hw/riscv/virt.c: Make block devices default to virtio
PATCH 1/1 hw/riscv/virt.c: Make block devices default to virtio
RISC-V virt is currently missing default type for block devices. Without this being set, proper backend is not created when option like -cdrom is used. So, make the virt board's default block device type be IF_VIRTIO similar to other architectures.
We also need to set no_cdrom to avoid getting a default cdrom device.
--- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+)
hw/riscv/virt.c +2 -0
@@ -1764,6 +1764,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->init = virt_machine_init; mc->max_cpus =VIRT_CPUS_MAX ; mc->default_cpu_type =TYPE_RISCV_CPU_BASE ; + mc->block_default_type =IF_VIRTIO ; + mc->no_cdrom =1 ; mc->pci_allow_0_address = true; mc->possible_cpu_arch_ids = riscv_numa_possible_cpu_arch_ids; mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props;
Signature · 1 line
2.34.1
Quoted 9 lines · Sunil V L
RISC-V virt is currently missing default type for block devices. Without this being set, proper backend is not created when option like -cdrom is used. So, make the virt board's default block device type be
IF_VIRTIOsimilar to other architectures.We also need to set
no_cdromto avoid getting a default cdrom device.Signed-off-by Sunil V L <[email protected]>---
Quoted 16 lines
hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+)hw/riscv/virt.c +2
-0@@ -1764,6 +1764,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->init = virt_machine_init; mc->max_cpus =VIRT_CPUS_MAX ; mc->default_cpu_type =TYPE_RISCV_CPU_BASE ; + mc->block_default_type =IF_VIRTIO ; + mc->no_cdrom =1 ; mc->pci_allow_0_address = true; mc->possible_cpu_arch_ids = riscv_numa_possible_cpu_arch_ids; mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props;
Quoted 9 lines · Sunil V L
RISC-V virt is currently missing default type for block devices. Without this being set, proper backend is not created when option like -cdrom is used. So, make the virt board's default block device type be
IF_VIRTIOsimilar to other architectures.We also need to set
no_cdromto avoid getting a default cdrom device.Signed-off-by Sunil V L <[email protected]>
Alistair
Quoted 21 lines
--- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+)hw/riscv/virt.c +2
-1@@ -1764,6 +1764,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->init = virt_machine_init; mc->max_cpus =VIRT_CPUS_MAX ; mc->default_cpu_type =TYPE_RISCV_CPU_BASE ; + mc->block_default_type =IF_VIRTIO ; + mc->no_cdrom =1 ; mc->pci_allow_0_address = true; mc->possible_cpu_arch_ids = riscv_numa_possible_cpu_arch_ids; mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; --2.34.1
Alistair Francis
AppliedQuoted 9 lines · Sunil V L
RISC-V virt is currently missing default type for block devices. Without this being set, proper backend is not created when option like -cdrom is used. So, make the virt board's default block device type be
IF_VIRTIOsimilar to other architectures.We also need to set
no_cdromto avoid getting a default cdrom device.Signed-off-by Sunil V L <[email protected]>
Thanks!
Applied to riscv-to-apply.next
Alistair
Quoted 21 lines
--- hw/riscv/virt.c | 2 ++ 1 file changed, 2 insertions(+)hw/riscv/virt.c +2
-1@@ -1764,6 +1764,8 @@ static void virt_machine_class_init(ObjectClass *oc, void *data) mc->init = virt_machine_init; mc->max_cpus =VIRT_CPUS_MAX ; mc->default_cpu_type =TYPE_RISCV_CPU_BASE ; + mc->block_default_type =IF_VIRTIO ; + mc->no_cdrom =1 ; mc->pci_allow_0_address = true; mc->possible_cpu_arch_ids = riscv_numa_possible_cpu_arch_ids; mc->cpu_index_to_instance_props = riscv_numa_cpu_index_to_props; --2.34.1