riscv: QEMU RISC-V IOMMU Support
Subsystems (2)
v4 cover riscv: QEMU RISC-V IOMMU Support
Hi,
This new version contains changes based on suggestions made during the v3 review [1]. Most notable changes:
- read/write locks were added in both ctx_lock and iot_lock. This code was picked from Tomasz branch;
- a new riscv_iommu_validate_process_ctx() helper was added to make process-context validations. Suggested by Jason Chien;
- a new doc patch was added to document how the IOMMU can be used by the 'virt' RISC-V board. Suggested by Alistair.
Patches based on alistair/riscv-to-apply.next. It's also applicable on master.
Patches missing reviews/acks: 3, 9, 14
* How it was tested *
This series was tested using an emulated QEMU RISC-V host booting a QEMU KVM guest, passing through an emulated e1000 network card from the host to the guest.
The Linux kernel used for tests can be found here:
https://github.com/tjeznach/linux/tree/riscv_iommu_v6-rc3
Changes from v3:
- patch 3:
- added FCTL_BE and FCTL_WSI bits to regs_ro[] mask
- renamed 'ctx->pasid' to 'ctx->process_id'
- added device translation cache update lock ctx_lock
- DC.tc.V == 0 is now checked before riscv_iommu_validate_device_ctx()
- PC.ta.V == 0 now issues a "PDT entry not valid" error in the end of riscv_iommu_validate_device_ctx()
- added a new riscv_iommu_validate_process_ctx() helper to validate PC
as section 2.2.4 dictates
- patch 5:
- added RISCV_PCI_CLASS_SYSTEM_IOMMU macro and use it in k->class_id
- patch 8:
- added update lock iot_lock
- patch 9:
- added FSC related checks to riscv_iommu_validate_process_ctx()
- moved 'if (mode == bare)' check to happen after ctx->process_id ==
noprocid check
- patch 14 (new):
- add riscv-iommu docs for more information on how to use the
riscv-iommu-pci device
- v3 link: https://lore.kernel.org/qemu-riscv/[email protected]/
[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Andrew Jones (1):
hw/riscv/riscv-iommu: Add another irq for mrif notifications
Daniel Henrique Barboza (4):
pci-ids.rst: add Red Hat pci-id for RISC-V IOMMU device test/qtest: add riscv-iommu-pci tests qtest/riscv-iommu-test: add init queues test docs/specs: add riscv-iommu
Tomasz Jeznach (9):
exec/memtxattr: add process identifier to the transaction attributes hw/riscv: add riscv-iommu-bits.h
hw/riscv: add RISC-V IOMMU base emulation
hw/riscv: add riscv-iommu-pci reference device hw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug hw/riscv/riscv-iommu: add Address Translation Cache (IOATC) hw/riscv/riscv-iommu: add s-stage and g-stage support hw/riscv/riscv-iommu: add ATS support hw/riscv/riscv-iommu: add DBG support
docs/specs/index.rst | 1 + docs/specs/pci-ids.rst | 2 + docs/specs/riscv-iommu.rst | 55 + docs/system/riscv/virt.rst | 13 + hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/riscv/riscv-iommu-bits.h | 419 ++++++ hw/riscv/riscv-iommu-pci.c | 178 +++ hw/riscv/riscv-iommu.c | 2372 ++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 148 ++ hw/riscv/trace-events | 15 + hw/riscv/trace.h | 1 + hw/riscv/virt.c | 33 +- include/exec/memattrs.h | 5 + include/hw/pci/pci.h | 1 + include/hw/riscv/iommu.h | 36 + meson.build | 1 + tests/qtest/libqos/meson.build | 4 + tests/qtest/libqos/riscv-iommu.c | 76 + tests/qtest/libqos/riscv-iommu.h | 100 ++ tests/qtest/meson.build | 1 + tests/qtest/riscv-iommu-test.c | 234 +++ 22 files changed, 3699 insertions(+), 1 deletion(-) create mode 100644 docs/specs/riscv-iommu.rst create mode 100644 hw/riscv/riscv-iommu-bits.h create mode 100644 hw/riscv/riscv-iommu-pci.c create mode 100644 hw/riscv/riscv-iommu.c create mode 100644 hw/riscv/riscv-iommu.h create mode 100644 hw/riscv/trace-events create mode 100644 hw/riscv/trace.h create mode 100644 include/hw/riscv/iommu.h create mode 100644 tests/qtest/libqos/riscv-iommu.c create mode 100644 tests/qtest/libqos/riscv-iommu.h create mode 100644 tests/qtest/riscv-iommu-test.c
Signature · 1 line
2.45.2
PATCH v4 1/14 exec/memtxattr: add process identifier to the transaction attributes
From: Tomasz Jeznach <[email protected]>
Extend memory transaction attributes with process identifier to allow per-request address translation logic to use requester_id / process_id to identify memory mapping (e.g. enabling IOMMU w/ PASID translations).
--- include/exec/memattrs.h | 5 +++++ 1 file changed, 5 insertions(+)
include/exec/memattrs.h +5 -0
@@ -52,6 +52,11 @@ typedef struct MemTxAttrs { unsigned int memory:1;/* Requester ID (for MSI for example) */ unsigned int requester_id:16; + +/* +* PCI PASID support: Limited to 8 bits process identifier. +*/ + unsigned int pasid:8; } MemTxAttrs;/* Bus masters which don't specify any attributes will get this,
Signature · 1 line
2.45.2
Re: [PATCH v4 01/14] exec/memtxattr: add process identifier to the transaction attributes
Quoted 9 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
Extend memory transaction attributes with process identifier to allow per-request address translation logic to use
requester_id/process_idto identify memory mapping (e.g. enabling IOMMU w/ PASID translations).Signed-off-by Tomasz Jeznach <[email protected]>Reviewed-by Frank Chang <[email protected]>
Alistair
Quoted 24 lines
--- include/exec/memattrs.h | 5 +++++ 1 file changed, 5 insertions(+)include/exec/memattrs.h +5
-1@@ -52,6 +52,11 @@ typedef struct MemTxAttrs { unsigned int memory:1;/* Requester ID (for MSI for example) */ unsigned int requester_id:16; + +/* +* PCI PASID support: Limited to 8 bits process identifier. +*/ + unsigned int pasid:8; } MemTxAttrs;/* Bus masters which don't specify any attributes will get this, -- 2.45.2
Re: [PATCH v4 01/14] exec/memtxattr: add process identifier to the transaction attributes
In reply to Daniel Henrique BarbozaQuoted 28 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
Extend memory transaction attributes with process identifier to allow per-request address translation logic to use
requester_id/process_idto identify memory mapping (e.g. enabling IOMMU w/ PASID translations).Signed-off-by Tomasz Jeznach <[email protected]>Reviewed-by Frank Chang <[email protected]>--- include/exec/memattrs.h | 5 +++++ 1 file changed, 5 insertions(+)include/exec/memattrs.h +5
-0@@ -52,6 +52,11 @@ typedef struct MemTxAttrs { unsigned int memory:1;/* Requester ID (for MSI for example) */ unsigned int requester_id:16; + +/* +* PCI PASID support: Limited to 8 bits process identifier. +*/ + unsigned int pasid:8; } MemTxAttrs;/* Bus masters which don't specify any attributes will get this,
PATCH v4 2/14 hw/riscv: add riscv-iommu-bits.h
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
This header will be used by the RISC-V IOMMU emulation to be added in the next patch. Due to its size it's being sent in separate for an easier review.
One thing to notice is that this header can be replaced by the future Linux RISC-V IOMMU driver header, which would become a linux-header we would import instead of keeping our own. The Linux implementation isn't upstream yet so for now we'll have to manage riscv-iommu-bits.h.
--- hw/riscv/riscv-iommu-bits.h | 347 ++++++++++++++++++++++++++++++++++++ 1 file changed, 347 insertions(+) create mode 100644 hw/riscv/riscv-iommu-bits.h
hw/riscv/riscv-iommu-bits.h new file +347 -0
@@ -0,0 +1,347 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright © 2022-2023 Rivos Inc. +* Copyright © 2023 FORTH-ICS/CARV +* Copyright © 2023 RISC-V IOMMU Task Group +* +* RISC-V IOMMU - Register Layout and Data Structures. +* +* Based on the IOMMU spec version 1.0, 3/2023 +* https://github.com/riscv-non-isa/riscv-iommu +*/ + +#ifndef HW_RISCV_IOMMU_BITS_H +#define HW_RISCV_IOMMU_BITS_H + +#include "qemu/osdep.h" + +#define RISCV_IOMMU_SPEC_DOT_VER 0x010 + +#ifndef GENMASK_ULL +#define GENMASK_ULL (h, l) (((~0ULL) >> (63 - (h) + (l))) << (l)) +#endif + +/* +* struct riscv_iommu_fq_record - Fault/Event Queue Record +* See section 3.2 for more info. +*/ +struct riscv_iommu_fq_record { +uint64_t hdr; +uint64_t _reserved; +uint64_t iotval; +uint64_t iotval2; +}; +/* Header fields */ +#define RISCV_IOMMU_FQ_HDR_CAUSE GENMASK_ULL(11, 0) +#define RISCV_IOMMU_FQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_FQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_FQ_HDR_TTYPE GENMASK_ULL(39, 34) +#define RISCV_IOMMU_FQ_HDR_DID GENMASK_ULL(63, 40) + +/* +* struct riscv_iommu_pq_record - PCIe Page Request record +* For more infos on the PCIe Page Request queue see chapter 3.3. +*/ +struct riscv_iommu_pq_record { +uint64_t hdr; +uint64_t payload; +}; +/* Header fields */ +#define RISCV_IOMMU_PREQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_PREQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) +#define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) +#define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) +/* Payload fields */ +#define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) + +/* Common field positions */ +#define RISCV_IOMMU_PPN_FIELD GENMASK_ULL(53, 10) +#define RISCV_IOMMU_QUEUE_LOGSZ_FIELD GENMASK_ULL(4, 0) +#define RISCV_IOMMU_QUEUE_INDEX_FIELD GENMASK_ULL(31, 0) +#define RISCV_IOMMU_QUEUE_ENABLE BIT(0) +#define RISCV_IOMMU_QUEUE_INTR_ENABLE BIT(1) +#define RISCV_IOMMU_QUEUE_MEM_FAULT BIT(8) +#define RISCV_IOMMU_QUEUE_OVERFLOW BIT(9) +#define RISCV_IOMMU_QUEUE_ACTIVE BIT(16) +#define RISCV_IOMMU_QUEUE_BUSY BIT(17) +#define RISCV_IOMMU_ATP_PPN_FIELD GENMASK_ULL(43, 0) +#define RISCV_IOMMU_ATP_MODE_FIELD GENMASK_ULL(63, 60) + +/* 5.3 IOMMU Capabilities (64bits) */ +#define RISCV_IOMMU_REG_CAP 0x0000 +#define RISCV_IOMMU_CAP_VERSION GENMASK_ULL(7, 0) +#define RISCV_IOMMU_CAP_MSI_FLAT BIT_ULL(22) +#define RISCV_IOMMU_CAP_MSI_MRIF BIT_ULL(23) +#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26) +#define RISCV_IOMMU_CAP_IGS GENMASK_ULL(29, 28) +#define RISCV_IOMMU_CAP_PAS GENMASK_ULL(37, 32) +#define RISCV_IOMMU_CAP_PD8 BIT_ULL(38) +#define RISCV_IOMMU_CAP_PD17 BIT_ULL(39) +#define RISCV_IOMMU_CAP_PD20 BIT_ULL(40) + +/* 5.4 Features control register (32bits) */ +#define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_WSI BIT(1) + +/* 5.5 Device-directory-table pointer (64bits) */ +#define RISCV_IOMMU_REG_DDTP 0x0010 +#define RISCV_IOMMU_DDTP_MODE GENMASK_ULL(3, 0) +#define RISCV_IOMMU_DDTP_BUSY BIT_ULL(4) +#define RISCV_IOMMU_DDTP_PPN RISCV_IOMMU_PPN_FIELD + +enum riscv_iommu_ddtp_modes { +RISCV_IOMMU_DDTP_MODE_OFF =0 , +RISCV_IOMMU_DDTP_MODE_BARE =1 , +RISCV_IOMMU_DDTP_MODE_1LVL =2 , +RISCV_IOMMU_DDTP_MODE_2LVL =3 , +RISCV_IOMMU_DDTP_MODE_3LVL =4 , +RISCV_IOMMU_DDTP_MODE_MAX =4 +}; + +/* 5.6 Command Queue Base (64bits) */ +#define RISCV_IOMMU_REG_CQB 0x0018 +#define RISCV_IOMMU_CQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_CQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.7 Command Queue head (32bits) */ +#define RISCV_IOMMU_REG_CQH 0x0020 + +/* 5.8 Command Queue tail (32bits) */ +#define RISCV_IOMMU_REG_CQT 0x0024 + +/* 5.9 Fault Queue Base (64bits) */ +#define RISCV_IOMMU_REG_FQB 0x0028 +#define RISCV_IOMMU_FQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_FQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.10 Fault Queue Head (32bits) */ +#define RISCV_IOMMU_REG_FQH 0x0030 + +/* 5.11 Fault Queue tail (32bits) */ +#define RISCV_IOMMU_REG_FQT 0x0034 + +/* 5.12 Page Request Queue base (64bits) */ +#define RISCV_IOMMU_REG_PQB 0x0038 +#define RISCV_IOMMU_PQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_PQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.13 Page Request Queue head (32bits) */ +#define RISCV_IOMMU_REG_PQH 0x0040 + +/* 5.14 Page Request Queue tail (32bits) */ +#define RISCV_IOMMU_REG_PQT 0x0044 + +/* 5.15 Command Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_CQCSR 0x0048 +#define RISCV_IOMMU_CQCSR_CQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_CQCSR_CIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_CQCSR_CQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_CQCSR_CMD_TO BIT(9) +#define RISCV_IOMMU_CQCSR_CMD_ILL BIT(10) +#define RISCV_IOMMU_CQCSR_FENCE_W_IP BIT(11) +#define RISCV_IOMMU_CQCSR_CQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_CQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.16 Fault Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_FQCSR 0x004C +#define RISCV_IOMMU_FQCSR_FQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_FQCSR_FIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_FQCSR_FQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_FQCSR_FQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_FQCSR_FQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_FQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.17 Page Request Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_PQCSR 0x0050 +#define RISCV_IOMMU_PQCSR_PQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_PQCSR_PIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_PQCSR_PQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_PQCSR_PQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_PQCSR_PQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_PQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.18 Interrupt Pending Status (32bits) */ +#define RISCV_IOMMU_REG_IPSR 0x0054 +#define RISCV_IOMMU_IPSR_CIP BIT(0) +#define RISCV_IOMMU_IPSR_FIP BIT(1) +#define RISCV_IOMMU_IPSR_PIP BIT(3) + +enum { +RISCV_IOMMU_INTR_CQ , +RISCV_IOMMU_INTR_FQ , +RISCV_IOMMU_INTR_PM , +RISCV_IOMMU_INTR_PQ , +RISCV_IOMMU_INTR_COUNT +}; + +/* 5.27 Interrupt cause to vector (64bits) */ +#define RISCV_IOMMU_REG_IVEC 0x02F8 + +/* 5.28 MSI Configuration table (32 * 64bits) */ +#define RISCV_IOMMU_REG_MSI_CONFIG 0x0300 + +#define RISCV_IOMMU_REG_SIZE 0x1000 + +#define RISCV_IOMMU_DDTE_VALID BIT_ULL(0) +#define RISCV_IOMMU_DDTE_PPN RISCV_IOMMU_PPN_FIELD + +/* Struct riscv_iommu_dc - Device Context - section 2.1 */ +struct riscv_iommu_dc { +uint64_t tc; +uint64_t iohgatp; +uint64_t ta; +uint64_t fsc; +uint64_t msiptp; +uint64_t msi_addr_mask; +uint64_t msi_addr_pattern; +uint64_t _reserved; +}; + +/* Translation control fields */ +#define RISCV_IOMMU_DC_TC_V BIT_ULL(0) +#define RISCV_IOMMU_DC_TC_EN_PRI BIT_ULL(2) +#define RISCV_IOMMU_DC_TC_T2GPA BIT_ULL(3) +#define RISCV_IOMMU_DC_TC_DTF BIT_ULL(4) +#define RISCV_IOMMU_DC_TC_PDTV BIT_ULL(5) +#define RISCV_IOMMU_DC_TC_PRPR BIT_ULL(6) +#define RISCV_IOMMU_DC_TC_DPE BIT_ULL(9) +#define RISCV_IOMMU_DC_TC_SBE BIT_ULL(10) +#define RISCV_IOMMU_DC_TC_SXL BIT_ULL(11) + +/* Second-stage (aka G-stage) context fields */ +#define RISCV_IOMMU_DC_IOHGATP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_IOHGATP_GSCID GENMASK_ULL(59, 44) +#define RISCV_IOMMU_DC_IOHGATP_MODE RISCV_IOMMU_ATP_MODE_FIELD + +enum riscv_iommu_dc_iohgatp_modes { +RISCV_IOMMU_DC_IOHGATP_MODE_BARE =0 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV32X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV39X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV48X4 =9 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV57X4 =10 +}; + +/* Translation attributes fields */ +#define RISCV_IOMMU_DC_TA_PSCID GENMASK_ULL(31, 12) + +/* First-stage context fields */ +#define RISCV_IOMMU_DC_FSC_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_FSC_MODE RISCV_IOMMU_ATP_MODE_FIELD + +/* Generic I/O MMU command structure - check section 3.1 */ +struct riscv_iommu_command { +uint64_t dword0; +uint64_t dword1; +}; + +#define RISCV_IOMMU_CMD_OPCODE GENMASK_ULL(6, 0) +#define RISCV_IOMMU_CMD_FUNC GENMASK_ULL(9, 7) + +#define RISCV_IOMMU_CMD_IOTINVAL_OPCODE 1 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA 0 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_GVMA 1 +#define RISCV_IOMMU_CMD_IOTINVAL_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCV BIT_ULL(32) +#define RISCV_IOMMU_CMD_IOTINVAL_GV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IOTINVAL_GSCID GENMASK_ULL(59, 44) + +#define RISCV_IOMMU_CMD_IOFENCE_OPCODE 2 +#define RISCV_IOMMU_CMD_IOFENCE_FUNC_C 0 +#define RISCV_IOMMU_CMD_IOFENCE_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOFENCE_DATA GENMASK_ULL(63, 32) + +#define RISCV_IOMMU_CMD_IODIR_OPCODE 3 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT 0 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT 1 +#define RISCV_IOMMU_CMD_IODIR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IODIR_DV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IODIR_DID GENMASK_ULL(63, 40) + +enum riscv_iommu_dc_fsc_atp_modes { +RISCV_IOMMU_DC_FSC_MODE_BARE =0 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV39 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV48 =9 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV57 =10 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD8 =1 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD17 =2 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD20 =3 +}; + +enum riscv_iommu_fq_causes { +RISCV_IOMMU_FQ_CAUSE_INST_FAULT =1 , +RISCV_IOMMU_FQ_CAUSE_RD_ADDR_MISALIGNED =4 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT =5 , +RISCV_IOMMU_FQ_CAUSE_WR_ADDR_MISALIGNED =6 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT =7 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_S =12 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_S =13 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_S =15 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_VS =20 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_VS =21 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_VS =23 , +RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED =256 , +RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT =257 , +RISCV_IOMMU_FQ_CAUSE_DDT_INVALID =258 , +RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED =259 , +RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED =260 , +RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT =261 , +RISCV_IOMMU_FQ_CAUSE_MSI_INVALID =262 , +RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED =263 , +RISCV_IOMMU_FQ_CAUSE_MRIF_FAULT =264 , +RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT =265 , +RISCV_IOMMU_FQ_CAUSE_PDT_INVALID =266 , +RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED =267 , +RISCV_IOMMU_FQ_CAUSE_DDT_CORRUPTED =268 , +RISCV_IOMMU_FQ_CAUSE_PDT_CORRUPTED =269 , +RISCV_IOMMU_FQ_CAUSE_MSI_PT_CORRUPTED =270 , +RISCV_IOMMU_FQ_CAUSE_MRIF_CORRUIPTED =271 , +RISCV_IOMMU_FQ_CAUSE_INTERNAL_DP_ERROR =272 , +RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT =273 , +RISCV_IOMMU_FQ_CAUSE_PT_CORRUPTED =274 +}; + +/* MSI page table pointer */ +#define RISCV_IOMMU_DC_MSIPTP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE RISCV_IOMMU_ATP_MODE_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE_OFF 0 +#define RISCV_IOMMU_DC_MSIPTP_MODE_FLAT 1 + +/* Translation attributes fields */ +#define RISCV_IOMMU_PC_TA_V BIT_ULL(0) + +/* First stage context fields */ +#define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0) + +enum riscv_iommu_fq_ttypes { +RISCV_IOMMU_FQ_TTYPE_NONE =0 , +RISCV_IOMMU_FQ_TTYPE_UADDR_INST_FETCH =1 , +RISCV_IOMMU_FQ_TTYPE_UADDR_RD =2 , +RISCV_IOMMU_FQ_TTYPE_UADDR_WR =3 , +RISCV_IOMMU_FQ_TTYPE_TADDR_INST_FETCH =5 , +RISCV_IOMMU_FQ_TTYPE_TADDR_RD =6 , +RISCV_IOMMU_FQ_TTYPE_TADDR_WR =7 , +RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ =8 , +}; + +/* Fields on pte */ +#define RISCV_IOMMU_MSI_PTE_V BIT_ULL(0) +#define RISCV_IOMMU_MSI_PTE_M GENMASK_ULL(2, 1) + +#define RISCV_IOMMU_MSI_PTE_M_MRIF 1 +#define RISCV_IOMMU_MSI_PTE_M_BASIC 3 + +/* When M == 1 (MRIF mode) */ +#define RISCV_IOMMU_MSI_PTE_MRIF_ADDR GENMASK_ULL(53, 7) +/* When M == 3 (basic mode) */ +#define RISCV_IOMMU_MSI_PTE_PPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_PTE_C BIT_ULL(63) + +/* Fields on mrif_info */ +#define RISCV_IOMMU_MSI_MRIF_NID GENMASK_ULL(9, 0) +#define RISCV_IOMMU_MSI_MRIF_NPPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_MRIF_NID_MSB BIT_ULL(60) + +#endif /* _RISCV_IOMMU_BITS_H_ */
Signature · 1 line
2.45.2
Re: [PATCH v4 02/14] hw/riscv: add riscv-iommu-bits.h
Quoted 32 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
This header will be used by the RISC-V IOMMU emulation to be added in the next patch. Due to its size it's being sent in separate for an easier review.
One thing to notice is that this header can be replaced by the future Linux RISC-V IOMMU driver header, which would become a linux-header we would import instead of keeping our own. The Linux implementation isn't upstream yet so for now we'll have to manage
riscv-iommu-bits.h.Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>Reviewed-by Frank Chang <[email protected]>--- hw/riscv/riscv-iommu-bits.h | 347 ++++++++++++++++++++++++++++++++++++ 1 file changed, 347 insertions(+) create mode 100644 hw/riscv/riscv-iommu-bits.hhw/riscv/riscv-iommu-bits.h new file +6
-0@@ -0,0 +1,347 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright © 2022-2023 Rivos Inc. +* Copyright © 2023 FORTH-ICS/CARV +* Copyright © 2023 RISC-V IOMMU Task Group +*
hw/riscv/riscv-iommu-bits.h line 16
Quoted 10 lines
hw/riscv/riscv-iommu-bits.h new file +10
-0+* RISC-V IOMMU - Register Layout and Data Structures. +* +* Based on the IOMMU spec version 1.0, 3/2023 +* https://github.com/riscv-non-isa/riscv-iommu +*/ + +#ifndef HW_RISCV_IOMMU_BITS_H +#define HW_RISCV_IOMMU_BITS_H + +#include "qemu/osdep.h"
We shouldn't include osdep.h in header files
Alistair
Quoted 335 lines
hw/riscv/riscv-iommu-bits.h new file +331
-1+ +#define RISCV_IOMMU_SPEC_DOT_VER 0x010 + +#ifndef GENMASK_ULL +#define GENMASK_ULL (h, l) (((~0ULL) >> (63 - (h) + (l))) << (l)) +#endif + +/* +* struct riscv_iommu_fq_record - Fault/Event Queue Record +* See section 3.2 for more info. +*/ +struct riscv_iommu_fq_record { +uint64_t hdr; +uint64_t _reserved; +uint64_t iotval; +uint64_t iotval2; +}; +/* Header fields */ +#define RISCV_IOMMU_FQ_HDR_CAUSE GENMASK_ULL(11, 0) +#define RISCV_IOMMU_FQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_FQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_FQ_HDR_TTYPE GENMASK_ULL(39, 34) +#define RISCV_IOMMU_FQ_HDR_DID GENMASK_ULL(63, 40) + +/* +* struct riscv_iommu_pq_record - PCIe Page Request record +* For more infos on the PCIe Page Request queue see chapter 3.3. +*/ +struct riscv_iommu_pq_record { +uint64_t hdr; +uint64_t payload; +}; +/* Header fields */ +#define RISCV_IOMMU_PREQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_PREQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) +#define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) +#define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) +/* Payload fields */ +#define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) + +/* Common field positions */ +#define RISCV_IOMMU_PPN_FIELD GENMASK_ULL(53, 10) +#define RISCV_IOMMU_QUEUE_LOGSZ_FIELD GENMASK_ULL(4, 0) +#define RISCV_IOMMU_QUEUE_INDEX_FIELD GENMASK_ULL(31, 0) +#define RISCV_IOMMU_QUEUE_ENABLE BIT(0) +#define RISCV_IOMMU_QUEUE_INTR_ENABLE BIT(1) +#define RISCV_IOMMU_QUEUE_MEM_FAULT BIT(8) +#define RISCV_IOMMU_QUEUE_OVERFLOW BIT(9) +#define RISCV_IOMMU_QUEUE_ACTIVE BIT(16) +#define RISCV_IOMMU_QUEUE_BUSY BIT(17) +#define RISCV_IOMMU_ATP_PPN_FIELD GENMASK_ULL(43, 0) +#define RISCV_IOMMU_ATP_MODE_FIELD GENMASK_ULL(63, 60) + +/* 5.3 IOMMU Capabilities (64bits) */ +#define RISCV_IOMMU_REG_CAP 0x0000 +#define RISCV_IOMMU_CAP_VERSION GENMASK_ULL(7, 0) +#define RISCV_IOMMU_CAP_MSI_FLAT BIT_ULL(22) +#define RISCV_IOMMU_CAP_MSI_MRIF BIT_ULL(23) +#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26) +#define RISCV_IOMMU_CAP_IGS GENMASK_ULL(29, 28) +#define RISCV_IOMMU_CAP_PAS GENMASK_ULL(37, 32) +#define RISCV_IOMMU_CAP_PD8 BIT_ULL(38) +#define RISCV_IOMMU_CAP_PD17 BIT_ULL(39) +#define RISCV_IOMMU_CAP_PD20 BIT_ULL(40) + +/* 5.4 Features control register (32bits) */ +#define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_WSI BIT(1) + +/* 5.5 Device-directory-table pointer (64bits) */ +#define RISCV_IOMMU_REG_DDTP 0x0010 +#define RISCV_IOMMU_DDTP_MODE GENMASK_ULL(3, 0) +#define RISCV_IOMMU_DDTP_BUSY BIT_ULL(4) +#define RISCV_IOMMU_DDTP_PPN RISCV_IOMMU_PPN_FIELD + +enum riscv_iommu_ddtp_modes { +RISCV_IOMMU_DDTP_MODE_OFF =0 , +RISCV_IOMMU_DDTP_MODE_BARE =1 , +RISCV_IOMMU_DDTP_MODE_1LVL =2 , +RISCV_IOMMU_DDTP_MODE_2LVL =3 , +RISCV_IOMMU_DDTP_MODE_3LVL =4 , +RISCV_IOMMU_DDTP_MODE_MAX =4 +}; + +/* 5.6 Command Queue Base (64bits) */ +#define RISCV_IOMMU_REG_CQB 0x0018 +#define RISCV_IOMMU_CQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_CQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.7 Command Queue head (32bits) */ +#define RISCV_IOMMU_REG_CQH 0x0020 + +/* 5.8 Command Queue tail (32bits) */ +#define RISCV_IOMMU_REG_CQT 0x0024 + +/* 5.9 Fault Queue Base (64bits) */ +#define RISCV_IOMMU_REG_FQB 0x0028 +#define RISCV_IOMMU_FQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_FQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.10 Fault Queue Head (32bits) */ +#define RISCV_IOMMU_REG_FQH 0x0030 + +/* 5.11 Fault Queue tail (32bits) */ +#define RISCV_IOMMU_REG_FQT 0x0034 + +/* 5.12 Page Request Queue base (64bits) */ +#define RISCV_IOMMU_REG_PQB 0x0038 +#define RISCV_IOMMU_PQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_PQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.13 Page Request Queue head (32bits) */ +#define RISCV_IOMMU_REG_PQH 0x0040 + +/* 5.14 Page Request Queue tail (32bits) */ +#define RISCV_IOMMU_REG_PQT 0x0044 + +/* 5.15 Command Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_CQCSR 0x0048 +#define RISCV_IOMMU_CQCSR_CQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_CQCSR_CIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_CQCSR_CQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_CQCSR_CMD_TO BIT(9) +#define RISCV_IOMMU_CQCSR_CMD_ILL BIT(10) +#define RISCV_IOMMU_CQCSR_FENCE_W_IP BIT(11) +#define RISCV_IOMMU_CQCSR_CQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_CQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.16 Fault Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_FQCSR 0x004C +#define RISCV_IOMMU_FQCSR_FQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_FQCSR_FIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_FQCSR_FQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_FQCSR_FQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_FQCSR_FQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_FQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.17 Page Request Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_PQCSR 0x0050 +#define RISCV_IOMMU_PQCSR_PQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_PQCSR_PIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_PQCSR_PQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_PQCSR_PQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_PQCSR_PQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_PQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.18 Interrupt Pending Status (32bits) */ +#define RISCV_IOMMU_REG_IPSR 0x0054 +#define RISCV_IOMMU_IPSR_CIP BIT(0) +#define RISCV_IOMMU_IPSR_FIP BIT(1) +#define RISCV_IOMMU_IPSR_PIP BIT(3) + +enum { +RISCV_IOMMU_INTR_CQ , +RISCV_IOMMU_INTR_FQ , +RISCV_IOMMU_INTR_PM , +RISCV_IOMMU_INTR_PQ , +RISCV_IOMMU_INTR_COUNT +}; + +/* 5.27 Interrupt cause to vector (64bits) */ +#define RISCV_IOMMU_REG_IVEC 0x02F8 + +/* 5.28 MSI Configuration table (32 * 64bits) */ +#define RISCV_IOMMU_REG_MSI_CONFIG 0x0300 + +#define RISCV_IOMMU_REG_SIZE 0x1000 + +#define RISCV_IOMMU_DDTE_VALID BIT_ULL(0) +#define RISCV_IOMMU_DDTE_PPN RISCV_IOMMU_PPN_FIELD + +/* Struct riscv_iommu_dc - Device Context - section 2.1 */ +struct riscv_iommu_dc { +uint64_t tc; +uint64_t iohgatp; +uint64_t ta; +uint64_t fsc; +uint64_t msiptp; +uint64_t msi_addr_mask; +uint64_t msi_addr_pattern; +uint64_t _reserved; +}; + +/* Translation control fields */ +#define RISCV_IOMMU_DC_TC_V BIT_ULL(0) +#define RISCV_IOMMU_DC_TC_EN_PRI BIT_ULL(2) +#define RISCV_IOMMU_DC_TC_T2GPA BIT_ULL(3) +#define RISCV_IOMMU_DC_TC_DTF BIT_ULL(4) +#define RISCV_IOMMU_DC_TC_PDTV BIT_ULL(5) +#define RISCV_IOMMU_DC_TC_PRPR BIT_ULL(6) +#define RISCV_IOMMU_DC_TC_DPE BIT_ULL(9) +#define RISCV_IOMMU_DC_TC_SBE BIT_ULL(10) +#define RISCV_IOMMU_DC_TC_SXL BIT_ULL(11) + +/* Second-stage (aka G-stage) context fields */ +#define RISCV_IOMMU_DC_IOHGATP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_IOHGATP_GSCID GENMASK_ULL(59, 44) +#define RISCV_IOMMU_DC_IOHGATP_MODE RISCV_IOMMU_ATP_MODE_FIELD + +enum riscv_iommu_dc_iohgatp_modes { +RISCV_IOMMU_DC_IOHGATP_MODE_BARE =0 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV32X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV39X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV48X4 =9 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV57X4 =10 +}; + +/* Translation attributes fields */ +#define RISCV_IOMMU_DC_TA_PSCID GENMASK_ULL(31, 12) + +/* First-stage context fields */ +#define RISCV_IOMMU_DC_FSC_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_FSC_MODE RISCV_IOMMU_ATP_MODE_FIELD + +/* Generic I/O MMU command structure - check section 3.1 */ +struct riscv_iommu_command { +uint64_t dword0; +uint64_t dword1; +}; + +#define RISCV_IOMMU_CMD_OPCODE GENMASK_ULL(6, 0) +#define RISCV_IOMMU_CMD_FUNC GENMASK_ULL(9, 7) + +#define RISCV_IOMMU_CMD_IOTINVAL_OPCODE 1 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA 0 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_GVMA 1 +#define RISCV_IOMMU_CMD_IOTINVAL_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCV BIT_ULL(32) +#define RISCV_IOMMU_CMD_IOTINVAL_GV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IOTINVAL_GSCID GENMASK_ULL(59, 44) + +#define RISCV_IOMMU_CMD_IOFENCE_OPCODE 2 +#define RISCV_IOMMU_CMD_IOFENCE_FUNC_C 0 +#define RISCV_IOMMU_CMD_IOFENCE_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOFENCE_DATA GENMASK_ULL(63, 32) + +#define RISCV_IOMMU_CMD_IODIR_OPCODE 3 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT 0 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT 1 +#define RISCV_IOMMU_CMD_IODIR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IODIR_DV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IODIR_DID GENMASK_ULL(63, 40) + +enum riscv_iommu_dc_fsc_atp_modes { +RISCV_IOMMU_DC_FSC_MODE_BARE =0 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV39 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV48 =9 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV57 =10 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD8 =1 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD17 =2 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD20 =3 +}; + +enum riscv_iommu_fq_causes { +RISCV_IOMMU_FQ_CAUSE_INST_FAULT =1 , +RISCV_IOMMU_FQ_CAUSE_RD_ADDR_MISALIGNED =4 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT =5 , +RISCV_IOMMU_FQ_CAUSE_WR_ADDR_MISALIGNED =6 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT =7 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_S =12 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_S =13 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_S =15 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_VS =20 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_VS =21 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_VS =23 , +RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED =256 , +RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT =257 , +RISCV_IOMMU_FQ_CAUSE_DDT_INVALID =258 , +RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED =259 , +RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED =260 , +RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT =261 , +RISCV_IOMMU_FQ_CAUSE_MSI_INVALID =262 , +RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED =263 , +RISCV_IOMMU_FQ_CAUSE_MRIF_FAULT =264 , +RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT =265 , +RISCV_IOMMU_FQ_CAUSE_PDT_INVALID =266 , +RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED =267 , +RISCV_IOMMU_FQ_CAUSE_DDT_CORRUPTED =268 , +RISCV_IOMMU_FQ_CAUSE_PDT_CORRUPTED =269 , +RISCV_IOMMU_FQ_CAUSE_MSI_PT_CORRUPTED =270 , +RISCV_IOMMU_FQ_CAUSE_MRIF_CORRUIPTED =271 , +RISCV_IOMMU_FQ_CAUSE_INTERNAL_DP_ERROR =272 , +RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT =273 , +RISCV_IOMMU_FQ_CAUSE_PT_CORRUPTED =274 +}; + +/* MSI page table pointer */ +#define RISCV_IOMMU_DC_MSIPTP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE RISCV_IOMMU_ATP_MODE_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE_OFF 0 +#define RISCV_IOMMU_DC_MSIPTP_MODE_FLAT 1 + +/* Translation attributes fields */ +#define RISCV_IOMMU_PC_TA_V BIT_ULL(0) + +/* First stage context fields */ +#define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0) + +enum riscv_iommu_fq_ttypes { +RISCV_IOMMU_FQ_TTYPE_NONE =0 , +RISCV_IOMMU_FQ_TTYPE_UADDR_INST_FETCH =1 , +RISCV_IOMMU_FQ_TTYPE_UADDR_RD =2 , +RISCV_IOMMU_FQ_TTYPE_UADDR_WR =3 , +RISCV_IOMMU_FQ_TTYPE_TADDR_INST_FETCH =5 , +RISCV_IOMMU_FQ_TTYPE_TADDR_RD =6 , +RISCV_IOMMU_FQ_TTYPE_TADDR_WR =7 , +RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ =8 , +}; + +/* Fields on pte */ +#define RISCV_IOMMU_MSI_PTE_V BIT_ULL(0) +#define RISCV_IOMMU_MSI_PTE_M GENMASK_ULL(2, 1) + +#define RISCV_IOMMU_MSI_PTE_M_MRIF 1 +#define RISCV_IOMMU_MSI_PTE_M_BASIC 3 + +/* When M == 1 (MRIF mode) */ +#define RISCV_IOMMU_MSI_PTE_MRIF_ADDR GENMASK_ULL(53, 7) +/* When M == 3 (basic mode) */ +#define RISCV_IOMMU_MSI_PTE_PPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_PTE_C BIT_ULL(63) + +/* Fields on mrif_info */ +#define RISCV_IOMMU_MSI_MRIF_NID GENMASK_ULL(9, 0) +#define RISCV_IOMMU_MSI_MRIF_NPPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_MRIF_NID_MSB BIT_ULL(60) + +#endif /* _RISCV_IOMMU_BITS_H_ */ --2.45.2
Re: [PATCH v4 02/14] hw/riscv: add riscv-iommu-bits.h
Quoted 38 lines · Alistair Francis
Quoted 36 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
This header will be used by the RISC-V IOMMU emulation to be added in the next patch. Due to its size it's being sent in separate for an easier review.
One thing to notice is that this header can be replaced by the future Linux RISC-V IOMMU driver header, which would become a linux-header we would import instead of keeping our own. The Linux implementation isn't upstream yet so for now we'll have to manage
riscv-iommu-bits.h.Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>Reviewed-by Frank Chang <[email protected]>--- hw/riscv/riscv-iommu-bits.h | 347 ++++++++++++++++++++++++++++++++++++ 1 file changed, 347 insertions(+)create mode 100644
hw/riscv/riscv-iommu-bits.hhw/riscv/riscv-iommu-bits.h new file +10
-0@@ -0,0 +1,347 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* +* Copyright © 2022-2023 Rivos Inc. +* Copyright © 2023 FORTH-ICS/CARV +* Copyright © 2023 RISC-V IOMMU Task Group +* +* RISC-V IOMMU - Register Layout and Data Structures. +* +* Based on the IOMMU spec version 1.0, 3/2023 +* https://github.com/riscv-non-isa/riscv-iommu
Quoted 8 lines
hw/riscv/riscv-iommu-bits.h line 16
Quoted 6 lines
hw/riscv/riscv-iommu-bits.h new file +6
-0+*/ + +#ifndef HW_RISCV_IOMMU_BITS_H +#define HW_RISCV_IOMMU_BITS_H + +#include "qemu/osdep.h" We shouldn't include
osdep.hin header files
Ooops. I'll remove it in v5.
Thanks,
Daniel
Quoted 338 lines
Alistair
Quoted 335 lines
hw/riscv/riscv-iommu-bits.h new file +331
-1+ +#define RISCV_IOMMU_SPEC_DOT_VER 0x010 + +#ifndef GENMASK_ULL +#define GENMASK_ULL (h, l) (((~0ULL) >> (63 - (h) + (l))) << (l)) +#endif + +/* +* struct riscv_iommu_fq_record - Fault/Event Queue Record +* See section 3.2 for more info. +*/ +struct riscv_iommu_fq_record { +uint64_t hdr; +uint64_t _reserved; +uint64_t iotval; +uint64_t iotval2; +}; +/* Header fields */ +#define RISCV_IOMMU_FQ_HDR_CAUSE GENMASK_ULL(11, 0) +#define RISCV_IOMMU_FQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_FQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_FQ_HDR_TTYPE GENMASK_ULL(39, 34) +#define RISCV_IOMMU_FQ_HDR_DID GENMASK_ULL(63, 40) + +/* +* struct riscv_iommu_pq_record - PCIe Page Request record +* For more infos on the PCIe Page Request queue see chapter 3.3. +*/ +struct riscv_iommu_pq_record { +uint64_t hdr; +uint64_t payload; +}; +/* Header fields */ +#define RISCV_IOMMU_PREQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_PREQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) +#define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) +#define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) +/* Payload fields */ +#define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) + +/* Common field positions */ +#define RISCV_IOMMU_PPN_FIELD GENMASK_ULL(53, 10) +#define RISCV_IOMMU_QUEUE_LOGSZ_FIELD GENMASK_ULL(4, 0) +#define RISCV_IOMMU_QUEUE_INDEX_FIELD GENMASK_ULL(31, 0) +#define RISCV_IOMMU_QUEUE_ENABLE BIT(0) +#define RISCV_IOMMU_QUEUE_INTR_ENABLE BIT(1) +#define RISCV_IOMMU_QUEUE_MEM_FAULT BIT(8) +#define RISCV_IOMMU_QUEUE_OVERFLOW BIT(9) +#define RISCV_IOMMU_QUEUE_ACTIVE BIT(16) +#define RISCV_IOMMU_QUEUE_BUSY BIT(17) +#define RISCV_IOMMU_ATP_PPN_FIELD GENMASK_ULL(43, 0) +#define RISCV_IOMMU_ATP_MODE_FIELD GENMASK_ULL(63, 60) + +/* 5.3 IOMMU Capabilities (64bits) */ +#define RISCV_IOMMU_REG_CAP 0x0000 +#define RISCV_IOMMU_CAP_VERSION GENMASK_ULL(7, 0) +#define RISCV_IOMMU_CAP_MSI_FLAT BIT_ULL(22) +#define RISCV_IOMMU_CAP_MSI_MRIF BIT_ULL(23) +#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26) +#define RISCV_IOMMU_CAP_IGS GENMASK_ULL(29, 28) +#define RISCV_IOMMU_CAP_PAS GENMASK_ULL(37, 32) +#define RISCV_IOMMU_CAP_PD8 BIT_ULL(38) +#define RISCV_IOMMU_CAP_PD17 BIT_ULL(39) +#define RISCV_IOMMU_CAP_PD20 BIT_ULL(40) + +/* 5.4 Features control register (32bits) */ +#define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_WSI BIT(1) + +/* 5.5 Device-directory-table pointer (64bits) */ +#define RISCV_IOMMU_REG_DDTP 0x0010 +#define RISCV_IOMMU_DDTP_MODE GENMASK_ULL(3, 0) +#define RISCV_IOMMU_DDTP_BUSY BIT_ULL(4) +#define RISCV_IOMMU_DDTP_PPN RISCV_IOMMU_PPN_FIELD + +enum riscv_iommu_ddtp_modes { +RISCV_IOMMU_DDTP_MODE_OFF =0 , +RISCV_IOMMU_DDTP_MODE_BARE =1 , +RISCV_IOMMU_DDTP_MODE_1LVL =2 , +RISCV_IOMMU_DDTP_MODE_2LVL =3 , +RISCV_IOMMU_DDTP_MODE_3LVL =4 , +RISCV_IOMMU_DDTP_MODE_MAX =4 +}; + +/* 5.6 Command Queue Base (64bits) */ +#define RISCV_IOMMU_REG_CQB 0x0018 +#define RISCV_IOMMU_CQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_CQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.7 Command Queue head (32bits) */ +#define RISCV_IOMMU_REG_CQH 0x0020 + +/* 5.8 Command Queue tail (32bits) */ +#define RISCV_IOMMU_REG_CQT 0x0024 + +/* 5.9 Fault Queue Base (64bits) */ +#define RISCV_IOMMU_REG_FQB 0x0028 +#define RISCV_IOMMU_FQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_FQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.10 Fault Queue Head (32bits) */ +#define RISCV_IOMMU_REG_FQH 0x0030 + +/* 5.11 Fault Queue tail (32bits) */ +#define RISCV_IOMMU_REG_FQT 0x0034 + +/* 5.12 Page Request Queue base (64bits) */ +#define RISCV_IOMMU_REG_PQB 0x0038 +#define RISCV_IOMMU_PQB_LOG2SZ RISCV_IOMMU_QUEUE_LOGSZ_FIELD +#define RISCV_IOMMU_PQB_PPN RISCV_IOMMU_PPN_FIELD + +/* 5.13 Page Request Queue head (32bits) */ +#define RISCV_IOMMU_REG_PQH 0x0040 + +/* 5.14 Page Request Queue tail (32bits) */ +#define RISCV_IOMMU_REG_PQT 0x0044 + +/* 5.15 Command Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_CQCSR 0x0048 +#define RISCV_IOMMU_CQCSR_CQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_CQCSR_CIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_CQCSR_CQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_CQCSR_CMD_TO BIT(9) +#define RISCV_IOMMU_CQCSR_CMD_ILL BIT(10) +#define RISCV_IOMMU_CQCSR_FENCE_W_IP BIT(11) +#define RISCV_IOMMU_CQCSR_CQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_CQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.16 Fault Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_FQCSR 0x004C +#define RISCV_IOMMU_FQCSR_FQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_FQCSR_FIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_FQCSR_FQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_FQCSR_FQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_FQCSR_FQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_FQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.17 Page Request Queue CSR (32bits) */ +#define RISCV_IOMMU_REG_PQCSR 0x0050 +#define RISCV_IOMMU_PQCSR_PQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_PQCSR_PIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_PQCSR_PQMF RISCV_IOMMU_QUEUE_MEM_FAULT +#define RISCV_IOMMU_PQCSR_PQOF RISCV_IOMMU_QUEUE_OVERFLOW +#define RISCV_IOMMU_PQCSR_PQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_PQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +/* 5.18 Interrupt Pending Status (32bits) */ +#define RISCV_IOMMU_REG_IPSR 0x0054 +#define RISCV_IOMMU_IPSR_CIP BIT(0) +#define RISCV_IOMMU_IPSR_FIP BIT(1) +#define RISCV_IOMMU_IPSR_PIP BIT(3) + +enum { +RISCV_IOMMU_INTR_CQ , +RISCV_IOMMU_INTR_FQ , +RISCV_IOMMU_INTR_PM , +RISCV_IOMMU_INTR_PQ , +RISCV_IOMMU_INTR_COUNT +}; + +/* 5.27 Interrupt cause to vector (64bits) */ +#define RISCV_IOMMU_REG_IVEC 0x02F8 + +/* 5.28 MSI Configuration table (32 * 64bits) */ +#define RISCV_IOMMU_REG_MSI_CONFIG 0x0300 + +#define RISCV_IOMMU_REG_SIZE 0x1000 + +#define RISCV_IOMMU_DDTE_VALID BIT_ULL(0) +#define RISCV_IOMMU_DDTE_PPN RISCV_IOMMU_PPN_FIELD + +/* Struct riscv_iommu_dc - Device Context - section 2.1 */ +struct riscv_iommu_dc { +uint64_t tc; +uint64_t iohgatp; +uint64_t ta; +uint64_t fsc; +uint64_t msiptp; +uint64_t msi_addr_mask; +uint64_t msi_addr_pattern; +uint64_t _reserved; +}; + +/* Translation control fields */ +#define RISCV_IOMMU_DC_TC_V BIT_ULL(0) +#define RISCV_IOMMU_DC_TC_EN_PRI BIT_ULL(2) +#define RISCV_IOMMU_DC_TC_T2GPA BIT_ULL(3) +#define RISCV_IOMMU_DC_TC_DTF BIT_ULL(4) +#define RISCV_IOMMU_DC_TC_PDTV BIT_ULL(5) +#define RISCV_IOMMU_DC_TC_PRPR BIT_ULL(6) +#define RISCV_IOMMU_DC_TC_DPE BIT_ULL(9) +#define RISCV_IOMMU_DC_TC_SBE BIT_ULL(10) +#define RISCV_IOMMU_DC_TC_SXL BIT_ULL(11) + +/* Second-stage (aka G-stage) context fields */ +#define RISCV_IOMMU_DC_IOHGATP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_IOHGATP_GSCID GENMASK_ULL(59, 44) +#define RISCV_IOMMU_DC_IOHGATP_MODE RISCV_IOMMU_ATP_MODE_FIELD + +enum riscv_iommu_dc_iohgatp_modes { +RISCV_IOMMU_DC_IOHGATP_MODE_BARE =0 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV32X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV39X4 =8 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV48X4 =9 , +RISCV_IOMMU_DC_IOHGATP_MODE_SV57X4 =10 +}; + +/* Translation attributes fields */ +#define RISCV_IOMMU_DC_TA_PSCID GENMASK_ULL(31, 12) + +/* First-stage context fields */ +#define RISCV_IOMMU_DC_FSC_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_FSC_MODE RISCV_IOMMU_ATP_MODE_FIELD + +/* Generic I/O MMU command structure - check section 3.1 */ +struct riscv_iommu_command { +uint64_t dword0; +uint64_t dword1; +}; + +#define RISCV_IOMMU_CMD_OPCODE GENMASK_ULL(6, 0) +#define RISCV_IOMMU_CMD_FUNC GENMASK_ULL(9, 7) + +#define RISCV_IOMMU_CMD_IOTINVAL_OPCODE 1 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA 0 +#define RISCV_IOMMU_CMD_IOTINVAL_FUNC_GVMA 1 +#define RISCV_IOMMU_CMD_IOTINVAL_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IOTINVAL_PSCV BIT_ULL(32) +#define RISCV_IOMMU_CMD_IOTINVAL_GV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IOTINVAL_GSCID GENMASK_ULL(59, 44) + +#define RISCV_IOMMU_CMD_IOFENCE_OPCODE 2 +#define RISCV_IOMMU_CMD_IOFENCE_FUNC_C 0 +#define RISCV_IOMMU_CMD_IOFENCE_AV BIT_ULL(10) +#define RISCV_IOMMU_CMD_IOFENCE_DATA GENMASK_ULL(63, 32) + +#define RISCV_IOMMU_CMD_IODIR_OPCODE 3 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT 0 +#define RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT 1 +#define RISCV_IOMMU_CMD_IODIR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_IODIR_DV BIT_ULL(33) +#define RISCV_IOMMU_CMD_IODIR_DID GENMASK_ULL(63, 40) + +enum riscv_iommu_dc_fsc_atp_modes { +RISCV_IOMMU_DC_FSC_MODE_BARE =0 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV39 =8 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV48 =9 , +RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV57 =10 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD8 =1 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD17 =2 , +RISCV_IOMMU_DC_FSC_PDTP_MODE_PD20 =3 +}; + +enum riscv_iommu_fq_causes { +RISCV_IOMMU_FQ_CAUSE_INST_FAULT =1 , +RISCV_IOMMU_FQ_CAUSE_RD_ADDR_MISALIGNED =4 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT =5 , +RISCV_IOMMU_FQ_CAUSE_WR_ADDR_MISALIGNED =6 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT =7 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_S =12 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_S =13 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_S =15 , +RISCV_IOMMU_FQ_CAUSE_INST_FAULT_VS =20 , +RISCV_IOMMU_FQ_CAUSE_RD_FAULT_VS =21 , +RISCV_IOMMU_FQ_CAUSE_WR_FAULT_VS =23 , +RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED =256 , +RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT =257 , +RISCV_IOMMU_FQ_CAUSE_DDT_INVALID =258 , +RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED =259 , +RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED =260 , +RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT =261 , +RISCV_IOMMU_FQ_CAUSE_MSI_INVALID =262 , +RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED =263 , +RISCV_IOMMU_FQ_CAUSE_MRIF_FAULT =264 , +RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT =265 , +RISCV_IOMMU_FQ_CAUSE_PDT_INVALID =266 , +RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED =267 , +RISCV_IOMMU_FQ_CAUSE_DDT_CORRUPTED =268 , +RISCV_IOMMU_FQ_CAUSE_PDT_CORRUPTED =269 , +RISCV_IOMMU_FQ_CAUSE_MSI_PT_CORRUPTED =270 , +RISCV_IOMMU_FQ_CAUSE_MRIF_CORRUIPTED =271 , +RISCV_IOMMU_FQ_CAUSE_INTERNAL_DP_ERROR =272 , +RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT =273 , +RISCV_IOMMU_FQ_CAUSE_PT_CORRUPTED =274 +}; + +/* MSI page table pointer */ +#define RISCV_IOMMU_DC_MSIPTP_PPN RISCV_IOMMU_ATP_PPN_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE RISCV_IOMMU_ATP_MODE_FIELD +#define RISCV_IOMMU_DC_MSIPTP_MODE_OFF 0 +#define RISCV_IOMMU_DC_MSIPTP_MODE_FLAT 1 + +/* Translation attributes fields */ +#define RISCV_IOMMU_PC_TA_V BIT_ULL(0) + +/* First stage context fields */ +#define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0) + +enum riscv_iommu_fq_ttypes { +RISCV_IOMMU_FQ_TTYPE_NONE =0 , +RISCV_IOMMU_FQ_TTYPE_UADDR_INST_FETCH =1 , +RISCV_IOMMU_FQ_TTYPE_UADDR_RD =2 , +RISCV_IOMMU_FQ_TTYPE_UADDR_WR =3 , +RISCV_IOMMU_FQ_TTYPE_TADDR_INST_FETCH =5 , +RISCV_IOMMU_FQ_TTYPE_TADDR_RD =6 , +RISCV_IOMMU_FQ_TTYPE_TADDR_WR =7 , +RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ =8 , +}; + +/* Fields on pte */ +#define RISCV_IOMMU_MSI_PTE_V BIT_ULL(0) +#define RISCV_IOMMU_MSI_PTE_M GENMASK_ULL(2, 1) + +#define RISCV_IOMMU_MSI_PTE_M_MRIF 1 +#define RISCV_IOMMU_MSI_PTE_M_BASIC 3 + +/* When M == 1 (MRIF mode) */ +#define RISCV_IOMMU_MSI_PTE_MRIF_ADDR GENMASK_ULL(53, 7) +/* When M == 3 (basic mode) */ +#define RISCV_IOMMU_MSI_PTE_PPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_PTE_C BIT_ULL(63) + +/* Fields on mrif_info */ +#define RISCV_IOMMU_MSI_MRIF_NID GENMASK_ULL(9, 0) +#define RISCV_IOMMU_MSI_MRIF_NPPN RISCV_IOMMU_PPN_FIELD +#define RISCV_IOMMU_MSI_MRIF_NID_MSB BIT_ULL(60) + +#endif /* _RISCV_IOMMU_BITS_H_ */ --2.45.2
PATCH v4 3/14 hw/riscv: add RISC-V IOMMU base emulation
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at:
https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf
Add the foundation of the device emulation for RISC-V IOMMU, which includes an IOMMU that has no capabilities but MSI interrupt support and fault queue interfaces. We'll add more features incrementally in the next patches.
--- hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/riscv/riscv-iommu-bits.h | 2 + hw/riscv/riscv-iommu.c | 1641 +++++++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 142 +++ hw/riscv/trace-events | 11 + hw/riscv/trace.h | 1 + include/hw/riscv/iommu.h | 36 + meson.build | 1 + 9 files changed, 1839 insertions(+) create mode 100644 hw/riscv/riscv-iommu.c create mode 100644 hw/riscv/riscv-iommu.h create mode 100644 hw/riscv/trace-events create mode 100644 hw/riscv/trace.h create mode 100644 include/hw/riscv/iommu.h
hw/riscv/Kconfig +4 -0
@@ -1,3 +1,6 @@ +config RISCV_IOMMU + bool + config RISCV_NUMA bool
@@ -47,6 +50,7 @@ config RISCV_VIRT select SERIAL select RISCV_ACLINT select RISCV_APLIC + select RISCV_IOMMU select RISCV_IMSIC select SIFIVE_PLIC select SIFIVE_TEST
hw/riscv/meson.build +1 -0
@@ -10,5 +10,6 @@ riscv_ss.add(when: 'CONFIG_SIFIVE_U', if_true: files('sifive_u.c')) riscv_ss.add(when: 'CONFIG_SPIKE', if_true: files('spike.c')) riscv_ss.add(when: 'CONFIG_MICROCHIP_PFSOC', if_true: files('microchip_pfsoc.c')) riscv_ss.add(when: 'CONFIG_ACPI', if_true: files('virt-acpi-build.c')) +riscv_ss.add(when: 'CONFIG_RISCV_IOMMU', if_true: files('riscv-iommu.c')) hw_arch += {'riscv': riscv_ss}
hw/riscv/riscv-iommu-bits.h +2 -0
@@ -82,6 +82,7 @@ struct riscv_iommu_pq_record {/* 5.4 Features control register (32bits) */ #define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_BE BIT(0)#define RISCV_IOMMU_FCTL_WSI BIT(1)/* 5.5 Device-directory-table pointer (64bits) */
@@ -311,6 +312,7 @@ enum riscv_iommu_fq_causes {/* Translation attributes fields */ #define RISCV_IOMMU_PC_TA_V BIT_ULL(0) +#define RISCV_IOMMU_PC_TA_RESERVED GENMASK_ULL(63, 32)/* First stage context fields */ #define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0)
hw/riscv/riscv-iommu.c new file +1641 -0
1,641 lines not on this page · raw message
hw/riscv/riscv-iommu.h new file +142 -0
142 lines not on this page · raw message
hw/riscv/trace-events new file +11 -0
@@ -0,0 +1,11 @@ +# See documentation at docs/devel/tracing.rst + +# riscv-iommu.c +riscv_iommu_new(const char *id, unsigned b, unsigned d, unsigned f) "%s: device attached %04x:%02x.%d" +riscv_iommu_flt(const char *id, unsigned b, unsigned d, unsigned f, uint64_t reason, uint64_t iova) "%s: fault %04x:%02x.%u reason: 0x%"PRIx64" iova: 0x%"PRIx64 +riscv_iommu_pri(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova) "%s: page request %04x:%02x.%u iova: 0x%"PRIx64 +riscv_iommu_dma(const char *id, unsigned b, unsigned d, unsigned f, unsigned pasid, const char *dir, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u #%u %s 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_msi(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u MSI 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_cmd(const char *id, uint64_t l, uint64_t u) "%s: command 0x%"PRIx64" 0x%"PRIx64 +riscv_iommu_notifier_add(const char *id) "%s: dev-iotlb notifier added" +riscv_iommu_notifier_del(const char *id) "%s: dev-iotlb notifier removed"
hw/riscv/trace.h new file +1 -0
@@ -0,0 +1 @@ +#include "trace/trace-hw_riscv.h"
include/hw/riscv/iommu.h new file +36 -0
@@ -0,0 +1,36 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2022-2023 Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef HW_RISCV_IOMMU_H +#define HW_RISCV_IOMMU_H + +#include "qemu/osdep.h" +#include "qom/object.h" + +#define TYPE_RISCV_IOMMU "riscv-iommu" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUState, RISCV_IOMMU) +typedef struct RISCVIOMMUState RISCVIOMMUState ; + +#define TYPE_RISCV_IOMMU_MEMORY_REGION "riscv-iommu-mr" +typedef struct RISCVIOMMUSpace RISCVIOMMUSpace ; + +#define TYPE_RISCV_IOMMU_PCI "riscv-iommu-pci" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUStatePci, RISCV_IOMMU_PCI) +typedef struct RISCVIOMMUStatePci RISCVIOMMUStatePci ; + +#endif
meson.build +1 -0
@@ -3353,6 +3353,7 @@ if have_system 'hw/pci-host', 'hw/ppc', 'hw/rtc', + 'hw/riscv', 'hw/s390x', 'hw/scsi', 'hw/sd',
Signature · 1 line
2.45.2
Re: [PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation
Hi Danial,
Quoted 153 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at:
https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf
Add the foundation of the device emulation for RISC-V IOMMU, which includes an IOMMU that has no capabilities but MSI interrupt support and fault queue interfaces. We'll add more features incrementally in the next patches.
Co-developed-by Sebastien Boeuf <[email protected]>Signed-off-by Sebastien Boeuf <[email protected]>Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>--- hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/riscv/riscv-iommu-bits.h | 2 + hw/riscv/riscv-iommu.c | 1641 +++++++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 142 +++ hw/riscv/trace-events | 11 + hw/riscv/trace.h | 1 + include/hw/riscv/iommu.h | 36 + meson.build | 1 + 9 files changed, 1839 insertions(+)create mode 100644
hw/riscv/riscv-iommu.c
create mode 100644hw/riscv/riscv-iommu.h
create mode 100644 hw/riscv/trace-events
create mode 100644hw/riscv/trace.h
create mode 100644include/hw/riscv/iommu.hhw/riscv/Kconfig +4
-0@@ -1,3 +1,6 @@ +config RISCV_IOMMU + bool + config RISCV_NUMA bool@@ -47,6 +50,7 @@ config RISCV_VIRT select SERIAL select RISCV_ACLINT select RISCV_APLIC + select RISCV_IOMMU select RISCV_IMSIC select SIFIVE_PLIC select SIFIVE_TESThw/riscv/meson.build +1
-0@@ -10,5 +10,6 @@ riscv_ss.add(when: 'CONFIG_SIFIVE_U', if_true: files('sifive_u.c')) riscv_ss.add(when: 'CONFIG_SPIKE', if_true: files('spike.c')) riscv_ss.add(when: 'CONFIG_MICROCHIP_PFSOC', if_true: files('microchip_pfsoc.c')) riscv_ss.add(when: 'CONFIG_ACPI', if_true: files('virt-acpi-build.c')) +riscv_ss.add(when: 'CONFIG_RISCV_IOMMU', if_true: files('riscv-iommu.c')) hw_arch += {'riscv': riscv_ss}hw/riscv/riscv-iommu-bits.h +2
-0@@ -82,6 +82,7 @@ struct riscv_iommu_pq_record {/* 5.4 Features control register (32bits) */ #define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_BE BIT(0)#define RISCV_IOMMU_FCTL_WSI BIT(1)/* 5.5 Device-directory-table pointer (64bits) */ @@ -311,6 +312,7 @@ enum riscv_iommu_fq_causes {/* Translation attributes fields */ #define RISCV_IOMMU_PC_TA_V BIT_ULL(0) +#define RISCV_IOMMU_PC_TA_RESERVED GENMASK_ULL(63, 32)/* First stage context fields */ #define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0)hw/riscv/riscv-iommu.c new file +64
-0@@ -0,0 +1,1641 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2021-2023, Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#include "qemu/osdep.h" +#include "qom/object.h" +#include "hw/pci/pci_bus.h" +#include "hw/pci/pci_device.h" +#include "hw/qdev-properties.h" +#include "hw/riscv/riscv_hart.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qemu/timer.h" + +#include "cpu_bits.h" +#include "riscv-iommu.h" +#include "riscv-iommu-bits.h" +#include "trace.h" + +#define LIMIT_CACHE_CTX (1U << 7) +#define LIMIT_CACHE_IOT (1U << 20) + +/* Physical page number coversions */ +#define PPN_PHYS (ppn) ((ppn) << TARGET_PAGE_BITS) +#define PPN_DOWN (phy) ((phy) >> TARGET_PAGE_BITS) + +typedef struct RISCVIOMMUContext RISCVIOMMUContext ; +typedef struct RISCVIOMMUEntry RISCVIOMMUEntry ; + +/* Device assigned I/O address space */ +struct RISCVIOMMUSpace { +IOMMUMemoryRegion iova_mr;/* IOVA memory region for attached device */ +AddressSpace iova_as;/* IOVA address space for attached device */ +RISCVIOMMUState *iommu;/* Managing IOMMU device state */ +uint32_t devid;/* Requester identifier, AKA device_id */ +bool notifier;/* IOMMU unmap notifier enabled */ +QLIST_ENTRY (RISCVIOMMUSpace) list; +}; + +/* Device translation context state. */ +struct RISCVIOMMUContext { +uint64_t devid:24 ;/* Requester Id, AKA device_id */ +uint64_t process_id:20 ;/* Process ID. PASID for PCIe */ +uint64_t __rfu:20 ;/* reserved */ +uint64_t tc;/* Translation Control */ +uint64_t ta;/* Translation Attributes */ +uint64_t msi_addr_mask;/* MSI filtering - address mask */ +uint64_t msi_addr_pattern;/* MSI filtering - address pattern */ +uint64_t msiptp;/* MSI redirection page table pointer */ +};
hw/riscv/riscv-iommu.c line 74
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ +/* IOMMU index for transactions without process_id specified. */ +#define RISCV_IOMMU_NOPROCID 0 + +static void riscv_iommu_notify (RISCVIOMMUState *s,int vec) +{ +const uint32_t fctl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FCTL ); +uint32_t ipsr, ivec; + +if (fctl &RISCV_IOMMU_FCTL_WSI || !s->notify) {
For WSI, we can assert INTx by invoking pci_set_irq().
Quoted 97 lines
hw/riscv/riscv-iommu.c new file +97
-0+return ; + } + + ipsr =riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_IPSR , (1 << vec),0 ); + ivec =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_IVEC ); + +if (!(ipsr & (1 << vec))) { + s->notify (s, (ivec >> (vec *4 )) &0x0F ); + } +} + +static void riscv_iommu_fault (RISCVIOMMUState *s, +struct riscv_iommu_fq_record *ev) +{ +uint32_t ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); +uint32_t head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQH ) & s->fq_mask; +uint32_t tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQT ) & s->fq_mask; +uint32_t next = (tail +1 ) & s->fq_mask; +uint32_t devid =get_field (ev->hdr,RISCV_IOMMU_FQ_HDR_DID ); + +trace_riscv_iommu_flt (s->parent_obj.id,PCI_BUS_NUM (devid),PCI_SLOT (devid), +PCI_FUNC (devid), ev->hdr, ev->iotval); + +if (!(ctrl &RISCV_IOMMU_FQCSR_FQON ) || + !!(ctrl & (RISCV_IOMMU_FQCSR_FQOF |RISCV_IOMMU_FQCSR_FQMF ))) { +return ; + } + +if (head == next) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , +RISCV_IOMMU_FQCSR_FQOF ,0 ); + }else { +dma_addr_t addr = s->fq_addr + tail *sizeof (*ev); +if (dma_memory_write (s->target_as, addr, ev,sizeof (*ev), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , +RISCV_IOMMU_FQCSR_FQMF ,0 ); + }else { +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_FQT , next); + } + } + +if (ctrl &RISCV_IOMMU_FQCSR_FIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_FQ ); + } +} + +static void riscv_iommu_pri (RISCVIOMMUState *s, +struct riscv_iommu_pq_record *pr) +{ +uint32_t ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); +uint32_t head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQH ) & s->pq_mask; +uint32_t tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQT ) & s->pq_mask; +uint32_t next = (tail +1 ) & s->pq_mask; +uint32_t devid =get_field (pr->hdr,RISCV_IOMMU_PREQ_HDR_DID ); + +trace_riscv_iommu_pri (s->parent_obj.id,PCI_BUS_NUM (devid),PCI_SLOT (devid), +PCI_FUNC (devid), pr->payload); + +if (!(ctrl &RISCV_IOMMU_PQCSR_PQON ) || + !!(ctrl & (RISCV_IOMMU_PQCSR_PQOF |RISCV_IOMMU_PQCSR_PQMF ))) { +return ; + } + +if (head == next) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , +RISCV_IOMMU_PQCSR_PQOF ,0 ); + }else { +dma_addr_t addr = s->pq_addr + tail *sizeof (*pr); +if (dma_memory_write (s->target_as, addr, pr,sizeof (*pr), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , +RISCV_IOMMU_PQCSR_PQMF ,0 ); + }else { +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_PQT , next); + } + } + +if (ctrl &RISCV_IOMMU_PQCSR_PIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_PQ ); + } +} + +/* Portable implementation of pext_u64, bit-mask extraction. */ +static uint64_t _pext_u64 (uint64_t val,uint64_t ext) +{ +uint64_t ret =0 ; +uint64_t rot =1 ; + +while (ext) { +if (ext &1 ) { +if (val &1 ) { + ret |= rot; + } + rot <<=1 ; + } + val >>=1 ;
hw/riscv/riscv-iommu.c line 181
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ ext >>=1 ; + } + +return ret; +} + +/* Check if GPA matches MSI/MRIF pattern. */ +static bool riscv_iommu_msi_check (RISCVIOMMUState *s,RISCVIOMMUContext *ctx, +dma_addr_t gpa) +{
If IOMMU does not support MSI, that is, s->enable_msi is false, we can return false.
Quoted 14 lines
hw/riscv/riscv-iommu.c new file +14
-0+if (get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_MODE ) != +RISCV_IOMMU_DC_MSIPTP_MODE_FLAT ) { +return false;/* Invalid MSI/MRIF mode */ + } + +if ((PPN_DOWN (gpa) ^ ctx->msi_addr_pattern) & ~ctx->msi_addr_mask) { +return false;/* GPA not in MSI range defined by AIA IMSIC rules. */ + } + +return true; +} + +/* RISCV IOMMU Address Translation Lookup - Page Table Walk */ +static int riscv_iommu_spa_fetch(RISCVIOMMUState *s, RISCVIOMMUContext *ctx,
hw/riscv/riscv-iommu.c line 205
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ IOMMUTLBEntry *iotlb) +{ +/* Early check for MSI address match when IOVA == GPA */ +if (iotlb->perm &IOMMU_WO && +riscv_iommu_msi_check (s, ctx, iotlb->iova)) { + iotlb->target_as = &s->trap_as; + iotlb->translated_addr = iotlb->iova; + iotlb->addr_mask = ~TARGET_PAGE_MASK ; +return 0 ; + }
From spec 2.3, step 17 and step 18 state that the MSI address translation is always done after the first stage translation is done.
Quoted 52 lines
hw/riscv/riscv-iommu.c new file +52
-0+ +/* Exit early for pass-through mode. */ + iotlb->translated_addr = iotlb->iova; + iotlb->addr_mask = ~TARGET_PAGE_MASK ; +/* Allow R/W in pass-through mode */ + iotlb->perm =IOMMU_RW ; +return 0 ; +} + +static void riscv_iommu_report_fault (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx, +uint32_t fault_type,uint32_t cause, +bool pv, +uint64_t iotval,uint64_t iotval2) +{ +struct riscv_iommu_fq_record ev = {0 }; + +if (ctx->tc &RISCV_IOMMU_DC_TC_DTF ) { +switch (cause) { +case RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED : +case RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT : +case RISCV_IOMMU_FQ_CAUSE_DDT_INVALID : +case RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED : +case RISCV_IOMMU_FQ_CAUSE_DDT_CORRUPTED : +case RISCV_IOMMU_FQ_CAUSE_INTERNAL_DP_ERROR : +case RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT : +break ; +default : +/* DTF prevents reporting a fault for this given cause */ +return ; + } + } + + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_CAUSE , cause); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_TTYPE , fault_type); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_DID , ctx->devid); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_PV , true); + +if (pv) { + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_PID , ctx->process_id); + } + + ev.iotval = iotval; + ev.iotval2 = iotval2; + +riscv_iommu_fault (s, &ev); +} + +/* Redirect MSI write for given GPA. */ +static MemTxResult riscv_iommu_msi_write (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx,uint64_t gpa,uint64_t data, +unsigned size,MemTxAttrs attrs)
hw/riscv/riscv-iommu.c line 267
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+{ +MemTxResult res; +dma_addr_t addr; +uint64_t intn; +uint32_t n190; +uint64_t pte[2 ]; +int fault_type =RISCV_IOMMU_FQ_TTYPE_UADDR_WR ; +int cause; + +if (!riscv_iommu_msi_check (s, ctx, gpa)) {
I think we have invoked riscv_iommu_msi_check() before writing to s->trap_as. Do we need this check?
Quoted 867 lines
hw/riscv/riscv-iommu.c new file +867
-0+ res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +/* Interrupt File Number */ + intn =_pext_u64 (PPN_DOWN (gpa), ctx->msi_addr_mask); +if (intn >=256 ) { +/* Interrupt file number out of range */ + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +/* fetch MSI PTE */ + addr =PPN_PHYS (get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_PPN )); + addr = addr | (intn *sizeof (pte)); + res =dma_memory_read (s->target_as, addr, &pte,sizeof (pte), +MEMTXATTRS_UNSPECIFIED ); +if (res !=MEMTX_OK ) { +if (res ==MEMTX_DECODE_ERROR ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_PT_CORRUPTED ; + }else { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + } + goto err; + } + +le64_to_cpus (&pte[0 ]); +le64_to_cpus (&pte[1 ]); + +if (!(pte[0 ] &RISCV_IOMMU_MSI_PTE_V ) || (pte[0 ] &RISCV_IOMMU_MSI_PTE_C )) { +/* +* The spec mentions that: "If msipte.C == 1, then further +* processing to interpret the PTE is implementation +* defined.". We'll abort with cause = 262 for this +* case too. +*/ + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_INVALID ; + goto err; + } + +switch (get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_M )) { +case RISCV_IOMMU_MSI_PTE_M_BASIC : +/* MSI Pass-through mode */ + addr =PPN_PHYS (get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_PPN )); + addr = addr | (gpa &TARGET_PAGE_MASK ); + +trace_riscv_iommu_msi (s->parent_obj.id,PCI_BUS_NUM (ctx->devid), +PCI_SLOT (ctx->devid),PCI_FUNC (ctx->devid), + gpa, addr); + + res =dma_memory_write (s->target_as, addr, &data, size, attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +return MEMTX_OK ; +case RISCV_IOMMU_MSI_PTE_M_MRIF : +/* MRIF mode, continue. */ +break ; +default : + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED ; + goto err; + } + +/* +* Report an error for interrupt identities exceeding the maximum allowed +* for an IMSIC interrupt file (2047) or destination address is not 32-bit +* aligned. See IOMMU Specification, Chapter 2.3. MSI page tables. +*/ +if ((data >2047 ) || (gpa &3 )) { + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED ; + goto err; + } + +/* MSI MRIF mode, non atomic pending bit update */ + +/* MRIF pending bit address */ + addr =get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_MRIF_ADDR ) <<9 ; + addr = addr | ((data &0x7c0 ) >>3 ); + +trace_riscv_iommu_msi (s->parent_obj.id,PCI_BUS_NUM (ctx->devid), +PCI_SLOT (ctx->devid),PCI_FUNC (ctx->devid), + gpa, addr); + +/* MRIF pending bit mask */ + data =1ULL << (data &0x03f ); + res =dma_memory_read (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + + intn = intn | data; + res =dma_memory_write (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +/* Get MRIF enable bits */ + addr = addr +sizeof (intn); + res =dma_memory_read (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +if (!(intn & data)) { +/* notification disabled, MRIF update completed. */ +return MEMTX_OK ; + } + +/* Send notification message */ + addr =PPN_PHYS (get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NPPN )); + n190 =get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NID ) | + (get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NID_MSB ) <<10 ); + + res =dma_memory_write (s->target_as, addr, &n190,sizeof (n190), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +return MEMTX_OK ; + +err: +riscv_iommu_report_fault (s, ctx, fault_type, cause, + !!ctx->process_id,0 ,0 ); +return res; +} + +/* +* Check device context configuration as described by the +* riscv-iommu spec section "Device-context configuration +* checks". +*/ +static bool riscv_iommu_validate_device_ctx (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx) +{ +uint32_t msi_mode; + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_EN_PRI ) && + ctx->tc &RISCV_IOMMU_DC_TC_PRPR ) { +return false; + } + +if (!(s->cap &RISCV_IOMMU_CAP_T2GPA ) && + ctx->tc &RISCV_IOMMU_DC_TC_T2GPA ) { +return false; + } + +if (s->cap &RISCV_IOMMU_CAP_MSI_FLAT ) { + msi_mode =get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_MODE ); + +if (msi_mode !=RISCV_IOMMU_DC_MSIPTP_MODE_OFF && + msi_mode !=RISCV_IOMMU_DC_MSIPTP_MODE_FLAT ) { +return false; + } + } + +/* +* CAP_END is always zero (only one endianess). FCTL_BE is +* always zero (little-endian accesses). Thus TC_SBE must +* always be LE, i.e. zero. +*/ +if (ctx->tc &RISCV_IOMMU_DC_TC_SBE ) { +return false; + } + +return true; +} + +/* +* Validate process context (PC) according to section +* "Process-context configuration checks". +*/ +static bool riscv_iommu_validate_process_ctx (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx) +{ +if (get_field (ctx->ta,RISCV_IOMMU_PC_TA_RESERVED )) { +return false; + } + +/* FSC and svNN checks to be added when adding s/g-stage support */ +return true; +} + +/* +* RISC-V IOMMU Device Context Loopkup - Device Directory Tree Walk +* +* @s : IOMMU Device State +* @ctx : Device Translation Context with devid and pasid set. +* @return : success or fault code. +*/ +static int riscv_iommu_ctx_fetch (RISCVIOMMUState *s,RISCVIOMMUContext *ctx) +{ +const uint64_t ddtp = s->ddtp; +unsigned mode =get_field (ddtp,RISCV_IOMMU_DDTP_MODE ); +dma_addr_t addr =PPN_PHYS (get_field (ddtp,RISCV_IOMMU_DDTP_PPN )); +struct riscv_iommu_dc dc; +/* Device Context format: 0: extended (64 bytes) | 1: base (32 bytes) */ +const int dc_fmt = !s->enable_msi; +const size_t dc_len =sizeof (dc) >> dc_fmt; +unsigned depth; +uint64_t de; + +switch (mode) { +case RISCV_IOMMU_DDTP_MODE_OFF : +return RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED ; + +case RISCV_IOMMU_DDTP_MODE_BARE : +/* mock up pass-through translation context */ + ctx->tc =RISCV_IOMMU_DC_TC_V ; + ctx->ta =0 ; + ctx->msiptp =0 ; +return 0 ; + +case RISCV_IOMMU_DDTP_MODE_1LVL : + depth =0 ; +break ; + +case RISCV_IOMMU_DDTP_MODE_2LVL : + depth =1 ; +break ; + +case RISCV_IOMMU_DDTP_MODE_3LVL : + depth =2 ; +break ; + +default : +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + +/* +* Check supported device id width (in bits). +* See IOMMU Specification, Chapter 6. Software guidelines. +* - if extended device-context format is used: +* 1LVL: 6, 2LVL: 15, 3LVL: 24 +* - if base device-context format is used: +* 1LVL: 7, 2LVL: 16, 3LVL: 24 +*/ +if (ctx->devid >= (1 << (depth *9 +6 + (dc_fmt && depth !=2 )))) { +return RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED ; + } + +/* Device directory tree walk */ +for (; depth-- >0 ; ) { +/* +* Select device id index bits based on device directory tree level +* and device context format. +* See IOMMU Specification, Chapter 2. Data Structures. +* - if extended device-context format is used: +* device index: [23:15][14:6][5:0] +* - if base device-context format is used: +* device index: [23:16][15:7][6:0] +*/ +const int split = depth *9 +6 + dc_fmt; + addr |= ((ctx->devid >> split) <<3 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &de,sizeof (de), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT ; + } +le64_to_cpus (&de); +if (!(de &RISCV_IOMMU_DDTE_VALID )) { +/* invalid directory entry */ +return RISCV_IOMMU_FQ_CAUSE_DDT_INVALID ; + } +if (de & ~(RISCV_IOMMU_DDTE_PPN |RISCV_IOMMU_DDTE_VALID )) { +/* reserved bits set */ +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + addr =PPN_PHYS (get_field (de,RISCV_IOMMU_DDTE_PPN )); + } + +/* index into device context entry page */ + addr |= (ctx->devid * dc_len) & ~TARGET_PAGE_MASK ; + +memset (&dc,0 ,sizeof (dc)); +if (dma_memory_read (s->target_as, addr, &dc, dc_len, +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT ; + } + +/* Set translation context. */ + ctx->tc =le64_to_cpu (dc.tc); + ctx->ta =le64_to_cpu (dc.ta); + ctx->msiptp =le64_to_cpu (dc.msiptp); + ctx->msi_addr_mask =le64_to_cpu (dc.msi_addr_mask); + ctx->msi_addr_pattern =le64_to_cpu (dc.msi_addr_pattern); + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_V )) { +return RISCV_IOMMU_FQ_CAUSE_DDT_INVALID ; + } + +if (!riscv_iommu_validate_device_ctx (s, ctx)) { +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_PDTV )) { +if (ctx->process_id !=RISCV_IOMMU_NOPROCID ) { +/* PASID is disabled */ +return RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED ; + } +return 0 ; + } + +/* FSC.TC.PDTV enabled */ +if (mode >RISCV_IOMMU_DC_FSC_PDTP_MODE_PD20 ) { +/* Invalid PDTP.MODE */ +return RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED ; + } + +for (depth = mode -RISCV_IOMMU_DC_FSC_PDTP_MODE_PD8 ; depth-- >0 ; ) { +/* +* Select process id index bits based on process directory tree +* level. See IOMMU Specification, 2.2. Process-Directory-Table. +*/ +const int split = depth *9 +8 ; + addr |= ((ctx->process_id >> split) <<3 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &de,sizeof (de), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT ; + } +le64_to_cpus (&de); +if (!(de &RISCV_IOMMU_PC_TA_V )) { +return RISCV_IOMMU_FQ_CAUSE_PDT_INVALID ; + } + addr =PPN_PHYS (get_field (de,RISCV_IOMMU_PC_FSC_PPN )); + } + +/* Leaf entry in PDT */ + addr |= (ctx->process_id <<4 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &dc.ta,sizeof (uint64_t ) *2 , +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT ; + } + +/* Use TA from process directory entry. */ + ctx->ta =le64_to_cpu (dc.ta); + +if (!(ctx->ta &RISCV_IOMMU_PC_TA_V )) { +return RISCV_IOMMU_FQ_CAUSE_PDT_INVALID ; + } + +if (!riscv_iommu_validate_process_ctx (s, ctx)) { +return RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED ; + } + +return 0 ; +} + +/* Translation Context cache support */ +static gboolean __ctx_equal (gconstpointer v1,gconstpointer v2) +{ +RISCVIOMMUContext *c1 = (RISCVIOMMUContext *) v1; +RISCVIOMMUContext *c2 = (RISCVIOMMUContext *) v2; +return c1->devid == c2->devid && + c1->process_id == c2->process_id; +} + +static guint __ctx_hash (gconstpointer v) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) v; +/* +* Generate simple hash of (process_id, devid) +* assuming 24-bit wide devid. +*/ +return (guint)(ctx->devid) + ((guint)(ctx->process_id) <<24 ); +} + +static void __ctx_inval_devid_procid (gpointer key,gpointer value, +gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +RISCVIOMMUContext *arg = (RISCVIOMMUContext *) data; +if (ctx->tc &RISCV_IOMMU_DC_TC_V && + ctx->devid == arg->devid && + ctx->process_id == arg->process_id) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void __ctx_inval_devid (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +RISCVIOMMUContext *arg = (RISCVIOMMUContext *) data; +if (ctx->tc &RISCV_IOMMU_DC_TC_V && + ctx->devid == arg->devid) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void __ctx_inval_all (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +if (ctx->tc &RISCV_IOMMU_DC_TC_V ) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void riscv_iommu_ctx_inval (RISCVIOMMUState *s,GHFunc func, +uint32_t devid,uint32_t process_id) +{ +GHashTable *ctx_cache; +RISCVIOMMUContext key = { + .devid = devid, + .process_id = process_id, + }; + ctx_cache =g_hash_table_ref (s->ctx_cache); +qemu_mutex_lock (&s->ctx_lock); +g_hash_table_foreach (ctx_cache, func, &key); +qemu_mutex_unlock (&s->ctx_lock); +g_hash_table_unref (ctx_cache); +} + +/* Find or allocate translation context for a given {device_id, process_id} */ +static RISCVIOMMUContext *riscv_iommu_ctx (RISCVIOMMUState *s, +unsigned devid,unsigned process_id, +void **ref) +{ +GHashTable *ctx_cache; +RISCVIOMMUContext *ctx; +RISCVIOMMUContext key = { + .devid = devid, + .process_id = process_id, + }; + + ctx_cache =g_hash_table_ref (s->ctx_cache); +qemu_mutex_lock (&s->ctx_lock); + ctx =g_hash_table_lookup (ctx_cache, &key); +qemu_mutex_unlock (&s->ctx_lock); + +if (ctx && (ctx->tc &RISCV_IOMMU_DC_TC_V )) { + *ref = ctx_cache; +return ctx; + } + + ctx =g_new0 (RISCVIOMMUContext,1 ); + ctx->devid = devid; + ctx->process_id = process_id; + +int fault =riscv_iommu_ctx_fetch (s, ctx); +if (!fault) { +qemu_mutex_lock (&s->ctx_lock); +if (g_hash_table_size (ctx_cache) >=LIMIT_CACHE_CTX ) { +g_hash_table_unref (ctx_cache); + ctx_cache =g_hash_table_new_full (__ctx_hash, __ctx_equal, + g_free,NULL ); +g_hash_table_ref (ctx_cache); +g_hash_table_unref (qatomic_xchg (&s->ctx_cache, ctx_cache)); + } +g_hash_table_add (ctx_cache, ctx); +qemu_mutex_unlock (&s->ctx_lock); + *ref = ctx_cache; +return ctx; + } + +g_hash_table_unref (ctx_cache); + *ref =NULL ; + +riscv_iommu_report_fault (s, ctx,RISCV_IOMMU_FQ_TTYPE_UADDR_RD , + fault, !!process_id,0 ,0 ); + +g_free (ctx); +return NULL ; +} + +static void riscv_iommu_ctx_put (RISCVIOMMUState *s,void *ref) +{ +if (ref) { +g_hash_table_unref ((GHashTable *)ref); + } +} + +/* Find or allocate address space for a given device */ +static AddressSpace *riscv_iommu_space (RISCVIOMMUState *s,uint32_t devid) +{ +RISCVIOMMUSpace *as; + +/* FIXME: PCIe bus remapping for attached endpoints. */ + devid |= s->bus <<8 ; + +qemu_mutex_lock (&s->core_lock); + QLIST_FOREACH(as, &s->spaces, list) { +if (as->devid == devid) { +break ; + } + } +qemu_mutex_unlock (&s->core_lock); + +if (as ==NULL ) { +char name[64 ]; + as =g_new0 (RISCVIOMMUSpace,1 ); + + as->iommu = s; + as->devid = devid; + +snprintf (name,sizeof (name),"riscv-iommu-%04x:%02x.%d-iova" , +PCI_BUS_NUM (as->devid),PCI_SLOT (as->devid),PCI_FUNC (as->devid)); + +/* IOVA address space, untranslated addresses */ +memory_region_init_iommu (&as->iova_mr,sizeof (as->iova_mr), +TYPE_RISCV_IOMMU_MEMORY_REGION , +OBJECT (as),"riscv_iommu" ,UINT64_MAX ); +address_space_init (&as->iova_as,MEMORY_REGION (&as->iova_mr), name); + +qemu_mutex_lock (&s->core_lock); +QLIST_INSERT_HEAD (&s->spaces, as, list); +qemu_mutex_unlock (&s->core_lock); + +trace_riscv_iommu_new (s->parent_obj.id,PCI_BUS_NUM (as->devid), +PCI_SLOT (as->devid),PCI_FUNC (as->devid)); + } +return &as->iova_as; +} + +static int riscv_iommu_translate (RISCVIOMMUState *s,RISCVIOMMUContext *ctx, +IOMMUTLBEntry *iotlb) +{ +bool enable_pasid; +bool enable_pri; +int fault; + +/* +* TC[32] is reserved for custom extensions, used here to temporarily +* enable automatic page-request generation for ATS queries. +*/ + enable_pri = (iotlb->perm ==IOMMU_NONE ) && (ctx->tc &BIT_ULL (32 )); + enable_pasid = (ctx->tc &RISCV_IOMMU_DC_TC_PDTV ); + +/* Translate using device directory / page table information. */ + fault =riscv_iommu_spa_fetch (s, ctx, iotlb); + +if (enable_pri && fault) { +struct riscv_iommu_pq_record pr = {0 }; +if (enable_pasid) { + pr.hdr =set_field (RISCV_IOMMU_PREQ_HDR_PV , +RISCV_IOMMU_PREQ_HDR_PID , ctx->process_id); + } + pr.hdr =set_field (pr.hdr,RISCV_IOMMU_PREQ_HDR_DID , ctx->devid); + pr.payload = (iotlb->iova &TARGET_PAGE_MASK ) | +RISCV_IOMMU_PREQ_PAYLOAD_M ; +riscv_iommu_pri (s, &pr); +return fault; + } + +if (fault) { +unsigned ttype; + +if (iotlb->perm &IOMMU_RW ) { + ttype =RISCV_IOMMU_FQ_TTYPE_UADDR_WR ; + }else { + ttype =RISCV_IOMMU_FQ_TTYPE_UADDR_RD ; + } + +riscv_iommu_report_fault (s, ctx, ttype, fault, enable_pasid, + iotlb->iova, iotlb->translated_addr); +return fault; + } + +return 0 ; +} + +/* IOMMU Command Interface */ +static MemTxResult riscv_iommu_iofence (RISCVIOMMUState *s,bool notify, +uint64_t addr,uint32_t data) +{ +/* +* ATS processing in this implementation of the IOMMU is synchronous, +* no need to wait for completions here. +*/ +if (!notify) { +return MEMTX_OK ; + } + +return dma_memory_write (s->target_as, addr, &data,sizeof (data), +MEMTXATTRS_UNSPECIFIED ); +} + +static void riscv_iommu_process_ddtp (RISCVIOMMUState *s) +{ +uint64_t old_ddtp = s->ddtp; +uint64_t new_ddtp =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_DDTP ); +unsigned new_mode =get_field (new_ddtp,RISCV_IOMMU_DDTP_MODE ); +unsigned old_mode =get_field (old_ddtp,RISCV_IOMMU_DDTP_MODE ); +bool ok = false; + +/* +* Check for allowed DDTP.MODE transitions: +* {OFF, BARE} -> {OFF, BARE, 1LVL, 2LVL, 3LVL} +* {1LVL, 2LVL, 3LVL} -> {OFF, BARE} +*/ +if (new_mode == old_mode || + new_mode ==RISCV_IOMMU_DDTP_MODE_OFF || + new_mode ==RISCV_IOMMU_DDTP_MODE_BARE ) { + ok = true; + }else if (new_mode ==RISCV_IOMMU_DDTP_MODE_1LVL || + new_mode ==RISCV_IOMMU_DDTP_MODE_2LVL || + new_mode ==RISCV_IOMMU_DDTP_MODE_3LVL ) { + ok = old_mode ==RISCV_IOMMU_DDTP_MODE_OFF || + old_mode ==RISCV_IOMMU_DDTP_MODE_BARE ; + } + +if (ok) { +/* clear reserved and busy bits, report back sanitized version */ + new_ddtp =set_field (new_ddtp &RISCV_IOMMU_DDTP_PPN , +RISCV_IOMMU_DDTP_MODE , new_mode); + }else { + new_ddtp = old_ddtp; + } + s->ddtp = new_ddtp; + +riscv_iommu_reg_set64 (s,RISCV_IOMMU_REG_DDTP , new_ddtp); +} + +/* Command function and opcode field. */ +#define RISCV_IOMMU_CMD (func, op) (((func) << 7) | (op)) + +static void riscv_iommu_process_cq_tail (RISCVIOMMUState *s) +{ +struct riscv_iommu_command cmd; +MemTxResult res; +dma_addr_t addr; +uint32_t tail, head, ctrl; +uint64_t cmd_opcode; +GHFunc func; + + ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); + tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQT ) & s->cq_mask; + head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQH ) & s->cq_mask; + +/* Check for pending error or queue processing disabled */ +if (!(ctrl &RISCV_IOMMU_CQCSR_CQON ) || + !!(ctrl & (RISCV_IOMMU_CQCSR_CMD_ILL |RISCV_IOMMU_CQCSR_CQMF ))) { +return ; + } + +while (tail != head) { + addr = s->cq_addr + head *sizeof (cmd); + res =dma_memory_read (s->target_as, addr, &cmd,sizeof (cmd), +MEMTXATTRS_UNSPECIFIED ); + +if (res !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CQMF ,0 ); + goto fault; + } + +trace_riscv_iommu_cmd (s->parent_obj.id, cmd.dword0, cmd.dword1); + + cmd_opcode =get_field (cmd.dword0, +RISCV_IOMMU_CMD_OPCODE |RISCV_IOMMU_CMD_FUNC ); + +switch (cmd_opcode) { +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOFENCE_FUNC_C , +RISCV_IOMMU_CMD_IOFENCE_OPCODE ): + res =riscv_iommu_iofence (s, + cmd.dword0 &RISCV_IOMMU_CMD_IOFENCE_AV , cmd.dword1, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IOFENCE_DATA )); + +if (res !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CQMF ,0 ); + goto fault; + } +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOTINVAL_FUNC_GVMA , +RISCV_IOMMU_CMD_IOTINVAL_OPCODE ): +if (cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_PSCV ) { +/* illegal command arguments IOTINVAL.GVMA & PSCV == 1 */ + goto cmd_ill; + } +/* translation cache not implemented yet */ +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA , +RISCV_IOMMU_CMD_IOTINVAL_OPCODE ): +/* translation cache not implemented yet */ +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT , +RISCV_IOMMU_CMD_IODIR_OPCODE ): +if (!(cmd.dword0 &RISCV_IOMMU_CMD_IODIR_DV )) { +/* invalidate all device context cache mappings */ + func = __ctx_inval_all; + }else { +/* invalidate all device context matching DID */ + func = __ctx_inval_devid; + } +riscv_iommu_ctx_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_DID ),0 ); +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT , +RISCV_IOMMU_CMD_IODIR_OPCODE ): +if (!(cmd.dword0 &RISCV_IOMMU_CMD_IODIR_DV )) { +/* illegal command arguments IODIR_PDT & DV == 0 */ + goto cmd_ill; + }else { + func = __ctx_inval_devid_procid; + } +riscv_iommu_ctx_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_DID ), +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_PID )); +break ; + +default : + cmd_ill: +/* Invalid instruction, do not advance instruction index. */ +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CMD_ILL ,0 ); + goto fault; + } + +/* Advance and update head pointer after command completes. */ + head = (head +1 ) & s->cq_mask; +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_CQH , head); + } +return ; + +fault: +if (ctrl &RISCV_IOMMU_CQCSR_CIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_CQ ); + } +} + +static void riscv_iommu_process_cq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_CQCSR_CQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_CQCSR_CQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_CQB ); + s->cq_mask = (2ULL <<get_field (base,RISCV_IOMMU_CQB_LOG2SZ )) -1 ; + s->cq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_CQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQT ], ~s->cq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_CQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_CQT ],0 ); + ctrl_set =RISCV_IOMMU_CQCSR_CQON ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY |RISCV_IOMMU_CQCSR_CQMF | +RISCV_IOMMU_CQCSR_CMD_ILL |RISCV_IOMMU_CQCSR_CMD_TO | +RISCV_IOMMU_CQCSR_FENCE_W_IP ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQT ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY |RISCV_IOMMU_CQCSR_CQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , ctrl_set, ctrl_clr); +} + +static void riscv_iommu_process_fq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_FQCSR_FQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_FQCSR_FQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_FQB ); + s->fq_mask = (2ULL <<get_field (base,RISCV_IOMMU_FQB_LOG2SZ )) -1 ; + s->fq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_FQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQH ], ~s->fq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_FQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_FQT ],0 ); + ctrl_set =RISCV_IOMMU_FQCSR_FQON ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY |RISCV_IOMMU_FQCSR_FQMF | +RISCV_IOMMU_FQCSR_FQOF ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQH ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY |RISCV_IOMMU_FQCSR_FQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , ctrl_set, ctrl_clr); +} + +static void riscv_iommu_process_pq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_PQCSR_PQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_PQCSR_PQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_PQB ); + s->pq_mask = (2ULL <<get_field (base,RISCV_IOMMU_PQB_LOG2SZ )) -1 ; + s->pq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_PQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQH ], ~s->pq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_PQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_PQT ],0 ); + ctrl_set =RISCV_IOMMU_PQCSR_PQON ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY |RISCV_IOMMU_PQCSR_PQMF | +RISCV_IOMMU_PQCSR_PQOF ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQH ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY |RISCV_IOMMU_PQCSR_PQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , ctrl_set, ctrl_clr); +} + +typedef void riscv_iommu_process_fn (RISCVIOMMUState *s); + +static void riscv_iommu_update_ipsr (RISCVIOMMUState *s,uint64_t data) +{ +uint32_t cqcsr, fqcsr, pqcsr; +uint32_t ipsr_set =0 ; +uint32_t ipsr_clr =0 ; + +if (data &RISCV_IOMMU_IPSR_CIP ) { + cqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); + +if (cqcsr &RISCV_IOMMU_CQCSR_CIE && + (cqcsr &RISCV_IOMMU_CQCSR_FENCE_W_IP || + cqcsr &RISCV_IOMMU_CQCSR_CMD_ILL || + cqcsr &RISCV_IOMMU_CQCSR_CMD_TO || + cqcsr &RISCV_IOMMU_CQCSR_CQMF )) { + ipsr_set |=RISCV_IOMMU_IPSR_CIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_CIP ; + } + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_CIP ; + } + +if (data &RISCV_IOMMU_IPSR_FIP ) { + fqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); + +if (fqcsr &RISCV_IOMMU_FQCSR_FIE && + (fqcsr &RISCV_IOMMU_FQCSR_FQOF || + fqcsr &RISCV_IOMMU_FQCSR_FQMF )) { + ipsr_set |=RISCV_IOMMU_IPSR_FIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_FIP ; + } + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_FIP ; + } + +if (data &RISCV_IOMMU_IPSR_PIP ) { + pqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); + + if (pqcsr & RISCV_IOMMU_PQCSR_PIE && + (pqcsr & RISCV_IOMMU_PQCSR_PQOF ||
hw/riscv/riscv-iommu.c line 1144
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ pqcsr & RISCV_IOMMU_PQCSR_PQMF)) { + ipsr_set |=RISCV_IOMMU_IPSR_PIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_PIP ; + } + } else { + ipsr_clr |=RISCV_IOMMU_IPSR_PIP ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_IPSR , ipsr_set, ipsr_clr);
If the pending bit is cleared, we can deassert the WSI.
Quoted 526 lines
hw/riscv/riscv-iommu.c new file +497
-0+} + +static MemTxResult riscv_iommu_mmio_write (void *opaque,hwaddr addr, +uint64_t data,unsigned size,MemTxAttrs attrs) +{ +riscv_iommu_process_fn *process_fn =NULL ; +RISCVIOMMUState *s = opaque; +uint32_t regb = addr & ~3 ; +uint32_t busy =0 ; +uint64_t val =0 ; + +if ((addr & (size -1 )) !=0 ) { +/* Unsupported MMIO alignment or access size */ +return MEMTX_ERROR ; + } + +if (addr + size >RISCV_IOMMU_REG_MSI_CONFIG ) { +/* Unsupported MMIO access location. */ +return MEMTX_ACCESS_ERROR ; + } + +/* Track actionable MMIO write. */ +switch (regb) { +case RISCV_IOMMU_REG_DDTP : +case RISCV_IOMMU_REG_DDTP +4 : + process_fn = riscv_iommu_process_ddtp; + regb =RISCV_IOMMU_REG_DDTP ; + busy =RISCV_IOMMU_DDTP_BUSY ; +break ; + +case RISCV_IOMMU_REG_CQT : + process_fn = riscv_iommu_process_cq_tail; +break ; + +case RISCV_IOMMU_REG_CQCSR : + process_fn = riscv_iommu_process_cq_control; + busy =RISCV_IOMMU_CQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_FQCSR : + process_fn = riscv_iommu_process_fq_control; + busy =RISCV_IOMMU_FQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_PQCSR : + process_fn = riscv_iommu_process_pq_control; + busy =RISCV_IOMMU_PQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_IPSR : +/* +* IPSR has special procedures to update. Execute it +* and exit. +*/ +if (size ==4 ) { +uint32_t ro =ldl_le_p (&s->regs_ro[addr]); +uint32_t wc =ldl_le_p (&s->regs_wc[addr]); +uint32_t rw =ldl_le_p (&s->regs_rw[addr]); +stl_le_p (&val, ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==8 ) { +uint64_t ro =ldq_le_p (&s->regs_ro[addr]); +uint64_t wc =ldq_le_p (&s->regs_wc[addr]); +uint64_t rw =ldq_le_p (&s->regs_rw[addr]); +stq_le_p (&val, ((rw & ro) | (data & ~ro)) & ~(data & wc)); + } + +riscv_iommu_update_ipsr (s, val); + +return MEMTX_OK ; + +default : +break ; + } + +/* +* Registers update might be not synchronized with core logic. +* If system software updates register when relevant BUSY bit +* is set IOMMU behavior of additional writes to the register +* is UNSPECIFIED. +*/ +qemu_spin_lock (&s->regs_lock); +if (size ==1 ) { +uint8_t ro = s->regs_ro[addr]; +uint8_t wc = s->regs_wc[addr]; +uint8_t rw = s->regs_rw[addr]; + s->regs_rw[addr] = ((rw & ro) | (data & ~ro)) & ~(data & wc); + }else if (size ==2 ) { +uint16_t ro =lduw_le_p (&s->regs_ro[addr]); +uint16_t wc =lduw_le_p (&s->regs_wc[addr]); +uint16_t rw =lduw_le_p (&s->regs_rw[addr]); +stw_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==4 ) { +uint32_t ro =ldl_le_p (&s->regs_ro[addr]); +uint32_t wc =ldl_le_p (&s->regs_wc[addr]); +uint32_t rw =ldl_le_p (&s->regs_rw[addr]); +stl_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==8 ) { +uint64_t ro =ldq_le_p (&s->regs_ro[addr]); +uint64_t wc =ldq_le_p (&s->regs_wc[addr]); +uint64_t rw =ldq_le_p (&s->regs_rw[addr]); +stq_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + } + +/* Busy flag update, MSB 4-byte register. */ +if (busy) { +uint32_t rw =ldl_le_p (&s->regs_rw[regb]); +stl_le_p (&s->regs_rw[regb], rw | busy); + } +qemu_spin_unlock (&s->regs_lock); + +if (process_fn) { +qemu_mutex_lock (&s->core_lock); +process_fn (s); +qemu_mutex_unlock (&s->core_lock); + } + +return MEMTX_OK ; +} + +static MemTxResult riscv_iommu_mmio_read (void *opaque,hwaddr addr, +uint64_t *data,unsigned size,MemTxAttrs attrs) +{ +RISCVIOMMUState *s = opaque; +uint64_t val =-1 ; +uint8_t *ptr; + +if ((addr & (size -1 )) !=0 ) { +/* Unsupported MMIO alignment. */ +return MEMTX_ERROR ; + } + +if (addr + size >RISCV_IOMMU_REG_MSI_CONFIG ) { +return MEMTX_ACCESS_ERROR ; + } + + ptr = &s->regs_rw[addr]; + +if (size ==1 ) { + val = (uint64_t )*ptr; + }else if (size ==2 ) { + val =lduw_le_p (ptr); + }else if (size ==4 ) { + val =ldl_le_p (ptr); + }else if (size ==8 ) { + val =ldq_le_p (ptr); + }else { +return MEMTX_ERROR ; + } + + *data = val; + +return MEMTX_OK ; +} + +static const MemoryRegionOps riscv_iommu_mmio_ops = { + .read_with_attrs = riscv_iommu_mmio_read, + .write_with_attrs = riscv_iommu_mmio_write, + .endianness =DEVICE_NATIVE_ENDIAN , + .impl = { + .min_access_size =4 , + .max_access_size =8 , + .unaligned = false, + }, + .valid = { + .min_access_size =4 , + .max_access_size =8 , + } +}; + +/* +* Translations matching MSI pattern check are redirected to "riscv-iommu-trap" +* memory region as untranslated address, for additional MSI/MRIF interception +* by IOMMU interrupt remapping implementation. +* Note: Device emulation code generating an MSI is expected to provide a valid +* memory transaction attributes with requested_id set. +*/ +static MemTxResult riscv_iommu_trap_write (void *opaque,hwaddr addr, +uint64_t data,unsigned size,MemTxAttrs attrs) +{ +RISCVIOMMUState * s = (RISCVIOMMUState *)opaque; +RISCVIOMMUContext *ctx; +MemTxResult res; +void *ref; +uint32_t devid = attrs.requester_id; + +if (attrs.unspecified) { +return MEMTX_ACCESS_ERROR ; + } + +/* FIXME: PCIe bus remapping for attached endpoints. */ + devid |= s->bus <<8 ; + + ctx =riscv_iommu_ctx (s, devid,0 , &ref); +if (ctx ==NULL ) { + res =MEMTX_ACCESS_ERROR ; + }else { + res =riscv_iommu_msi_write (s, ctx, addr, data, size, attrs); + } +riscv_iommu_ctx_put (s, ref); +return res; +} + +static MemTxResult riscv_iommu_trap_read (void *opaque,hwaddr addr, +uint64_t *data,unsigned size,MemTxAttrs attrs) +{ +return MEMTX_ACCESS_ERROR ; +} + +static const MemoryRegionOps riscv_iommu_trap_ops = { + .read_with_attrs = riscv_iommu_trap_read, + .write_with_attrs = riscv_iommu_trap_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .impl = { + .min_access_size =4 , + .max_access_size =8 , + .unaligned = true, + }, + .valid = { + .min_access_size =4 , + .max_access_size =8 , + } +}; + +static void riscv_iommu_realize (DeviceState *dev,Error **errp) +{ +RISCVIOMMUState *s =RISCV_IOMMU (dev); + + s->cap = s->version &RISCV_IOMMU_CAP_VERSION ; +if (s->enable_msi) { + s->cap |=RISCV_IOMMU_CAP_MSI_FLAT |RISCV_IOMMU_CAP_MSI_MRIF ; + } +/* Report QEMU target physical address space limits */ + s->cap =set_field (s->cap,RISCV_IOMMU_CAP_PAS , +TARGET_PHYS_ADDR_SPACE_BITS ); + +/* TODO: method to report supported PASID bits */ + s->pasid_bits =8 ;/* restricted to size of MemTxAttrs.pasid */ + s->cap |=RISCV_IOMMU_CAP_PD8 ; + +/* Out-of-reset translation mode: OFF (DMA disabled) BARE (passthrough) */ + s->ddtp =set_field (0 ,RISCV_IOMMU_DDTP_MODE , s->enable_off ? +RISCV_IOMMU_DDTP_MODE_OFF :RISCV_IOMMU_DDTP_MODE_BARE ); + +/* register storage */ + s->regs_rw =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + s->regs_ro =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + s->regs_wc =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + +/* Mark all registers read-only */ +memset (s->regs_ro,0xff ,RISCV_IOMMU_REG_SIZE ); + +/* +* Register complete MMIO space, including MSI/PBA registers. +* Note, PCIDevice implementation will add overlapping MR for MSI/PBA, +* managed directly by the PCIDevice implementation. +*/ +memory_region_init_io (&s->regs_mr,OBJECT (dev), &riscv_iommu_mmio_ops, s, +"riscv-iommu-regs" ,RISCV_IOMMU_REG_SIZE ); + +/* Set power-on register state */ +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_CAP ], s->cap); +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_FCTL ],0 ); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_FCTL ], + ~(RISCV_IOMMU_FCTL_BE |RISCV_IOMMU_FCTL_WSI )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_DDTP ], + ~(RISCV_IOMMU_DDTP_PPN |RISCV_IOMMU_DDTP_MODE )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQB ], + ~(RISCV_IOMMU_CQB_LOG2SZ |RISCV_IOMMU_CQB_PPN )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQB ], + ~(RISCV_IOMMU_FQB_LOG2SZ |RISCV_IOMMU_FQB_PPN )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQB ], + ~(RISCV_IOMMU_PQB_LOG2SZ |RISCV_IOMMU_PQB_PPN )); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_CQCSR ],RISCV_IOMMU_CQCSR_CQMF | +RISCV_IOMMU_CQCSR_CMD_TO |RISCV_IOMMU_CQCSR_CMD_ILL ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQCSR ],RISCV_IOMMU_CQCSR_CQON | +RISCV_IOMMU_CQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_FQCSR ],RISCV_IOMMU_FQCSR_FQMF | +RISCV_IOMMU_FQCSR_FQOF ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQCSR ],RISCV_IOMMU_FQCSR_FQON | +RISCV_IOMMU_FQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_PQCSR ],RISCV_IOMMU_PQCSR_PQMF | +RISCV_IOMMU_PQCSR_PQOF ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQCSR ],RISCV_IOMMU_PQCSR_PQON | +RISCV_IOMMU_PQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_IPSR ], ~0 ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_IVEC ],0 ); +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_DDTP ], s->ddtp); + +/* Memory region for downstream access, if specified. */ +if (s->target_mr) { + s->target_as =g_new0 (AddressSpace,1 ); +address_space_init (s->target_as, s->target_mr, +"riscv-iommu-downstream" ); + }else { +/* Fallback to global system memory. */ + s->target_as = &address_space_memory; + } + +/* Memory region for untranslated MRIF/MSI writes */ +memory_region_init_io (&s->trap_mr,OBJECT (dev), &riscv_iommu_trap_ops, s, +"riscv-iommu-trap" , ~0ULL ); +address_space_init (&s->trap_as, &s->trap_mr,"riscv-iommu-trap-as" ); + +/* Device translation context cache */ + s->ctx_cache =g_hash_table_new_full (__ctx_hash, __ctx_equal, + g_free,NULL ); +qemu_mutex_init (&s->ctx_lock); + + s->iommus.le_next =NULL ; + s->iommus.le_prev =NULL ; +QLIST_INIT (&s->spaces); +qemu_mutex_init (&s->core_lock); +qemu_spin_init (&s->regs_lock); +} + +static void riscv_iommu_unrealize (DeviceState *dev) +{ +RISCVIOMMUState *s =RISCV_IOMMU (dev); + +qemu_mutex_destroy (&s->core_lock); +g_hash_table_unref (s->ctx_cache); +} + +static Property riscv_iommu_properties[] = { +DEFINE_PROP_UINT32 ("version" , RISCVIOMMUState, version, +RISCV_IOMMU_SPEC_DOT_VER ), +DEFINE_PROP_UINT32 ("bus" , RISCVIOMMUState, bus,0x0 ), +DEFINE_PROP_BOOL ("intremap" , RISCVIOMMUState, enable_msi, TRUE), +DEFINE_PROP_BOOL ("off" , RISCVIOMMUState, enable_off, TRUE), +DEFINE_PROP_LINK ("downstream-mr" , RISCVIOMMUState, target_mr, + TYPE_MEMORY_REGION, MemoryRegion *), +DEFINE_PROP_END_OF_LIST (), +}; + +static void riscv_iommu_class_init (ObjectClass *klass,void * data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + +/* internal device for riscv-iommu-{pci/sys}, not user-creatable */ + dc->user_creatable = false; + dc->realize = riscv_iommu_realize; + dc->unrealize = riscv_iommu_unrealize; +device_class_set_props (dc, riscv_iommu_properties); +} + +static const TypeInfo riscv_iommu_info = { + .name =TYPE_RISCV_IOMMU , + .parent =TYPE_DEVICE , + .instance_size =sizeof (RISCVIOMMUState), + .class_init = riscv_iommu_class_init, +}; + +static const char *IOMMU_FLAG_STR [] = { +"NA" , +"RO" , +"WR" , +"RW" , +}; + +/* RISC-V IOMMU Memory Region - Address Translation Space */ +static IOMMUTLBEntry riscv_iommu_memory_region_translate ( +IOMMUMemoryRegion *iommu_mr,hwaddr addr, +IOMMUAccessFlags flag,int iommu_idx) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); +RISCVIOMMUContext *ctx; +void *ref; +IOMMUTLBEntry iotlb = { + .iova = addr, + .target_as = as->iommu->target_as, + .addr_mask = ~0ULL , + .perm = flag, + }; + + ctx =riscv_iommu_ctx (as->iommu, as->devid, iommu_idx, &ref); +if (ctx ==NULL ) { +/* Translation disabled or invalid. */ + iotlb.addr_mask =0 ; + iotlb.perm =IOMMU_NONE ; + }else if (riscv_iommu_translate (as->iommu, ctx, &iotlb)) { +/* Translation disabled or fault reported. */ + iotlb.addr_mask =0 ; + iotlb.perm =IOMMU_NONE ; + } + +/* Trace all dma translations with original access flags. */ +trace_riscv_iommu_dma (as->iommu->parent_obj.id,PCI_BUS_NUM (as->devid), +PCI_SLOT (as->devid),PCI_FUNC (as->devid), iommu_idx, +IOMMU_FLAG_STR [flag &IOMMU_RW ], iotlb.iova, + iotlb.translated_addr); + +riscv_iommu_ctx_put (as->iommu, ref); + +return iotlb; +} + +static int riscv_iommu_memory_region_notify ( +IOMMUMemoryRegion *iommu_mr,IOMMUNotifierFlag old, +IOMMUNotifierFlag new,Error **errp) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); + +if (old ==IOMMU_NOTIFIER_NONE ) { + as->notifier = true; +trace_riscv_iommu_notifier_add (iommu_mr->parent_obj.name); + }else if (new ==IOMMU_NOTIFIER_NONE ) { + as->notifier = false; +trace_riscv_iommu_notifier_del (iommu_mr->parent_obj.name); + } + +return 0 ; +} + +static inline bool pci_is_iommu (PCIDevice *pdev) +{ +return pci_get_word (pdev->config +PCI_CLASS_DEVICE ) ==0x0806 ; +} + +static AddressSpace *riscv_iommu_find_as (PCIBus *bus,void *opaque,int devfn) +{ +RISCVIOMMUState *s = (RISCVIOMMUState *) opaque; +PCIDevice *pdev =pci_find_device (bus,pci_bus_num (bus), devfn); +AddressSpace *as =NULL ; + +if (pdev &&pci_is_iommu (pdev)) { +return s->target_as; + } + +/* Find first registered IOMMU device */ +while (s->iommus.le_prev) { + s = *(s->iommus.le_prev); + } + +/* Find first matching IOMMU */ +while (s !=NULL && as ==NULL ) { + as =riscv_iommu_space (s,PCI_BUILD_BDF (pci_bus_num (bus), devfn)); + s = s->iommus.le_next; + } + +return as ? as : &address_space_memory; +} + +static const PCIIOMMUOps riscv_iommu_ops = { + .get_address_space = riscv_iommu_find_as, +}; + +void riscv_iommu_pci_setup_iommu (RISCVIOMMUState *iommu,PCIBus *bus, +Error **errp) +{ +if (bus->iommu_ops && + bus->iommu_ops->get_address_space == riscv_iommu_find_as) { +/* Allow multiple IOMMUs on the same PCIe bus, link known devices */ +RISCVIOMMUState *last = (RISCVIOMMUState *)bus->iommu_opaque; +QLIST_INSERT_AFTER (last, iommu, iommus); + }else if (!bus->iommu_ops && !bus->iommu_opaque) { +pci_setup_iommu (bus, &riscv_iommu_ops, iommu); + }else { +error_setg (errp,"can't register secondary IOMMU for PCI bus #%d" , +pci_bus_num (bus)); + } +} + +static int riscv_iommu_memory_region_index (IOMMUMemoryRegion *iommu_mr, +MemTxAttrs attrs) +{ +return attrs.unspecified ?RISCV_IOMMU_NOPROCID : (int )attrs.pasid; +} + +static int riscv_iommu_memory_region_index_len (IOMMUMemoryRegion *iommu_mr) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); +return 1 << as->iommu->pasid_bits; +} + +static void riscv_iommu_memory_region_init (ObjectClass *klass,void *data) +{ +IOMMUMemoryRegionClass *imrc =IOMMU_MEMORY_REGION_CLASS (klass); + + imrc->translate = riscv_iommu_memory_region_translate; + imrc->notify_flag_changed = riscv_iommu_memory_region_notify; + imrc->attrs_to_index = riscv_iommu_memory_region_index; + imrc->num_indexes = riscv_iommu_memory_region_index_len; +} + +static const TypeInfo riscv_iommu_memory_region_info = { + .parent =TYPE_IOMMU_MEMORY_REGION , + .name =TYPE_RISCV_IOMMU_MEMORY_REGION , + .class_init = riscv_iommu_memory_region_init, +}; + +static void riscv_iommu_register_mr_types (void ) +{ +type_register_static (&riscv_iommu_memory_region_info); +type_register_static (&riscv_iommu_info); +} + +type_init (riscv_iommu_register_mr_types);hw/riscv/riscv-iommu.h new file +23
-0@@ -0,0 +1,142 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2022-2023 Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef HW_RISCV_IOMMU_STATE_H +#define HW_RISCV_IOMMU_STATE_H + +#include "qemu/osdep.h" +#include "qom/object.h"
hw/riscv/riscv-iommu.h line 33
Quoted 10 lines
hw/riscv/riscv-iommu.h new file +10
-0+ +#include "hw/riscv/iommu.h" + +struct RISCVIOMMUState { +/*< private >*/ +DeviceState parent_obj; + +/*< public >*/ +uint32_t version;/* Reported interface version number */ +uint32_t pasid_bits;/* process identifier width */
Do you mind renaming pasid_bits to something like pid_bits to remain consistency?
Quoted 187 lines
hw/riscv/riscv-iommu.h new file +109
-0+uint32_t bus;/* PCI bus mapping for non-root endpoints */ + +uint64_t cap;/* IOMMU supported capabilities */ +uint64_t fctl;/* IOMMU enabled features */ + +bool enable_off;/* Enable out-of-reset OFF mode (DMA disabled) */ +bool enable_msi;/* Enable MSI remapping */ + +/* IOMMU Internal State */ +uint64_t ddtp;/* Validated Device Directory Tree Root Pointer */ + +dma_addr_t cq_addr;/* Command queue base physical address */ +dma_addr_t fq_addr;/* Fault/event queue base physical address */ +dma_addr_t pq_addr;/* Page request queue base physical address */ + +uint32_t cq_mask;/* Command queue index bit mask */ +uint32_t fq_mask;/* Fault/event queue index bit mask */ +uint32_t pq_mask;/* Page request queue index bit mask */ + +/* interrupt notifier */ +void (*notify)(RISCVIOMMUState *iommu,unsigned vector); + +/* IOMMU State Machine */ +QemuThread core_proc;/* Background processing thread */ +QemuMutex core_lock;/* Global IOMMU lock, used for cache/regs updates */ +QemuCond core_cond;/* Background processing wake up signal */ +unsigned core_exec;/* Processing thread execution actions */ + +/* IOMMU target address space */ +AddressSpace *target_as; +MemoryRegion *target_mr; + +/* MSI / MRIF access trap */ +AddressSpace trap_as; +MemoryRegion trap_mr; + +GHashTable *ctx_cache;/* Device translation Context Cache */ +QemuMutex ctx_lock;/* Device translation Cache update lock */ + +/* MMIO Hardware Interface */ +MemoryRegion regs_mr; +QemuSpin regs_lock; +uint8_t *regs_rw;/* register state (user write) */ +uint8_t *regs_wc;/* write-1-to-clear mask */ +uint8_t *regs_ro;/* read-only mask */ + +QLIST_ENTRY (RISCVIOMMUState) iommus; + QLIST_HEAD(, RISCVIOMMUSpace) spaces; +}; + +void riscv_iommu_pci_setup_iommu (RISCVIOMMUState *iommu,PCIBus *bus, +Error **errp); + +/* private helpers */ + +/* Register helper functions */ +static inline uint32_t riscv_iommu_reg_mod32 (RISCVIOMMUState *s, +unsigned idx,uint32_t set,uint32_t clr) +{ +uint32_t val; +qemu_spin_lock (&s->regs_lock); + val =ldl_le_p (s->regs_rw + idx); +stl_le_p (s->regs_rw + idx, (val & ~clr) | set); +qemu_spin_unlock (&s->regs_lock); +return val; +} + +static inline void riscv_iommu_reg_set32 (RISCVIOMMUState *s, +unsigned idx,uint32_t set) +{ +qemu_spin_lock (&s->regs_lock); +stl_le_p (s->regs_rw + idx, set); +qemu_spin_unlock (&s->regs_lock); +} + +static inline uint32_t riscv_iommu_reg_get32 (RISCVIOMMUState *s, +unsigned idx) +{ +return ldl_le_p (s->regs_rw + idx); +} + +static inline uint64_t riscv_iommu_reg_mod64 (RISCVIOMMUState *s, +unsigned idx,uint64_t set,uint64_t clr) +{ +uint64_t val; +qemu_spin_lock (&s->regs_lock); + val =ldq_le_p (s->regs_rw + idx); +stq_le_p (s->regs_rw + idx, (val & ~clr) | set); +qemu_spin_unlock (&s->regs_lock); +return val; +} + +static inline void riscv_iommu_reg_set64 (RISCVIOMMUState *s, +unsigned idx,uint64_t set) +{ +qemu_spin_lock (&s->regs_lock); +stq_le_p (s->regs_rw + idx, set); +qemu_spin_unlock (&s->regs_lock); +} + +static inline uint64_t riscv_iommu_reg_get64 (RISCVIOMMUState *s, +unsigned idx) +{ +return ldq_le_p (s->regs_rw + idx); +} + + + +#endif hw/riscv/trace-events new file +11
-0@@ -0,0 +1,11 @@ +# See documentation at docs/devel/tracing.rst + +# riscv-iommu.c +riscv_iommu_new(const char *id, unsigned b, unsigned d, unsigned f) "%s: device attached %04x:%02x.%d" +riscv_iommu_flt(const char *id, unsigned b, unsigned d, unsigned f, uint64_t reason, uint64_t iova) "%s: fault %04x:%02x.%u reason: 0x%"PRIx64" iova: 0x%"PRIx64 +riscv_iommu_pri(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova) "%s: page request %04x:%02x.%u iova: 0x%"PRIx64 +riscv_iommu_dma(const char *id, unsigned b, unsigned d, unsigned f, unsigned pasid, const char *dir, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u #%u %s 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_msi(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u MSI 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_cmd(const char *id, uint64_t l, uint64_t u) "%s: command 0x%"PRIx64" 0x%"PRIx64 +riscv_iommu_notifier_add(const char *id) "%s: dev-iotlb notifier added" +riscv_iommu_notifier_del(const char *id) "%s: dev-iotlb notifier removed"hw/riscv/trace.h new file +1
-0@@ -0,0 +1 @@ +#include "trace/trace-hw_riscv.h" include/hw/riscv/iommu.h new file +36
-0@@ -0,0 +1,36 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2022-2023 Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef HW_RISCV_IOMMU_H +#define HW_RISCV_IOMMU_H + +#include "qemu/osdep.h" +#include "qom/object.h" + +#define TYPE_RISCV_IOMMU "riscv-iommu" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUState, RISCV_IOMMU) +typedef struct RISCVIOMMUState RISCVIOMMUState ; + +#define TYPE_RISCV_IOMMU_MEMORY_REGION "riscv-iommu-mr" +typedef struct RISCVIOMMUSpace RISCVIOMMUSpace ; + +#define TYPE_RISCV_IOMMU_PCI "riscv-iommu-pci" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUStatePci, RISCV_IOMMU_PCI) +typedef struct RISCVIOMMUStatePci RISCVIOMMUStatePci ; + +#endif meson.build +1
-0@@ -3353,6 +3353,7 @@ if have_system 'hw/pci-host', 'hw/ppc', 'hw/rtc', + 'hw/riscv', 'hw/s390x', 'hw/scsi', 'hw/sd',
Re: [PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation
Hi,
Quoted 38 lines · Jason Chien
Hi Danial,
Quoted 35 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at:
https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf
Add the foundation of the device emulation for RISC-V IOMMU, which includes an IOMMU that has no capabilities but MSI interrupt support and fault queue interfaces. We'll add more features incrementally in the next patches.
Co-developed-by Sebastien Boeuf <[email protected]>Signed-off-by Sebastien Boeuf <[email protected]>Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>---
hw/riscv/Kconfig | 4 +
hw/riscv/meson.build | 1 +hw/riscv/riscv-iommu-bits.h| 2 + hw/riscv/riscv-iommu.c | 1641 +++++++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 142 +++ hw/riscv/trace-events | 11 +
hw/riscv/trace.h | 1 + include/hw/riscv/iommu.h | 36 +
meson.build | 1 +9 files changed, 1839 insertions(+)create mode 100644
hw/riscv/riscv-iommu.c
create mode 100644hw/riscv/riscv-iommu.h
create mode 100644 hw/riscv/trace-events
create mode 100644hw/riscv/trace.h
create mode 100644include/hw/riscv/iommu.hhw/riscv/Kconfig +0
-0
(...)
Quoted 10 lines
hw/riscv/Kconfig
Quoted 9 lines
hw/riscv/Kconfig +9
-0+/* IOMMU index for transactions without process_id specified. */ +#define RISCV_IOMMU_NOPROCID 0 + +static void riscv_iommu_notify(RISCVIOMMUState *s, int vec) +{ + const uint32_t fctl = riscv_iommu_reg_get32(s, RISCV_IOMMU_REG_FCTL); + uint32_t ipsr, ivec; + + if (fctl & RISCV_IOMMU_FCTL_WSI || !s->notify) {For WSI, we can assert INTx by invoking
pci_set_irq().
For now we're not advertising WSI support because we don't have a way to test it (riscv-iommu-pci only supports MSI). In fact riscv_iommu_notify() isn't called for any WSI capable device, at least for now.
I'm finishing some patches where we'll re-introduce riscv-iommu-sys in the 'virt' machine with WSI. At that point we'll pay more attention with the WSI bits that we're ignoring for now.
Quoted 11 lines
Quoted 11 lines
+ return;
+ }hw/riscv/Kconfig +9
-0+ + ipsr = riscv_iommu_reg_mod32(s, RISCV_IOMMU_REG_IPSR, (1 << vec), 0); + ivec = riscv_iommu_reg_get32(s, RISCV_IOMMU_REG_IVEC); + + if (!(ipsr & (1 << vec))) { + s->notify(s, (ivec >> (vec * 4)) & 0x0F); + } +} +
(...)
Quoted 8 lines
hw/riscv/Kconfig
Quoted 5 lines
hw/riscv/Kconfig +5
-0+ +/* Check if GPA matches MSI/MRIF pattern. */ +static bool riscv_iommu_msi_check(RISCVIOMMUState *s, RISCVIOMMUContext *ctx, + dma_addr_t gpa) +{If IOMMU does not support MSI, that is,
s->enable_msiis false, we can return false.
Done.
Quoted 17 lines
Quoted 17 lines
+ if (
get_field(ctx->msiptp, RISCV_IOMMU_DC_MSIPTP_MODE)!= +RISCV_IOMMU_DC_MSIPTP_MODE_FLAT) {
+ return false; /* Invalid MSI/MRIF mode */
+ }hw/riscv/Kconfig +13
-0+ + if ((PPN_DOWN(gpa) ^ ctx->msi_addr_pattern) & ~ctx->msi_addr_mask) { + return false; /* GPA not in MSI range defined by AIA IMSIC rules. */ + } + + return true; +} + +/* RISCV IOMMU Address Translation Lookup - Page Table Walk */ +static int riscv_iommu_spa_fetch(RISCVIOMMUState *s, RISCVIOMMUContext *ctx, + IOMMUTLBEntry *iotlb) +{ + /* Early check for MSI address match when IOVA == GPA */
Quoted 8 lines
Quoted 7 lines
+ if (
iotlb->perm&IOMMU_WO&&
+riscv_iommu_msi_check(s, ctx, iotlb->iova)) { +iotlb->target_as=&s->trap_as;
+iotlb->translated_addr=iotlb->iova; +iotlb->addr_mask= ~TARGET_PAGE_MASK; + return 0;
+ }From spec 2.3, step 17 and step 18 state that the MSI address translation is always done after the first stage translation is done.
This piece of code isn't doing MSI addr translation. It's preventing the lookup process by doing an early exit if IOVA==GPA, i.e. there's nothing to translate.
What you described is being done in patch 8 with s-stage and g-stage support.
(...)
Quoted 7 lines
Quoted 7 lines
hw/riscv/Kconfig +7
-0+/* Redirect MSI write for given GPA. */ +static MemTxResult riscv_iommu_msi_write(RISCVIOMMUState *s, + RISCVIOMMUContext *ctx, uint64_t gpa, uint64_t data, + unsigned size, MemTxAttrs attrs) +{ + MemTxResult res; + dma_addr_t addr;
Quoted 8 lines
Quoted 7 lines
+
uint64_tintn;
+uint32_tn190;
+uint64_tpte[2];
+ intfault_type=RISCV_IOMMU_FQ_TTYPE_UADDR_WR; + int cause;
+
+ if (!riscv_iommu_msi_check(s, ctx, gpa)) {I think we have invoked
riscv_iommu_msi_check()before writing tos->trap_as. Do we need this check?
You're right. Removed.
(...)
Quoted 9 lines
Quoted 9 lines
hw/riscv/Kconfig +9
-0+ + if (data & RISCV_IOMMU_IPSR_PIP) { + pqcsr = riscv_iommu_reg_get32(s, RISCV_IOMMU_REG_PQCSR); + + if (pqcsr & RISCV_IOMMU_PQCSR_PIE && + (pqcsr & RISCV_IOMMU_PQCSR_PQOF || + pqcsr & RISCV_IOMMU_PQCSR_PQMF)) { + ipsr_set |= RISCV_IOMMU_IPSR_PIP; + } else {
Quoted 8 lines
Quoted 7 lines
+
ipsr_clr|=RISCV_IOMMU_IPSR_PIP;
+ }
+ } else {
+ipsr_clr|=RISCV_IOMMU_IPSR_PIP;
+ }
+
+riscv_iommu_reg_mod32(s, RISCV_IOMMU_REG_IPSR, ipsr_set, ipsr_clr);If the pending bit is cleared, we can deassert the WSI.
I'll make a note to remind about this later when we add WSI support.
(...)
Quoted 8 lines
Quoted 8 lines
hw/riscv/Kconfig +8
-0+#ifndef HW_RISCV_IOMMU_STATE_H +#define HW_RISCV_IOMMU_STATE_H + +#include "qemu/osdep.h" +#include "qom/object.h" + +#include "hw/riscv/iommu.h" +
Quoted 8 lines
hw/riscv/Kconfig
Quoted 7 lines
hw/riscv/Kconfig +7
-0+struct RISCVIOMMUState { + /*< private >*/ + DeviceState parent_obj; + + /*< public >*/ + uint32_t version; /* Reported interface version number */ + uint32_t pasid_bits; /* process identifier width */Do you mind renaming
pasid_bitsto something likepid_bitsto remain consistency?
Done. In fact I also renamed 'pasid' from the first patch to 'pid' as well.
Thanks,
Daniel
Re: [PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation
In reply to Jason ChienQuoted 361 lines · Jason Chien
Hi Danial,
Quoted 153 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at:
https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf
Add the foundation of the device emulation for RISC-V IOMMU, which includes an IOMMU that has no capabilities but MSI interrupt support and fault queue interfaces. We'll add more features incrementally in the next patches.
Co-developed-by Sebastien Boeuf <[email protected]>Signed-off-by Sebastien Boeuf <[email protected]>Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>--- hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/riscv/riscv-iommu-bits.h | 2 + hw/riscv/riscv-iommu.c | 1641 +++++++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 142 +++ hw/riscv/trace-events | 11 + hw/riscv/trace.h | 1 + include/hw/riscv/iommu.h | 36 + meson.build | 1 + 9 files changed, 1839 insertions(+)create mode 100644
hw/riscv/riscv-iommu.c
create mode 100644hw/riscv/riscv-iommu.h
create mode 100644 hw/riscv/trace-events
create mode 100644hw/riscv/trace.h
create mode 100644include/hw/riscv/iommu.hhw/riscv/Kconfig +4
-0@@ -1,3 +1,6 @@ +config RISCV_IOMMU + bool + config RISCV_NUMA bool@@ -47,6 +50,7 @@ config RISCV_VIRT select SERIAL select RISCV_ACLINT select RISCV_APLIC + select RISCV_IOMMU select RISCV_IMSIC select SIFIVE_PLIC select SIFIVE_TESThw/riscv/meson.build +1
-0@@ -10,5 +10,6 @@ riscv_ss.add(when: 'CONFIG_SIFIVE_U', if_true: files('sifive_u.c')) riscv_ss.add(when: 'CONFIG_SPIKE', if_true: files('spike.c')) riscv_ss.add(when: 'CONFIG_MICROCHIP_PFSOC', if_true: files('microchip_pfsoc.c')) riscv_ss.add(when: 'CONFIG_ACPI', if_true: files('virt-acpi-build.c')) +riscv_ss.add(when: 'CONFIG_RISCV_IOMMU', if_true: files('riscv-iommu.c')) hw_arch += {'riscv': riscv_ss}hw/riscv/riscv-iommu-bits.h +2
-0@@ -82,6 +82,7 @@ struct riscv_iommu_pq_record {/* 5.4 Features control register (32bits) */ #define RISCV_IOMMU_REG_FCTL 0x0008 +#define RISCV_IOMMU_FCTL_BE BIT(0)#define RISCV_IOMMU_FCTL_WSI BIT(1)/* 5.5 Device-directory-table pointer (64bits) */ @@ -311,6 +312,7 @@ enum riscv_iommu_fq_causes {/* Translation attributes fields */ #define RISCV_IOMMU_PC_TA_V BIT_ULL(0) +#define RISCV_IOMMU_PC_TA_RESERVED GENMASK_ULL(63, 32)/* First stage context fields */ #define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0)hw/riscv/riscv-iommu.c new file +64
-0@@ -0,0 +1,1641 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2021-2023, Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#include "qemu/osdep.h" +#include "qom/object.h" +#include "hw/pci/pci_bus.h" +#include "hw/pci/pci_device.h" +#include "hw/qdev-properties.h" +#include "hw/riscv/riscv_hart.h" +#include "migration/vmstate.h" +#include "qapi/error.h" +#include "qemu/timer.h" + +#include "cpu_bits.h" +#include "riscv-iommu.h" +#include "riscv-iommu-bits.h" +#include "trace.h" + +#define LIMIT_CACHE_CTX (1U << 7) +#define LIMIT_CACHE_IOT (1U << 20) + +/* Physical page number coversions */ +#define PPN_PHYS (ppn) ((ppn) << TARGET_PAGE_BITS) +#define PPN_DOWN (phy) ((phy) >> TARGET_PAGE_BITS) + +typedef struct RISCVIOMMUContext RISCVIOMMUContext ; +typedef struct RISCVIOMMUEntry RISCVIOMMUEntry ; + +/* Device assigned I/O address space */ +struct RISCVIOMMUSpace { +IOMMUMemoryRegion iova_mr;/* IOVA memory region for attached device */ +AddressSpace iova_as;/* IOVA address space for attached device */ +RISCVIOMMUState *iommu;/* Managing IOMMU device state */ +uint32_t devid;/* Requester identifier, AKA device_id */ +bool notifier;/* IOMMU unmap notifier enabled */ +QLIST_ENTRY (RISCVIOMMUSpace) list; +}; + +/* Device translation context state. */ +struct RISCVIOMMUContext { +uint64_t devid:24 ;/* Requester Id, AKA device_id */ +uint64_t process_id:20 ;/* Process ID. PASID for PCIe */ +uint64_t __rfu:20 ;/* reserved */ +uint64_t tc;/* Translation Control */ +uint64_t ta;/* Translation Attributes */ +uint64_t msi_addr_mask;/* MSI filtering - address mask */ +uint64_t msi_addr_pattern;/* MSI filtering - address pattern */ +uint64_t msiptp;/* MSI redirection page table pointer */ +};hw/riscv/riscv-iommu.c line 74
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ +/* IOMMU index for transactions without process_id specified. */ +#define RISCV_IOMMU_NOPROCID 0 + +static void riscv_iommu_notify (RISCVIOMMUState *s,int vec) +{ +const uint32_t fctl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FCTL ); +uint32_t ipsr, ivec; + +if (fctl &RISCV_IOMMU_FCTL_WSI || !s->notify) {For WSI, we can assert INTx by invoking
pci_set_irq().Quoted 97 lines
hw/riscv/riscv-iommu.c new file +97
-0+return ; + } + + ipsr =riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_IPSR , (1 << vec),0 ); + ivec =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_IVEC ); + +if (!(ipsr & (1 << vec))) { + s->notify (s, (ivec >> (vec *4 )) &0x0F ); + } +} + +static void riscv_iommu_fault (RISCVIOMMUState *s, +struct riscv_iommu_fq_record *ev) +{ +uint32_t ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); +uint32_t head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQH ) & s->fq_mask; +uint32_t tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQT ) & s->fq_mask; +uint32_t next = (tail +1 ) & s->fq_mask; +uint32_t devid =get_field (ev->hdr,RISCV_IOMMU_FQ_HDR_DID ); + +trace_riscv_iommu_flt (s->parent_obj.id,PCI_BUS_NUM (devid),PCI_SLOT (devid), +PCI_FUNC (devid), ev->hdr, ev->iotval); + +if (!(ctrl &RISCV_IOMMU_FQCSR_FQON ) || + !!(ctrl & (RISCV_IOMMU_FQCSR_FQOF |RISCV_IOMMU_FQCSR_FQMF ))) { +return ; + } + +if (head == next) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , +RISCV_IOMMU_FQCSR_FQOF ,0 ); + }else { +dma_addr_t addr = s->fq_addr + tail *sizeof (*ev); +if (dma_memory_write (s->target_as, addr, ev,sizeof (*ev), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , +RISCV_IOMMU_FQCSR_FQMF ,0 ); + }else { +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_FQT , next); + } + } + +if (ctrl &RISCV_IOMMU_FQCSR_FIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_FQ ); + } +} + +static void riscv_iommu_pri (RISCVIOMMUState *s, +struct riscv_iommu_pq_record *pr) +{ +uint32_t ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); +uint32_t head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQH ) & s->pq_mask; +uint32_t tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQT ) & s->pq_mask; +uint32_t next = (tail +1 ) & s->pq_mask; +uint32_t devid =get_field (pr->hdr,RISCV_IOMMU_PREQ_HDR_DID ); + +trace_riscv_iommu_pri (s->parent_obj.id,PCI_BUS_NUM (devid),PCI_SLOT (devid), +PCI_FUNC (devid), pr->payload); + +if (!(ctrl &RISCV_IOMMU_PQCSR_PQON ) || + !!(ctrl & (RISCV_IOMMU_PQCSR_PQOF |RISCV_IOMMU_PQCSR_PQMF ))) { +return ; + } + +if (head == next) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , +RISCV_IOMMU_PQCSR_PQOF ,0 ); + }else { +dma_addr_t addr = s->pq_addr + tail *sizeof (*pr); +if (dma_memory_write (s->target_as, addr, pr,sizeof (*pr), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , +RISCV_IOMMU_PQCSR_PQMF ,0 ); + }else { +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_PQT , next); + } + } + +if (ctrl &RISCV_IOMMU_PQCSR_PIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_PQ ); + } +} + +/* Portable implementation of pext_u64, bit-mask extraction. */ +static uint64_t _pext_u64 (uint64_t val,uint64_t ext) +{ +uint64_t ret =0 ; +uint64_t rot =1 ; + +while (ext) { +if (ext &1 ) { +if (val &1 ) { + ret |= rot; + } + rot <<=1 ; + } + val >>=1 ;hw/riscv/riscv-iommu.c line 181
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ ext >>=1 ; + } + +return ret; +} + +/* Check if GPA matches MSI/MRIF pattern. */ +static bool riscv_iommu_msi_check (RISCVIOMMUState *s,RISCVIOMMUContext *ctx, +dma_addr_t gpa) +{If IOMMU does not support MSI, that is,
s->enable_msiis false, we can return false.Quoted 14 lines
hw/riscv/riscv-iommu.c new file +14
-0+if (get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_MODE ) != +RISCV_IOMMU_DC_MSIPTP_MODE_FLAT ) { +return false;/* Invalid MSI/MRIF mode */ + } + +if ((PPN_DOWN (gpa) ^ ctx->msi_addr_pattern) & ~ctx->msi_addr_mask) { +return false;/* GPA not in MSI range defined by AIA IMSIC rules. */ + } + +return true; +} + +/* RISCV IOMMU Address Translation Lookup - Page Table Walk */ +static int riscv_iommu_spa_fetch(RISCVIOMMUState *s, RISCVIOMMUContext *ctx,hw/riscv/riscv-iommu.c line 205
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ IOMMUTLBEntry *iotlb) +{ +/* Early check for MSI address match when IOVA == GPA */ +if (iotlb->perm &IOMMU_WO && +riscv_iommu_msi_check (s, ctx, iotlb->iova)) { + iotlb->target_as = &s->trap_as; + iotlb->translated_addr = iotlb->iova; + iotlb->addr_mask = ~TARGET_PAGE_MASK ; +return 0 ; + }From spec 2.3, step 17 and step 18 state that the MSI address
translation is always done after the first stage translation is done.Quoted 56 lines
hw/riscv/riscv-iommu.c new file +56
-0+ +/* Exit early for pass-through mode. */ + iotlb->translated_addr = iotlb->iova; + iotlb->addr_mask = ~TARGET_PAGE_MASK ; +/* Allow R/W in pass-through mode */ + iotlb->perm =IOMMU_RW ; +return 0 ; +} + +static void riscv_iommu_report_fault (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx, +uint32_t fault_type,uint32_t cause, +bool pv, +uint64_t iotval,uint64_t iotval2) +{ +struct riscv_iommu_fq_record ev = {0 }; + +if (ctx->tc &RISCV_IOMMU_DC_TC_DTF ) { +switch (cause) { +case RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED : +case RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT : +case RISCV_IOMMU_FQ_CAUSE_DDT_INVALID : +case RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED : +case RISCV_IOMMU_FQ_CAUSE_DDT_CORRUPTED : +case RISCV_IOMMU_FQ_CAUSE_INTERNAL_DP_ERROR : +case RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT : +break ; +default : +/* DTF prevents reporting a fault for this given cause */ +return ; + } + } + + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_CAUSE , cause); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_TTYPE , fault_type); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_DID , ctx->devid); + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_PV , true); + +if (pv) { + ev.hdr =set_field (ev.hdr,RISCV_IOMMU_FQ_HDR_PID , ctx->process_id); + } + + ev.iotval = iotval; + ev.iotval2 = iotval2; + +riscv_iommu_fault (s, &ev); +} + +/* Redirect MSI write for given GPA. */ +static MemTxResult riscv_iommu_msi_write (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx,uint64_t gpa,uint64_t data, +unsigned size,MemTxAttrs attrs) +{ +MemTxResult res; +dma_addr_t addr; +uint64_t intn;
Quoted 8 lines
hw/riscv/riscv-iommu.c line 267
Quoted 6 lines
hw/riscv/riscv-iommu.c new file +6
-0+uint32_t n190; +uint64_t pte[2 ]; +int fault_type =RISCV_IOMMU_FQ_TTYPE_UADDR_WR ; +int cause; + +if (!riscv_iommu_msi_check (s, ctx, gpa)) {I think we have invoked
riscv_iommu_msi_check()before writing tos->trap_as. Do we need this check?
As we have no control how/when devices will use translated address space this check was added to detect incorrect use of returned address space for IOVA translation and cases where device context MSI configuration changed between translation and actual MSI generation. Agree it looks as redundant check, but might help others to catch MSI related problems.
Thanks,
- Tomasz
Quoted 1,603 lines
Quoted 867 lines
hw/riscv/riscv-iommu.c new file +867
-0+ res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +/* Interrupt File Number */ + intn =_pext_u64 (PPN_DOWN (gpa), ctx->msi_addr_mask); +if (intn >=256 ) { +/* Interrupt file number out of range */ + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +/* fetch MSI PTE */ + addr =PPN_PHYS (get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_PPN )); + addr = addr | (intn *sizeof (pte)); + res =dma_memory_read (s->target_as, addr, &pte,sizeof (pte), +MEMTXATTRS_UNSPECIFIED ); +if (res !=MEMTX_OK ) { +if (res ==MEMTX_DECODE_ERROR ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_PT_CORRUPTED ; + }else { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + } + goto err; + } + +le64_to_cpus (&pte[0 ]); +le64_to_cpus (&pte[1 ]); + +if (!(pte[0 ] &RISCV_IOMMU_MSI_PTE_V ) || (pte[0 ] &RISCV_IOMMU_MSI_PTE_C )) { +/* +* The spec mentions that: "If msipte.C == 1, then further +* processing to interpret the PTE is implementation +* defined.". We'll abort with cause = 262 for this +* case too. +*/ + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_INVALID ; + goto err; + } + +switch (get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_M )) { +case RISCV_IOMMU_MSI_PTE_M_BASIC : +/* MSI Pass-through mode */ + addr =PPN_PHYS (get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_PPN )); + addr = addr | (gpa &TARGET_PAGE_MASK ); + +trace_riscv_iommu_msi (s->parent_obj.id,PCI_BUS_NUM (ctx->devid), +PCI_SLOT (ctx->devid),PCI_FUNC (ctx->devid), + gpa, addr); + + res =dma_memory_write (s->target_as, addr, &data, size, attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +return MEMTX_OK ; +case RISCV_IOMMU_MSI_PTE_M_MRIF : +/* MRIF mode, continue. */ +break ; +default : + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED ; + goto err; + } + +/* +* Report an error for interrupt identities exceeding the maximum allowed +* for an IMSIC interrupt file (2047) or destination address is not 32-bit +* aligned. See IOMMU Specification, Chapter 2.3. MSI page tables. +*/ +if ((data >2047 ) || (gpa &3 )) { + res =MEMTX_ACCESS_ERROR ; + cause =RISCV_IOMMU_FQ_CAUSE_MSI_MISCONFIGURED ; + goto err; + } + +/* MSI MRIF mode, non atomic pending bit update */ + +/* MRIF pending bit address */ + addr =get_field (pte[0 ],RISCV_IOMMU_MSI_PTE_MRIF_ADDR ) <<9 ; + addr = addr | ((data &0x7c0 ) >>3 ); + +trace_riscv_iommu_msi (s->parent_obj.id,PCI_BUS_NUM (ctx->devid), +PCI_SLOT (ctx->devid),PCI_FUNC (ctx->devid), + gpa, addr); + +/* MRIF pending bit mask */ + data =1ULL << (data &0x03f ); + res =dma_memory_read (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + + intn = intn | data; + res =dma_memory_write (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +/* Get MRIF enable bits */ + addr = addr +sizeof (intn); + res =dma_memory_read (s->target_as, addr, &intn,sizeof (intn), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_LOAD_FAULT ; + goto err; + } + +if (!(intn & data)) { +/* notification disabled, MRIF update completed. */ +return MEMTX_OK ; + } + +/* Send notification message */ + addr =PPN_PHYS (get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NPPN )); + n190 =get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NID ) | + (get_field (pte[1 ],RISCV_IOMMU_MSI_MRIF_NID_MSB ) <<10 ); + + res =dma_memory_write (s->target_as, addr, &n190,sizeof (n190), attrs); +if (res !=MEMTX_OK ) { + cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; + goto err; + } + +return MEMTX_OK ; + +err: +riscv_iommu_report_fault (s, ctx, fault_type, cause, + !!ctx->process_id,0 ,0 ); +return res; +} + +/* +* Check device context configuration as described by the +* riscv-iommu spec section "Device-context configuration +* checks". +*/ +static bool riscv_iommu_validate_device_ctx (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx) +{ +uint32_t msi_mode; + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_EN_PRI ) && + ctx->tc &RISCV_IOMMU_DC_TC_PRPR ) { +return false; + } + +if (!(s->cap &RISCV_IOMMU_CAP_T2GPA ) && + ctx->tc &RISCV_IOMMU_DC_TC_T2GPA ) { +return false; + } + +if (s->cap &RISCV_IOMMU_CAP_MSI_FLAT ) { + msi_mode =get_field (ctx->msiptp,RISCV_IOMMU_DC_MSIPTP_MODE ); + +if (msi_mode !=RISCV_IOMMU_DC_MSIPTP_MODE_OFF && + msi_mode !=RISCV_IOMMU_DC_MSIPTP_MODE_FLAT ) { +return false; + } + } + +/* +* CAP_END is always zero (only one endianess). FCTL_BE is +* always zero (little-endian accesses). Thus TC_SBE must +* always be LE, i.e. zero. +*/ +if (ctx->tc &RISCV_IOMMU_DC_TC_SBE ) { +return false; + } + +return true; +} + +/* +* Validate process context (PC) according to section +* "Process-context configuration checks". +*/ +static bool riscv_iommu_validate_process_ctx (RISCVIOMMUState *s, +RISCVIOMMUContext *ctx) +{ +if (get_field (ctx->ta,RISCV_IOMMU_PC_TA_RESERVED )) { +return false; + } + +/* FSC and svNN checks to be added when adding s/g-stage support */ +return true; +} + +/* +* RISC-V IOMMU Device Context Loopkup - Device Directory Tree Walk +* +* @s : IOMMU Device State +* @ctx : Device Translation Context with devid and pasid set. +* @return : success or fault code. +*/ +static int riscv_iommu_ctx_fetch (RISCVIOMMUState *s,RISCVIOMMUContext *ctx) +{ +const uint64_t ddtp = s->ddtp; +unsigned mode =get_field (ddtp,RISCV_IOMMU_DDTP_MODE ); +dma_addr_t addr =PPN_PHYS (get_field (ddtp,RISCV_IOMMU_DDTP_PPN )); +struct riscv_iommu_dc dc; +/* Device Context format: 0: extended (64 bytes) | 1: base (32 bytes) */ +const int dc_fmt = !s->enable_msi; +const size_t dc_len =sizeof (dc) >> dc_fmt; +unsigned depth; +uint64_t de; + +switch (mode) { +case RISCV_IOMMU_DDTP_MODE_OFF : +return RISCV_IOMMU_FQ_CAUSE_DMA_DISABLED ; + +case RISCV_IOMMU_DDTP_MODE_BARE : +/* mock up pass-through translation context */ + ctx->tc =RISCV_IOMMU_DC_TC_V ; + ctx->ta =0 ; + ctx->msiptp =0 ; +return 0 ; + +case RISCV_IOMMU_DDTP_MODE_1LVL : + depth =0 ; +break ; + +case RISCV_IOMMU_DDTP_MODE_2LVL : + depth =1 ; +break ; + +case RISCV_IOMMU_DDTP_MODE_3LVL : + depth =2 ; +break ; + +default : +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + +/* +* Check supported device id width (in bits). +* See IOMMU Specification, Chapter 6. Software guidelines. +* - if extended device-context format is used: +* 1LVL: 6, 2LVL: 15, 3LVL: 24 +* - if base device-context format is used: +* 1LVL: 7, 2LVL: 16, 3LVL: 24 +*/ +if (ctx->devid >= (1 << (depth *9 +6 + (dc_fmt && depth !=2 )))) { +return RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED ; + } + +/* Device directory tree walk */ +for (; depth-- >0 ; ) { +/* +* Select device id index bits based on device directory tree level +* and device context format. +* See IOMMU Specification, Chapter 2. Data Structures. +* - if extended device-context format is used: +* device index: [23:15][14:6][5:0] +* - if base device-context format is used: +* device index: [23:16][15:7][6:0] +*/ +const int split = depth *9 +6 + dc_fmt; + addr |= ((ctx->devid >> split) <<3 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &de,sizeof (de), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT ; + } +le64_to_cpus (&de); +if (!(de &RISCV_IOMMU_DDTE_VALID )) { +/* invalid directory entry */ +return RISCV_IOMMU_FQ_CAUSE_DDT_INVALID ; + } +if (de & ~(RISCV_IOMMU_DDTE_PPN |RISCV_IOMMU_DDTE_VALID )) { +/* reserved bits set */ +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + addr =PPN_PHYS (get_field (de,RISCV_IOMMU_DDTE_PPN )); + } + +/* index into device context entry page */ + addr |= (ctx->devid * dc_len) & ~TARGET_PAGE_MASK ; + +memset (&dc,0 ,sizeof (dc)); +if (dma_memory_read (s->target_as, addr, &dc, dc_len, +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_DDT_LOAD_FAULT ; + } + +/* Set translation context. */ + ctx->tc =le64_to_cpu (dc.tc); + ctx->ta =le64_to_cpu (dc.ta); + ctx->msiptp =le64_to_cpu (dc.msiptp); + ctx->msi_addr_mask =le64_to_cpu (dc.msi_addr_mask); + ctx->msi_addr_pattern =le64_to_cpu (dc.msi_addr_pattern); + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_V )) { +return RISCV_IOMMU_FQ_CAUSE_DDT_INVALID ; + } + +if (!riscv_iommu_validate_device_ctx (s, ctx)) { +return RISCV_IOMMU_FQ_CAUSE_DDT_MISCONFIGURED ; + } + +if (!(ctx->tc &RISCV_IOMMU_DC_TC_PDTV )) { +if (ctx->process_id !=RISCV_IOMMU_NOPROCID ) { +/* PASID is disabled */ +return RISCV_IOMMU_FQ_CAUSE_TTYPE_BLOCKED ; + } +return 0 ; + } + +/* FSC.TC.PDTV enabled */ +if (mode >RISCV_IOMMU_DC_FSC_PDTP_MODE_PD20 ) { +/* Invalid PDTP.MODE */ +return RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED ; + } + +for (depth = mode -RISCV_IOMMU_DC_FSC_PDTP_MODE_PD8 ; depth-- >0 ; ) { +/* +* Select process id index bits based on process directory tree +* level. See IOMMU Specification, 2.2. Process-Directory-Table. +*/ +const int split = depth *9 +8 ; + addr |= ((ctx->process_id >> split) <<3 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &de,sizeof (de), +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT ; + } +le64_to_cpus (&de); +if (!(de &RISCV_IOMMU_PC_TA_V )) { +return RISCV_IOMMU_FQ_CAUSE_PDT_INVALID ; + } + addr =PPN_PHYS (get_field (de,RISCV_IOMMU_PC_FSC_PPN )); + } + +/* Leaf entry in PDT */ + addr |= (ctx->process_id <<4 ) & ~TARGET_PAGE_MASK ; +if (dma_memory_read (s->target_as, addr, &dc.ta,sizeof (uint64_t ) *2 , +MEMTXATTRS_UNSPECIFIED ) !=MEMTX_OK ) { +return RISCV_IOMMU_FQ_CAUSE_PDT_LOAD_FAULT ; + } + +/* Use TA from process directory entry. */ + ctx->ta =le64_to_cpu (dc.ta); + +if (!(ctx->ta &RISCV_IOMMU_PC_TA_V )) { +return RISCV_IOMMU_FQ_CAUSE_PDT_INVALID ; + } + +if (!riscv_iommu_validate_process_ctx (s, ctx)) { +return RISCV_IOMMU_FQ_CAUSE_PDT_MISCONFIGURED ; + } + +return 0 ; +} + +/* Translation Context cache support */ +static gboolean __ctx_equal (gconstpointer v1,gconstpointer v2) +{ +RISCVIOMMUContext *c1 = (RISCVIOMMUContext *) v1; +RISCVIOMMUContext *c2 = (RISCVIOMMUContext *) v2; +return c1->devid == c2->devid && + c1->process_id == c2->process_id; +} + +static guint __ctx_hash (gconstpointer v) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) v; +/* +* Generate simple hash of (process_id, devid) +* assuming 24-bit wide devid. +*/ +return (guint)(ctx->devid) + ((guint)(ctx->process_id) <<24 ); +} + +static void __ctx_inval_devid_procid (gpointer key,gpointer value, +gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +RISCVIOMMUContext *arg = (RISCVIOMMUContext *) data; +if (ctx->tc &RISCV_IOMMU_DC_TC_V && + ctx->devid == arg->devid && + ctx->process_id == arg->process_id) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void __ctx_inval_devid (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +RISCVIOMMUContext *arg = (RISCVIOMMUContext *) data; +if (ctx->tc &RISCV_IOMMU_DC_TC_V && + ctx->devid == arg->devid) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void __ctx_inval_all (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUContext *ctx = (RISCVIOMMUContext *) value; +if (ctx->tc &RISCV_IOMMU_DC_TC_V ) { + ctx->tc &= ~RISCV_IOMMU_DC_TC_V ; + } +} + +static void riscv_iommu_ctx_inval (RISCVIOMMUState *s,GHFunc func, +uint32_t devid,uint32_t process_id) +{ +GHashTable *ctx_cache; +RISCVIOMMUContext key = { + .devid = devid, + .process_id = process_id, + }; + ctx_cache =g_hash_table_ref (s->ctx_cache); +qemu_mutex_lock (&s->ctx_lock); +g_hash_table_foreach (ctx_cache, func, &key); +qemu_mutex_unlock (&s->ctx_lock); +g_hash_table_unref (ctx_cache); +} + +/* Find or allocate translation context for a given {device_id, process_id} */ +static RISCVIOMMUContext *riscv_iommu_ctx (RISCVIOMMUState *s, +unsigned devid,unsigned process_id, +void **ref) +{ +GHashTable *ctx_cache; +RISCVIOMMUContext *ctx; +RISCVIOMMUContext key = { + .devid = devid, + .process_id = process_id, + }; + + ctx_cache =g_hash_table_ref (s->ctx_cache); +qemu_mutex_lock (&s->ctx_lock); + ctx =g_hash_table_lookup (ctx_cache, &key); +qemu_mutex_unlock (&s->ctx_lock); + +if (ctx && (ctx->tc &RISCV_IOMMU_DC_TC_V )) { + *ref = ctx_cache; +return ctx; + } + + ctx =g_new0 (RISCVIOMMUContext,1 ); + ctx->devid = devid; + ctx->process_id = process_id; + +int fault =riscv_iommu_ctx_fetch (s, ctx); +if (!fault) { +qemu_mutex_lock (&s->ctx_lock); +if (g_hash_table_size (ctx_cache) >=LIMIT_CACHE_CTX ) { +g_hash_table_unref (ctx_cache); + ctx_cache =g_hash_table_new_full (__ctx_hash, __ctx_equal, + g_free,NULL ); +g_hash_table_ref (ctx_cache); +g_hash_table_unref (qatomic_xchg (&s->ctx_cache, ctx_cache)); + } +g_hash_table_add (ctx_cache, ctx); +qemu_mutex_unlock (&s->ctx_lock); + *ref = ctx_cache; +return ctx; + } + +g_hash_table_unref (ctx_cache); + *ref =NULL ; + +riscv_iommu_report_fault (s, ctx,RISCV_IOMMU_FQ_TTYPE_UADDR_RD , + fault, !!process_id,0 ,0 ); + +g_free (ctx); +return NULL ; +} + +static void riscv_iommu_ctx_put (RISCVIOMMUState *s,void *ref) +{ +if (ref) { +g_hash_table_unref ((GHashTable *)ref); + } +} + +/* Find or allocate address space for a given device */ +static AddressSpace *riscv_iommu_space (RISCVIOMMUState *s,uint32_t devid) +{ +RISCVIOMMUSpace *as; + +/* FIXME: PCIe bus remapping for attached endpoints. */ + devid |= s->bus <<8 ; + +qemu_mutex_lock (&s->core_lock); + QLIST_FOREACH(as, &s->spaces, list) { +if (as->devid == devid) { +break ; + } + } +qemu_mutex_unlock (&s->core_lock); + +if (as ==NULL ) { +char name[64 ]; + as =g_new0 (RISCVIOMMUSpace,1 ); + + as->iommu = s; + as->devid = devid; + +snprintf (name,sizeof (name),"riscv-iommu-%04x:%02x.%d-iova" , +PCI_BUS_NUM (as->devid),PCI_SLOT (as->devid),PCI_FUNC (as->devid)); + +/* IOVA address space, untranslated addresses */ +memory_region_init_iommu (&as->iova_mr,sizeof (as->iova_mr), +TYPE_RISCV_IOMMU_MEMORY_REGION , +OBJECT (as),"riscv_iommu" ,UINT64_MAX ); +address_space_init (&as->iova_as,MEMORY_REGION (&as->iova_mr), name); + +qemu_mutex_lock (&s->core_lock); +QLIST_INSERT_HEAD (&s->spaces, as, list); +qemu_mutex_unlock (&s->core_lock); + +trace_riscv_iommu_new (s->parent_obj.id,PCI_BUS_NUM (as->devid), +PCI_SLOT (as->devid),PCI_FUNC (as->devid)); + } +return &as->iova_as; +} + +static int riscv_iommu_translate (RISCVIOMMUState *s,RISCVIOMMUContext *ctx, +IOMMUTLBEntry *iotlb) +{ +bool enable_pasid; +bool enable_pri; +int fault; + +/* +* TC[32] is reserved for custom extensions, used here to temporarily +* enable automatic page-request generation for ATS queries. +*/ + enable_pri = (iotlb->perm ==IOMMU_NONE ) && (ctx->tc &BIT_ULL (32 )); + enable_pasid = (ctx->tc &RISCV_IOMMU_DC_TC_PDTV ); + +/* Translate using device directory / page table information. */ + fault =riscv_iommu_spa_fetch (s, ctx, iotlb); + +if (enable_pri && fault) { +struct riscv_iommu_pq_record pr = {0 }; +if (enable_pasid) { + pr.hdr =set_field (RISCV_IOMMU_PREQ_HDR_PV , +RISCV_IOMMU_PREQ_HDR_PID , ctx->process_id); + } + pr.hdr =set_field (pr.hdr,RISCV_IOMMU_PREQ_HDR_DID , ctx->devid); + pr.payload = (iotlb->iova &TARGET_PAGE_MASK ) | +RISCV_IOMMU_PREQ_PAYLOAD_M ; +riscv_iommu_pri (s, &pr); +return fault; + } + +if (fault) { +unsigned ttype; + +if (iotlb->perm &IOMMU_RW ) { + ttype =RISCV_IOMMU_FQ_TTYPE_UADDR_WR ; + }else { + ttype =RISCV_IOMMU_FQ_TTYPE_UADDR_RD ; + } + +riscv_iommu_report_fault (s, ctx, ttype, fault, enable_pasid, + iotlb->iova, iotlb->translated_addr); +return fault; + } + +return 0 ; +} + +/* IOMMU Command Interface */ +static MemTxResult riscv_iommu_iofence (RISCVIOMMUState *s,bool notify, +uint64_t addr,uint32_t data) +{ +/* +* ATS processing in this implementation of the IOMMU is synchronous, +* no need to wait for completions here. +*/ +if (!notify) { +return MEMTX_OK ; + } + +return dma_memory_write (s->target_as, addr, &data,sizeof (data), +MEMTXATTRS_UNSPECIFIED ); +} + +static void riscv_iommu_process_ddtp (RISCVIOMMUState *s) +{ +uint64_t old_ddtp = s->ddtp; +uint64_t new_ddtp =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_DDTP ); +unsigned new_mode =get_field (new_ddtp,RISCV_IOMMU_DDTP_MODE ); +unsigned old_mode =get_field (old_ddtp,RISCV_IOMMU_DDTP_MODE ); +bool ok = false; + +/* +* Check for allowed DDTP.MODE transitions: +* {OFF, BARE} -> {OFF, BARE, 1LVL, 2LVL, 3LVL} +* {1LVL, 2LVL, 3LVL} -> {OFF, BARE} +*/ +if (new_mode == old_mode || + new_mode ==RISCV_IOMMU_DDTP_MODE_OFF || + new_mode ==RISCV_IOMMU_DDTP_MODE_BARE ) { + ok = true; + }else if (new_mode ==RISCV_IOMMU_DDTP_MODE_1LVL || + new_mode ==RISCV_IOMMU_DDTP_MODE_2LVL || + new_mode ==RISCV_IOMMU_DDTP_MODE_3LVL ) { + ok = old_mode ==RISCV_IOMMU_DDTP_MODE_OFF || + old_mode ==RISCV_IOMMU_DDTP_MODE_BARE ; + } + +if (ok) { +/* clear reserved and busy bits, report back sanitized version */ + new_ddtp =set_field (new_ddtp &RISCV_IOMMU_DDTP_PPN , +RISCV_IOMMU_DDTP_MODE , new_mode); + }else { + new_ddtp = old_ddtp; + } + s->ddtp = new_ddtp; + +riscv_iommu_reg_set64 (s,RISCV_IOMMU_REG_DDTP , new_ddtp); +} + +/* Command function and opcode field. */ +#define RISCV_IOMMU_CMD (func, op) (((func) << 7) | (op)) + +static void riscv_iommu_process_cq_tail (RISCVIOMMUState *s) +{ +struct riscv_iommu_command cmd; +MemTxResult res; +dma_addr_t addr; +uint32_t tail, head, ctrl; +uint64_t cmd_opcode; +GHFunc func; + + ctrl =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); + tail =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQT ) & s->cq_mask; + head =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQH ) & s->cq_mask; + +/* Check for pending error or queue processing disabled */ +if (!(ctrl &RISCV_IOMMU_CQCSR_CQON ) || + !!(ctrl & (RISCV_IOMMU_CQCSR_CMD_ILL |RISCV_IOMMU_CQCSR_CQMF ))) { +return ; + } + +while (tail != head) { + addr = s->cq_addr + head *sizeof (cmd); + res =dma_memory_read (s->target_as, addr, &cmd,sizeof (cmd), +MEMTXATTRS_UNSPECIFIED ); + +if (res !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CQMF ,0 ); + goto fault; + } + +trace_riscv_iommu_cmd (s->parent_obj.id, cmd.dword0, cmd.dword1); + + cmd_opcode =get_field (cmd.dword0, +RISCV_IOMMU_CMD_OPCODE |RISCV_IOMMU_CMD_FUNC ); + +switch (cmd_opcode) { +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOFENCE_FUNC_C , +RISCV_IOMMU_CMD_IOFENCE_OPCODE ): + res =riscv_iommu_iofence (s, + cmd.dword0 &RISCV_IOMMU_CMD_IOFENCE_AV , cmd.dword1, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IOFENCE_DATA )); + +if (res !=MEMTX_OK ) { +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CQMF ,0 ); + goto fault; + } +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOTINVAL_FUNC_GVMA , +RISCV_IOMMU_CMD_IOTINVAL_OPCODE ): +if (cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_PSCV ) { +/* illegal command arguments IOTINVAL.GVMA & PSCV == 1 */ + goto cmd_ill; + } +/* translation cache not implemented yet */ +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA , +RISCV_IOMMU_CMD_IOTINVAL_OPCODE ): +/* translation cache not implemented yet */ +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT , +RISCV_IOMMU_CMD_IODIR_OPCODE ): +if (!(cmd.dword0 &RISCV_IOMMU_CMD_IODIR_DV )) { +/* invalidate all device context cache mappings */ + func = __ctx_inval_all; + }else { +/* invalidate all device context matching DID */ + func = __ctx_inval_devid; + } +riscv_iommu_ctx_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_DID ),0 ); +break ; + +case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_PDT , +RISCV_IOMMU_CMD_IODIR_OPCODE ): +if (!(cmd.dword0 &RISCV_IOMMU_CMD_IODIR_DV )) { +/* illegal command arguments IODIR_PDT & DV == 0 */ + goto cmd_ill; + }else { + func = __ctx_inval_devid_procid; + } +riscv_iommu_ctx_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_DID ), +get_field (cmd.dword0,RISCV_IOMMU_CMD_IODIR_PID )); +break ; + +default : + cmd_ill: +/* Invalid instruction, do not advance instruction index. */ +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , +RISCV_IOMMU_CQCSR_CMD_ILL ,0 ); + goto fault; + } + +/* Advance and update head pointer after command completes. */ + head = (head +1 ) & s->cq_mask; +riscv_iommu_reg_set32 (s,RISCV_IOMMU_REG_CQH , head); + } +return ; + +fault: +if (ctrl &RISCV_IOMMU_CQCSR_CIE ) { +riscv_iommu_notify (s,RISCV_IOMMU_INTR_CQ ); + } +} + +static void riscv_iommu_process_cq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_CQCSR_CQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_CQCSR_CQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_CQB ); + s->cq_mask = (2ULL <<get_field (base,RISCV_IOMMU_CQB_LOG2SZ )) -1 ; + s->cq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_CQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQT ], ~s->cq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_CQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_CQT ],0 ); + ctrl_set =RISCV_IOMMU_CQCSR_CQON ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY |RISCV_IOMMU_CQCSR_CQMF | +RISCV_IOMMU_CQCSR_CMD_ILL |RISCV_IOMMU_CQCSR_CMD_TO | +RISCV_IOMMU_CQCSR_FENCE_W_IP ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQT ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY |RISCV_IOMMU_CQCSR_CQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_CQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_CQCSR , ctrl_set, ctrl_clr); +} + +static void riscv_iommu_process_fq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_FQCSR_FQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_FQCSR_FQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_FQB ); + s->fq_mask = (2ULL <<get_field (base,RISCV_IOMMU_FQB_LOG2SZ )) -1 ; + s->fq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_FQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQH ], ~s->fq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_FQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_FQT ],0 ); + ctrl_set =RISCV_IOMMU_FQCSR_FQON ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY |RISCV_IOMMU_FQCSR_FQMF | +RISCV_IOMMU_FQCSR_FQOF ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQH ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY |RISCV_IOMMU_FQCSR_FQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_FQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_FQCSR , ctrl_set, ctrl_clr); +} + +static void riscv_iommu_process_pq_control (RISCVIOMMUState *s) +{ +uint64_t base; +uint32_t ctrl_set =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); +uint32_t ctrl_clr; +bool enable = !!(ctrl_set &RISCV_IOMMU_PQCSR_PQEN ); +bool active = !!(ctrl_set &RISCV_IOMMU_PQCSR_PQON ); + +if (enable && !active) { + base =riscv_iommu_reg_get64 (s,RISCV_IOMMU_REG_PQB ); + s->pq_mask = (2ULL <<get_field (base,RISCV_IOMMU_PQB_LOG2SZ )) -1 ; + s->pq_addr =PPN_PHYS (get_field (base,RISCV_IOMMU_PQB_PPN )); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQH ], ~s->pq_mask); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_PQH ],0 ); +stl_le_p (&s->regs_rw[RISCV_IOMMU_REG_PQT ],0 ); + ctrl_set =RISCV_IOMMU_PQCSR_PQON ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY |RISCV_IOMMU_PQCSR_PQMF | +RISCV_IOMMU_PQCSR_PQOF ; + }else if (!enable && active) { +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQH ], ~0 ); + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY |RISCV_IOMMU_PQCSR_PQON ; + }else { + ctrl_set =0 ; + ctrl_clr =RISCV_IOMMU_PQCSR_BUSY ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_PQCSR , ctrl_set, ctrl_clr); +} + +typedef void riscv_iommu_process_fn (RISCVIOMMUState *s); + +static void riscv_iommu_update_ipsr (RISCVIOMMUState *s,uint64_t data) +{ +uint32_t cqcsr, fqcsr, pqcsr; +uint32_t ipsr_set =0 ; +uint32_t ipsr_clr =0 ; + +if (data &RISCV_IOMMU_IPSR_CIP ) { + cqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_CQCSR ); + +if (cqcsr &RISCV_IOMMU_CQCSR_CIE && + (cqcsr &RISCV_IOMMU_CQCSR_FENCE_W_IP || + cqcsr &RISCV_IOMMU_CQCSR_CMD_ILL || + cqcsr &RISCV_IOMMU_CQCSR_CMD_TO || + cqcsr &RISCV_IOMMU_CQCSR_CQMF )) { + ipsr_set |=RISCV_IOMMU_IPSR_CIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_CIP ; + } + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_CIP ; + } + +if (data &RISCV_IOMMU_IPSR_FIP ) { + fqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_FQCSR ); + +if (fqcsr &RISCV_IOMMU_FQCSR_FIE && + (fqcsr &RISCV_IOMMU_FQCSR_FQOF || + fqcsr &RISCV_IOMMU_FQCSR_FQMF )) { + ipsr_set |=RISCV_IOMMU_IPSR_FIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_FIP ; + } + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_FIP ; + } + +if (data &RISCV_IOMMU_IPSR_PIP ) { + pqcsr =riscv_iommu_reg_get32 (s,RISCV_IOMMU_REG_PQCSR ); + + if (pqcsr & RISCV_IOMMU_PQCSR_PIE && + (pqcsr & RISCV_IOMMU_PQCSR_PQOF ||hw/riscv/riscv-iommu.c line 1144
Quoted 10 lines
hw/riscv/riscv-iommu.c new file +10
-0+ pqcsr & RISCV_IOMMU_PQCSR_PQMF)) { + ipsr_set |=RISCV_IOMMU_IPSR_PIP ; + }else { + ipsr_clr |=RISCV_IOMMU_IPSR_PIP ; + } + } else { + ipsr_clr |=RISCV_IOMMU_IPSR_PIP ; + } + +riscv_iommu_reg_mod32 (s,RISCV_IOMMU_REG_IPSR , ipsr_set, ipsr_clr);If the pending bit is cleared, we can deassert the WSI.
Quoted 526 lines
hw/riscv/riscv-iommu.c new file +497
-0+} + +static MemTxResult riscv_iommu_mmio_write (void *opaque,hwaddr addr, +uint64_t data,unsigned size,MemTxAttrs attrs) +{ +riscv_iommu_process_fn *process_fn =NULL ; +RISCVIOMMUState *s = opaque; +uint32_t regb = addr & ~3 ; +uint32_t busy =0 ; +uint64_t val =0 ; + +if ((addr & (size -1 )) !=0 ) { +/* Unsupported MMIO alignment or access size */ +return MEMTX_ERROR ; + } + +if (addr + size >RISCV_IOMMU_REG_MSI_CONFIG ) { +/* Unsupported MMIO access location. */ +return MEMTX_ACCESS_ERROR ; + } + +/* Track actionable MMIO write. */ +switch (regb) { +case RISCV_IOMMU_REG_DDTP : +case RISCV_IOMMU_REG_DDTP +4 : + process_fn = riscv_iommu_process_ddtp; + regb =RISCV_IOMMU_REG_DDTP ; + busy =RISCV_IOMMU_DDTP_BUSY ; +break ; + +case RISCV_IOMMU_REG_CQT : + process_fn = riscv_iommu_process_cq_tail; +break ; + +case RISCV_IOMMU_REG_CQCSR : + process_fn = riscv_iommu_process_cq_control; + busy =RISCV_IOMMU_CQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_FQCSR : + process_fn = riscv_iommu_process_fq_control; + busy =RISCV_IOMMU_FQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_PQCSR : + process_fn = riscv_iommu_process_pq_control; + busy =RISCV_IOMMU_PQCSR_BUSY ; +break ; + +case RISCV_IOMMU_REG_IPSR : +/* +* IPSR has special procedures to update. Execute it +* and exit. +*/ +if (size ==4 ) { +uint32_t ro =ldl_le_p (&s->regs_ro[addr]); +uint32_t wc =ldl_le_p (&s->regs_wc[addr]); +uint32_t rw =ldl_le_p (&s->regs_rw[addr]); +stl_le_p (&val, ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==8 ) { +uint64_t ro =ldq_le_p (&s->regs_ro[addr]); +uint64_t wc =ldq_le_p (&s->regs_wc[addr]); +uint64_t rw =ldq_le_p (&s->regs_rw[addr]); +stq_le_p (&val, ((rw & ro) | (data & ~ro)) & ~(data & wc)); + } + +riscv_iommu_update_ipsr (s, val); + +return MEMTX_OK ; + +default : +break ; + } + +/* +* Registers update might be not synchronized with core logic. +* If system software updates register when relevant BUSY bit +* is set IOMMU behavior of additional writes to the register +* is UNSPECIFIED. +*/ +qemu_spin_lock (&s->regs_lock); +if (size ==1 ) { +uint8_t ro = s->regs_ro[addr]; +uint8_t wc = s->regs_wc[addr]; +uint8_t rw = s->regs_rw[addr]; + s->regs_rw[addr] = ((rw & ro) | (data & ~ro)) & ~(data & wc); + }else if (size ==2 ) { +uint16_t ro =lduw_le_p (&s->regs_ro[addr]); +uint16_t wc =lduw_le_p (&s->regs_wc[addr]); +uint16_t rw =lduw_le_p (&s->regs_rw[addr]); +stw_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==4 ) { +uint32_t ro =ldl_le_p (&s->regs_ro[addr]); +uint32_t wc =ldl_le_p (&s->regs_wc[addr]); +uint32_t rw =ldl_le_p (&s->regs_rw[addr]); +stl_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + }else if (size ==8 ) { +uint64_t ro =ldq_le_p (&s->regs_ro[addr]); +uint64_t wc =ldq_le_p (&s->regs_wc[addr]); +uint64_t rw =ldq_le_p (&s->regs_rw[addr]); +stq_le_p (&s->regs_rw[addr], ((rw & ro) | (data & ~ro)) & ~(data & wc)); + } + +/* Busy flag update, MSB 4-byte register. */ +if (busy) { +uint32_t rw =ldl_le_p (&s->regs_rw[regb]); +stl_le_p (&s->regs_rw[regb], rw | busy); + } +qemu_spin_unlock (&s->regs_lock); + +if (process_fn) { +qemu_mutex_lock (&s->core_lock); +process_fn (s); +qemu_mutex_unlock (&s->core_lock); + } + +return MEMTX_OK ; +} + +static MemTxResult riscv_iommu_mmio_read (void *opaque,hwaddr addr, +uint64_t *data,unsigned size,MemTxAttrs attrs) +{ +RISCVIOMMUState *s = opaque; +uint64_t val =-1 ; +uint8_t *ptr; + +if ((addr & (size -1 )) !=0 ) { +/* Unsupported MMIO alignment. */ +return MEMTX_ERROR ; + } + +if (addr + size >RISCV_IOMMU_REG_MSI_CONFIG ) { +return MEMTX_ACCESS_ERROR ; + } + + ptr = &s->regs_rw[addr]; + +if (size ==1 ) { + val = (uint64_t )*ptr; + }else if (size ==2 ) { + val =lduw_le_p (ptr); + }else if (size ==4 ) { + val =ldl_le_p (ptr); + }else if (size ==8 ) { + val =ldq_le_p (ptr); + }else { +return MEMTX_ERROR ; + } + + *data = val; + +return MEMTX_OK ; +} + +static const MemoryRegionOps riscv_iommu_mmio_ops = { + .read_with_attrs = riscv_iommu_mmio_read, + .write_with_attrs = riscv_iommu_mmio_write, + .endianness =DEVICE_NATIVE_ENDIAN , + .impl = { + .min_access_size =4 , + .max_access_size =8 , + .unaligned = false, + }, + .valid = { + .min_access_size =4 , + .max_access_size =8 , + } +}; + +/* +* Translations matching MSI pattern check are redirected to "riscv-iommu-trap" +* memory region as untranslated address, for additional MSI/MRIF interception +* by IOMMU interrupt remapping implementation. +* Note: Device emulation code generating an MSI is expected to provide a valid +* memory transaction attributes with requested_id set. +*/ +static MemTxResult riscv_iommu_trap_write (void *opaque,hwaddr addr, +uint64_t data,unsigned size,MemTxAttrs attrs) +{ +RISCVIOMMUState * s = (RISCVIOMMUState *)opaque; +RISCVIOMMUContext *ctx; +MemTxResult res; +void *ref; +uint32_t devid = attrs.requester_id; + +if (attrs.unspecified) { +return MEMTX_ACCESS_ERROR ; + } + +/* FIXME: PCIe bus remapping for attached endpoints. */ + devid |= s->bus <<8 ; + + ctx =riscv_iommu_ctx (s, devid,0 , &ref); +if (ctx ==NULL ) { + res =MEMTX_ACCESS_ERROR ; + }else { + res =riscv_iommu_msi_write (s, ctx, addr, data, size, attrs); + } +riscv_iommu_ctx_put (s, ref); +return res; +} + +static MemTxResult riscv_iommu_trap_read (void *opaque,hwaddr addr, +uint64_t *data,unsigned size,MemTxAttrs attrs) +{ +return MEMTX_ACCESS_ERROR ; +} + +static const MemoryRegionOps riscv_iommu_trap_ops = { + .read_with_attrs = riscv_iommu_trap_read, + .write_with_attrs = riscv_iommu_trap_write, + .endianness =DEVICE_LITTLE_ENDIAN , + .impl = { + .min_access_size =4 , + .max_access_size =8 , + .unaligned = true, + }, + .valid = { + .min_access_size =4 , + .max_access_size =8 , + } +}; + +static void riscv_iommu_realize (DeviceState *dev,Error **errp) +{ +RISCVIOMMUState *s =RISCV_IOMMU (dev); + + s->cap = s->version &RISCV_IOMMU_CAP_VERSION ; +if (s->enable_msi) { + s->cap |=RISCV_IOMMU_CAP_MSI_FLAT |RISCV_IOMMU_CAP_MSI_MRIF ; + } +/* Report QEMU target physical address space limits */ + s->cap =set_field (s->cap,RISCV_IOMMU_CAP_PAS , +TARGET_PHYS_ADDR_SPACE_BITS ); + +/* TODO: method to report supported PASID bits */ + s->pasid_bits =8 ;/* restricted to size of MemTxAttrs.pasid */ + s->cap |=RISCV_IOMMU_CAP_PD8 ; + +/* Out-of-reset translation mode: OFF (DMA disabled) BARE (passthrough) */ + s->ddtp =set_field (0 ,RISCV_IOMMU_DDTP_MODE , s->enable_off ? +RISCV_IOMMU_DDTP_MODE_OFF :RISCV_IOMMU_DDTP_MODE_BARE ); + +/* register storage */ + s->regs_rw =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + s->regs_ro =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + s->regs_wc =g_new0 (uint8_t,RISCV_IOMMU_REG_SIZE ); + +/* Mark all registers read-only */ +memset (s->regs_ro,0xff ,RISCV_IOMMU_REG_SIZE ); + +/* +* Register complete MMIO space, including MSI/PBA registers. +* Note, PCIDevice implementation will add overlapping MR for MSI/PBA, +* managed directly by the PCIDevice implementation. +*/ +memory_region_init_io (&s->regs_mr,OBJECT (dev), &riscv_iommu_mmio_ops, s, +"riscv-iommu-regs" ,RISCV_IOMMU_REG_SIZE ); + +/* Set power-on register state */ +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_CAP ], s->cap); +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_FCTL ],0 ); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_FCTL ], + ~(RISCV_IOMMU_FCTL_BE |RISCV_IOMMU_FCTL_WSI )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_DDTP ], + ~(RISCV_IOMMU_DDTP_PPN |RISCV_IOMMU_DDTP_MODE )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQB ], + ~(RISCV_IOMMU_CQB_LOG2SZ |RISCV_IOMMU_CQB_PPN )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQB ], + ~(RISCV_IOMMU_FQB_LOG2SZ |RISCV_IOMMU_FQB_PPN )); +stq_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQB ], + ~(RISCV_IOMMU_PQB_LOG2SZ |RISCV_IOMMU_PQB_PPN )); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_CQCSR ],RISCV_IOMMU_CQCSR_CQMF | +RISCV_IOMMU_CQCSR_CMD_TO |RISCV_IOMMU_CQCSR_CMD_ILL ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_CQCSR ],RISCV_IOMMU_CQCSR_CQON | +RISCV_IOMMU_CQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_FQCSR ],RISCV_IOMMU_FQCSR_FQMF | +RISCV_IOMMU_FQCSR_FQOF ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_FQCSR ],RISCV_IOMMU_FQCSR_FQON | +RISCV_IOMMU_FQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_PQCSR ],RISCV_IOMMU_PQCSR_PQMF | +RISCV_IOMMU_PQCSR_PQOF ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_PQCSR ],RISCV_IOMMU_PQCSR_PQON | +RISCV_IOMMU_PQCSR_BUSY ); +stl_le_p (&s->regs_wc[RISCV_IOMMU_REG_IPSR ], ~0 ); +stl_le_p (&s->regs_ro[RISCV_IOMMU_REG_IVEC ],0 ); +stq_le_p (&s->regs_rw[RISCV_IOMMU_REG_DDTP ], s->ddtp); + +/* Memory region for downstream access, if specified. */ +if (s->target_mr) { + s->target_as =g_new0 (AddressSpace,1 ); +address_space_init (s->target_as, s->target_mr, +"riscv-iommu-downstream" ); + }else { +/* Fallback to global system memory. */ + s->target_as = &address_space_memory; + } + +/* Memory region for untranslated MRIF/MSI writes */ +memory_region_init_io (&s->trap_mr,OBJECT (dev), &riscv_iommu_trap_ops, s, +"riscv-iommu-trap" , ~0ULL ); +address_space_init (&s->trap_as, &s->trap_mr,"riscv-iommu-trap-as" ); + +/* Device translation context cache */ + s->ctx_cache =g_hash_table_new_full (__ctx_hash, __ctx_equal, + g_free,NULL ); +qemu_mutex_init (&s->ctx_lock); + + s->iommus.le_next =NULL ; + s->iommus.le_prev =NULL ; +QLIST_INIT (&s->spaces); +qemu_mutex_init (&s->core_lock); +qemu_spin_init (&s->regs_lock); +} + +static void riscv_iommu_unrealize (DeviceState *dev) +{ +RISCVIOMMUState *s =RISCV_IOMMU (dev); + +qemu_mutex_destroy (&s->core_lock); +g_hash_table_unref (s->ctx_cache); +} + +static Property riscv_iommu_properties[] = { +DEFINE_PROP_UINT32 ("version" , RISCVIOMMUState, version, +RISCV_IOMMU_SPEC_DOT_VER ), +DEFINE_PROP_UINT32 ("bus" , RISCVIOMMUState, bus,0x0 ), +DEFINE_PROP_BOOL ("intremap" , RISCVIOMMUState, enable_msi, TRUE), +DEFINE_PROP_BOOL ("off" , RISCVIOMMUState, enable_off, TRUE), +DEFINE_PROP_LINK ("downstream-mr" , RISCVIOMMUState, target_mr, + TYPE_MEMORY_REGION, MemoryRegion *), +DEFINE_PROP_END_OF_LIST (), +}; + +static void riscv_iommu_class_init (ObjectClass *klass,void * data) +{ +DeviceClass *dc =DEVICE_CLASS (klass); + +/* internal device for riscv-iommu-{pci/sys}, not user-creatable */ + dc->user_creatable = false; + dc->realize = riscv_iommu_realize; + dc->unrealize = riscv_iommu_unrealize; +device_class_set_props (dc, riscv_iommu_properties); +} + +static const TypeInfo riscv_iommu_info = { + .name =TYPE_RISCV_IOMMU , + .parent =TYPE_DEVICE , + .instance_size =sizeof (RISCVIOMMUState), + .class_init = riscv_iommu_class_init, +}; + +static const char *IOMMU_FLAG_STR [] = { +"NA" , +"RO" , +"WR" , +"RW" , +}; + +/* RISC-V IOMMU Memory Region - Address Translation Space */ +static IOMMUTLBEntry riscv_iommu_memory_region_translate ( +IOMMUMemoryRegion *iommu_mr,hwaddr addr, +IOMMUAccessFlags flag,int iommu_idx) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); +RISCVIOMMUContext *ctx; +void *ref; +IOMMUTLBEntry iotlb = { + .iova = addr, + .target_as = as->iommu->target_as, + .addr_mask = ~0ULL , + .perm = flag, + }; + + ctx =riscv_iommu_ctx (as->iommu, as->devid, iommu_idx, &ref); +if (ctx ==NULL ) { +/* Translation disabled or invalid. */ + iotlb.addr_mask =0 ; + iotlb.perm =IOMMU_NONE ; + }else if (riscv_iommu_translate (as->iommu, ctx, &iotlb)) { +/* Translation disabled or fault reported. */ + iotlb.addr_mask =0 ; + iotlb.perm =IOMMU_NONE ; + } + +/* Trace all dma translations with original access flags. */ +trace_riscv_iommu_dma (as->iommu->parent_obj.id,PCI_BUS_NUM (as->devid), +PCI_SLOT (as->devid),PCI_FUNC (as->devid), iommu_idx, +IOMMU_FLAG_STR [flag &IOMMU_RW ], iotlb.iova, + iotlb.translated_addr); + +riscv_iommu_ctx_put (as->iommu, ref); + +return iotlb; +} + +static int riscv_iommu_memory_region_notify ( +IOMMUMemoryRegion *iommu_mr,IOMMUNotifierFlag old, +IOMMUNotifierFlag new,Error **errp) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); + +if (old ==IOMMU_NOTIFIER_NONE ) { + as->notifier = true; +trace_riscv_iommu_notifier_add (iommu_mr->parent_obj.name); + }else if (new ==IOMMU_NOTIFIER_NONE ) { + as->notifier = false; +trace_riscv_iommu_notifier_del (iommu_mr->parent_obj.name); + } + +return 0 ; +} + +static inline bool pci_is_iommu (PCIDevice *pdev) +{ +return pci_get_word (pdev->config +PCI_CLASS_DEVICE ) ==0x0806 ; +} + +static AddressSpace *riscv_iommu_find_as (PCIBus *bus,void *opaque,int devfn) +{ +RISCVIOMMUState *s = (RISCVIOMMUState *) opaque; +PCIDevice *pdev =pci_find_device (bus,pci_bus_num (bus), devfn); +AddressSpace *as =NULL ; + +if (pdev &&pci_is_iommu (pdev)) { +return s->target_as; + } + +/* Find first registered IOMMU device */ +while (s->iommus.le_prev) { + s = *(s->iommus.le_prev); + } + +/* Find first matching IOMMU */ +while (s !=NULL && as ==NULL ) { + as =riscv_iommu_space (s,PCI_BUILD_BDF (pci_bus_num (bus), devfn)); + s = s->iommus.le_next; + } + +return as ? as : &address_space_memory; +} + +static const PCIIOMMUOps riscv_iommu_ops = { + .get_address_space = riscv_iommu_find_as, +}; + +void riscv_iommu_pci_setup_iommu (RISCVIOMMUState *iommu,PCIBus *bus, +Error **errp) +{ +if (bus->iommu_ops && + bus->iommu_ops->get_address_space == riscv_iommu_find_as) { +/* Allow multiple IOMMUs on the same PCIe bus, link known devices */ +RISCVIOMMUState *last = (RISCVIOMMUState *)bus->iommu_opaque; +QLIST_INSERT_AFTER (last, iommu, iommus); + }else if (!bus->iommu_ops && !bus->iommu_opaque) { +pci_setup_iommu (bus, &riscv_iommu_ops, iommu); + }else { +error_setg (errp,"can't register secondary IOMMU for PCI bus #%d" , +pci_bus_num (bus)); + } +} + +static int riscv_iommu_memory_region_index (IOMMUMemoryRegion *iommu_mr, +MemTxAttrs attrs) +{ +return attrs.unspecified ?RISCV_IOMMU_NOPROCID : (int )attrs.pasid; +} + +static int riscv_iommu_memory_region_index_len (IOMMUMemoryRegion *iommu_mr) +{ +RISCVIOMMUSpace *as =container_of (iommu_mr, RISCVIOMMUSpace, iova_mr); +return 1 << as->iommu->pasid_bits; +} + +static void riscv_iommu_memory_region_init (ObjectClass *klass,void *data) +{ +IOMMUMemoryRegionClass *imrc =IOMMU_MEMORY_REGION_CLASS (klass); + + imrc->translate = riscv_iommu_memory_region_translate; + imrc->notify_flag_changed = riscv_iommu_memory_region_notify; + imrc->attrs_to_index = riscv_iommu_memory_region_index; + imrc->num_indexes = riscv_iommu_memory_region_index_len; +} + +static const TypeInfo riscv_iommu_memory_region_info = { + .parent =TYPE_IOMMU_MEMORY_REGION , + .name =TYPE_RISCV_IOMMU_MEMORY_REGION , + .class_init = riscv_iommu_memory_region_init, +}; + +static void riscv_iommu_register_mr_types (void ) +{ +type_register_static (&riscv_iommu_memory_region_info); +type_register_static (&riscv_iommu_info); +} + +type_init (riscv_iommu_register_mr_types);hw/riscv/riscv-iommu.h new file +23
-0@@ -0,0 +1,142 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2022-2023 Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef HW_RISCV_IOMMU_STATE_H +#define HW_RISCV_IOMMU_STATE_H + +#include "qemu/osdep.h" +#include "qom/object.h" hw/riscv/riscv-iommu.h line 33
Quoted 10 lines
hw/riscv/riscv-iommu.h new file +10
-0+ +#include "hw/riscv/iommu.h" + +struct RISCVIOMMUState { +/*< private >*/ +DeviceState parent_obj; + +/*< public >*/ +uint32_t version;/* Reported interface version number */ +uint32_t pasid_bits;/* process identifier width */ Do you mind renaming
pasid_bitsto something likepid_bitsto remain consistency?Quoted 187 lines
hw/riscv/riscv-iommu.h new file +109
-0+uint32_t bus;/* PCI bus mapping for non-root endpoints */ + +uint64_t cap;/* IOMMU supported capabilities */ +uint64_t fctl;/* IOMMU enabled features */ + +bool enable_off;/* Enable out-of-reset OFF mode (DMA disabled) */ +bool enable_msi;/* Enable MSI remapping */ + +/* IOMMU Internal State */ +uint64_t ddtp;/* Validated Device Directory Tree Root Pointer */ + +dma_addr_t cq_addr;/* Command queue base physical address */ +dma_addr_t fq_addr;/* Fault/event queue base physical address */ +dma_addr_t pq_addr;/* Page request queue base physical address */ + +uint32_t cq_mask;/* Command queue index bit mask */ +uint32_t fq_mask;/* Fault/event queue index bit mask */ +uint32_t pq_mask;/* Page request queue index bit mask */ + +/* interrupt notifier */ +void (*notify)(RISCVIOMMUState *iommu,unsigned vector); + +/* IOMMU State Machine */ +QemuThread core_proc;/* Background processing thread */ +QemuMutex core_lock;/* Global IOMMU lock, used for cache/regs updates */ +QemuCond core_cond;/* Background processing wake up signal */ +unsigned core_exec;/* Processing thread execution actions */ + +/* IOMMU target address space */ +AddressSpace *target_as; +MemoryRegion *target_mr; + +/* MSI / MRIF access trap */ +AddressSpace trap_as; +MemoryRegion trap_mr; + +GHashTable *ctx_cache;/* Device translation Context Cache */ +QemuMutex ctx_lock;/* Device translation Cache update lock */ + +/* MMIO Hardware Interface */ +MemoryRegion regs_mr; +QemuSpin regs_lock; +uint8_t *regs_rw;/* register state (user write) */ +uint8_t *regs_wc;/* write-1-to-clear mask */ +uint8_t *regs_ro;/* read-only mask */ + +QLIST_ENTRY (RISCVIOMMUState) iommus; + QLIST_HEAD(, RISCVIOMMUSpace) spaces; +}; + +void riscv_iommu_pci_setup_iommu (RISCVIOMMUState *iommu,PCIBus *bus, +Error **errp); + +/* private helpers */ + +/* Register helper functions */ +static inline uint32_t riscv_iommu_reg_mod32 (RISCVIOMMUState *s, +unsigned idx,uint32_t set,uint32_t clr) +{ +uint32_t val; +qemu_spin_lock (&s->regs_lock); + val =ldl_le_p (s->regs_rw + idx); +stl_le_p (s->regs_rw + idx, (val & ~clr) | set); +qemu_spin_unlock (&s->regs_lock); +return val; +} + +static inline void riscv_iommu_reg_set32 (RISCVIOMMUState *s, +unsigned idx,uint32_t set) +{ +qemu_spin_lock (&s->regs_lock); +stl_le_p (s->regs_rw + idx, set); +qemu_spin_unlock (&s->regs_lock); +} + +static inline uint32_t riscv_iommu_reg_get32 (RISCVIOMMUState *s, +unsigned idx) +{ +return ldl_le_p (s->regs_rw + idx); +} + +static inline uint64_t riscv_iommu_reg_mod64 (RISCVIOMMUState *s, +unsigned idx,uint64_t set,uint64_t clr) +{ +uint64_t val; +qemu_spin_lock (&s->regs_lock); + val =ldq_le_p (s->regs_rw + idx); +stq_le_p (s->regs_rw + idx, (val & ~clr) | set); +qemu_spin_unlock (&s->regs_lock); +return val; +} + +static inline void riscv_iommu_reg_set64 (RISCVIOMMUState *s, +unsigned idx,uint64_t set) +{ +qemu_spin_lock (&s->regs_lock); +stq_le_p (s->regs_rw + idx, set); +qemu_spin_unlock (&s->regs_lock); +} + +static inline uint64_t riscv_iommu_reg_get64 (RISCVIOMMUState *s, +unsigned idx) +{ +return ldq_le_p (s->regs_rw + idx); +} + + + +#endif hw/riscv/trace-events new file +11
-0@@ -0,0 +1,11 @@ +# See documentation at docs/devel/tracing.rst + +# riscv-iommu.c +riscv_iommu_new(const char *id, unsigned b, unsigned d, unsigned f) "%s: device attached %04x:%02x.%d" +riscv_iommu_flt(const char *id, unsigned b, unsigned d, unsigned f, uint64_t reason, uint64_t iova) "%s: fault %04x:%02x.%u reason: 0x%"PRIx64" iova: 0x%"PRIx64 +riscv_iommu_pri(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova) "%s: page request %04x:%02x.%u iova: 0x%"PRIx64 +riscv_iommu_dma(const char *id, unsigned b, unsigned d, unsigned f, unsigned pasid, const char *dir, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u #%u %s 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_msi(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u MSI 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_cmd(const char *id, uint64_t l, uint64_t u) "%s: command 0x%"PRIx64" 0x%"PRIx64 +riscv_iommu_notifier_add(const char *id) "%s: dev-iotlb notifier added" +riscv_iommu_notifier_del(const char *id) "%s: dev-iotlb notifier removed"hw/riscv/trace.h new file +1
-0@@ -0,0 +1 @@ +#include "trace/trace-hw_riscv.h" include/hw/riscv/iommu.h new file +36
-0@@ -0,0 +1,36 @@ +/* +* QEMU emulation of an RISC-V IOMMU +* +* Copyright (C) 2022-2023 Rivos Inc. +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; either version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License along +* with this program; if not, see <http://www.gnu.org/licenses/>. +*/ + +#ifndef HW_RISCV_IOMMU_H +#define HW_RISCV_IOMMU_H + +#include "qemu/osdep.h" +#include "qom/object.h" + +#define TYPE_RISCV_IOMMU "riscv-iommu" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUState, RISCV_IOMMU) +typedef struct RISCVIOMMUState RISCVIOMMUState ; + +#define TYPE_RISCV_IOMMU_MEMORY_REGION "riscv-iommu-mr" +typedef struct RISCVIOMMUSpace RISCVIOMMUSpace ; + +#define TYPE_RISCV_IOMMU_PCI "riscv-iommu-pci" +OBJECT_DECLARE_SIMPLE_TYPE(RISCVIOMMUStatePci, RISCV_IOMMU_PCI) +typedef struct RISCVIOMMUStatePci RISCVIOMMUStatePci ; + +#endif meson.build +1
-0@@ -3353,6 +3353,7 @@ if have_system 'hw/pci-host', 'hw/ppc', 'hw/rtc', + 'hw/riscv', 'hw/s390x', 'hw/scsi', 'hw/sd',
PATCH v4 4/14 pci-ids.rst: add Red Hat pci-id for RISC-V IOMMU device
In reply to Daniel Henrique BarbozaThe RISC-V IOMMU PCI device we're going to add next is a reference implementation of the riscv-iommu spec [1], which predicts that the IOMMU can be implemented as a PCIe device.
However, RISC-V International (RVI), the entity that ratified the riscv-iommu spec, didn't bother assigning a PCI ID for this IOMMU PCIe implementation that the spec predicts. This puts us in an uncommon situation because we want to add the reference IOMMU PCIe implementation but we don't have a PCI ID for it.
Given that RVI doesn't provide a PCI ID for it we reached out to Red Hat and Gerd Hoffman, and they were kind enough to give us a PCI ID for the RISC-V IOMMU PCI reference device.
Thanks Red Hat and Gerd for this RISC-V IOMMU PCIe device ID.
[1] https://github.com/riscv-non-isa/riscv-iommu/releases/tag/v1.0.0
--- docs/specs/pci-ids.rst | 2 ++ include/hw/pci/pci.h | 1 + 2 files changed, 3 insertions(+)
docs/specs/pci-ids.rst +2 -0
@@ -94,6 +94,8 @@ PCI devices (other than virtio): PCI ACPI ERST device (``-device acpi-erst``) 1b36:0013 PCI UFS device (``-device ufs``) +1b36:0014 + PCI RISC-V IOMMU device All these devices are documented in :doc:`index`.
include/hw/pci/pci.h +1 -0
@@ -115,6 +115,7 @@ extern bool pci_available;#define PCI_DEVICE_ID_REDHAT_PVPANIC 0x0011#define PCI_DEVICE_ID_REDHAT_ACPI_ERST 0x0012#define PCI_DEVICE_ID_REDHAT_UFS 0x0013 +#define PCI_DEVICE_ID_REDHAT_RISCV_IOMMU 0x0014#define PCI_DEVICE_ID_REDHAT_QXL 0x0100#define FMT_PCIBUS PRIx64
Signature · 1 line
2.45.2
PATCH v4 5/14 hw/riscv: add riscv-iommu-pci reference device
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU can be modelled as a PCIe device following the guidelines of the RISC-V IOMMU spec, chapter 7.1, "Integrating an IOMMU as a PCIe device".
--- hw/riscv/meson.build | 2 +- hw/riscv/riscv-iommu-pci.c | 178 +++++++++++++++++++++++++++++++++++++ 2 files changed, 179 insertions(+), 1 deletion(-) create mode 100644 hw/riscv/riscv-iommu-pci.c
hw/riscv/meson.build +1 -1
@@ -10,6 +10,6 @@ riscv_ss.add(when: 'CONFIG_SIFIVE_U', if_true: files('sifive_u.c')) riscv_ss.add(when: 'CONFIG_SPIKE', if_true: files('spike.c')) riscv_ss.add(when: 'CONFIG_MICROCHIP_PFSOC', if_true: files('microchip_pfsoc.c')) riscv_ss.add(when: 'CONFIG_ACPI', if_true: files('virt-acpi-build.c')) -riscv_ss.add(when: 'CONFIG_RISCV_IOMMU', if_true: files('riscv-iommu.c')) +riscv_ss.add(when: 'CONFIG_RISCV_IOMMU', if_true: files('riscv-iommu.c', 'riscv-iommu-pci.c')) hw_arch += {'riscv': riscv_ss}
hw/riscv/riscv-iommu-pci.c new file +178 -0
178 lines not on this page · raw message
Signature · 1 line
2.45.2
PATCH v4 6/14 hw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
Generate device tree entry for riscv-iommu PCI device, along with mapping all PCI device identifiers to the single IOMMU device instance.
--- hw/riscv/virt.c | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-)
hw/riscv/virt.c +32 -1
@@ -32,6 +32,7 @@#include "hw/core/sysbus-fdt.h" #include "target/riscv/pmu.h" #include "hw/riscv/riscv_hart.h" +#include "hw/riscv/iommu.h" #include "hw/riscv/virt.h" #include "hw/riscv/boot.h" #include "hw/riscv/numa.h"
@@ -1006,6 +1007,30 @@ static void create_fdt_virtio_iommu(RISCVVirtState *s, uint16_t bdf) bdf + 1, iommu_phandle, bdf + 1, 0xffff - bdf); } +static void create_fdt_iommu (RISCVVirtState *s,uint16_t bdf) +{ +const char comp[] ="riscv,pci-iommu" ; +void *fdt =MACHINE (s)->fdt; +uint32_t iommu_phandle; + g_autofree char *iommu_node = NULL; + g_autofree char *pci_node = NULL; + + pci_node =g_strdup_printf ("/soc/pci@%lx" , + (long ) virt_memmap[VIRT_PCIE_ECAM ].base); + iommu_node =g_strdup_printf ("%s/iommu@%x" , pci_node, bdf); + iommu_phandle =qemu_fdt_alloc_phandle (fdt); +qemu_fdt_add_subnode (fdt, iommu_node); + +qemu_fdt_setprop (fdt, iommu_node,"compatible" , comp,sizeof (comp)); +qemu_fdt_setprop_cell (fdt, iommu_node,"#iommu-cells" ,1 ); +qemu_fdt_setprop_cell (fdt, iommu_node,"phandle" , iommu_phandle); +qemu_fdt_setprop_cells (fdt, iommu_node,"reg" , + bdf <<8 ,0 ,0 ,0 ,0 ); +qemu_fdt_setprop_cells (fdt, pci_node,"iommu-map" , +0 , iommu_phandle,0 , bdf, + bdf +1 , iommu_phandle, bdf +1 ,0xffff - bdf); +} +static void finalize_fdt (RISCVVirtState *s) {uint32_t phandle =1 , irq_mmio_phandle =1 , msi_pcie_phandle =1 ;
@@ -1712,9 +1737,11 @@ static HotplugHandler *virt_machine_get_hotplug_handler(MachineState *machine,MachineClass *mc =MACHINE_GET_CLASS (machine);if (device_is_dynamic_sysbus (mc, dev) || -object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI )) { +object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI ) || +object_dynamic_cast (OBJECT (dev),TYPE_RISCV_IOMMU_PCI )) {return HOTPLUG_HANDLER (machine); } +return NULL ; }
@@ -1735,6 +1762,10 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev,if (object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI )) {create_fdt_virtio_iommu (s,pci_get_bdf (PCI_DEVICE (dev))); } + +if (object_dynamic_cast (OBJECT (dev),TYPE_RISCV_IOMMU_PCI )) { +create_fdt_iommu (s,pci_get_bdf (PCI_DEVICE (dev))); + } }static void virt_machine_class_init (ObjectClass *oc,void *data)
Signature · 1 line
2.45.2
Re: [PATCH v4 06/14] hw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug
Quoted 9 lines · Daniel Henrique Barboza
From: Tomasz Jeznach <[email protected]>
Generate device tree entry for riscv-iommu PCI device, along with mapping all PCI device identifiers to the single IOMMU device instance.
Signed-off-by Tomasz Jeznach <[email protected]>Signed-off-by Daniel Henrique Barboza <[email protected]>Reviewed-by Frank Chang <[email protected]>
Alistair
Quoted 75 lines
--- hw/riscv/virt.c | 33 ++++++++++++++++++++++++++++++++- 1 file changed, 32 insertions(+), 1 deletion(-)hw/riscv/virt.c +32
-2@@ -32,6 +32,7 @@#include "hw/core/sysbus-fdt.h" #include "target/riscv/pmu.h" #include "hw/riscv/riscv_hart.h" +#include "hw/riscv/iommu.h" #include "hw/riscv/virt.h" #include "hw/riscv/boot.h" #include "hw/riscv/numa.h" @@ -1006,6 +1007,30 @@ static void create_fdt_virtio_iommu(RISCVVirtState *s, uint16_t bdf) bdf + 1, iommu_phandle, bdf + 1, 0xffff - bdf); } +static void create_fdt_iommu (RISCVVirtState *s,uint16_t bdf) +{ +const char comp[] ="riscv,pci-iommu" ; +void *fdt =MACHINE (s)->fdt; +uint32_t iommu_phandle; + g_autofree char *iommu_node = NULL; + g_autofree char *pci_node = NULL; + + pci_node =g_strdup_printf ("/soc/pci@%lx" , + (long ) virt_memmap[VIRT_PCIE_ECAM ].base); + iommu_node =g_strdup_printf ("%s/iommu@%x" , pci_node, bdf); + iommu_phandle =qemu_fdt_alloc_phandle (fdt); +qemu_fdt_add_subnode (fdt, iommu_node); + +qemu_fdt_setprop (fdt, iommu_node,"compatible" , comp,sizeof (comp)); +qemu_fdt_setprop_cell (fdt, iommu_node,"#iommu-cells" ,1 ); +qemu_fdt_setprop_cell (fdt, iommu_node,"phandle" , iommu_phandle); +qemu_fdt_setprop_cells (fdt, iommu_node,"reg" , + bdf <<8 ,0 ,0 ,0 ,0 ); +qemu_fdt_setprop_cells (fdt, pci_node,"iommu-map" , +0 , iommu_phandle,0 , bdf, + bdf +1 , iommu_phandle, bdf +1 ,0xffff - bdf); +} +static void finalize_fdt (RISCVVirtState *s) {uint32_t phandle =1 , irq_mmio_phandle =1 , msi_pcie_phandle =1 ;@@ -1712,9 +1737,11 @@ static HotplugHandler *virt_machine_get_hotplug_handler(MachineState *machine,MachineClass *mc =MACHINE_GET_CLASS (machine);if (device_is_dynamic_sysbus (mc, dev) || -object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI )) { +object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI ) || +object_dynamic_cast (OBJECT (dev),TYPE_RISCV_IOMMU_PCI )) {return HOTPLUG_HANDLER (machine); } +return NULL ; }@@ -1735,6 +1762,10 @@ static void virt_machine_device_plug_cb(HotplugHandler *hotplug_dev,if (object_dynamic_cast (OBJECT (dev),TYPE_VIRTIO_IOMMU_PCI )) {create_fdt_virtio_iommu (s,pci_get_bdf (PCI_DEVICE (dev))); } + +if (object_dynamic_cast (OBJECT (dev),TYPE_RISCV_IOMMU_PCI )) { +create_fdt_iommu (s,pci_get_bdf (PCI_DEVICE (dev))); + } }static void virt_machine_class_init (ObjectClass *oc,void *data) --2.45.2
PATCH v4 7/14 test/qtest: add riscv-iommu-pci tests
In reply to Daniel Henrique BarbozaTo test the RISC-V IOMMU emulation we'll use its PCI representation. Create a new 'riscv-iommu-pci' libqos device that will be present with CONFIG_RISCV_IOMMU. This config is only available for RISC-V, so this device will only be consumed by the RISC-V libqos machine.
Start with basic tests: a PCI sanity check and a reset state register test. The reset test was taken from the RISC-V IOMMU spec chapter 5.2, "Reset behavior".
More tests will be added later.
--- tests/qtest/libqos/meson.build | 4 ++ tests/qtest/libqos/riscv-iommu.c | 76 ++++++++++++++++++++++++++ tests/qtest/libqos/riscv-iommu.h | 71 ++++++++++++++++++++++++ tests/qtest/meson.build | 1 + tests/qtest/riscv-iommu-test.c | 93 ++++++++++++++++++++++++++++++++ 5 files changed, 245 insertions(+) create mode 100644 tests/qtest/libqos/riscv-iommu.c create mode 100644 tests/qtest/libqos/riscv-iommu.h create mode 100644 tests/qtest/riscv-iommu-test.c
tests/qtest/libqos/meson.build +4 -0
@@ -68,6 +68,10 @@ if have_virtfs libqos_srcs += files('virtio-9p.c', 'virtio-9p-client.c') endif +if config_all_devices.has_key('CONFIG_RISCV_IOMMU') + libqos_srcs += files('riscv-iommu.c') +endif + libqos = static_library('qos', libqos_srcs + genh, name_suffix: 'fa', build_by_default: false)
tests/qtest/libqos/riscv-iommu.c new file +76 -0
76 lines not on this page · raw message
tests/qtest/libqos/riscv-iommu.h new file +71 -0
71 lines not on this page · raw message
tests/qtest/meson.build +1 -0
@@ -293,6 +293,7 @@ qos_test_ss.add( 'vmxnet3-test.c', 'igb-test.c', 'ufs-test.c', + 'riscv-iommu-test.c', ) if config_all_devices.has_key('CONFIG_VIRTIO_SERIAL')
tests/qtest/riscv-iommu-test.c new file +93 -0
93 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH v4 07/14] test/qtest: add riscv-iommu-pci tests
Quoted 6 lines · Daniel Henrique Barboza
To test the RISC-V IOMMU emulation we'll use its PCI representation. Create a new 'riscv-iommu-pci' libqos device that will be present with
CONFIG_RISCV_IOMMU. This config is only available for RISC-V, so this device will only be consumed by the RISC-V libqos machine.
Quoted 8 lines
Start with basic tests: a PCI sanity check and a reset state register test. The reset test was taken from the RISC-V IOMMU spec chapter 5.2, "Reset behavior".
More tests will be added later.
Signed-off-by Daniel Henrique Barboza <[email protected]>Reviewed-by Frank Chang <[email protected]>
Alistair
Quoted 300 lines
--- tests/qtest/libqos/meson.build | 4 ++ tests/qtest/libqos/riscv-iommu.c | 76 ++++++++++++++++++++++++++ tests/qtest/libqos/riscv-iommu.h | 71 ++++++++++++++++++++++++ tests/qtest/meson.build | 1 + tests/qtest/riscv-iommu-test.c | 93 ++++++++++++++++++++++++++++++++ 5 files changed, 245 insertions(+) create mode 100644 tests/qtest/libqos/riscv-iommu.c create mode 100644 tests/qtest/libqos/riscv-iommu.h create mode 100644 tests/qtest/riscv-iommu-test.ctests/qtest/libqos/meson.build +4
-0@@ -68,6 +68,10 @@ if have_virtfs libqos_srcs += files('virtio-9p.c', 'virtio-9p-client.c') endif +if config_all_devices.has_key('CONFIG_RISCV_IOMMU') + libqos_srcs += files('riscv-iommu.c') +endif + libqos = static_library('qos', libqos_srcs + genh, name_suffix: 'fa', build_by_default: false)tests/qtest/libqos/riscv-iommu.c new file +76
-0@@ -0,0 +1,76 @@ +/* +* libqos driver riscv-iommu-pci framework +* +* Copyright (c) 2024 Ventana Micro Systems Inc. +* +* This work is licensed under the terms of the GNU GPL, version 2 or (at your +* option) any later version. See the COPYING file in the top-level directory. +* +*/ + +#include "qemu/osdep.h" +#include "../libqtest.h" +#include "qemu/module.h" +#include "qgraph.h" +#include "pci.h" +#include "riscv-iommu.h" + +static void *riscv_iommu_pci_get_driver (void *obj,const char *interface) +{ +QRISCVIOMMU *r_iommu_pci = obj; + +if (!g_strcmp0 (interface,"pci-device" )) { +return &r_iommu_pci->dev; + } + +fprintf (stderr,"%s not present in riscv_iommu_pci\n" , interface); +g_assert_not_reached (); +} + +static void riscv_iommu_pci_start_hw (QOSGraphObject *obj) +{ +QRISCVIOMMU *pci = (QRISCVIOMMU *)obj; +qpci_device_enable (&pci->dev); +} + +static void riscv_iommu_pci_destructor (QOSGraphObject *obj) +{ +QRISCVIOMMU *pci = (QRISCVIOMMU *)obj; +qpci_iounmap (&pci->dev, pci->reg_bar); +} + +static void *riscv_iommu_pci_create (void *pci_bus,QGuestAllocator *alloc, +void *addr) +{ +QRISCVIOMMU *r_iommu_pci =g_new0 (QRISCVIOMMU ,1 ); +QPCIBus *bus = pci_bus; + +qpci_device_init (&r_iommu_pci->dev, bus, addr); + r_iommu_pci->reg_bar =qpci_iomap (&r_iommu_pci->dev,0 ,NULL ); + + r_iommu_pci->obj.get_driver = riscv_iommu_pci_get_driver; + r_iommu_pci->obj.start_hw = riscv_iommu_pci_start_hw; + r_iommu_pci->obj.destructor = riscv_iommu_pci_destructor; +return &r_iommu_pci->obj; +} + +static void riscv_iommu_pci_register_nodes (void ) +{ +QPCIAddress addr = { + .vendor_id =RISCV_IOMMU_PCI_VENDOR_ID , + .device_id =RISCV_IOMMU_PCI_DEVICE_ID , + .devfn =QPCI_DEVFN (1 ,0 ), + }; + +QOSGraphEdgeOptions opts = { + .extra_device_opts ="addr=01.0" , + }; + +add_qpci_address (&opts, &addr); + +qos_node_create_driver ("riscv-iommu-pci" , riscv_iommu_pci_create); +qos_node_produces ("riscv-iommu-pci" ,"pci-device" ); +qos_node_consumes ("riscv-iommu-pci" ,"pci-bus" , &opts); +} + +libqos_init (riscv_iommu_pci_register_nodes);tests/qtest/libqos/riscv-iommu.h new file +71
-0@@ -0,0 +1,71 @@ +/* +* libqos driver riscv-iommu-pci framework +* +* Copyright (c) 2024 Ventana Micro Systems Inc. +* +* This work is licensed under the terms of the GNU GPL, version 2 or (at your +* option) any later version. See the COPYING file in the top-level directory. +* +*/ + +#ifndef TESTS_LIBQOS_RISCV_IOMMU_H +#define TESTS_LIBQOS_RISCV_IOMMU_H + +#include "qgraph.h" +#include "pci.h" +#include "qemu/bitops.h" + +#ifndef GENMASK_ULL +#define GENMASK_ULL (h, l) (((~0ULL) >> (63 - (h) + (l))) << (l)) +#endif + +/* +* RISC-V IOMMU uses PCI_VENDOR_ID_REDHAT 0x1b36 and +* PCI_DEVICE_ID_REDHAT_RISCV_IOMMU 0x0014. +*/ +#define RISCV_IOMMU_PCI_VENDOR_ID 0x1b36 +#define RISCV_IOMMU_PCI_DEVICE_ID 0x0014 +#define RISCV_IOMMU_PCI_DEVICE_CLASS 0x0806 + +/* Common field positions */ +#define RISCV_IOMMU_QUEUE_ENABLE BIT(0) +#define RISCV_IOMMU_QUEUE_INTR_ENABLE BIT(1) +#define RISCV_IOMMU_QUEUE_MEM_FAULT BIT(8) +#define RISCV_IOMMU_QUEUE_ACTIVE BIT(16) +#define RISCV_IOMMU_QUEUE_BUSY BIT(17) + +#define RISCV_IOMMU_REG_CAP 0x0000 +#define RISCV_IOMMU_CAP_VERSION GENMASK_ULL(7, 0) + +#define RISCV_IOMMU_REG_DDTP 0x0010 +#define RISCV_IOMMU_DDTP_BUSY BIT_ULL(4) +#define RISCV_IOMMU_DDTP_MODE GENMASK_ULL(3, 0) +#define RISCV_IOMMU_DDTP_MODE_OFF 0 + +#define RISCV_IOMMU_REG_CQCSR 0x0048 +#define RISCV_IOMMU_CQCSR_CQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_CQCSR_CIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_CQCSR_CQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_CQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +#define RISCV_IOMMU_REG_FQCSR 0x004C +#define RISCV_IOMMU_FQCSR_FQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_FQCSR_FIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_FQCSR_FQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_FQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +#define RISCV_IOMMU_REG_PQCSR 0x0050 +#define RISCV_IOMMU_PQCSR_PQEN RISCV_IOMMU_QUEUE_ENABLE +#define RISCV_IOMMU_PQCSR_PIE RISCV_IOMMU_QUEUE_INTR_ENABLE +#define RISCV_IOMMU_PQCSR_PQON RISCV_IOMMU_QUEUE_ACTIVE +#define RISCV_IOMMU_PQCSR_BUSY RISCV_IOMMU_QUEUE_BUSY + +#define RISCV_IOMMU_REG_IPSR 0x0054 + +typedef struct QRISCVIOMMU { +QOSGraphObject obj; +QPCIDevice dev; +QPCIBar reg_bar; +}QRISCVIOMMU ; + +#endif tests/qtest/meson.build +1
-0@@ -293,6 +293,7 @@ qos_test_ss.add( 'vmxnet3-test.c', 'igb-test.c', 'ufs-test.c', + 'riscv-iommu-test.c', ) if config_all_devices.has_key('CONFIG_VIRTIO_SERIAL')tests/qtest/riscv-iommu-test.c new file +93
-1@@ -0,0 +1,93 @@ +/* +* QTest testcase for RISC-V IOMMU +* +* Copyright (c) 2024 Ventana Micro Systems Inc. +* +* This work is licensed under the terms of the GNU GPL, version 2 or (at your +* option) any later version. See the COPYING file in the top-level directory. +* +*/ + +#include "qemu/osdep.h" +#include "libqtest-single.h" +#include "qemu/module.h" +#include "libqos/qgraph.h" +#include "libqos/riscv-iommu.h" +#include "hw/pci/pci_regs.h" + +static uint32_t riscv_iommu_read_reg32 (QRISCVIOMMU *r_iommu,int reg_offset) +{ +uint32_t reg; + +qpci_memread (&r_iommu->dev, r_iommu->reg_bar, reg_offset, + ®,sizeof (reg)); +return reg; +} + +static uint64_t riscv_iommu_read_reg64 (QRISCVIOMMU *r_iommu,int reg_offset) +{ +uint64_t reg; + +qpci_memread (&r_iommu->dev, r_iommu->reg_bar, reg_offset, + ®,sizeof (reg)); +return reg; +} + +static void test_pci_config (void *obj,void *data,QGuestAllocator *t_alloc) +{ +QRISCVIOMMU *r_iommu = obj; +QPCIDevice *dev = &r_iommu->dev; +uint16_t vendorid, deviceid, classid; + + vendorid =qpci_config_readw (dev,PCI_VENDOR_ID ); + deviceid =qpci_config_readw (dev,PCI_DEVICE_ID ); + classid =qpci_config_readw (dev,PCI_CLASS_DEVICE ); + + g_assert_cmpuint(vendorid, ==, RISCV_IOMMU_PCI_VENDOR_ID); + g_assert_cmpuint(deviceid, ==, RISCV_IOMMU_PCI_DEVICE_ID); + g_assert_cmpuint(classid, ==, RISCV_IOMMU_PCI_DEVICE_CLASS); +} + +static void test_reg_reset (void *obj,void *data,QGuestAllocator *t_alloc) +{ +QRISCVIOMMU *r_iommu = obj; +uint64_t cap; +uint32_t reg; + + cap =riscv_iommu_read_reg64 (r_iommu,RISCV_IOMMU_REG_CAP ); + g_assert_cmpuint(cap & RISCV_IOMMU_CAP_VERSION, ==, 0x10); + + reg =riscv_iommu_read_reg32 (r_iommu,RISCV_IOMMU_REG_CQCSR ); + g_assert_cmpuint(reg & RISCV_IOMMU_CQCSR_CQEN, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_CQCSR_CIE, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_CQCSR_CQON, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_CQCSR_BUSY, ==, 0); + + reg =riscv_iommu_read_reg32 (r_iommu,RISCV_IOMMU_REG_FQCSR ); + g_assert_cmpuint(reg & RISCV_IOMMU_FQCSR_FQEN, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_FQCSR_FIE, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_FQCSR_FQON, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_FQCSR_BUSY, ==, 0); + + reg =riscv_iommu_read_reg32 (r_iommu,RISCV_IOMMU_REG_PQCSR ); + g_assert_cmpuint(reg & RISCV_IOMMU_PQCSR_PQEN, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_PQCSR_PIE, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_PQCSR_PQON, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_PQCSR_BUSY, ==, 0); + + reg =riscv_iommu_read_reg32 (r_iommu,RISCV_IOMMU_REG_DDTP ); + g_assert_cmpuint(reg & RISCV_IOMMU_DDTP_BUSY, ==, 0); + g_assert_cmpuint(reg & RISCV_IOMMU_DDTP_MODE, ==, +RISCV_IOMMU_DDTP_MODE_OFF ); + + reg =riscv_iommu_read_reg32 (r_iommu,RISCV_IOMMU_REG_IPSR ); + g_assert_cmpuint(reg, ==, 0); +} + +static void register_riscv_iommu_test (void ) +{ +qos_add_test ("pci_config" ,"riscv-iommu-pci" , test_pci_config,NULL ); +qos_add_test ("reg_reset" ,"riscv-iommu-pci" , test_reg_reset,NULL ); +} + +libqos_init (register_riscv_iommu_test); --2.45.2
PATCH v4 8/14 hw/riscv/riscv-iommu: add Address Translation Cache (IOATC)
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
The RISC-V IOMMU spec predicts that the IOMMU can use translation caches to hold entries from the DDT. This includes implementation for all cache commands that are marked as 'not implemented'.
There are some artifacts included in the cache that predicts s-stage and g-stage elements, although we don't support it yet. We'll introduce them next.
--- hw/riscv/riscv-iommu.c | 197 ++++++++++++++++++++++++++++++++++++++++- hw/riscv/riscv-iommu.h | 3 + 2 files changed, 196 insertions(+), 4 deletions(-)
hw/riscv/riscv-iommu.c +193 -4
@@ -63,6 +63,16 @@ struct RISCVIOMMUContext {uint64_t msiptp;/* MSI redirection page table pointer */ }; +/* Address translation cache entry */ +struct RISCVIOMMUEntry { +uint64_t iova:44 ;/* IOVA Page Number */ +uint64_t pscid:20 ;/* Process Soft-Context identifier */ +uint64_t phys:44 ;/* Physical Page Number */ +uint64_t gscid:16 ;/* Guest Soft-Context identifier */ +uint64_t perm:2 ;/* IOMMU_RW flags */ +uint64_t __rfu:2 ; +}; +/* IOMMU index for transactions without process_id specified. */ #define RISCV_IOMMU_NOPROCID 0
@@ -787,13 +797,129 @@ static AddressSpace *riscv_iommu_space(RISCVIOMMUState *s, uint32_t devid)return &as->iova_as; } +/* Translation Object cache support */ +static gboolean __iot_equal (gconstpointer v1,gconstpointer v2) +{ +RISCVIOMMUEntry *t1 = (RISCVIOMMUEntry *) v1; +RISCVIOMMUEntry *t2 = (RISCVIOMMUEntry *) v2; +return t1->gscid == t2->gscid && t1->pscid == t2->pscid && + t1->iova == t2->iova; +} + +static guint __iot_hash (gconstpointer v) +{ +RISCVIOMMUEntry *t = (RISCVIOMMUEntry *) v; +return (guint )t->iova; +} + +/* GV: 1 PSCV: 1 AV: 1 */ +static void __iot_inval_pscid_iova (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUEntry *iot = (RISCVIOMMUEntry *) value; +RISCVIOMMUEntry *arg = (RISCVIOMMUEntry *) data; +if (iot->gscid == arg->gscid && + iot->pscid == arg->pscid && + iot->iova == arg->iova) { + iot->perm =IOMMU_NONE ; + } +} + +/* GV: 1 PSCV: 1 AV: 0 */ +static void __iot_inval_pscid (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUEntry *iot = (RISCVIOMMUEntry *) value; +RISCVIOMMUEntry *arg = (RISCVIOMMUEntry *) data; +if (iot->gscid == arg->gscid && + iot->pscid == arg->pscid) { + iot->perm =IOMMU_NONE ; + } +} + +/* GV: 1 GVMA: 1 */ +static void __iot_inval_gscid_gpa (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUEntry *iot = (RISCVIOMMUEntry *) value; +RISCVIOMMUEntry *arg = (RISCVIOMMUEntry *) data; +if (iot->gscid == arg->gscid) { +/* simplified cache, no GPA matching */ + iot->perm =IOMMU_NONE ; + } +} + +/* GV: 1 GVMA: 0 */ +static void __iot_inval_gscid (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUEntry *iot = (RISCVIOMMUEntry *) value; +RISCVIOMMUEntry *arg = (RISCVIOMMUEntry *) data; +if (iot->gscid == arg->gscid) { + iot->perm =IOMMU_NONE ; + } +} + +/* GV: 0 */ +static void __iot_inval_all (gpointer key,gpointer value,gpointer data) +{ +RISCVIOMMUEntry *iot = (RISCVIOMMUEntry *) value; + iot->perm =IOMMU_NONE ; +} + +/* caller should keep ref-count for iot_cache object */ +static RISCVIOMMUEntry *riscv_iommu_iot_lookup (RISCVIOMMUContext *ctx, +GHashTable *iot_cache,hwaddr iova) +{ +RISCVIOMMUEntry key = { + .pscid =get_field (ctx->ta,RISCV_IOMMU_DC_TA_PSCID ), + .iova =PPN_DOWN (iova), + }; +return g_hash_table_lookup (iot_cache, &key); +} + +/* caller should keep ref-count for iot_cache object */ +static void riscv_iommu_iot_update (RISCVIOMMUState *s, +GHashTable *iot_cache,RISCVIOMMUEntry *iot) +{ +if (!s->iot_limit) { +return ; + } + +qemu_mutex_lock (&s->iot_lock); +if (g_hash_table_size (s->iot_cache) >= s->iot_limit) { + iot_cache =g_hash_table_new_full (__iot_hash, __iot_equal, + g_free,NULL ); +g_hash_table_unref (qatomic_xchg (&s->iot_cache, iot_cache)); + } +g_hash_table_add (iot_cache, iot); +qemu_mutex_unlock (&s->iot_lock); +} + +static void riscv_iommu_iot_inval (RISCVIOMMUState *s,GHFunc func, +uint32_t gscid,uint32_t pscid,hwaddr iova) +{ +GHashTable *iot_cache; +RISCVIOMMUEntry key = { + .gscid = gscid, + .pscid = pscid, + .iova =PPN_DOWN (iova), + }; + + iot_cache =g_hash_table_ref (s->iot_cache); +qemu_mutex_lock (&s->iot_lock); +g_hash_table_foreach (iot_cache, func, &key); +qemu_mutex_unlock (&s->iot_lock); +g_hash_table_unref (iot_cache); +} +static int riscv_iommu_translate (RISCVIOMMUState *s,RISCVIOMMUContext *ctx, -IOMMUTLBEntry *iotlb) +IOMMUTLBEntry *iotlb,bool enable_cache) { +RISCVIOMMUEntry *iot; +IOMMUAccessFlags perm;bool enable_pasid;bool enable_pri; +GHashTable *iot_cache;int fault; + iot_cache =g_hash_table_ref (s->iot_cache);/* * TC[32] is reserved for custom extensions, used here to temporarily * enable automatic page-request generation for ATS queries.
@@ -801,9 +927,38 @@ static int riscv_iommu_translate(RISCVIOMMUState *s, RISCVIOMMUContext *ctx, enable_pri = (iotlb->perm ==IOMMU_NONE ) && (ctx->tc &BIT_ULL (32 )); enable_pasid = (ctx->tc &RISCV_IOMMU_DC_TC_PDTV ); +qemu_mutex_lock (&s->iot_lock); + iot =riscv_iommu_iot_lookup (ctx, iot_cache, iotlb->iova); +qemu_mutex_unlock (&s->iot_lock); + perm = iot ? iot->perm :IOMMU_NONE ; +if (perm !=IOMMU_NONE ) { + iotlb->translated_addr =PPN_PHYS (iot->phys); + iotlb->addr_mask = ~TARGET_PAGE_MASK ; + iotlb->perm = perm; + fault =0 ; + goto done; + } +/* Translate using device directory / page table information. */ fault =riscv_iommu_spa_fetch (s, ctx, iotlb); +if (!fault && iotlb->target_as == &s->trap_as) { +/* Do not cache trapped MSI translations */ + goto done; + } + +if (!fault && iotlb->translated_addr != iotlb->iova && enable_cache) { + iot =g_new0 (RISCVIOMMUEntry,1 ); + iot->iova =PPN_DOWN (iotlb->iova); + iot->phys =PPN_DOWN (iotlb->translated_addr); + iot->pscid =get_field (ctx->ta,RISCV_IOMMU_DC_TA_PSCID ); + iot->perm = iotlb->perm; +riscv_iommu_iot_update (s, iot_cache, iot); + } + +done: +g_hash_table_unref (iot_cache); +if (enable_pri && fault) {struct riscv_iommu_pq_record pr = {0 };if (enable_pasid) {
@@ -943,13 +1098,40 @@ static void riscv_iommu_process_cq_tail(RISCVIOMMUState *s)if (cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_PSCV ) {/* illegal command arguments IOTINVAL.GVMA & PSCV == 1 */ goto cmd_ill; + }else if (!(cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_GV )) { +/* invalidate all cache mappings */ + func = __iot_inval_all; + }else if (!(cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_AV )) { +/* invalidate cache matching GSCID */ + func = __iot_inval_gscid; + }else { +/* invalidate cache matching GSCID and ADDR (GPA) */ + func = __iot_inval_gscid_gpa; } -/* translation cache not implemented yet */ +riscv_iommu_iot_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IOTINVAL_GSCID ),0 , + cmd.dword1 &TARGET_PAGE_MASK );break ;case RISCV_IOMMU_CMD (RISCV_IOMMU_CMD_IOTINVAL_FUNC_VMA ,RISCV_IOMMU_CMD_IOTINVAL_OPCODE ): -/* translation cache not implemented yet */ +if (!(cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_GV )) { +/* invalidate all cache mappings, simplified model */ + func = __iot_inval_all; + }else if (!(cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_PSCV )) { +/* invalidate cache matching GSCID, simplified model */ + func = __iot_inval_gscid; + }else if (!(cmd.dword0 &RISCV_IOMMU_CMD_IOTINVAL_AV )) { +/* invalidate cache matching GSCID and PSCID */ + func = __iot_inval_pscid; + }else { +/* invalidate cache matching GSCID and PSCID and ADDR (IOVA) */ + func = __iot_inval_pscid_iova; + } +riscv_iommu_iot_inval (s, func, +get_field (cmd.dword0,RISCV_IOMMU_CMD_IOTINVAL_GSCID ), +get_field (cmd.dword0,RISCV_IOMMU_CMD_IOTINVAL_PSCID ), + cmd.dword1 &TARGET_PAGE_MASK );break ; case RISCV_IOMMU_CMD(RISCV_IOMMU_CMD_IODIR_FUNC_INVAL_DDT,
@@ -1450,6 +1632,10 @@ static void riscv_iommu_realize(DeviceState *dev, Error **errp) g_free, NULL);qemu_mutex_init (&s->ctx_lock); + s->iot_cache =g_hash_table_new_full (__iot_hash, __iot_equal, + g_free,NULL ); +qemu_mutex_init (&s->iot_lock); + s->iommus.le_next =NULL ; s->iommus.le_prev =NULL ;QLIST_INIT (&s->spaces);
@@ -1462,6 +1648,7 @@ static void riscv_iommu_unrealize(DeviceState *dev)RISCVIOMMUState *s =RISCV_IOMMU (dev);qemu_mutex_destroy (&s->core_lock); +g_hash_table_unref (s->iot_cache);g_hash_table_unref (s->ctx_cache); }
@@ -1469,6 +1656,8 @@ static Property riscv_iommu_properties[] = {DEFINE_PROP_UINT32 ("version" , RISCVIOMMUState, version,RISCV_IOMMU_SPEC_DOT_VER ),DEFINE_PROP_UINT32 ("bus" , RISCVIOMMUState, bus,0x0 ), +DEFINE_PROP_UINT32 ("ioatc-limit" , RISCVIOMMUState, iot_limit, +LIMIT_CACHE_IOT ),DEFINE_PROP_BOOL ("intremap" , RISCVIOMMUState, enable_msi, TRUE),DEFINE_PROP_BOOL ("off" , RISCVIOMMUState, enable_off, TRUE), DEFINE_PROP_LINK("downstream-mr", RISCVIOMMUState, target_mr,
@@ -1521,7 +1710,7 @@ static IOMMUTLBEntry riscv_iommu_memory_region_translate(/* Translation disabled or invalid. */ iotlb.addr_mask =0 ; iotlb.perm =IOMMU_NONE ; - }else if (riscv_iommu_translate (as->iommu, ctx, &iotlb)) { + }else if (riscv_iommu_translate (as->iommu, ctx, &iotlb, true)) {/* Translation disabled or fault reported. */ iotlb.addr_mask =0 ; iotlb.perm =IOMMU_NONE ;
hw/riscv/riscv-iommu.h +3 -0
@@ -69,6 +69,9 @@ struct RISCVIOMMUState {GHashTable *ctx_cache;/* Device translation Context Cache */ QemuMutex ctx_lock;/* Device translation Cache update lock */ +GHashTable *iot_cache;/* IO Translated Address Cache */ +QemuMutex iot_lock;/* IO TLB Cache update lock */ +unsigned iot_limit;/* IO Translation Cache size limit */ /* MMIO Hardware Interface */ MemoryRegion regs_mr;
Signature · 1 line
2.45.2
PATCH v4 9/14 hw/riscv/riscv-iommu: add s-stage and g-stage support
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
Add support for s-stage (sv32, sv39, sv48, sv57 caps) and g-stage (sv32x4, sv39x4, sv48x4, sv57x4 caps). Most of the work is done in the riscv_iommu_spa_fetch() function that now has to consider how many translation stages we need to walk the page table.
--- hw/riscv/riscv-iommu-bits.h | 12 ++ hw/riscv/riscv-iommu.c | 377 +++++++++++++++++++++++++++++++++++- hw/riscv/riscv-iommu.h | 2 + 3 files changed, 381 insertions(+), 10 deletions(-)
hw/riscv/riscv-iommu-bits.h +12 -0
@@ -71,6 +71,14 @@ struct riscv_iommu_pq_record {/* 5.3 IOMMU Capabilities (64bits) */ #define RISCV_IOMMU_REG_CAP 0x0000#define RISCV_IOMMU_CAP_VERSION GENMASK_ULL(7, 0) +#define RISCV_IOMMU_CAP_SV32 BIT_ULL(8) +#define RISCV_IOMMU_CAP_SV39 BIT_ULL(9) +#define RISCV_IOMMU_CAP_SV48 BIT_ULL(10) +#define RISCV_IOMMU_CAP_SV57 BIT_ULL(11) +#define RISCV_IOMMU_CAP_SV32X4 BIT_ULL(16) +#define RISCV_IOMMU_CAP_SV39X4 BIT_ULL(17) +#define RISCV_IOMMU_CAP_SV48X4 BIT_ULL(18) +#define RISCV_IOMMU_CAP_SV57X4 BIT_ULL(19)#define RISCV_IOMMU_CAP_MSI_FLAT BIT_ULL(22)#define RISCV_IOMMU_CAP_MSI_MRIF BIT_ULL(23)#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26)
@@ -84,6 +92,7 @@ struct riscv_iommu_pq_record {#define RISCV_IOMMU_REG_FCTL 0x0008#define RISCV_IOMMU_FCTL_BE BIT(0)#define RISCV_IOMMU_FCTL_WSI BIT(1) +#define RISCV_IOMMU_FCTL_GXL BIT(2)/* 5.5 Device-directory-table pointer (64bits) */ #define RISCV_IOMMU_REG_DDTP 0x0010
@@ -206,6 +215,8 @@ struct riscv_iommu_dc {#define RISCV_IOMMU_DC_TC_DTF BIT_ULL(4)#define RISCV_IOMMU_DC_TC_PDTV BIT_ULL(5)#define RISCV_IOMMU_DC_TC_PRPR BIT_ULL(6) +#define RISCV_IOMMU_DC_TC_GADE BIT_ULL(7) +#define RISCV_IOMMU_DC_TC_SADE BIT_ULL(8)#define RISCV_IOMMU_DC_TC_DPE BIT_ULL(9)#define RISCV_IOMMU_DC_TC_SBE BIT_ULL(10)#define RISCV_IOMMU_DC_TC_SXL BIT_ULL(11)
@@ -316,6 +327,7 @@ enum riscv_iommu_fq_causes {/* First stage context fields */ #define RISCV_IOMMU_PC_FSC_PPN GENMASK_ULL(43, 0) +#define RISCV_IOMMU_PC_FSC_RESERVED GENMASK_ULL(59, 44)enum riscv_iommu_fq_ttypes {RISCV_IOMMU_FQ_TTYPE_NONE =0 ,
hw/riscv/riscv-iommu.c +367 -10
475 lines not on this page · raw message
hw/riscv/riscv-iommu.h +2 -0
@@ -38,6 +38,8 @@ struct RISCVIOMMUState {bool enable_off;/* Enable out-of-reset OFF mode (DMA disabled) */ bool enable_msi;/* Enable MSI remapping */ +bool enable_s_stage;/* Enable S/VS-Stage translation */ +bool enable_g_stage;/* Enable G-Stage translation */ /* IOMMU Internal State */ uint64_t ddtp;/* Validated Device Directory Tree Root Pointer */
Signature · 1 line
2.45.2
PATCH v4 10/14 hw/riscv/riscv-iommu: add ATS support
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
Add PCIe Address Translation Services (ATS) capabilities to the IOMMU. This will add support for ATS translation requests in Fault/Event queues, Page-request queue and IOATC invalidations.
--- hw/riscv/riscv-iommu-bits.h | 43 +++++++++++- hw/riscv/riscv-iommu.c | 129 +++++++++++++++++++++++++++++++++++- hw/riscv/riscv-iommu.h | 1 + hw/riscv/trace-events | 3 + 4 files changed, 173 insertions(+), 3 deletions(-)
hw/riscv/riscv-iommu-bits.h +42 -1
@@ -81,6 +81,7 @@ struct riscv_iommu_pq_record {#define RISCV_IOMMU_CAP_SV57X4 BIT_ULL(19)#define RISCV_IOMMU_CAP_MSI_FLAT BIT_ULL(22)#define RISCV_IOMMU_CAP_MSI_MRIF BIT_ULL(23) +#define RISCV_IOMMU_CAP_ATS BIT_ULL(25)#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26)#define RISCV_IOMMU_CAP_IGS GENMASK_ULL(29, 28)#define RISCV_IOMMU_CAP_PAS GENMASK_ULL(37, 32)
@@ -210,6 +211,7 @@ struct riscv_iommu_dc {/* Translation control fields */ #define RISCV_IOMMU_DC_TC_V BIT_ULL(0) +#define RISCV_IOMMU_DC_TC_EN_ATS BIT_ULL(1)#define RISCV_IOMMU_DC_TC_EN_PRI BIT_ULL(2)#define RISCV_IOMMU_DC_TC_T2GPA BIT_ULL(3)#define RISCV_IOMMU_DC_TC_DTF BIT_ULL(4)
@@ -271,6 +273,20 @@ struct riscv_iommu_command {#define RISCV_IOMMU_CMD_IODIR_DV BIT_ULL(33)#define RISCV_IOMMU_CMD_IODIR_DID GENMASK_ULL(63, 40) +/* 3.1.4 I/O MMU PCIe ATS */ +#define RISCV_IOMMU_CMD_ATS_OPCODE 4 +#define RISCV_IOMMU_CMD_ATS_FUNC_INVAL 0 +#define RISCV_IOMMU_CMD_ATS_FUNC_PRGR 1 +#define RISCV_IOMMU_CMD_ATS_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_CMD_ATS_PV BIT_ULL(32) +#define RISCV_IOMMU_CMD_ATS_DSV BIT_ULL(33) +#define RISCV_IOMMU_CMD_ATS_RID GENMASK_ULL(55, 40) +#define RISCV_IOMMU_CMD_ATS_DSEG GENMASK_ULL(63, 56) +/* dword1 is the ATS payload, two different payload types for INVAL and PRGR */ + +/* ATS.PRGR payload */ +#define RISCV_IOMMU_CMD_ATS_PRGR_RESP_CODE GENMASK_ULL(47, 44) +enum riscv_iommu_dc_fsc_atp_modes {RISCV_IOMMU_DC_FSC_MODE_BARE =0 ,RISCV_IOMMU_DC_FSC_IOSATP_MODE_SV32 =8 ,
@@ -337,7 +353,32 @@ enum riscv_iommu_fq_ttypes {RISCV_IOMMU_FQ_TTYPE_TADDR_INST_FETCH =5 ,RISCV_IOMMU_FQ_TTYPE_TADDR_RD =6 ,RISCV_IOMMU_FQ_TTYPE_TADDR_WR =7 , - RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ = 8, +RISCV_IOMMU_FQ_TTYPE_PCIE_ATS_REQ =8 , + RISCV_IOMMU_FW_TTYPE_PCIE_MSG_REQ = 9, +}; + +/* Header fields */ +#define RISCV_IOMMU_PREQ_HDR_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_PREQ_HDR_PV BIT_ULL(32) +#define RISCV_IOMMU_PREQ_HDR_PRIV BIT_ULL(33) +#define RISCV_IOMMU_PREQ_HDR_EXEC BIT_ULL(34) +#define RISCV_IOMMU_PREQ_HDR_DID GENMASK_ULL(63, 40) + +/* Payload fields */ +#define RISCV_IOMMU_PREQ_PAYLOAD_R BIT_ULL(0) +#define RISCV_IOMMU_PREQ_PAYLOAD_W BIT_ULL(1) +#define RISCV_IOMMU_PREQ_PAYLOAD_L BIT_ULL(2) +#define RISCV_IOMMU_PREQ_PAYLOAD_M GENMASK_ULL(2, 0) +#define RISCV_IOMMU_PREQ_PRG_INDEX GENMASK_ULL(11, 3) +#define RISCV_IOMMU_PREQ_UADDR GENMASK_ULL(63, 12) + + +/* +* struct riscv_iommu_msi_pte - MSI Page Table Entry +*/ +struct riscv_iommu_msi_pte { +uint64_t pte; +uint64_t mrif_info; };/* Fields on pte */
hw/riscv/riscv-iommu.c +127 -2
187 lines not on this page · raw message
hw/riscv/riscv-iommu.h +1 -0
@@ -38,6 +38,7 @@ struct RISCVIOMMUState {bool enable_off;/* Enable out-of-reset OFF mode (DMA disabled) */ bool enable_msi;/* Enable MSI remapping */ +bool enable_ats;/* Enable ATS support */ bool enable_s_stage;/* Enable S/VS-Stage translation */ bool enable_g_stage;/* Enable G-Stage translation */
hw/riscv/trace-events +3 -0
@@ -9,3 +9,6 @@ riscv_iommu_msi(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iov riscv_iommu_cmd(const char *id, uint64_t l, uint64_t u) "%s: command 0x%"PRIx64" 0x%"PRIx64 riscv_iommu_notifier_add(const char *id) "%s: dev-iotlb notifier added" riscv_iommu_notifier_del(const char *id) "%s: dev-iotlb notifier removed" +riscv_iommu_ats(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova) "%s: translate request %04x:%02x.%u iova: 0x%"PRIx64 +riscv_iommu_ats_inval(const char *id) "%s: dev-iotlb invalidate" +riscv_iommu_ats_prgr(const char *id) "%s: dev-iotlb page request group response"
Signature · 1 line
2.45.2
PATCH v4 11/14 hw/riscv/riscv-iommu: add DBG support
In reply to Daniel Henrique BarbozaFrom: Tomasz Jeznach <[email protected]>
DBG support adds three additional registers: tr_req_iova, tr_req_ctl and tr_response.
The DBG cap is always enabled. No on/off toggle is provided for it.
--- hw/riscv/riscv-iommu-bits.h | 17 +++++++++++ hw/riscv/riscv-iommu.c | 59 +++++++++++++++++++++++++++++++++++++ 2 files changed, 76 insertions(+)
hw/riscv/riscv-iommu-bits.h +17 -0
@@ -84,6 +84,7 @@ struct riscv_iommu_pq_record {#define RISCV_IOMMU_CAP_ATS BIT_ULL(25)#define RISCV_IOMMU_CAP_T2GPA BIT_ULL(26)#define RISCV_IOMMU_CAP_IGS GENMASK_ULL(29, 28) +#define RISCV_IOMMU_CAP_DBG BIT_ULL(31)#define RISCV_IOMMU_CAP_PAS GENMASK_ULL(37, 32)#define RISCV_IOMMU_CAP_PD8 BIT_ULL(38)#define RISCV_IOMMU_CAP_PD17 BIT_ULL(39)
@@ -186,6 +187,22 @@ enum { RISCV_IOMMU_INTR_COUNT }; +/* 5.24 Translation request IOVA (64bits) */ +#define RISCV_IOMMU_REG_TR_REQ_IOVA 0x0258 + +/* 5.25 Translation request control (64bits) */ +#define RISCV_IOMMU_REG_TR_REQ_CTL 0x0260 +#define RISCV_IOMMU_TR_REQ_CTL_GO_BUSY BIT_ULL(0) +#define RISCV_IOMMU_TR_REQ_CTL_NW BIT_ULL(3) +#define RISCV_IOMMU_TR_REQ_CTL_PID GENMASK_ULL(31, 12) +#define RISCV_IOMMU_TR_REQ_CTL_DID GENMASK_ULL(63, 40) + +/* 5.26 Translation request response (64bits) */ +#define RISCV_IOMMU_REG_TR_RESPONSE 0x0268 +#define RISCV_IOMMU_TR_RESPONSE_FAULT BIT_ULL(0) +#define RISCV_IOMMU_TR_RESPONSE_S BIT_ULL(9) +#define RISCV_IOMMU_TR_RESPONSE_PPN RISCV_IOMMU_PPN_FIELD +/* 5.27 Interrupt cause to vector (64bits) */ #define RISCV_IOMMU_REG_IVEC 0x02F8
hw/riscv/riscv-iommu.c +59 -0
83 lines not on this page · raw message
Signature · 1 line
2.45.2
PATCH v4 12/14 hw/riscv/riscv-iommu: Add another irq for mrif notifications
In reply to Daniel Henrique BarbozaFrom: Andrew Jones <[email protected]>
And add mrif notification trace.
--- hw/riscv/riscv-iommu-pci.c | 2 +- hw/riscv/riscv-iommu.c | 1 + hw/riscv/trace-events | 1 + 3 files changed, 3 insertions(+), 1 deletion(-)
hw/riscv/riscv-iommu-pci.c +1 -1
@@ -81,7 +81,7 @@ static void riscv_iommu_pci_realize(PCIDevice *dev, Error **errp)pci_register_bar (dev,0 ,PCI_BASE_ADDRESS_SPACE_MEMORY |PCI_BASE_ADDRESS_MEM_TYPE_64 , &s->bar0); -int ret =msix_init (dev,RISCV_IOMMU_INTR_COUNT , +int ret =msix_init (dev,RISCV_IOMMU_INTR_COUNT +1 , &s->bar0,0 ,RISCV_IOMMU_REG_MSI_CONFIG , &s->bar0,0 ,RISCV_IOMMU_REG_MSI_CONFIG +256 ,0 , &err);
hw/riscv/riscv-iommu.c +1 -0
@@ -623,6 +623,7 @@ static MemTxResult riscv_iommu_msi_write(RISCVIOMMUState *s, cause =RISCV_IOMMU_FQ_CAUSE_MSI_WR_FAULT ; goto err; } +trace_riscv_iommu_mrif_notification (s->parent_obj.id, n190, addr);return MEMTX_OK ;
hw/riscv/trace-events +1 -0
@@ -6,6 +6,7 @@ riscv_iommu_flt(const char *id, unsigned b, unsigned d, unsigned f, uint64_t rea riscv_iommu_pri(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova) "%s: page request %04x:%02x.%u iova: 0x%"PRIx64 riscv_iommu_dma(const char *id, unsigned b, unsigned d, unsigned f, unsigned pasid, const char *dir, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u #%u %s 0x%"PRIx64" -> 0x%"PRIx64 riscv_iommu_msi(const char *id, unsigned b, unsigned d, unsigned f, uint64_t iova, uint64_t phys) "%s: translate %04x:%02x.%u MSI 0x%"PRIx64" -> 0x%"PRIx64 +riscv_iommu_mrif_notification(const char *id, uint32_t nid, uint64_t phys) "%s: sent MRIF notification 0x%x to 0x%"PRIx64 riscv_iommu_cmd(const char *id, uint64_t l, uint64_t u) "%s: command 0x%"PRIx64" 0x%"PRIx64 riscv_iommu_notifier_add(const char *id) "%s: dev-iotlb notifier added" riscv_iommu_notifier_del(const char *id) "%s: dev-iotlb notifier removed"
Signature · 1 line
2.45.2
PATCH v4 13/14 qtest/riscv-iommu-test: add init queues test
In reply to Daniel Henrique BarbozaAdd an additional test to further exercise the IOMMU where we attempt to initialize the command, fault and page-request queues.
These steps are taken from chapter 6.2 of the RISC-V IOMMU spec, "Guidelines for initialization". It emulates what we expect from the software/OS when initializing the IOMMU.
--- tests/qtest/libqos/riscv-iommu.h | 29 +++++++ tests/qtest/riscv-iommu-test.c | 141 +++++++++++++++++++++++++++++++ 2 files changed, 170 insertions(+)
tests/qtest/libqos/riscv-iommu.h +29 -0
@@ -62,6 +62,35 @@#define RISCV_IOMMU_REG_IPSR 0x0054 +#define RISCV_IOMMU_REG_IVEC 0x02F8 +#define RISCV_IOMMU_REG_IVEC_CIV GENMASK_ULL(3, 0) +#define RISCV_IOMMU_REG_IVEC_FIV GENMASK_ULL(7, 4) +#define RISCV_IOMMU_REG_IVEC_PIV GENMASK_ULL(15, 12) + +#define RISCV_IOMMU_REG_CQB 0x0018 +#define RISCV_IOMMU_CQB_PPN_START 10 +#define RISCV_IOMMU_CQB_PPN_LEN 44 +#define RISCV_IOMMU_CQB_LOG2SZ_START 0 +#define RISCV_IOMMU_CQB_LOG2SZ_LEN 5 + +#define RISCV_IOMMU_REG_CQT 0x0024 + +#define RISCV_IOMMU_REG_FQB 0x0028 +#define RISCV_IOMMU_FQB_PPN_START 10 +#define RISCV_IOMMU_FQB_PPN_LEN 44 +#define RISCV_IOMMU_FQB_LOG2SZ_START 0 +#define RISCV_IOMMU_FQB_LOG2SZ_LEN 5 + +#define RISCV_IOMMU_REG_FQT 0x0034 + +#define RISCV_IOMMU_REG_PQB 0x0038 +#define RISCV_IOMMU_PQB_PPN_START 10 +#define RISCV_IOMMU_PQB_PPN_LEN 44 +#define RISCV_IOMMU_PQB_LOG2SZ_START 0 +#define RISCV_IOMMU_PQB_LOG2SZ_LEN 5 + +#define RISCV_IOMMU_REG_PQT 0x0044 + typedef struct QRISCVIOMMU { QOSGraphObject obj; QPCIDevice dev;
tests/qtest/riscv-iommu-test.c +141 -0
157 lines not on this page · raw message
Signature · 1 line
2.45.2
PATCH v4 14/14 docs/specs: add riscv-iommu
In reply to Daniel Henrique BarbozaAdd a simple guideline to use the existing RISC-V IOMMU support we just added.
This doc will be updated once we add the riscv-iommu-sys device.
--- docs/specs/index.rst | 1 + docs/specs/riscv-iommu.rst | 55 ++++++++++++++++++++++++++++++++++++++ docs/system/riscv/virt.rst | 13 +++++++++ 3 files changed, 69 insertions(+) create mode 100644 docs/specs/riscv-iommu.rst
docs/specs/index.rst +1 -0
@@ -33,3 +33,4 @@ guest hardware that is specific to QEMU. virt-ctlr vmcoreinfo vmgenid + riscv-iommu
docs/specs/riscv-iommu.rst new file +55 -0
55 lines not on this page · raw message
docs/system/riscv/virt.rst +13 -0
@@ -84,6 +84,19 @@ none``, as in Firmware images used for pflash must be exactly 32 MiB in size. +riscv-iommu support +------------------- + +The board has support for the riscv-iommu-pci device by using the following +command line: + +.. code-block:: bash + + $ qemu-system-riscv64 -M virt -device riscv-iommu-pci (...) + +Refer to :ref:`riscv-iommu` for more information on how the RISC-V IOMMU support +works. + Machine-specific options ------------------------
Signature · 1 line
2.45.2
Re: [PATCH v4 14/14] docs/specs: add riscv-iommu
Quoted 70 lines · Daniel Henrique Barboza
Add a simple guideline to use the existing RISC-V IOMMU support we just added.
This doc will be updated once we add the riscv-iommu-sys device.
Signed-off-by Daniel Henrique Barboza <[email protected]>--- docs/specs/index.rst | 1 + docs/specs/riscv-iommu.rst | 55 ++++++++++++++++++++++++++++++++++++++ docs/system/riscv/virt.rst | 13 +++++++++ 3 files changed, 69 insertions(+) create mode 100644 docs/specs/riscv-iommu.rstdocs/specs/index.rst +1
-0@@ -33,3 +33,4 @@ guest hardware that is specific to QEMU. virt-ctlr vmcoreinfo vmgenid + riscv-iommudocs/specs/riscv-iommu.rst new file +41
-0@@ -0,0 +1,55 @@ +.. _riscv-iommu: + +RISC-V IOMMU support for RISC-V machines +======================================== + +QEMU implements a RISC-V IOMMU emulation based on the RISC-V IOMMU spec +version 1.0 [1]. + +The emulation includes a PCI reference device, riscv-iommu-pci, that QEMU +RISC-V boards can use. The 'virt' RISC-V machine is compatible with this +device. + +A platform device that implements the RISC-V IOMMU will be added in the +future. + + +riscv-iommu-pci reference device +-------------------------------- + +This device implements the RISC-V IOMMU emulation as recommended by the section +"Integrating an IOMMU as a PCIe device" of [1]: a PCI device with base class 08h, +sub-class 06h and programming interface 00h. + +As a reference device it doesn't implement anything outside of the specification, +so it uses a generic default PCI ID given by QEMU: 1b36:0014. + +To include the device in the 'virt' machine: + +.. code-block:: bash + + $ qemu-system-riscv64 -M virt -device riscv-iommu-pci (...) + +As of this writing the existing Linux kernel support [2], not yet merged, is being +created as a Rivos device, i.e. it uses Rivos vendor ID. To use the riscv-iommu-pci +device with the existing kernel support we need to emulate a Rivos PCI IOMMU by +setting 'vendor-id' and 'device-id': + +.. code-block:: bash + + $ qemu-system-riscv64 -M virt \ + -device riscv-iommu-pci,vendor-id=0x1efd,device-id=0xedf1 (...)
docs/specs/riscv-iommu.rst line 51
Quoted 10 lines
docs/specs/riscv-iommu.rst new file +10
-0+ +Several options are available to control the capabilities of the device, namely: + +- "bus" +- "ioatc-limit" +- "intremap" +- "ats" +- "off" (Out-of-reset translation mode: 'on' for DMA disabled, 'off' for 'BARE' (passthrough)) +- "s-stage" +- "g-stage"
These names don't jump out of the spec, so we probably want to at least provide a sentence on what they mean/do.
Alistair
Quoted 32 lines
docs/specs/riscv-iommu.rst new file +4
-0+ + +[1] https://github.com/riscv-non-isa/riscv-iommu/releases/download/v1.0/riscv-iommu.pdf +[2] https://lore.kernel.org/linux-riscv/[email protected]/docs/system/riscv/virt.rst +13
-1@@ -84,6 +84,19 @@ none``, as in Firmware images used for pflash must be exactly 32 MiB in size. +riscv-iommu support +------------------- + +The board has support for the riscv-iommu-pci device by using the following +command line: + +.. code-block:: bash + + $ qemu-system-riscv64 -M virt -device riscv-iommu-pci (...) + +Refer to :ref:`riscv-iommu` for more information on how the RISC-V IOMMU support +works. + Machine-specific options ------------------------ --2.45.2
Hi,
Would it make it easier for review if we squash patch 3:
[PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation
and patch 8:
[PATCH v4 09/14] hw/riscv/riscv-iommu: add s-stage and g-stage support
In the same patch?
I'm asking because I've been noticing since the first versions that some reviews on patch 3 seems to refer to context that are s-stage and g-stage related, i.e. added later. Perhaps squashing them together makes it easier to review since we'll have a more complete picture. Patch 3 will end up gaining +381 lines though.
Thanks,
Daniel
Quoted 109 lines · Daniel Henrique Barboza
Hi,
This new version contains changes based on suggestions made during the v3 review [1]. Most notable changes:
- read/write locks were added in both
ctx_lockandiot_lock. This code was picked from Tomasz branch;
- a newriscv_iommu_validate_process_ctx()helper was added to make process-context validations. Suggested by Jason Chien;
- a new doc patch was added to document how the IOMMU can be used by the 'virt' RISC-V board. Suggested by Alistair.Patches based on alistair/riscv-to-apply.next. It's also applicable on master.
Patches missing reviews/acks: 3, 9, 14
* How it was tested *
This series was tested using an emulated QEMU RISC-V host booting a QEMU KVM guest, passing through an emulated e1000 network card from the host to the guest.
The Linux kernel used for tests can be found here:
https://github.com/tjeznach/linux/tree/riscv_iommu_v6-rc3
Changes from v3:
- patch 3:
- addedFCTL_BEandFCTL_WSIbits to regs_ro[] mask
- renamed 'ctx->pasid' to 'ctx->process_id'
- added device translation cache update lockctx_lock
- DC.tc.V == 0 is now checked beforeriscv_iommu_validate_device_ctx()
- PC.ta.V == 0 now issues a "PDT entry not valid" error in the end ofriscv_iommu_validate_device_ctx()
- added a newriscv_iommu_validate_process_ctx()helper to validate PC
as section 2.2.4 dictates
- patch 5:
- addedRISCV_PCI_CLASS_SYSTEM_IOMMUmacro and use it ink->class_id
- patch 8:
- added update lockiot_lock
- patch 9:
- added FSC related checks toriscv_iommu_validate_process_ctx()
- moved 'if (mode == bare)' check to happen afterctx->process_id==
noprocid check
- patch 14 (new):
- add riscv-iommu docs for more information on how to use the
riscv-iommu-pci device
- v3 link: https://lore.kernel.org/qemu-riscv/[email protected]/[1] https://lore.kernel.org/qemu-riscv/[email protected]/
Andrew Jones (1):
hw/riscv/riscv-iommu: Add another irq for mrif notificationsDaniel Henrique Barboza (4):
pci-ids.rst: add Red Hat pci-id for RISC-V IOMMU device test/qtest: add riscv-iommu-pci tests qtest/riscv-iommu-test: add init queues test docs/specs: add riscv-iommuTomasz Jeznach (9):
exec/memtxattr: add process identifier to the transaction attributes hw/riscv: addriscv-iommu-bits.h
hw/riscv: add RISC-V IOMMU base emulation
hw/riscv: add riscv-iommu-pci reference devicehw/riscv/virt.c: support for RISC-V IOMMU PCIDevice hotplug hw/riscv/riscv-iommu: add Address Translation Cache (IOATC) hw/riscv/riscv-iommu: add s-stage and g-stage support hw/riscv/riscv-iommu: add ATS support hw/riscv/riscv-iommu: add DBG supportdocs/specs/index.rst | 1 + docs/specs/pci-ids.rst | 2 + docs/specs/riscv-iommu.rst | 55 + docs/system/riscv/virt.rst | 13 + hw/riscv/Kconfig | 4 + hw/riscv/meson.build | 1 + hw/riscv/riscv-iommu-bits.h | 419 ++++++ hw/riscv/riscv-iommu-pci.c | 178 +++ hw/riscv/riscv-iommu.c | 2372 ++++++++++++++++++++++++++++++ hw/riscv/riscv-iommu.h | 148 ++ hw/riscv/trace-events | 15 + hw/riscv/trace.h | 1 + hw/riscv/virt.c | 33 +- include/exec/memattrs.h | 5 + include/hw/pci/pci.h | 1 + include/hw/riscv/iommu.h | 36 + meson.build | 1 + tests/qtest/libqos/meson.build | 4 + tests/qtest/libqos/riscv-iommu.c | 76 + tests/qtest/libqos/riscv-iommu.h | 100 ++ tests/qtest/meson.build | 1 + tests/qtest/riscv-iommu-test.c | 234 +++ 22 files changed, 3699 insertions(+), 1 deletion(-)create mode 100644
docs/specs/riscv-iommu.rstcreate mode 100644hw/riscv/riscv-iommu-bits.hcreate mode 100644hw/riscv/riscv-iommu-pci.ccreate mode 100644hw/riscv/riscv-iommu.ccreate mode 100644hw/riscv/riscv-iommu.hcreate mode 100644 hw/riscv/trace-events create mode 100644hw/riscv/trace.h
create mode 100644include/hw/riscv/iommu.hcreate mode 100644tests/qtest/libqos/riscv-iommu.ccreate mode 100644tests/qtest/libqos/riscv-iommu.hcreate mode 100644tests/qtest/riscv-iommu-test.c
Quoted 11 lines · Daniel Henrique Barboza
Hi,
Would it make it easier for review if we squash patch 3:
[PATCH v4 03/14] hw/riscv: add RISC-V IOMMU base emulation
and patch 8:
[PATCH v4 09/14] hw/riscv/riscv-iommu: add s-stage and g-stage support
Quoted 7 lines
In the same patch?
I'm asking because I've been noticing since the first versions that some reviews on patch 3 seems to refer to context that are s-stage and g-stage related, i.e. added later. Perhaps squashing them together makes it easier to review since we'll have a more complete picture. Patch 3 will end up gaining +381 lines though.
Squashing is probably the way to go
Alistair