Skip to contentSkip to conversation

ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

PATCH Applied Raymond Hackley 4 participants 6 messages Jun 30, 2024 – Jul 3, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v3 cover ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences.

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- UART (on USB connector via the TI TSU6721 MUIC)
- Regulators
- Touchscreen
- Accelerometer

---
v2: Adjust l3, l15, l22 and l27 regulator voltages. Sort nodes.
Set regulator-allow-set-load for vqmmc supplies.
v3: Rename node haptic to vibrator.

#1 lore raw

PATCH v3 1/2 dt-bindings: arm: qcom: Document samsung,ms013g

Document samsung,ms013g for Galaxy Grand 2.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
index ec1c10a12470..7990e7e27542 100644
@@ -141,6 +141,7 @@ properties:
               - microsoft,makepeace
               - microsoft,moneypenny
               - motorola,falcon
+              - samsung,ms013g
               - samsung,s3ve3g
           - const: qcom,msm8226
 
Signature · 1 line
2.39.2
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: qcom: Document samsung,ms013g

Quoted 3 lines · Raymond Hackley

Document samsung,ms013g for Galaxy Grand 2.

<form letter>
This is a friendly reminder during the review process.

It looks like you received a tag and forgot to add it.

If you do not know the process, here is a short explanation:
Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

If a tag was not added on purpose, please state why and what changed. </form letter>

Best regards,
Krzysztof

#3 lore raw

PATCH v3 2/2 ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

In reply to Raymond Hackley

Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences.

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- UART (on USB connector via the TI TSU6721 MUIC)
- Regulators
- Touchscreen
- Accelerometer

---
 arch/arm/boot/dts/qcom/Makefile               |   1 +
 .../dts/qcom/qcom-msm8226-samsung-ms013g.dts  | 386 ++++++++++++++++++
 2 files changed, 387 insertions(+)
 create mode 100644 arch/arm/boot/dts/qcom/qcom-msm8226-samsung-ms013g.dts
arch/arm/boot/dts/qcom/Makefile +1 -0
index ccd4ce6353df..f06c6d425e91 100644
@@ -28,6 +28,7 @@ dtb-$(CONFIG_ARCH_QCOM) += \
 	qcom-msm8226-microsoft-dempsey.dtb \
 	qcom-msm8226-microsoft-makepeace.dtb \
 	qcom-msm8226-microsoft-moneypenny.dtb \
+	qcom-msm8226-samsung-ms013g.dtb \
 	qcom-msm8226-samsung-s3ve3g.dtb \
 	qcom-msm8660-surf.dtb \
 	qcom-msm8916-samsung-e5.dtb \
arch/arm/boot/dts/qcom/qcom-msm8226-samsung-ms013g.dts new file +386 -0

386 lines not on this page · raw message

Signature · 1 line
2.39.2
#4 lore raw
In reply to Raymond Hackley
Quoted 12 lines · Raymond Hackley

Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences.

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- UART (on USB connector via the TI TSU6721 MUIC)
- Regulators
- Touchscreen
- Accelerometer

Quoted 7 lines

---
v2: Adjust l3, l15, l22 and l27 regulator voltages. Sort nodes.
Set regulator-allow-set-load for vqmmc supplies.
v3: Rename node haptic to vibrator.

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y qcom/qcom-msm8226-samsung-ms013g.dtb' for [email protected]:

arch/arm/boot/dts/qcom/qcom-msm8226-samsung-ms013g.dtb: syscon@f9011000: compatible: ['syscon'] is too short
from schema $id: http://devicetree.org/schemas/mfd/syscon-common.yaml#

maintainer Applied
#5 lore raw

Re: (subset) [PATCH v3 0/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

In reply to Raymond Hackley
Quoted 12 lines · Raymond Hackley

Samsung Galaxy Grand 2 is a phone based on MSM8226. It's similar to the other Samsung devices based on MSM8226 with only a few minor differences.

The device trees contain initial support with:
- GPIO keys
- Regulator haptic
- SDHCI (internal and external storage)
- UART (on USB connector via the TI TSU6721 MUIC)
- Regulators
- Touchscreen
- Accelerometer

Quoted 1 line

[...]

Applied, thanks!

[2/2] ARM: dts: qcom-msm8226-samsung-ms013g: Add initial device tree

      commit: 2a5454d0fe5684855581f8ad958afbcdc476fd64

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>