Add support for Kontron OSM-S i.MX93 SoM and carrier board
Subsystems (6)
cover Add support for Kontron OSM-S i.MX93 SoM and carrier board
From: Frieder Schrempf <[email protected]>
Patch 1-4: small DT binding fixups Patch 5: board DT bindings
Patch 6: support PMIC driver without IRQ Patch 7: add devicetrees
Frieder Schrempf (7):
dt-bindings: eeprom: at24: Move compatible for Belling BL24C16A to
proper place
dt-bindings: eeprom: at24: Add compatible for ONSemi N24S64B
dt-bindings: gpio: vf610: Allow gpio-line-names to be set
dt-bindings: regulator: pca9450: Make interrupt optional
dt-bindings: arm: fsl: Add Kontron i.MX93 OSM-S based boards
regulator: pca9450: Make IRQ optional
arm64: dts: Add support for Kontron i.MX93 OSM-S SoM and BL carrier
board
.../devicetree/bindings/arm/fsl.yaml | 6 + .../devicetree/bindings/eeprom/at24.yaml | 10 +- .../devicetree/bindings/gpio/gpio-vf610.yaml | 1 + .../regulator/nxp,pca9450-regulator.yaml | 1 - .../dts/freescale/imx93-kontron-bl-osm-s.dts | 165 ++++++ .../dts/freescale/imx93-kontron-osm-s.dtsi | 547 ++++++++++++++++++ drivers/regulator/pca9450-regulator.c | 41 +- 7 files changed, 744 insertions(+), 27 deletions(-) create mode 100644 arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts create mode 100644 arch/arm64/boot/dts/freescale/imx93-kontron-osm-s.dtsi
Signature · 1 line
2.45.2
PATCH 1/7 dt-bindings: eeprom: at24: Move compatible for Belling BL24C16A to proper place
From: Frieder Schrempf <[email protected]>
Merge the compatibles for the 24c16 types into a single list.
--- Documentation/devicetree/bindings/eeprom/at24.yaml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -4
@@ -102,9 +102,6 @@ properties: pattern: spd$ # These are special cases that don't conform to the above pattern. # Each requires a standard at24 model as fallback. - - items: - - const: belling,bl24c16a - - const: atmel,24c16 - items: - enum: - rohm,br24g01
@@ -122,7 +119,9 @@ properties: - rohm,br24g04 - const: atmel,24c04 - items: - - const: renesas,r1ex24016 + - enum: + - belling,bl24c16a + - renesas,r1ex24016 - const: atmel,24c16 - items: - const: giantec,gt24c32a
Signature · 1 line
2.45.2
Re: [PATCH 1/7] dt-bindings: eeprom: at24: Move compatible for Belling BL24C16A to proper place
Quoted 7 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
Merge the compatibles for the 24c16 types into a single list.
Signed-off-by Frieder Schrempf <[email protected]>--- Documentation/devicetree/bindings/eeprom/at24.yaml | 7 +++----
Best regards,
Krzysztof
PATCH 2/7 dt-bindings: eeprom: at24: Add compatible for ONSemi N24S64B
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
The ONSemi N24S64B is a 64 KBit serial EEPROM that is compatible with atmel,24c64.
--- Documentation/devicetree/bindings/eeprom/at24.yaml | 3 +++ 1 file changed, 3 insertions(+)
Documentation/devicetree/bindings/eeprom/at24.yaml +3 -0
@@ -126,6 +126,9 @@ properties: - items: - const: giantec,gt24c32a - const: atmel,24c32 + - items: + - const: onnn,n24s64b + - const: atmel,24c64 - items: - enum: - renesas,r1ex24128
Signature · 1 line
2.45.2
Re: [PATCH 2/7] dt-bindings: eeprom: at24: Add compatible for ONSemi N24S64B
Quoted 6 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
The ONSemi N24S64B is a 64 KBit serial EEPROM that is compatible with atmel,24c64.
Signed-off-by Frieder Schrempf <[email protected]>
Best regards,
Krzysztof
PATCH 3/7 dt-bindings: gpio: vf610: Allow gpio-line-names to be set
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
Describe common "gpio-line-names" property to fix dtbs_check warnings like:
arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@43810000:
'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'
--- Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 + 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +1 -0
@@ -50,6 +50,7 @@ properties: const: 2 gpio-controller: true + gpio-line-names: true clocks: items:
Signature · 1 line
2.45.2
Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set
Quoted 6 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
Describe common "gpio-line-names" property to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@43810000:
There is no such file. You cannot use future work as reason for a warning. Simply such warning does not exist at this point and introducing warnings knowingly is also not correct.
Quoted 12 lines
'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'Signed-off-by Frieder Schrempf <[email protected]>--- Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +0
-0
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml properties: · line 53
Quoted 4 lines
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +1
-0@@ -50,6 +50,7 @@ properties: const: 2 gpio-controller: true + gpio-line-names: true
maxItems are not known?
Best regards,
Krzysztof
Re: [PATCH 3/7] dt-bindings: gpio: vf610: Allow gpio-line-names to be set
Hi Krzysztof,
thanks for reviewing!
Quoted 11 lines · Krzysztof Kozlowski
Quoted 6 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
Describe common "gpio-line-names" property to fix
dtbs_checkwarnings like:
arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dtb: gpio@43810000:There is no such file. You cannot use future work as reason for a warning. Simply such warning does not exist at this point and introducing warnings knowingly is also not correct.
Ok, I will change the commit message and not mention the warning.
Quoted 15 lines
Quoted 15 lines
'gpio-line-names' does not match any of the regexes: '^.+-hog(-[0-9]+)?$', 'pinctrl-[0-9]+'Signed-off-by Frieder Schrempf <[email protected]>--- Documentation/devicetree/bindings/gpio/gpio-vf610.yaml | 1 + 1 file changed, 1 insertion(+)Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +0
-0@@ -50,6 +50,7 @@ properties: const: 2
Quoted 4 lines
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml properties: · line 53
Quoted 2 lines
Documentation/devicetree/bindings/gpio/gpio-vf610.yaml +1
-0gpio-controller: true + gpio-line-names: truemaxItems are not known?
I will set "minItems: 1" and "maxItems: 32" as this is the proper range for the number of values.
Thanks
Frieder
PATCH 4/7 dt-bindings: regulator: pca9450: Make interrupt optional
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
The interrupt line is currently only used for printing warnings and the PMIC works just fine without it.
Allow boards to not use the interrupt line and therefore make it optional.
--- .../devicetree/bindings/regulator/nxp,pca9450-regulator.yaml | 1 - 1 file changed, 1 deletion(-)
Documentation/devicetree/bindings/regulator/nxp,pca9450-regulator.yaml +0 -1
@@ -96,7 +96,6 @@ properties: required: - compatible - reg - - interrupts - regulators additionalProperties: false
Signature · 1 line
2.45.2
Re: [PATCH 4/7] dt-bindings: regulator: pca9450: Make interrupt optional
Quoted 8 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
The interrupt line is currently only used for printing warnings and the PMIC works just fine without it.
Allow boards to not use the interrupt line and therefore make it optional.
Do you want to say that interrupt is optional in the hardware and not connected in your board? Sorry, but that's quite long statement without actually stating the main point why this should be optional in the binding.
Best regards,
Krzysztof
Re: [PATCH 4/7] dt-bindings: regulator: pca9450: Make interrupt optional
Quoted 6 lines · Krzysztof Kozlowski
Quoted 5 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
The interrupt line is currently only used for printing warnings and the PMIC works just fine without it.
Quoted 7 lines
Quoted 3 lines
Allow boards to not use the interrupt line and therefore make it optional.
Do you want to say that interrupt is optional in the hardware and not connected in your board? Sorry, but that's quite long statement without actually stating the main point why this should be optional in the binding.
Yes, ok. I will change the commit message to be more precise.
PATCH 5/7 dt-bindings: arm: fsl: Add Kontron i.MX93 OSM-S based boards
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
Add the bindings for the Kontron i.MX93 OSM-S SoM and BL carrier board.
--- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/fsl.yaml +6 -0
@@ -1318,6 +1318,12 @@ properties: - const: variscite,var-som-mx93 - const: fsl,imx93 + - description: Kontron OSM-S i.MX93 SoM based boards + items: + - const: kontron,imx93-bl-osm-s # Kontron BL i.MX93 OSM-S board + - const: kontron,imx93-osm-s # Kontron OSM-S i.MX93 SoM + - const: fsl,imx93 + - description: Freescale Vybrid Platform Device Tree Bindings
Signature · 1 line
2.45.2
Re: [PATCH 5/7] dt-bindings: arm: fsl: Add Kontron i.MX93 OSM-S based boards
Quoted 8 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
Add the bindings for the Kontron i.MX93 OSM-S SoM and BL carrier board.
Signed-off-by Frieder Schrempf <[email protected]>--- Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
Best regards,
Krzysztof
PATCH 6/7 regulator: pca9450: Make IRQ optional
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
The IRQ line might not be connected on some boards. Allow the driver to be probed without it.
--- drivers/regulator/pca9450-regulator.c | 41 +++++++++++++-------------- 1 file changed, 19 insertions(+), 22 deletions(-)
drivers/regulator/pca9450-regulator.c +19 -22
@@ -891,11 +891,6 @@ static int pca9450_i2c_probe(struct i2c_client *i2c)unsigned int reset_ctrl;int ret; -if (!i2c->irq) { -dev_err (&i2c->dev,"No IRQ configured?\n" ); -return -EINVAL ; - } - pca9450 =devm_kzalloc (&i2c->dev,sizeof (struct pca9450 ),GFP_KERNEL );if (!pca9450)return -ENOMEM ;
@@ -967,23 +962,25 @@ static int pca9450_i2c_probe(struct i2c_client *i2c) } } - ret =devm_request_threaded_irq (pca9450->dev, pca9450->irq,NULL , - pca9450_irq_handler, - (IRQF_TRIGGER_FALLING |IRQF_ONESHOT ), -"pca9450-irq" , pca9450); -if (ret !=0 ) { -dev_err (pca9450->dev,"Failed to request IRQ: %d\n" , - pca9450->irq); -return ret; - } -/* Unmask all interrupt except PWRON/WDOG/RSVD */ - ret =regmap_update_bits (pca9450->regmap,PCA9450_REG_INT1_MSK , -IRQ_VR_FLT1 |IRQ_VR_FLT2 |IRQ_LOWVSYS | -IRQ_THERM_105 |IRQ_THERM_125 , -IRQ_PWRON |IRQ_WDOGB |IRQ_RSVD ); -if (ret) { -dev_err (&i2c->dev,"Unmask irq error\n" ); -return ret; +if (pca9450->irq) { + ret =devm_request_threaded_irq (pca9450->dev, pca9450->irq,NULL , + pca9450_irq_handler, + (IRQF_TRIGGER_FALLING |IRQF_ONESHOT ), +"pca9450-irq" , pca9450); +if (ret !=0 ) { +dev_err (pca9450->dev,"Failed to request IRQ: %d\n" , + pca9450->irq); +return ret; + } +/* Unmask all interrupt except PWRON/WDOG/RSVD */ + ret =regmap_update_bits (pca9450->regmap,PCA9450_REG_INT1_MSK , +IRQ_VR_FLT1 |IRQ_VR_FLT2 |IRQ_LOWVSYS | +IRQ_THERM_105 |IRQ_THERM_125 , +IRQ_PWRON |IRQ_WDOGB |IRQ_RSVD ); +if (ret) { +dev_err (&i2c->dev,"Unmask irq error\n" ); +return ret; + } }/* Clear PRESET_EN bit in BUCK123_DVS to use DVS registers */
Signature · 1 line
2.45.2
PATCH 7/7 arm64: dts: Add support for Kontron i.MX93 OSM-S SoM and BL carrier board
In reply to Frieder SchrempfFrom: Frieder Schrempf <[email protected]>
This adds support for the Kontron Electronics OSM-S i.MX93 SoM and the matching baseboard BL i.MX93.
The SoM hardware complies to the Open Standard Module (OSM) 1.1 specification, size S (https://sget.org/standards/osm).
--- .../dts/freescale/imx93-kontron-bl-osm-s.dts | 165 ++++++ .../dts/freescale/imx93-kontron-osm-s.dtsi | 547 ++++++++++++++++++ 2 files changed, 712 insertions(+) create mode 100644 arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts create mode 100644 arch/arm64/boot/dts/freescale/imx93-kontron-osm-s.dtsi
arch/arm64/boot/dts/freescale/imx93-kontron-bl-osm-s.dts new file +165 -0
@@ -0,0 +1,165 @@ +// SPDX-License-Identifier: GPL-2.0+ OR MIT +/* + * Copyright (C) 2024 Kontron Electronics GmbH + */ + +/dts-v1/; + +#include "imx93-kontron-osm-s.dtsi" + +/ { + model = "Kontron BL i.MX93 OSM-S"; + compatible = "kontron,imx93-bl-osm-s", "kontron,imx93-osm-s", "fsl,imx93"; + + aliases { + ethernet0 = &fec; + ethernet1 = &eqos; + }; + + leds { + compatible = "gpio-leds"; + + led1 { + label = "led1"; + gpios = <&gpio2 3 GPIO_ACTIVE_HIGH>; + linux,default-trigger = "heartbeat"; + }; + }; + + pwm-beeper { + compatible = "pwm-beeper"; + pwms = <&tpm6 1 5000 0>; + }; + + reg_vcc_panel: regulator-vcc-panel { + compatible = "regulator-fixed"; + enable-active-high; + gpio = <&gpio4 3 GPIO_ACTIVE_HIGH>; + regulator-max-microvolt = <3300000>; + regulator-min-microvolt = <3300000>; + regulator-name = "VCC_PANEL"; + }; +}; + +&lpspi8 { + status = "okay"; + assigned-clocks = <&clk IMX93_CLK_LPSPI8>; + assigned-clock-parents = <&clk IMX93_CLK_SYS_PLL_PFD0_DIV2>; + assigned-clock-rates = <100000000>; + + eeram@0 { + compatible = "microchip,48l640"; + reg = <0>; + spi-max-frequency = <20000000>; + }; +}; + +&eqos { /* Second ethernet (OSM-S ETH_B) */ + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_eqos_rgmii>; + phy-mode = "rgmii-id"; + phy-handle = <ðphy1>; + status = "okay"; + + mdio { + compatible = "snps,dwmac-mdio"; + #address-cells = <1>; + #size-cells = <0>; + + ethphy1: ethernet-phy@1 { + compatible = "ethernet-phy-id4f51.e91b"; + reg = <1>; + reset-assert-us = <10000>; + reset-gpios = <&gpio1 10 GPIO_ACTIVE_LOW>; + }; + }; +}; + +&fec { /* First ethernet (OSM-S ETH_A) */ + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_enet_rgmii>; + phy-connection-type = "rgmii-id"; + phy-handle = <ðphy0>; + status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + ethphy0: ethernet-phy@1 { + compatible = "ethernet-phy-id4f51.e91b"; + reg = <1>; + reset-assert-us = <10000>; + reset-gpios = <&gpio2 18 GPIO_ACTIVE_LOW>; + }; + }; +}; + +&flexcan1 { + status = "okay"; +}; + +&lpi2c2 { + status = "okay"; + + gpio_expander_dio: gpio@20 { + compatible = "ti,tca6408"; + reg = <0x20>; + gpio-controller; + #gpio-cells = <2>; + gpio-line-names = "DIO1_OUT","DIO1_IN", "DIO2_OUT","DIO2_IN", + "DIO3_OUT","DIO3_IN", "DIO4_OUT","DIO4_IN"; + interrupt-parent = <&gpio4>; + interrupts = <28 IRQ_TYPE_EDGE_FALLING>; + reset-gpios = <&gpio2 2 GPIO_ACTIVE_LOW>; + }; +}; + +&lpuart1 { + status = "okay"; +}; + +&lpuart7 { + uart-has-rtscts; + status = "okay"; +}; + +&lpuart6 { + linux,rs485-enabled-at-boot-time; + uart-has-rtscts; + status = "okay"; +}; + +&tpm6 { + status = "okay"; +}; + +&usbotg1 { + disable-over-current; + dr_mode = "host"; + status = "okay"; + + #address-cells = <1>; + #size-cells = <0>; + + usb1@1 { + compatible = "usb424,2514"; + reg = <1>; + }; +}; + +&usbotg2 { + adp-disable; + hnp-disable; + srp-disable; + + disable-over-current; + dr_mode = "otg"; + usb-role-switch; + status = "okay"; +}; + +&usdhc2 { + vmmc-supply = <®_vdd_3v3>; + status = "okay"; +};
arch/arm64/boot/dts/freescale/imx93-kontron-osm-s.dtsi new file +547 -0
547 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH 7/7] arm64: dts: Add support for Kontron i.MX93 OSM-S SoM and BL carrier board
Quoted 9 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
This adds support for the Kontron Electronics OSM-S i.MX93 SoM and the matching baseboard BL i.MX93.
The SoM hardware complies to the Open Standard Module (OSM) 1.1 specification, size S (https://sget.org/standards/osm).
Signed-off-by Frieder Schrempf <[email protected]>
This is missing the Makefile changes to actually build the DTs. I will add them in v2.
Bartosz Golaszewski
AppliedFrom: Bartosz Golaszewski <[email protected]>
Quoted 8 lines · Frieder Schrempf
From: Frieder Schrempf <[email protected]>
Patch 1-4: small DT binding fixups Patch 5: board DT bindings
Patch 6: support PMIC driver without IRQ Patch 7: add devicetrees[...]
Applied, thanks!
[1/7] dt-bindings: eeprom: at24: Move compatible for Belling BL24C16A to proper place
commit: d83c217778e7425d10105001150c5670e07f88fe
[2/7] dt-bindings: eeprom: at24: Add compatible for ONSemi N24S64B
commit: 3a9ba4e32230df6c48cda1fd5cbca6facacc74c2Best regards,
Signature · 1 line
Bartosz Golaszewski <[email protected]>