Skip to contentSkip to conversation

msc_sm2s_imx8mp: Adjust the initrd_addr location

PATCH Superseded Fabio Estevam 2 participants 5 messages Jul 3, 2024 – Jul 4, 2024 Arm i.MX and Layerscape

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH 1/1 msc_sm2s_imx8mp: Adjust the initrd_addr location

From: Fabio Estevam <[email protected]>

Booting an initramfs with the current address may lead to initramfs corruption and boot failure.

Move it 0x48000000 which avoids initramfs overlap and allows a successful initramfs boot.

---
 include/configs/msc_sm2s_imx8mp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/msc_sm2s_imx8mp.h +1 -1
index 3c7d96cb3c0a..2a52455ace34 100644
@@ -39,7 +39,7 @@
 	"fdt_addr_r=0x43000000\0"			\
 	"boot_fdt=try\0" \
 	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"initrd_addr=0x43800000\0"		\
+	"initrd_addr=0x48000000\0"		\
 	"bootm_size=0x10000000\0" \
 	"mmcpart=1\0" \
 	"mmcroot=/dev/mmcblk1p2 rootwait rw\0" \
Signature · 1 line
2.34.1
#1 lore raw
Quoted 18 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Booting an initramfs with the current address may lead to initramfs corruption and boot failure.

Move it 0x48000000 which avoids initramfs overlap and allows a successful initramfs boot.

---
 include/configs/msc_sm2s_imx8mp.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/msc_sm2s_imx8mp.h +0 -0
index 3c7d96cb3c0a..2a52455ace34 100644

include/configs/msc_sm2s_imx8mp.h line 45

Quoted 8 lines
include/configs/msc_sm2s_imx8mp.h +1 -1
@@ -39,7 +39,7 @@
 	"fdt_addr_r=0x43000000\0"			\
 	"boot_fdt=try\0" \
 	"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \
-	"initrd_addr=0x43800000\0"		\
+	"initrd_addr=0x48000000\0"		\
 	"bootm_size=0x10000000\0" \
 	"mmcpart=1\0" \
 	"mmcroot=/dev/mmcblk1p2 rootwait rw\0" \

Shouldn't fdt_addr_r change too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?

Signature · 1 line
Tom
author reviewer
#2 lore raw

Hi Tom,

Quoted 3 lines · Tom Rini

Shouldn't fdt_addr_r change too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?

It has 2GB of RAM.

Changing only initrd_addr and keeping fdt_addr_r unchanged allows a successful initramfs boot.

#3 lore raw
Quoted 4 lines · Fabio Estevam

Hi Tom,

On Wed, Jul 3, 2024 at 3:03 PM Tom Rini <[email protected]> wrote:

Quoted 8 lines
Quoted 3 lines

Shouldn't fdt_addr_r change too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?

It has 2GB of RAM.

Changing only initrd_addr and keeping fdt_addr_r unchanged allows a successful initramfs boot.

How is the fdt at 0x43000000 not being clobbered if the initramfs at 0x43800000 is? Is it because it's just enough of a bad spot that we relocate the fdt out of the way? With the kernel at 0x40480000 everything else is too low. kernel address + 128MiB for fdt address, then +512KiB (or a bit more, for nicer numbers) for initrd.

Signature · 1 line
Tom
author reviewer
#4 lore raw

Hi Tom,

Quoted 5 lines · Tom Rini

How is the fdt at 0x43000000 not being clobbered if the initramfs at 0x43800000 is? Is it because it's just enough of a bad spot that we relocate the fdt out of the way? With the kernel at 0x40480000 everything else is too low. kernel address + 128MiB for fdt address, then +512KiB (or a bit more, for nicer numbers) for initrd.

Thanks for the suggestion, it works.

I sent a v2 with that proposal.

Thanks