msc_sm2s_imx8mp: Adjust the initrd_addr location
Fabio Estevam
reviewerPATCH 1/1 msc_sm2s_imx8mp: Adjust the initrd_addr location
From: Fabio Estevam <[email protected]>
Booting an initramfs with the current address may lead to initramfs corruption and boot failure.
Move it 0x48000000 which avoids initramfs overlap and allows a successful initramfs boot.
--- include/configs/msc_sm2s_imx8mp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/configs/msc_sm2s_imx8mp.h +1 -1
@@ -39,7 +39,7 @@"fdt_addr_r=0x43000000\0" \"boot_fdt=try\0" \"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ -"initrd_addr=0x43800000\0" \ +"initrd_addr=0x48000000\0" \"bootm_size=0x10000000\0" \"mmcpart=1\0" \"mmcroot=/dev/mmcblk1p2 rootwait rw\0" \
Signature · 1 line
2.34.1
Quoted 18 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Booting an initramfs with the current address may lead to initramfs corruption and boot failure.
Move it
0x48000000which avoids initramfs overlap and allows a successful initramfs boot.Signed-off-by Fabio Estevam <[email protected]>--- include/configs/msc_sm2s_imx8mp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)include/configs/msc_sm2s_imx8mp.h +0
-0
include/configs/msc_sm2s_imx8mp.h line 45
Quoted 8 lines
include/configs/msc_sm2s_imx8mp.h +1
-1@@ -39,7 +39,7 @@"fdt_addr_r=0x43000000\0" \"boot_fdt=try\0" \"fdtfile=" CONFIG_DEFAULT_FDT_FILE "\0" \ -"initrd_addr=0x43800000\0" \ +"initrd_addr=0x48000000\0" \"bootm_size=0x10000000\0" \"mmcpart=1\0" \"mmcroot=/dev/mmcblk1p2 rootwait rw\0" \
Shouldn't fdt_addr_r change too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?
Signature · 1 line
Tom
Fabio Estevam
reviewerHi Tom,
Quoted 3 lines · Tom Rini
Shouldn't
fdt_addr_rchange too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?
It has 2GB of RAM.
Changing only initrd_addr and keeping fdt_addr_r unchanged allows a successful initramfs boot.
Quoted 4 lines · Fabio Estevam
Hi Tom,
On Wed, Jul 3, 2024 at 3:03 PM Tom Rini <[email protected]> wrote:
Quoted 8 lines
Quoted 3 lines
Shouldn't
fdt_addr_rchange too? This is making me suspect the whole map is too small for safety, how much memory does the platform have at minimum?It has 2GB of RAM.
Changing only
initrd_addrand keepingfdt_addr_runchanged allows a successful initramfs boot.
How is the fdt at 0x43000000 not being clobbered if the initramfs at 0x43800000 is? Is it because it's just enough of a bad spot that we relocate the fdt out of the way? With the kernel at 0x40480000 everything else is too low. kernel address + 128MiB for fdt address, then +512KiB (or a bit more, for nicer numbers) for initrd.
Signature · 1 line
Tom
Fabio Estevam
reviewerHi Tom,
Quoted 5 lines · Tom Rini
How is the fdt at
0x43000000not being clobbered if the initramfs at0x43800000is? Is it because it's just enough of a bad spot that we relocate the fdt out of the way? With the kernel at0x40480000everything else is too low. kernel address + 128MiB for fdt address, then +512KiB (or a bit more, for nicer numbers) for initrd.
Thanks for the suggestion, it works.
I sent a v2 with that proposal.
Thanks