Skip to contentSkip to conversation

nvme-pci: Fix the instructions for disabling power management

PATCH Applied Bart Van Assche 2 participants 2 messages Jul 11, 2024 – Jul 15, 2024 NVMe

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 nvme-pci: Fix the instructions for disabling power management

pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. Hence add pcie_port_pm=off. This disables power management for all PCIe ports.

This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.

Fixes 4641a8e6e145 ("nvme-pci: add trouble shooting steps for timeouts")
Cc Keith Busch <[email protected]>
Cc Christoph Hellwig <[email protected]>
Cc Chaitanya Kulkarni <[email protected]>

---

Changes compared to v1: restored "pcie_aspm=off"

 drivers/nvme/host/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -1
index 102a9fb0c65f..9e9b05e79c47 100644
@@ -1274,7 +1274,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)
 	dev_warn(dev->ctrl.device,
 		 "Does your device have a faulty power saving mode enabled?\n");
 	dev_warn(dev->ctrl.device,
-		 "Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off\" and report a bug\n");
+		 "Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off pcie_port_pm=off\" and report a bug\n");
 }
 
 static enum blk_eh_timer_return nvme_timeout(struct request *req)
maintainer Applied
#1 lore raw
Quoted 7 lines · Bart Van Assche

pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. Hence add pcie_port_pm=off. This disables power management for all PCIe ports.

This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.

Thanks, applied to nvme-6.11.