nvme-pci: Fix the instructions for disabling power management
PATCH 1/1 nvme-pci: Fix the instructions for disabling power management
pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. pcie_port_pm=off disables power management for all PCIe ports.
This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.
--- drivers/nvme/host/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/nvme/host/pci.c +1 -1
@@ -1274,7 +1274,7 @@ static void nvme_warn_reset(struct nvme_dev *dev, u32 csts)dev_warn (dev->ctrl.device,"Does your device have a faulty power saving mode enabled?\n" );dev_warn (dev->ctrl.device, -"Try \"nvme_core.default_ps_max_latency_us=0 pcie_aspm=off\" and report a bug\n" ); +"Try \"nvme_core.default_ps_max_latency_us=0 pcie_port_pm=off\" and report a bug\n" ); }static enum blk_eh_timer_return nvme_timeout (struct request *req)
Keith Busch
maintainerQuoted 6 lines · Bart Van Assche
pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. pcie_port_pm=off disables power management for all PCIe ports.
This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.
Interesting, didn't know about that parameter. Does this actually aspm too, though? It looks like we want aspm policy to be performance for that to happen.
Quoted 11 lines · Keith Busch
Quoted 6 lines · Bart Van Assche
pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. pcie_port_pm=off disables power management for all PCIe ports.
This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.
Interesting, didn't know about that parameter. Does this actually aspm too, though? It looks like we want aspm policy to be performance for that to happen.
Hi Keith,
I don't know the answer to your question. All I know is that the settings from this patch are required to make the SSD mentioned above work reliably.
Thanks,
Bart.
Keith Busch
maintainerQuoted 13 lines · Bart Van Assche
Quoted 11 lines · Keith Busch
Quoted 6 lines · Bart Van Assche
pcie_aspm=off tells the kernel not to modify the ASPM configuration. This setting does not guarantee that ASPM (Active State Power Management) is disabled. pcie_port_pm=off disables power management for all PCIe ports.
This patch has been tested on a workstation with a Samsung SSD 970 EVO Plus NVMe SSD.
Interesting, didn't know about that parameter. Does this actually aspm too, though? It looks like we want aspm policy to be performance for that to happen.
Quoted 5 lines
Hi Keith,
I don't know the answer to your question. All I know is that the settings from this patch are required to make the SSD mentioned above work reliably.
Okay, do you think we could just append the new parameter to the existing recommendation rather than replace the aspm one? I could swear I recall some platform where pcie_aspm=off did fix something, but it's been a while.