Skip to contentSkip to conversation

pkg-cmake CMAKE_ASM_COMPILER override

PATCH Applied Heiko Thiery 3 participants 4 messages Jul 13, 2024 – Aug 12, 2024

lore
Share & tools
lore
#0 lore raw

cover pkg-cmake CMAKE_ASM_COMPILER override

While I was adding a new host package (blake3) I got an error with the selection of the ASM compiler. The error could be fixed by using -DCMAKE_ASM_COMPILER="$(CMAKE_HOST_C_COMPILER). During the review it was noticed that the value DCMAKE_ASM_COMPILER was incorrectly set in the pkg-cmake infra. After this was fixed, the workaround for this could be removed in the blake3 package.

This workaround is also present in the llvm package and now can also be removed.

Heiko Thiery (2):
package/pkg-cmake: remove override of CMAKE_ASM_COMPILER package/llvm-project/llvm: remove overriding the ASM compiler

 package/llvm-project/llvm/llvm.mk | 6 +++---
 package/pkg-cmake.mk              | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#1 lore raw

PATCH 1/2 package/pkg-cmake: remove override of CMAKE_ASM_COMPILER

Overriding the ASM is wrong and leads to failures e.g. for the llvm package. Therefore the ASM compiler was overwritten there.

---
 package/pkg-cmake.mk | 1 -
 1 file changed, 1 deletion(-)
package/pkg-cmake.mk +0 -1
index 8f391eb4c9..c7032312fb 100644
@@ -147,7 +147,6 @@ define $(2)_CONFIGURE_CMDS
 		-DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \
 		-DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
 		-DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
-		-DCMAKE_ASM_COMPILER="$$(HOSTAS)" \
 		-DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \
 		-DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \
 		$(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#2 lore raw

Re: [Buildroot] [PATCH 1/2] package/pkg-cmake: remove override of CMAKE_ASM_COMPILER

Quoted 15 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Heiko" == Heiko Thiery <[email protected]> writes:

Overriding the ASM is wrong and leads to failures e.g. for the llvm package. Therefore the ASM compiler was overwritten there.

---
 package/pkg-cmake.mk | 1 -
 1 file changed, 1 deletion(-)
package/pkg-cmake.mk +0 -0
index 8f391eb4c9..c7032312fb 100644

package/pkg-cmake.mk define $(2)_CONFIGURE_CMDS · line 152

Quoted 7 lines
package/pkg-cmake.mk +0 -1
@@ -147,7 +147,6 @@ define $(2)_CONFIGURE_CMDS
 		-DCMAKE_CXX_FLAGS="$$(HOST_CXXFLAGS)" \
 		-DCMAKE_EXE_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
 		-DCMAKE_SHARED_LINKER_FLAGS="$$(HOST_LDFLAGS)" \
-		-DCMAKE_ASM_COMPILER="$$(HOSTAS)" \
 		-DCMAKE_C_COMPILER="$$(CMAKE_HOST_C_COMPILER)" \
 		-DCMAKE_CXX_COMPILER="$$(CMAKE_HOST_CXX_COMPILER)" \
 		$(if $$(CMAKE_HOST_C_COMPILER_LAUNCHER),\

Committed to 2024.02.x and 2024.05.x, thanks.

Signature · 5 lines
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
#3 lore raw
In reply to Heiko Thiery
Quoted 9 lines · Heiko Thiery

While I was adding a new host package (blake3) I got an error with the selection of the ASM compiler. The error could be fixed by using -DCMAKE_ASM_COMPILER="$(CMAKE_HOST_C_COMPILER). During the review it was noticed that the value DCMAKE_ASM_COMPILER was incorrectly set in the pkg-cmake infra. After this was fixed, the workaround for this could be removed in the blake3 package.

This workaround is also present in the llvm package and now can also be removed.

Applied both to master, thanks, after extending the commit message a little
like you asked.

Regards,
Arnout

Quoted 9 lines

Heiko Thiery (2):
package/pkg-cmake: remove override of CMAKE_ASM_COMPILER package/llvm-project/llvm: remove overriding the ASM compiler

  package/llvm-project/llvm/llvm.mk | 6 +++---
  package/pkg-cmake.mk              | 1 -
  2 files changed, 3 insertions(+), 4 deletions(-)

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot