Skip to content

pkg-cmake CMAKE_ASM_COMPILER override

Heiko Thiery buildroot 1 version Applied

Status from this message: Applied both to master, thanks, after extending the commit message a little

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 3 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2package/pkg-cmake: remove override of CMAKE_ASM_COMPILERpackage/pkg-cmake.mk+0 -11 reply
2/2package/llvm-project/llvm: remove overriding the ASM compilerpackage/llvm-project/llvm/llvm.mk+0 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/2] pkg-cmake CMAKE_ASM_COMPILER override

While I was adding a new host package (blake3) I got an error with the selection of the ASM compiler. The error could be fixed by using -DCMAKE_ASM_COMPILER="$(CMAKE_HOST_C_COMPILER). During the review it was noticed that the value DCMAKE_ASM_COMPILER was incorrectly set in the pkg-cmake infra. After this was fixed, the workaround for this could be removed in the blake3 package.

This workaround is also present in the llvm package and now can also be removed.

Heiko Thiery (2):
package/pkg-cmake: remove override of CMAKE_ASM_COMPILER package/llvm-project/llvm: remove overriding the ASM compiler

 package/llvm-project/llvm/llvm.mk | 6 +++---
 package/pkg-cmake.mk              | 1 -
 2 files changed, 3 insertions(+), 4 deletions(-)
Signature · 6 lines
2.39.2

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot