Skip to contentSkip to conversation

arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs

PATCH Applied Johan Hovold 3 participants 10 messages Jul 19, 2024 – Jul 29, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

cover arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs

I noticed that these issues had been reproduced in x1e80100-crd. Ideally these should go into 6.11 as well.

Johan

Johan Hovold (4):
arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node

 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts        | 16 ++++++++--------
 .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts   | 16 ++++++++--------
 2 files changed, 16 insertions(+), 16 deletions(-)
Signature · 1 line
2.44.2
#1 lore raw

PATCH 1/4 arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs

Disable the PCIe perst pull-down resistors to save some power.

---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +3 -3
index 2897dff8e3bb..4c8ae13d25b9 100644
@@ -885,7 +885,7 @@ perst-n-pins {
 			pins = "gpio143";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
@@ -908,7 +908,7 @@ perst-n-pins {
 			pins = "gpio151";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
@@ -931,7 +931,7 @@ perst-n-pins {
 			pins = "gpio141";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
Signature · 1 line
2.44.2
#3 lore raw

PATCH 2/4 arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node

In reply to Johan Hovold

Clean up the PCIe2a pinctrl node indentation which should use tabs only.

---
 arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +5 -5
index 4c8ae13d25b9..97bc717279a2 100644
@@ -889,11 +889,11 @@ perst-n-pins {
 		};
 
 		wake-n-pins {
-		       pins = "gpio145";
-		       function = "gpio";
-		       drive-strength = <2>;
-		       bias-pull-up;
-	       };
+			pins = "gpio145";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
 	};
 
 	pcie3a_default: pcie3a-default-state {
Signature · 1 line
2.44.2
#5 lore raw

PATCH 3/4 arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs

In reply to Johan Hovold

Disable the PCIe perst pull-down resistors to save some power.

---
 arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +3 -3
index a1baf30b023c..5e5fdb085b88 100644
@@ -1617,7 +1617,7 @@ perst-n-pins {
 			pins = "gpio143";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
@@ -1640,7 +1640,7 @@ perst-n-pins {
 			pins = "gpio151";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
@@ -1663,7 +1663,7 @@ perst-n-pins {
 			pins = "gpio141";
 			function = "gpio";
 			drive-strength = <2>;
-			bias-pull-down;
+			bias-disable;
 		};
 
 		wake-n-pins {
Signature · 1 line
2.44.2
#7 lore raw

PATCH 4/4 arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node

In reply to Johan Hovold

Clean up the PCIe2a pinctrl node indentation which should use tabs only.

---
 .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts    | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +5 -5
index 5e5fdb085b88..888f42ca230f 100644
@@ -1621,11 +1621,11 @@ perst-n-pins {
 		};
 
 		wake-n-pins {
-		       pins = "gpio145";
-		       function = "gpio";
-		       drive-strength = <2>;
-		       bias-pull-up;
-	       };
+			pins = "gpio145";
+			function = "gpio";
+			drive-strength = <2>;
+			bias-pull-up;
+		};
 	};
 
 	pcie3a_default: pcie3a-default-state {
Signature · 1 line
2.44.2
maintainer Applied
#9 lore raw
In reply to Johan Hovold
Quoted 6 lines · Johan Hovold

I noticed that these issues had been reproduced in x1e80100-crd. Ideally these should go into 6.11 as well.

Johan

Quoted 7 lines

Johan Hovold (4):
arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node

[...]

Applied, thanks!

[1/4] arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs

      commit: 7313361396d1db9c4d5a485ec5cf904792f5bd62
[2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
      commit: 60a99c4c10d41f4bbb54ec8a70dbdbc98eff18eb
[3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
      commit: a59e55237c477c7003f06c0297a80510434b3fe6
[4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
      commit: dfd06c0e7ff7af10b34fbd6526a08e078a1e876b

Best regards,

Signature · 1 line
Bjorn Andersson <[email protected]>