arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs
cover arm64: dts: qcom: sc8280xp: disable PCIe perst pull downs
I noticed that these issues had been reproduced in x1e80100-crd. Ideally these should go into 6.11 as well.
Johan
Johan Hovold (4):
arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 16 ++++++++-------- .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 16 ++++++++-------- 2 files changed, 16 insertions(+), 16 deletions(-)
Signature · 1 line
2.44.2
PATCH 1/4 arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
Disable the PCIe perst pull-down resistors to save some power.
--- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +3 -3
@@ -885,7 +885,7 @@ perst-n-pins { pins = "gpio143"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
@@ -908,7 +908,7 @@ perst-n-pins { pins = "gpio151"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
@@ -931,7 +931,7 @@ perst-n-pins { pins = "gpio141"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
Signature · 1 line
2.44.2
Re: [PATCH 1/4] arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
Quoted 4 lines · Johan Hovold
Disable the PCIe perst pull-down resistors to save some power.
Signed-off-by Johan Hovold <[email protected]>---
Konrad
PATCH 2/4 arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
In reply to Johan HovoldClean up the PCIe2a pinctrl node indentation which should use tabs only.
--- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts +5 -5
@@ -889,11 +889,11 @@ perst-n-pins { }; wake-n-pins { - pins = "gpio145"; - function = "gpio"; - drive-strength = <2>; - bias-pull-up; - }; + pins = "gpio145"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; pcie3a_default: pcie3a-default-state {
Signature · 1 line
2.44.2
Re: [PATCH 2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
Quoted 4 lines · Johan Hovold
Clean up the PCIe2a pinctrl node indentation which should use tabs only.
Signed-off-by Johan Hovold <[email protected]>---
Konrad
PATCH 3/4 arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
In reply to Johan HovoldDisable the PCIe perst pull-down resistors to save some power.
--- arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +3 -3
@@ -1617,7 +1617,7 @@ perst-n-pins { pins = "gpio143"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
@@ -1640,7 +1640,7 @@ perst-n-pins { pins = "gpio151"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
@@ -1663,7 +1663,7 @@ perst-n-pins { pins = "gpio141"; function = "gpio"; drive-strength = <2>; - bias-pull-down; + bias-disable; }; wake-n-pins {
Signature · 1 line
2.44.2
Re: [PATCH 3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
Quoted 4 lines · Johan Hovold
Disable the PCIe perst pull-down resistors to save some power.
Signed-off-by Johan Hovold <[email protected]>---
Konrad
PATCH 4/4 arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
In reply to Johan HovoldClean up the PCIe2a pinctrl node indentation which should use tabs only.
--- .../boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts +5 -5
@@ -1621,11 +1621,11 @@ perst-n-pins { }; wake-n-pins { - pins = "gpio145"; - function = "gpio"; - drive-strength = <2>; - bias-pull-up; - }; + pins = "gpio145"; + function = "gpio"; + drive-strength = <2>; + bias-pull-up; + }; }; pcie3a_default: pcie3a-default-state {
Signature · 1 line
2.44.2
Re: [PATCH 4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
Quoted 4 lines · Johan Hovold
Clean up the PCIe2a pinctrl node indentation which should use tabs only.
Signed-off-by Johan Hovold <[email protected]>---
Konrad
Quoted 6 lines · Johan Hovold
I noticed that these issues had been reproduced in x1e80100-crd. Ideally these should go into 6.11 as well.
Johan
Quoted 7 lines
Johan Hovold (4):
arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node[...]
Applied, thanks!
[1/4] arm64: dts: qcom: sc8280xp-crd: disable PCIe perst pull downs
commit: 7313361396d1db9c4d5a485ec5cf904792f5bd62
[2/4] arm64: dts: qcom: sc8280xp-crd: clean up PCIe2a pinctrl node
commit: 60a99c4c10d41f4bbb54ec8a70dbdbc98eff18eb
[3/4] arm64: dts: qcom: sc8280xp-x13s: disable PCIe perst pull downs
commit: a59e55237c477c7003f06c0297a80510434b3fe6
[4/4] arm64: dts: qcom: sc8280xp-x13s: clean up PCIe2a pinctrl node
commit: dfd06c0e7ff7af10b34fbd6526a08e078a1e876bBest regards,
Signature · 1 line
Bjorn Andersson <[email protected]>