cache: StarFive: Require a 64-bit system
Subsystems (2)
PATCH 1/1 cache: StarFive: Require a 64-bit system
From: Palmer Dabbelt <[email protected]>
This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.
--- drivers/cache/Kconfig | 1 + drivers/cache/starfive_starlink_cache.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)
drivers/cache/Kconfig +1 -0
@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE bool "StarFive StarLink Cache controller" depends on RISCV depends on ARCH_STARFIVE + depends on 64BIT select RISCV_DMA_NONCOHERENT select RISCV_NONSTANDARD_CACHE_OPS help
drivers/cache/starfive_starlink_cache.c +1 -1
@@ -19,7 +19,7 @@#define STARLINK_CACHE_FLUSH_CTL 0x10#define STARLINK_CACHE_ALIGN 0x40 -#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39, 0) +#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39ULL, 0)#define STARLINK_CACHE_FLUSH_CTL_MODE_MASK GENMASK(2, 1)#define STARLINK_CACHE_FLUSH_CTL_ENABLE_MASK BIT(0)
Signature · 1 line
2.45.2
Quoted 8 lines · Palmer Dabbelt
From: Palmer Dabbelt <[email protected]>
This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.
Fixes cabff60ca77d ("cache: Add StarFive StarLink cache management")Signed-off-by Palmer Dabbelt <[email protected]>
if you wanna take it - might be worth being explicit about it causing build issues for rv32 though.
Thanks,
Conor.
Quoted 33 lines
--- drivers/cache/Kconfig | 1 + drivers/cache/starfive_starlink_cache.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)drivers/cache/Kconfig +1
-0@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE bool "StarFive StarLink Cache controller" depends on RISCV depends on ARCH_STARFIVE + depends on 64BIT select RISCV_DMA_NONCOHERENT select RISCV_NONSTANDARD_CACHE_OPS helpdrivers/cache/starfive_starlink_cache.c +1
-1@@ -19,7 +19,7 @@#define STARLINK_CACHE_FLUSH_CTL 0x10#define STARLINK_CACHE_ALIGN 0x40 -#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39, 0) +#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39ULL, 0)#define STARLINK_CACHE_FLUSH_CTL_MODE_MASK GENMASK(2, 1)#define STARLINK_CACHE_FLUSH_CTL_ENABLE_MASK BIT(0)Signature · 1 line
2.45.2
Conor Dooley
maintainerQuoted 39 lines · Conor Dooley
Quoted 8 lines · Palmer Dabbelt
From: Palmer Dabbelt <[email protected]>
This has a bunch of {read,write}q() calls, so it won't work on 32-bit systems. I don't think there's any 32-bit StarFive systems, so for now just require 64-bit.
Fixes cabff60ca77d ("cache: Add StarFive StarLink cache management")Signed-off-by Palmer Dabbelt <[email protected]>Acked-by Conor Dooley <[email protected]>if you wanna take it - might be worth being explicit about it causing build issues for rv32 though.
Quoted 25 lines
--- drivers/cache/Kconfig | 1 + drivers/cache/starfive_starlink_cache.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-)drivers/cache/Kconfig +1
-0@@ -18,6 +18,7 @@ config STARFIVE_STARLINK_CACHE bool "StarFive StarLink Cache controller" depends on RISCV depends on ARCH_STARFIVE + depends on 64BIT select RISCV_DMA_NONCOHERENT select RISCV_NONSTANDARD_CACHE_OPS helpdrivers/cache/starfive_starlink_cache.c +0
-0@@ -19,7 +19,7 @@#define STARLINK_CACHE_FLUSH_CTL 0x10#define STARLINK_CACHE_ALIGN 0x40
Quoted 2 lines
drivers/cache/starfive_starlink_cache.c line 22
Quoted 2 lines
drivers/cache/starfive_starlink_cache.c +1
-1-#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39, 0) +#define STARLINK_CACHE_ADDRESS_RANGE_MASK GENMASK(39ULL, 0)
Actually, Emil pointed out on IRC that this looks wrong. Should probably be GENMASK_ULL(39, 0), not GENMASK(39ULL, 0)