Skip to contentSkip to conversation

Capitalize Farenheit

PATCH In review David Hunter 4 participants 6 messages Jul 23, 2024 – Aug 16, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Capitalize Farenheit

Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.

---
 Documentation/watchdog/watchdog-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/watchdog/watchdog-api.rst +1 -1
index 800dcd7586f2..78e228c272cf 100644
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
 support the GETBOOTSTATUS call.
 
 Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
     int temperature;
     ioctl(fd, WDIOC_GETTEMP, &temperature);
Signature · 1 line
2.34.1
maintainer
#1 lore raw
Quoted 3 lines · David Hunter

Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.

Please at least follow guidelines for submitting patches, specifically

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
"

Guenter

Quoted 18 lines
---
  Documentation/watchdog/watchdog-api.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/watchdog/watchdog-api.rst +1 -1
index 800dcd7586f2..78e228c272cf 100644
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
  support the GETBOOTSTATUS call.
 
  Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
      int temperature;
      ioctl(fd, WDIOC_GETTEMP, &temperature);
reviewer
#2 lore raw
Quoted 7 lines · Guenter Roeck
Quoted 3 lines · David Hunter

Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.

Please at least follow guidelines for submitting patches, specifically

Quoted 8 lines

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
"

Guenter

Also, please spell it correctly in the $Subject.

Quoted 18 lines
Quoted 16 lines

---
  Documentation/watchdog/watchdog-api.rst | 2 +-

  1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/watchdog/watchdog-api.rst +0 -0
index 800dcd7586f2..78e228c272cf 100644
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only

  support the GETBOOTSTATUS call.
    Some drivers can measure the temperature using the GETTEMP ioctl.  The

Documentation/watchdog/watchdog-api.rst +1 -1
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::

        int temperature;
      ioctl(fd, WDIOC_GETTEMP, &temperature);

Signature · 1 line
~Randy
#3 lore raw

PATCH v3 1/1 Documentation: Capitalize Fahrenheit in watchdog-api.rst

In reply to David Hunter

Capitalize "fahrenheit," a spelling mistake.

---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit message

V1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in Subject

V2: https://lore.kernel.org/lkml/[email protected]/

V1: https://lore.kernel.org/lkml/[email protected]/

 Documentation/watchdog/watchdog-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

Documentation/watchdog/watchdog-api.rst +1 -1
index 800dcd7586f2..78e228c272cf 100644
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
 support the GETBOOTSTATUS call.
 
 Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
     int temperature;
     ioctl(fd, WDIOC_GETTEMP, &temperature);
Signature · 1 line
2.34.1
maintainer Reviewed-by on v3 1/1
#4 lore raw

Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst

Quoted 3 lines · David Hunter

Capitalize "fahrenheit," a spelling mistake.

Quoted 30 lines

---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit message

V1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in Subject

V2: https://lore.kernel.org/lkml/[email protected]/

V1: https://lore.kernel.org/lkml/[email protected]/

  Documentation/watchdog/watchdog-api.rst | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

---

Documentation/watchdog/watchdog-api.rst +1 -1
index 800dcd7586f2..78e228c272cf 100644
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
  support the GETBOOTSTATUS call.
 
  Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::
 
      int temperature;
      ioctl(fd, WDIOC_GETTEMP, &temperature);
maintainer Applied
#5 lore raw

Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst

In reply to David Hunter
Quoted 25 lines · David Hunter

Capitalize "fahrenheit," a spelling mistake.

---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit message

V1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in Subject

V2: https://lore.kernel.org/lkml/[email protected]/

V1: https://lore.kernel.org/lkml/[email protected]/

 Documentation/watchdog/watchdog-api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

---

Documentation/watchdog/watchdog-api.rst +0 -0
index 800dcd7586f2..78e228c272cf 100644

Documentation/watchdog/watchdog-api.rst Note that not all devices support these two calls, and some only · line 252

Quoted 5 lines
Documentation/watchdog/watchdog-api.rst +1 -1
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only
 support the GETBOOTSTATUS call.
 
 Some drivers can measure the temperature using the GETTEMP ioctl.  The
-returned value is the temperature in degrees fahrenheit::
+returned value is the temperature in degrees Fahrenheit::

Applied, thanks.

jon