Capitalize Farenheit
Subsystems (2)
PATCH 1/1 Capitalize Farenheit
Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.
--- Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/watchdog/watchdog-api.rst +1 -1
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only support the GETBOOTSTATUS call. Some drivers can measure the temperature using the GETTEMP ioctl. The -returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit:: int temperature; ioctl(fd, WDIOC_GETTEMP, &temperature);
Signature · 1 line
2.34.1
Guenter Roeck
maintainerQuoted 3 lines · David Hunter
Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.
Please at least follow guidelines for submitting patches, specifically
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
"
Guenter
Quoted 18 lines
Signed-off-by David Hunter <[email protected]>--- Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/watchdog/watchdog-api.rst +1
-1@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only support the GETBOOTSTATUS call. Some drivers can measure the temperature using the GETTEMP ioctl. The -returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit:: int temperature; ioctl(fd, WDIOC_GETTEMP, &temperature);
Randy Dunlap
reviewerQuoted 7 lines · Guenter Roeck
Quoted 3 lines · David Hunter
Not capitalizing "fahrenheit" is an extremely minor spelling mistake. This commit fixes that.
Please at least follow guidelines for submitting patches, specifically
Quoted 8 lines
"Describe your changes in imperative mood, e.g. "make xyzzy do frotz" instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy to do frotz", as if you are giving orders to the codebase to change its behaviour.
"Guenter
Also, please spell it correctly in the $Subject.
Quoted 18 lines
Quoted 16 lines
Signed-off-by David Hunter <[email protected]>---
Documentation/watchdog/watchdog-api.rst| 2 +-1 file changed, 1 insertion(+), 1 deletion(-)Documentation/watchdog/watchdog-api.rst +0
-0@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some onlysupport the GETBOOTSTATUS call.
Some drivers can measure the temperature using the GETTEMP ioctl. TheDocumentation/watchdog/watchdog-api.rst +1
-1-returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit::int temperature;
ioctl(fd, WDIOC_GETTEMP, &temperature);
Signature · 1 line
~Randy
PATCH v3 1/1 Documentation: Capitalize Fahrenheit in watchdog-api.rst
In reply to David HunterCapitalize "fahrenheit," a spelling mistake.
---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit message
V1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in Subject
V2: https://lore.kernel.org/lkml/[email protected]/
V1: https://lore.kernel.org/lkml/[email protected]/
Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
---
Documentation/watchdog/watchdog-api.rst +1 -1
@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only support the GETBOOTSTATUS call. Some drivers can measure the temperature using the GETTEMP ioctl. The -returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit:: int temperature; ioctl(fd, WDIOC_GETTEMP, &temperature);
Signature · 1 line
2.34.1
Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst
Quoted 3 lines · David Hunter
Capitalize "fahrenheit," a spelling mistake.
Signed-off-by David Hunter <[email protected]>
Quoted 30 lines
---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit messageV1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in SubjectV2: https://lore.kernel.org/lkml/[email protected]/
V1: https://lore.kernel.org/lkml/[email protected]/
Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)---
Documentation/watchdog/watchdog-api.rst +1
-1@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only support the GETBOOTSTATUS call. Some drivers can measure the temperature using the GETTEMP ioctl. The -returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit:: int temperature; ioctl(fd, WDIOC_GETTEMP, &temperature);
Re: [PATCH v3] Documentation: Capitalize Fahrenheit in watchdog-api.rst
In reply to David HunterQuoted 25 lines · David Hunter
Capitalize "fahrenheit," a spelling mistake.
Signed-off-by David Hunter <[email protected]>---
V2 -> V3:
- Fixed misspelling of "Capitalize" in commit message.
- Put Tags and Kernel Subsystem in subject
- Put changelog after commit messageV1 -> V2:
- Fixed imperative mood
- Fixed misspelling of "Fahrenheit" in SubjectV2: https://lore.kernel.org/lkml/[email protected]/
V1: https://lore.kernel.org/lkml/[email protected]/
Documentation/watchdog/watchdog-api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)---
Documentation/watchdog/watchdog-api.rst +0
-0
Documentation/watchdog/watchdog-api.rst Note that not all devices support these two calls, and some only · line 252
Quoted 5 lines
Documentation/watchdog/watchdog-api.rst +1
-1@@ -249,7 +249,7 @@ Note that not all devices support these two calls, and some only support the GETBOOTSTATUS call. Some drivers can measure the temperature using the GETTEMP ioctl. The -returned value is the temperature in degrees fahrenheit:: +returned value is the temperature in degrees Fahrenheit::
Applied, thanks.
jon