Skip to contentSkip to conversation

docs: KVM: Fix register ID of SPSR_FIQ

PATCH Applied Takahiro Itazuri 5 participants 5 messages Jun 6, 2023 – Aug 5, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 docs: KVM: Fix register ID of SPSR_FIQ

Fixes the register ID of SPSR_FIQ.

SPSR_FIQ is a 64-bit register and the 64-bit register size mask is 0x0030000000000000ULL.

Fixes fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")

---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/

---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +1 -1
index a5c803f39832..65dad2581751 100644
@@ -2535,7 +2535,7 @@ Specifically:
   0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
   0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
   0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
-  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
+  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
   0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
   0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
   ...
Signature · 1 line
2.38.0
#1 lore raw

Hi folks,

I also came across this inconsistency in the docs. What happened to the patch in question?

#2 lore raw
In reply to Takahiro Itazuri

+Cc kvmarm people and the list ...

Quoted 7 lines · Takahiro Itazuri

Fixes the register ID of SPSR_FIQ.

SPSR_FIQ is a 64-bit register and the 64-bit register size mask is 0x0030000000000000ULL.

Fixes fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")

... since you're fixing the encoding of an *arm64* core register and the mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess this is the main reason why this patch has been blocked on the list for over a year, as pointed out recently by Alexander [*].

Quoted 16 lines

---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/

---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +0 -0
index a5c803f39832..65dad2581751 100644

Documentation/virt/kvm/api.rst Specifically: · line 2540

Quoted 8 lines
Documentation/virt/kvm/api.rst +1 -1
@@ -2535,7 +2535,7 @@ Specifically:
   0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
   0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
   0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
-  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
+  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
   0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
   0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
...

The change itself looks reasonable.

Thanks,
Zenghui

[*] https://lore.kernel.org/all/[email protected]

maintainer Acked-by
#3 lore raw
Quoted 2 lines · Zenghui Yu

+Cc kvmarm people and the list ...

Thanks Zenghui.

Quoted 7 lines · Takahiro Itazuri
Quoted 5 lines

Fixes the register ID of SPSR_FIQ.

SPSR_FIQ is a 64-bit register and the 64-bit register size mask is 0x0030000000000000ULL.

Quoted 7 lines
Quoted 2 lines
Fixes fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")

... since you're fixing the encoding of an *arm64* core register and the mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess this is the main reason why this patch has been blocked on the list for over a year, as pointed out recently by Alexander [*].

That, and the fact that this is send to an email address I haven't been reachable on for about 5 years...

Quoted 28 lines
Quoted 17 lines

---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/

---
 Documentation/virt/kvm/api.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +0 -0
index a5c803f39832..65dad2581751 100644

Documentation/virt/kvm/api.rst Specifically: · line 2540

Quoted 8 lines
Documentation/virt/kvm/api.rst +1 -1
@@ -2535,7 +2535,7 @@ Specifically:
   0x6030 0000 0010 004a SPSR_ABT    64  spsr[KVM_SPSR_ABT]
   0x6030 0000 0010 004c SPSR_UND    64  spsr[KVM_SPSR_UND]
   0x6030 0000 0010 004e SPSR_IRQ    64  spsr[KVM_SPSR_IRQ]
-  0x6060 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
+  0x6030 0000 0010 0050 SPSR_FIQ    64  spsr[KVM_SPSR_FIQ]
   0x6040 0000 0010 0054 V0         128  fp_regs.vregs[0]    [1]_
   0x6040 0000 0010 0058 V1         128  fp_regs.vregs[1]    [1]_
...

The change itself looks reasonable.

Quoted 4 lines

Thanks,
Zenghui

[*] https://lore.kernel.org/all/[email protected]

In case Oliver picks this up for 6.11:

	M.
Signature · 1 line
Without deviation from the norm, progress is not possible.