docs: KVM: Fix register ID of SPSR_FIQ
Subsystems (3)
PATCH v2 1/1 docs: KVM: Fix register ID of SPSR_FIQ
Fixes the register ID of SPSR_FIQ.
SPSR_FIQ is a 64-bit register and the 64-bit register size mask is 0x0030000000000000ULL.
---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/
--- Documentation/virt/kvm/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Documentation/virt/kvm/api.rst +1 -1
@@ -2535,7 +2535,7 @@ Specifically: 0x6030 0000 0010 004a SPSR_ABT 64 spsr[KVM_SPSR_ABT] 0x6030 0000 0010 004c SPSR_UND 64 spsr[KVM_SPSR_UND] 0x6030 0000 0010 004e SPSR_IRQ 64 spsr[KVM_SPSR_IRQ] - 0x6060 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] + 0x6030 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] 0x6040 0000 0010 0054 V0 128 fp_regs.vregs[0] [1]_ 0x6040 0000 0010 0058 V1 128 fp_regs.vregs[1] [1]_ ...
Signature · 1 line
2.38.0
Hi folks,
I also came across this inconsistency in the docs. What happened to the patch in question?
+Cc kvmarm people and the list ...
Quoted 7 lines · Takahiro Itazuri
Fixes the register ID of
SPSR_FIQ.
SPSR_FIQis a 64-bit register and the 64-bit register size mask is0x0030000000000000ULL.Fixes fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")Signed-off-by Takahiro Itazuri <[email protected]>
... since you're fixing the encoding of an *arm64* core register and the mentioned commit fd3bc912d3d1 was merged via the kvmarm tree. I guess this is the main reason why this patch has been blocked on the list for over a year, as pointed out recently by Alexander [*].
Quoted 16 lines
---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/--- Documentation/virt/kvm/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/virt/kvm/api.rst +0
-0
Documentation/virt/kvm/api.rst Specifically: · line 2540
Quoted 8 lines
Documentation/virt/kvm/api.rst +1
-1@@ -2535,7 +2535,7 @@ Specifically: 0x6030 0000 0010 004a SPSR_ABT 64 spsr[KVM_SPSR_ABT] 0x6030 0000 0010 004c SPSR_UND 64 spsr[KVM_SPSR_UND] 0x6030 0000 0010 004e SPSR_IRQ 64 spsr[KVM_SPSR_IRQ] - 0x6060 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] + 0x6030 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] 0x6040 0000 0010 0054 V0 128 fp_regs.vregs[0] [1]_ 0x6040 0000 0010 0058 V1 128 fp_regs.vregs[1] [1]_
The change itself looks reasonable.
Thanks,
Zenghui
Quoted 2 lines · Zenghui Yu
+Cc kvmarm people and the list ...
Thanks Zenghui.
Quoted 7 lines · Takahiro Itazuri
Quoted 5 lines
Fixes the register ID of
SPSR_FIQ.
SPSR_FIQis a 64-bit register and the 64-bit register size mask is0x0030000000000000ULL.
Quoted 7 lines
Quoted 2 lines
Fixes fd3bc912d3d1 ("KVM: Documentation: Document arm64 core registers in detail")Signed-off-by Takahiro Itazuri <[email protected]>... since you're fixing the encoding of an *arm64* core register and the mentioned commit
fd3bc912d3d1was merged via the kvmarm tree. I guess this is the main reason why this patch has been blocked on the list for over a year, as pointed out recently by Alexander [*].
That, and the fact that this is send to an email address I haven't been reachable on for about 5 years...
Quoted 28 lines
Quoted 17 lines
---
Changes from v1
- Add a description about the 64-bit register size mask in the commit message.
- Link: https://lore.kernel.org/all/[email protected]/--- Documentation/virt/kvm/api.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Documentation/virt/kvm/api.rst +0
-0Documentation/virt/kvm/api.rst Specifically: · line 2540
Quoted 8 lines
Documentation/virt/kvm/api.rst +1
-1@@ -2535,7 +2535,7 @@ Specifically: 0x6030 0000 0010 004a SPSR_ABT 64 spsr[KVM_SPSR_ABT] 0x6030 0000 0010 004c SPSR_UND 64 spsr[KVM_SPSR_UND] 0x6030 0000 0010 004e SPSR_IRQ 64 spsr[KVM_SPSR_IRQ] - 0x6060 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] + 0x6030 0000 0010 0050 SPSR_FIQ 64 spsr[KVM_SPSR_FIQ] 0x6040 0000 0010 0054 V0 128 fp_regs.vregs[0] [1]_ 0x6040 0000 0010 0058 V1 128 fp_regs.vregs[1] [1]_The change itself looks reasonable.
Quoted 4 lines
Thanks,
Zenghui
In case Oliver picks this up for 6.11:
M.
Signature · 1 line
Without deviation from the norm, progress is not possible.
Oliver Upton
AppliedQuoted 6 lines · Takahiro Itazuri
Fixes the register ID of
SPSR_FIQ.
SPSR_FIQis a 64-bit register and the 64-bit register size mask is0x0030000000000000ULL.
Applied to kvmarm/fixes, thanks!
[1/1] docs: KVM: Fix register ID of SPSR_FIQ
https://git.kernel.org/kvmarm/kvmarm/c/7fef1eb0b013
--
Best,
Oliver