Add ACPI CPER firmware first error injection on ARM emulation
v7 cover Add ACPI CPER firmware first error injection on ARM emulation
Testing OS kernel ACPI APEI CPER support is tricky, as one depends on having hardware with special-purpose BIOS and/or hardware.
With QEMU, it becomes a lot easier, as it can be done via QMP.
This series add support for injecting CPER records on ARM emulation.
The QEMU side changes add a QAPI able to do CPER error injection on ARM, with a raw data parameter, making it very flexible.
A script is provided at the final patch implementing support for ARM Processor CPER error injection according with ACPI 6.x and UEFI 2.9A/2.10 specs, via QMP.
Injecting such errors can be done using the provided script:
$ ./scripts/ghes_inject.py arm Error injected.
Produces a simple CPER register, properly handled by the Linux Kernel:
[ 794.983753] {4}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
[ 794.984150] {4}[Hardware Error]: event severity: recoverable
[ 794.984391] {4}[Hardware Error]: Error 0, type: recoverable
[ 794.984652] {4}[Hardware Error]: section_type: ARM processor error
[ 794.984926] {4}[Hardware Error]: MIDR: 0x0000000000000000
[ 794.985184] {4}[Hardware Error]: running state: 0x0
[ 794.985411] {4}[Hardware Error]: Power State Coordination Interface state: 0
[ 794.985720] {4}[Hardware Error]: Error info structure 0:
[ 794.985960] {4}[Hardware Error]: num errors: 2
[ 794.986175] {4}[Hardware Error]: error_type: 0x02: cache error
[ 794.986442] {4}[Hardware Error]: error_info: 0x000000000091000f
[ 794.986755] {4}[Hardware Error]: transaction type: Data Access
[ 794.987027] {4}[Hardware Error]: cache error, operation type: Data write
[ 794.987310] {4}[Hardware Error]: cache level: 2
[ 794.987529] {4}[Hardware Error]: processor context not corrupted
[ 794.987867] [Firmware Warn]: GHES: Unhandled processor error type 0x02: cache errorMore complex use cases can be done, like:
$ ./scripts/ghes_inject.py arm --mpidr 0x444 --running --affinity 1 \ --error-info 12345678 --vendor 0x13,123,4,5,1 --ctx-array 0,1,2,3,4,5 \ -t cache tlb bus micro-arch tlb,micro-arch Error injected.
[ 899.181246] {5}[Hardware Error]: Hardware error from APEI Generic Hardware Error Source: 1
[ 899.181769] {5}[Hardware Error]: event severity: recoverable
[ 899.182069] {5}[Hardware Error]: Error 0, type: recoverable
[ 899.182370] {5}[Hardware Error]: section_type: ARM processor error
[ 899.182689] {5}[Hardware Error]: MIDR: 0x0000000000000000
[ 899.182980] {5}[Hardware Error]: Multiprocessor Affinity Register (MPIDR): 0x0000000000000000
[ 899.183395] {5}[Hardware Error]: error affinity level: 0
[ 899.183683] {5}[Hardware Error]: running state: 0x1
[ 899.183962] {5}[Hardware Error]: Power State Coordination Interface state: 0
[ 899.184332] {5}[Hardware Error]: Error info structure 0:
[ 899.184610] {5}[Hardware Error]: num errors: 2
[ 899.184864] {5}[Hardware Error]: error_type: 0x02: cache error
[ 899.185181] {5}[Hardware Error]: error_info: 0x0000000000bc614e
[ 899.185504] {5}[Hardware Error]: cache level: 2
[ 899.185771] {5}[Hardware Error]: processor context not corrupted
[ 899.186082] {5}[Hardware Error]: Error info structure 1:
[ 899.186366] {5}[Hardware Error]: num errors: 2
[ 899.186613] {5}[Hardware Error]: error_type: 0x04: TLB error
[ 899.186929] {5}[Hardware Error]: error_info: 0x000000000054007f
[ 899.187236] {5}[Hardware Error]: transaction type: Instruction
[ 899.187588] {5}[Hardware Error]: TLB error, operation type: Instruction fetch
[ 899.187962] {5}[Hardware Error]: TLB level: 1
[ 899.188209] {5}[Hardware Error]: processor context not corrupted
[ 899.188535] {5}[Hardware Error]: the error has not been corrected
[ 899.188853] {5}[Hardware Error]: PC is imprecise
[ 899.189114] {5}[Hardware Error]: Error info structure 2:
[ 899.189404] {5}[Hardware Error]: num errors: 2
[ 899.189653] {5}[Hardware Error]: error_type: 0x08: bus error
[ 899.189967] {5}[Hardware Error]: error_info: 0x00000080d6460fff
[ 899.190293] {5}[Hardware Error]: transaction type: Generic
[ 899.190611] {5}[Hardware Error]: bus error, operation type: Generic read (type of instruction or data request cannot be determined)
[ 899.191174] {5}[Hardware Error]: affinity level at which the bus error occurred: 1
[ 899.191563] {5}[Hardware Error]: processor context corrupted
[ 899.191872] {5}[Hardware Error]: the error has been corrected
[ 899.192185] {5}[Hardware Error]: PC is imprecise
[ 899.192445] {5}[Hardware Error]: Program execution can be restarted reliably at the PC associated with the error.
[ 899.192939] {5}[Hardware Error]: participation type: Local processor observed
[ 899.193324] {5}[Hardware Error]: request timed out
[ 899.193596] {5}[Hardware Error]: address space: External Memory Access
[ 899.193945] {5}[Hardware Error]: memory access attributes:0x20
[ 899.194273] {5}[Hardware Error]: access mode: secure
[ 899.194544] {5}[Hardware Error]: Error info structure 3:
[ 899.194838] {5}[Hardware Error]: num errors: 2
[ 899.195088] {5}[Hardware Error]: error_type: 0x10: micro-architectural error
[ 899.195456] {5}[Hardware Error]: error_info: 0x0000000078da03ff
[ 899.195782] {5}[Hardware Error]: Error info structure 4:
[ 899.196070] {5}[Hardware Error]: num errors: 2
[ 899.196331] {5}[Hardware Error]: error_type: 0x14: TLB error|micro-architectural error
[ 899.196733] {5}[Hardware Error]: Context info structure 0:
[ 899.197024] {5}[Hardware Error]: register context type: AArch64 EL1 context registers
[ 899.197427] {5}[Hardware Error]: 00000000: 00000000 00000000
[ 899.197741] {5}[Hardware Error]: Vendor specific error info has 5 bytes:
[ 899.198096] {5}[Hardware Error]: 00000000: 13 7b 04 05 01 .{...
[ 899.198610] [Firmware Warn]: GHES: Unhandled processor error type 0x02: cache error
[ 899.199000] [Firmware Warn]: GHES: Unhandled processor error type 0x04: TLB error
[ 899.199388] [Firmware Warn]: GHES: Unhandled processor error type 0x08: bus error
[ 899.199767] [Firmware Warn]: GHES: Unhandled processor error type 0x10: micro-architectural error
[ 899.200194] [Firmware Warn]: GHES: Unhandled processor error type 0x14: TLB error|micro-architectural error---
v7:
- Change the way offsets are calculated and used on HEST table. Now, it is compatible with migrations as all offsets are relative to the HEST table;
- GHES interface is now more generic: the entire CPER is sent via QMP, instead of just the payload;
- Some code cleanups to make the code more robust;
- The python script now uses QEMUMonitorProtocol class.
v6:
- PNP0C33 device creation moved to aml-build.c;
- acpi_ghes record functions now use ACPI notify parameter, instead of source ID;
- the number of source IDs is now automatically calculated;
- some code cleanups and function/var renames;
- some fixes and cleanups at the error injection script;
- ghes cper stub now produces an error if cper JSON is not compiled;
- Offset calculation logic for GHES was refactored;
- Updated documentation to reflect the GHES allocated size;
- Added a x-mpidr object for QOM usage;
- Added a patch making usage of x-mpidr field at ARM injection script;
v5:
- CPER guid is now passing as string;
- raw-data is now passed with base64 encode;
- Removed several GPIO left-overs from arm/virt.c changes;
- Lots of cleanups and improvements at the error injection script. It now better handles QMP dialog and doesn't print debug messages. Also, code was split on two modules, to make easier to add more error injection commands.
v4:
- CPER generation moved to happen outside QEMU;
- One patch adding support for mpidr query was removed.
v3:
- patch 1 cleanups with some comment changes and adding another place where the poweroff GPIO define should be used. No changes on other patches (except due to conflict resolution).
v2:
- added a new patch using a define for GPIO power pin;
- patch 2 changed to also use a define for generic error GPIO pin;
- a couple cleanups at patch 2 removing uneeded else clauses.
Jonathan Cameron (1):
acpi/ghes: Add support for GED error device
Mauro Carvalho Chehab (9):
acpi/generic_event_device: add an APEI error device arm/virt: Wire up a GED error device for ACPI / GHES qapi/acpi-hest: add an interface to do generic CPER error injection acpi/ghes: rework the logic to handle HEST source ID acpi/ghes: add support for generic error injection via QAPI
docs: acpi_hest_ghes: fix documentation for CPER size scripts/ghes_inject: add a script to generate GHES error inject target/arm: add an experimental mpidr arm cpu property object scripts/arm_processor_error.py: retrieve mpidr if not filled
MAINTAINERS | 10 + docs/specs/acpi_hest_ghes.rst | 6 +- hw/acpi/Kconfig | 5 + hw/acpi/aml-build.c | 10 + hw/acpi/generic_event_device.c | 8 + hw/acpi/ghes-stub.c | 3 +- hw/acpi/ghes.c | 250 +++++++++---- hw/acpi/ghes_cper.c | 33 ++ hw/acpi/ghes_cper_stub.c | 19 + hw/acpi/meson.build | 2 + hw/arm/Kconfig | 5 + hw/arm/virt-acpi-build.c | 6 +- hw/arm/virt.c | 12 +- include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 + include/hw/acpi/generic_event_device.h | 1 + include/hw/acpi/ghes.h | 23 +- include/hw/arm/virt.h | 1 + qapi/acpi-hest.json | 36 ++ qapi/meson.build | 1 + qapi/qapi-schema.json | 1 + scripts/arm_processor_error.py | 382 +++++++++++++++++++ scripts/ghes_inject.py | 51 +++ scripts/qmp_helper.py | 486 +++++++++++++++++++++++++ target/arm/cpu.c | 1 + target/arm/cpu.h | 1 + target/arm/helper.c | 10 +- 27 files changed, 1276 insertions(+), 90 deletions(-) create mode 100644 hw/acpi/ghes_cper.c create mode 100644 hw/acpi/ghes_cper_stub.c create mode 100644 qapi/acpi-hest.json create mode 100644 scripts/arm_processor_error.py create mode 100755 scripts/ghes_inject.py create mode 100644 scripts/qmp_helper.py
Signature · 1 line
2.46.0
PATCH v7 1/10 acpi/generic_event_device: add an APEI error device
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.
The PNP0C33 device is used to report hardware errors to the guest via ACPI APEI Generic Hardware Error Source (GHES).
--- hw/acpi/aml-build.c | 10 ++++++++++ hw/acpi/generic_event_device.c | 8 ++++++++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 ++ include/hw/acpi/generic_event_device.h | 1 + 5 files changed, 22 insertions(+)
hw/acpi/aml-build.c +10 -0
@@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source)return var; } + +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */ +Aml *aml_error_device (void ) +{ +Aml *dev =aml_device (ACPI_APEI_ERROR_DEVICE ); +aml_append (dev,aml_name_decl ("_HID" ,aml_string ("PNP0C33" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_int (0 ))); + +return dev; +}
hw/acpi/generic_event_device.c +8 -0
@@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = {ACPI_GED_PWR_DOWN_EVT ,ACPI_GED_NVDIMM_HOTPLUG_EVT ,ACPI_GED_CPU_HOTPLUG_EVT , + ACPI_GED_ERROR_EVT };/*
@@ -116,6 +117,11 @@ void build_ged_aml(Aml *table, const char *name, HotplugHandler *hotplug_dev,aml_notify (aml_name (ACPI_POWER_BUTTON_DEVICE ), aml_int(0x80)));break ; +case ACPI_GED_ERROR_EVT : +aml_append (if_ctx, +aml_notify (aml_name (ACPI_APEI_ERROR_DEVICE ), +aml_int (0x80 ))); +break ;case ACPI_GED_NVDIMM_HOTPLUG_EVT : aml_append(if_ctx, aml_notify(aml_name("\\_SB.NVDR"),
@@ -295,6 +301,8 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev) sel =ACPI_GED_MEM_HOTPLUG_EVT ; }else if (ev &ACPI_POWER_DOWN_STATUS ) { sel =ACPI_GED_PWR_DOWN_EVT ; + }else if (ev &ACPI_GENERIC_ERROR ) { + sel =ACPI_GED_ERROR_EVT ; }else if (ev &ACPI_NVDIMM_HOTPLUG_STATUS ) { sel =ACPI_GED_NVDIMM_HOTPLUG_EVT ; }else if (ev &ACPI_CPU_HOTPLUG_STATUS ) {
include/hw/acpi/acpi_dev_interface.h +1 -0
@@ -13,6 +13,7 @@ typedef enum {ACPI_NVDIMM_HOTPLUG_STATUS =16 ,ACPI_VMGENID_CHANGE_STATUS =32 ,ACPI_POWER_DOWN_STATUS =64 , +ACPI_GENERIC_ERROR =128 , } AcpiEventStatusBits;#define TYPE_ACPI_DEVICE_IF "acpi-device-interface"
include/hw/acpi/aml-build.h +2 -0
@@ -252,6 +252,7 @@ struct CrsRangeSet {/* Consumer/Producer */ #define AML_SERIAL_BUS_FLAG_CONSUME_ONLY (1 << 1) +#define ACPI_APEI_ERROR_DEVICE "GEDD"/** * init_aml_allocator: *
@@ -382,6 +383,7 @@ Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz, uint8_t channel);Aml *aml_sleep (uint64_t msec);Aml *aml_i2c_serial_bus_device (uint16_t address,const char *resource_source); +Aml *aml_error_device (void );/* Block AML object primitives */ Aml *aml_scope (const char *name_format, ...)G_GNUC_PRINTF (1 ,2 );
include/hw/acpi/generic_event_device.h +1 -0
@@ -98,6 +98,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(AcpiGedState, ACPI_GED)#define ACPI_GED_PWR_DOWN_EVT 0x2#define ACPI_GED_NVDIMM_HOTPLUG_EVT 0x4#define ACPI_GED_CPU_HOTPLUG_EVT 0x8 +#define ACPI_GED_ERROR_EVT 0x10 typedef struct GEDState { MemoryRegion evt;
Signature · 1 line
2.46.0
Re: [PATCH v7 01/10] acpi/generic_event_device: add an APEI error device
Quoted 26 lines · Mauro Carvalho Chehab
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.The PNP0C33 device is used to report hardware errors to the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by Mauro Carvalho Chehab <[email protected]>Co-authored-by Jonathan Cameron <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Reviewed-by Igor Mammedov <[email protected]>--- hw/acpi/aml-build.c | 10 ++++++++++ hw/acpi/generic_event_device.c | 8 ++++++++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 ++ include/hw/acpi/generic_event_device.h | 1 + 5 files changed, 22 insertions(+)hw/acpi/aml-build.c +0
-0
hw/acpi/aml-build.c Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source) · line 2524
Quoted 5 lines
hw/acpi/aml-build.c +2
-0@@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source)return var; } + +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */
I could not find Event Notification For Generic Error Sources in ACPI 5.0.
Instead, I see
18.3.2.6.2 SCI Notification For Generic Error Sources
What did I miss?
hw/acpi/aml-build.c Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source) · line 2530
Quoted 10 lines
hw/acpi/aml-build.c +6
-0+Aml *aml_error_device (void ) +{ +Aml *dev =aml_device (ACPI_APEI_ERROR_DEVICE ); +aml_append (dev,aml_name_decl ("_HID" ,aml_string ("PNP0C33" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_int (0 ))); +
comment on why is this here?
Quoted 81 lines
hw/acpi/aml-build.c +2
-0+return dev; +}hw/acpi/generic_event_device.c +8
-0@@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = {ACPI_GED_PWR_DOWN_EVT ,ACPI_GED_NVDIMM_HOTPLUG_EVT ,ACPI_GED_CPU_HOTPLUG_EVT , + ACPI_GED_ERROR_EVT };/* @@ -116,6 +117,11 @@ void build_ged_aml(Aml *table, const char *name, HotplugHandler *hotplug_dev,aml_notify (aml_name (ACPI_POWER_BUTTON_DEVICE ), aml_int(0x80)));break ; +case ACPI_GED_ERROR_EVT : +aml_append (if_ctx, +aml_notify (aml_name (ACPI_APEI_ERROR_DEVICE ), +aml_int (0x80 ))); +break ;case ACPI_GED_NVDIMM_HOTPLUG_EVT : aml_append(if_ctx, aml_notify(aml_name("\\_SB.NVDR"),@@ -295,6 +301,8 @@ static void acpi_ged_send_event(AcpiDeviceIf *adev, AcpiEventStatusBits ev) sel =ACPI_GED_MEM_HOTPLUG_EVT ; }else if (ev &ACPI_POWER_DOWN_STATUS ) { sel =ACPI_GED_PWR_DOWN_EVT ; + }else if (ev &ACPI_GENERIC_ERROR ) { + sel =ACPI_GED_ERROR_EVT ; }else if (ev &ACPI_NVDIMM_HOTPLUG_STATUS ) { sel =ACPI_GED_NVDIMM_HOTPLUG_EVT ; }else if (ev &ACPI_CPU_HOTPLUG_STATUS ) {include/hw/acpi/acpi_dev_interface.h +1
-0@@ -13,6 +13,7 @@ typedef enum {ACPI_NVDIMM_HOTPLUG_STATUS =16 ,ACPI_VMGENID_CHANGE_STATUS =32 ,ACPI_POWER_DOWN_STATUS =64 , +ACPI_GENERIC_ERROR =128 , } AcpiEventStatusBits;#define TYPE_ACPI_DEVICE_IF "acpi-device-interface"include/hw/acpi/aml-build.h +2
-0@@ -252,6 +252,7 @@ struct CrsRangeSet {/* Consumer/Producer */ #define AML_SERIAL_BUS_FLAG_CONSUME_ONLY (1 << 1) +#define ACPI_APEI_ERROR_DEVICE "GEDD"/** * init_aml_allocator: * @@ -382,6 +383,7 @@ Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz, uint8_t channel);Aml *aml_sleep (uint64_t msec);Aml *aml_i2c_serial_bus_device (uint16_t address,const char *resource_source); +Aml *aml_error_device (void );/* Block AML object primitives */ Aml *aml_scope (const char *name_format, ...)G_GNUC_PRINTF (1 ,2 );include/hw/acpi/generic_event_device.h +1
-0@@ -98,6 +98,7 @@ OBJECT_DECLARE_SIMPLE_TYPE(AcpiGedState, ACPI_GED)#define ACPI_GED_PWR_DOWN_EVT 0x2#define ACPI_GED_NVDIMM_HOTPLUG_EVT 0x4#define ACPI_GED_CPU_HOTPLUG_EVT 0x8 +#define ACPI_GED_ERROR_EVT 0x10 typedef struct GEDState { MemoryRegion evt;Signature · 1 line
2.46.0
Re: [PATCH v7 01/10] acpi/generic_event_device: add an APEI error device
In reply to Mauro Carvalho ChehabQuoted 26 lines · On Wed, 14 Aug 2024 01:23:23 +0200 Mauro Carvalho Chehab…
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.The PNP0C33 device is used to report hardware errors to the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by Mauro Carvalho Chehab <[email protected]>Co-authored-by Jonathan Cameron <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Reviewed-by Igor Mammedov <[email protected]>--- hw/acpi/aml-build.c | 10 ++++++++++ hw/acpi/generic_event_device.c | 8 ++++++++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 ++ include/hw/acpi/generic_event_device.h | 1 + 5 files changed, 22 insertions(+)hw/acpi/aml-build.c +0
-0
hw/acpi/aml-build.c Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source) · line 2524
Quoted 5 lines
hw/acpi/aml-build.c +2
-0@@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source)return var; } + +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */
Given this section got a rename maybe the comment should mention old name and current name for the section?
Quoted 13 lines
hw/acpi/aml-build.c +8
-0+Aml *aml_error_device (void ) +{ +Aml *dev =aml_device (ACPI_APEI_ERROR_DEVICE ); +aml_append (dev,aml_name_decl ("_HID" ,aml_string ("PNP0C33" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_int (0 ))); + +return dev; +}hw/acpi/generic_event_device.c +0
-0
hw/acpi/generic_event_device.c static const uint32_t ged_supported_events[] = { · line 29
Quoted 4 lines
hw/acpi/generic_event_device.c +1
-0@@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = {ACPI_GED_PWR_DOWN_EVT ,ACPI_GED_NVDIMM_HOTPLUG_EVT ,ACPI_GED_CPU_HOTPLUG_EVT , +ACPI_GED_ERROR_EVT
trailing comma missing.
Re: [PATCH v7 01/10] acpi/generic_event_device: add an APEI error device
Em Wed, 14 Aug 2024 13:33:21 +0100
Jonathan Cameron <[email protected]> escreveu:
Quoted 30 lines
Quoted 27 lines · On Wed, 14 Aug 2024 01:23:23 +0200 Mauro Carvalho Chehab…
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.The PNP0C33 device is used to report hardware errors to the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by Mauro Carvalho Chehab <[email protected]>Co-authored-by Jonathan Cameron <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Reviewed-by Igor Mammedov <[email protected]>--- hw/acpi/aml-build.c | 10 ++++++++++ hw/acpi/generic_event_device.c | 8 ++++++++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 ++ include/hw/acpi/generic_event_device.h | 1 + 5 files changed, 22 insertions(+)hw/acpi/aml-build.c +0
-0@@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source)
Quoted 7 lines
hw/acpi/aml-build.c Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source) · line 2524
Quoted 4 lines
hw/acpi/aml-build.c +2
-0return var; } + +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */ Given this section got a rename maybe the comment should mention old name and current name for the section?
ACPI 6.5 has the same name for the section:
18.3.2.7.2. Event Notification For Generic Error Sources
An event notification is recommended for corrected errors where latency in processing error reports is not critical to proper system operation. The implementation of Event notification requires the platform to define a device with PNP ID PNP0C33 in the ACPI namespace, referred to as the error device.
Just section number changed. IMO, it is still good enough to seek for it at the docs.
Btw, in this specific case, the best is to use the search box of Sphinx html output and seek for PNP0C33 ;-)
Quoted 12 lines
Quoted 12 lines
hw/acpi/aml-build.c +8
-0+Aml *aml_error_device (void ) +{ +Aml *dev =aml_device (ACPI_APEI_ERROR_DEVICE ); +aml_append (dev,aml_name_decl ("_HID" ,aml_string ("PNP0C33" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_int (0 ))); + +return dev; +}hw/acpi/generic_event_device.c +0
-1--- a/hw/acpi/generic_event_device.c
Quoted 8 lines
hw/acpi/generic_event_device.c static const uint32_t ged_supported_events[] = { · line 29
Quoted 6 lines
+++
b/hw/acpi/generic_event_device.chw/acpi/generic_event_device.c +1
-0@@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = {ACPI_GED_PWR_DOWN_EVT ,ACPI_GED_NVDIMM_HOTPLUG_EVT ,ACPI_GED_CPU_HOTPLUG_EVT , +ACPI_GED_ERROR_EVT trailing comma missing.
I'll add.
Thanks,
Mauro
Re: [PATCH v7 01/10] acpi/generic_event_device: add an APEI error device
Quoted 41 lines · On Fri, 16 Aug 2024 07:53:24 +0200 Mauro Carvalho Chehab…
Em Wed, 14 Aug 2024 13:33:21 +0100
Jonathan Cameron <[email protected]> escreveu:Quoted 30 lines
Quoted 27 lines · On Wed, 14 Aug 2024 01:23:23 +0200 Mauro Carvalho Chehab…
Adds a generic error device to handle generic hardware error events as specified at ACPI 6.5 specification at 18.3.2.7.2:
https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#event-notification-for-generic-error-sources
using HID PNP0C33.The PNP0C33 device is used to report hardware errors to the guest via ACPI APEI Generic Hardware Error Source (GHES).
Co-authored-by Mauro Carvalho Chehab <[email protected]>Co-authored-by Jonathan Cameron <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Reviewed-by Igor Mammedov <[email protected]>--- hw/acpi/aml-build.c | 10 ++++++++++ hw/acpi/generic_event_device.c | 8 ++++++++ include/hw/acpi/acpi_dev_interface.h | 1 + include/hw/acpi/aml-build.h | 2 ++ include/hw/acpi/generic_event_device.h | 1 + 5 files changed, 22 insertions(+)hw/acpi/aml-build.c +0
-0@@ -2520,3 +2520,13 @@ Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source)Quoted 7 lines
hw/acpi/aml-build.c Aml *aml_i2c_serial_bus_device(uint16_t address, const char *resource_source) · line 2524
Quoted 4 lines
hw/acpi/aml-build.c +2
-0return var; } + +/* ACPI 5.0: 18.3.2.6.2 Event Notification For Generic Error Sources */ Given this section got a rename maybe the comment should mention old name and current name for the section?
Quoted 1 line
ACPI 6.5 has the same name for the section:
We did a bit of digging after an offline discussion.
It's only there in Errata B of ACPI 5.0. So need to update this reference to be more specific if we want to avoid confusion.
Quoted 40 lines
18.3.2.7.2. Event Notification For Generic Error Sources
An event notification is recommended for corrected errors where latency in processing error reports is not critical to proper system operation. The implementation of Event notification requires the platform to define a device with PNP ID PNP0C33 in the ACPI namespace, referred to as the error device.
Just section number changed. IMO, it is still good enough to seek for it at the docs.
Btw, in this specific case, the best is to use the search box of Sphinx html output and seek for PNP0C33 ;-)
Quoted 12 lines
Quoted 12 lines
hw/acpi/aml-build.c +8
-0+Aml *aml_error_device (void ) +{ +Aml *dev =aml_device (ACPI_APEI_ERROR_DEVICE ); +aml_append (dev,aml_name_decl ("_HID" ,aml_string ("PNP0C33" ))); +aml_append (dev,aml_name_decl ("_UID" ,aml_int (0 ))); + +return dev; +}hw/acpi/generic_event_device.c +0
-1--- a/hw/acpi/generic_event_device.cQuoted 8 lines
hw/acpi/generic_event_device.c static const uint32_t ged_supported_events[] = { · line 29
Quoted 6 lines
+++
b/hw/acpi/generic_event_device.chw/acpi/generic_event_device.c +1
-0@@ -26,6 +26,7 @@ static const uint32_t ged_supported_events[] = {ACPI_GED_PWR_DOWN_EVT ,ACPI_GED_NVDIMM_HOTPLUG_EVT ,ACPI_GED_CPU_HOTPLUG_EVT , +ACPI_GED_ERROR_EVT trailing comma missing.
I'll add.
Thanks,
Mauro
PATCH v7 2/10 arm/virt: Wire up a GED error device for ACPI / GHES
In reply to Mauro Carvalho ChehabAdds support to ARM virtualization to allow handling generic error ACPI Event via GED & error source device.
It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/[email protected]/
--- hw/acpi/ghes.c | 3 +++ hw/arm/virt-acpi-build.c | 1 + hw/arm/virt.c | 12 +++++++++++- include/hw/acpi/ghes.h | 3 +++ include/hw/arm/virt.h | 1 + 5 files changed, 19 insertions(+), 1 deletion(-)
hw/acpi/ghes.c +3 -0
@@ -444,6 +444,9 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address)return ret; } +NotifierList acpi_generic_error_notifiers = +NOTIFIER_LIST_INITIALIZER (error_device_notifiers); +bool acpi_ghes_present (void ) {AcpiGedState *acpi_ged_state;
hw/arm/virt-acpi-build.c +1 -0
@@ -858,6 +858,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker, VirtMachineState *vms) }acpi_dsdt_add_power_button (scope); +aml_append (scope,aml_error_device ());#ifdef CONFIG_TPM acpi_dsdt_add_tpm (scope, vms);#endif
hw/arm/virt.c +11 -1
@@ -677,7 +677,7 @@ static inline DeviceState *create_acpi_ged(VirtMachineState *vms)DeviceState *dev;MachineState *ms =MACHINE (vms);int irq = vms->irqmap[VIRT_ACPI_GED ]; -uint32_t event =ACPI_GED_PWR_DOWN_EVT ; +uint32_t event =ACPI_GED_PWR_DOWN_EVT |ACPI_GED_ERROR_EVT ;if (ms->ram_slots) { event |=ACPI_GED_MEM_HOTPLUG_EVT ;
@@ -1009,6 +1009,13 @@ static void virt_powerdown_req(Notifier *n, void *opaque) } } +static void virt_generic_error_req (Notifier *n,void *opaque) +{ +VirtMachineState *s =container_of (n, VirtMachineState, generic_error_notifier); + +acpi_send_event (s->acpi_dev,ACPI_GENERIC_ERROR ); +} +static void create_gpio_keys (char *fdt,DeviceState *pl061_dev,uint32_t phandle) {
@@ -2385,6 +2392,9 @@ static void machvirt_init(MachineState *machine)if (has_ged && aarch64 && firmware_loaded &&virt_is_acpi_enabled (vms)) { vms->acpi_dev =create_acpi_ged (vms); + vms->generic_error_notifier.notify = virt_generic_error_req; +notifier_list_add (&acpi_generic_error_notifiers, + &vms->generic_error_notifier); }else {create_gpio_devices (vms,VIRT_GPIO , sysmem); }
include/hw/acpi/ghes.h +3 -0
@@ -23,6 +23,9 @@#define ACPI_GHES_H #include "hw/acpi/bios-linker-loader.h" +#include "qemu/notify.h" + +extern NotifierList acpi_generic_error_notifiers;/* * Values for Hardware Error Notification Type field
include/hw/arm/virt.h +1 -0
@@ -175,6 +175,7 @@ struct VirtMachineState {DeviceState *gic;DeviceState *acpi_dev;Notifier powerdown_notifier; +Notifier generic_error_notifier;PCIBus *bus;char *oem_id;char *oem_table_id;
Signature · 1 line
2.46.0
Re: [PATCH v7 02/10] arm/virt: Wire up a GED error device for ACPI / GHES
Quoted 11 lines · On Wed, 14 Aug 2024 01:23:24 +0200 Mauro Carvalho Chehab…
Adds support to ARM virtualization to allow handling generic error ACPI Event via GED & error source device.
It is aligned with Linux Kernel patch:
https://lore.kernel.org/lkml/[email protected]/Co-authored-by Mauro Carvalho Chehab <[email protected]>Co-authored-by Jonathan Cameron <[email protected]>Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Acked-by Igor Mammedov <[email protected]>
Not sure I said, but this is much neater than what I had so I like this a lot.
Jonathan
PATCH v7 3/10 acpi/ghes: Add support for GED error device
In reply to Mauro Carvalho ChehabFrom: Jonathan Cameron <[email protected]>
As a GED error device is now defined, add another type of notification.
Add error notification to GHES v2 using a GED error device GED triggered via interrupt.
[mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks and
rename HEST event to better identify GED interrupt OSPM]
--- hw/acpi/ghes.c | 12 +++++++++--- include/hw/acpi/ghes.h | 3 ++- 2 files changed, 11 insertions(+), 4 deletions(-)
hw/acpi/ghes.c +9 -3
@@ -34,8 +34,8 @@/* The max size in bytes for one error block */ #define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB) -/* Now only support ARMv8 SEA notification type error source */ -#define ACPI_GHES_ERROR_SOURCE_COUNT 1 +/* Support ARMv8 SEA notification type error source and GPIO interrupt. */ +#define ACPI_GHES_ERROR_SOURCE_COUNT 2/* Generic Hardware Error Source version 2 */ #define ACPI_GHES_SOURCE_GENERIC_ERROR_V2 10
@@ -290,6 +290,9 @@ void build_ghes_error_table(GArray *hardware_errors, BIOSLinker *linker)static void build_ghes_v2 (GArray *table_data,int source_id,BIOSLinker *linker) {uint64_t address_offset; + +assert (source_id <ACPI_HEST_SRC_ID_RESERVED ); +/* * Type: * Generic Hardware Error Source version 2(GHESv2 - Type 10)
@@ -327,6 +330,9 @@ static void build_ghes_v2(GArray *table_data, int source_id, BIOSLinker *linker)*/ build_ghes_hw_error_notification (table_data,ACPI_GHES_NOTIFY_SEA );break ; +case ACPI_HEST_SRC_ID_GED : +build_ghes_hw_error_notification (table_data,ACPI_GHES_NOTIFY_GPIO ); +break ;default :error_report ("Not support this error source" );abort ();
@@ -370,6 +376,7 @@ void acpi_build_hest(GArray *table_data, BIOSLinker *linker,/* Error Source Count */ build_append_int_noprefix (table_data,ACPI_GHES_ERROR_SOURCE_COUNT ,4 );build_ghes_v2 (table_data,ACPI_HEST_SRC_ID_SEA , linker); +build_ghes_v2 (table_data,ACPI_HEST_SRC_ID_GED , linker);acpi_table_end (linker, &table); }
@@ -406,7 +413,6 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) start_addr =le64_to_cpu (ags->ghes_addr_le);if (physical_address) { -if (source_id <ACPI_HEST_SRC_ID_RESERVED ) { start_addr += source_id *sizeof (uint64_t ); }
include/hw/acpi/ghes.h +2 -1
@@ -59,9 +59,10 @@ enum AcpiGhesNotifyType { ACPI_GHES_NOTIFY_RESERVED = 12 }; +/* Those are used as table indexes when building GHES tables */ enum {ACPI_HEST_SRC_ID_SEA =0 , -/* future ids go here */ +ACPI_HEST_SRC_ID_GED ,ACPI_HEST_SRC_ID_RESERVED , };
Signature · 1 line
2.46.0
Re: [PATCH v7 03/10] acpi/ghes: Add support for GED error device
Quoted 8 lines · On Wed, 14 Aug 2024 01:23:25 +0200 Mauro Carvalho Chehab…
From: Jonathan Cameron <[email protected]>
As a GED error device is now defined, add another type of notification.
Add error notification to GHES v2 using a GED error device GED triggered via interrupt.
Quoted 6 lines
[mchehab: do some cleanups at ACPI_HEST_SRC_ID_* checks and
rename HEST event to better identify GED interrupt OSPM]Signed-off-by Jonathan Cameron <[email protected]>Signed-off-by Mauro Carvalho Chehab <[email protected]>Reviewed-by Igor Mammedov <[email protected]>
One trivial thing inline (probably my mistake ;)
Jonathan
Quoted 49 lines
--- hw/acpi/ghes.c | 12 +++++++++--- include/hw/acpi/ghes.h | 3 ++- 2 files changed, 11 insertions(+), 4 deletions(-)hw/acpi/ghes.c +9
-2@@ -34,8 +34,8 @@/* The max size in bytes for one error block */ #define ACPI_GHES_MAX_RAW_DATA_LENGTH (1 * KiB) -/* Now only support ARMv8 SEA notification type error source */ -#define ACPI_GHES_ERROR_SOURCE_COUNT 1 +/* Support ARMv8 SEA notification type error source and GPIO interrupt. */ +#define ACPI_GHES_ERROR_SOURCE_COUNT 2/* Generic Hardware Error Source version 2 */ #define ACPI_GHES_SOURCE_GENERIC_ERROR_V2 10@@ -290,6 +290,9 @@ void build_ghes_error_table(GArray *hardware_errors, BIOSLinker *linker)static void build_ghes_v2 (GArray *table_data,int source_id,BIOSLinker *linker) {uint64_t address_offset; + +assert (source_id <ACPI_HEST_SRC_ID_RESERVED ); +/* * Type: * Generic Hardware Error Source version 2(GHESv2 - Type 10) @@ -327,6 +330,9 @@ static void build_ghes_v2(GArray *table_data, int source_id, BIOSLinker *linker)*/ build_ghes_hw_error_notification (table_data,ACPI_GHES_NOTIFY_SEA );break ; +case ACPI_HEST_SRC_ID_GED : +build_ghes_hw_error_notification (table_data,ACPI_GHES_NOTIFY_GPIO ); +break ;default :error_report ("Not support this error source" );abort ();@@ -370,6 +376,7 @@ void acpi_build_hest(GArray *table_data, BIOSLinker *linker,/* Error Source Count */ build_append_int_noprefix (table_data,ACPI_GHES_ERROR_SOURCE_COUNT ,4 );build_ghes_v2 (table_data,ACPI_HEST_SRC_ID_SEA , linker); +build_ghes_v2 (table_data,ACPI_HEST_SRC_ID_GED , linker);acpi_table_end (linker, &table); }
hw/acpi/ghes.c int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) · line 409
Quoted 4 lines
hw/acpi/ghes.c +0
-1@@ -406,7 +413,6 @@ int acpi_ghes_record_errors(uint8_t source_id, uint64_t physical_address) start_addr =le64_to_cpu (ags->ghes_addr_le);if (physical_address) { -
Clean this accidental change out.
Quoted 19 lines
hw/acpi/ghes.c +0
-0if (source_id <ACPI_HEST_SRC_ID_RESERVED ) { start_addr += source_id *sizeof (uint64_t ); }include/hw/acpi/ghes.h +2
-1@@ -59,9 +59,10 @@ enum AcpiGhesNotifyType { ACPI_GHES_NOTIFY_RESERVED = 12 }; +/* Those are used as table indexes when building GHES tables */ enum {ACPI_HEST_SRC_ID_SEA =0 , -/* future ids go here */ +ACPI_HEST_SRC_ID_GED ,ACPI_HEST_SRC_ID_RESERVED , };
PATCH v7 4/10 qapi/acpi-hest: add an interface to do generic CPER error injection
In reply to Mauro Carvalho ChehabCreates a QMP command to be used for generic ACPI APEI hardware error injection (HEST) via GHESv2.
The actual GHES code will be added at the followup patch.
--- MAINTAINERS | 7 +++++++ hw/acpi/Kconfig | 5 +++++ hw/acpi/ghes_cper.c | 33 +++++++++++++++++++++++++++++++++ hw/acpi/ghes_cper_stub.c | 19 +++++++++++++++++++ hw/acpi/meson.build | 2 ++ hw/arm/Kconfig | 5 +++++ include/hw/acpi/ghes.h | 1 + qapi/acpi-hest.json | 36 ++++++++++++++++++++++++++++++++++++ qapi/meson.build | 1 + qapi/qapi-schema.json | 1 + 10 files changed, 110 insertions(+) create mode 100644 hw/acpi/ghes_cper.c create mode 100644 hw/acpi/ghes_cper_stub.c create mode 100644 qapi/acpi-hest.json
MAINTAINERS +7 -0
@@ -2077,6 +2077,13 @@ F: hw/acpi/ghes.c F: include/hw/acpi/ghes.h F: docs/specs/acpi_hest_ghes.rst +ACPI/HEST/GHES/ARM processor CPER +R: Mauro Carvalho Chehab <[email protected]> +S: Maintained +F: hw/arm/ghes_cper.c +F: hw/acpi/ghes_cper_stub.c +F: qapi/acpi-hest.json + ppc4xx L: [email protected] S: Orphan
hw/acpi/Kconfig +5 -0
@@ -51,6 +51,11 @@ config ACPI_APEI bool depends on ACPI +config GHES_CPER + bool + depends on ACPI_APEI + default y + config ACPI_PCI bool depends on ACPI && PCI
hw/acpi/ghes_cper.c new file +33 -0
@@ -0,0 +1,33 @@ +/* +* CPER payload parser for error injection +* +* Copyright(C) 2024 Huawei LTD. +* +* This code is licensed under the GPL version 2 or later. See the +* COPYING file in the top-level directory. +* +*/ + +#include "qemu/osdep.h" + +#include "qemu/base64.h" +#include "qemu/error-report.h" +#include "qemu/uuid.h" +#include "qapi/qapi-commands-acpi-hest.h" +#include "hw/acpi/ghes.h" + +void qmp_ghes_cper (const char *qmp_cper, +Error **errp) +{ + +uint8_t *cper; +size_t len; + + cper =qbase64_decode (qmp_cper,-1 , &len, errp); +if (!cper) { +error_setg (errp,"missing GHES CPER payload" ); +return ; + } + +/* TODO: call a function at ghes */ +}
hw/acpi/ghes_cper_stub.c new file +19 -0
@@ -0,0 +1,19 @@ +/* +* Stub interface for CPER payload parser for error injection +* +* Copyright(C) 2024 Huawei LTD. +* +* This code is licensed under the GPL version 2 or later. See the +* COPYING file in the top-level directory. +* +*/ + +#include "qemu/osdep.h" +#include "qapi/error.h" +#include "qapi/qapi-commands-acpi-hest.h" +#include "hw/acpi/ghes.h" + +void qmp_ghes_cper (const char *cper,Error **errp) +{ +error_setg (errp,"GHES QMP error inject is not compiled in" ); +}
hw/acpi/meson.build +2 -0
@@ -34,4 +34,6 @@ endif system_ss.add(when: 'CONFIG_ACPI', if_false: files('acpi-stub.c', 'aml-build-stub.c', 'ghes-stub.c', 'acpi_interface.c')) system_ss.add(when: 'CONFIG_ACPI_PCI_BRIDGE', if_false: files('pci-bridge-stub.c')) system_ss.add_all(when: 'CONFIG_ACPI', if_true: acpi_ss) +system_ss.add(when: 'CONFIG_GHES_CPER', if_true: files('ghes_cper.c')) +system_ss.add(when: 'CONFIG_GHES_CPER', if_false: files('ghes_cper_stub.c')) system_ss.add(files('acpi-qmp-cmds.c'))
hw/arm/Kconfig +5 -0
@@ -712,3 +712,8 @@ config ARMSSE select UNIMP select SSE_COUNTER select SSE_TIMER + +config GHES_CPER + bool + depends on ARM + default y if AARCH64
include/hw/acpi/ghes.h +1 -0
@@ -23,6 +23,7 @@#define ACPI_GHES_H #include "hw/acpi/bios-linker-loader.h" +#include "qapi/error.h" #include "qemu/notify.h" extern NotifierList acpi_generic_error_notifiers;
qapi/acpi-hest.json new file +36 -0
@@ -0,0 +1,36 @@ +# -*- Mode: Python -*- +# vim: filetype=python + +## +# = GHESv2 CPER Error Injection +# +# Defined since ACPI Specification 6.2, +# section 18.3.2.8 Generic Hardware Error Source version 2. See: +# +# https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#generic-hardware-error-source-version-2-ghesv2-type-10 +## + + +## +# @ghes-cper: +# +# Inject a CPER error data to be filled according to ACPI 6.2 +# spec via GHESv2. +# +# @cper: contains a base64 encoded string with raw data for a single CPER +# record with Generic Error Status Block, Generic Error Data Entry and +# generic error data payload, as described at +# https://uefi.org/specs/UEFI/2.10/Apx_N_Common_Platform_Error_Record.html#format +# +# Features: +# +# @unstable: This command is experimental. +# +# Since: 9.2 +## +{ 'command': 'ghes-cper', + 'data': { + 'cper': 'str' + }, + 'features': [ 'unstable' ] +}
qapi/meson.build +1 -0
@@ -59,6 +59,7 @@ qapi_all_modules = [ if have_system qapi_all_modules += [ 'acpi', + 'acpi-hest', 'audio', 'cryptodev', 'qdev',
qapi/qapi-schema.json +1 -0
@@ -75,6 +75,7 @@ { 'include': 'misc-target.json' } { 'include': 'audio.json' } { 'include': 'acpi.json' } +{ 'include': 'acpi-hest.json' } { 'include': 'pci.json' } { 'include': 'stats.json' } { 'include': 'virtio.json' }
Signature · 1 line
2.46.0
Re: [PATCH v7 04/10] qapi/acpi-hest: add an interface to do generic CPER error injection
Quoted 8 lines · On Wed, 14 Aug 2024 01:23:26 +0200 Mauro Carvalho Chehab…
Creates a QMP command to be used for generic ACPI APEI hardware error injection (HEST) via GHESv2.
The actual GHES code will be added at the followup patch.
Signed-off-by Mauro Carvalho Chehab <[email protected]>Signed-off-by Shiju Jose <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>
A few trivial things from a quick glance at this
(to remind myself of how this fits together).
Quoted 22 lines
hw/acpi/Kconfig +5
-0@@ -51,6 +51,11 @@ config ACPI_APEI bool depends on ACPI +config GHES_CPER + bool + depends on ACPI_APEI + default y + config ACPI_PCI bool depends on ACPI && PCIhw/acpi/ghes_cper.c new file +0
-0
hw/acpi/ghes_cper.c line 20
Quoted 6 lines
hw/acpi/ghes_cper.c new file +5
-0@@ -0,0 +1,33 @@ +#include "qapi/qapi-commands-acpi-hest.h" +#include "hw/acpi/ghes.h" + +void qmp_ghes_cper (const char *qmp_cper, +Error **errp)
That's a very short line wrap.
Quoted 19 lines
hw/acpi/ghes_cper.c new file +13
-0+{ + +uint8_t *cper; +size_t len; + + cper =qbase64_decode (qmp_cper,-1 , &len, errp); +if (!cper) { +error_setg (errp,"missing GHES CPER payload" ); +return ; + } + +/* TODO: call a function at ghes */ +}include/hw/acpi/ghes.h +0
-0
include/hw/acpi/ghes.h line 26
Quoted 4 lines
include/hw/acpi/ghes.h +1
-0@@ -23,6 +23,7 @@#define ACPI_GHES_H #include "hw/acpi/bios-linker-loader.h" +#include "qapi/error.h"
Odd to have an include added with no other changes in file? Wrong patch maybe? Or should it be included by a c file instead?
Quoted 4 lines
include/hw/acpi/ghes.h +0
-0#include "qemu/notify.h" extern NotifierList acpi_generic_error_notifiers;qapi/acpi-hest.json +0
-0
Re: [PATCH v7 04/10] qapi/acpi-hest: add an interface to do generic CPER error injection
Em Wed, 14 Aug 2024 14:53:22 +0100
Jonathan Cameron <[email protected]> escreveu:
Quoted 38 lines
Quoted 8 lines · On Wed, 14 Aug 2024 01:23:26 +0200 Mauro Carvalho Chehab…
Creates a QMP command to be used for generic ACPI APEI hardware error injection (HEST) via GHESv2.
The actual GHES code will be added at the followup patch.
Signed-off-by Mauro Carvalho Chehab <[email protected]>Signed-off-by Shiju Jose <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>A few trivial things from a quick glance at this
(to remind myself of how this fits together).Quoted 22 lines
hw/acpi/Kconfig +5
-0@@ -51,6 +51,11 @@ config ACPI_APEI bool depends on ACPI +config GHES_CPER + bool + depends on ACPI_APEI + default y + config ACPI_PCI bool depends on ACPI && PCIhw/acpi/ghes_cper.c new file +0
-0@@ -0,0 +1,33 @@
Quoted 5 lines
hw/acpi/ghes_cper.c line 20
Quoted 5 lines
hw/acpi/ghes_cper.c new file +5
-0+#include "qapi/qapi-commands-acpi-hest.h" +#include "hw/acpi/ghes.h" + +void qmp_ghes_cper (const char *qmp_cper, +Error **errp)
Heh, with all code changes, this is not a lot simpler than before ;-)
I'll address it on a next spin.
Quoted 23 lines
That's a very short line wrap.
Quoted 21 lines
hw/acpi/ghes_cper.c new file +13
-0+{ + +uint8_t *cper; +size_t len; + + cper =qbase64_decode (qmp_cper,-1 , &len, errp); +if (!cper) { +error_setg (errp,"missing GHES CPER payload" ); +return ; + } + +/* TODO: call a function at ghes */ +}include/hw/acpi/ghes.h +0
-0@@ -23,6 +23,7 @@#define ACPI_GHES_H
Quoted 4 lines
include/hw/acpi/ghes.h line 26
Quoted 2 lines
include/hw/acpi/ghes.h +1
-0#include "hw/acpi/bios-linker-loader.h" +#include "qapi/error.h" Odd to have an include added with no other changes in file? Wrong patch maybe? Or should it be included by a c file instead?
Removing it would cause a compilation breakage. It might be moved to a c file, but patch 5/10 requires it at ghes.h, as it adds this to ghes.h:
void ghes_record_cper_errors(uint8_t *cper, size_t len,
enum AcpiGhesNotifyType notify,Error **errp);So, instead of poking around moving this to/from .c/.h, I opted to place it on its final place.
Quoted 6 lines
qapi/acpi-hest.json
Quoted 4 lines
include/hw/acpi/ghes.h +0
-0#include "qemu/notify.h" extern NotifierList acpi_generic_error_notifiers;qapi/acpi-hest.json +0
-0
Thanks,
Mauro
PATCH v7 5/10 acpi/ghes: rework the logic to handle HEST source ID
In reply to Mauro Carvalho ChehabThe current logic is based on a lot of duct tape, with offsets calculated based on one define with the number of source IDs and an enum.
Rewrite the logic in a way that it would be more resilient of code changes, by moving the source ID count to an enum and make the offset calculus more explicit.
Such change was inspired on a patch from Jonathan Cameron splitting the logic to get the CPER address on a separate function, as this will be needed to support generic error injection.
--- hw/acpi/ghes-stub.c | 3 +- hw/acpi/ghes.c | 204 +++++++++++++++++++++++---------------- hw/arm/virt-acpi-build.c | 5 +- include/hw/acpi/ghes.h | 17 ++-- 4 files changed, 133 insertions(+), 96 deletions(-)
hw/acpi/ghes-stub.c +2 -1
@@ -11,7 +11,8 @@#include "qemu/osdep.h" #include "hw/acpi/ghes.h" -int acpi_ghes_record_errors (uint8_t source_id,uint64_t physical_address) +int acpi_ghes_record_errors (enum AcpiGhesNotifyType notify, +uint64_t physical_address) {return -1 ; }
hw/acpi/ghes.c +123 -81
318 lines not on this page · raw message
hw/arm/virt-acpi-build.c +2 -3
@@ -944,10 +944,9 @@ void virt_acpi_build(VirtMachineState *vms, AcpiBuildTables *tables)build_dbg2 (tables_blob, tables->linker, vms);if (vms->ras) { -build_ghes_error_table (tables->hardware_errors, tables->linker);acpi_add_table (table_offsets, tables_blob); -acpi_build_hest (tables_blob, tables->linker, vms->oem_id, - vms->oem_table_id); +acpi_build_hest (tables_blob, tables->hardware_errors, tables->linker, + vms->oem_id, vms->oem_table_id); }if (ms->numa_state->num_nodes >0 ) {
include/hw/acpi/ghes.h +6 -11
@@ -29,7 +29,7 @@extern NotifierList acpi_generic_error_notifiers;/* -* Values for Hardware Error Notification Type field +* ACPI spec values for Hardware Error Notification Type field */ enum AcpiGhesNotifyType {/* Polled */
@@ -60,24 +60,19 @@ enum AcpiGhesNotifyType { ACPI_GHES_NOTIFY_RESERVED = 12 }; -/* Those are used as table indexes when building GHES tables */ -enum { -ACPI_HEST_SRC_ID_SEA =0 , -ACPI_HEST_SRC_ID_GED , -ACPI_HEST_SRC_ID_RESERVED , -}; -typedef struct AcpiGhesState { +uint64_t hest_addr_le;uint64_t ghes_addr_le;bool present;/* True if GHES is present at all on this board */ }AcpiGhesState ; -void build_ghes_error_table (GArray *hardware_errors,BIOSLinker *linker); -void acpi_build_hest (GArray *table_data,BIOSLinker *linker, +void acpi_build_hest (GArray *table_data,GArray *hardware_errors, +BIOSLinker *linker,const char *oem_id,const char *oem_table_id);void acpi_ghes_add_fw_cfg (AcpiGhesState *vms,FWCfgState *s,GArray *hardware_errors); -int acpi_ghes_record_errors (uint8_t notify,uint64_t error_physical_addr); +int acpi_ghes_record_errors (enum AcpiGhesNotifyType notify, +uint64_t error_physical_addr);/** * acpi_ghes_present: Report whether ACPI GHES table is present
Signature · 1 line
2.46.0
Re: [PATCH v7 05/10] acpi/ghes: rework the logic to handle HEST source ID
Em Wed, 14 Aug 2024 01:23:27 +0200
Mauro Carvalho Chehab <[email protected]> escreveu:
This hunk is wrong:
Quoted 4 lines
hw/acpi/ghes.c +0
-0@@ -350,9 +380,10 @@ static void build_ghes_v2(GArray *table_data, int source_id, BIOSLinker *linker)build_append_gas (table_data,AML_AS_SYSTEM_MEMORY ,0x40 ,0 ,4 /* QWord access */ ,0 ); bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
hw/acpi/ghes.c static void build_ghes_v2(GArray *table_data, int source_id, BIOSLinker *linker) · line 389
Quoted 10 lines
hw/acpi/ghes.c +4
-3- address_offset +GAS_ADDR_OFFSET , -sizeof (uint64_t ),ACPI_GHES_ERRORS_FW_CFG_FILE , - (ACPI_GHES_ERROR_SOURCE_COUNT + source_id) * sizeof(uint64_t)); + address_offset +GAS_ADDR_OFFSET , +sizeof (uint64_t ), +ACPI_BUILD_TABLE_FILE , + address_offset + GAS_ADDR_OFFSET);/* * Read Ack Preserve field
It should be, instead:
/*
* Read Ack Register
* ACPI 6.1: 18.3.2.8 Generic Hardware Error Source
* version 2 (GHESv2 - Type 10)
*/
address_offset = table_data->len;
build_append_gas(table_data, AML_AS_SYSTEM_MEMORY, 0x40, 0,
4 /* QWord access */, 0);
bios_linker_loader_add_pointer(linker, ACPI_BUILD_TABLE_FILE,
address_offset + GAS_ADDR_OFFSET,
sizeof(uint64_t),
ACPI_HW_ERROR_FW_CFG_FILE,
(ACPI_HEST_SRC_ID_COUNT + source_id) *
sizeof(uint64_t));Funny enough, even with this problem, error injection was working.
I'll be preparing a v8 with such fix applied.
I'll also add an optional patch at the end to double-check if the links are properly generated, using an abort() in case something ever goes wrong.
Regards,
Mauro
PATCH v7 6/10 acpi/ghes: add support for generic error injection via QAPI
In reply to Mauro Carvalho ChehabProvide a generic interface for error injection via GHESv2.
This patch is co-authored:
- original ghes logic to inject a simple ARM record by Shiju Jose;
- generic logic to handle block addresses by Jonathan Cameron;
- generic GHESv2 error inject by Mauro Carvalho Chehab;
--- hw/acpi/ghes.c | 57 ++++++++++++++++++++++++++++++++++++++++++ hw/acpi/ghes_cper.c | 2 +- include/hw/acpi/ghes.h | 3 +++ 3 files changed, 61 insertions(+), 1 deletion(-)
hw/acpi/ghes.c +57 -0
@@ -495,6 +495,63 @@ int acpi_ghes_record_errors(enum AcpiGhesNotifyType notify,NotifierList acpi_generic_error_notifiers =NOTIFIER_LIST_INITIALIZER (error_device_notifiers); +void ghes_record_cper_errors (uint8_t *cper,size_t len, +enum AcpiGhesNotifyType notify,Error **errp) +{ +uint64_t cper_addr, read_ack_start_addr; +enum AcpiHestSourceId source; +AcpiGedState *acpi_ged_state; +AcpiGhesState *ags; +uint64_t read_ack; + +if (ghes_notify_to_source_id (notify, &source)) { +error_setg (errp, +"GHES: Invalid error block/ack address(es) for notify %d" , + notify); +return ; + } + + acpi_ged_state =ACPI_GED (object_resolve_path_type ("" ,TYPE_ACPI_GED , +NULL )); +g_assert (acpi_ged_state); + ags = &acpi_ged_state->ghes_state; + + cper_addr =le64_to_cpu (ags->ghes_addr_le); + cper_addr +=2 *ACPI_HEST_SRC_ID_COUNT *sizeof (uint64_t ); + cper_addr += source *ACPI_GHES_MAX_RAW_DATA_LENGTH ; + + read_ack_start_addr =le64_to_cpu (ags->hest_addr_le); + read_ack_start_addr += source *HEST_GHES_V2_TABLE_SIZE +HEST_ACK_OFFSET ; + +cpu_physical_memory_read (read_ack_start_addr, + &read_ack,sizeof (uint64_t )); + +/* zero means OSPM does not acknowledge the error */ +if (!read_ack) { +error_setg (errp, +"Last CPER record was not acknowledged yet" ); + read_ack =1 ; +cpu_physical_memory_write (read_ack_start_addr, + &read_ack,sizeof (uint64_t )); +return ; + } + + read_ack =cpu_to_le64 (0 ); +cpu_physical_memory_write (read_ack_start_addr, + &read_ack,sizeof (uint64_t )); + +/* Build CPER record */ + +if (len >ACPI_GHES_MAX_RAW_DATA_LENGTH ) { +error_setg (errp,"GHES CPER record is too big: %ld" , len); + } + +/* Write the generic error data entry into guest memory */ +cpu_physical_memory_write (cper_addr, cper, len); + +notifier_list_notify (&acpi_generic_error_notifiers,NULL ); +} +bool acpi_ghes_present (void ) {AcpiGedState *acpi_ged_state;
hw/acpi/ghes_cper.c +1 -1
@@ -29,5 +29,5 @@ void qmp_ghes_cper(const char *qmp_cper,return ; } -/* TODO: call a function at ghes */ +ghes_record_cper_errors (cper, len,ACPI_GHES_NOTIFY_GPIO , errp); }
include/hw/acpi/ghes.h +3 -0
@@ -74,6 +74,9 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *vms, FWCfgState *s,int acpi_ghes_record_errors (enum AcpiGhesNotifyType notify,uint64_t error_physical_addr); +void ghes_record_cper_errors (uint8_t *cper,size_t len, +enum AcpiGhesNotifyType notify,Error **errp); +/** * acpi_ghes_present: Report whether ACPI GHES table is present *
Signature · 1 line
2.46.0
PATCH v7 7/10 docs: acpi_hest_ghes: fix documentation for CPER size
In reply to Mauro Carvalho ChehabWhile the spec defines a CPER size of 4KiB for each record, currently it is set to 1KiB. Fix the documentation and add a pointer to the macro name there, as this may help to keep it updated.
--- docs/specs/acpi_hest_ghes.rst | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
docs/specs/acpi_hest_ghes.rst +4 -2
@@ -67,8 +67,10 @@ Design Details (3) The address registers table contains N Error Block Address entries and N Read Ack Register entries. The size for each entry is 8-byte. The Error Status Data Block table contains N Error Status Data Block - entries. The size for each entry is 4096(0x1000) bytes. The total size - for the "etc/hardware_errors" fw_cfg blob is (N * 8 * 2 + N * 4096) bytes. + entries. The size for each entry is defined at the source code as + ACPI_GHES_MAX_RAW_DATA_LENGTH (currently 1024 bytes). The total size + for the "etc/hardware_errors" fw_cfg blob is + (N * 8 * 2 + N * ACPI_GHES_MAX_RAW_DATA_LENGTH) bytes. N is the number of the kinds of hardware error sources. (4) QEMU generates the ACPI linker/loader script for the firmware. The
Signature · 1 line
2.46.0
PATCH v7 8/10 scripts/ghes_inject: add a script to generate GHES error inject
In reply to Mauro Carvalho ChehabUsing the QMP GHESv2 API requires preparing a raw data array containing a CPER record.
Add a helper script with subcommands to prepare such data.
Currently, only ARM Processor error CPER record is supported.
--- MAINTAINERS | 3 + scripts/arm_processor_error.py | 371 +++++++++++++++++++++++++ scripts/ghes_inject.py | 51 ++++ scripts/qmp_helper.py | 486 +++++++++++++++++++++++++++++++++ 4 files changed, 911 insertions(+) create mode 100644 scripts/arm_processor_error.py create mode 100755 scripts/ghes_inject.py create mode 100644 scripts/qmp_helper.py
MAINTAINERS +3 -0
@@ -2083,6 +2083,9 @@ S: Maintained F: hw/arm/ghes_cper.c F: hw/acpi/ghes_cper_stub.c F: qapi/acpi-hest.json +F: scripts/ghes_inject.py +F: scripts/arm_processor_error.py +F: scripts/qmp_helper.py ppc4xx L: [email protected]
scripts/arm_processor_error.py new file +371 -0
371 lines not on this page · raw message
scripts/ghes_inject.py new file +51 -0
51 lines not on this page · raw message
scripts/qmp_helper.py new file +486 -0
486 lines not on this page · raw message
Signature · 1 line
2.46.0
PATCH v7 9/10 target/arm: add an experimental mpidr arm cpu property object
In reply to Mauro Carvalho ChehabAccurately injecting an ARM Processor error ACPI/APEI GHES error record requires the value of the ARM Multiprocessor Affinity Register (mpidr).
While ARM implements it, this is currently not visible.
Add a field at CPU storing it, and place it at arm_cpu_properties as experimental, thus allowing it to be queried via QMP using qom-get function.
--- target/arm/cpu.c | 1 + target/arm/cpu.h | 1 + target/arm/helper.c | 10 ++++++++-- 3 files changed, 10 insertions(+), 2 deletions(-)
target/arm/cpu.c +1 -0
@@ -2619,6 +2619,7 @@ static ObjectClass *arm_cpu_class_by_name(const char *cpu_model)static Property arm_cpu_properties[] = {DEFINE_PROP_UINT64 ("midr" ,ARMCPU , midr,0 ), +DEFINE_PROP_UINT64 ("x-mpidr" ,ARMCPU , mpidr,0 ),DEFINE_PROP_UINT64 ("mp-affinity" ,ARMCPU , mp_affinity,ARM64_AFFINITY_INVALID ),DEFINE_PROP_INT32 ("node-id" ,ARMCPU , node_id,CPU_UNSET_NUMA_NODE_ID ),
target/arm/cpu.h +1 -0
@@ -1033,6 +1033,7 @@ struct ArchCPU {uint64_t reset_pmcr_el0; } isar;uint64_t midr; +uint64_t mpidr;uint32_t revidr;uint32_t reset_fpsid;uint64_t ctr;
target/arm/helper.c +8 -2
@@ -4692,7 +4692,7 @@ static uint64_t mpidr_read_val(CPUARMState *env)return mpidr; } -static uint64_t mpidr_read (CPUARMState *env,const ARMCPRegInfo *ri) +static uint64_t mpidr_read (CPUARMState *env) {unsigned int cur_el =arm_current_el (env);
@@ -4702,6 +4702,11 @@ static uint64_t mpidr_read(CPUARMState *env, const ARMCPRegInfo *ri)return mpidr_read_val (env); } +static uint64_t mpidr_read_ri (CPUARMState *env,const ARMCPRegInfo *ri) +{ +return mpidr_read (env); +} +static const ARMCPRegInfo lpae_cp_reginfo[] = {/* NOP AMAIR0/1 */ { .name ="AMAIR0" , .state =ARM_CP_STATE_BOTH ,
@@ -9723,7 +9728,7 @@ void register_cp_regs_for_features(ARMCPU *cpu) { .name = "MPIDR_EL1", .state = ARM_CP_STATE_BOTH, .opc0 = 3, .crn = 0, .crm = 0, .opc1 = 0, .opc2 = 5, .fgt = FGT_MPIDR_EL1, - .access = PL1_R, .readfn = mpidr_read, .type = ARM_CP_NO_RAW }, + .access = PL1_R, .readfn = mpidr_read_ri, .type = ARM_CP_NO_RAW }, };#ifdef CONFIG_USER_ONLY static const ARMCPRegUserSpaceInfo mpidr_user_cp_reginfo[] = {
@@ -9733,6 +9738,7 @@ void register_cp_regs_for_features(ARMCPU *cpu)modify_arm_cp_regs (mpidr_cp_reginfo, mpidr_user_cp_reginfo);#endif define_arm_cp_regs (cpu, mpidr_cp_reginfo); + cpu->mpidr =mpidr_read (env); }if (arm_feature (env,ARM_FEATURE_AUXCR )) {
Signature · 1 line
2.46.0
PATCH v7 10/10 scripts/arm_processor_error.py: retrieve mpidr if not filled
In reply to Mauro Carvalho ChehabAdd support to retrieve mpidr value via qom-get.
--- scripts/arm_processor_error.py | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-)
scripts/arm_processor_error.py +19 -8
@@ -5,12 +5,10 @@ # # Copyright (C) 2024 Mauro Carvalho Chehab <[email protected]> -# TODO: current implementation has dummy defaults. -# -# For a better implementation, a QMP addition/call is needed to -# retrieve some data for ARM Processor Error injection: -# -# - ARM registers: power_state, mpidr. +# Note: currently it lacks a method to fill the ARM Processor Error CPER +# psci field from emulation. On a real hardware, this is filled only +# when a CPU is not running. Implementing support for it to simulate a +# real hardware is not trivial. import argparse import re
@@ -168,11 +166,24 @@ def send_cper(self, args): else: cper["running-state"] = 0 + if args.mpidr: + cper["mpidr-el1"] = arg["mpidr"] + elif cpus: + cmd_arg = { + 'path': cpus[0], + 'property': "x-mpidr" + } + ret = qmp_cmd.send_cmd("qom-get", cmd_arg, may_open=True) + if isinstance(ret, int): + cper["mpidr-el1"] = ret + else: + cper["mpidr-el1"] = 0 + if arm_valid_init: if args.affinity: cper["valid"] |= self.arm_valid_bits["affinity"] - if args.mpidr: + if "mpidr-el1" in cper: cper["valid"] |= self.arm_valid_bits["mpidr"] if "running-state" in cper:
@@ -356,7 +367,7 @@ def send_cper(self, args): if isinstance(ret, int): arg["midr-el1"] = ret - util.data_add(data, arg.get("mpidr-el1", 0), 8) + util.data_add(data, cper["mpidr-el1"], 8) util.data_add(data, arg.get("midr-el1", 0), 8) util.data_add(data, cper["running-state"], 4) util.data_add(data, arg.get("psci-state", 0), 4)
Signature · 1 line
2.46.0