DCD: Add support for Dynamic Capacity Devices (DCD)
Subsystems (7)
v3 cover DCD: Add support for Dynamic Capacity Devices (DCD)
A git tree of this series can be found here:
https://github.com/weiny2/linux-kernel/tree/dcd-v4-2024-08-16
This series requires the CXL memory notifier lock change:
https://lore.kernel.org/all/[email protected]/
Background
==========
A Dynamic Capacity Device (DCD) (CXL 3.1 sec 9.13.3) is a CXL memory device that allows memory capacity within a region to change dynamically without the need for resetting the device, reconfiguring HDM decoders, or reconfiguring software DAX regions.
One of the biggest use cases for Dynamic Capacity is to allow hosts to share memory dynamically within a data center without increasing the per-host attached memory.
The general flow for the addition or removal of memory is to have an orchestrator coordinate the use of the memory. Generally there are 5 actors in such a system, the Orchestrator, Fabric Manager, the Logical device, the Host Kernel, and a Host User.
Typical work flows are shown below.
Orchestrator FM Device Host Kernel Host User
| | | | |
|-------------- Create region ----------------------->|
| | | | |
| | | |<-- Create ---|
| | | | Region |
|<------------- Signal done --------------------------|
| | | | |
|-- Add ----->|-- Add --->|--- Add --->| |
| Capacity | Extent | Extent | |
| | | | |
| |<- Accept -|<- Accept -| |
| | Extent | Extent | |
| | | |<- Create --->|
| | | | DAX dev |-- Use memory
| | | | | |
| | | | | |
| | | |<- Release ---| <-+
| | | | DAX dev |
| | | | |
|<------------- Signal done --------------------------|
| | | | |
|-- Remove -->|- Release->|- Release ->| |
| Capacity | Extent | Extent | |
| | | | |
| |<- Release-|<- Release -| |
| | Extent | Extent | |
| | | | |
|-- Add ----->|-- Add --->|--- Add --->| |
| Capacity | Extent | Extent | |
| | | | |
| |<- Accept -|<- Accept -| |
| | Extent | Extent | |
| | | |<- Create ----|
| | | | DAX dev |-- Use memory
| | | | | |
| | | |<- Release ---| <-+
| | | | DAX dev |
|<------------- Signal done --------------------------|
| | | | |
|-- Remove -->|- Release->|- Release ->| |
| Capacity | Extent | Extent | |
| | | | |
| |<- Release-|<- Release -| |
| | Extent | Extent | |
| | | | |
|-- Add ----->|-- Add --->|--- Add --->| |
| Capacity | Extent | Extent | |
| | | |<- Create ----|
| | | | DAX dev |-- Use memory
| | | | | |
|-- Remove -->|- Release->|- Release ->| | |
| Capacity | Extent | Extent | | |
| | | | | |
| | | (Release Ignored) | |
| | | | | |
| | | |<- Release ---| <-+
| | | | DAX dev |
|<------------- Signal done --------------------------|
| | | | |
| |- Release->|- Release ->| |
| | Extent | Extent | |
| | | | |
| |<- Release-|<- Release -| |
| | Extent | Extent | |
| | | |<- Destroy ---|
| | | | Region |
| | | | |Previous versions of this series[0] resulted in architectural comments as well as confusion on the architecture based on the organization of patch series itself.
This version has reordered the patches to clarify the architecture. It also streamlines extent handling more.
The series still requires the creation of regions and DAX devices to be synchronized with the Orchestrator and Fabric Manager. The host kernel will reject an add extent event if the region is not created yet. It will also ignore a release if the DAX device is created and referencing an extent.
These synchronizations are not anticipated to be an issue with real applications.
In order to allow for capacity to be added and removed a new concept of a sparse DAX region is introduced. A sparse DAX region may have 0 or more bytes of available space. The total space depends on the number and size of the extents which have been added.
Initially it is anticipated that users of the memory will carefully coordinate the surfacing of additional capacity with the creation of DAX devices which use that capacity. Therefore, the allocation of the memory to DAX devices does not allow for specific associations between DAX device and extent. This keeps allocations very similar to existing DAX region behavior.
Great care was taken to keep the extent tracking simple. Some xarray's needed to be added but extra software objects were kept to a minimum.
Region extents continue to be tracked as sub-devices of the DAX region. This ensures that region destruction cleans up all extent allocations properly.
Due to these major changes all reviews were removed from the larger patches. A few of the straight forward patches have kept the tags.
In summary the major functionality of this series includes:
- Getting the dynamic capacity (DC) configuration information from cxl devices
- Configuring the DC partitions reported by hardware
- Enhancing the CXL and DAX regions for dynamic capacity support a. Maintain a logical separation between hardware extents and software managed region extents. This provides an abstraction between the layers and should allow for interleaving in the future
- Get hardware extent lists for endpoint decoders upon region creation.
- Adjust extent/region memory available on the following events. a. Add capacity Events
b. Release capacity events
- Host response for add capacity
a. do not accept the extent if:
If the region does not exist
or an error occurs realizing the extent
b. If the region does exist
realize a DAX region extent with 1:1 mapping (no interleave yet)
c. Support the more bit by processing a list of extents marked
with the more bit together before setting up a response.
- Host response for remove capacity
a. If no DAX device references the extent; release the extent b. If a reference does exist, ignore the request.
(Require FM to issue release again.)
- Modify DAX device creation/resize to account for extents within a sparse DAX region
- Trace Dynamic Capacity events for debugging
- Add cxl-test infrastructure to allow for faster unit testing (See new ndctl branch for cxl-dcd.sh test[1])
Fan Ni's upstream of Qemu DCD was used for testing.
Remaining work:
1) Integrate the QoS work from Dave Jiang
2) Interleave support
Possible additional work depending on requirements:
1) Allow mapping to specific extents (perhaps based on label/tag)
2) Release extents when DAX devices are released if a release was previously seen from the device
3) Accept a new extent which extends (but overlaps) an existing extent(s)
4) Rework DAX device interfaces, memfd has been explored a bit
[0] v1: https://lore.kernel.org/all/[email protected]/
[1] https://github.com/weiny2/ndctl/tree/dcd-region2-2024-08-15
---
Major changes:
- Jonathan: support the more bit
- djbw: Allow more than 1 region per DC partition
- All: Address the many comments on the series.
- iweiny: rebase
- iweiny: Rework the series to make it easier to review and understand
the flow
- Link to v1: https://lore.kernel.org/r/[email protected]
- Link to v2: https://lore.kernel.org/all/[email protected]/
---
Ira Weiny (11):
range: Add range_overlaps()
printk: Add print format (%par) for struct range
dax: Document dax dev range tuple
cxl/pci: Delay event buffer allocation
cxl/region: Refactor common create region code cxl/events: Split event msgnum configuration from irq setup cxl/pci: Factor out interrupt policy check
cxl/core: Return endpoint decoder information from region search dax/bus: Factor out dev dax resize logic tools/testing/cxl: Make event logs dynamic tools/testing/cxl: Add DC Regions to mock mem data
Navneet Singh (14):
cxl/mbox: Flag support for Dynamic Capacity Devices (DCD) cxl/mem: Read dynamic capacity configuration from the device cxl/core: Separate region mode from decoder mode cxl/region: Add dynamic capacity decoder and region modes cxl/hdm: Add dynamic capacity size support to endpoint decoders cxl/port: Add endpoint decoder DC mode support to sysfs cxl/mem: Expose DCD partition capabilities in sysfs cxl/region: Add sparse DAX region support
cxl/mem: Configure dynamic capacity interrupts cxl/extent: Process DCD events and realize region extents cxl/region/extent: Expose region extent information in sysfs dax/region: Create resources on sparse DAX regions cxl/region: Read existing extents on region creation cxl/mem: Trace Dynamic capacity Event Record
Documentation/ABI/testing/sysfs-bus-cxl | 68 ++- Documentation/core-api/printk-formats.rst | 14 + drivers/cxl/core/Makefile | 2 +- drivers/cxl/core/core.h | 33 +- drivers/cxl/core/extent.c | 467 ++++++++++++++ drivers/cxl/core/hdm.c | 206 ++++++- drivers/cxl/core/mbox.c | 578 +++++++++++++++++- drivers/cxl/core/memdev.c | 101 ++- drivers/cxl/core/port.c | 13 +- drivers/cxl/core/region.c | 173 ++++-- drivers/cxl/core/trace.h | 65 ++ drivers/cxl/cxl.h | 122 +++- drivers/cxl/cxlmem.h | 128 +++- drivers/cxl/pci.c | 123 +++- drivers/dax/bus.c | 352 +++++++++-- drivers/dax/bus.h | 4 +- drivers/dax/cxl.c | 73 ++- drivers/dax/dax-private.h | 39 +- drivers/dax/hmem/hmem.c | 2 +- drivers/dax/pmem.c | 2 +- fs/btrfs/ordered-data.c | 10 +- include/linux/cxl-event.h | 32 + include/linux/range.h | 7 + lib/vsprintf.c | 37 ++ tools/testing/cxl/Kbuild | 3 +- tools/testing/cxl/test/mem.c | 981 ++++++++++++++++++++++++++---- 26 files changed, 3327 insertions(+), 308 deletions(-)
---
base-commit: 3cef9316df4cda21b5bf25e4230221b02050dfa1
change-id: 20230604-dcd-type2-upstream-0cd15f6216fd
Best regards,
Signature · 1 line
Ira Weiny <[email protected]>
PATCH v3 1/25 range: Add range_overlaps()
Code to support CXL Dynamic Capacity devices will have extent ranges which need to be compared for intersection not a subset as is being checked in range_contains().
range_overlaps() is defined in btrfs with a different meaning from what is required in the standard range code. Dan Williams pointed this out in [1]. Adjust the btrfs call according to his suggestion there.
Then add a generic range_overlaps().
[1] https://lore.kernel.org/all/[email protected]/
--- fs/btrfs/ordered-data.c | 10 +++++----- include/linux/range.h | 7 +++++++ 2 files changed, 12 insertions(+), 5 deletions(-)
fs/btrfs/ordered-data.c +5 -5
@@ -111,8 +111,8 @@ static struct rb_node *__tree_search(struct rb_root *root, u64 file_offset,return NULL ; } -static int range_overlaps (struct btrfs_ordered_extent *entry,u64 file_offset, -u64 len) +static int btrfs_range_overlaps (struct btrfs_ordered_extent *entry,u64 file_offset, +u64 len) {if (file_offset + len <= entry->file_offset || entry->file_offset + entry->num_bytes <= file_offset)
@@ -985,7 +985,7 @@ struct btrfs_ordered_extent *btrfs_lookup_ordered_range(while (1 ) { entry = rb_entry(node, struct btrfs_ordered_extent, rb_node); -if (range_overlaps (entry, file_offset, len)) +if (btrfs_range_overlaps (entry, file_offset, len))break ;if (entry->file_offset >= file_offset + len) {
@@ -1114,12 +1114,12 @@ struct btrfs_ordered_extent *btrfs_lookup_first_ordered_range( }if (prev) { entry = rb_entry(prev, struct btrfs_ordered_extent, rb_node); -if (range_overlaps (entry, file_offset, len)) +if (btrfs_range_overlaps (entry, file_offset, len)) goto out; }if (next) { entry = rb_entry(next, struct btrfs_ordered_extent, rb_node); -if (range_overlaps (entry, file_offset, len)) +if (btrfs_range_overlaps (entry, file_offset, len)) goto out; }/* No ordered extent in the range */
include/linux/range.h +7 -0
@@ -13,11 +13,18 @@ static inline u64 range_len(const struct range *range)return range->end - range->start +1 ; } +/* True if r1 completely contains r2 */ static inline bool range_contains (struct range *r1,struct range *r2) {return r1->start <= r2->start && r1->end >= r2->end; } +/* True if any part of r1 overlaps r2 */ +static inline bool range_overlaps (struct range *r1,struct range *r2) +{ +return r1->start <= r2->end && r1->end >= r2->start; +} +int add_range (struct range *range,int az,int nr_range,u64 start,u64 end);
Signature · 1 line
2.45.2
PATCH v3 2/25 printk: Add print format (%par) for struct range
In reply to Ira WeinyThe use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages.
To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Williams mentions in [1] that it might be time to have a print specifier for struct range similar to struct resource
A few alternatives were considered including '%pn' for 'print raNge' but %par follows that struct range is most often used to store a range of physical addresses. So use '%par' for 'print address range'.
To: Petr Mladek <[email protected]> (maintainer:VSPRINTF)
To: Steven Rostedt <[email protected]> (maintainer:VSPRINTF)
To: Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
--- Documentation/core-api/printk-formats.rst | 14 ++++++++++++ lib/vsprintf.c | 37 +++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+)
Documentation/core-api/printk-formats.rst +14 -0
@@ -231,6 +231,20 @@ width of the CPU data path. Passed by reference. +Struct Range +------------ + +:: + + %par [range 0x60000000-0x6fffffff] or + [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference. + DMA address types dma_addr_t ----------------------------
lib/vsprintf.c +37 -0
@@ -1140,6 +1140,39 @@ char *resource_string(char *buf, char *end, struct resource *res,return string_nocheck (buf, end, sym, spec); } +static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_PRINTK_SIZE 16 +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range - ]") +char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); + +static const struct printf_spec str_spec = { + .field_width =-1 , + .precision =10 , + .flags =LEFT , + }; +static const struct printf_spec range_spec = { + .base =16 , + .field_width =RANGE_PRINTK_SIZE , + .precision =-1 , + .flags =SPECIAL |SMALL |ZEROPAD , + }; + + *p++ ='[' ; + p =string_nocheck (p, pend,"range " , str_spec); + p =number (p, pend, range->start, range_spec); + *p++ ='-' ; + p =number (p, pend, range->end, range_spec); + *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +} +static noinline_for_stack char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,const char *fmt)
@@ -1802,6 +1835,8 @@ char *address_val(char *buf, char *end, const void *addr,return buf;switch (fmt[1 ]) { +case 'r' : +return range_string (buf, end, addr, spec, fmt);case 'd' : num = *(const dma_addr_t *)addr; size =sizeof (dma_addr_t);
@@ -2364,6 +2399,8 @@ char *rust_fmt_argument(char *buf, char *end, void *ptr);* to use print_hex_dump() for the larger input. * - 'a[pd]' For address types [p] phys_addr_t, [d] dma_addr_t and derivatives * (default assumed to be phys_addr_t, passed by reference) +* - 'ar' For decoded struct ranges (a variation of physical address which are +* most often stored in struct ranges. * - 'd[234]' For a dentry name (optionally 2-4 last components) * - 'D[234]' Same as 'd' but for a struct file * - 'g' For block_device name (gendisk + partition number)
Signature · 1 line
2.45.2
Petr Mladek
maintainerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 15 lines · Ira Weiny
The use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages.
To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Williams mentions in [1] that it might be time to have a print specifier for struct range similar to struct resource
A few alternatives were considered including '%pn' for 'print raNge' but %par follows that struct range is most often used to store a range of physical addresses. So use '%par' for 'print address range'.
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 239
Quoted 9 lines
Documentation/core-api/printk-formats.rst +6
-0@@ -231,6 +231,20 @@ width of the CPU data path. Passed by reference. +Struct Range +------------ + +:: + + %par [range 0x60000000-0x6fffffff] or
It seems that it is always 64-bit. It prints:
struct range {
u64 start;
u64 end;
};Quoted 16 lines
Documentation/core-api/printk-formats.rst +8
-0+ [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference. + DMA address types dma_addr_t ----------------------------lib/vsprintf.c +0
-0
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1149
Quoted 10 lines
lib/vsprintf.c +7
-0@@ -1140,6 +1140,39 @@ char *resource_string(char *buf, char *end, struct resource *res,return string_nocheck (buf, end, sym, spec); } +static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_PRINTK_SIZE 16 +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range - ]")
I think that it should be "[range -]"
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1157
Quoted 8 lines
lib/vsprintf.c +8
-0+char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); + +static const struct printf_spec str_spec = { + .field_width =-1 , + .precision =10 , + .flags =LEFT , + };
Is this really needed? What about using "default_str_spec" instead?
Quoted 11 lines
lib/vsprintf.c +11
-0+static const struct printf_spec range_spec = { + .base =16 , + .field_width =RANGE_PRINTK_SIZE , + .precision =-1 , + .flags =SPECIAL |SMALL |ZEROPAD , + }; + + *p++ ='[' ; + p =string_nocheck (p, pend,"range " , str_spec); + p =number (p, pend, range->start, range_spec); + *p++ ='-' ;
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1178
Quoted 10 lines
lib/vsprintf.c +7
-0+ p =number (p, pend, range->end, range_spec); + *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +} +static noinline_for_stack char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,const char *fmt)
Also add a selftest into lib/test_printf.c, please.
Best Regards,
Petr
Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 28 lines · Petr Mladek
Quoted 15 lines · Ira Weiny
The use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages.
To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Williams mentions in [1] that it might be time to have a print specifier for struct range similar to struct resource
A few alternatives were considered including '%pn' for 'print raNge' but %par follows that struct range is most often used to store a range of physical addresses. So use '%par' for 'print address range'.
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 239
Quoted 9 lines
Documentation/core-api/printk-formats.rst +6
-0@@ -231,6 +231,20 @@ width of the CPU data path. Passed by reference. +Struct Range +------------ + +:: + + %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
Quoted 4 lines
struct range {
u64 start;
u64 end;
};Indeed. Thanks I should not have just copied/pasted.
Quoted 20 lines
Quoted 20 lines
Documentation/core-api/printk-formats.rst +8
-0+ [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference. + DMA address types dma_addr_t ----------------------------lib/vsprintf.c +0
-0@@ -1140,6 +1140,39 @@ char *resource_string(char *buf, char *end, struct resource *res,return string_nocheck (buf, end, sym, spec); }
Quoted 9 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1149
Quoted 7 lines
lib/vsprintf.c +7
-0+static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_PRINTK_SIZE 16 +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range - ]")I think that it should be "[range -]"
Sounds good.
Quoted 11 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1157
Quoted 9 lines
lib/vsprintf.c +8
-0+char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); + +static const struct printf_spec str_spec = { + .field_width =-1 , + .precision =10 , + .flags =LEFT , + };Is this really needed? What about using "
default_str_spec" instead?
Because I got confused and was coping from resource_string().
Deleted now...
Quoted 4 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1160
Quoted 4 lines
lib/vsprintf.c +3
-0+static const struct printf_spec range_spec = { + .base =16 , + .field_width =RANGE_PRINTK_SIZE ,
However, my testing indicates this needs to be.
.field_width = 18, /* 2 (0x) + 2 * 8 (bytes) */
... to properly zero pad the value. Does that make sense?
Quoted 12 lines
Quoted 12 lines
lib/vsprintf.c +12
-0+ .precision = -1, + .flags = SPECIAL | SMALL | ZEROPAD, + }; + + *p++ ='[' ; + p =string_nocheck (p, pend,"range " , str_spec); + p =number (p, pend, range->start, range_spec); + *p++ ='-' ; + p =number (p, pend, range->end, range_spec); + *p++ =']' ; + *p ='\0' ; +
Quoted 8 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1178
Quoted 6 lines
lib/vsprintf.c +3
-0+return string_nocheck (buf, end, sym, spec); +} +static noinline_for_stack char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,const char *fmt)Also add a selftest into
lib/test_printf.c, please.
Yes of course... Makes testing easier too.
Thanks,
Ira
Quoted 3 lines
Best Regards,
Petr
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 10 lines
Quoted 8 lines
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 239
Quoted 1 line
Documentation/core-api/printk-formats.rst +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Documentation/core-api/printk-formats.rst +7
-0+ [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference.
...
Quoted 6 lines
Quoted 1 line
Is this really needed? What about using "
default_str_spec" instead?Because I got confused and was coping from
resource_string().Deleted now...
Quoted 7 lines
Quoted 1 line
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1160
Quoted 1 line
lib/vsprintf.c +1
-0+ .field_width = RANGE_PRINTK_SIZE,However, my testing indicates this needs to be.
.field_width = 18, /* 2 (0x) + 2 * 8 (bytes) */... to properly zero pad the value. Does that make sense?
Looking at this, moving under %pr/R should deduplicate the code, no? I.o.w. better to use existing code for them to print struct range, no?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Petr Mladek
maintainerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 15 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 9 lines
Quoted 8 lines
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 239
Quoted 1 line
Documentation/core-api/printk-formats.rst +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };
Quoted 4 lines
Quoted 1 line
Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 246
Quoted 7 lines
Documentation/core-api/printk-formats.rst +7
-0+ [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference.
Best Regards,
Petr
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 11 lines
Quoted 11 lines
Quoted 10 lines
Quoted 8 lines
Documentation/core-api/printk-formats.rst width of the CPU data path. · line 239
Quoted 1 line
Documentation/core-api/printk-formats.rst +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };Indeed. Thanks I should not have just copied/pasted.
Quoted 8 lines
Quoted 2 lines
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Documentation/core-api/printk-formats.rst +7
-0+ [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 17 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };
Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
I'm speaking a bit for Dan here but also the logical way I thought of things.
1) %p does not dictate anything about the format of the data. Rather indicates that what is passed is a pointer. Because we are passing a pointer to a range struct %pXX makes sense.
2) %pa indicates what follows is 'address'. This was a bit of creative license because, as I said in the commit message most of the time struct range contains an address range. So for this narrow use case it also makes sense.
3) %par r for range.
%p[rR] is taken. %pra confuses things IMO.
Quoted 6 lines
Quoted 6 lines
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
%r could be used I think. But this breaks with the convention of passing a pointer and how to interpret it. The other idea I had, mentioned in the commit message was %pn. Meaning passed by pointer 'raNge'.
I think that follows better than %r. That would be another break from C99. But we don't have to follow that.
Quoted 4 lines
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.
Andy, I'm not quite following how you expect to share the code between resource_string() and range_string()?
There is very little duplicated code. In fact with Petr's suggestions and some more work range_string() is quite simple:
+static noinline_for_stack
+char *range_string(char *buf, char *end, const struct range *range,
+ struct printf_spec spec, const char *fmt)
+{
+#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4)
+#define RANGE_PRINT_BUF_SIZE sizeof("[range -]")
+ char sym[RANGE_DECODED_BUF_SIZE + RANGE_PRINT_BUF_SIZE];
+ char *p = sym, *pend = sym + sizeof(sym);
+
+ *p++ = '['; + p = string_nocheck(p, pend, "range ", default_str_spec); + p = special_hex_number(p, pend, range->start, sizeof(range->start)); + *p++ = '-'; + p = special_hex_number(p, pend, range->end, sizeof(range->end)); + *p++ = ']'; + *p = '\0';
+
+ return string_nocheck(buf, end, sym, spec);
+}
Also this is the bulk of the patch except for documentation and the new testing code. [new patch below]
Am I missing your point somehow? I considered cramming a struct range into a struct resource to let resource_string() process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.
Most importantly that would not be much less code AFAICT.
Ira
[snip]
<new patch>
commit a5f0305d319eac7c6e480851378695f8bd42a3d0
Author: Ira Weiny <[email protected]> Date: Fri Jun 28 16:47:06 2024 -0500
printk: Add print format (%par) for struct range
The use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages.
To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Williams mentions in [1] that it might be time to have a print specifier for struct range similar to struct resource
A few alternatives were considered including '%pn' for 'print raNge' but %par follows that struct range is most often used to store a range of physical addresses. So use '%par' for 'print address range'.
To: Petr Mladek <[email protected]> (maintainer:VSPRINTF)
To: Steven Rostedt <[email protected]> (maintainer:VSPRINTF)
To: Jonathan Corbet <[email protected]> (maintainer:DOCUMENTATION)
---
Changes:
[iweiny: use special_hex_number()]
[Petr: Update documentation]
[Petr: use 'range -']
[Petr: fixup printf_spec specifiers]
[Petr: add lib/test_printf test]
Documentation/core-api/printk-formats.rst +13 -0
@@ -231,6 +231,19 @@ width of the CPU data path. Passed by reference. +Struct Range +------------ + +:: + + %par [range 0x0000000060000000-0x000000006fffffff] + +For printing struct range. A variation of printing a physical address is to +print the value of struct range which are often used to hold a physical address +range. + +Passed by reference. + DMA address types dma_addr_t ----------------------------
lib/test_printf.c +20 -0
@@ -388,6 +388,25 @@ struct_resource(void) { } +static void __init +struct_range (void ) +{ +struct range test_range = { + .start =0xc0ffee00ba5eba11 , + .end =0xc0ffee00ba5eba11 , + }; + +test ("[range 0xc0ffee00ba5eba11-0xc0ffee00ba5eba11]" , +"%par" , &test_range); + + test_range = (struct range ) { + .start =0xc0ffee , + .end =0xba5eba11 , + }; +test ("[range 0x0000000000c0ffee-0x00000000ba5eba11]" , +"%par" , &test_range); +} +static void __init addr (void ) {
@@ -789,6 +808,7 @@ test_pointer(void)symbol_ptr ();kernel_ptr ();struct_resource (); +struct_range ();addr ();escaped_str ();hex_string ();
lib/vsprintf.c +24 -0
@@ -1140,6 +1140,26 @@ char *resource_string(char *buf, char *end, struct resource *res,return string_nocheck (buf, end, sym, spec); } +static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") +char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); + + *p++ ='[' ; + p =string_nocheck (p, pend,"range " , default_str_spec); + p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +} +static noinline_for_stack char *hex_string(char *buf, char *end, u8 *addr, struct printf_spec spec,const char *fmt)
@@ -1802,6 +1822,8 @@ char *address_val(char *buf, char *end, const void *addr,return buf;switch (fmt[1 ]) { +case 'r' : +return range_string (buf, end, addr, spec, fmt);case 'd' : num = *(const dma_addr_t *)addr; size =sizeof (dma_addr_t);
@@ -2364,6 +2386,8 @@ char *rust_fmt_argument(char *buf, char *end, void *ptr);* to use print_hex_dump() for the larger input. * - 'a[pd]' For address types [p] phys_addr_t, [d] dma_addr_t and derivatives * (default assumed to be phys_addr_t, passed by reference) +* - 'ar' For decoded struct ranges (a variation of physical address which are +* most often stored in struct ranges. * - 'd[234]' For a dentry name (optionally 2-4 last components) * - 'D[234]' Same as 'd' but for a struct file * - 'g' For block_device name (gendisk + partition number)
Petr Mladek
maintainerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 26 lines · Ira Weiny
Quoted 17 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
I'm speaking a bit for Dan here but also the logical way I thought of things.
Quoted 8 lines
1) %p does not dictate anything about the format of the data. Rather indicates that what is passed is a pointer. Because we are passing a pointer to a range struct %pXX makes sense.
2) %pa indicates what follows is 'address'. This was a bit of creative license because, as I said in the commit message most of the time struct range contains an address range. So for this narrow use case it also makes sense.
3) %par r for range.
Yes. I got it.
Well, is struct range really used for addresses? It rather looks like a range of any 64-bit values.
Quoted 1 line
%p[rR] is taken. %pra confuses things IMO.
Another variants might be %pr64 or %prange.
IMHO, there is no good solution. We are trying to find the least bad one. The meaning should be as obvious and as least confusing as possible.
Honestly, I do not have a strong opinion. I kind of like %prange ;-) But I could live with all other variants, except for %pn mentioned below.
Quoted 8 lines
Quoted 5 lines
Quoted 5 lines
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
%r could be used I think. But this breaks with the convention of passing a pointer and how to interpret it.
How exactly does it break the convention, please?
Do you passing a pointer to struct range instead of a pointer to struct resource?
It should not be a big problem as long as the vsprintf() code is able to guess the right pointer type from the %pXX modifier.
Quoted 2 lines
The other idea I had, mentioned in the commit message was %pn. Meaning passed by pointer 'raNge'.
This looks like the worst variant to me.
Quoted 19 lines
Quoted 3 lines
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.Andy, I'm not quite following how you expect to share the code between
resource_string()andrange_string()?There is very little duplicated code. In fact with Petr's suggestions and some more work
range_string()is quite simple:lib/vsprintf.c +9
-0+static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") +char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); +
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1161
Quoted 10 lines
lib/vsprintf.c +10
-0+ *p++ ='[' ; + p =string_nocheck (p, pend,"range " , default_str_spec); + p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +}
I agree that there is not much duplicated code in the end.
Quoted 8 lines
Also this is the bulk of the patch except for documentation and the new testing code. [new patch below]
Am I missing your point somehow? I considered cramming a struct range into a struct resource to let
resource_string()process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.
This would be nasty. I believe that this is not what Andy meant.
Best Regards,
Petr
PS: I have vacation until the end of the week, so my next eventual
reaction would be delayed.
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 2 lines · Petr Mladek
Quoted 1 line · Ira Weiny
Andy Shevchenko wrote:
...
Quoted 1 line
But I could live with all other variants, except for %pn mentioned below.
I believe %r is also no go as we most likely get a complier warning.
...
Quoted 7 lines
Quoted 5 lines
Am I missing your point somehow? I considered cramming a struct range into a struct resource to let
resource_string()process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.This would be nasty. I believe that this is not what Andy meant.
You are right, this is not what I meant.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range
In reply to Petr MladekQuoted 36 lines · Petr Mladek
Quoted 26 lines · Ira Weiny
Quoted 17 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
I'm speaking a bit for Dan here but also the logical way I thought of things.
Quoted 8 lines
1) %p does not dictate anything about the format of the data. Rather indicates that what is passed is a pointer. Because we are passing a pointer to a range struct %pXX makes sense.
2) %pa indicates what follows is 'address'. This was a bit of creative license because, as I said in the commit message most of the time struct range contains an address range. So for this narrow use case it also makes sense.
3) %par r for range.
Quoted 3 lines
Yes. I got it.
Well, is struct range really used for addresses?
Commonly yes. But I agree with Andy that it is not always.
Quoted 10 lines
It rather looks like
a range of any 64-bit values.Quoted 1 line
%p[rR] is taken. %pra confuses things IMO.
Another variants might be %pr64 or %prange.
IMHO, there is no good solution. We are trying to find the least bad one. The meaning should be as obvious and as least confusing as possible.
Yep.
Quoted 10 lines
Honestly, I do not have a strong opinion. I kind of like %prange ;-) But I could live with all other variants, except for %pn mentioned below.
Quoted 6 lines
Quoted 5 lines
Quoted 5 lines
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
Quoted 7 lines
Quoted 2 lines
%r could be used I think. But this breaks with the convention of passing a pointer and how to interpret it.
How exactly does it break the convention, please?
Do you passing a pointer to struct range instead of a pointer to struct resource?
Yes a pointer is passed as the parameter. This is what %p means AFAIU. Then the modifier is applied to know what we are pointing to.
Quoted 8 lines
It should not be a big problem as long as the
vsprintf()code is able to guess the right pointer type from the %pXX modifier.Quoted 2 lines
The other idea I had, mentioned in the commit message was %pn. Meaning passed by pointer 'raNge'.
This looks like the worst variant to me.
Fair enough.
Quoted 36 lines
Quoted 20 lines
Quoted 4 lines
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.Andy, I'm not quite following how you expect to share the code between
resource_string()andrange_string()?There is very little duplicated code. In fact with Petr's suggestions and some more work
range_string()is quite simple:lib/vsprintf.c +9
-0+static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") +char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym); +lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1161
Quoted 10 lines
lib/vsprintf.c +10
-0+ *p++ ='[' ; + p =string_nocheck (p, pend,"range " , default_str_spec); + p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +}I agree that there is not much duplicated code in the end.
Quoted 3 lines
Also this is the bulk of the patch except for documentation and the new testing code. [new patch below]
Quoted 7 lines
Quoted 5 lines
Am I missing your point somehow? I considered cramming a struct range into a struct resource to let
resource_string()process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.This would be nasty. I believe that this is not what Andy meant.
Nope.
Quoted 6 lines
Best Regards,
PetrPS: I have vacation until the end of the week, so my next eventual
reaction would be delayed.
No hurry. I'm still mucking around with it,
Ira
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
In reply to Ira WeinyQuoted 6 lines · Ira Weiny
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
...
Quoted 14 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 9 lines
Quoted 8 lines
Review
Quoted 1 line
(quoted diff) +1
-0+ %par [range 0x60000000-0x6fffffff] orIt seems that it is always 64-bit. It prints:
struct range { u64 start; u64 end; };Quoted 4 lines
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Indeed. Thanks I should not have just copied/pasted.
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
Quoted 6 lines
I'm speaking a bit for Dan here but also the logical way I thought of things.
1) %p does not dictate anything about the format of the data. Rather indicates that what is passed is a pointer. Because we are passing a pointer to a range struct %pXX makes sense.
There is no objection to that.
Quoted 4 lines
2) %pa indicates what follows is 'address'. This was a bit of creative license because, as I said in the commit message most of the time struct range contains an address range. So for this narrow use case it also makes sense.
As in the discussion it was pointed out that struct range is always 64-bit, limiting it to the "address" is a wrong assumption as we are talking generic printing routine here. We don't know what users will be in the future on 32-bit platforms, or what data (semantically) is being held by this structure.
Quoted 1 line
3) %par r for range.
I understand, but again struct range != address.
Quoted 2 lines
%p[rR] is taken.
%pra confuses things IMO.
It doesn't confuse me. :-) But I believe Petr also has a rationale behind this proposal as he described earlier.
Quoted 9 lines
Quoted 5 lines
Quoted 5 lines
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
%r could be used I think. But this breaks with the convention of passing a pointer and how to interpret it. The other idea I had, mentioned in the commit message was %pn. Meaning passed by pointer 'raNge'.
No, we can't use %r or anything else that is documented for the standard printf() format specifiers, otherwise you will get a compiler warning and basically it means no go.
Quoted 13 lines
I think that follows better than %r. That would be another break from C99. But we don't have to follow that.
Quoted 3 lines
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.Andy, I'm not quite following how you expect to share the code between
resource_string()andrange_string()?There is very little duplicated code. In fact with Petr's suggestions and some more work
range_string()is quite simple:
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1150
Quoted 8 lines
lib/vsprintf.c +8
-0+static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") +char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ]; +char *p = sym, *pend = sym +sizeof (sym);
Missing check for pointer, but it's not that I wanted to tell.
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1153
Quoted 2 lines
lib/vsprintf.c +2
-0+ *p++ ='[' ; + p =string_nocheck (p, pend,"range " , default_str_spec);
Hmm... %pr uses str_spec, what the difference can be here?
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1156
Quoted 3 lines
lib/vsprintf.c +3
-0+ p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end));
This is basically the copy of %pr implementation.
p = number(p, pend, res->start, *specp);
if (res->start != res->end) {
*p++ = '-';
p = number(p, pend, res->end, *specp);
}Would it be possible to unify? I think so, but it requires a bit of thinking.
That's why testing is very important in this kind of generic code.
Quoted 10 lines
lib/vsprintf.c +5
-0+ *p++ =']' ; + *p ='\0' ; + +return string_nocheck (buf, end, sym, spec); +}Also this is the bulk of the patch except for documentation and the new testing code. [new patch below]
Am I missing your point somehow?
See above.
Quoted 5 lines
I considered cramming a struct range into a
struct resource to letresource_string()process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.
No, that's not what I was expecting.
Quoted 1 line
Most importantly that would not be much less code AFAICT.
...
Quoted 1 line
+ %par [range 0x0000000060000000-0x000000006fffffff]
I still think this is not okay to use %pa namespace.
...
Quoted 7 lines
lib/test_printf.c +7
-0+static void __init +struct_range (void ) +{ +struct range test_range = { + .start =0xc0ffee00ba5eba11 , + .end =0xc0ffee00ba5eba11 , + };
lib/test_printf.c struct_resource(void) · line 407
Quoted 10 lines
lib/test_printf.c +10
-0+ +test ("[range 0xc0ffee00ba5eba11-0xc0ffee00ba5eba11]" , +"%par" , &test_range); + + test_range = (struct range ) { + .start =0xc0ffee , + .end =0xba5eba11 , + }; +test ("[range 0x0000000000c0ffee-0x00000000ba5eba11]" , +"%par" , &test_range);
Case when start == end?
Case when end < start?
Quoted 1 line
+}
...
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1158
Quoted 7 lines
lib/vsprintf.c +7
-0+ *p++ ='[' ; + p =string_nocheck (p, pend,"range " , default_str_spec); + p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + *p++ =']' ; + *p ='\0' ;
As per above comments.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Re: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 8 lines · Andy Shevchenko
Quoted 6 lines · Ira Weiny
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
[snip]
Quoted 18 lines
Quoted 10 lines
Quoted 3 lines
Quoted 3 lines
Quoted 3 lines
With that said, I'm not sure the %pa is a good placeholder for this ('a' stands to "address" AFAIU). Perhaps this should go somewhere under %pr/%pR?
I'm speaking a bit for Dan here but also the logical way I thought of things.
1) %p does not dictate anything about the format of the data. Rather indicates that what is passed is a pointer. Because we are passing a pointer to a range struct %pXX makes sense.
There is no objection to that.
Quoted 4 lines
2) %pa indicates what follows is 'address'. This was a bit of creative license because, as I said in the commit message most of the time struct range contains an address range. So for this narrow use case it also makes sense.
Quoted 8 lines
As in the discussion it was pointed out that struct range is always 64-bit, limiting it to the "address" is a wrong assumption as we are talking generic printing routine here. We don't know what users will be in the future on 32-bit platforms, or what data (semantically) is being held by this structure.
Quoted 1 line
3) %par r for range.
I understand, but again struct range != address.
Agreed.
Quoted 6 lines
Quoted 3 lines
%p[rR] is taken.
%pra confuses things IMO.It doesn't confuse me. :-) But I believe Petr also has a rationale behind this proposal as he described earlier.
%pra it is then.
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
Quoted 6 lines
The r/R in %pr/%pR actually stands for "resource".
But "%ra" really looks like a better choice than "%par". Both "resource" and "range" starts with 'r'. Also the struct resource is printed as a range of values.
Quoted 7 lines
Quoted 3 lines
%r could be used I think. But this breaks with the convention of passing a pointer and how to interpret it. The other idea I had, mentioned in the commit message was %pn. Meaning passed by pointer 'raNge'.
No, we can't use %r or anything else that is documented for the standard
printf()format specifiers, otherwise you will get a compiler warning and basically it means no go.
I was not thrilled with %r anyway.
Quoted 14 lines
Quoted 14 lines
I think that follows better than %r. That would be another break from C99. But we don't have to follow that.
Quoted 3 lines
Fine with me as long as it:
1) doesn't collide with %pa namespace
2) tries to deduplicate existing code as much as possible.Andy, I'm not quite following how you expect to share the code between
resource_string()andrange_string()?There is very little duplicated code. In fact with Petr's suggestions and some more work
range_string()is quite simple:
Quoted 11 lines
Review
Quoted 8 lines
(quoted diff) +8
-0+static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, + struct printf_spec spec, const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") + char sym[RANGE_DECODED_BUF_SIZE + RANGE_PRINT_BUF_SIZE]; + char *p = sym, *pend = sym + sizeof(sym);Missing check for pointer, but it's not that I wanted to tell.
No it was not missing. It was checked in address_val() already. However, with %pra I'll have to add it in.
Quoted 5 lines
Review
Quoted 3 lines
(quoted diff) +2
-0+ *p++ = '['; + p = string_nocheck(p, pend, "range ", default_str_spec);Hmm... %pr uses
str_spec, what the difference can be here?
str_spec is designed for variable length strings which are used based on the struct resource flags. Struct range does not vary so default_str_spec works.
Quoted 6 lines
Review
Quoted 4 lines
(quoted diff) +3
-0+ p = special_hex_number(p, pend, range->start, sizeof(range->start)); + *p++ = '-'; + p = special_hex_number(p, pend, range->end, sizeof(range->end));This is basically the copy of %pr implementation.
Only at a very basic level. struct resource has a variable spec while struct range does not. This causes complexity to make the code the same.
Quoted 8 lines
p = number(p, pend, res->start, *specp); if (res->start != res->end) { *p++ = '-'; p = number(p, pend, res->end, *specp); }Would it be possible to unify? I think so, but it requires a bit of thinking.
Not much thinking. But the issue is that they are not close enough to justify the extra complexity IMHO.
Making the outputs match with a common function takes 13 lines of code[1] including the declaration of a print specification which, as this thread already showed, is non-trivial to understand.
__Also__ this is currently crashing on me and I can't figure out why.
$ git diff --stat lib/vsprintf.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-)
OTOH to force a unified output, only takes 2 lines of duplicated code.[2] This is a very minor expense of duplicate code which is much easier to follow.
$ git diff --stat lib/vsprintf.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Quoted 2 lines
That's why testing is very important in this kind of generic code.
Yep. But the struct resource test was stubbed out. I've added some basic ones. But there are many more variations of struct resource prints. I'm not sure I've not broken them.
Quoted 14 lines
Quoted 11 lines
(quoted diff) +5
-0+ *p++ = ']'; + *p = '\0'; + + return string_nocheck(buf, end, sym, spec); +}Also this is the bulk of the patch except for documentation and the new testing code. [new patch below]
Am I missing your point somehow?
See above.
Quoted 7 lines
Quoted 5 lines
I considered cramming a struct range into a
struct resource to letresource_string()process the data. But that would involve creating a new IORESOURCE_* flag (not ideal) and also does not allow for the larger u64 data in struct range should this be a 32 bit physical address config.No, that's not what I was expecting.
Good.
Quoted 8 lines
Quoted 2 lines
Most importantly that would not be much less code AFAICT.
...
Quoted 1 line
+ %par [range 0x0000000060000000-0x000000006fffffff]
I still think this is not okay to use %pa namespace.
Agreed. Lets go with %pra
Quoted 14 lines
...
Quoted 11 lines
(quoted diff) +11
-0+static void __init +struct_range(void) +{ + struct range test_range = { + .start = 0xc0ffee00ba5eba11, + .end = 0xc0ffee00ba5eba11, + }; + + test("[range 0xc0ffee00ba5eba11-0xc0ffee00ba5eba11]", + "%par", &test_range); +
Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ test_range = (struct range) { + .start = 0xc0ffee, + .end = 0xba5eba11, + }; + test("[range 0x0000000000c0ffee-0x00000000ba5eba11]", + "%par", &test_range);Case when start == end?
Yes, that is the 1st case.
Quoted 1 line
Case when end < start?
I had no intention of having the output dictated by the values.
test("[range 0x0000000000c0ffee-0x0000000000c0ffee]",
and
test("[range 0x00000000ba5eba11-0x0000000000c0ffee]",... are acceptable to me.
Quoted 13 lines
Quoted 2 lines
+}
...
Review
Quoted 7 lines
(quoted diff) +7
-0+ *p++ = '['; + p = string_nocheck(p, pend, "range ", default_str_spec); + p = special_hex_number(p, pend, range->start, sizeof(range->start)); + *p++ = '-'; + p = special_hex_number(p, pend, range->end, sizeof(range->end)); + *p++ = ']'; + *p = '\0';
Quoted 1 line
As per above comments.
Thanks for the review,
Ira
[1] sample diff
lib/vsprintf.c +24 -8
@@ -1039,6 +1039,18 @@ static const struct printf_spec default_dec04_spec = { .flags = ZEROPAD, }; +static noinline_for_stack +char *hex_range(char *buf, char *end, u64 start_val, u64 end_val, +struct printf_spec spec) +{ + buf =number (buf, end, start_val, spec); +if (start_val != end_val) { + *buf++ ='-' ; + buf =number (buf, end, end_val, spec); + } +return buf; +} +static noinline_for_stack char *resource_string(char *buf, char *end, struct resource *res,struct printf_spec spec,const char *fmt)
@@ -1115,11 +1127,7 @@ char *resource_string(char *buf, char *end, struct resource *res, p =string_nocheck (p, pend,"size " , str_spec); p =number (p, pend,resource_size (res), *specp); }else { - p =number (p, pend, res->start, *specp); -if (res->start != res->end) { - *p++ ='-' ; - p =number (p, pend, res->end, *specp); - } + p =hex_range (p, pend, res->start, res->end, *specp); }if (decode) {if (res->flags &IORESOURCE_MEM_64 )
@@ -1149,11 +1157,19 @@ char *range_string(char *buf, char *end, const struct range *range,char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ];char *p = sym, *pend = sym +sizeof (sym); +struct printf_spec range_spec = { + spec.field_width =2 +2 *sizeof (range->start),/* 0x + 2 * u64 */ + spec.flags =SPECIAL |SMALL |ZEROPAD , + spec.base =16 , + spec.precision =-1 , + }; + +if (check_pointer (&buf, end, range, spec)) +return buf; + *p++ ='[' ; p =string_nocheck (p, pend,"range " , default_str_spec); - p =special_hex_number (p, pend, range->start,sizeof (range->start)); - *p++ ='-' ; - p =special_hex_number (p, pend, range->end,sizeof (range->end)); + p =hex_range (p, pend, range->start, range->end, range_spec); *p++ =']' ; *p ='\0' ;
[2] sample diff
lib/vsprintf.c +7 -2
@@ -1149,11 +1149,16 @@ char *range_string(char *buf, char *end, const struct range *range,char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ];char *p = sym, *pend = sym +sizeof (sym); +if (check_pointer (&buf, end, range, spec)) +return buf; + *p++ ='[' ; p =string_nocheck (p, pend,"range " , default_str_spec); p =special_hex_number (p, pend, range->start,sizeof (range->start)); - *p++ ='-' ; - p =special_hex_number (p, pend, range->end,sizeof (range->end)); +if (range->start != range->end) { + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + } *p++ =']' ; *p ='\0' ;
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 8 lines · Ira Weiny
Quoted 7 lines · Andy Shevchenko
Quoted 6 lines · Ira Weiny
Quoted 5 lines · Andy Shevchenko
Quoted 4 lines · Petr Mladek
Quoted 3 lines · Andy Shevchenko
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
[snip]
Quoted 10 lines
Quoted 9 lines
Review
Quoted 7 lines
(quoted diff) +7
-0+char *range_string(char *buf, char *end, const struct range *range, + struct printf_spec spec, const char *fmt) +{ +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range -]") + char sym[RANGE_DECODED_BUF_SIZE + RANGE_PRINT_BUF_SIZE]; + char *p = sym, *pend = sym + sizeof(sym);Missing check for pointer, but it's not that I wanted to tell.
Quoted 2 lines
No it was not missing. It was checked in
address_val()already. However, with %pra I'll have to add it in.
Ah, I haven't noticed the address_val() implementation details, thanks for elaborating!
Quoted 7 lines
Quoted 4 lines
Review
Quoted 2 lines
(quoted diff) +2
-0+ *p++ = '['; + p = string_nocheck(p, pend, "range ", default_str_spec);Hmm... %pr uses
str_spec, what the difference can be here?
str_specis designed for variable length strings which are used based on the struct resource flags. Struct range does not vary sodefault_str_specworks.
Okay, makes sense.
Quoted 8 lines
Quoted 5 lines
lib/vsprintf.c char *range_string(char *buf, char *end, const struct range *range, · line 1160
Quoted 3 lines
lib/vsprintf.c +3
-0+ p =special_hex_number (p, pend, range->start,sizeof (range->start)); + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end));This is basically the copy of %pr implementation.
Only at a very basic level. struct resource has a variable spec while struct range does not. This causes complexity to make the code the same.
Fair enough, that's why I said "as much as possible to deduplicate". If you think this is not worth it, let's do without an additional complications then.
Quoted 10 lines
Quoted 7 lines
p = number(p, pend, res->start, *specp); if (res->start != res->end) { *p++ = '-'; p = number(p, pend, res->end, *specp); }Would it be possible to unify? I think so, but it requires a bit of thinking.
Not much thinking. But the issue is that they are not close enough to justify the extra complexity IMHO.
Okay!
Quoted 10 lines
Making the outputs match with a common function takes 13 lines of code[1] including the declaration of a print specification which, as this thread already showed, is non-trivial to understand.
__Also__this is currently crashing on me and I can't figure out why.$ git diff --stat lib/vsprintf.c | 32 ++++++++++++++++++++++++-------- 1 file changed, 24 insertions(+), 8 deletions(-)
Quoted 6 lines
OTOH to force a unified output, only takes 2 lines of duplicated code.[2] This is a very minor expense of duplicate code which is much easier to follow.
$ git diff --stat lib/vsprintf.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-)
Yep, got it.
Quoted 5 lines
Quoted 1 line
That's why testing is very important in this kind of generic code.
Yep. But the struct resource test was stubbed out. I've added some basic ones. But there are many more variations of struct resource prints. I'm not sure I've not broken them.
Yeah, so make it then separated branches for %pr and %pra. You will take the correct argument type in each of them. There are existing examples there.
Probably an initial 'r'/'R' parsing should be moved to pointer().
Quoted 5 lines
Quoted 5 lines
Quoted 5 lines
(quoted diff) +5
-0+ *p++ = ']'; + *p = '\0'; + + return string_nocheck(buf, end, sym, spec); +}
...
Quoted 17 lines
Quoted 8 lines
Quoted 8 lines
(quoted diff) +8
-0+ struct range test_range = { + .start = 0xc0ffee00ba5eba11, + .end = 0xc0ffee00ba5eba11, + }; + + test("[range 0xc0ffee00ba5eba11-0xc0ffee00ba5eba11]", + "%par", &test_range); +Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ test_range = (struct range) { + .start = 0xc0ffee, + .end = 0xba5eba11, + }; + test("[range 0x0000000000c0ffee-0x00000000ba5eba11]", + "%par", &test_range);Case when start == end?
Quoted 1 line
Yes, that is the 1st case.
Thumb up!
Quoted 9 lines
Quoted 1 line
Case when end < start?
I had no intention of having the output dictated by the values.
test("[range 0x0000000000c0ffee-0x0000000000c0ffee]", and test("[range 0x00000000ba5eba11-0x0000000000c0ffee]",... are acceptable to me.
But it seems the %pr in the first case doesn't do range, just a single value, which makes sense to me (and this thread proved it) to avoid needless pedantic checking of each value. It means that at a glance you may tell start == end. Not sure about end < start case, but the point is just let's make it mimicing %pr behaviour.
...
Quoted 29 lines
lib/vsprintf.c +13
-5+static noinline_for_stack +char *hex_range(char *buf, char *end, u64 start_val, u64 end_val, +struct printf_spec spec) +{ + buf =number (buf, end, start_val, spec); +if (start_val != end_val) { + *buf++ ='-' ; + buf =number (buf, end, end_val, spec); + } +return buf; +} +static noinline_for_stack char *resource_string(char *buf, char *end, struct resource *res,struct printf_spec spec,const char *fmt)@@ -1115,11 +1127,7 @@ char *resource_string(char *buf, char *end, struct resource *res, p =string_nocheck (p, pend,"size " , str_spec); p =number (p, pend,resource_size (res), *specp); }else { - p =number (p, pend, res->start, *specp); -if (res->start != res->end) { - *p++ ='-' ; - p =number (p, pend, res->end, *specp); - } + p =hex_range (p, pend, res->start, res->end, *specp); }if (decode) {if (res->flags &IORESOURCE_MEM_64 )
lib/vsprintf.c char *range_string(char *buf, char *end, const struct range *range, · line 1165
Quoted 9 lines
lib/vsprintf.c +6
-0@@ -1149,11 +1157,19 @@ char *range_string(char *buf, char *end, const struct range *range,char sym[RANGE_DECODED_BUF_SIZE +RANGE_PRINT_BUF_SIZE ];char *p = sym, *pend = sym +sizeof (sym); +struct printf_spec range_spec = { + spec.field_width =2 +2 *sizeof (range->start),/* 0x + 2 * u64 */ + spec.flags =SPECIAL |SMALL |ZEROPAD , + spec.base =16 , + spec.precision =-1 , + };
But this can be deduplicated from special_hex_number(), no? Something like
fill_special_hex_number_spec()
{
}
special_hex_number()
{
fill_special_hex_number_spec();
}special_hex_range()
{
fill_special_hex_number_spec();
}Would it be better?
lib/vsprintf.c char *range_string(char *buf, char *end, const struct range *range, · line 1174
Quoted 11 lines
lib/vsprintf.c +4
-3+if (check_pointer (&buf, end, range, spec)) +return buf; + *p++ ='[' ; p =string_nocheck (p, pend,"range " , default_str_spec); - p =special_hex_number (p, pend, range->start,sizeof (range->start)); - *p++ ='-' ; - p =special_hex_number (p, pend, range->end,sizeof (range->end)); + p =hex_range (p, pend, range->start, range->end, range_spec); *p++ =']' ; *p ='\0' ;
so, can you check if with the above implemented we can actually enforce unified format for %pr and %pra?
...
lib/vsprintf.c char *range_string(char *buf, char *end, const struct range *range, · line 1161
Quoted 9 lines
[2] sample diff
p = special_hex_number(p, pend, range->start, sizeof(range->start));lib/vsprintf.c +4
-2- *p++ ='-' ; - p =special_hex_number (p, pend, range->end,sizeof (range->end)); +if (range->start != range->end) { + *p++ ='-' ; + p =special_hex_number (p, pend, range->end,sizeof (range->end)); + }
There is a possibility to supply a callback, but it seems to me much overcomplicated approach.
...
If we go the second way (the latter one here) can you add a comment in both %pr/%pra code excerpts to point to each other that the format is unified between them? It might help in the future to optimise the code if needed at all.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Petr Mladek
maintainerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
In reply to Ira WeinyQuoted 29 lines · Ira Weiny
Quoted 28 lines · Petr Mladek
Quoted 27 lines · Ira Weiny
The use of struct range in the CXL subsystem is growing. In particular, the addition of Dynamic Capacity devices uses struct range in a number of places which are reported in debug and error messages.
To wit requiring the printing of the start/end fields in each print became cumbersome. Dan Williams mentions in [1] that it might be time to have a print specifier for struct range similar to struct resource
A few alternatives were considered including '%pn' for 'print raNge' but %par follows that struct range is most often used to store a range of physical addresses. So use '%par' for 'print address range'.
lib/vsprintf.c +7
-0@@ -1140,6 +1140,39 @@ char *resource_string(char *buf, char *end, struct resource *res,return string_nocheck (buf, end, sym, spec); } +static noinline_for_stack +char *range_string(char *buf, char *end, const struct range *range, +struct printf_spec spec,const char *fmt) +{ +#define RANGE_PRINTK_SIZE 16 +#define RANGE_DECODED_BUF_SIZE ((2 * sizeof(struct range)) + 4) +#define RANGE_PRINT_BUF_SIZE sizeof("[range - ]")
[...]
Quoted 7 lines
Quoted 3 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1160
Quoted 3 lines
lib/vsprintf.c +3
-0+static const struct printf_spec range_spec = { + .base =16 , + .field_width =RANGE_PRINTK_SIZE ,However, my testing indicates this needs to be.
.field_width = 18, /* 2 (0x) + 2 * 8 (bytes) */
Makes sense. Great catch!
Quoted 13 lines
... to properly zero pad the value. Does that make sense?
Quoted 11 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1171
Quoted 11 lines
lib/vsprintf.c +11
-0+ .precision = -1, + .flags = SPECIAL | SMALL | ZEROPAD, + }; + + *p++ ='[' ; + p =string_nocheck (p, pend,"range " , str_spec); + p =number (p, pend, range->start, range_spec); + *p++ ='-' ; + p =number (p, pend, range->end, range_spec); + *p++ =']' ; + *p ='\0' ;
Best Regards,
Petr
Andy Shevchenko
reviewerRe: [PATCH v3 02/25] printk: Add print format (%par) for struct range
Quoted 3 lines · Petr Mladek
Quoted 2 lines · Ira Weiny
Quoted 1 line · Petr Mladek
On Fri 2024-08-16 09:44:10, Ira Weiny wrote:
[...]
Quoted 9 lines
Quoted 7 lines
Quoted 3 lines
lib/vsprintf.c char *resource_string(char *buf, char *end, struct resource *res, · line 1160
Quoted 3 lines
lib/vsprintf.c +3
-0+static const struct printf_spec range_spec = { + .base =16 , + .field_width =RANGE_PRINTK_SIZE ,However, my testing indicates this needs to be.
.field_width = 18, /* 2 (0x) + 2 * 8 (bytes) */Makes sense. Great catch!
Which effectively means usage of special_hex_number(). But again, consider to unite this with %pR/r implementation(s).
Quoted 5 lines
Quoted 5 lines
... to properly zero pad the value. Does that make sense?
Quoted 3 lines
Quoted 3 lines
lib/vsprintf.c +3
-0+ .precision = -1, + .flags = SPECIAL | SMALL | ZEROPAD, + };
Signature · 2 lines
With Best Regards, Andy Shevchenko
PATCH v3 3/25 dax: Document dax dev range tuple
In reply to Ira WeinyThe device DAX structure is being enhanced to track additional DCD information.
The current range tuple was not fully documented. Document it prior to adding information for DC.
---
Changes:
[iweiny: move to start of series]
--- drivers/dax/dax-private.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
drivers/dax/dax-private.h +4 -1
@@ -58,7 +58,10 @@ struct dax_mapping {* @dev - device core * @pgmap - pgmap for memmap setup / lifetime (driver owned) * @nr_range: size of @ranges -* @ranges: resource-span + pgoff tuples for the instance +* @ranges: range tuples of memory used +* @pgoff: page offset +* @range: resource-span +* @mapping: device to assist in interrogating the range layout */ struct dev_dax {struct dax_region *region;
Signature · 1 line
2.45.2
Re: [PATCH v3 03/25] dax: Document dax dev range tuple
Quoted 8 lines · Ira Weiny
The device DAX structure is being enhanced to track additional DCD information.
The current range tuple was not fully documented. Document it prior to adding information for DC.
Suggested-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 25 lines
---
Changes:
[iweiny: move to start of series]--- drivers/dax/dax-private.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/dax/dax-private.h +4
-1@@ -58,7 +58,10 @@ struct dax_mapping {* @dev - device core * @pgmap - pgmap for memmap setup / lifetime (driver owned) * @nr_range: size of @ranges -* @ranges: resource-span + pgoff tuples for the instance +* @ranges: range tuples of memory used +* @pgoff: page offset +* @range: resource-span +* @mapping: device to assist in interrogating the range layout */ struct dev_dax {struct dax_region *region;
Re: [PATCH v3 03/25] dax: Document dax dev range tuple
In reply to Ira WeinyQuoted 21 lines · On Fri, 16 Aug 2024 09:44:11 -0500 Ira Weiny <[email protected]> wrote:
The device DAX structure is being enhanced to track additional DCD information.
The current range tuple was not fully documented. Document it prior to adding information for DC.
Suggested-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: move to start of series]--- drivers/dax/dax-private.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)drivers/dax/dax-private.h +0
-0
drivers/dax/dax-private.h struct dax_mapping { · line 64
Quoted 8 lines
drivers/dax/dax-private.h +4
-1@@ -58,7 +58,10 @@ struct dax_mapping {* @dev - device core * @pgmap - pgmap for memmap setup / lifetime (driver owned) * @nr_range: size of @ranges -* @ranges: resource-span + pgoff tuples for the instance +* @ranges: range tuples of memory used +* @pgoff: page offset +* @range: resource-span +* @mapping: device to assist in interrogating the range layout
I think the kernel doc format for this should be
@ranges.pgoff: etc
https://docs.kernel.org/doc-guide/kernel-doc.html#nested-structs-unions
Though not quite sure what happens for pointers to structures, maybe this is correct as it stands?
Quoted 4 lines
drivers/dax/dax-private.h +0
-0*/ struct dev_dax {struct dax_region *region;
PATCH v3 4/25 cxl/pci: Delay event buffer allocation
In reply to Ira WeinyThe event buffer does not need to be allocated if something has failed in setting up event irq's.
In prep for adjusting event configuration for DCD events move the buffer allocation to the end of the event configuration.
---
Changes:
[iweiny: keep tags for early simple patch] [Davidlohr, Jonathan, djiang: move to beginning of series]
[Dave feel free to pick this up if you like]
--- drivers/cxl/pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/cxl/pci.c +4 -4
@@ -760,10 +760,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return 0 ; } - rc =cxl_mem_alloc_event_buf (mds); -if (rc) -return rc; - rc =cxl_event_get_int_policy (mds, &policy);if (rc)return rc;
@@ -777,6 +773,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return -EBUSY ; } + rc =cxl_mem_alloc_event_buf (mds); +if (rc) +return rc; + rc =cxl_event_irqsetup (mds);if (rc)return rc;
Signature · 1 line
2.45.2
Re: [PATCH v3 04/25] cxl/pci: Delay event buffer allocation
Quoted 10 lines · Ira Weiny
The event buffer does not need to be allocated if something has failed in setting up event irq's.
In prep for adjusting event configuration for DCD events move the buffer allocation to the end of the event configuration.
Reviewed-by Davidlohr Bueso <[email protected]>Reviewed-by Dave Jiang <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Re: [PATCH v3 04/25] cxl/pci: Delay event buffer allocation
In reply to Ira WeinyQuoted 6 lines · Ira Weiny
The event buffer does not need to be allocated if something has failed in setting up event irq's.
In prep for adjusting event configuration for DCD events move the buffer allocation to the end of the event configuration.
Quoted 6 lines
Reviewed-by Davidlohr Bueso <[email protected]>Reviewed-by Dave Jiang <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Quoted 38 lines
Changes:
[iweiny: keep tags for early simple patch] [Davidlohr, Jonathan, djiang: move to beginning of series]
[Dave feel free to pick this up if you like]--- drivers/cxl/pci.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/cxl/pci.c +4
-4@@ -760,10 +760,6 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return 0 ; } - rc =cxl_mem_alloc_event_buf (mds); -if (rc) -return rc; - rc =cxl_event_get_int_policy (mds, &policy);if (rc)return rc;@@ -777,6 +773,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return -EBUSY ; } + rc =cxl_mem_alloc_event_buf (mds); +if (rc) +return rc; + rc =cxl_event_irqsetup (mds);if (rc)return rc;Signature · 2 lines
-- 2.45.2
PATCH v3 5/25 cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Per the CXL 3.1 specification software must check the Command Effects Log (CEL) for dynamic capacity command support.
Detect support for the DCD commands while reading the CEL, including:
Get DC Config
Get DC Extent List
Add DC Response
Release DC
---
Changes:
[iweiny: Keep tags for this early simple patch]
[Davidlohr: update commit message]
[djiang: Fix misalignment]
--- drivers/cxl/core/mbox.c | 33 +++++++++++++++++++++++++++++++++ drivers/cxl/cxlmem.h | 15 +++++++++++++++ 2 files changed, 48 insertions(+)
drivers/cxl/core/mbox.c +33 -0
@@ -164,6 +164,34 @@ static void cxl_set_security_cmd_enabled(struct cxl_security_state *security, } } +static bool cxl_is_dcd_command (u16 opcode) +{ +#define CXL_MBOX_OP_DCD_CMDS 0x48 + +return (opcode >>8 ) ==CXL_MBOX_OP_DCD_CMDS ; +} + +static void cxl_set_dcd_cmd_enabled (struct cxl_memdev_state *mds, +u16 opcode) +{ +switch (opcode) { +case CXL_MBOX_OP_GET_DC_CONFIG : +set_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +break ; +case CXL_MBOX_OP_GET_DC_EXTENT_LIST : +set_bit (CXL_DCD_ENABLED_GET_EXTENT_LIST , mds->dcd_cmds); +break ; +case CXL_MBOX_OP_ADD_DC_RESPONSE : +set_bit (CXL_DCD_ENABLED_ADD_RESPONSE , mds->dcd_cmds); +break ; +case CXL_MBOX_OP_RELEASE_DC : +set_bit (CXL_DCD_ENABLED_RELEASE , mds->dcd_cmds); +break ; +default : +break ; + } +} +static bool cxl_is_poison_command (u16 opcode) {#define CXL_MBOX_OP_POISON_CMDS 0x43
@@ -745,6 +773,11 @@ static void cxl_walk_cel(struct cxl_memdev_state *mds, size_t size, u8 *cel) enabled++; } +if (cxl_is_dcd_command (opcode)) { +cxl_set_dcd_cmd_enabled (mds, opcode); + enabled++; + } +dev_dbg (dev,"Opcode 0x%04x %s\n" , opcode, enabled ?"enabled" :"unsupported by driver" ); }
drivers/cxl/cxlmem.h +15 -0
@@ -238,6 +238,15 @@ struct cxl_event_state {struct mutex log_lock; }; +/* Device enabled DCD commands */ +enum dcd_cmd_enabled_bits { +CXL_DCD_ENABLED_GET_CONFIG , +CXL_DCD_ENABLED_GET_EXTENT_LIST , +CXL_DCD_ENABLED_ADD_RESPONSE , +CXL_DCD_ENABLED_RELEASE , +CXL_DCD_ENABLED_MAX +}; +/* Device enabled poison commands */ enum poison_cmd_enabled_bits {CXL_POISON_ENABLED_LIST ,
@@ -454,6 +463,7 @@ struct cxl_dev_state {* (CXL 2.0 8.2.9.5.1.1 Identify Memory Device) * @mbox_mutex: Mutex to synchronize mailbox access. * @firmware_version: Firmware version for the memory device. +* @dcd_cmds: List of DCD commands implemented by memory device * @enabled_cmds: Hardware commands found enabled in CEL. * @exclusive_cmds: Commands that are kernel-internal only * @total_bytes: sum of all possible capacities
@@ -482,6 +492,7 @@ struct cxl_memdev_state {size_t lsa_size;struct mutex mbox_mutex;/* Protects device mailbox and firmware */ char firmware_version[0x10 ]; +DECLARE_BITMAP (dcd_cmds,CXL_DCD_ENABLED_MAX );DECLARE_BITMAP (enabled_cmds,CXL_MEM_COMMAND_ID_MAX );DECLARE_BITMAP (exclusive_cmds,CXL_MEM_COMMAND_ID_MAX );u64 total_bytes;
@@ -555,6 +566,10 @@ enum cxl_opcode {CXL_MBOX_OP_UNLOCK =0x4503 ,CXL_MBOX_OP_FREEZE_SECURITY =0x4504 ,CXL_MBOX_OP_PASSPHRASE_SECURE_ERASE =0x4505 , +CXL_MBOX_OP_GET_DC_CONFIG =0x4800 , +CXL_MBOX_OP_GET_DC_EXTENT_LIST =0x4801 , +CXL_MBOX_OP_ADD_DC_RESPONSE =0x4802 , +CXL_MBOX_OP_RELEASE_DC =0x4803 , CXL_MBOX_OP_MAX = 0x10000 };
Signature · 1 line
2.45.2
Re: [PATCH v3 05/25] cxl/mbox: Flag support for Dynamic Capacity Devices (DCD)
Quoted 12 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Per the CXL 3.1 specification software must check the Command Effects Log (CEL) for dynamic capacity command support.
Detect support for the DCD commands while reading the CEL, including:
Get DC Config
Get DC Extent List
Add DC Response
Release DC
Quoted 8 lines
Signed-off-by Navneet Singh <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>Reviewed-by Fan Ni <[email protected]>Reviewed-by Dave Jiang <[email protected]>Reviewed-by Davidlohr Bueso <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 6/25 cxl/mem: Read dynamic capacity configuration from the device
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Devices which optionally support Dynamic Capacity (DC) are configured via mailbox commands. CXL 3.1 requires the host to issue the Get DC Configuration command in order to properly configure DCDs. Without the Get DC Configuration command DCD can't be supported.
Implement the DC mailbox commands as specified in CXL 3.1 section 8.2.9.9.9 (opcodes 48XXh) to read and store the DCD configuration information. Disable DCD if DCD is not supported. Leverage the Get DC Configuration command supported bit to indicate if DCD support.
Linux has no use for the trailing fields of the Get Dynamic Capacity Configuration Output Payload (Total number of supported extents, number of available extents, total number of supported tags, and number of available tags). Avoid defining those fields to use the more useful dynamic C array.
---
Changes:
[Li, Ming: Fix bug in total_bytes calculation]
[iweiny: update commit message]
[Jonathan: fix formatting]
[Jonathan: Define block line size]
[Jonathan/Fan: use regions returned field instead of macro in get config] [Jørgen: Rename memdev state range variables]
[Jonathan: adjust use of rc in cxl_dev_dynamic_capacity_identify()] [Jonathan: white space cleanup]
[fan: make a comment about the trailing configuration output fields]
--- drivers/cxl/core/mbox.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++- drivers/cxl/cxlmem.h | 64 +++++++++++++++++- drivers/cxl/pci.c | 4 ++ 3 files changed, 237 insertions(+), 2 deletions(-)
drivers/cxl/core/mbox.c +170 -1
@@ -1157,7 +1157,7 @@ int cxl_dev_state_identify(struct cxl_memdev_state *mds)if (rc <0 )return rc; - mds->total_bytes = + mds->static_bytes =le64_to_cpu (id.total_capacity) *CXL_CAPACITY_MULTIPLIER ; mds->volatile_only_bytes =le64_to_cpu (id.volatile_capacity) *CXL_CAPACITY_MULTIPLIER ;
@@ -1264,6 +1264,159 @@ int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd)return rc; } +static int cxl_dc_save_region_info (struct cxl_memdev_state *mds,u8 index, +struct cxl_dc_region_config *region_config) +{ +struct cxl_dc_region_info *dcr = &mds->dc_region[index]; +struct device *dev = mds->cxlds.dev; + + dcr->base =le64_to_cpu (region_config->region_base); + dcr->decode_len =le64_to_cpu (region_config->region_decode_length); + dcr->decode_len *=CXL_CAPACITY_MULTIPLIER ; + dcr->len =le64_to_cpu (region_config->region_length); + dcr->blk_size =le64_to_cpu (region_config->region_block_size); + dcr->dsmad_handle =le32_to_cpu (region_config->region_dsmad_handle); + dcr->flags = region_config->flags; +snprintf (dcr->name,CXL_DC_REGION_STRLEN ,"dc%d" , index); + +/* Check regions are in increasing DPA order */ +if (index >0 ) { +struct cxl_dc_region_info *prev_dcr = &mds->dc_region[index -1 ]; + +if ((prev_dcr->base + prev_dcr->decode_len) > dcr->base) { +dev_err (dev, +"DPA ordering violation for DC region %d and %d\n" , + index -1 , index); +return -EINVAL ; + } + } + +if (!IS_ALIGNED (dcr->base,SZ_256M ) || + !IS_ALIGNED (dcr->base, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid base %#llx blk size %#llx\n" , + index, dcr->base, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->decode_len ==0 || dcr->len ==0 || dcr->decode_len < dcr->len || + !IS_ALIGNED (dcr->len, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid length; decode %#llx len %#llx blk size %#llx\n" , + index, dcr->decode_len, dcr->len, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->blk_size ==0 || dcr->blk_size %CXL_DCD_BLOCK_LINE_SIZE || + !is_power_of_2 (dcr->blk_size)) { +dev_err (dev,"DC region %d invalid block size; %#llx\n" , + index, dcr->blk_size); +return -EINVAL ; + } + +dev_dbg (dev, +"DC region %s base %#llx length %#llx block size %#llx\n" , + dcr->name, dcr->base, dcr->decode_len, dcr->blk_size); + +return 0 ; +} + +/* Returns the number of regions in dc_resp or -ERRNO */ +static int cxl_get_dc_config (struct cxl_memdev_state *mds,u8 start_region, +struct cxl_mbox_get_dc_config_out *dc_resp, +size_t dc_resp_size) +{ +struct cxl_mbox_get_dc_config_in get_dc = (struct cxl_mbox_get_dc_config_in ) { + .region_count =CXL_MAX_DC_REGION , + .start_region_index = start_region, + }; +struct cxl_mbox_cmd mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode =CXL_MBOX_OP_GET_DC_CONFIG , + .payload_in = &get_dc, + .size_in =sizeof (get_dc), + .size_out = dc_resp_size, + .payload_out = dc_resp, + .min_out =1 , + }; +struct device *dev = mds->cxlds.dev; +int rc; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc <0 ) +return rc; + +dev_dbg (dev,"Read %d/%d DC regions\n" , + dc_resp->regions_returned, dc_resp->avail_region_count); +return dc_resp->regions_returned; +} + +/** +* cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity +* information from the device. +* @mds: The memory device state +* +* Read Dynamic Capacity information from the device and populate the state +* structures for later use. +* +* Return: 0 if identify was executed successfully, -ERRNO on error. +*/ +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds) +{ +size_t dc_resp_size = mds->payload_size; +struct device *dev = mds->cxlds.dev; +u8 start_region, i; + +for (i =0 ; i <CXL_MAX_DC_REGION ; i++) +snprintf (mds->dc_region[i].name,CXL_DC_REGION_STRLEN ,"<nil>" ); + +if (!cxl_dcd_supported (mds)) { +dev_dbg (dev,"DCD not supported\n" ); +return 0 ; + } + + struct cxl_mbox_get_dc_config_out *dc_resp __free(kfree) = +kvmalloc (dc_resp_size,GFP_KERNEL ); +if (!dc_resp) +return -ENOMEM ; + + start_region =0 ; +do { +int rc, j; + + rc =cxl_get_dc_config (mds, start_region, dc_resp, dc_resp_size); +if (rc <0 ) { +dev_dbg (dev,"Failed to get DC config: %d\n" , rc); +return rc; + } + + mds->nr_dc_region += rc; + +if (mds->nr_dc_region <1 || mds->nr_dc_region >CXL_MAX_DC_REGION ) { +dev_err (dev,"Invalid num of dynamic capacity regions %d\n" , + mds->nr_dc_region); +return -EINVAL ; + } + +for (i = start_region, j =0 ; i < mds->nr_dc_region; i++, j++) { + rc =cxl_dc_save_region_info (mds, i, &dc_resp->region[j]); +if (rc) { +dev_dbg (dev,"Failed to save region info: %d\n" , rc); +return rc; + } + } + + start_region = mds->nr_dc_region; + + }while (mds->nr_dc_region < dc_resp->avail_region_count); + + mds->dynamic_bytes = + mds->dc_region[mds->nr_dc_region -1 ].base + + mds->dc_region[mds->nr_dc_region -1 ].decode_len - + mds->dc_region[0 ].base; +dev_dbg (dev,"Total dynamic range: %#llx\n" , mds->dynamic_bytes); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (cxl_dev_dynamic_capacity_identify,CXL ); +static int add_dpa_res (struct device *dev,struct resource *parent,struct resource *res,resource_size_t start,resource_size_t size,const char *type)
@@ -1294,8 +1447,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) {struct cxl_dev_state *cxlds = &mds->cxlds;struct device *dev = cxlds->dev; +size_t untenanted_mem;int rc; + mds->total_bytes = mds->static_bytes; +if (mds->nr_dc_region) { + untenanted_mem = mds->dc_region[0 ].base - mds->static_bytes; + mds->total_bytes += untenanted_mem + mds->dynamic_bytes; + } +if (!cxlds->media_ready) { cxlds->dpa_res =DEFINE_RES_MEM (0 ,0 ); cxlds->ram_res =DEFINE_RES_MEM (0 ,0 );
@@ -1305,6 +1465,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) cxlds->dpa_res =DEFINE_RES_MEM (0 , mds->total_bytes); +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; + + rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->dc_res[i], + dcr->base, dcr->decode_len, dcr->name); +if (rc) +return rc; + } +if (mds->partition_align_bytes ==0 ) { rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->ram_res,0 , mds->volatile_only_bytes,"ram" );
drivers/cxl/cxlmem.h +63 -1
128 lines not on this page · raw message
drivers/cxl/pci.c +4 -0
@@ -874,6 +874,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (rc)return rc; + rc =cxl_dev_dynamic_capacity_identify (mds); +if (rc) +cxl_disable_dcd (mds); + rc =cxl_mem_create_range_info (mds);if (rc)return rc;
Signature · 1 line
2.45.2
Dave Jiang
maintainerRe: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device
Quoted 154 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Devices which optionally support Dynamic Capacity (DC) are configured via mailbox commands. CXL 3.1 requires the host to issue the Get DC Configuration command in order to properly configure DCDs. Without the Get DC Configuration command DCD can't be supported.
Implement the DC mailbox commands as specified in CXL 3.1 section 8.2.9.9.9 (opcodes 48XXh) to read and store the DCD configuration information. Disable DCD if DCD is not supported. Leverage the Get DC Configuration command supported bit to indicate if DCD support.
Linux has no use for the trailing fields of the Get Dynamic Capacity Configuration Output Payload (Total number of supported extents, number of available extents, total number of supported tags, and number of available tags). Avoid defining those fields to use the more useful dynamic C array.
Cc "Li, Ming" <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[Li, Ming: Fix bug intotal_bytescalculation]
[iweiny: update commit message]
[Jonathan: fix formatting]
[Jonathan: Define block line size]
[Jonathan/Fan: use regions returned field instead of macro in get config] [Jørgen: Rename memdev state range variables]
[Jonathan: adjust use of rc incxl_dev_dynamic_capacity_identify()] [Jonathan: white space cleanup]
[fan: make a comment about the trailing configuration output fields]--- drivers/cxl/core/mbox.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++- drivers/cxl/cxlmem.h | 64 +++++++++++++++++- drivers/cxl/pci.c | 4 ++ 3 files changed, 237 insertions(+), 2 deletions(-)drivers/cxl/core/mbox.c +98
-1@@ -1157,7 +1157,7 @@ int cxl_dev_state_identify(struct cxl_memdev_state *mds)if (rc <0 )return rc; - mds->total_bytes = + mds->static_bytes =le64_to_cpu (id.total_capacity) *CXL_CAPACITY_MULTIPLIER ; mds->volatile_only_bytes =le64_to_cpu (id.volatile_capacity) *CXL_CAPACITY_MULTIPLIER ;@@ -1264,6 +1264,159 @@ int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd)return rc; } +static int cxl_dc_save_region_info (struct cxl_memdev_state *mds,u8 index, +struct cxl_dc_region_config *region_config) +{ +struct cxl_dc_region_info *dcr = &mds->dc_region[index]; +struct device *dev = mds->cxlds.dev; + + dcr->base =le64_to_cpu (region_config->region_base); + dcr->decode_len =le64_to_cpu (region_config->region_decode_length); + dcr->decode_len *=CXL_CAPACITY_MULTIPLIER ; + dcr->len =le64_to_cpu (region_config->region_length); + dcr->blk_size =le64_to_cpu (region_config->region_block_size); + dcr->dsmad_handle =le32_to_cpu (region_config->region_dsmad_handle); + dcr->flags = region_config->flags; +snprintf (dcr->name,CXL_DC_REGION_STRLEN ,"dc%d" , index); + +/* Check regions are in increasing DPA order */ +if (index >0 ) { +struct cxl_dc_region_info *prev_dcr = &mds->dc_region[index -1 ]; + +if ((prev_dcr->base + prev_dcr->decode_len) > dcr->base) { +dev_err (dev, +"DPA ordering violation for DC region %d and %d\n" , + index -1 , index); +return -EINVAL ; + } + } + +if (!IS_ALIGNED (dcr->base,SZ_256M ) || + !IS_ALIGNED (dcr->base, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid base %#llx blk size %#llx\n" , + index, dcr->base, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->decode_len ==0 || dcr->len ==0 || dcr->decode_len < dcr->len || + !IS_ALIGNED (dcr->len, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid length; decode %#llx len %#llx blk size %#llx\n" , + index, dcr->decode_len, dcr->len, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->blk_size ==0 || dcr->blk_size %CXL_DCD_BLOCK_LINE_SIZE || + !is_power_of_2 (dcr->blk_size)) { +dev_err (dev,"DC region %d invalid block size; %#llx\n" , + index, dcr->blk_size); +return -EINVAL ; + } + +dev_dbg (dev, +"DC region %s base %#llx length %#llx block size %#llx\n" , + dcr->name, dcr->base, dcr->decode_len, dcr->blk_size); + +return 0 ; +} + +/* Returns the number of regions in dc_resp or -ERRNO */ +static int cxl_get_dc_config (struct cxl_memdev_state *mds,u8 start_region, +struct cxl_mbox_get_dc_config_out *dc_resp, +size_t dc_resp_size) +{ +struct cxl_mbox_get_dc_config_in get_dc = (struct cxl_mbox_get_dc_config_in ) { + .region_count =CXL_MAX_DC_REGION , + .start_region_index = start_region, + }; +struct cxl_mbox_cmd mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode =CXL_MBOX_OP_GET_DC_CONFIG , + .payload_in = &get_dc, + .size_in =sizeof (get_dc), + .size_out = dc_resp_size, + .payload_out = dc_resp, + .min_out =1 , + }; +struct device *dev = mds->cxlds.dev; +int rc; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc <0 ) +return rc; + +dev_dbg (dev,"Read %d/%d DC regions\n" , + dc_resp->regions_returned, dc_resp->avail_region_count); +return dc_resp->regions_returned; +} + +/** +* cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity +* information from the device. +* @mds: The memory device state +* +* Read Dynamic Capacity information from the device and populate the state +* structures for later use. +* +* Return: 0 if identify was executed successfully, -ERRNO on error. +*/ +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds) +{ +size_t dc_resp_size = mds->payload_size;
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1373
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+struct device *dev = mds->cxlds.dev; +u8 start_region, i; + +for (i =0 ; i <CXL_MAX_DC_REGION ; i++) +snprintf (mds->dc_region[i].name,CXL_DC_REGION_STRLEN ,"<nil>" ); + +if (!cxl_dcd_supported (mds)) { +dev_dbg (dev,"DCD not supported\n" ); +return 0 ; + }
This should happen before you pre-format the name string? I would assume that if DCD is not supported then the dcd name sysfs attribs would be not be visible?
Quoted 15 lines
drivers/cxl/core/mbox.c +15
-0+ + struct cxl_mbox_get_dc_config_out *dc_resp __free(kfree) = +kvmalloc (dc_resp_size,GFP_KERNEL ); +if (!dc_resp) +return -ENOMEM ; + + start_region =0 ; + do { + int rc, j; + + rc = cxl_get_dc_config(mds, start_region, dc_resp, dc_resp_size); + if (rc < 0) { + dev_dbg(dev, "Failed to get DC config: %d\n", rc); + return rc; + }
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1398
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ + mds->nr_dc_region += rc; + +if (mds->nr_dc_region <1 || mds->nr_dc_region >CXL_MAX_DC_REGION ) { +dev_err (dev,"Invalid num of dynamic capacity regions %d\n" , + mds->nr_dc_region); +return -EINVAL ; + } + +for (i = start_region, j =0 ; i < mds->nr_dc_region; i++, j++) {
This should be 'j < mds->nr_dc_region'? Otherwise if your start region say is '3' and you have '2' DC regions, you never enter the loop. Or does that not happen? I also wonder if you need to check if 'start_region + mds->nr_dc_region > CXL_MAX_DC_REGION'.
Quoted 85 lines
drivers/cxl/core/mbox.c +37
-0+ rc =cxl_dc_save_region_info (mds, i, &dc_resp->region[j]); +if (rc) { +dev_dbg (dev,"Failed to save region info: %d\n" , rc); +return rc; + } + } + + start_region = mds->nr_dc_region; + + }while (mds->nr_dc_region < dc_resp->avail_region_count); + + mds->dynamic_bytes = + mds->dc_region[mds->nr_dc_region -1 ].base + + mds->dc_region[mds->nr_dc_region -1 ].decode_len - + mds->dc_region[0 ].base; +dev_dbg (dev,"Total dynamic range: %#llx\n" , mds->dynamic_bytes); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (cxl_dev_dynamic_capacity_identify,CXL ); +static int add_dpa_res (struct device *dev,struct resource *parent,struct resource *res,resource_size_t start,resource_size_t size,const char *type)@@ -1294,8 +1447,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) {struct cxl_dev_state *cxlds = &mds->cxlds;struct device *dev = cxlds->dev; +size_t untenanted_mem;int rc; + mds->total_bytes = mds->static_bytes; +if (mds->nr_dc_region) { + untenanted_mem = mds->dc_region[0 ].base - mds->static_bytes; + mds->total_bytes += untenanted_mem + mds->dynamic_bytes; + } +if (!cxlds->media_ready) { cxlds->dpa_res =DEFINE_RES_MEM (0 ,0 ); cxlds->ram_res =DEFINE_RES_MEM (0 ,0 );@@ -1305,6 +1465,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) cxlds->dpa_res =DEFINE_RES_MEM (0 , mds->total_bytes); +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; + + rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->dc_res[i], + dcr->base, dcr->decode_len, dcr->name); +if (rc) +return rc; + } +if (mds->partition_align_bytes ==0 ) { rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->ram_res,0 , mds->volatile_only_bytes,"ram" );drivers/cxl/cxlmem.h +4
-0@@ -402,6 +402,7 @@ enum cxl_devtype { CXL_DEVTYPE_CLASSMEM, }; +#define CXL_MAX_DC_REGION 8/** * struct cxl_dpa_perf - DPA performance property entry * @dpa_range: range for DPA address @@ -431,6 +432,8 @@ struct cxl_dpa_perf {* @dpa_res: Overall DPA resource tree for the device * @pmem_res: Active Persistent memory capacity configuration * @ram_res: Active Volatile memory capacity configuration +* @dc_res: Active Dynamic Capacity memory configuration for each possible +* region * @serial: PCIe Device Serial Number * @type: Generic Memory Class device or Vendor Specific Memory device */ @@ -445,10 +448,22 @@ struct cxl_dev_state {struct resource dpa_res;struct resource pmem_res;struct resource ram_res; +struct resource dc_res[CXL_MAX_DC_REGION ];u64 serial;enum cxl_devtype type; };
drivers/cxl/cxlmem.h struct cxl_dev_state { · line 464
Quoted 10 lines
drivers/cxl/cxlmem.h +9
-0+#define CXL_DC_REGION_STRLEN > +struct cxl_dc_region_info { +u64 base; +u64 decode_len; +u64 len; +u64 blk_size; +u32 dsmad_handle; +u8 flags; +u8 name[CXL_DC_REGION_STRLEN ]; +};
Does this need kdoc comments?
drivers/cxl/cxlmem.h struct cxl_dev_state { · line 486
Quoted 12 lines
drivers/cxl/cxlmem.h +4
-1+/** * struct cxl_memdev_state - Generic Type-3 Memory Device Class driver data * @@ -466,7 +481,9 @@ struct cxl_dev_state {* @dcd_cmds: List of DCD commands implemented by memory device * @enabled_cmds: Hardware commands found enabled in CEL. * @exclusive_cmds: Commands that are kernel-internal only -* @total_bytes: sum of all possible capacities +* @total_bytes: length of all possible capacities +* @static_bytes: length of possible static RAM and PMEM partitions +* @dynamic_bytes: length of possible DC partitions (DC Regions)
Did this get added to the wrong struct comment header? 'cxl_dev_state' instead of 'cxl_memdev_state'?
drivers/cxl/cxlmem.h struct cxl_dev_state { · line 497
Quoted 9 lines
drivers/cxl/cxlmem.h +2
-0* @volatile_only_bytes: hard volatile capacity * @persistent_only_bytes: hard persistent capacity * @partition_align_bytes: alignment size for partition-able capacity @@ -476,6 +493,8 @@ struct cxl_dev_state {* @next_persistent_bytes: persistent capacity change pending device reset * @ram_perf: performance data entry matched to RAM partition * @pmem_perf: performance data entry matched to PMEM partition +* @nr_dc_region: number of DC regions implemented in the memory device +* @dc_region: array containing info about the DC regions
Did this get added to the wrong struct comment header? 'cxl_dev_state' instead of 'cxl_memdev_state'?
DJ
Quoted 97 lines
drivers/cxl/cxlmem.h +43
-0* @event: event log driver state * @poison: poison driver state info * @security: security driver state info @@ -496,6 +515,8 @@ struct cxl_memdev_state {DECLARE_BITMAP (enabled_cmds,CXL_MEM_COMMAND_ID_MAX );DECLARE_BITMAP (exclusive_cmds,CXL_MEM_COMMAND_ID_MAX );u64 total_bytes; +u64 static_bytes; +u64 dynamic_bytes;u64 volatile_only_bytes;u64 persistent_only_bytes;u64 partition_align_bytes;@@ -507,6 +528,9 @@ struct cxl_memdev_state {struct cxl_dpa_perf ram_perf;struct cxl_dpa_perf pmem_perf; +u8 nr_dc_region; +struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct cxl_event_state event;struct cxl_poison_state poison;struct cxl_security_state security;@@ -709,6 +733,32 @@ struct cxl_mbox_set_partition_info {#define CXL_SET_PARTITION_IMMEDIATE_FLAG BIT(0) +/* See CXL 3.1 Table 8-163 get dynamic capacity config Input Payload */ +struct cxl_mbox_get_dc_config_in { +u8 region_count; +u8 start_region_index; +} __packed; + +/* See CXL 3.1 Table 8-164 get dynamic capacity config Output Payload */ +struct cxl_mbox_get_dc_config_out { +u8 avail_region_count; +u8 regions_returned; +u8 rsvd[6 ]; +/* See CXL 3.1 Table 8-165 */ +struct cxl_dc_region_config { +__le64 region_base; +__le64 region_decode_length; +__le64 region_length; +__le64 region_block_size; +__le32 region_dsmad_handle; +u8 flags; +u8 rsvd[3 ]; + } __packed region[]; +/* Trailing fields unused */ +} __packed; +#define CXL_DYNAMIC_CAPACITY_SANITIZE_ON_RELEASE_FLAG BIT(0) +#define CXL_DCD_BLOCK_LINE_SIZE 0x40 +/* Set Timestamp CXL 3.0 Spec 8.2.9.4.2 */ struct cxl_mbox_set_timestamp_in {__le64 timestamp;@@ -832,6 +882,7 @@ enum {int cxl_internal_send_cmd (struct cxl_memdev_state *mds,struct cxl_mbox_cmd *cmd);int cxl_dev_state_identify (struct cxl_memdev_state *mds); +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds);int cxl_await_media_ready (struct cxl_dev_state *cxlds);int cxl_enumerate_cmds (struct cxl_memdev_state *mds);int cxl_mem_create_range_info (struct cxl_memdev_state *mds);@@ -845,6 +896,17 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,enum cxl_event_log_type type, enum cxl_event_type event_type, const uuid_t *uuid, union cxl_event *evt); + +static inline bool cxl_dcd_supported (struct cxl_memdev_state *mds) +{ +return test_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} + +static inline void cxl_disable_dcd (struct cxl_memdev_state *mds) +{ +clear_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} +int cxl_set_timestamp (struct cxl_memdev_state *mds);int cxl_poison_state_init (struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,drivers/cxl/pci.c +4
-0@@ -874,6 +874,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (rc)return rc; + rc =cxl_dev_dynamic_capacity_identify (mds); +if (rc) +cxl_disable_dcd (mds); + rc =cxl_mem_create_range_info (mds);if (rc)return rc;
Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device
Quoted 189 lines · Dave Jiang
Quoted 154 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Devices which optionally support Dynamic Capacity (DC) are configured via mailbox commands. CXL 3.1 requires the host to issue the Get DC Configuration command in order to properly configure DCDs. Without the Get DC Configuration command DCD can't be supported.
Implement the DC mailbox commands as specified in CXL 3.1 section 8.2.9.9.9 (opcodes 48XXh) to read and store the DCD configuration information. Disable DCD if DCD is not supported. Leverage the Get DC Configuration command supported bit to indicate if DCD support.
Linux has no use for the trailing fields of the Get Dynamic Capacity Configuration Output Payload (Total number of supported extents, number of available extents, total number of supported tags, and number of available tags). Avoid defining those fields to use the more useful dynamic C array.
Cc "Li, Ming" <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[Li, Ming: Fix bug intotal_bytescalculation]
[iweiny: update commit message]
[Jonathan: fix formatting]
[Jonathan: Define block line size]
[Jonathan/Fan: use regions returned field instead of macro in get config] [Jørgen: Rename memdev state range variables]
[Jonathan: adjust use of rc incxl_dev_dynamic_capacity_identify()] [Jonathan: white space cleanup]
[fan: make a comment about the trailing configuration output fields]--- drivers/cxl/core/mbox.c | 171 +++++++++++++++++++++++++++++++++++++++++++++++- drivers/cxl/cxlmem.h | 64 +++++++++++++++++- drivers/cxl/pci.c | 4 ++ 3 files changed, 237 insertions(+), 2 deletions(-)drivers/cxl/core/mbox.c +98
-1@@ -1157,7 +1157,7 @@ int cxl_dev_state_identify(struct cxl_memdev_state *mds)if (rc <0 )return rc; - mds->total_bytes = + mds->static_bytes =le64_to_cpu (id.total_capacity) *CXL_CAPACITY_MULTIPLIER ; mds->volatile_only_bytes =le64_to_cpu (id.volatile_capacity) *CXL_CAPACITY_MULTIPLIER ;@@ -1264,6 +1264,159 @@ int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd)return rc; } +static int cxl_dc_save_region_info (struct cxl_memdev_state *mds,u8 index, +struct cxl_dc_region_config *region_config) +{ +struct cxl_dc_region_info *dcr = &mds->dc_region[index]; +struct device *dev = mds->cxlds.dev; + + dcr->base =le64_to_cpu (region_config->region_base); + dcr->decode_len =le64_to_cpu (region_config->region_decode_length); + dcr->decode_len *=CXL_CAPACITY_MULTIPLIER ; + dcr->len =le64_to_cpu (region_config->region_length); + dcr->blk_size =le64_to_cpu (region_config->region_block_size); + dcr->dsmad_handle =le32_to_cpu (region_config->region_dsmad_handle); + dcr->flags = region_config->flags; +snprintf (dcr->name,CXL_DC_REGION_STRLEN ,"dc%d" , index); + +/* Check regions are in increasing DPA order */ +if (index >0 ) { +struct cxl_dc_region_info *prev_dcr = &mds->dc_region[index -1 ]; + +if ((prev_dcr->base + prev_dcr->decode_len) > dcr->base) { +dev_err (dev, +"DPA ordering violation for DC region %d and %d\n" , + index -1 , index); +return -EINVAL ; + } + } + +if (!IS_ALIGNED (dcr->base,SZ_256M ) || + !IS_ALIGNED (dcr->base, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid base %#llx blk size %#llx\n" , + index, dcr->base, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->decode_len ==0 || dcr->len ==0 || dcr->decode_len < dcr->len || + !IS_ALIGNED (dcr->len, dcr->blk_size)) { +dev_err (dev,"DC region %d invalid length; decode %#llx len %#llx blk size %#llx\n" , + index, dcr->decode_len, dcr->len, dcr->blk_size); +return -EINVAL ; + } + +if (dcr->blk_size ==0 || dcr->blk_size %CXL_DCD_BLOCK_LINE_SIZE || + !is_power_of_2 (dcr->blk_size)) { +dev_err (dev,"DC region %d invalid block size; %#llx\n" , + index, dcr->blk_size); +return -EINVAL ; + } + +dev_dbg (dev, +"DC region %s base %#llx length %#llx block size %#llx\n" , + dcr->name, dcr->base, dcr->decode_len, dcr->blk_size); + +return 0 ; +} + +/* Returns the number of regions in dc_resp or -ERRNO */ +static int cxl_get_dc_config (struct cxl_memdev_state *mds,u8 start_region, +struct cxl_mbox_get_dc_config_out *dc_resp, +size_t dc_resp_size) +{ +struct cxl_mbox_get_dc_config_in get_dc = (struct cxl_mbox_get_dc_config_in ) { + .region_count =CXL_MAX_DC_REGION , + .start_region_index = start_region, + }; +struct cxl_mbox_cmd mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode =CXL_MBOX_OP_GET_DC_CONFIG , + .payload_in = &get_dc, + .size_in =sizeof (get_dc), + .size_out = dc_resp_size, + .payload_out = dc_resp, + .min_out =1 , + }; +struct device *dev = mds->cxlds.dev; +int rc; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc <0 ) +return rc; + +dev_dbg (dev,"Read %d/%d DC regions\n" , + dc_resp->regions_returned, dc_resp->avail_region_count); +return dc_resp->regions_returned; +} + +/** +* cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity +* information from the device. +* @mds: The memory device state +* +* Read Dynamic Capacity information from the device and populate the state +* structures for later use. +* +* Return: 0 if identify was executed successfully, -ERRNO on error. +*/ +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds) +{ +size_t dc_resp_size = mds->payload_size;drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1373
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+struct device *dev = mds->cxlds.dev; +u8 start_region, i; + +for (i =0 ; i <CXL_MAX_DC_REGION ; i++) +snprintf (mds->dc_region[i].name,CXL_DC_REGION_STRLEN ,"<nil>" ); + +if (!cxl_dcd_supported (mds)) { +dev_dbg (dev,"DCD not supported\n" ); +return 0 ; + }This should happen before you pre-format the name string? I would assume that if DCD is not supported then the dcd name sysfs attribs would be not be visible?
Quoted 19 lines
drivers/cxl/core/mbox.c +19
-0+ + struct cxl_mbox_get_dc_config_out *dc_resp __free(kfree) = +kvmalloc (dc_resp_size,GFP_KERNEL ); +if (!dc_resp) +return -ENOMEM ; + + start_region =0 ; + do { + int rc, j; + + rc = cxl_get_dc_config(mds, start_region, dc_resp, dc_resp_size); + if (rc < 0) { + dev_dbg(dev, "Failed to get DC config: %d\n", rc); + return rc; + } + + mds->nr_dc_region += rc; + + if (mds->nr_dc_region < 1 || mds->nr_dc_region > CXL_MAX_DC_REGION) {
Quoted 9 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1398
Quoted 6 lines
drivers/cxl/core/mbox.c +6
-0+dev_err (dev,"Invalid num of dynamic capacity regions %d\n" , + mds->nr_dc_region); +return -EINVAL ; + } + +for (i = start_region, j =0 ; i < mds->nr_dc_region; i++, j++) {This should be 'j <
mds->nr_dc_region'? Otherwise if your start region say is '3' and you have '2' DC regions, you never enter the loop. Or does that not happen? I also wonder if you need to check if 'start_region+mds->nr_dc_region>CXL_MAX_DC_REGION'.
That can not happen, start_region was updated to the number of regions has returned till now (not counting the current call), while nr_dc_region is the total number of regions returned till now (including the current call) as we update it above, so start_region should never be larger than nr_dc_region.
Quoted 3 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1401
Quoted 3 lines
drivers/cxl/core/mbox.c +3
-0+ rc =cxl_dc_save_region_info (mds, i, &dc_resp->region[j]); +if (rc) { +dev_dbg (dev,"Failed to save region info: %d\n" , rc);
I am not sure why we sometimes use dev_err and sometimes we use dev_dbg here, if dcd is supported, error from getting dc configuration is an error to me.
Fan
Quoted 220 lines
Quoted 82 lines
drivers/cxl/core/mbox.c +34
-0+return rc; + } + } + + start_region = mds->nr_dc_region; + + }while (mds->nr_dc_region < dc_resp->avail_region_count); + + mds->dynamic_bytes = + mds->dc_region[mds->nr_dc_region -1 ].base + + mds->dc_region[mds->nr_dc_region -1 ].decode_len - + mds->dc_region[0 ].base; +dev_dbg (dev,"Total dynamic range: %#llx\n" , mds->dynamic_bytes); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (cxl_dev_dynamic_capacity_identify,CXL ); +static int add_dpa_res (struct device *dev,struct resource *parent,struct resource *res,resource_size_t start,resource_size_t size,const char *type)@@ -1294,8 +1447,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) {struct cxl_dev_state *cxlds = &mds->cxlds;struct device *dev = cxlds->dev; +size_t untenanted_mem;int rc; + mds->total_bytes = mds->static_bytes; +if (mds->nr_dc_region) { + untenanted_mem = mds->dc_region[0 ].base - mds->static_bytes; + mds->total_bytes += untenanted_mem + mds->dynamic_bytes; + } +if (!cxlds->media_ready) { cxlds->dpa_res =DEFINE_RES_MEM (0 ,0 ); cxlds->ram_res =DEFINE_RES_MEM (0 ,0 );@@ -1305,6 +1465,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) cxlds->dpa_res =DEFINE_RES_MEM (0 , mds->total_bytes); +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; + + rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->dc_res[i], + dcr->base, dcr->decode_len, dcr->name); +if (rc) +return rc; + } +if (mds->partition_align_bytes ==0 ) { rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->ram_res,0 , mds->volatile_only_bytes,"ram" );drivers/cxl/cxlmem.h +4
-0@@ -402,6 +402,7 @@ enum cxl_devtype { CXL_DEVTYPE_CLASSMEM, }; +#define CXL_MAX_DC_REGION 8/** * struct cxl_dpa_perf - DPA performance property entry * @dpa_range: range for DPA address @@ -431,6 +432,8 @@ struct cxl_dpa_perf {* @dpa_res: Overall DPA resource tree for the device * @pmem_res: Active Persistent memory capacity configuration * @ram_res: Active Volatile memory capacity configuration +* @dc_res: Active Dynamic Capacity memory configuration for each possible +* region * @serial: PCIe Device Serial Number * @type: Generic Memory Class device or Vendor Specific Memory device */ @@ -445,10 +448,22 @@ struct cxl_dev_state {struct resource dpa_res;struct resource pmem_res;struct resource ram_res; +struct resource dc_res[CXL_MAX_DC_REGION ];u64 serial;enum cxl_devtype type; };drivers/cxl/cxlmem.h struct cxl_dev_state { · line 464
Quoted 10 lines
drivers/cxl/cxlmem.h +9
-0+#define CXL_DC_REGION_STRLEN > +struct cxl_dc_region_info { +u64 base; +u64 decode_len; +u64 len; +u64 blk_size; +u32 dsmad_handle; +u8 flags; +u8 name[CXL_DC_REGION_STRLEN ]; +};Does this need kdoc comments?
drivers/cxl/cxlmem.h struct cxl_dev_state { · line 486
Quoted 12 lines
drivers/cxl/cxlmem.h +4
-1+/** * struct cxl_memdev_state - Generic Type-3 Memory Device Class driver data * @@ -466,7 +481,9 @@ struct cxl_dev_state {* @dcd_cmds: List of DCD commands implemented by memory device * @enabled_cmds: Hardware commands found enabled in CEL. * @exclusive_cmds: Commands that are kernel-internal only -* @total_bytes: sum of all possible capacities +* @total_bytes: length of all possible capacities +* @static_bytes: length of possible static RAM and PMEM partitions +* @dynamic_bytes: length of possible DC partitions (DC Regions) Did this get added to the wrong struct comment header? '
cxl_dev_state' instead of 'cxl_memdev_state'?drivers/cxl/cxlmem.h struct cxl_dev_state { · line 497
Quoted 9 lines
drivers/cxl/cxlmem.h +2
-0* @volatile_only_bytes: hard volatile capacity * @persistent_only_bytes: hard persistent capacity * @partition_align_bytes: alignment size for partition-able capacity @@ -476,6 +493,8 @@ struct cxl_dev_state {* @next_persistent_bytes: persistent capacity change pending device reset * @ram_perf: performance data entry matched to RAM partition * @pmem_perf: performance data entry matched to PMEM partition +* @nr_dc_region: number of DC regions implemented in the memory device +* @dc_region: array containing info about the DC regions Did this get added to the wrong struct comment header? '
cxl_dev_state' instead of 'cxl_memdev_state'?DJ
Quoted 97 lines
drivers/cxl/cxlmem.h +43
-0* @event: event log driver state * @poison: poison driver state info * @security: security driver state info @@ -496,6 +515,8 @@ struct cxl_memdev_state {DECLARE_BITMAP (enabled_cmds,CXL_MEM_COMMAND_ID_MAX );DECLARE_BITMAP (exclusive_cmds,CXL_MEM_COMMAND_ID_MAX );u64 total_bytes; +u64 static_bytes; +u64 dynamic_bytes;u64 volatile_only_bytes;u64 persistent_only_bytes;u64 partition_align_bytes;@@ -507,6 +528,9 @@ struct cxl_memdev_state {struct cxl_dpa_perf ram_perf;struct cxl_dpa_perf pmem_perf; +u8 nr_dc_region; +struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct cxl_event_state event;struct cxl_poison_state poison;struct cxl_security_state security;@@ -709,6 +733,32 @@ struct cxl_mbox_set_partition_info {#define CXL_SET_PARTITION_IMMEDIATE_FLAG BIT(0) +/* See CXL 3.1 Table 8-163 get dynamic capacity config Input Payload */ +struct cxl_mbox_get_dc_config_in { +u8 region_count; +u8 start_region_index; +} __packed; + +/* See CXL 3.1 Table 8-164 get dynamic capacity config Output Payload */ +struct cxl_mbox_get_dc_config_out { +u8 avail_region_count; +u8 regions_returned; +u8 rsvd[6 ]; +/* See CXL 3.1 Table 8-165 */ +struct cxl_dc_region_config { +__le64 region_base; +__le64 region_decode_length; +__le64 region_length; +__le64 region_block_size; +__le32 region_dsmad_handle; +u8 flags; +u8 rsvd[3 ]; + } __packed region[]; +/* Trailing fields unused */ +} __packed; +#define CXL_DYNAMIC_CAPACITY_SANITIZE_ON_RELEASE_FLAG BIT(0) +#define CXL_DCD_BLOCK_LINE_SIZE 0x40 +/* Set Timestamp CXL 3.0 Spec 8.2.9.4.2 */ struct cxl_mbox_set_timestamp_in {__le64 timestamp;@@ -832,6 +882,7 @@ enum {int cxl_internal_send_cmd (struct cxl_memdev_state *mds,struct cxl_mbox_cmd *cmd);int cxl_dev_state_identify (struct cxl_memdev_state *mds); +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds);int cxl_await_media_ready (struct cxl_dev_state *cxlds);int cxl_enumerate_cmds (struct cxl_memdev_state *mds);int cxl_mem_create_range_info (struct cxl_memdev_state *mds);@@ -845,6 +896,17 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,enum cxl_event_log_type type, enum cxl_event_type event_type, const uuid_t *uuid, union cxl_event *evt); + +static inline bool cxl_dcd_supported (struct cxl_memdev_state *mds) +{ +return test_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} + +static inline void cxl_disable_dcd (struct cxl_memdev_state *mds) +{ +clear_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} +int cxl_set_timestamp (struct cxl_memdev_state *mds);int cxl_poison_state_init (struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,drivers/cxl/pci.c +4
-0@@ -874,6 +874,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (rc)return rc; + rc =cxl_dev_dynamic_capacity_identify (mds); +if (rc) +cxl_disable_dcd (mds); + rc =cxl_mem_create_range_info (mds);if (rc)return rc;
Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device
Quoted 21 lines · Fan Ni
Quoted 20 lines · Dave Jiang
Quoted 20 lines
drivers/cxl/core/mbox.c +19
-0+ +/** +* cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity +* information from the device. +* @mds: The memory device state +* +* Read Dynamic Capacity information from the device and populate the state +* structures for later use. +* +* Return: 0 if identify was executed successfully, -ERRNO on error. +*/ +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds) +{ +size_t dc_resp_size = mds->payload_size; +struct device *dev = mds->cxlds.dev; +u8 start_region, i; + +for (i =0 ; i <CXL_MAX_DC_REGION ; i++) +snprintf (mds->dc_region[i].name,CXL_DC_REGION_STRLEN ,"<nil>" );
Quoted 8 lines
Quoted 8 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1373
Quoted 5 lines
drivers/cxl/core/mbox.c +5
-0+ +if (!cxl_dcd_supported (mds)) { +dev_dbg (dev,"DCD not supported\n" ); +return 0 ; + }This should happen before you pre-format the name string? I would assume that if DCD is not supported then the dcd name sysfs attribs would be not be visible?
No this string is not used for sysfs. It is used to label the dpa resources... That said in review I don't recall why it was necessary to add the '<nil>' to them by default. I'm actually going to remove that and continue testing and if I recall where this was showing up I might add it back in.
Quoted 28 lines
Quoted 19 lines
Quoted 19 lines
drivers/cxl/core/mbox.c +19
-0+ + struct cxl_mbox_get_dc_config_out *dc_resp __free(kfree) = +kvmalloc (dc_resp_size,GFP_KERNEL ); +if (!dc_resp) +return -ENOMEM ; + + start_region =0 ; + do { + int rc, j; + + rc = cxl_get_dc_config(mds, start_region, dc_resp, dc_resp_size); + if (rc < 0) { + dev_dbg(dev, "Failed to get DC config: %d\n", rc); + return rc; + } + + mds->nr_dc_region += rc; + + if (mds->nr_dc_region < 1 || mds->nr_dc_region > CXL_MAX_DC_REGION) {Quoted 9 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1398
Quoted 6 lines
drivers/cxl/core/mbox.c +6
-0+dev_err (dev,"Invalid num of dynamic capacity regions %d\n" , + mds->nr_dc_region); +return -EINVAL ; + } + +for (i = start_region, j =0 ; i < mds->nr_dc_region; i++, j++) {This should be 'j <
mds->nr_dc_region'? Otherwise if your start region say is '3' and you have '2' DC regions, you never enter the loop. Or does that not happen? I also wonder if you need to check if 'start_region+mds->nr_dc_region>CXL_MAX_DC_REGION'.
Quoted 5 lines
That can not happen,
start_regionwas updated to the number of regions has returned till now (not counting the current call), whilenr_dc_regionis the total number of regions returned till now (including the current call) as we update it above, sostart_regionshould never be larger thannr_dc_region.
Yep.
Quoted 8 lines
Quoted 4 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1401
Quoted 4 lines
drivers/cxl/core/mbox.c +3
-0+ rc =cxl_dc_save_region_info (mds, i, &dc_resp->region[j]); +if (rc) { +dev_dbg (dev,"Failed to save region info: %d\n" , rc);I am not sure why we sometimes use
dev_errand sometimes we usedev_dbghere, if dcd is supported, error from getting dc configuration is an error to me.
We are trying to reduce the dev_err() use. cxl_dc_save_region_info() has dev_err() which is much more specific as to the error. At worse this is just redundant as a debug.
I'll remove it because the debug output is pretty verbose too.
Ira
Quoted 224 lines
Fan
Quoted 220 lines
Quoted 82 lines
drivers/cxl/core/mbox.c +34
-0+return rc; + } + } + + start_region = mds->nr_dc_region; + + }while (mds->nr_dc_region < dc_resp->avail_region_count); + + mds->dynamic_bytes = + mds->dc_region[mds->nr_dc_region -1 ].base + + mds->dc_region[mds->nr_dc_region -1 ].decode_len - + mds->dc_region[0 ].base; +dev_dbg (dev,"Total dynamic range: %#llx\n" , mds->dynamic_bytes); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (cxl_dev_dynamic_capacity_identify,CXL ); +static int add_dpa_res (struct device *dev,struct resource *parent,struct resource *res,resource_size_t start,resource_size_t size,const char *type)@@ -1294,8 +1447,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) {struct cxl_dev_state *cxlds = &mds->cxlds;struct device *dev = cxlds->dev; +size_t untenanted_mem;int rc; + mds->total_bytes = mds->static_bytes; +if (mds->nr_dc_region) { + untenanted_mem = mds->dc_region[0 ].base - mds->static_bytes; + mds->total_bytes += untenanted_mem + mds->dynamic_bytes; + } +if (!cxlds->media_ready) { cxlds->dpa_res =DEFINE_RES_MEM (0 ,0 ); cxlds->ram_res =DEFINE_RES_MEM (0 ,0 );@@ -1305,6 +1465,15 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds) cxlds->dpa_res =DEFINE_RES_MEM (0 , mds->total_bytes); +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; + + rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->dc_res[i], + dcr->base, dcr->decode_len, dcr->name); +if (rc) +return rc; + } +if (mds->partition_align_bytes ==0 ) { rc =add_dpa_res (dev, &cxlds->dpa_res, &cxlds->ram_res,0 , mds->volatile_only_bytes,"ram" );drivers/cxl/cxlmem.h +4
-0@@ -402,6 +402,7 @@ enum cxl_devtype { CXL_DEVTYPE_CLASSMEM, }; +#define CXL_MAX_DC_REGION 8/** * struct cxl_dpa_perf - DPA performance property entry * @dpa_range: range for DPA address @@ -431,6 +432,8 @@ struct cxl_dpa_perf {* @dpa_res: Overall DPA resource tree for the device * @pmem_res: Active Persistent memory capacity configuration * @ram_res: Active Volatile memory capacity configuration +* @dc_res: Active Dynamic Capacity memory configuration for each possible +* region * @serial: PCIe Device Serial Number * @type: Generic Memory Class device or Vendor Specific Memory device */ @@ -445,10 +448,22 @@ struct cxl_dev_state {struct resource dpa_res;struct resource pmem_res;struct resource ram_res; +struct resource dc_res[CXL_MAX_DC_REGION ];u64 serial;enum cxl_devtype type; };drivers/cxl/cxlmem.h struct cxl_dev_state { · line 464
Quoted 10 lines
drivers/cxl/cxlmem.h +9
-0+#define CXL_DC_REGION_STRLEN > +struct cxl_dc_region_info { +u64 base; +u64 decode_len; +u64 len; +u64 blk_size; +u32 dsmad_handle; +u8 flags; +u8 name[CXL_DC_REGION_STRLEN ]; +};Does this need kdoc comments?
drivers/cxl/cxlmem.h struct cxl_dev_state { · line 486
Quoted 12 lines
drivers/cxl/cxlmem.h +4
-1+/** * struct cxl_memdev_state - Generic Type-3 Memory Device Class driver data * @@ -466,7 +481,9 @@ struct cxl_dev_state {* @dcd_cmds: List of DCD commands implemented by memory device * @enabled_cmds: Hardware commands found enabled in CEL. * @exclusive_cmds: Commands that are kernel-internal only -* @total_bytes: sum of all possible capacities +* @total_bytes: length of all possible capacities +* @static_bytes: length of possible static RAM and PMEM partitions +* @dynamic_bytes: length of possible DC partitions (DC Regions) Did this get added to the wrong struct comment header? '
cxl_dev_state' instead of 'cxl_memdev_state'?drivers/cxl/cxlmem.h struct cxl_dev_state { · line 497
Quoted 9 lines
drivers/cxl/cxlmem.h +2
-0* @volatile_only_bytes: hard volatile capacity * @persistent_only_bytes: hard persistent capacity * @partition_align_bytes: alignment size for partition-able capacity @@ -476,6 +493,8 @@ struct cxl_dev_state {* @next_persistent_bytes: persistent capacity change pending device reset * @ram_perf: performance data entry matched to RAM partition * @pmem_perf: performance data entry matched to PMEM partition +* @nr_dc_region: number of DC regions implemented in the memory device +* @dc_region: array containing info about the DC regions Did this get added to the wrong struct comment header? '
cxl_dev_state' instead of 'cxl_memdev_state'?DJ
Quoted 97 lines
drivers/cxl/cxlmem.h +43
-0* @event: event log driver state * @poison: poison driver state info * @security: security driver state info @@ -496,6 +515,8 @@ struct cxl_memdev_state {DECLARE_BITMAP (enabled_cmds,CXL_MEM_COMMAND_ID_MAX );DECLARE_BITMAP (exclusive_cmds,CXL_MEM_COMMAND_ID_MAX );u64 total_bytes; +u64 static_bytes; +u64 dynamic_bytes;u64 volatile_only_bytes;u64 persistent_only_bytes;u64 partition_align_bytes;@@ -507,6 +528,9 @@ struct cxl_memdev_state {struct cxl_dpa_perf ram_perf;struct cxl_dpa_perf pmem_perf; +u8 nr_dc_region; +struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct cxl_event_state event;struct cxl_poison_state poison;struct cxl_security_state security;@@ -709,6 +733,32 @@ struct cxl_mbox_set_partition_info {#define CXL_SET_PARTITION_IMMEDIATE_FLAG BIT(0) +/* See CXL 3.1 Table 8-163 get dynamic capacity config Input Payload */ +struct cxl_mbox_get_dc_config_in { +u8 region_count; +u8 start_region_index; +} __packed; + +/* See CXL 3.1 Table 8-164 get dynamic capacity config Output Payload */ +struct cxl_mbox_get_dc_config_out { +u8 avail_region_count; +u8 regions_returned; +u8 rsvd[6 ]; +/* See CXL 3.1 Table 8-165 */ +struct cxl_dc_region_config { +__le64 region_base; +__le64 region_decode_length; +__le64 region_length; +__le64 region_block_size; +__le32 region_dsmad_handle; +u8 flags; +u8 rsvd[3 ]; + } __packed region[]; +/* Trailing fields unused */ +} __packed; +#define CXL_DYNAMIC_CAPACITY_SANITIZE_ON_RELEASE_FLAG BIT(0) +#define CXL_DCD_BLOCK_LINE_SIZE 0x40 +/* Set Timestamp CXL 3.0 Spec 8.2.9.4.2 */ struct cxl_mbox_set_timestamp_in {__le64 timestamp;@@ -832,6 +882,7 @@ enum {int cxl_internal_send_cmd (struct cxl_memdev_state *mds,struct cxl_mbox_cmd *cmd);int cxl_dev_state_identify (struct cxl_memdev_state *mds); +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds);int cxl_await_media_ready (struct cxl_dev_state *cxlds);int cxl_enumerate_cmds (struct cxl_memdev_state *mds);int cxl_mem_create_range_info (struct cxl_memdev_state *mds);@@ -845,6 +896,17 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,enum cxl_event_log_type type, enum cxl_event_type event_type, const uuid_t *uuid, union cxl_event *evt); + +static inline bool cxl_dcd_supported (struct cxl_memdev_state *mds) +{ +return test_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} + +static inline void cxl_disable_dcd (struct cxl_memdev_state *mds) +{ +clear_bit (CXL_DCD_ENABLED_GET_CONFIG , mds->dcd_cmds); +} +int cxl_set_timestamp (struct cxl_memdev_state *mds);int cxl_poison_state_init (struct cxl_memdev_state *mds); int cxl_mem_get_poison(struct cxl_memdev *cxlmd, u64 offset, u64 len,drivers/cxl/pci.c +4
-0@@ -874,6 +874,10 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)if (rc)return rc; + rc =cxl_dev_dynamic_capacity_identify (mds); +if (rc) +cxl_disable_dcd (mds); + rc =cxl_mem_create_range_info (mds);if (rc)return rc;
Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device
In reply to Fan NiQuoted 1 line · Fan Ni
On Fri, Aug 16, 2024 at 02:45:47PM -0700, Dave Jiang wrote:
[snip]
Quoted 19 lines
Quoted 19 lines
Quoted 19 lines
drivers/cxl/core/mbox.c +19
-0+ +/** +* cxl_dev_dynamic_capacity_identify() - Reads the dynamic capacity +* information from the device. +* @mds: The memory device state +* +* Read Dynamic Capacity information from the device and populate the state +* structures for later use. +* +* Return: 0 if identify was executed successfully, -ERRNO on error. +*/ +int cxl_dev_dynamic_capacity_identify (struct cxl_memdev_state *mds) +{ +size_t dc_resp_size = mds->payload_size; +struct device *dev = mds->cxlds.dev; +u8 start_region, i; + +for (i =0 ; i <CXL_MAX_DC_REGION ; i++) +snprintf (mds->dc_region[i].name,CXL_DC_REGION_STRLEN ,"<nil>" );
Quoted 8 lines
Quoted 8 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1373
Quoted 5 lines
drivers/cxl/core/mbox.c +5
-0+ +if (!cxl_dcd_supported (mds)) { +dev_dbg (dev,"DCD not supported\n" ); +return 0 ; + }This should happen before you pre-format the name string? I would assume that if DCD is not supported then the dcd name sysfs attribs would be not be visible?
No this string is not used for sysfs. It is used to label the dpa resources... That said in review I don't recall why it was necessary to add the '<nil>' to them by default. I'm actually going to remove that and continue testing and if I recall where this was showing up I might add it back in.
Quoted 28 lines
Quoted 19 lines
Quoted 19 lines
drivers/cxl/core/mbox.c +19
-0+ + struct cxl_mbox_get_dc_config_out *dc_resp __free(kfree) = +kvmalloc (dc_resp_size,GFP_KERNEL ); +if (!dc_resp) +return -ENOMEM ; + + start_region =0 ; + do { + int rc, j; + + rc = cxl_get_dc_config(mds, start_region, dc_resp, dc_resp_size); + if (rc < 0) { + dev_dbg(dev, "Failed to get DC config: %d\n", rc); + return rc; + } + + mds->nr_dc_region += rc; + + if (mds->nr_dc_region < 1 || mds->nr_dc_region > CXL_MAX_DC_REGION) {Quoted 9 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1398
Quoted 6 lines
drivers/cxl/core/mbox.c +6
-0+dev_err (dev,"Invalid num of dynamic capacity regions %d\n" , + mds->nr_dc_region); +return -EINVAL ; + } + +for (i = start_region, j =0 ; i < mds->nr_dc_region; i++, j++) {This should be 'j <
mds->nr_dc_region'? Otherwise if your start region say is '3' and you have '2' DC regions, you never enter the loop. Or does that not happen? I also wonder if you need to check if 'start_region+mds->nr_dc_region>CXL_MAX_DC_REGION'.
Quoted 5 lines
That can not happen,
start_regionwas updated to the number of regions has returned till now (not counting the current call), whilenr_dc_regionis the total number of regions returned till now (including the current call) as we update it above, sostart_regionshould never be larger thannr_dc_region.
Yep.
Quoted 8 lines
Quoted 4 lines
drivers/cxl/core/mbox.c int cxl_mem_sanitize(struct cxl_memdev *cxlmd, u16 cmd) · line 1401
Quoted 4 lines
drivers/cxl/core/mbox.c +3
-0+ rc =cxl_dc_save_region_info (mds, i, &dc_resp->region[j]); +if (rc) { +dev_dbg (dev,"Failed to save region info: %d\n" , rc);I am not sure why we sometimes use
dev_errand sometimes we usedev_dbghere, if dcd is supported, error from getting dc configuration is an error to me.
We are trying to reduce the dev_err() use. cxl_dc_save_region_info() has dev_err() which is much more specific as to the error. At worse this is just redundant as a debug.
I'll remove it because the debug output is pretty verbose too.
Ira
Quoted 2 lines
Fan
[snip]
Re: [PATCH v3 06/25] cxl/mem: Read dynamic capacity configuration from the device
In reply to [email protected]Quoted 18 lines · On Fri, 16 Aug 2024 09:44:14 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
Devices which optionally support Dynamic Capacity (DC) are configured via mailbox commands. CXL 3.1 requires the host to issue the Get DC Configuration command in order to properly configure DCDs. Without the Get DC Configuration command DCD can't be supported.
Implement the DC mailbox commands as specified in CXL 3.1 section 8.2.9.9.9 (opcodes 48XXh) to read and store the DCD configuration information. Disable DCD if DCD is not supported. Leverage the Get DC Configuration command supported bit to indicate if DCD support.
Linux has no use for the trailing fields of the Get Dynamic Capacity Configuration Output Payload (Total number of supported extents, number of available extents, total number of supported tags, and number of available tags). Avoid defining those fields to use the more useful dynamic C array.
Quoted 4 lines
Cc "Li, Ming" <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
LGTM
If you can get rid of the <nil> thing even better.
PATCH v3 7/25 cxl/core: Separate region mode from decoder mode
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Until now region modes and decoder modes were equivalent in that both modes were either PMEM or RAM. The addition of Dynamic Capacity partitions defines up to 8 DC partitions per device.
The region mode is thus no longer equivalent to the endpoint decoder mode. IOW the endpoint decoders may have modes of DC0-DC7 while the region mode is simply DC.
Define a new region mode enumeration which applies to regions separate from the decoder mode. Adjust the code to process these modes independently.
There is no equal to decoder mode dead in region modes. Avoid constructing regions with decoders which have been flagged as dead.
---
Changes:
[iweiny: rebase]
[Jonathan: remove dead code]
[Jonathan: clarify commit message]
--- drivers/cxl/core/region.c | 75 ++++++++++++++++++++++++++++++++++------------- drivers/cxl/cxl.h | 26 ++++++++++++++-- 2 files changed, 79 insertions(+), 22 deletions(-)
drivers/cxl/core/region.c +55 -20
@@ -144,7 +144,7 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *attr, rc =down_read_interruptible (&cxl_region_rwsem);if (rc)return rc; -if (cxlr->mode !=CXL_DECODER_PMEM ) +if (cxlr->mode !=CXL_REGION_PMEM ) rc =sysfs_emit (buf,"\n" );else rc =sysfs_emit (buf,"%pUb\n" , &p->uuid);
@@ -457,7 +457,7 @@ static umode_t cxl_region_visible(struct kobject *kobj, struct attribute *a,* Support tooling that expects to find a 'uuid' attribute for all * regions regardless of mode. */ -if (a == &dev_attr_uuid.attr && cxlr->mode !=CXL_DECODER_PMEM ) +if (a == &dev_attr_uuid.attr && cxlr->mode !=CXL_REGION_PMEM )return 0444 ;return a->mode; }
@@ -620,7 +620,7 @@ static ssize_t mode_show(struct device *dev, struct device_attribute *attr, {struct cxl_region *cxlr =to_cxl_region (dev); -return sysfs_emit (buf,"%s\n" ,cxl_decoder_mode_name (cxlr->mode)); +return sysfs_emit (buf,"%s\n" ,cxl_region_mode_name (cxlr->mode)); }static DEVICE_ATTR_RO (mode);
@@ -646,7 +646,7 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size)/* ways, granularity and uuid (if PMEM) need to be set before HPA */ if (!p->interleave_ways || !p->interleave_granularity || - (cxlr->mode ==CXL_DECODER_PMEM &&uuid_is_null (&p->uuid))) + (cxlr->mode ==CXL_REGION_PMEM &&uuid_is_null (&p->uuid)))return -ENXIO ;div64_u64_rem (size, (u64 )SZ_256M * p->interleave_ways, &remainder);
@@ -1863,6 +1863,17 @@ static int cxl_region_sort_targets(struct cxl_region *cxlr)return rc; } +static bool cxl_modes_compatible (enum cxl_region_mode rmode, +enum cxl_decoder_mode dmode) +{ +if (rmode ==CXL_REGION_RAM && dmode ==CXL_DECODER_RAM ) +return true; +if (rmode ==CXL_REGION_PMEM && dmode ==CXL_DECODER_PMEM ) +return true; + +return false; +} +static int cxl_region_attach (struct cxl_region *cxlr,struct cxl_endpoint_decoder *cxled,int pos) {
@@ -1882,9 +1893,11 @@ static int cxl_region_attach(struct cxl_region *cxlr,return rc; } -if (cxled->mode != cxlr->mode) { -dev_dbg (&cxlr->dev,"%s region mode: %d mismatch: %d\n" , -dev_name (&cxled->cxld.dev), cxlr->mode, cxled->mode); +if (!cxl_modes_compatible (cxlr->mode, cxled->mode)) { +dev_dbg (&cxlr->dev,"%s region mode: %s mismatch decoder: %s\n" , +dev_name (&cxled->cxld.dev), +cxl_region_mode_name (cxlr->mode), +cxl_decoder_mode_name (cxled->mode));return -EINVAL ; }
@@ -2447,7 +2460,7 @@ static int cxl_region_calculate_adistance(struct notifier_block *nb,* devm_cxl_add_region - Adds a region to a decoder * @cxlrd: root decoder * @id: memregion id to create, or memregion_free() on failure -* @mode: mode for the endpoint decoders of this region +* @mode: mode of this region * @type: select whether this is an expander or accelerator (type-2 or type-3) * * This is the second step of region initialization. Regions exist within an
@@ -2458,7 +2471,7 @@ static int cxl_region_calculate_adistance(struct notifier_block *nb,*/ static struct cxl_region *devm_cxl_add_region (struct cxl_root_decoder *cxlrd,int id, -enum cxl_decoder_mode mode, +enum cxl_region_mode mode,enum cxl_decoder_type type) {struct cxl_port *port =to_cxl_port (cxlrd->cxlsd.cxld.dev.parent);
@@ -2512,16 +2525,17 @@ static ssize_t create_ram_region_show(struct device *dev, }static struct cxl_region *__create_region (struct cxl_root_decoder *cxlrd, -enum cxl_decoder_mode mode,int id) +enum cxl_region_mode mode,int id) {int rc;switch (mode) { -case CXL_DECODER_RAM : -case CXL_DECODER_PMEM : +case CXL_REGION_RAM : +case CXL_REGION_PMEM :break ;default : -dev_err (&cxlrd->cxlsd.cxld.dev,"unsupported mode %d\n" , mode); +dev_err (&cxlrd->cxlsd.cxld.dev,"unsupported mode %s\n" , +cxl_region_mode_name (mode));return ERR_PTR (-EINVAL ); }
@@ -2549,7 +2563,7 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_DECODER_PMEM , id); + cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);
@@ -2569,7 +2583,7 @@ static ssize_t create_ram_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_DECODER_RAM , id); + cxlr =__create_region (cxlrd,CXL_REGION_RAM , id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);
@@ -3215,6 +3229,22 @@ static int match_region_by_range(struct device *dev, void *data)return rc; } +static enum cxl_region_mode +cxl_decoder_to_region_mode (enum cxl_decoder_mode mode) +{ +switch (mode) { +case CXL_DECODER_NONE : +return CXL_REGION_NONE ; +case CXL_DECODER_RAM : +return CXL_REGION_RAM ; +case CXL_DECODER_PMEM : +return CXL_REGION_PMEM ; +case CXL_DECODER_MIXED : +default : +return CXL_REGION_MIXED ; + } +} +/* Establish an empty region covering the given HPA range */ static struct cxl_region *construct_region (struct cxl_root_decoder *cxlrd,struct cxl_endpoint_decoder *cxled)
@@ -3223,12 +3253,17 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,struct cxl_port *port =cxlrd_to_port (cxlrd);struct range *hpa = &cxled->cxld.hpa_range;struct cxl_region_params *p; +enum cxl_region_mode mode;struct cxl_region *cxlr;struct resource *res;int rc; +if (cxled->mode ==CXL_DECODER_DEAD ) +return ERR_PTR (-EINVAL ); + + mode =cxl_decoder_to_region_mode (cxled->mode);do { - cxlr =__create_region (cxlrd, cxled->mode, + cxlr =__create_region (cxlrd, mode,atomic_read (&cxlrd->region_id)); }while (IS_ERR (cxlr) &&PTR_ERR (cxlr) == -EBUSY );
@@ -3431,9 +3466,9 @@ static int cxl_region_probe(struct device *dev)return rc;switch (cxlr->mode) { -case CXL_DECODER_PMEM : +case CXL_REGION_PMEM :return devm_cxl_add_pmem_region (cxlr); -case CXL_DECODER_RAM : +case CXL_REGION_RAM :/* * The region can not be manged by CXL if any portion of * it is already online as 'System RAM'
@@ -3445,8 +3480,8 @@ static int cxl_region_probe(struct device *dev)return 0 ;return devm_cxl_add_dax_region (cxlr);default : -dev_dbg (&cxlr->dev,"unsupported region mode: %d\n" , - cxlr->mode); +dev_dbg (&cxlr->dev,"unsupported region mode: %s\n" , +cxl_region_mode_name (cxlr->mode));return -ENXIO ; } }
drivers/cxl/cxl.h +24 -2
@@ -388,6 +388,27 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode)return "mixed" ; } +enum cxl_region_mode { +CXL_REGION_NONE , +CXL_REGION_RAM , +CXL_REGION_PMEM , +CXL_REGION_MIXED , +}; + +static inline const char *cxl_region_mode_name (enum cxl_region_mode mode) +{ +static const char *const names[] = { + [CXL_REGION_NONE ] ="none" , + [CXL_REGION_RAM ] ="ram" , + [CXL_REGION_PMEM ] ="pmem" , + [CXL_REGION_MIXED ] ="mixed" , + }; + +if (mode >=CXL_REGION_NONE && mode <=CXL_REGION_MIXED ) +return names[mode]; +return "mixed" ; +} +/* * Track whether this decoder is reserved for region autodiscovery, or * free for userspace provisioning.
@@ -515,7 +536,8 @@ struct cxl_region_params {* struct cxl_region - CXL region * @dev: This region's device * @id: This region's id. Id is globally unique across all regions -* @mode: Endpoint decoder allocation / access mode +* @mode: Region mode which defines which endpoint decoder modes the region is +* compatible with * @type: Endpoint decoder target type * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown * @cxlr_pmem: (for pmem regions) cached copy of the nvdimm bridge
@@ -528,7 +550,7 @@ struct cxl_region_params {struct cxl_region {struct device dev;int id; -enum cxl_decoder_mode mode; +enum cxl_region_mode mode;enum cxl_decoder_type type;struct cxl_nvdimm_bridge *cxl_nvb;struct cxl_pmem_region *cxlr_pmem;
Signature · 1 line
2.45.2
Re: [PATCH v3 07/25] cxl/core: Separate region mode from decoder mode
Quoted 14 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Until now region modes and decoder modes were equivalent in that both modes were either PMEM or RAM. The addition of Dynamic Capacity partitions defines up to 8 DC partitions per device.
The region mode is thus no longer equivalent to the endpoint decoder mode. IOW the endpoint decoders may have modes of DC0-DC7 while the region mode is simply DC.
Define a new region mode enumeration which applies to regions separate from the decoder mode. Adjust the code to process these modes independently.
Quoted 7 lines
There is no equal to decoder mode dead in region modes. Avoid constructing regions with decoders which have been flagged as dead.
Suggested-by Jonathan Cameron <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 259 lines
---
Changes:
[iweiny: rebase]
[Jonathan: remove dead code]
[Jonathan: clarify commit message]--- drivers/cxl/core/region.c | 75 ++++++++++++++++++++++++++++++++++------------- drivers/cxl/cxl.h | 26 ++++++++++++++-- 2 files changed, 79 insertions(+), 22 deletions(-)drivers/cxl/core/region.c +55
-20@@ -144,7 +144,7 @@ static ssize_t uuid_show(struct device *dev, struct device_attribute *attr, rc =down_read_interruptible (&cxl_region_rwsem);if (rc)return rc; -if (cxlr->mode !=CXL_DECODER_PMEM ) +if (cxlr->mode !=CXL_REGION_PMEM ) rc =sysfs_emit (buf,"\n" );else rc =sysfs_emit (buf,"%pUb\n" , &p->uuid);@@ -457,7 +457,7 @@ static umode_t cxl_region_visible(struct kobject *kobj, struct attribute *a,* Support tooling that expects to find a 'uuid' attribute for all * regions regardless of mode. */ -if (a == &dev_attr_uuid.attr && cxlr->mode !=CXL_DECODER_PMEM ) +if (a == &dev_attr_uuid.attr && cxlr->mode !=CXL_REGION_PMEM )return 0444 ;return a->mode; }@@ -620,7 +620,7 @@ static ssize_t mode_show(struct device *dev, struct device_attribute *attr, {struct cxl_region *cxlr =to_cxl_region (dev); -return sysfs_emit (buf,"%s\n" ,cxl_decoder_mode_name (cxlr->mode)); +return sysfs_emit (buf,"%s\n" ,cxl_region_mode_name (cxlr->mode)); }static DEVICE_ATTR_RO (mode);@@ -646,7 +646,7 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size)/* ways, granularity and uuid (if PMEM) need to be set before HPA */ if (!p->interleave_ways || !p->interleave_granularity || - (cxlr->mode ==CXL_DECODER_PMEM &&uuid_is_null (&p->uuid))) + (cxlr->mode ==CXL_REGION_PMEM &&uuid_is_null (&p->uuid)))return -ENXIO ;div64_u64_rem (size, (u64 )SZ_256M * p->interleave_ways, &remainder);@@ -1863,6 +1863,17 @@ static int cxl_region_sort_targets(struct cxl_region *cxlr)return rc; } +static bool cxl_modes_compatible (enum cxl_region_mode rmode, +enum cxl_decoder_mode dmode) +{ +if (rmode ==CXL_REGION_RAM && dmode ==CXL_DECODER_RAM ) +return true; +if (rmode ==CXL_REGION_PMEM && dmode ==CXL_DECODER_PMEM ) +return true; + +return false; +} +static int cxl_region_attach (struct cxl_region *cxlr,struct cxl_endpoint_decoder *cxled,int pos) {@@ -1882,9 +1893,11 @@ static int cxl_region_attach(struct cxl_region *cxlr,return rc; } -if (cxled->mode != cxlr->mode) { -dev_dbg (&cxlr->dev,"%s region mode: %d mismatch: %d\n" , -dev_name (&cxled->cxld.dev), cxlr->mode, cxled->mode); +if (!cxl_modes_compatible (cxlr->mode, cxled->mode)) { +dev_dbg (&cxlr->dev,"%s region mode: %s mismatch decoder: %s\n" , +dev_name (&cxled->cxld.dev), +cxl_region_mode_name (cxlr->mode), +cxl_decoder_mode_name (cxled->mode));return -EINVAL ; }@@ -2447,7 +2460,7 @@ static int cxl_region_calculate_adistance(struct notifier_block *nb,* devm_cxl_add_region - Adds a region to a decoder * @cxlrd: root decoder * @id: memregion id to create, or memregion_free() on failure -* @mode: mode for the endpoint decoders of this region +* @mode: mode of this region * @type: select whether this is an expander or accelerator (type-2 or type-3) * * This is the second step of region initialization. Regions exist within an @@ -2458,7 +2471,7 @@ static int cxl_region_calculate_adistance(struct notifier_block *nb,*/ static struct cxl_region *devm_cxl_add_region (struct cxl_root_decoder *cxlrd,int id, -enum cxl_decoder_mode mode, +enum cxl_region_mode mode,enum cxl_decoder_type type) {struct cxl_port *port =to_cxl_port (cxlrd->cxlsd.cxld.dev.parent);@@ -2512,16 +2525,17 @@ static ssize_t create_ram_region_show(struct device *dev, }static struct cxl_region *__create_region (struct cxl_root_decoder *cxlrd, -enum cxl_decoder_mode mode,int id) +enum cxl_region_mode mode,int id) {int rc;switch (mode) { -case CXL_DECODER_RAM : -case CXL_DECODER_PMEM : +case CXL_REGION_RAM : +case CXL_REGION_PMEM :break ;default : -dev_err (&cxlrd->cxlsd.cxld.dev,"unsupported mode %d\n" , mode); +dev_err (&cxlrd->cxlsd.cxld.dev,"unsupported mode %s\n" , +cxl_region_mode_name (mode));return ERR_PTR (-EINVAL ); }@@ -2549,7 +2563,7 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_DECODER_PMEM , id); + cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);@@ -2569,7 +2583,7 @@ static ssize_t create_ram_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_DECODER_RAM , id); + cxlr =__create_region (cxlrd,CXL_REGION_RAM , id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);@@ -3215,6 +3229,22 @@ static int match_region_by_range(struct device *dev, void *data)return rc; } +static enum cxl_region_mode +cxl_decoder_to_region_mode (enum cxl_decoder_mode mode) +{ +switch (mode) { +case CXL_DECODER_NONE : +return CXL_REGION_NONE ; +case CXL_DECODER_RAM : +return CXL_REGION_RAM ; +case CXL_DECODER_PMEM : +return CXL_REGION_PMEM ; +case CXL_DECODER_MIXED : +default : +return CXL_REGION_MIXED ; + } +} +/* Establish an empty region covering the given HPA range */ static struct cxl_region *construct_region (struct cxl_root_decoder *cxlrd,struct cxl_endpoint_decoder *cxled)@@ -3223,12 +3253,17 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,struct cxl_port *port =cxlrd_to_port (cxlrd);struct range *hpa = &cxled->cxld.hpa_range;struct cxl_region_params *p; +enum cxl_region_mode mode;struct cxl_region *cxlr;struct resource *res;int rc; +if (cxled->mode ==CXL_DECODER_DEAD ) +return ERR_PTR (-EINVAL ); + + mode =cxl_decoder_to_region_mode (cxled->mode);do { - cxlr =__create_region (cxlrd, cxled->mode, + cxlr =__create_region (cxlrd, mode,atomic_read (&cxlrd->region_id)); }while (IS_ERR (cxlr) &&PTR_ERR (cxlr) == -EBUSY );@@ -3431,9 +3466,9 @@ static int cxl_region_probe(struct device *dev)return rc;switch (cxlr->mode) { -case CXL_DECODER_PMEM : +case CXL_REGION_PMEM :return devm_cxl_add_pmem_region (cxlr); -case CXL_DECODER_RAM : +case CXL_REGION_RAM :/* * The region can not be manged by CXL if any portion of * it is already online as 'System RAM' @@ -3445,8 +3480,8 @@ static int cxl_region_probe(struct device *dev)return 0 ;return devm_cxl_add_dax_region (cxlr);default : -dev_dbg (&cxlr->dev,"unsupported region mode: %d\n" , - cxlr->mode); +dev_dbg (&cxlr->dev,"unsupported region mode: %s\n" , +cxl_region_mode_name (cxlr->mode));return -ENXIO ; } }drivers/cxl/cxl.h +24
-2@@ -388,6 +388,27 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode)return "mixed" ; } +enum cxl_region_mode { +CXL_REGION_NONE , +CXL_REGION_RAM , +CXL_REGION_PMEM , +CXL_REGION_MIXED , +}; + +static inline const char *cxl_region_mode_name (enum cxl_region_mode mode) +{ +static const char *const names[] = { + [CXL_REGION_NONE ] ="none" , + [CXL_REGION_RAM ] ="ram" , + [CXL_REGION_PMEM ] ="pmem" , + [CXL_REGION_MIXED ] ="mixed" , + }; + +if (mode >=CXL_REGION_NONE && mode <=CXL_REGION_MIXED ) +return names[mode]; +return "mixed" ; +} +/* * Track whether this decoder is reserved for region autodiscovery, or * free for userspace provisioning. @@ -515,7 +536,8 @@ struct cxl_region_params {* struct cxl_region - CXL region * @dev: This region's device * @id: This region's id. Id is globally unique across all regions -* @mode: Endpoint decoder allocation / access mode +* @mode: Region mode which defines which endpoint decoder modes the region is +* compatible with * @type: Endpoint decoder target type * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown * @cxlr_pmem: (for pmem regions) cached copy of the nvdimm bridge @@ -528,7 +550,7 @@ struct cxl_region_params {struct cxl_region {struct device dev;int id; -enum cxl_decoder_mode mode; +enum cxl_region_mode mode;enum cxl_decoder_type type;struct cxl_nvdimm_bridge *cxl_nvb;struct cxl_pmem_region *cxlr_pmem;
Re: [PATCH v3 07/25] cxl/core: Separate region mode from decoder mode
In reply to [email protected]Quoted 14 lines · On Fri, 16 Aug 2024 09:44:15 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
Until now region modes and decoder modes were equivalent in that both modes were either PMEM or RAM. The addition of Dynamic Capacity partitions defines up to 8 DC partitions per device.
The region mode is thus no longer equivalent to the endpoint decoder mode. IOW the endpoint decoders may have modes of DC0-DC7 while the region mode is simply DC.
Define a new region mode enumeration which applies to regions separate from the decoder mode. Adjust the code to process these modes independently.
Quoted 7 lines
There is no equal to decoder mode dead in region modes. Avoid constructing regions with decoders which have been flagged as dead.
Suggested-by Jonathan Cameron <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Re: [PATCH v3 07/25] cxl/core: Separate region mode from decoder mode
In reply to [email protected]Quoted 14 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Until now region modes and decoder modes were equivalent in that both modes were either PMEM or RAM. The addition of Dynamic Capacity partitions defines up to 8 DC partitions per device.
The region mode is thus no longer equivalent to the endpoint decoder mode. IOW the endpoint decoders may have modes of DC0-DC7 while the region mode is simply DC.
Define a new region mode enumeration which applies to regions separate from the decoder mode. Adjust the code to process these modes independently.
Quoted 7 lines
There is no equal to decoder mode dead in region modes. Avoid constructing regions with decoders which have been flagged as dead.
Suggested-by Jonathan Cameron <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 8/25 cxl/region: Add dynamic capacity decoder and region modes
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
One or more decoders each pointing to a Dynamic Capacity (DC) partition form a CXL software region. The region mode reflects composition of that entire software region. Decoder mode reflects a specific DC partition. DC partitions are also known as DC regions per CXL specification r3.1.
Define the new modes and helper functions required to make the association between these new modes.
---
Changes:
[iweiny: keep tags on simple patch]
[Fan: s/partitions/partition/]
[djiang: New wording for the commit message]
[iweiny: reword commit message more]
--- drivers/cxl/core/region.c | 4 ++++ drivers/cxl/cxl.h | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+)
drivers/cxl/core/region.c +4 -0
@@ -1870,6 +1870,8 @@ static bool cxl_modes_compatible(enum cxl_region_mode rmode,return true;if (rmode ==CXL_REGION_PMEM && dmode ==CXL_DECODER_PMEM )return true; +if (rmode ==CXL_REGION_DC &&cxl_decoder_mode_is_dc (dmode)) +return true;return false; }
@@ -3239,6 +3241,8 @@ cxl_decoder_to_region_mode(enum cxl_decoder_mode mode)return CXL_REGION_RAM ;case CXL_DECODER_PMEM :return CXL_REGION_PMEM ; + case CXL_DECODER_DC0 ... CXL_DECODER_DC7: +return CXL_REGION_DC ;case CXL_DECODER_MIXED :default :return CXL_REGION_MIXED ;
drivers/cxl/cxl.h +23 -0
@@ -370,6 +370,14 @@ enum cxl_decoder_mode {CXL_DECODER_NONE ,CXL_DECODER_RAM ,CXL_DECODER_PMEM , +CXL_DECODER_DC0 , +CXL_DECODER_DC1 , +CXL_DECODER_DC2 , +CXL_DECODER_DC3 , +CXL_DECODER_DC4 , +CXL_DECODER_DC5 , +CXL_DECODER_DC6 , +CXL_DECODER_DC7 ,CXL_DECODER_MIXED , CXL_DECODER_DEAD, };
@@ -380,6 +388,14 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode) [CXL_DECODER_NONE] = "none", [CXL_DECODER_RAM] = "ram", [CXL_DECODER_PMEM] = "pmem", + [CXL_DECODER_DC0] = "dc0", + [CXL_DECODER_DC1] = "dc1", + [CXL_DECODER_DC2] = "dc2", + [CXL_DECODER_DC3] = "dc3", + [CXL_DECODER_DC4] = "dc4", + [CXL_DECODER_DC5] = "dc5", + [CXL_DECODER_DC6] = "dc6", + [CXL_DECODER_DC7] = "dc7", [CXL_DECODER_MIXED] = "mixed", };
@@ -388,10 +404,16 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode)return "mixed" ; } +static inline bool cxl_decoder_mode_is_dc (enum cxl_decoder_mode mode) +{ +return (mode >=CXL_DECODER_DC0 && mode <=CXL_DECODER_DC7 ); +} +enum cxl_region_mode {CXL_REGION_NONE ,CXL_REGION_RAM ,CXL_REGION_PMEM , +CXL_REGION_DC ,CXL_REGION_MIXED , };
@@ -401,6 +423,7 @@ static inline const char *cxl_region_mode_name(enum cxl_region_mode mode) [CXL_REGION_NONE] = "none", [CXL_REGION_RAM] = "ram", [CXL_REGION_PMEM] = "pmem", + [CXL_REGION_DC] = "dc", [CXL_REGION_MIXED] = "mixed", };
Signature · 1 line
2.45.2
Re: [PATCH v3 08/25] cxl/region: Add dynamic capacity decoder and region modes
Quoted 8 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
One or more decoders each pointing to a Dynamic Capacity (DC) partition form a CXL software region. The region mode reflects composition of that entire software region. Decoder mode reflects a specific DC partition. DC partitions are also known as DC regions per CXL specification r3.1.
Quoted 8 lines
Define the new modes and helper functions required to make the association between these new modes.
Reviewed-by Jonathan Cameron <[email protected]>Reviewed-by Fan Ni <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 94 lines
---
Changes:
[iweiny: keep tags on simple patch]
[Fan: s/partitions/partition/]
[djiang: New wording for the commit message]
[iweiny: reword commit message more]--- drivers/cxl/core/region.c | 4 ++++ drivers/cxl/cxl.h | 23 +++++++++++++++++++++++ 2 files changed, 27 insertions(+)drivers/cxl/core/region.c +4
-0@@ -1870,6 +1870,8 @@ static bool cxl_modes_compatible(enum cxl_region_mode rmode,return true;if (rmode ==CXL_REGION_PMEM && dmode ==CXL_DECODER_PMEM )return true; +if (rmode ==CXL_REGION_DC &&cxl_decoder_mode_is_dc (dmode)) +return true;return false; }@@ -3239,6 +3241,8 @@ cxl_decoder_to_region_mode(enum cxl_decoder_mode mode)return CXL_REGION_RAM ;case CXL_DECODER_PMEM :return CXL_REGION_PMEM ; + case CXL_DECODER_DC0 ... CXL_DECODER_DC7: +return CXL_REGION_DC ;case CXL_DECODER_MIXED :default :return CXL_REGION_MIXED ;drivers/cxl/cxl.h +23
-0@@ -370,6 +370,14 @@ enum cxl_decoder_mode {CXL_DECODER_NONE ,CXL_DECODER_RAM ,CXL_DECODER_PMEM , +CXL_DECODER_DC0 , +CXL_DECODER_DC1 , +CXL_DECODER_DC2 , +CXL_DECODER_DC3 , +CXL_DECODER_DC4 , +CXL_DECODER_DC5 , +CXL_DECODER_DC6 , +CXL_DECODER_DC7 ,CXL_DECODER_MIXED , CXL_DECODER_DEAD, };@@ -380,6 +388,14 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode) [CXL_DECODER_NONE] = "none", [CXL_DECODER_RAM] = "ram", [CXL_DECODER_PMEM] = "pmem", + [CXL_DECODER_DC0] = "dc0", + [CXL_DECODER_DC1] = "dc1", + [CXL_DECODER_DC2] = "dc2", + [CXL_DECODER_DC3] = "dc3", + [CXL_DECODER_DC4] = "dc4", + [CXL_DECODER_DC5] = "dc5", + [CXL_DECODER_DC6] = "dc6", + [CXL_DECODER_DC7] = "dc7", [CXL_DECODER_MIXED] = "mixed", };@@ -388,10 +404,16 @@ static inline const char *cxl_decoder_mode_name(enum cxl_decoder_mode mode)return "mixed" ; } +static inline bool cxl_decoder_mode_is_dc (enum cxl_decoder_mode mode) +{ +return (mode >=CXL_DECODER_DC0 && mode <=CXL_DECODER_DC7 ); +} +enum cxl_region_mode {CXL_REGION_NONE ,CXL_REGION_RAM ,CXL_REGION_PMEM , +CXL_REGION_DC ,CXL_REGION_MIXED , };@@ -401,6 +423,7 @@ static inline const char *cxl_region_mode_name(enum cxl_region_mode mode) [CXL_REGION_NONE] = "none", [CXL_REGION_RAM] = "ram", [CXL_REGION_PMEM] = "pmem", + [CXL_REGION_DC] = "dc", [CXL_REGION_MIXED] = "mixed", };
Re: [PATCH v3 08/25] cxl/region: Add dynamic capacity decoder and region modes
In reply to [email protected]Quoted 8 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
One or more decoders each pointing to a Dynamic Capacity (DC) partition form a CXL software region. The region mode reflects composition of that entire software region. Decoder mode reflects a specific DC partition. DC partitions are also known as DC regions per CXL specification r3.1.
Quoted 9 lines
Define the new modes and helper functions required to make the association between these new modes.
Reviewed-by Jonathan Cameron <[email protected]>Reviewed-by Fan Ni <[email protected]>Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 9/25 cxl/hdm: Add dynamic capacity size support to endpoint decoders
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
To support Dynamic Capacity Devices (DCD) endpoint decoders will need to map DC partitions (regions). In addition to assigning the size of the DC partition, the decoder must assign any skip value from the previous decoder. This must be done within a contiguous DPA space.
Two complications arise with Dynamic Capacity regions which did not exist with Ram and PMEM partitions. First, gaps in the DPA space can exist between and around the DC partitions. Second, the Linux resource tree does not allow a resource to be marked across existing nodes within a tree.
For clarity, below is an example of an 60GB device with 10GB of RAM, 10GB of PMEM and 10GB for each of 2 DC partitions. The desired CXL mapping is 5GB of RAM, 5GB of PMEM, and 5GB of DC1.
DPA RANGE
(dpa_res)
0GB 10GB 20GB 30GB 40GB 50GB 60GB
|----------|----------|----------|----------|----------|----------|RAM PMEM DC0 DC1 (ram_res) (pmem_res) (dc_res[0]) (dc_res[1])
|----------|----------| <gap> |----------| <gap> |----------|
RAM PMEM DC1
|XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----| 0GB 5GB 10GB 15GB 20GB 30GB 40GB 50GB 60GB
The previous skip resource between RAM and PMEM was always a child of the RAM resource and fit nicely [see (S) below]. Because of this simplicity this skip resource reference was not stored in any CXL state. On release the skip range could be calculated based on the endpoint decoders stored values.
Now when DC1 is being mapped 4 skip resources must be created as children. One for the PMEM resource (A), two of the parent DPA resource (B,D), and one more child of the DC0 resource (C).
0GB 10GB 20GB 30GB 40GB 50GB 60GB
|----------|----------|----------|----------|----------|----------|
| |
|----------|----------| | |----------| | |----------|
| | | | |
(S) (A) (B) (C) (D)
v v v v v
|XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----|
skip skip skip skip skipExpand the calculation of DPA free space and enhance the logic to support this more complex skipping. To track the potential of multiple skip resources an xarray is attached to the endpoint decoder. The existing algorithm between RAM and PMEM is consolidated within the new one to streamline the code even though the result is the storage of a single skip resource in the xarray.
---
Changes:
[Jonathan: Use an example only mapping 1/2 of DC1] [iweiny: Update cover letter]
[iweiny: Fix 0day bugs
https://lore.kernel.org/all/[email protected]/ [djbw/Jonathan: allow more than 1 region per DC partition] --- drivers/cxl/core/hdm.c | 196 ++++++++++++++++++++++++++++++++++++++++++++---- drivers/cxl/core/port.c | 2 + drivers/cxl/cxl.h | 2 + 3 files changed, 184 insertions(+), 16 deletions(-)
drivers/cxl/core/hdm.c +180 -16
@@ -223,6 +223,25 @@ void cxl_dpa_debug(struct seq_file *file, struct cxl_dev_state *cxlds) }EXPORT_SYMBOL_NS_GPL (cxl_dpa_debug,CXL ); +static void cxl_skip_release (struct cxl_endpoint_decoder *cxled) +{ +struct cxl_dev_state *cxlds =cxled_to_memdev (cxled)->cxlds; +struct cxl_port *port =cxled_to_port (cxled); +struct device *dev = &port->dev; +unsigned long index; +void *entry; + +xa_for_each (&cxled->skip_res, index, entry) { +struct resource *res = entry; + +dev_dbg (dev,"decoder%d.%d: releasing skipped space; %pr\n" , + port->id, cxled->cxld.id, res); +__release_region (&cxlds->dpa_res, res->start, +resource_size (res)); +xa_erase (&cxled->skip_res, index); + } +} +/* * Must be called in a context that synchronizes against this decoder's * port ->remove() callback (like an endpoint decoder sysfs attribute)
@@ -233,15 +252,11 @@ static void __cxl_dpa_release(struct cxl_endpoint_decoder *cxled)struct cxl_port *port =cxled_to_port (cxled);struct cxl_dev_state *cxlds = cxlmd->cxlds;struct resource *res = cxled->dpa_res; -resource_size_t skip_start;lockdep_assert_held_write (&cxl_dpa_rwsem); -/* save @skip_start, before @res is released */ - skip_start = res->start - cxled->skip;__release_region (&cxlds->dpa_res, res->start,resource_size (res)); -if (cxled->skip) -__release_region (&cxlds->dpa_res, skip_start, cxled->skip); +cxl_skip_release (cxled); cxled->skip =0 ; cxled->dpa_res =NULL ;put_device (&cxled->cxld.dev);
@@ -268,6 +283,105 @@ static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled)__cxl_dpa_release (cxled); } +static int dc_mode_to_region_index (enum cxl_decoder_mode mode) +{ +return mode -CXL_DECODER_DC0 ; +} + +static int cxl_request_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t skip_base,resource_size_t skip_len) +{ +struct cxl_dev_state *cxlds =cxled_to_memdev (cxled)->cxlds; +const char *name =dev_name (&cxled->cxld.dev); +struct cxl_port *port =cxled_to_port (cxled); +struct resource *dpa_res = &cxlds->dpa_res; +struct device *dev = &port->dev; +struct resource *res; +int rc; + + res =__request_region (dpa_res, skip_base, skip_len, name,0 ); +if (!res) +return -EBUSY ; + + rc =xa_insert (&cxled->skip_res, skip_base, res,GFP_KERNEL ); +if (rc) { +__release_region (dpa_res, skip_base, skip_len); +return rc; + } + +dev_dbg (dev,"decoder%d.%d: skipped space; %pr\n" , + port->id, cxled->cxld.id, res); +return 0 ; +} + +static int cxl_reserve_dpa_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t base,resource_size_t skipped) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_port *port =cxled_to_port (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; +resource_size_t skip_base = base - skipped; +struct device *dev = &port->dev; +resource_size_t skip_len =0 ; +int rc, index; + +if (resource_size (&cxlds->ram_res) && skip_base <= cxlds->ram_res.end) { + skip_len = cxlds->ram_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done ram!\n" ); +return 0 ; + } + +if (resource_size (&cxlds->pmem_res) && + skip_base <= cxlds->pmem_res.end) { + skip_len = cxlds->pmem_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + + index =dc_mode_to_region_index (cxled->mode); +for (int i =0 ; i <= index; i++) { +struct resource *dcr = &cxlds->dc_res[i]; + +if (skip_base < dcr->start) { + skip_len = dcr->start - skip_base; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done DC region %d!\n" , i); +break ; + } + +if (resource_size (dcr) && skip_base <= dcr->end) { +if (skip_base > base) { +dev_err (dev,"Skip error DC region %d; skip_base %pa; base %pa\n" , + i, &skip_base, &base); +return -ENXIO ; + } + + skip_len = dcr->end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + } + +return 0 ; +} +static int __cxl_dpa_reserve (struct cxl_endpoint_decoder *cxled,resource_size_t base,resource_size_t len,resource_size_t skipped)
@@ -305,13 +419,12 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, }if (skipped) { - res =__request_region (&cxlds->dpa_res, base - skipped, skipped, -dev_name (&cxled->cxld.dev),0 ); -if (!res) { -dev_dbg (dev, -"decoder%d.%d: failed to reserve skipped space\n" , - port->id, cxled->cxld.id); -return -EBUSY ; +int rc =cxl_reserve_dpa_skip (cxled, base, skipped); + +if (rc) { +dev_dbg (dev,"decoder%d.%d: failed to reserve skipped space; %pa - %pa\n" , + port->id, cxled->cxld.id, &base, &skipped); +return rc; } } res = __request_region(&cxlds->dpa_res, base, len,
@@ -319,14 +432,20 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled,if (!res) {dev_dbg (dev,"decoder%d.%d: failed to reserve allocation\n" , port->id, cxled->cxld.id); -if (skipped) -__release_region (&cxlds->dpa_res, base - skipped, - skipped); +cxl_skip_release (cxled);return -EBUSY ; } cxled->dpa_res = res; cxled->skip = skipped; +for (int mode =CXL_DECODER_DC0 ; mode <=CXL_DECODER_DC7 ; mode++) { +int index =dc_mode_to_region_index (mode); + +if (resource_contains (&cxlds->dc_res[index], res)) { + cxled->mode = mode; + goto success; + } + }if (resource_contains (&cxlds->pmem_res, res)) cxled->mode =CXL_DECODER_PMEM ;else if (resource_contains (&cxlds->ram_res, res))
@@ -337,6 +456,9 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, cxled->mode =CXL_DECODER_MIXED ; } +success: +dev_dbg (dev,"decoder%d.%d: %pr mode: %d\n" , port->id, cxled->cxld.id, + cxled->dpa_res, cxled->mode); port->hdm_end++;get_device (&cxled->cxld.dev);return 0 ;
@@ -466,8 +588,8 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,int cxl_dpa_alloc (struct cxl_endpoint_decoder *cxled,unsigned long long size) { -struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);resource_size_t free_ram_start, free_pmem_start; +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);struct cxl_port *port =cxled_to_port (cxled);struct cxl_dev_state *cxlds = cxlmd->cxlds;struct device *dev = &cxled->cxld.dev;
@@ -524,12 +646,54 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)else skip_end = start -1 ; skip = skip_end - skip_start +1 ; + }else if (cxl_decoder_mode_is_dc (cxled->mode)) { +int dc_index =dc_mode_to_region_index (cxled->mode); + +for (p = cxlds->dc_res[dc_index].child, last =NULL ; p; p = p->sibling) + last = p; + +if (last) { +/* +* Some capacity in this DC partition is already allocated, +* that allocation already handled the skip. +*/ + start = last->end +1 ; + skip =0 ; + }else { +/* Calculate skip */ +resource_size_t skip_start, skip_end; + + start = cxlds->dc_res[dc_index].start; + +if ((resource_size (&cxlds->pmem_res) ==0 ) || !cxlds->pmem_res.child) + skip_start = free_ram_start; +else + skip_start = free_pmem_start; +/* +* If any dc region is already mapped, then that allocation +* already handled the RAM and PMEM skip. Check for DC region +* skip. +*/ +for (int i = dc_index -1 ; i >=0 ; i--) { +if (cxlds->dc_res[i].child) { + skip_start = cxlds->dc_res[i].child->end +1 ; +break ; + } + } + + skip_end = start -1 ; + skip = skip_end - skip_start +1 ; + } + avail = cxlds->dc_res[dc_index].end - start +1 ; }else {dev_dbg (dev,"mode not set\n" ); rc = -EINVAL ; goto out; } +dev_dbg (dev,"DPA Allocation start: %pa len: %#llx Skip: %pa\n" , + &start, size, &skip); +if (size > avail) {dev_dbg (dev,"%pa exceeds available %s capacity: %pa\n" , &size,cxl_decoder_mode_name (cxled->mode), &avail);
drivers/cxl/core/port.c +2 -0
@@ -419,6 +419,7 @@ static void cxl_endpoint_decoder_release(struct device *dev)struct cxl_endpoint_decoder *cxled =to_cxl_endpoint_decoder (dev);__cxl_decoder_release (&cxled->cxld); +xa_destroy (&cxled->skip_res);kfree (cxled); }
@@ -1899,6 +1900,7 @@ struct cxl_endpoint_decoder *cxl_endpoint_decoder_alloc(struct cxl_port *port)return ERR_PTR (-ENOMEM ); cxled->pos =-1 ; +xa_init (&cxled->skip_res); cxld = &cxled->cxld; rc =cxl_decoder_init (port, cxld);if (rc) {
drivers/cxl/cxl.h +2 -0
@@ -446,6 +446,7 @@ enum cxl_decoder_state {* @cxld: base cxl_decoder_object * @dpa_res: actively claimed DPA span of this decoder * @skip: offset into @dpa_res where @cxld.hpa_range maps +* @skip_res: array of skipped resources from the previous decoder end * @mode: which memory type / access-mode-partition this decoder targets * @state: autodiscovery state * @pos: interleave position in @cxld.region
@@ -454,6 +455,7 @@ struct cxl_endpoint_decoder {struct cxl_decoder cxld;struct resource *dpa_res;resource_size_t skip; +struct xarray skip_res;enum cxl_decoder_mode mode;enum cxl_decoder_state state;int pos;
Signature · 1 line
2.45.2
Dave Jiang
maintainerRe: [PATCH v3 09/25] cxl/hdm: Add dynamic capacity size support to endpoint decoders
Quoted 136 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
To support Dynamic Capacity Devices (DCD) endpoint decoders will need to map DC partitions (regions). In addition to assigning the size of the DC partition, the decoder must assign any skip value from the previous decoder. This must be done within a contiguous DPA space.
Two complications arise with Dynamic Capacity regions which did not exist with Ram and PMEM partitions. First, gaps in the DPA space can exist between and around the DC partitions. Second, the Linux resource tree does not allow a resource to be marked across existing nodes within a tree.
For clarity, below is an example of an 60GB device with 10GB of RAM, 10GB of PMEM and 10GB for each of 2 DC partitions. The desired CXL mapping is 5GB of RAM, 5GB of PMEM, and 5GB of DC1.
DPA RANGE (dpa_res) 0GB 10GB 20GB 30GB 40GB 50GB 60GB |----------|----------|----------|----------|----------|----------|RAM PMEM DC0 DC1 (ram_res) (pmem_res) (dc_res[0]) (dc_res[1])|----------|----------| <gap> |----------| <gap> |----------|
RAM PMEM DC1
|XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----| 0GB 5GB 10GB 15GB 20GB 30GB 40GB 50GB 60GBThe previous skip resource between RAM and PMEM was always a child of the RAM resource and fit nicely [see (S) below]. Because of this simplicity this skip resource reference was not stored in any CXL state. On release the skip range could be calculated based on the endpoint decoders stored values.
Now when DC1 is being mapped 4 skip resources must be created as children. One for the PMEM resource (A), two of the parent DPA resource (B,D), and one more child of the DC0 resource (C).
0GB 10GB 20GB 30GB 40GB 50GB 60GB |----------|----------|----------|----------|----------|----------| | | |----------|----------| | |----------| | |----------| | | | | | (S) (A) (B) (C) (D) v v v v v |XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----| skip skip skip skip skipExpand the calculation of DPA free space and enhance the logic to support this more complex skipping. To track the potential of multiple skip resources an xarray is attached to the endpoint decoder. The existing algorithm between RAM and PMEM is consolidated within the new one to streamline the code even though the result is the storage of a single skip resource in the xarray.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[Jonathan: Use an example only mapping 1/2 of DC1] [iweiny: Update cover letter]
[iweiny: Fix 0day bugshttps://lore.kernel.org/all/[email protected]/ [djbw/Jonathan: allow more than 1 region per DC partition] --- drivers/cxl/core/hdm.c | 196 ++++++++++++++++++++++++++++++++++++++++++++---- drivers/cxl/core/port.c | 2 + drivers/cxl/cxl.h | 2 + 3 files changed, 184 insertions(+), 16 deletions(-)drivers/cxl/core/hdm.c +31
-5@@ -223,6 +223,25 @@ void cxl_dpa_debug(struct seq_file *file, struct cxl_dev_state *cxlds) }EXPORT_SYMBOL_NS_GPL (cxl_dpa_debug,CXL ); +static void cxl_skip_release (struct cxl_endpoint_decoder *cxled) +{ +struct cxl_dev_state *cxlds =cxled_to_memdev (cxled)->cxlds; +struct cxl_port *port =cxled_to_port (cxled); +struct device *dev = &port->dev; +unsigned long index; +void *entry; + +xa_for_each (&cxled->skip_res, index, entry) { +struct resource *res = entry; + +dev_dbg (dev,"decoder%d.%d: releasing skipped space; %pr\n" , + port->id, cxled->cxld.id, res); +__release_region (&cxlds->dpa_res, res->start, +resource_size (res)); +xa_erase (&cxled->skip_res, index); + } +} +/* * Must be called in a context that synchronizes against this decoder's * port ->remove() callback (like an endpoint decoder sysfs attribute) @@ -233,15 +252,11 @@ static void __cxl_dpa_release(struct cxl_endpoint_decoder *cxled)struct cxl_port *port =cxled_to_port (cxled);struct cxl_dev_state *cxlds = cxlmd->cxlds;struct resource *res = cxled->dpa_res; -resource_size_t skip_start;lockdep_assert_held_write (&cxl_dpa_rwsem); -/* save @skip_start, before @res is released */ - skip_start = res->start - cxled->skip;__release_region (&cxlds->dpa_res, res->start,resource_size (res)); -if (cxled->skip) -__release_region (&cxlds->dpa_res, skip_start, cxled->skip); +cxl_skip_release (cxled); cxled->skip =0 ; cxled->dpa_res =NULL ;put_device (&cxled->cxld.dev);@@ -268,6 +283,105 @@ static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled)__cxl_dpa_release (cxled); } +static int dc_mode_to_region_index (enum cxl_decoder_mode mode) +{ +return mode -CXL_DECODER_DC0 ; +} + +static int cxl_request_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t skip_base,resource_size_t skip_len) +{ +struct cxl_dev_state *cxlds =cxled_to_memdev (cxled)->cxlds; +const char *name =dev_name (&cxled->cxld.dev); +struct cxl_port *port =cxled_to_port (cxled);
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 306
Quoted 10 lines
drivers/cxl/core/hdm.c +10
-0+struct resource *dpa_res = &cxlds->dpa_res; +struct device *dev = &port->dev; +struct resource *res; +int rc; + + res =__request_region (dpa_res, skip_base, skip_len, name,0 ); +if (!res) +return -EBUSY ; + + rc =xa_insert (&cxled->skip_res, skip_base, res,GFP_KERNEL );
Maybe rename skip_res to skip_xa, given most of the vars in CXL with _res are 'struct resource' to avoid confusion. See 'dpa_res' above.
Quoted 32 lines
drivers/cxl/core/hdm.c +32
-0+if (rc) { +__release_region (dpa_res, skip_base, skip_len); +return rc; + } + +dev_dbg (dev,"decoder%d.%d: skipped space; %pr\n" , + port->id, cxled->cxld.id, res); +return 0 ; +} + +static int cxl_reserve_dpa_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t base,resource_size_t skipped) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_port *port =cxled_to_port (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; +resource_size_t skip_base = base - skipped; +struct device *dev = &port->dev; +resource_size_t skip_len =0 ; +int rc, index; + +if (resource_size (&cxlds->ram_res) && skip_base <= cxlds->ram_res.end) { + skip_len = cxlds->ram_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done ram!\n" ); +return 0 ;
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 348
Quoted 10 lines
drivers/cxl/core/hdm.c +10
-0+ } + +if (resource_size (&cxlds->pmem_res) && + skip_base <= cxlds->pmem_res.end) { + skip_len = cxlds->pmem_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + }
Does 'skip_base == base' need to be checked here again before going to DCD?
DJ
Quoted 199 lines
drivers/cxl/core/hdm.c +97
-11+ + index =dc_mode_to_region_index (cxled->mode); +for (int i =0 ; i <= index; i++) { +struct resource *dcr = &cxlds->dc_res[i]; + +if (skip_base < dcr->start) { + skip_len = dcr->start - skip_base; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done DC region %d!\n" , i); +break ; + } + +if (resource_size (dcr) && skip_base <= dcr->end) { +if (skip_base > base) { +dev_err (dev,"Skip error DC region %d; skip_base %pa; base %pa\n" , + i, &skip_base, &base); +return -ENXIO ; + } + + skip_len = dcr->end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + } + +return 0 ; +} +static int __cxl_dpa_reserve (struct cxl_endpoint_decoder *cxled,resource_size_t base,resource_size_t len,resource_size_t skipped)@@ -305,13 +419,12 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, }if (skipped) { - res =__request_region (&cxlds->dpa_res, base - skipped, skipped, -dev_name (&cxled->cxld.dev),0 ); -if (!res) { -dev_dbg (dev, -"decoder%d.%d: failed to reserve skipped space\n" , - port->id, cxled->cxld.id); -return -EBUSY ; +int rc =cxl_reserve_dpa_skip (cxled, base, skipped); + +if (rc) { +dev_dbg (dev,"decoder%d.%d: failed to reserve skipped space; %pa - %pa\n" , + port->id, cxled->cxld.id, &base, &skipped); +return rc; } } res = __request_region(&cxlds->dpa_res, base, len,@@ -319,14 +432,20 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled,if (!res) {dev_dbg (dev,"decoder%d.%d: failed to reserve allocation\n" , port->id, cxled->cxld.id); -if (skipped) -__release_region (&cxlds->dpa_res, base - skipped, - skipped); +cxl_skip_release (cxled);return -EBUSY ; } cxled->dpa_res = res; cxled->skip = skipped; +for (int mode =CXL_DECODER_DC0 ; mode <=CXL_DECODER_DC7 ; mode++) { +int index =dc_mode_to_region_index (mode); + +if (resource_contains (&cxlds->dc_res[index], res)) { + cxled->mode = mode; + goto success; + } + }if (resource_contains (&cxlds->pmem_res, res)) cxled->mode =CXL_DECODER_PMEM ;else if (resource_contains (&cxlds->ram_res, res))@@ -337,6 +456,9 @@ static int __cxl_dpa_reserve(struct cxl_endpoint_decoder *cxled, cxled->mode =CXL_DECODER_MIXED ; } +success: +dev_dbg (dev,"decoder%d.%d: %pr mode: %d\n" , port->id, cxled->cxld.id, + cxled->dpa_res, cxled->mode); port->hdm_end++;get_device (&cxled->cxld.dev);return 0 ;@@ -466,8 +588,8 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,int cxl_dpa_alloc (struct cxl_endpoint_decoder *cxled,unsigned long long size) { -struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);resource_size_t free_ram_start, free_pmem_start; +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);struct cxl_port *port =cxled_to_port (cxled);struct cxl_dev_state *cxlds = cxlmd->cxlds;struct device *dev = &cxled->cxld.dev;@@ -524,12 +646,54 @@ int cxl_dpa_alloc(struct cxl_endpoint_decoder *cxled, unsigned long long size)else skip_end = start -1 ; skip = skip_end - skip_start +1 ; + }else if (cxl_decoder_mode_is_dc (cxled->mode)) { +int dc_index =dc_mode_to_region_index (cxled->mode); + +for (p = cxlds->dc_res[dc_index].child, last =NULL ; p; p = p->sibling) + last = p; + +if (last) { +/* +* Some capacity in this DC partition is already allocated, +* that allocation already handled the skip. +*/ + start = last->end +1 ; + skip =0 ; + }else { +/* Calculate skip */ +resource_size_t skip_start, skip_end; + + start = cxlds->dc_res[dc_index].start; + +if ((resource_size (&cxlds->pmem_res) ==0 ) || !cxlds->pmem_res.child) + skip_start = free_ram_start; +else + skip_start = free_pmem_start; +/* +* If any dc region is already mapped, then that allocation +* already handled the RAM and PMEM skip. Check for DC region +* skip. +*/ +for (int i = dc_index -1 ; i >=0 ; i--) { +if (cxlds->dc_res[i].child) { + skip_start = cxlds->dc_res[i].child->end +1 ; +break ; + } + } + + skip_end = start -1 ; + skip = skip_end - skip_start +1 ; + } + avail = cxlds->dc_res[dc_index].end - start +1 ; }else {dev_dbg (dev,"mode not set\n" ); rc = -EINVAL ; goto out; } +dev_dbg (dev,"DPA Allocation start: %pa len: %#llx Skip: %pa\n" , + &start, size, &skip); +if (size > avail) {dev_dbg (dev,"%pa exceeds available %s capacity: %pa\n" , &size,cxl_decoder_mode_name (cxled->mode), &avail);drivers/cxl/core/port.c +2
-0@@ -419,6 +419,7 @@ static void cxl_endpoint_decoder_release(struct device *dev)struct cxl_endpoint_decoder *cxled =to_cxl_endpoint_decoder (dev);__cxl_decoder_release (&cxled->cxld); +xa_destroy (&cxled->skip_res);kfree (cxled); }@@ -1899,6 +1900,7 @@ struct cxl_endpoint_decoder *cxl_endpoint_decoder_alloc(struct cxl_port *port)return ERR_PTR (-ENOMEM ); cxled->pos =-1 ; +xa_init (&cxled->skip_res); cxld = &cxled->cxld; rc =cxl_decoder_init (port, cxld);if (rc) {drivers/cxl/cxl.h +2
-0@@ -446,6 +446,7 @@ enum cxl_decoder_state {* @cxld: base cxl_decoder_object * @dpa_res: actively claimed DPA span of this decoder * @skip: offset into @dpa_res where @cxld.hpa_range maps +* @skip_res: array of skipped resources from the previous decoder end * @mode: which memory type / access-mode-partition this decoder targets * @state: autodiscovery state * @pos: interleave position in @cxld.region @@ -454,6 +455,7 @@ struct cxl_endpoint_decoder {struct cxl_decoder cxld;struct resource *dpa_res;resource_size_t skip; +struct xarray skip_res;enum cxl_decoder_mode mode;enum cxl_decoder_state state;int pos;
Re: [PATCH v3 09/25] cxl/hdm: Add dynamic capacity size support to endpoint decoders
Quoted 5 lines · Dave Jiang
Quoted 2 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
[snip]
Quoted 16 lines
Quoted 16 lines
drivers/cxl/core/hdm.c +16
-0+static int dc_mode_to_region_index (enum cxl_decoder_mode mode) +{ +return mode -CXL_DECODER_DC0 ; +} + +static int cxl_request_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t skip_base,resource_size_t skip_len) +{ +struct cxl_dev_state *cxlds =cxled_to_memdev (cxled)->cxlds; +const char *name =dev_name (&cxled->cxld.dev); +struct cxl_port *port =cxled_to_port (cxled); +struct resource *dpa_res = &cxlds->dpa_res; +struct device *dev = &port->dev; +struct resource *res; +int rc; +
Quoted 9 lines
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 306
Quoted 5 lines
drivers/cxl/core/hdm.c +5
-0+ res =__request_region (dpa_res, skip_base, skip_len, name,0 ); +if (!res) +return -EBUSY ; + + rc =xa_insert (&cxled->skip_res, skip_base, res,GFP_KERNEL );Maybe rename
skip_restoskip_xa, given most of the vars in CXL with_resare 'struct resource' to avoid confusion. See 'dpa_res' above.
Good idea.
[done]
Quoted 36 lines
Quoted 36 lines
drivers/cxl/core/hdm.c +36
-0+if (rc) { +__release_region (dpa_res, skip_base, skip_len); +return rc; + } + +dev_dbg (dev,"decoder%d.%d: skipped space; %pr\n" , + port->id, cxled->cxld.id, res); +return 0 ; +} + +static int cxl_reserve_dpa_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t base,resource_size_t skipped) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_port *port =cxled_to_port (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; +resource_size_t skip_base = base - skipped; +struct device *dev = &port->dev; +resource_size_t skip_len =0 ; +int rc, index; + +if (resource_size (&cxlds->ram_res) && skip_base <= cxlds->ram_res.end) { + skip_len = cxlds->ram_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done ram!\n" ); +return 0 ; + } + +if (resource_size (&cxlds->pmem_res) && + skip_base <= cxlds->pmem_res.end) {
Quoted 8 lines
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 348
Quoted 6 lines
drivers/cxl/core/hdm.c +6
-0+ skip_len = cxlds->pmem_res.end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + }Does '
skip_base== base' need to be checked here again before going to DCD?
No it is checked below...
Quoted 12 lines
DJ
Quoted 9 lines
drivers/cxl/core/hdm.c +9
-0+ + index =dc_mode_to_region_index (cxled->mode); +for (int i =0 ; i <= index; i++) { +struct resource *dcr = &cxlds->dc_res[i]; + +if (skip_base < dcr->start) { + skip_len = dcr->start - skip_base; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc)
Quoted 8 lines
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 365
Quoted 8 lines
drivers/cxl/core/hdm.c +8
-0+return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done DC region %d!\n" , i); +break ; + }
... here.
After any skips between pmem and the first DC partition. Ira
Quoted 19 lines
Quoted 19 lines
drivers/cxl/core/hdm.c +19
-0+ +if (resource_size (dcr) && skip_base <= dcr->end) { +if (skip_base > base) { +dev_err (dev,"Skip error DC region %d; skip_base %pa; base %pa\n" , + i, &skip_base, &base); +return -ENXIO ; + } + + skip_len = dcr->end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + } + +return 0 ; +} +
[snip]
Re: [PATCH v3 09/25] cxl/hdm: Add dynamic capacity size support to endpoint decoders
In reply to [email protected]Quoted 57 lines · On Fri, 16 Aug 2024 09:44:17 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
To support Dynamic Capacity Devices (DCD) endpoint decoders will need to map DC partitions (regions). In addition to assigning the size of the DC partition, the decoder must assign any skip value from the previous decoder. This must be done within a contiguous DPA space.
Two complications arise with Dynamic Capacity regions which did not exist with Ram and PMEM partitions. First, gaps in the DPA space can exist between and around the DC partitions. Second, the Linux resource tree does not allow a resource to be marked across existing nodes within a tree.
For clarity, below is an example of an 60GB device with 10GB of RAM, 10GB of PMEM and 10GB for each of 2 DC partitions. The desired CXL mapping is 5GB of RAM, 5GB of PMEM, and 5GB of DC1.
DPA RANGE (dpa_res) 0GB 10GB 20GB 30GB 40GB 50GB 60GB |----------|----------|----------|----------|----------|----------|RAM PMEM DC0 DC1 (ram_res) (pmem_res) (dc_res[0]) (dc_res[1])|----------|----------| <gap> |----------| <gap> |----------|
RAM PMEM DC1
|XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----| 0GB 5GB 10GB 15GB 20GB 30GB 40GB 50GB 60GBThe previous skip resource between RAM and PMEM was always a child of the RAM resource and fit nicely [see (S) below]. Because of this simplicity this skip resource reference was not stored in any CXL state. On release the skip range could be calculated based on the endpoint decoders stored values.
Now when DC1 is being mapped 4 skip resources must be created as children. One for the PMEM resource (A), two of the parent DPA resource (B,D), and one more child of the DC0 resource (C).
0GB 10GB 20GB 30GB 40GB 50GB 60GB |----------|----------|----------|----------|----------|----------| | | |----------|----------| | |----------| | |----------| | | | | | (S) (A) (B) (C) (D) v v v v v |XXXXX|----|XXXXX|----|----------|----------|----------|XXXXX-----| skip skip skip skip skipExpand the calculation of DPA free space and enhance the logic to support this more complex skipping. To track the potential of multiple skip resources an xarray is attached to the endpoint decoder. The existing algorithm between RAM and PMEM is consolidated within the new one to streamline the code even though the result is the storage of a single skip resource in the xarray.
Quoted 4 lines
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
One query below + request to add a comment on it for when I've again completely forgotten how this works.
Also a grumpy reviewer comment.
Quoted 4 lines
drivers/cxl/core/hdm.c +4
-0+static int cxl_reserve_dpa_skip (struct cxl_endpoint_decoder *cxled, +resource_size_t base,resource_size_t skipped) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);
drivers/cxl/core/hdm.c static void devm_cxl_dpa_release(struct cxl_endpoint_decoder *cxled) · line 351
Quoted 10 lines
drivers/cxl/core/hdm.c +9
-0+struct cxl_port *port =cxled_to_port (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; +resource_size_t skip_base = base - skipped; +struct device *dev = &port->dev; +resource_size_t skip_len =0 ; +int rc, index; + + index =dc_mode_to_region_index (cxled->mode); +for (int i =0 ; i <= index; i++) {
I'm not sure why this is <= so maybe a comment?
Quoted 34 lines
drivers/cxl/core/hdm.c +32
-0+struct resource *dcr = &cxlds->dc_res[i]; + +if (skip_base < dcr->start) { + skip_len = dcr->start - skip_base; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + +if (skip_base == base) { +dev_dbg (dev,"skip done DC region %d!\n" , i); +break ; + } + +if (resource_size (dcr) && skip_base <= dcr->end) { +if (skip_base > base) { +dev_err (dev,"Skip error DC region %d; skip_base %pa; base %pa\n" , + i, &skip_base, &base); +return -ENXIO ; + } + + skip_len = dcr->end - skip_base +1 ; + rc =cxl_request_skip (cxled, skip_base, skip_len); +if (rc) +return rc; + skip_base += skip_len; + } + } + +return 0 ; +}
drivers/cxl/core/hdm.c int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled, · line 592
Quoted 6 lines
drivers/cxl/core/hdm.c +1
-1@@ -466,8 +588,8 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,int cxl_dpa_alloc (struct cxl_endpoint_decoder *cxled,unsigned long long size) { -struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);resource_size_t free_ram_start, free_pmem_start; +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled);
Patch noise. Put it back where it was! (assuming I haven't failed to spot the difference)
Quoted 3 lines
drivers/cxl/core/hdm.c +0
-0struct cxl_port *port =cxled_to_port (cxled);struct cxl_dev_state *cxlds = cxlmd->cxlds;struct device *dev = &cxled->cxld.dev;
PATCH v3 10/25 cxl/port: Add endpoint decoder DC mode support to sysfs
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Endpoint decoder mode is used to represent the partition the decoder points to such as ram or pmem.
Expand the mode to allow a decoder to point to a specific DC partition (Region).
---
Changes:
[Fan: change mode range logic]
[Fan: use !resource_size()]
[djiang: use the static mode name string array in mode_store()] [Jonathan: remove rc check from mode to region index]
[Jonathan: clarify decoder mode 'mixed']
[djbw: drop cleanup patch and just follow the convention in cxl_dpa_set_mode()] [fan: make dcd resource size check similar to other partitions] [djbw, jonathan, fan: remove mode range check from dc_mode_to_region_index] [iweiny: push sysfs versions to 6.12]
--- Documentation/ABI/testing/sysfs-bus-cxl | 21 ++++++++++---------- drivers/cxl/core/hdm.c | 10 ++++++++++ drivers/cxl/core/port.c | 10 +++++----- drivers/cxl/cxl.h | 35 ++++++++++++++++++--------------- 4 files changed, 45 insertions(+), 31 deletions(-)
Documentation/ABI/testing/sysfs-bus-cxl +11 -10
@@ -316,23 +316,24 @@ Description: What: /sys/bus/cxl/devices/decoderX.Y/mode -Date: May, 2022 -KernelVersion: v6.0 +Date: May, 2022, October 2024 +KernelVersion: v6.0, v6.12 (dcY) Contact: [email protected] Description: (RW) When a CXL decoder is of devtype "cxl_decoder_endpoint" it translates from a host physical address range, to a device local address range. Device-local address ranges are further split - into a 'ram' (volatile memory) range and 'pmem' (persistent - memory) range. The 'mode' attribute emits one of 'ram', 'pmem', - 'mixed', or 'none'. The 'mixed' indication is for error cases - when a decoder straddles the volatile/persistent partition - boundary, and 'none' indicates the decoder is not actively - decoding, or no DPA allocation policy has been set. + into a 'ram' (volatile memory) range, 'pmem' (persistent + memory) range, or Dynamic Capacity (DC) range. The 'mode' + attribute emits one of 'ram', 'pmem', 'dcY', 'mixed', or + 'none'. The 'mixed' indication is for error cases when a + decoder straddles partition boundaries, and 'none' indicates + the decoder is not actively decoding, or no DPA allocation + policy has been set. 'mode' can be written, when the decoder is in the 'disabled' - state, with either 'ram' or 'pmem' to set the boundaries for the - next allocation. + state, with 'ram', 'pmem', or 'dcY' to set the boundaries for + the next allocation. What: /sys/bus/cxl/devices/decoderX.Y/dpa_resource
drivers/cxl/core/hdm.c +10 -0
@@ -551,6 +551,7 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,switch (mode) {case CXL_DECODER_RAM :case CXL_DECODER_PMEM : + case CXL_DECODER_DC0 ... CXL_DECODER_DC7:break ;default :dev_dbg (dev,"unsupported mode: %d\n" , mode);
@@ -578,6 +579,15 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled, goto out; } +if (mode >=CXL_DECODER_DC0 && mode <=CXL_DECODER_DC7 ) { + rc =dc_mode_to_region_index (mode); +if (!resource_size (&cxlds->dc_res[rc])) { +dev_dbg (dev,"no available dynamic capacity\n" ); + rc = -ENXIO ; + goto out; + } + } + cxled->mode = mode; rc =0 ; out:
drivers/cxl/core/port.c +5 -5
@@ -205,11 +205,11 @@ static ssize_t mode_store(struct device *dev, struct device_attribute *attr,enum cxl_decoder_mode mode;ssize_t rc; -if (sysfs_streq (buf,"pmem" )) - mode =CXL_DECODER_PMEM ; -else if (sysfs_streq (buf,"ram" )) - mode =CXL_DECODER_RAM ; -else +for (mode =CXL_DECODER_RAM ; mode <CXL_DECODER_MIXED ; mode++) +if (sysfs_streq (buf, cxl_decoder_mode_names[mode])) +break ; + +if (mode >=CXL_DECODER_MIXED )return -EINVAL ; rc =cxl_dpa_set_mode (cxled, mode);
drivers/cxl/cxl.h +19 -16
@@ -365,6 +365,9 @@ struct cxl_decoder {/* * CXL_DECODER_DEAD prevents endpoints from being reattached to regions * while cxld_unregister() is running +* +* NOTE: CXL_DECODER_RAM must be second and CXL_DECODER_MIXED must be last. +* See mode_store() */ enum cxl_decoder_mode {CXL_DECODER_NONE ,
@@ -382,25 +385,25 @@ enum cxl_decoder_mode { CXL_DECODER_DEAD, }; +static const char *const cxl_decoder_mode_names[] = { + [CXL_DECODER_NONE ] ="none" , + [CXL_DECODER_RAM ] ="ram" , + [CXL_DECODER_PMEM ] ="pmem" , + [CXL_DECODER_DC0 ] ="dc0" , + [CXL_DECODER_DC1 ] ="dc1" , + [CXL_DECODER_DC2 ] ="dc2" , + [CXL_DECODER_DC3 ] ="dc3" , + [CXL_DECODER_DC4 ] ="dc4" , + [CXL_DECODER_DC5 ] ="dc5" , + [CXL_DECODER_DC6 ] ="dc6" , + [CXL_DECODER_DC7 ] ="dc7" , + [CXL_DECODER_MIXED ] ="mixed" , +}; +static inline const char *cxl_decoder_mode_name (enum cxl_decoder_mode mode) { -static const char *const names[] = { - [CXL_DECODER_NONE ] ="none" , - [CXL_DECODER_RAM ] ="ram" , - [CXL_DECODER_PMEM ] ="pmem" , - [CXL_DECODER_DC0 ] ="dc0" , - [CXL_DECODER_DC1 ] ="dc1" , - [CXL_DECODER_DC2 ] ="dc2" , - [CXL_DECODER_DC3 ] ="dc3" , - [CXL_DECODER_DC4 ] ="dc4" , - [CXL_DECODER_DC5 ] ="dc5" , - [CXL_DECODER_DC6 ] ="dc6" , - [CXL_DECODER_DC7 ] ="dc7" , - [CXL_DECODER_MIXED ] ="mixed" , - }; -if (mode >=CXL_DECODER_NONE && mode <=CXL_DECODER_MIXED ) -return names[mode]; +return cxl_decoder_mode_names[mode];return "mixed" ; }
Signature · 1 line
2.45.2
Re: [PATCH v3 10/25] cxl/port: Add endpoint decoder DC mode support to sysfs
Quoted 11 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Endpoint decoder mode is used to represent the partition the decoder points to such as ram or pmem.
Expand the mode to allow a decoder to point to a specific DC partition (Region).
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 164 lines
---
Changes:
[Fan: change mode range logic]
[Fan: use !resource_size()]
[djiang: use the static mode name string array inmode_store()] [Jonathan: remove rc check from mode to region index]
[Jonathan: clarify decoder mode 'mixed']
[djbw: drop cleanup patch and just follow the convention incxl_dpa_set_mode()] [fan: make dcd resource size check similar to other partitions] [djbw, jonathan, fan: remove mode range check fromdc_mode_to_region_index] [iweiny: push sysfs versions to 6.12]--- Documentation/ABI/testing/sysfs-bus-cxl | 21 ++++++++++---------- drivers/cxl/core/hdm.c | 10 ++++++++++ drivers/cxl/core/port.c | 10 +++++----- drivers/cxl/cxl.h | 35 ++++++++++++++++++--------------- 4 files changed, 45 insertions(+), 31 deletions(-)Documentation/ABI/testing/sysfs-bus-cxl +11
-10@@ -316,23 +316,24 @@ Description: What: /sys/bus/cxl/devices/decoderX.Y/mode -Date: May, 2022 -KernelVersion: v6.0 +Date: May, 2022, October 2024 +KernelVersion: v6.0, v6.12 (dcY) Contact: [email protected] Description: (RW) When a CXL decoder is of devtype "cxl_decoder_endpoint" it translates from a host physical address range, to a device local address range. Device-local address ranges are further split - into a 'ram' (volatile memory) range and 'pmem' (persistent - memory) range. The 'mode' attribute emits one of 'ram', 'pmem', - 'mixed', or 'none'. The 'mixed' indication is for error cases - when a decoder straddles the volatile/persistent partition - boundary, and 'none' indicates the decoder is not actively - decoding, or no DPA allocation policy has been set. + into a 'ram' (volatile memory) range, 'pmem' (persistent + memory) range, or Dynamic Capacity (DC) range. The 'mode' + attribute emits one of 'ram', 'pmem', 'dcY', 'mixed', or + 'none'. The 'mixed' indication is for error cases when a + decoder straddles partition boundaries, and 'none' indicates + the decoder is not actively decoding, or no DPA allocation + policy has been set. 'mode' can be written, when the decoder is in the 'disabled' - state, with either 'ram' or 'pmem' to set the boundaries for the - next allocation. + state, with 'ram', 'pmem', or 'dcY' to set the boundaries for + the next allocation. What: /sys/bus/cxl/devices/decoderX.Y/dpa_resourcedrivers/cxl/core/hdm.c +10
-0@@ -551,6 +551,7 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled,switch (mode) {case CXL_DECODER_RAM :case CXL_DECODER_PMEM : + case CXL_DECODER_DC0 ... CXL_DECODER_DC7:break ;default :dev_dbg (dev,"unsupported mode: %d\n" , mode);@@ -578,6 +579,15 @@ int cxl_dpa_set_mode(struct cxl_endpoint_decoder *cxled, goto out; } +if (mode >=CXL_DECODER_DC0 && mode <=CXL_DECODER_DC7 ) { + rc =dc_mode_to_region_index (mode); +if (!resource_size (&cxlds->dc_res[rc])) { +dev_dbg (dev,"no available dynamic capacity\n" ); + rc = -ENXIO ; + goto out; + } + } + cxled->mode = mode; rc =0 ; out:drivers/cxl/core/port.c +5
-5@@ -205,11 +205,11 @@ static ssize_t mode_store(struct device *dev, struct device_attribute *attr,enum cxl_decoder_mode mode;ssize_t rc; -if (sysfs_streq (buf,"pmem" )) - mode =CXL_DECODER_PMEM ; -else if (sysfs_streq (buf,"ram" )) - mode =CXL_DECODER_RAM ; -else +for (mode =CXL_DECODER_RAM ; mode <CXL_DECODER_MIXED ; mode++) +if (sysfs_streq (buf, cxl_decoder_mode_names[mode])) +break ; + +if (mode >=CXL_DECODER_MIXED )return -EINVAL ; rc =cxl_dpa_set_mode (cxled, mode);drivers/cxl/cxl.h +19
-16@@ -365,6 +365,9 @@ struct cxl_decoder {/* * CXL_DECODER_DEAD prevents endpoints from being reattached to regions * while cxld_unregister() is running +* +* NOTE: CXL_DECODER_RAM must be second and CXL_DECODER_MIXED must be last. +* See mode_store() */ enum cxl_decoder_mode {CXL_DECODER_NONE ,@@ -382,25 +385,25 @@ enum cxl_decoder_mode { CXL_DECODER_DEAD, }; +static const char *const cxl_decoder_mode_names[] = { + [CXL_DECODER_NONE ] ="none" , + [CXL_DECODER_RAM ] ="ram" , + [CXL_DECODER_PMEM ] ="pmem" , + [CXL_DECODER_DC0 ] ="dc0" , + [CXL_DECODER_DC1 ] ="dc1" , + [CXL_DECODER_DC2 ] ="dc2" , + [CXL_DECODER_DC3 ] ="dc3" , + [CXL_DECODER_DC4 ] ="dc4" , + [CXL_DECODER_DC5 ] ="dc5" , + [CXL_DECODER_DC6 ] ="dc6" , + [CXL_DECODER_DC7 ] ="dc7" , + [CXL_DECODER_MIXED ] ="mixed" , +}; +static inline const char *cxl_decoder_mode_name (enum cxl_decoder_mode mode) { -static const char *const names[] = { - [CXL_DECODER_NONE ] ="none" , - [CXL_DECODER_RAM ] ="ram" , - [CXL_DECODER_PMEM ] ="pmem" , - [CXL_DECODER_DC0 ] ="dc0" , - [CXL_DECODER_DC1 ] ="dc1" , - [CXL_DECODER_DC2 ] ="dc2" , - [CXL_DECODER_DC3 ] ="dc3" , - [CXL_DECODER_DC4 ] ="dc4" , - [CXL_DECODER_DC5 ] ="dc5" , - [CXL_DECODER_DC6 ] ="dc6" , - [CXL_DECODER_DC7 ] ="dc7" , - [CXL_DECODER_MIXED ] ="mixed" , - }; -if (mode >=CXL_DECODER_NONE && mode <=CXL_DECODER_MIXED ) -return names[mode]; +return cxl_decoder_mode_names[mode];return "mixed" ; }
Re: [PATCH v3 10/25] cxl/port: Add endpoint decoder DC mode support to sysfs
In reply to [email protected]Quoted 5 lines · On Fri, 16 Aug 2024 09:44:18 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
Endpoint decoder mode is used to represent the partition the decoder points to such as ram or pmem.
Quoted 7 lines
Expand the mode to allow a decoder to point to a specific DC partition (Region).
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 11/25 cxl/mem: Expose DCD partition capabilities in sysfs
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
To properly configure CXL regions on Dynamic Capacity Devices (DCD), user space will need to know the details of the DC partitions available.
Expose dynamic capacity capabilities through sysfs.
---
Changes:
[iweiny: remove review tags]
[Davidlohr/Fan/Jonathan: omit 'dc' attribute directory if device is not DC] [Jonathan: update documentation for dc visibility]
[Jonathan: Add a comment to DC region X attributes to ensure visibility checks work] [iweiny: push sysfs version to 6.12]
--- Documentation/ABI/testing/sysfs-bus-cxl | 12 ++++ drivers/cxl/core/memdev.c | 97 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+)
Documentation/ABI/testing/sysfs-bus-cxl +12 -0
@@ -54,6 +54,18 @@ Description: identically named field in the Identify Memory Device Output Payload in the CXL-2.0 specification. +What: /sys/bus/cxl/devices/memX/dc/region_count + /sys/bus/cxl/devices/memX/dc/regionY_size +Date: August, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) Dynamic Capacity (DC) region information. The dc + directory is only visible on devices which support Dynamic + Capacity. + The region_count is the number of Dynamic Capacity (DC) + partitions (regions) supported on the device. + regionY_size is the size of each of those partitions. What: /sys/bus/cxl/devices/memX/pmem/qos_class Date: May, 2023
drivers/cxl/core/memdev.c +97 -0
115 lines not on this page · raw message
Signature · 1 line
2.45.2
Dave Jiang
maintainerRe: [PATCH v3 11/25] cxl/mem: Expose DCD partition capabilities in sysfs
Quoted 28 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
To properly configure CXL regions on Dynamic Capacity Devices (DCD), user space will need to know the details of the DC partitions available.
Expose dynamic capacity capabilities through sysfs.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: remove review tags]
[Davidlohr/Fan/Jonathan: omit 'dc' attribute directory if device is not DC] [Jonathan: update documentation for dc visibility]
[Jonathan: Add a comment to DC region X attributes to ensure visibility checks work] [iweiny: push sysfs version to 6.12]--- Documentation/ABI/testing/sysfs-bus-cxl | 12 ++++ drivers/cxl/core/memdev.c | 97 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+)Documentation/ABI/testing/sysfs-bus-cxl +0
-0
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 58
Quoted 5 lines
Documentation/ABI/testing/sysfs-bus-cxl +2
-0@@ -54,6 +54,18 @@ Description: identically named field in the Identify Memory Device Output Payload in the CXL-2.0 specification. +What: /sys/bus/cxl/devices/memX/dc/region_count + /sys/bus/cxl/devices/memX/dc/regionY_size
Just make it into 2 separate entries?
DJ
Quoted 136 lines
Documentation/ABI/testing/sysfs-bus-cxl +10
-0+Date: August, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) Dynamic Capacity (DC) region information. The dc + directory is only visible on devices which support Dynamic + Capacity. + The region_count is the number of Dynamic Capacity (DC) + partitions (regions) supported on the device. + regionY_size is the size of each of those partitions. What: /sys/bus/cxl/devices/memX/pmem/qos_class Date: May, 2023drivers/cxl/core/memdev.c +97
-0@@ -101,6 +101,18 @@ static ssize_t pmem_size_show(struct device *dev, struct device_attribute *attr,static struct device_attribute dev_attr_pmem_size =__ATTR (size,0444 , pmem_size_show,NULL ); +static ssize_t region_count_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct cxl_memdev *cxlmd =to_cxl_memdev (dev); +struct cxl_memdev_state *mds =to_cxl_memdev_state (cxlmd->cxlds); + +return sysfs_emit (buf,"%d\n" , mds->nr_dc_region); +} + +static struct device_attribute dev_attr_region_count = +__ATTR (region_count,0444 , region_count_show,NULL ); +static ssize_t serial_show (struct device *dev,struct device_attribute *attr,char *buf) {@@ -448,6 +460,90 @@ static struct attribute *cxl_memdev_security_attributes[] = { NULL, }; +static ssize_t show_size_regionN (struct cxl_memdev *cxlmd,char *buf,int pos) +{ +struct cxl_memdev_state *mds =to_cxl_memdev_state (cxlmd->cxlds); + +return sysfs_emit (buf,"%#llx\n" , mds->dc_region[pos].decode_len); +} + +#define REGION_SIZE_ATTR_RO (n) \ +static ssize_t region##n##_size_show(struct device *dev, \ + struct device_attribute *attr, \ + char *buf) \ +{ \ + return show_size_regionN(to_cxl_memdev(dev), buf, (n)); \ +} \ +static DEVICE_ATTR_RO(region##n##_size) +REGION_SIZE_ATTR_RO (0 ); +REGION_SIZE_ATTR_RO (1 ); +REGION_SIZE_ATTR_RO (2 ); +REGION_SIZE_ATTR_RO (3 ); +REGION_SIZE_ATTR_RO (4 ); +REGION_SIZE_ATTR_RO (5 ); +REGION_SIZE_ATTR_RO (6 ); +REGION_SIZE_ATTR_RO (7 ); + +/* +* RegionX attributes must be listed in order and first in this array to +* support the visbility checks. +*/ +static struct attribute *cxl_memdev_dc_attributes[] = { + &dev_attr_region0_size.attr, + &dev_attr_region1_size.attr, + &dev_attr_region2_size.attr, + &dev_attr_region3_size.attr, + &dev_attr_region4_size.attr, + &dev_attr_region5_size.attr, + &dev_attr_region6_size.attr, + &dev_attr_region7_size.attr, + &dev_attr_region_count.attr, +NULL , +}; + +static umode_t cxl_memdev_dc_attr_visible (struct kobject *kobj,struct attribute *a,int n) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_memdev *cxlmd =to_cxl_memdev (dev); +struct cxl_memdev_state *mds =to_cxl_memdev_state (cxlmd->cxlds); + +/* Not a memory device */ +if (!mds) +return 0 ; + +if (a == &dev_attr_region_count.attr) +return a->mode; + +/* +* Show only the regions supported, regionX attributes are first in the +* list +*/ +if (n < mds->nr_dc_region) +return a->mode; + +return 0 ; +} + +static bool cxl_memdev_dc_group_visible (struct kobject *kobj) +{ +struct device *dev =kobj_to_dev (kobj); +struct cxl_memdev *cxlmd =to_cxl_memdev (dev); +struct cxl_memdev_state *mds =to_cxl_memdev_state (cxlmd->cxlds); + +/* No DC regions */ +if (!mds || mds->nr_dc_region ==0 ) +return false; +return true; +} + +DEFINE_SYSFS_GROUP_VISIBLE (cxl_memdev_dc); + +static struct attribute_group cxl_memdev_dc_group = { + .name ="dc" , + .attrs = cxl_memdev_dc_attributes, + .is_visible =SYSFS_GROUP_VISIBLE (cxl_memdev_dc), +}; +static umode_t cxl_memdev_visible (struct kobject *kobj,struct attribute *a,int n) {@@ -528,6 +624,7 @@ static const struct attribute_group *cxl_memdev_attribute_groups[] = { &cxl_memdev_ram_attribute_group, &cxl_memdev_pmem_attribute_group, &cxl_memdev_security_attribute_group, + &cxl_memdev_dc_group, NULL, };
Re: [PATCH v3 11/25] cxl/mem: Expose DCD partition capabilities in sysfs
Quoted 34 lines · Dave Jiang
Quoted 31 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
To properly configure CXL regions on Dynamic Capacity Devices (DCD), user space will need to know the details of the DC partitions available.
Expose dynamic capacity capabilities through sysfs.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: remove review tags]
[Davidlohr/Fan/Jonathan: omit 'dc' attribute directory if device is not DC] [Jonathan: update documentation for dc visibility]
[Jonathan: Add a comment to DC region X attributes to ensure visibility checks work] [iweiny: push sysfs version to 6.12]--- Documentation/ABI/testing/sysfs-bus-cxl | 12 ++++ drivers/cxl/core/memdev.c | 97 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+)Documentation/ABI/testing/sysfs-bus-cxl +0
-0@@ -54,6 +54,18 @@ Description: identically named field in the Identify Memory Device Output Payload in the CXL-2.0 specification.
Quoted 4 lines
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 58
Quoted 2 lines
Documentation/ABI/testing/sysfs-bus-cxl +2
-0+What: /sys/bus/cxl/devices/memX/dc/region_count + /sys/bus/cxl/devices/memX/dc/regionY_sizeJust make it into 2 separate entries?
Do you mean in the docs?
Ira
Quoted 15 lines
DJ
Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-cxl +10
-0+Date: August, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) Dynamic Capacity (DC) region information. The dc + directory is only visible on devices which support Dynamic + Capacity. + The region_count is the number of Dynamic Capacity (DC) + partitions (regions) supported on the device. + regionY_size is the size of each of those partitions. What: /sys/bus/cxl/devices/memX/pmem/qos_class Date: May, 2023
[snip]
Dave Jiang
maintainerRe: [PATCH v3 11/25] cxl/mem: Expose DCD partition capabilities in sysfs
Quoted 35 lines · Ira Weiny
Quoted 34 lines · Dave Jiang
Quoted 31 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
To properly configure CXL regions on Dynamic Capacity Devices (DCD), user space will need to know the details of the DC partitions available.
Expose dynamic capacity capabilities through sysfs.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: remove review tags]
[Davidlohr/Fan/Jonathan: omit 'dc' attribute directory if device is not DC] [Jonathan: update documentation for dc visibility]
[Jonathan: Add a comment to DC region X attributes to ensure visibility checks work] [iweiny: push sysfs version to 6.12]--- Documentation/ABI/testing/sysfs-bus-cxl | 12 ++++ drivers/cxl/core/memdev.c | 97 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+)Documentation/ABI/testing/sysfs-bus-cxl +0
-0@@ -54,6 +54,18 @@ Description: identically named field in the Identify Memory Device Output Payload in the CXL-2.0 specification.
Quoted 6 lines
Quoted 4 lines
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 58
Quoted 2 lines
Documentation/ABI/testing/sysfs-bus-cxl +2
-0+What: /sys/bus/cxl/devices/memX/dc/region_count + /sys/bus/cxl/devices/memX/dc/regionY_sizeJust make it into 2 separate entries?
Do you mean in the docs?
Yes. Here you are combining all the sysfs entries into 1. I'm suggesting unique block per each sysfs entry with their own description.
Quoted 20 lines
Ira
Quoted 15 lines
DJ
Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-cxl +10
-0+Date: August, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) Dynamic Capacity (DC) region information. The dc + directory is only visible on devices which support Dynamic + Capacity. + The region_count is the number of Dynamic Capacity (DC) + partitions (regions) supported on the device. + regionY_size is the size of each of those partitions. What: /sys/bus/cxl/devices/memX/pmem/qos_class Date: May, 2023[snip]
Re: [PATCH v3 11/25] cxl/mem: Expose DCD partition capabilities in sysfs
In reply to Ira WeinyQuoted 35 lines · On Thu, 22 Aug 2024 21:28:41 -0500 Ira Weiny <[email protected]> wrote:
Quoted 34 lines · Dave Jiang
Quoted 31 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
To properly configure CXL regions on Dynamic Capacity Devices (DCD), user space will need to know the details of the DC partitions available.
Expose dynamic capacity capabilities through sysfs.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: remove review tags]
[Davidlohr/Fan/Jonathan: omit 'dc' attribute directory if device is not DC] [Jonathan: update documentation for dc visibility]
[Jonathan: Add a comment to DC region X attributes to ensure visibility checks work] [iweiny: push sysfs version to 6.12]--- Documentation/ABI/testing/sysfs-bus-cxl | 12 ++++ drivers/cxl/core/memdev.c | 97 +++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+)Documentation/ABI/testing/sysfs-bus-cxl +0
-0@@ -54,6 +54,18 @@ Description: identically named field in the Identify Memory Device Output Payload in the CXL-2.0 specification.
Quoted 6 lines
Quoted 4 lines
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 58
Quoted 2 lines
Documentation/ABI/testing/sysfs-bus-cxl +2
-0+What: /sys/bus/cxl/devices/memX/dc/region_count + /sys/bus/cxl/devices/memX/dc/regionY_sizeJust make it into 2 separate entries?
Do you mean in the docs?
Assuming yes, then I think it would be cleaner as two separate entries
+ Maybe even one for the directory which can then have
the visibility statement.
Quoted 21 lines
Ira
Quoted 15 lines
DJ
Quoted 13 lines
Documentation/ABI/testing/sysfs-bus-cxl +10
-0+Date: August, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) Dynamic Capacity (DC) region information. The dc + directory is only visible on devices which support Dynamic + Capacity. + The region_count is the number of Dynamic Capacity (DC) + partitions (regions) supported on the device. + regionY_size is the size of each of those partitions. What: /sys/bus/cxl/devices/memX/pmem/qos_class Date: May, 2023[snip]
PATCH v3 12/25 cxl/region: Refactor common create region code
In reply to Ira Weinycreate_pmem_region_store() and create_ram_region_store() are identical with the exception of the region mode. With the addition of DC region mode this would end up being 3 copies of the same code.
Refactor create_pmem_region_store() and create_ram_region_store() to use a single common function to be used in subsequent DC code.
--- drivers/cxl/core/region.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)
drivers/cxl/core/region.c +11 -17
@@ -2553,9 +2553,8 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,return devm_cxl_add_region (cxlrd, id, mode,CXL_DECODER_HOSTONLYMEM ); } -static ssize_t create_pmem_region_store (struct device *dev, -struct device_attribute *attr, -const char *buf,size_t len) +static ssize_t create_region_store (struct device *dev,const char *buf, +size_t len,enum cxl_region_mode mode) {struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev);struct cxl_region *cxlr;
@@ -2565,31 +2564,26 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id); + cxlr =__create_region (cxlrd, mode, id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);return len; } + +static ssize_t create_pmem_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_PMEM ); +}DEVICE_ATTR_RW (create_pmem_region);static ssize_t create_ram_region_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) { -struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev); -struct cxl_region *cxlr; -int rc, id; - - rc =sscanf (buf,"region%d\n" , &id); -if (rc !=1 ) -return -EINVAL ; - - cxlr =__create_region (cxlrd,CXL_REGION_RAM , id); -if (IS_ERR (cxlr)) -return PTR_ERR (cxlr); - -return len; +return create_region_store (dev, buf, len,CXL_REGION_RAM ); }DEVICE_ATTR_RW (create_ram_region);
Signature · 1 line
2.45.2
Re: [PATCH v3 12/25] cxl/region: Refactor common create region code
Quoted 9 lines · Ira Weiny
create_pmem_region_store()andcreate_ram_region_store()are identical with the exception of the region mode. With the addition of DC region mode this would end up being 3 copies of the same code.Refactor
create_pmem_region_store()andcreate_ram_region_store()to use a single common function to be used in subsequent DC code.Suggested-by Fan Ni <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 62 lines
--- drivers/cxl/core/region.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)drivers/cxl/core/region.c +11
-17@@ -2553,9 +2553,8 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,return devm_cxl_add_region (cxlrd, id, mode,CXL_DECODER_HOSTONLYMEM ); } -static ssize_t create_pmem_region_store (struct device *dev, -struct device_attribute *attr, -const char *buf,size_t len) +static ssize_t create_region_store (struct device *dev,const char *buf, +size_t len,enum cxl_region_mode mode) {struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev);struct cxl_region *cxlr;@@ -2565,31 +2564,26 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id); + cxlr =__create_region (cxlrd, mode, id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);return len; } + +static ssize_t create_pmem_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_PMEM ); +}DEVICE_ATTR_RW (create_pmem_region);static ssize_t create_ram_region_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) { -struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev); -struct cxl_region *cxlr; -int rc, id; - - rc =sscanf (buf,"region%d\n" , &id); -if (rc !=1 ) -return -EINVAL ; - - cxlr =__create_region (cxlrd,CXL_REGION_RAM , id); -if (IS_ERR (cxlr)) -return PTR_ERR (cxlr); - -return len; +return create_region_store (dev, buf, len,CXL_REGION_RAM ); }DEVICE_ATTR_RW (create_ram_region);
Re: [PATCH v3 12/25] cxl/region: Refactor common create region code
In reply to Ira WeinyQuoted 10 lines · Ira Weiny
create_pmem_region_store()andcreate_ram_region_store()are identical with the exception of the region mode. With the addition of DC region mode this would end up being 3 copies of the same code.Refactor
create_pmem_region_store()andcreate_ram_region_store()to use a single common function to be used in subsequent DC code.Suggested-by Fan Ni <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Quoted 64 lines
drivers/cxl/core/region.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)drivers/cxl/core/region.c +11
-17@@ -2553,9 +2553,8 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,return devm_cxl_add_region (cxlrd, id, mode,CXL_DECODER_HOSTONLYMEM ); } -static ssize_t create_pmem_region_store (struct device *dev, -struct device_attribute *attr, -const char *buf,size_t len) +static ssize_t create_region_store (struct device *dev,const char *buf, +size_t len,enum cxl_region_mode mode) {struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev);struct cxl_region *cxlr;@@ -2565,31 +2564,26 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id); + cxlr =__create_region (cxlrd, mode, id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);return len; } + +static ssize_t create_pmem_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_PMEM ); +}DEVICE_ATTR_RW (create_pmem_region);static ssize_t create_ram_region_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) { -struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev); -struct cxl_region *cxlr; -int rc, id; - - rc =sscanf (buf,"region%d\n" , &id); -if (rc !=1 ) -return -EINVAL ; - - cxlr =__create_region (cxlrd,CXL_REGION_RAM , id); -if (IS_ERR (cxlr)) -return PTR_ERR (cxlr); - -return len; +return create_region_store (dev, buf, len,CXL_REGION_RAM ); }DEVICE_ATTR_RW (create_ram_region);Signature · 2 lines
-- 2.45.2
Re: [PATCH v3 12/25] cxl/region: Refactor common create region code
In reply to Ira WeinyQuoted 9 lines · On Fri, 16 Aug 2024 09:44:20 -0500 Ira Weiny <[email protected]> wrote:
create_pmem_region_store()andcreate_ram_region_store()are identical with the exception of the region mode. With the addition of DC region mode this would end up being 3 copies of the same code.Refactor
create_pmem_region_store()andcreate_ram_region_store()to use a single common function to be used in subsequent DC code.Suggested-by Fan Ni <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Make sense
Quoted 62 lines
--- drivers/cxl/core/region.c | 28 +++++++++++----------------- 1 file changed, 11 insertions(+), 17 deletions(-)drivers/cxl/core/region.c +11
-17@@ -2553,9 +2553,8 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,return devm_cxl_add_region (cxlrd, id, mode,CXL_DECODER_HOSTONLYMEM ); } -static ssize_t create_pmem_region_store (struct device *dev, -struct device_attribute *attr, -const char *buf,size_t len) +static ssize_t create_region_store (struct device *dev,const char *buf, +size_t len,enum cxl_region_mode mode) {struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev);struct cxl_region *cxlr;@@ -2565,31 +2564,26 @@ static ssize_t create_pmem_region_store(struct device *dev,if (rc !=1 )return -EINVAL ; - cxlr =__create_region (cxlrd,CXL_REGION_PMEM , id); + cxlr =__create_region (cxlrd, mode, id);if (IS_ERR (cxlr))return PTR_ERR (cxlr);return len; } + +static ssize_t create_pmem_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_PMEM ); +}DEVICE_ATTR_RW (create_pmem_region);static ssize_t create_ram_region_store (struct device *dev,struct device_attribute *attr,const char *buf,size_t len) { -struct cxl_root_decoder *cxlrd =to_cxl_root_decoder (dev); -struct cxl_region *cxlr; -int rc, id; - - rc =sscanf (buf,"region%d\n" , &id); -if (rc !=1 ) -return -EINVAL ; - - cxlr =__create_region (cxlrd,CXL_REGION_RAM , id); -if (IS_ERR (cxlr)) -return PTR_ERR (cxlr); - -return len; +return create_region_store (dev, buf, len,CXL_REGION_RAM ); }DEVICE_ATTR_RW (create_ram_region);
Re: [PATCH v3 12/25] cxl/region: Refactor common create region code
In reply to Ira WeinyQuoted 9 lines · Ira Weiny
create_pmem_region_store()andcreate_ram_region_store()are identical with the exception of the region mode. With the addition of DC region mode this would end up being 3 copies of the same code.Refactor
create_pmem_region_store()andcreate_ram_region_store()to use a single common function to be used in subsequent DC code.Suggested-by Fan Ni <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 13/25 cxl/region: Add sparse DAX region support
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Dynamic Capacity CXL regions must allow memory to be added or removed dynamically. In addition to the quantity of memory available the location of the memory within a DC partition is dynamic based on the extents offered by a device. CXL DAX regions must accommodate the sparseness of this memory in the management of DAX regions and devices.
Introduce the concept of a sparse DAX region. Add a create_dc_region() sysfs entry to create such regions. Special case DC capable regions to create a 0 sized seed DAX device to maintain compatibility which requires a default DAX device to hold a region reference.
Indicate 0 byte available capacity until such time that capacity is added.
Sparse regions complicate the range mapping of dax devices. There is no known use case for range mapping on sparse regions. Avoid the complication by preventing range mapping of dax devices on sparse regions.
Interleaving is deferred for now. Add checks.
---
Changes:
[Fan: use single function for dc region store]
[djiang: avoid setting dev_size twice]
[djbw: Check DCD support and interleave restriction on region creation] [iweiny: squash patch : dax/region: Prevent range mapping allocation on sparse regions] [iwieny: remove reviews]
[iweiny: rebase to master]
[iweiny: push sysfs version to 6.12]
[iweiny: make cxled_to_mds inline]
--- Documentation/ABI/testing/sysfs-bus-cxl | 22 ++++++++-------- drivers/cxl/core/core.h | 12 +++++++++ drivers/cxl/core/port.c | 1 + drivers/cxl/core/region.c | 46 +++++++++++++++++++++++++++++++-- drivers/dax/bus.c | 10 +++++++ drivers/dax/bus.h | 1 + drivers/dax/cxl.c | 16 ++++++++++-- 7 files changed, 93 insertions(+), 15 deletions(-)
Documentation/ABI/testing/sysfs-bus-cxl +11 -11
@@ -406,20 +406,20 @@ Description: interleave_granularity). -What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram}_region -Date: May, 2022, January, 2023 -KernelVersion: v6.0 (pmem), v6.3 (ram) +What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram,dc}_region +Date: May, 2022, January, 2023, August 2024 +KernelVersion: v6.0 (pmem), v6.3 (ram), v6.12 (dc) Contact: [email protected] Description: (RW) Write a string in the form 'regionZ' to start the process - of defining a new persistent, or volatile memory region - (interleave-set) within the decode range bounded by root decoder - 'decoderX.Y'. The value written must match the current value - returned from reading this attribute. An atomic compare exchange - operation is done on write to assign the requested id to a - region and allocate the region-id for the next creation attempt. - EBUSY is returned if the region name written does not match the - current cached value. + of defining a new persistent, volatile, or Dynamic Capacity + (DC) memory region (interleave-set) within the decode range + bounded by root decoder 'decoderX.Y'. The value written must + match the current value returned from reading this attribute. + An atomic compare exchange operation is done on write to assign + the requested id to a region and allocate the region-id for the + next creation attempt. EBUSY is returned if the region name + written does not match the current cached value. What: /sys/bus/cxl/devices/decoderX.Y/delete_region
drivers/cxl/core/core.h +12 -0
@@ -4,15 +4,27 @@#ifndef __CXL_CORE_H__#define __CXL_CORE_H__ +#include <cxlmem.h> +extern const struct device_type cxl_nvdimm_bridge_type;extern const struct device_type cxl_nvdimm_type;extern const struct device_type cxl_pmu_type;extern struct attribute_group cxl_base_attribute_group; +static inline struct cxl_memdev_state * +cxled_to_mds (struct cxl_endpoint_decoder *cxled) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; + + return container_of(cxlds, struct cxl_memdev_state, cxlds); +} +#ifdef CONFIG_CXL_REGION extern struct device_attribute dev_attr_create_pmem_region;extern struct device_attribute dev_attr_create_ram_region; +extern struct device_attribute dev_attr_create_dc_region;extern struct device_attribute dev_attr_delete_region;extern struct device_attribute dev_attr_region;extern const struct device_type cxl_pmem_region_type;
drivers/cxl/core/port.c +1 -0
@@ -320,6 +320,7 @@ static struct attribute *cxl_decoder_root_attrs[] = { &dev_attr_qos_class.attr, SET_CXL_REGION_ATTR(create_pmem_region) SET_CXL_REGION_ATTR(create_ram_region) + SET_CXL_REGION_ATTR(create_dc_region) SET_CXL_REGION_ATTR(delete_region) NULL, };
drivers/cxl/core/region.c +44 -2
94 lines not on this page · raw message
drivers/dax/bus.c +10 -0
@@ -178,6 +178,11 @@ static bool is_static(struct dax_region *dax_region)return (dax_region->res.flags &IORESOURCE_DAX_STATIC ) !=0 ; } +static bool is_sparse (struct dax_region *dax_region) +{ +return (dax_region->res.flags &IORESOURCE_DAX_SPARSE_CAP ) !=0 ; +} +bool static_dev_dax (struct dev_dax *dev_dax) {return is_static (dev_dax->region);
@@ -301,6 +306,9 @@ static unsigned long long dax_region_avail_size(struct dax_region *dax_region)lockdep_assert_held (&dax_region_rwsem); +if (is_sparse (dax_region)) +return 0 ; +for_each_dax_region_resource (dax_region, res) size -=resource_size (res);return size;
@@ -1373,6 +1381,8 @@ static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)return 0 ;if (a == &dev_attr_mapping.attr &&is_static (dax_region))return 0 ; +if (a == &dev_attr_mapping.attr &&is_sparse (dax_region)) +return 0 ;if ((a == &dev_attr_align.attr || a == &dev_attr_size.attr) &&is_static (dax_region))return 0444 ;
drivers/dax/bus.h +1 -0
@@ -13,6 +13,7 @@ struct dax_region;/* dax bus specific ioresource flags */ #define IORESOURCE_DAX_STATIC BIT(0)#define IORESOURCE_DAX_KMEM BIT(1) +#define IORESOURCE_DAX_SPARSE_CAP BIT(2) struct dax_region *alloc_dax_region(struct device *parent, int region_id, struct range *range, int target_node, unsigned int align,
drivers/dax/cxl.c +14 -2
@@ -13,19 +13,31 @@ static int cxl_dax_region_probe(struct device *dev)struct cxl_region *cxlr = cxlr_dax->cxlr;struct dax_region *dax_region;struct dev_dax_data data; +resource_size_t dev_size; +unsigned long flags;if (nid ==NUMA_NO_NODE ) nid =memory_add_physaddr_to_nid (cxlr_dax->hpa_range.start); + flags =IORESOURCE_DAX_KMEM ; +if (cxlr->mode ==CXL_REGION_DC ) + flags |=IORESOURCE_DAX_SPARSE_CAP ; + dax_region =alloc_dax_region (dev, cxlr->id, &cxlr_dax->hpa_range, nid, -PMD_SIZE ,IORESOURCE_DAX_KMEM ); +PMD_SIZE , flags);if (!dax_region)return -ENOMEM ; +if (cxlr->mode ==CXL_REGION_DC ) +/* Add empty seed dax device */ + dev_size =0 ; +else + dev_size =range_len (&cxlr_dax->hpa_range); + data = (struct dev_dax_data ) { .dax_region = dax_region, .id =-1 , - .size =range_len (&cxlr_dax->hpa_range), + .size = dev_size, .memmap_on_memory = true, };
Signature · 1 line
2.45.2
Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support
Quoted 21 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity CXL regions must allow memory to be added or removed dynamically. In addition to the quantity of memory available the location of the memory within a DC partition is dynamic based on the extents offered by a device. CXL DAX regions must accommodate the sparseness of this memory in the management of DAX regions and devices.
Introduce the concept of a sparse DAX region. Add a
create_dc_region()sysfs entry to create such regions. Special case DC capable regions to create a 0 sized seed DAX device to maintain compatibility which requires a default DAX device to hold a region reference.Indicate 0 byte available capacity until such time that capacity is added.
Sparse regions complicate the range mapping of dax devices. There is no known use case for range mapping on sparse regions. Avoid the complication by preventing range mapping of dax devices on sparse regions.
Quoted 5 lines
Interleaving is deferred for now. Add checks.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 293 lines
---
Changes:
[Fan: use single function for dc region store]
[djiang: avoid settingdev_sizetwice]
[djbw: Check DCD support and interleave restriction on region creation] [iweiny: squash patch : dax/region: Prevent range mapping allocation on sparse regions] [iwieny: remove reviews]
[iweiny: rebase to master]
[iweiny: push sysfs version to 6.12]
[iweiny: makecxled_to_mdsinline]--- Documentation/ABI/testing/sysfs-bus-cxl | 22 ++++++++-------- drivers/cxl/core/core.h | 12 +++++++++ drivers/cxl/core/port.c | 1 + drivers/cxl/core/region.c | 46 +++++++++++++++++++++++++++++++-- drivers/dax/bus.c | 10 +++++++ drivers/dax/bus.h | 1 + drivers/dax/cxl.c | 16 ++++++++++-- 7 files changed, 93 insertions(+), 15 deletions(-)Documentation/ABI/testing/sysfs-bus-cxl +11
-11@@ -406,20 +406,20 @@ Description: interleave_granularity). -What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram}_region -Date: May, 2022, January, 2023 -KernelVersion: v6.0 (pmem), v6.3 (ram) +What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram,dc}_region +Date: May, 2022, January, 2023, August 2024 +KernelVersion: v6.0 (pmem), v6.3 (ram), v6.12 (dc) Contact: [email protected] Description: (RW) Write a string in the form 'regionZ' to start the process - of defining a new persistent, or volatile memory region - (interleave-set) within the decode range bounded by root decoder - 'decoderX.Y'. The value written must match the current value - returned from reading this attribute. An atomic compare exchange - operation is done on write to assign the requested id to a - region and allocate the region-id for the next creation attempt. - EBUSY is returned if the region name written does not match the - current cached value. + of defining a new persistent, volatile, or Dynamic Capacity + (DC) memory region (interleave-set) within the decode range + bounded by root decoder 'decoderX.Y'. The value written must + match the current value returned from reading this attribute. + An atomic compare exchange operation is done on write to assign + the requested id to a region and allocate the region-id for the + next creation attempt. EBUSY is returned if the region name + written does not match the current cached value. What: /sys/bus/cxl/devices/decoderX.Y/delete_regiondrivers/cxl/core/core.h +12
-0@@ -4,15 +4,27 @@#ifndef __CXL_CORE_H__#define __CXL_CORE_H__ +#include <cxlmem.h> +extern const struct device_type cxl_nvdimm_bridge_type;extern const struct device_type cxl_nvdimm_type;extern const struct device_type cxl_pmu_type;extern struct attribute_group cxl_base_attribute_group; +static inline struct cxl_memdev_state * +cxled_to_mds (struct cxl_endpoint_decoder *cxled) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; + + return container_of(cxlds, struct cxl_memdev_state, cxlds); +} +#ifdef CONFIG_CXL_REGION extern struct device_attribute dev_attr_create_pmem_region;extern struct device_attribute dev_attr_create_ram_region; +extern struct device_attribute dev_attr_create_dc_region;extern struct device_attribute dev_attr_delete_region;extern struct device_attribute dev_attr_region;extern const struct device_type cxl_pmem_region_type;drivers/cxl/core/port.c +1
-0@@ -320,6 +320,7 @@ static struct attribute *cxl_decoder_root_attrs[] = { &dev_attr_qos_class.attr, SET_CXL_REGION_ATTR(create_pmem_region) SET_CXL_REGION_ATTR(create_ram_region) + SET_CXL_REGION_ATTR(create_dc_region) SET_CXL_REGION_ATTR(delete_region) NULL, };drivers/cxl/core/region.c +44
-2@@ -496,6 +496,11 @@ static ssize_t interleave_ways_store(struct device *dev,if (rc)return rc; +if (cxlr->mode ==CXL_REGION_DC && val !=1 ) { +dev_err (dev,"Interleaving and DCD not supported\n" ); +return -EINVAL ; + } + rc =ways_to_eiw (val, &iw);if (rc)return rc;@@ -2174,6 +2179,7 @@ static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos,if (sysfs_streq (buf,"\n" )) rc =detach_target (cxlr, pos);else { +struct cxl_endpoint_decoder *cxled;struct device *dev; dev =bus_find_device_by_name (&cxl_bus_type,NULL , buf);@@ -2185,8 +2191,13 @@ static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos, goto out; } - rc =attach_target (cxlr,to_cxl_endpoint_decoder (dev), pos, -TASK_INTERRUPTIBLE ); + cxled =to_cxl_endpoint_decoder (dev); +if (cxlr->mode ==CXL_REGION_DC && + !cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_dbg (dev,"DCD unsupported\n" ); +return -EINVAL ; + } + rc =attach_target (cxlr, cxled, pos,TASK_INTERRUPTIBLE ); out:put_device (dev); }@@ -2534,6 +2545,7 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,switch (mode) {case CXL_REGION_RAM :case CXL_REGION_PMEM : +case CXL_REGION_DC :break ;default : dev_err(&cxlrd->cxlsd.cxld.dev, "unsupported mode %s\n",@@ -2587,6 +2599,20 @@ static ssize_t create_ram_region_store(struct device *dev, }DEVICE_ATTR_RW (create_ram_region); +static ssize_t create_dc_region_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +return __create_region_show (to_cxl_root_decoder (dev), buf); +} + +static ssize_t create_dc_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_DC ); +} +DEVICE_ATTR_RW (create_dc_region); +static ssize_t region_show (struct device *dev,struct device_attribute *attr,char *buf) {@@ -3168,6 +3194,11 @@ static int devm_cxl_add_dax_region(struct cxl_region *cxlr)struct device *dev;int rc; +if (cxlr->mode ==CXL_REGION_DC && cxlr->params.interleave_ways !=1 ) { +dev_err (&cxlr->dev,"Interleaving DC not supported\n" ); +return -EINVAL ; + } + cxlr_dax =cxl_dax_region_alloc (cxlr);if (IS_ERR (cxlr_dax))return PTR_ERR (cxlr_dax);@@ -3260,6 +3291,16 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,return ERR_PTR (-EINVAL ); mode =cxl_decoder_to_region_mode (cxled->mode); +if (mode ==CXL_REGION_DC ) { +if (!cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_err (&cxled->cxld.dev,"DCD unsupported\n" ); +return ERR_PTR (-EINVAL ); + } +if (cxled->cxld.interleave_ways !=1 ) { +dev_err (&cxled->cxld.dev,"Interleaving and DCD not supported\n" ); +return ERR_PTR (-EINVAL ); + } + } do { cxlr = __create_region(cxlrd, mode, atomic_read(&cxlrd->region_id));@@ -3467,6 +3508,7 @@ static int cxl_region_probe(struct device *dev)case CXL_REGION_PMEM :return devm_cxl_add_pmem_region (cxlr);case CXL_REGION_RAM : +case CXL_REGION_DC :/* * The region can not be manged by CXL if any portion of * it is already online as 'System RAM' drivers/dax/bus.c +10
-0@@ -178,6 +178,11 @@ static bool is_static(struct dax_region *dax_region)return (dax_region->res.flags &IORESOURCE_DAX_STATIC ) !=0 ; } +static bool is_sparse (struct dax_region *dax_region) +{ +return (dax_region->res.flags &IORESOURCE_DAX_SPARSE_CAP ) !=0 ; +} +bool static_dev_dax (struct dev_dax *dev_dax) {return is_static (dev_dax->region);@@ -301,6 +306,9 @@ static unsigned long long dax_region_avail_size(struct dax_region *dax_region)lockdep_assert_held (&dax_region_rwsem); +if (is_sparse (dax_region)) +return 0 ; +for_each_dax_region_resource (dax_region, res) size -=resource_size (res);return size;@@ -1373,6 +1381,8 @@ static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)return 0 ;if (a == &dev_attr_mapping.attr &&is_static (dax_region))return 0 ; +if (a == &dev_attr_mapping.attr &&is_sparse (dax_region)) +return 0 ;if ((a == &dev_attr_align.attr || a == &dev_attr_size.attr) &&is_static (dax_region))return 0444 ;drivers/dax/bus.h +1
-0@@ -13,6 +13,7 @@ struct dax_region;/* dax bus specific ioresource flags */ #define IORESOURCE_DAX_STATIC BIT(0)#define IORESOURCE_DAX_KMEM BIT(1) +#define IORESOURCE_DAX_SPARSE_CAP BIT(2) struct dax_region *alloc_dax_region(struct device *parent, int region_id, struct range *range, int target_node, unsigned int align,drivers/dax/cxl.c +14
-2@@ -13,19 +13,31 @@ static int cxl_dax_region_probe(struct device *dev)struct cxl_region *cxlr = cxlr_dax->cxlr;struct dax_region *dax_region;struct dev_dax_data data; +resource_size_t dev_size; +unsigned long flags;if (nid ==NUMA_NO_NODE ) nid =memory_add_physaddr_to_nid (cxlr_dax->hpa_range.start); + flags =IORESOURCE_DAX_KMEM ; +if (cxlr->mode ==CXL_REGION_DC ) + flags |=IORESOURCE_DAX_SPARSE_CAP ; + dax_region =alloc_dax_region (dev, cxlr->id, &cxlr_dax->hpa_range, nid, -PMD_SIZE ,IORESOURCE_DAX_KMEM ); +PMD_SIZE , flags);if (!dax_region)return -ENOMEM ; +if (cxlr->mode ==CXL_REGION_DC ) +/* Add empty seed dax device */ + dev_size =0 ; +else + dev_size =range_len (&cxlr_dax->hpa_range); + data = (struct dev_dax_data ) { .dax_region = dax_region, .id =-1 , - .size =range_len (&cxlr_dax->hpa_range), + .size = dev_size, .memmap_on_memory = true, };
Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support
In reply to [email protected]Quoted 132 lines · On Fri, Aug 16, 2024 at 09:44:21AM -0500, [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity CXL regions must allow memory to be added or removed dynamically. In addition to the quantity of memory available the location of the memory within a DC partition is dynamic based on the extents offered by a device. CXL DAX regions must accommodate the sparseness of this memory in the management of DAX regions and devices.
Introduce the concept of a sparse DAX region. Add a
create_dc_region()sysfs entry to create such regions. Special case DC capable regions to create a 0 sized seed DAX device to maintain compatibility which requires a default DAX device to hold a region reference.Indicate 0 byte available capacity until such time that capacity is added.
Sparse regions complicate the range mapping of dax devices. There is no known use case for range mapping on sparse regions. Avoid the complication by preventing range mapping of dax devices on sparse regions.
Interleaving is deferred for now. Add checks.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[Fan: use single function for dc region store]
[djiang: avoid settingdev_sizetwice]
[djbw: Check DCD support and interleave restriction on region creation] [iweiny: squash patch : dax/region: Prevent range mapping allocation on sparse regions] [iwieny: remove reviews]
[iweiny: rebase to master]
[iweiny: push sysfs version to 6.12]
[iweiny: makecxled_to_mdsinline]--- Documentation/ABI/testing/sysfs-bus-cxl | 22 ++++++++-------- drivers/cxl/core/core.h | 12 +++++++++ drivers/cxl/core/port.c | 1 + drivers/cxl/core/region.c | 46 +++++++++++++++++++++++++++++++-- drivers/dax/bus.c | 10 +++++++ drivers/dax/bus.h | 1 + drivers/dax/cxl.c | 16 ++++++++++-- 7 files changed, 93 insertions(+), 15 deletions(-)Documentation/ABI/testing/sysfs-bus-cxl +11
-11@@ -406,20 +406,20 @@ Description: interleave_granularity). -What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram}_region -Date: May, 2022, January, 2023 -KernelVersion: v6.0 (pmem), v6.3 (ram) +What: /sys/bus/cxl/devices/decoderX.Y/create_{pmem,ram,dc}_region +Date: May, 2022, January, 2023, August 2024 +KernelVersion: v6.0 (pmem), v6.3 (ram), v6.12 (dc) Contact: [email protected] Description: (RW) Write a string in the form 'regionZ' to start the process - of defining a new persistent, or volatile memory region - (interleave-set) within the decode range bounded by root decoder - 'decoderX.Y'. The value written must match the current value - returned from reading this attribute. An atomic compare exchange - operation is done on write to assign the requested id to a - region and allocate the region-id for the next creation attempt. - EBUSY is returned if the region name written does not match the - current cached value. + of defining a new persistent, volatile, or Dynamic Capacity + (DC) memory region (interleave-set) within the decode range + bounded by root decoder 'decoderX.Y'. The value written must + match the current value returned from reading this attribute. + An atomic compare exchange operation is done on write to assign + the requested id to a region and allocate the region-id for the + next creation attempt. EBUSY is returned if the region name + written does not match the current cached value. What: /sys/bus/cxl/devices/decoderX.Y/delete_regiondrivers/cxl/core/core.h +12
-0@@ -4,15 +4,27 @@#ifndef __CXL_CORE_H__#define __CXL_CORE_H__ +#include <cxlmem.h> +extern const struct device_type cxl_nvdimm_bridge_type;extern const struct device_type cxl_nvdimm_type;extern const struct device_type cxl_pmu_type;extern struct attribute_group cxl_base_attribute_group; +static inline struct cxl_memdev_state * +cxled_to_mds (struct cxl_endpoint_decoder *cxled) +{ +struct cxl_memdev *cxlmd =cxled_to_memdev (cxled); +struct cxl_dev_state *cxlds = cxlmd->cxlds; + + return container_of(cxlds, struct cxl_memdev_state, cxlds); +} +#ifdef CONFIG_CXL_REGION extern struct device_attribute dev_attr_create_pmem_region;extern struct device_attribute dev_attr_create_ram_region; +extern struct device_attribute dev_attr_create_dc_region;extern struct device_attribute dev_attr_delete_region;extern struct device_attribute dev_attr_region;extern const struct device_type cxl_pmem_region_type;drivers/cxl/core/port.c +1
-0@@ -320,6 +320,7 @@ static struct attribute *cxl_decoder_root_attrs[] = { &dev_attr_qos_class.attr, SET_CXL_REGION_ATTR(create_pmem_region) SET_CXL_REGION_ATTR(create_ram_region) + SET_CXL_REGION_ATTR(create_dc_region) SET_CXL_REGION_ATTR(delete_region) NULL, };drivers/cxl/core/region.c +0
-0
drivers/cxl/core/region.c static ssize_t interleave_ways_store(struct device *dev, · line 500
Quoted 5 lines
drivers/cxl/core/region.c +2
-0@@ -496,6 +496,11 @@ static ssize_t interleave_ways_store(struct device *dev,if (rc)return rc; +if (cxlr->mode ==CXL_REGION_DC && val !=1 ) { +dev_err (dev,"Interleaving and DCD not supported\n" );
Is there a typo here?
Maybe "Interleaving a DCD not supported"?
Quoted 72 lines
drivers/cxl/core/region.c +31
-2+return -EINVAL ; + } + rc =ways_to_eiw (val, &iw);if (rc)return rc;@@ -2174,6 +2179,7 @@ static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos,if (sysfs_streq (buf,"\n" )) rc =detach_target (cxlr, pos);else { +struct cxl_endpoint_decoder *cxled;struct device *dev; dev =bus_find_device_by_name (&cxl_bus_type,NULL , buf);@@ -2185,8 +2191,13 @@ static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos, goto out; } - rc =attach_target (cxlr,to_cxl_endpoint_decoder (dev), pos, -TASK_INTERRUPTIBLE ); + cxled =to_cxl_endpoint_decoder (dev); +if (cxlr->mode ==CXL_REGION_DC && + !cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_dbg (dev,"DCD unsupported\n" ); +return -EINVAL ; + } + rc =attach_target (cxlr, cxled, pos,TASK_INTERRUPTIBLE ); out:put_device (dev); }@@ -2534,6 +2545,7 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,switch (mode) {case CXL_REGION_RAM :case CXL_REGION_PMEM : +case CXL_REGION_DC :break ;default : dev_err(&cxlrd->cxlsd.cxld.dev, "unsupported mode %s\n",@@ -2587,6 +2599,20 @@ static ssize_t create_ram_region_store(struct device *dev, }DEVICE_ATTR_RW (create_ram_region); +static ssize_t create_dc_region_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +return __create_region_show (to_cxl_root_decoder (dev), buf); +} + +static ssize_t create_dc_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_DC ); +} +DEVICE_ATTR_RW (create_dc_region); +static ssize_t region_show (struct device *dev,struct device_attribute *attr,char *buf) {@@ -3168,6 +3194,11 @@ static int devm_cxl_add_dax_region(struct cxl_region *cxlr)struct device *dev;int rc; +if (cxlr->mode ==CXL_REGION_DC && cxlr->params.interleave_ways !=1 ) { +dev_err (&cxlr->dev,"Interleaving DC not supported\n" ); +return -EINVAL ; + } + cxlr_dax =cxl_dax_region_alloc (cxlr);if (IS_ERR (cxlr_dax))return PTR_ERR (cxlr_dax);
drivers/cxl/core/region.c static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd, · line 3300
Quoted 10 lines
drivers/cxl/core/region.c +7
-0@@ -3260,6 +3291,16 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,return ERR_PTR (-EINVAL ); mode =cxl_decoder_to_region_mode (cxled->mode); +if (mode ==CXL_REGION_DC ) { +if (!cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_err (&cxled->cxld.dev,"DCD unsupported\n" ); +return ERR_PTR (-EINVAL ); + } +if (cxled->cxld.interleave_ways !=1 ) { +dev_err (&cxled->cxld.dev,"Interleaving and DCD not supported\n" );
If it goes here, it means DCD is upported, but interleaving is not, so the message here may also need change.
Fan
Quoted 103 lines
drivers/cxl/core/region.c +4
-0+return ERR_PTR (-EINVAL ); + } + } do { cxlr = __create_region(cxlrd, mode, atomic_read(&cxlrd->region_id));@@ -3467,6 +3508,7 @@ static int cxl_region_probe(struct device *dev)case CXL_REGION_PMEM :return devm_cxl_add_pmem_region (cxlr);case CXL_REGION_RAM : +case CXL_REGION_DC :/* * The region can not be manged by CXL if any portion of * it is already online as 'System RAM' drivers/dax/bus.c +10
-0@@ -178,6 +178,11 @@ static bool is_static(struct dax_region *dax_region)return (dax_region->res.flags &IORESOURCE_DAX_STATIC ) !=0 ; } +static bool is_sparse (struct dax_region *dax_region) +{ +return (dax_region->res.flags &IORESOURCE_DAX_SPARSE_CAP ) !=0 ; +} +bool static_dev_dax (struct dev_dax *dev_dax) {return is_static (dev_dax->region);@@ -301,6 +306,9 @@ static unsigned long long dax_region_avail_size(struct dax_region *dax_region)lockdep_assert_held (&dax_region_rwsem); +if (is_sparse (dax_region)) +return 0 ; +for_each_dax_region_resource (dax_region, res) size -=resource_size (res);return size;@@ -1373,6 +1381,8 @@ static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)return 0 ;if (a == &dev_attr_mapping.attr &&is_static (dax_region))return 0 ; +if (a == &dev_attr_mapping.attr &&is_sparse (dax_region)) +return 0 ;if ((a == &dev_attr_align.attr || a == &dev_attr_size.attr) &&is_static (dax_region))return 0444 ;drivers/dax/bus.h +1
-0@@ -13,6 +13,7 @@ struct dax_region;/* dax bus specific ioresource flags */ #define IORESOURCE_DAX_STATIC BIT(0)#define IORESOURCE_DAX_KMEM BIT(1) +#define IORESOURCE_DAX_SPARSE_CAP BIT(2) struct dax_region *alloc_dax_region(struct device *parent, int region_id, struct range *range, int target_node, unsigned int align,drivers/dax/cxl.c +14
-2@@ -13,19 +13,31 @@ static int cxl_dax_region_probe(struct device *dev)struct cxl_region *cxlr = cxlr_dax->cxlr;struct dax_region *dax_region;struct dev_dax_data data; +resource_size_t dev_size; +unsigned long flags;if (nid ==NUMA_NO_NODE ) nid =memory_add_physaddr_to_nid (cxlr_dax->hpa_range.start); + flags =IORESOURCE_DAX_KMEM ; +if (cxlr->mode ==CXL_REGION_DC ) + flags |=IORESOURCE_DAX_SPARSE_CAP ; + dax_region =alloc_dax_region (dev, cxlr->id, &cxlr_dax->hpa_range, nid, -PMD_SIZE ,IORESOURCE_DAX_KMEM ); +PMD_SIZE , flags);if (!dax_region)return -ENOMEM ; +if (cxlr->mode ==CXL_REGION_DC ) +/* Add empty seed dax device */ + dev_size =0 ; +else + dev_size =range_len (&cxlr_dax->hpa_range); + data = (struct dev_dax_data ) { .dax_region = dax_region, .id =-1 , - .size =range_len (&cxlr_dax->hpa_range), + .size = dev_size, .memmap_on_memory = true, };Signature · 2 lines
-- 2.45.2
Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support
In reply to [email protected]Quoted 21 lines · On Fri, 16 Aug 2024 09:44:21 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity CXL regions must allow memory to be added or removed dynamically. In addition to the quantity of memory available the location of the memory within a DC partition is dynamic based on the extents offered by a device. CXL DAX regions must accommodate the sparseness of this memory in the management of DAX regions and devices.
Introduce the concept of a sparse DAX region. Add a
create_dc_region()sysfs entry to create such regions. Special case DC capable regions to create a 0 sized seed DAX device to maintain compatibility which requires a default DAX device to hold a region reference.Indicate 0 byte available capacity until such time that capacity is added.
Sparse regions complicate the range mapping of dax devices. There is no known use case for range mapping on sparse regions. Avoid the complication by preventing range mapping of dax devices on sparse regions.
Quoted 5 lines
Interleaving is deferred for now. Add checks.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Re: [PATCH v3 13/25] cxl/region: Add sparse DAX region support
In reply to [email protected]Quoted 47 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity CXL regions must allow memory to be added or removed dynamically. In addition to the quantity of memory available the location of the memory within a DC partition is dynamic based on the extents offered by a device. CXL DAX regions must accommodate the sparseness of this memory in the management of DAX regions and devices.
Introduce the concept of a sparse DAX region. Add a
create_dc_region()sysfs entry to create such regions. Special case DC capable regions to create a 0 sized seed DAX device to maintain compatibility which requires a default DAX device to hold a region reference.Indicate 0 byte available capacity until such time that capacity is added.
Sparse regions complicate the range mapping of dax devices. There is no known use case for range mapping on sparse regions. Avoid the complication by preventing range mapping of dax devices on sparse regions.
Interleaving is deferred for now. Add checks.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[Fan: use single function for dc region store]
[djiang: avoid settingdev_sizetwice]
[djbw: Check DCD support and interleave restriction on region creation] [iweiny: squash patch : dax/region: Prevent range mapping allocation on sparse regions] [iwieny: remove reviews]
[iweiny: rebase to master]
[iweiny: push sysfs version to 6.12]
[iweiny: makecxled_to_mdsinline]--- Documentation/ABI/testing/sysfs-bus-cxl | 22 ++++++++-------- drivers/cxl/core/core.h | 12 +++++++++ drivers/cxl/core/port.c | 1 + drivers/cxl/core/region.c | 46 +++++++++++++++++++++++++++++++-- drivers/dax/bus.c | 10 +++++++ drivers/dax/bus.h | 1 + drivers/dax/cxl.c | 16 ++++++++++-- 7 files changed, 93 insertions(+), 15 deletions(-)
[...]
drivers/cxl/core/region.c static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos, · line 2198
Quoted 11 lines
drivers/cxl/core/region.c +5
-2@@ -2185,8 +2191,13 @@ static size_t store_targetN(struct cxl_region *cxlr, const char *buf, int pos, goto out; } - rc =attach_target (cxlr,to_cxl_endpoint_decoder (dev), pos, -TASK_INTERRUPTIBLE ); + cxled =to_cxl_endpoint_decoder (dev); +if (cxlr->mode ==CXL_REGION_DC && + !cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_dbg (dev,"DCD unsupported\n" ); +return -EINVAL ;
need a 'goto out' here to dereference the device?
Quoted 157 lines
drivers/cxl/core/region.c +33
-0+ } + rc =attach_target (cxlr, cxled, pos,TASK_INTERRUPTIBLE ); out:put_device (dev); }@@ -2534,6 +2545,7 @@ static struct cxl_region *__create_region(struct cxl_root_decoder *cxlrd,switch (mode) {case CXL_REGION_RAM :case CXL_REGION_PMEM : +case CXL_REGION_DC :break ;default : dev_err(&cxlrd->cxlsd.cxld.dev, "unsupported mode %s\n",@@ -2587,6 +2599,20 @@ static ssize_t create_ram_region_store(struct device *dev, }DEVICE_ATTR_RW (create_ram_region); +static ssize_t create_dc_region_show (struct device *dev, +struct device_attribute *attr,char *buf) +{ +return __create_region_show (to_cxl_root_decoder (dev), buf); +} + +static ssize_t create_dc_region_store (struct device *dev, +struct device_attribute *attr, +const char *buf,size_t len) +{ +return create_region_store (dev, buf, len,CXL_REGION_DC ); +} +DEVICE_ATTR_RW (create_dc_region); +static ssize_t region_show (struct device *dev,struct device_attribute *attr,char *buf) {@@ -3168,6 +3194,11 @@ static int devm_cxl_add_dax_region(struct cxl_region *cxlr)struct device *dev;int rc; +if (cxlr->mode ==CXL_REGION_DC && cxlr->params.interleave_ways !=1 ) { +dev_err (&cxlr->dev,"Interleaving DC not supported\n" ); +return -EINVAL ; + } + cxlr_dax =cxl_dax_region_alloc (cxlr);if (IS_ERR (cxlr_dax))return PTR_ERR (cxlr_dax);@@ -3260,6 +3291,16 @@ static struct cxl_region *construct_region(struct cxl_root_decoder *cxlrd,return ERR_PTR (-EINVAL ); mode =cxl_decoder_to_region_mode (cxled->mode); +if (mode ==CXL_REGION_DC ) { +if (!cxl_dcd_supported (cxled_to_mds (cxled))) { +dev_err (&cxled->cxld.dev,"DCD unsupported\n" ); +return ERR_PTR (-EINVAL ); + } +if (cxled->cxld.interleave_ways !=1 ) { +dev_err (&cxled->cxld.dev,"Interleaving and DCD not supported\n" ); +return ERR_PTR (-EINVAL ); + } + } do { cxlr = __create_region(cxlrd, mode, atomic_read(&cxlrd->region_id));@@ -3467,6 +3508,7 @@ static int cxl_region_probe(struct device *dev)case CXL_REGION_PMEM :return devm_cxl_add_pmem_region (cxlr);case CXL_REGION_RAM : +case CXL_REGION_DC :/* * The region can not be manged by CXL if any portion of * it is already online as 'System RAM' drivers/dax/bus.c +10
-0@@ -178,6 +178,11 @@ static bool is_static(struct dax_region *dax_region)return (dax_region->res.flags &IORESOURCE_DAX_STATIC ) !=0 ; } +static bool is_sparse (struct dax_region *dax_region) +{ +return (dax_region->res.flags &IORESOURCE_DAX_SPARSE_CAP ) !=0 ; +} +bool static_dev_dax (struct dev_dax *dev_dax) {return is_static (dev_dax->region);@@ -301,6 +306,9 @@ static unsigned long long dax_region_avail_size(struct dax_region *dax_region)lockdep_assert_held (&dax_region_rwsem); +if (is_sparse (dax_region)) +return 0 ; +for_each_dax_region_resource (dax_region, res) size -=resource_size (res);return size;@@ -1373,6 +1381,8 @@ static umode_t dev_dax_visible(struct kobject *kobj, struct attribute *a, int n)return 0 ;if (a == &dev_attr_mapping.attr &&is_static (dax_region))return 0 ; +if (a == &dev_attr_mapping.attr &&is_sparse (dax_region)) +return 0 ;if ((a == &dev_attr_align.attr || a == &dev_attr_size.attr) &&is_static (dax_region))return 0444 ;drivers/dax/bus.h +1
-0@@ -13,6 +13,7 @@ struct dax_region;/* dax bus specific ioresource flags */ #define IORESOURCE_DAX_STATIC BIT(0)#define IORESOURCE_DAX_KMEM BIT(1) +#define IORESOURCE_DAX_SPARSE_CAP BIT(2) struct dax_region *alloc_dax_region(struct device *parent, int region_id, struct range *range, int target_node, unsigned int align,drivers/dax/cxl.c +14
-2@@ -13,19 +13,31 @@ static int cxl_dax_region_probe(struct device *dev)struct cxl_region *cxlr = cxlr_dax->cxlr;struct dax_region *dax_region;struct dev_dax_data data; +resource_size_t dev_size; +unsigned long flags;if (nid ==NUMA_NO_NODE ) nid =memory_add_physaddr_to_nid (cxlr_dax->hpa_range.start); + flags =IORESOURCE_DAX_KMEM ; +if (cxlr->mode ==CXL_REGION_DC ) + flags |=IORESOURCE_DAX_SPARSE_CAP ; + dax_region =alloc_dax_region (dev, cxlr->id, &cxlr_dax->hpa_range, nid, -PMD_SIZE ,IORESOURCE_DAX_KMEM ); +PMD_SIZE , flags);if (!dax_region)return -ENOMEM ; +if (cxlr->mode ==CXL_REGION_DC ) +/* Add empty seed dax device */ + dev_size =0 ; +else + dev_size =range_len (&cxlr_dax->hpa_range); + data = (struct dev_dax_data ) { .dax_region = dax_region, .id =-1 , - .size =range_len (&cxlr_dax->hpa_range), + .size = dev_size, .memmap_on_memory = true, };
PATCH v3 14/25 cxl/events: Split event msgnum configuration from irq setup
In reply to Ira WeinyDynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Split cxl_event_config_msgnums() from irq setup in preparation for separate DCD interrupts configuration.
--- drivers/cxl/pci.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/cxl/pci.c +12 -12
@@ -698,35 +698,31 @@ static int cxl_event_config_msgnums(struct cxl_memdev_state *mds,return cxl_event_get_int_policy (mds, policy); } -static int cxl_event_irqsetup (struct cxl_memdev_state *mds) +static int cxl_event_irqsetup (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy) {struct cxl_dev_state *cxlds = &mds->cxlds; -struct cxl_event_interrupt_policy policy;int rc; - rc =cxl_event_config_msgnums (mds, &policy); -if (rc) -return rc; - - rc =cxl_event_req_irq (cxlds, policy.info_settings); + rc =cxl_event_req_irq (cxlds, policy->info_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Info log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.warn_settings); + rc =cxl_event_req_irq (cxlds, policy->warn_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Warn log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.failure_settings); + rc =cxl_event_req_irq (cxlds, policy->failure_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Failure log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.fatal_settings); + rc =cxl_event_req_irq (cxlds, policy->fatal_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Fatal log\n" );return rc;
@@ -745,7 +741,7 @@ static bool cxl_event_int_is_fw(u8 setting)static int cxl_event_config (struct pci_host_bridge *host_bridge,struct cxl_memdev_state *mds,bool irq_avail) { -struct cxl_event_interrupt_policy policy; +struct cxl_event_interrupt_policy policy = {0 };int rc;/*
@@ -773,11 +769,15 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return -EBUSY ; } + rc =cxl_event_config_msgnums (mds, &policy); +if (rc) +return rc; + rc =cxl_mem_alloc_event_buf (mds);if (rc)return rc; - rc =cxl_event_irqsetup (mds); + rc =cxl_event_irqsetup (mds, &policy);if (rc)return rc;
Signature · 1 line
2.45.2
Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup
Quoted 9 lines · Ira Weiny
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Split
cxl_event_config_msgnums()from irq setup in preparation for separate DCD interrupts configuration.Signed-off-by Ira Weiny <[email protected]>
Quoted 77 lines
--- drivers/cxl/pci.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)drivers/cxl/pci.c +12
-12@@ -698,35 +698,31 @@ static int cxl_event_config_msgnums(struct cxl_memdev_state *mds,return cxl_event_get_int_policy (mds, policy); } -static int cxl_event_irqsetup (struct cxl_memdev_state *mds) +static int cxl_event_irqsetup (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy) {struct cxl_dev_state *cxlds = &mds->cxlds; -struct cxl_event_interrupt_policy policy;int rc; - rc =cxl_event_config_msgnums (mds, &policy); -if (rc) -return rc; - - rc =cxl_event_req_irq (cxlds, policy.info_settings); + rc =cxl_event_req_irq (cxlds, policy->info_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Info log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.warn_settings); + rc =cxl_event_req_irq (cxlds, policy->warn_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Warn log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.failure_settings); + rc =cxl_event_req_irq (cxlds, policy->failure_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Failure log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.fatal_settings); + rc =cxl_event_req_irq (cxlds, policy->fatal_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Fatal log\n" );return rc;@@ -745,7 +741,7 @@ static bool cxl_event_int_is_fw(u8 setting)static int cxl_event_config (struct pci_host_bridge *host_bridge,struct cxl_memdev_state *mds,bool irq_avail) { -struct cxl_event_interrupt_policy policy; +struct cxl_event_interrupt_policy policy = {0 };int rc;/* @@ -773,11 +769,15 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return -EBUSY ; } + rc =cxl_event_config_msgnums (mds, &policy); +if (rc) +return rc; + rc =cxl_mem_alloc_event_buf (mds);if (rc)return rc; - rc =cxl_event_irqsetup (mds); + rc =cxl_event_irqsetup (mds, &policy);if (rc)return rc;
Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup
In reply to Ira WeinyQuoted 10 lines · Ira Weiny
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Split
cxl_event_config_msgnums()from irq setup in preparation for separate DCD interrupts configuration.Signed-off-by Ira Weiny <[email protected]>---
Quoted 79 lines
drivers/cxl/pci.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)drivers/cxl/pci.c +12
-12@@ -698,35 +698,31 @@ static int cxl_event_config_msgnums(struct cxl_memdev_state *mds,return cxl_event_get_int_policy (mds, policy); } -static int cxl_event_irqsetup (struct cxl_memdev_state *mds) +static int cxl_event_irqsetup (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy) {struct cxl_dev_state *cxlds = &mds->cxlds; -struct cxl_event_interrupt_policy policy;int rc; - rc =cxl_event_config_msgnums (mds, &policy); -if (rc) -return rc; - - rc =cxl_event_req_irq (cxlds, policy.info_settings); + rc =cxl_event_req_irq (cxlds, policy->info_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Info log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.warn_settings); + rc =cxl_event_req_irq (cxlds, policy->warn_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Warn log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.failure_settings); + rc =cxl_event_req_irq (cxlds, policy->failure_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Failure log\n" );return rc; } - rc =cxl_event_req_irq (cxlds, policy.fatal_settings); + rc =cxl_event_req_irq (cxlds, policy->fatal_settings);if (rc) {dev_err (cxlds->dev,"Failed to get interrupt for event Fatal log\n" );return rc;@@ -745,7 +741,7 @@ static bool cxl_event_int_is_fw(u8 setting)static int cxl_event_config (struct pci_host_bridge *host_bridge,struct cxl_memdev_state *mds,bool irq_avail) { -struct cxl_event_interrupt_policy policy; +struct cxl_event_interrupt_policy policy = {0 };int rc;/* @@ -773,11 +769,15 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,return -EBUSY ; } + rc =cxl_event_config_msgnums (mds, &policy); +if (rc) +return rc; + rc =cxl_mem_alloc_event_buf (mds);if (rc)return rc; - rc =cxl_event_irqsetup (mds); + rc =cxl_event_irqsetup (mds, &policy);if (rc)return rc;Signature · 2 lines
-- 2.45.2
Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup
In reply to Ira WeinyQuoted 9 lines · On Fri, 16 Aug 2024 09:44:22 -0500 Ira Weiny <[email protected]> wrote:
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Split
cxl_event_config_msgnums()from irq setup in preparation for separate DCD interrupts configuration.Signed-off-by Ira Weiny <[email protected]>
Re: [PATCH v3 14/25] cxl/events: Split event msgnum configuration from irq setup
In reply to Ira WeinyQuoted 9 lines · Ira Weiny
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Split
cxl_event_config_msgnums()from irq setup in preparation for separate DCD interrupts configuration.Signed-off-by Ira Weiny <[email protected]>
PATCH v3 15/25 cxl/pci: Factor out interrupt policy check
In reply to Ira WeinyDynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Factor out event interrupt setting validation.
---
Changes:
[iweiny: reword commit message]
[iweiny: keep review tags on simple patch]
--- drivers/cxl/pci.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)
drivers/cxl/pci.c +16 -7
@@ -738,6 +738,21 @@ static bool cxl_event_int_is_fw(u8 setting)return mode ==CXL_INT_FW ; } +static bool cxl_event_validate_mem_policy (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy) +{ +if (cxl_event_int_is_fw (policy->info_settings) || +cxl_event_int_is_fw (policy->warn_settings) || +cxl_event_int_is_fw (policy->failure_settings) || +cxl_event_int_is_fw (policy->fatal_settings)) { +dev_err (mds->cxlds.dev, +"FW still in control of Event Logs despite _OSC settings\n" ); +return false; + } + +return true; +} +static int cxl_event_config (struct pci_host_bridge *host_bridge,struct cxl_memdev_state *mds,bool irq_avail) {
@@ -760,14 +775,8 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; -if (cxl_event_int_is_fw (policy.info_settings) || -cxl_event_int_is_fw (policy.warn_settings) || -cxl_event_int_is_fw (policy.failure_settings) || -cxl_event_int_is_fw (policy.fatal_settings)) { -dev_err (mds->cxlds.dev, -"FW still in control of Event Logs despite _OSC settings\n" ); +if (!cxl_event_validate_mem_policy (mds, &policy))return -EBUSY ; - } rc =cxl_event_config_msgnums (mds, &policy);if (rc)
Signature · 1 line
2.45.2
Re: [PATCH v3 15/25] cxl/pci: Factor out interrupt policy check
Quoted 11 lines · Ira Weiny
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Factor out event interrupt setting validation.
Reviewed-by Dave Jiang <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 54 lines
---
Changes:
[iweiny: reword commit message]
[iweiny: keep review tags on simple patch]--- drivers/cxl/pci.c | 23 ++++++++++++++++------- 1 file changed, 16 insertions(+), 7 deletions(-)drivers/cxl/pci.c +16
-7@@ -738,6 +738,21 @@ static bool cxl_event_int_is_fw(u8 setting)return mode ==CXL_INT_FW ; } +static bool cxl_event_validate_mem_policy (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy) +{ +if (cxl_event_int_is_fw (policy->info_settings) || +cxl_event_int_is_fw (policy->warn_settings) || +cxl_event_int_is_fw (policy->failure_settings) || +cxl_event_int_is_fw (policy->fatal_settings)) { +dev_err (mds->cxlds.dev, +"FW still in control of Event Logs despite _OSC settings\n" ); +return false; + } + +return true; +} +static int cxl_event_config (struct pci_host_bridge *host_bridge,struct cxl_memdev_state *mds,bool irq_avail) {@@ -760,14 +775,8 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; -if (cxl_event_int_is_fw (policy.info_settings) || -cxl_event_int_is_fw (policy.warn_settings) || -cxl_event_int_is_fw (policy.failure_settings) || -cxl_event_int_is_fw (policy.fatal_settings)) { -dev_err (mds->cxlds.dev, -"FW still in control of Event Logs despite _OSC settings\n" ); +if (!cxl_event_validate_mem_policy (mds, &policy))return -EBUSY ; - } rc =cxl_event_config_msgnums (mds, &policy);if (rc)Signature · 2 lines
-- 2.45.2
Re: [PATCH v3 15/25] cxl/pci: Factor out interrupt policy check
In reply to Ira WeinyQuoted 11 lines · Ira Weiny
Dynamic Capacity Devices (DCD) require event interrupts to process memory addition or removal. BIOS may have control over non-DCD event processing. DCD interrupt configuration needs to be separate from memory event interrupt configuration.
Factor out event interrupt setting validation.
Reviewed-by Dave Jiang <[email protected]>Reviewed-by Jonathan Cameron <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 16/25 cxl/mem: Configure dynamic capacity interrupts
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Dynamic Capacity Devices (DCD) support extent change notifications through the event log mechanism. The interrupt mailbox commands were extended in CXL 3.1 to support these notifications. Firmware can't configure DCD events to be FW controlled but can retain control of memory events.
Configure DCD event log interrupts on devices supporting dynamic capacity. Disable DCD if interrupts are not supported.
Care is taken to preserve the interrupt policy set by the FW if FW first has been selected by the BIOS.
---
Changes:
[iweiny: update commit message]
[iweiny: rebase to upstream irq code]
[iweiny: disable DCD if irqs not supported]
[Jonathan: formatting fix]
[Fan: add text to debug print]
[djiang: make dcd helpers inline]
--- drivers/cxl/cxlmem.h | 2 ++ drivers/cxl/pci.c | 72 +++++++++++++++++++++++++++++++++++++++++++--------- 2 files changed, 62 insertions(+), 12 deletions(-)
drivers/cxl/cxlmem.h +2 -0
@@ -225,7 +225,9 @@ struct cxl_event_interrupt_policy {u8 warn_settings;u8 failure_settings;u8 fatal_settings; +u8 dcd_settings; } __packed; +#define CXL_EVENT_INT_POLICY_BASE_SIZE 4/* info, warn, failure, fatal */ /** * struct cxl_event_state - Event log driver state
drivers/cxl/pci.c +60 -12
127 lines not on this page · raw message
Signature · 1 line
2.45.2
Re: [PATCH v3 16/25] cxl/mem: Configure dynamic capacity interrupts
Quoted 11 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity Devices (DCD) support extent change notifications through the event log mechanism. The interrupt mailbox commands were extended in CXL 3.1 to support these notifications. Firmware can't configure DCD events to be FW controlled but can retain control of memory events.
Configure DCD event log interrupts on devices supporting dynamic capacity. Disable DCD if interrupts are not supported.
Quoted 6 lines
Care is taken to preserve the interrupt policy set by the FW if FW first has been selected by the BIOS.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 165 lines
---
Changes:
[iweiny: update commit message]
[iweiny: rebase to upstream irq code]
[iweiny: disable DCD if irqs not supported]
[Jonathan: formatting fix]
[Fan: add text to debug print]
[djiang: make dcd helpers inline]--- drivers/cxl/cxlmem.h | 2 ++ drivers/cxl/pci.c | 72 +++++++++++++++++++++++++++++++++++++++++++--------- 2 files changed, 62 insertions(+), 12 deletions(-)drivers/cxl/cxlmem.h +2
-0@@ -225,7 +225,9 @@ struct cxl_event_interrupt_policy {u8 warn_settings;u8 failure_settings;u8 fatal_settings; +u8 dcd_settings; } __packed; +#define CXL_EVENT_INT_POLICY_BASE_SIZE 4/* info, warn, failure, fatal */ /** * struct cxl_event_state - Event log driver state drivers/cxl/pci.c +60
-12@@ -669,22 +669,33 @@ static int cxl_event_get_int_policy(struct cxl_memdev_state *mds, }static int cxl_event_config_msgnums (struct cxl_memdev_state *mds, -struct cxl_event_interrupt_policy *policy) +struct cxl_event_interrupt_policy *policy, +bool native_cxl) { +size_t size_in =CXL_EVENT_INT_POLICY_BASE_SIZE ;struct cxl_mbox_cmd mbox_cmd;int rc; - *policy = (struct cxl_event_interrupt_policy ) { - .info_settings =CXL_INT_MSI_MSIX , - .warn_settings =CXL_INT_MSI_MSIX , - .failure_settings =CXL_INT_MSI_MSIX , - .fatal_settings =CXL_INT_MSI_MSIX , - }; +/* memory event policy is left if FW has control */ +if (native_cxl) { + *policy = (struct cxl_event_interrupt_policy ) { + .info_settings =CXL_INT_MSI_MSIX , + .warn_settings =CXL_INT_MSI_MSIX , + .failure_settings =CXL_INT_MSI_MSIX , + .fatal_settings =CXL_INT_MSI_MSIX , + .dcd_settings =0 , + }; + } + +if (cxl_dcd_supported (mds)) { + policy->dcd_settings =CXL_INT_MSI_MSIX ; + size_in +=sizeof (policy->dcd_settings); + } mbox_cmd = (struct cxl_mbox_cmd ) { .opcode =CXL_MBOX_OP_SET_EVT_INT_POLICY , .payload_in = policy, - .size_in =sizeof (*policy), + .size_in = size_in, }; rc =cxl_internal_send_cmd (mds, &mbox_cmd);@@ -731,6 +742,31 @@ static int cxl_event_irqsetup(struct cxl_memdev_state *mds,return 0 ; } +static int cxl_irqsetup (struct cxl_memdev_state *mds, +struct cxl_event_interrupt_policy *policy, +bool native_cxl) +{ +struct cxl_dev_state *cxlds = &mds->cxlds; +int rc; + +if (native_cxl) { + rc =cxl_event_irqsetup (mds, policy); +if (rc) +return rc; + } + +if (cxl_dcd_supported (mds)) { + rc =cxl_event_req_irq (cxlds, policy->dcd_settings); +if (rc) { +dev_err (cxlds->dev,"Failed to get interrupt for DCD event log\n" ); +cxl_disable_dcd (mds); +return rc; + } + } + +return 0 ; +} +static bool cxl_event_int_is_fw (u8 setting) {u8 mode =FIELD_GET (CXLDEV_EVENT_INT_MODE_MASK , setting);@@ -757,17 +793,25 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, struct cxl_memdev_state *mds, bool irq_avail) {struct cxl_event_interrupt_policy policy = {0 }; +bool native_cxl = host_bridge->native_cxl_error;int rc;/* * When BIOS maintains CXL error reporting control, it will process * event records. Only one agent can do so. +* +* If BIOS has control of events and DCD is not supported skip event +* configuration. */ -if (!host_bridge->native_cxl_error) +if (!native_cxl && !cxl_dcd_supported (mds))return 0 ;if (!irq_avail) {dev_info (mds->cxlds.dev,"No interrupt support, disable event processing.\n" ); +if (cxl_dcd_supported (mds)) { +dev_info (mds->cxlds.dev,"DCD requires interrupts, disable DCD\n" ); +cxl_disable_dcd (mds); + }return 0 ; }@@ -775,10 +819,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; -if (!cxl_event_validate_mem_policy (mds, &policy)) +if (native_cxl && !cxl_event_validate_mem_policy (mds, &policy))return -EBUSY ; - rc =cxl_event_config_msgnums (mds, &policy); + rc =cxl_event_config_msgnums (mds, &policy, native_cxl);if (rc)return rc;@@ -786,12 +830,16 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; - rc =cxl_event_irqsetup (mds, &policy); + rc =cxl_irqsetup (mds, &policy, native_cxl);if (rc)return rc;cxl_mem_get_event_records (mds,CXLDEV_EVENT_STATUS_ALL ); +dev_dbg (mds->cxlds.dev,"Event config : %s DCD %s\n" , + native_cxl ?"OS" :"BIOS" , +cxl_dcd_supported (mds) ?"supported" :"not supported" ); +return 0 ; }
Re: [PATCH v3 16/25] cxl/mem: Configure dynamic capacity interrupts
In reply to [email protected]Quoted 11 lines · On Fri, 16 Aug 2024 09:44:24 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity Devices (DCD) support extent change notifications through the event log mechanism. The interrupt mailbox commands were extended in CXL 3.1 to support these notifications. Firmware can't configure DCD events to be FW controlled but can retain control of memory events.
Configure DCD event log interrupts on devices supporting dynamic capacity. Disable DCD if interrupts are not supported.
Quoted 6 lines
Care is taken to preserve the interrupt policy set by the FW if FW first has been selected by the BIOS.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Minor thing on naming inline. Either way
Quoted 33 lines
---
Changes:
[iweiny: update commit message]
[iweiny: rebase to upstream irq code]
[iweiny: disable DCD if irqs not supported]
[Jonathan: formatting fix]
[Fan: add text to debug print]
[djiang: make dcd helpers inline]--- drivers/cxl/cxlmem.h | 2 ++ drivers/cxl/pci.c | 72 +++++++++++++++++++++++++++++++++++++++++++--------- 2 files changed, 62 insertions(+), 12 deletions(-)drivers/cxl/cxlmem.h +2
-0@@ -225,7 +225,9 @@ struct cxl_event_interrupt_policy {u8 warn_settings;u8 failure_settings;u8 fatal_settings; +u8 dcd_settings; } __packed; +#define CXL_EVENT_INT_POLICY_BASE_SIZE 4/* info, warn, failure, fatal */ /** * struct cxl_event_state - Event log driver state drivers/cxl/pci.c +0
-0
drivers/cxl/pci.c static int cxl_event_get_int_policy(struct cxl_memdev_state *mds, · line 673
Quoted 6 lines
drivers/cxl/pci.c +2
-1@@ -669,22 +669,33 @@ static int cxl_event_get_int_policy(struct cxl_memdev_state *mds, }static int cxl_event_config_msgnums (struct cxl_memdev_state *mds, -struct cxl_event_interrupt_policy *policy) +struct cxl_event_interrupt_policy *policy, +bool native_cxl)
Maybe carry through the native_cxl_error naming?
Quoted 44 lines
drivers/cxl/pci.c +18
-7{ +size_t size_in =CXL_EVENT_INT_POLICY_BASE_SIZE ;struct cxl_mbox_cmd mbox_cmd;int rc; - *policy = (struct cxl_event_interrupt_policy ) { - .info_settings =CXL_INT_MSI_MSIX , - .warn_settings =CXL_INT_MSI_MSIX , - .failure_settings =CXL_INT_MSI_MSIX , - .fatal_settings =CXL_INT_MSI_MSIX , - }; +/* memory event policy is left if FW has control */ +if (native_cxl) { + *policy = (struct cxl_event_interrupt_policy ) { + .info_settings =CXL_INT_MSI_MSIX , + .warn_settings =CXL_INT_MSI_MSIX , + .failure_settings =CXL_INT_MSI_MSIX , + .fatal_settings =CXL_INT_MSI_MSIX , + .dcd_settings =0 , + }; + } + +if (cxl_dcd_supported (mds)) { + policy->dcd_settings =CXL_INT_MSI_MSIX ; + size_in +=sizeof (policy->dcd_settings); + } mbox_cmd = (struct cxl_mbox_cmd ) { .opcode =CXL_MBOX_OP_SET_EVT_INT_POLICY , .payload_in = policy, - .size_in =sizeof (*policy), + .size_in = size_in, }; rc =cxl_internal_send_cmd (mds, &mbox_cmd);@@ -731,6 +742,31 @@ static int cxl_event_irqsetup(struct cxl_memdev_state *mds,return 0 ; } +static bool cxl_event_int_is_fw (u8 setting) {u8 mode =FIELD_GET (CXLDEV_EVENT_INT_MODE_MASK , setting);
drivers/cxl/pci.c static int cxl_event_config(struct pci_host_bridge *host_bridge, · line 796
Quoted 4 lines
drivers/cxl/pci.c +1
-0@@ -757,17 +793,25 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge, struct cxl_memdev_state *mds, bool irq_avail) {struct cxl_event_interrupt_policy policy = {0 }; +bool native_cxl = host_bridge->native_cxl_error;
Maybe keep the native_cxl_error naming for the local variable as well?
Quoted 54 lines
drivers/cxl/pci.c +15
-4int rc;/* * When BIOS maintains CXL error reporting control, it will process * event records. Only one agent can do so. +* +* If BIOS has control of events and DCD is not supported skip event +* configuration. */ -if (!host_bridge->native_cxl_error) +if (!native_cxl && !cxl_dcd_supported (mds))return 0 ;if (!irq_avail) {dev_info (mds->cxlds.dev,"No interrupt support, disable event processing.\n" ); +if (cxl_dcd_supported (mds)) { +dev_info (mds->cxlds.dev,"DCD requires interrupts, disable DCD\n" ); +cxl_disable_dcd (mds); + }return 0 ; }@@ -775,10 +819,10 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; -if (!cxl_event_validate_mem_policy (mds, &policy)) +if (native_cxl && !cxl_event_validate_mem_policy (mds, &policy))return -EBUSY ; - rc =cxl_event_config_msgnums (mds, &policy); + rc =cxl_event_config_msgnums (mds, &policy, native_cxl);if (rc)return rc;@@ -786,12 +830,16 @@ static int cxl_event_config(struct pci_host_bridge *host_bridge,if (rc)return rc; - rc =cxl_event_irqsetup (mds, &policy); + rc =cxl_irqsetup (mds, &policy, native_cxl);if (rc)return rc;cxl_mem_get_event_records (mds,CXLDEV_EVENT_STATUS_ALL ); +dev_dbg (mds->cxlds.dev,"Event config : %s DCD %s\n" , + native_cxl ?"OS" :"BIOS" , +cxl_dcd_supported (mds) ?"supported" :"not supported" ); +return 0 ; }
Re: [PATCH v3 16/25] cxl/mem: Configure dynamic capacity interrupts
In reply to [email protected]Quoted 11 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Dynamic Capacity Devices (DCD) support extent change notifications through the event log mechanism. The interrupt mailbox commands were extended in CXL 3.1 to support these notifications. Firmware can't configure DCD events to be FW controlled but can retain control of memory events.
Configure DCD event log interrupts on devices supporting dynamic capacity. Disable DCD if interrupts are not supported.
Quoted 6 lines
Care is taken to preserve the interrupt policy set by the FW if FW first has been selected by the BIOS.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
PATCH v3 17/25 cxl/core: Return endpoint decoder information from region search
In reply to Ira Weinycxl_dpa_to_region() finds the region from a <DPA, device> tuple. The search involves finding the device endpoint decoder as well.
Dynamic capacity extent processing uses the endpoint decoder HPA information to calculate the HPA offset. In addition, well behaved extents should be contained within an endpoint decoder.
Return the endpoint decoder found to be used in subsequent DCD code.
--- drivers/cxl/core/core.h | 6 ++++-- drivers/cxl/core/mbox.c | 2 +- drivers/cxl/core/memdev.c | 4 ++-- drivers/cxl/core/region.c | 8 +++++++- 4 files changed, 14 insertions(+), 6 deletions(-)
drivers/cxl/core/core.h +4 -2
@@ -39,7 +39,8 @@ void cxl_decoder_kill_region(struct cxl_endpoint_decoder *cxled);int cxl_region_init (void );void cxl_region_exit (void );int cxl_get_poison_by_endpoint (struct cxl_port *port); -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa); +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled);u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa);
@@ -50,7 +51,8 @@ static inline u64 cxl_dpa_to_hpa(struct cxl_region *cxlr,return ULLONG_MAX ; }static inline -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa) +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled) {return NULL ; }
drivers/cxl/core/mbox.c +1 -1
@@ -909,7 +909,7 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,guard (rwsem_read)(&cxl_dpa_rwsem); dpa =le64_to_cpu (evt->media_hdr.phys_addr) &CXL_DPA_MASK ; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) hpa =cxl_dpa_to_hpa (cxlr, cxlmd, dpa);
drivers/cxl/core/memdev.c +2 -2
@@ -323,7 +323,7 @@ int cxl_inject_poison(struct cxl_memdev *cxlmd, u64 dpa)if (rc) goto out; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) dev_warn_once(mds->cxlds.dev, "poison inject dpa:%#llx region: %s\n", dpa,
@@ -387,7 +387,7 @@ int cxl_clear_poison(struct cxl_memdev *cxlmd, u64 dpa)if (rc) goto out; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) dev_warn_once(mds->cxlds.dev, "poison clear dpa:%#llx region: %s\n", dpa,
drivers/cxl/core/region.c +7 -1
@@ -2828,6 +2828,7 @@ int cxl_get_poison_by_endpoint(struct cxl_port *port)struct cxl_dpa_to_region_context {struct cxl_region *cxlr;u64 dpa; +struct cxl_endpoint_decoder *cxled; };static int __cxl_dpa_to_region (struct device *dev,void *arg)
@@ -2861,11 +2862,13 @@ static int __cxl_dpa_to_region(struct device *dev, void *arg) dev_name(dev)); ctx->cxlr = cxlr; + ctx->cxled = cxled;return 1 ; } -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa) +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled) {struct cxl_dpa_to_region_context ctx;struct cxl_port *port;
@@ -2877,6 +2880,9 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa)if (port &&is_cxl_endpoint (port) &&cxl_num_decoders_committed (port))device_for_each_child (&port->dev, &ctx, __cxl_dpa_to_region); +if (cxled) + *cxled = ctx.cxled; +return ctx.cxlr; }
Signature · 1 line
2.45.2
Re: [PATCH v3 17/25] cxl/core: Return endpoint decoder information from region search
Quoted 10 lines · Ira Weiny
cxl_dpa_to_region()finds the region from a <DPA, device> tuple. The search involves finding the device endpoint decoder as well.Dynamic capacity extent processing uses the endpoint decoder HPA information to calculate the HPA offset. In addition, well behaved extents should be contained within an endpoint decoder.
Return the endpoint decoder found to be used in subsequent DCD code.
Signed-off-by Ira Weiny <[email protected]>
Quoted 104 lines
--- drivers/cxl/core/core.h | 6 ++++-- drivers/cxl/core/mbox.c | 2 +- drivers/cxl/core/memdev.c | 4 ++-- drivers/cxl/core/region.c | 8 +++++++- 4 files changed, 14 insertions(+), 6 deletions(-)drivers/cxl/core/core.h +4
-2@@ -39,7 +39,8 @@ void cxl_decoder_kill_region(struct cxl_endpoint_decoder *cxled);int cxl_region_init (void );void cxl_region_exit (void );int cxl_get_poison_by_endpoint (struct cxl_port *port); -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa); +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled);u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa);@@ -50,7 +51,8 @@ static inline u64 cxl_dpa_to_hpa(struct cxl_region *cxlr,return ULLONG_MAX ; }static inline -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa) +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled) {return NULL ; }drivers/cxl/core/mbox.c +1
-1@@ -909,7 +909,7 @@ void cxl_event_trace_record(const struct cxl_memdev *cxlmd,guard (rwsem_read)(&cxl_dpa_rwsem); dpa =le64_to_cpu (evt->media_hdr.phys_addr) &CXL_DPA_MASK ; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) hpa =cxl_dpa_to_hpa (cxlr, cxlmd, dpa);drivers/cxl/core/memdev.c +2
-2@@ -323,7 +323,7 @@ int cxl_inject_poison(struct cxl_memdev *cxlmd, u64 dpa)if (rc) goto out; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) dev_warn_once(mds->cxlds.dev, "poison inject dpa:%#llx region: %s\n", dpa,@@ -387,7 +387,7 @@ int cxl_clear_poison(struct cxl_memdev *cxlmd, u64 dpa)if (rc) goto out; - cxlr =cxl_dpa_to_region (cxlmd, dpa); + cxlr =cxl_dpa_to_region (cxlmd, dpa,NULL );if (cxlr) dev_warn_once(mds->cxlds.dev, "poison clear dpa:%#llx region: %s\n", dpa,drivers/cxl/core/region.c +7
-1@@ -2828,6 +2828,7 @@ int cxl_get_poison_by_endpoint(struct cxl_port *port)struct cxl_dpa_to_region_context {struct cxl_region *cxlr;u64 dpa; +struct cxl_endpoint_decoder *cxled; };static int __cxl_dpa_to_region (struct device *dev,void *arg)@@ -2861,11 +2862,13 @@ static int __cxl_dpa_to_region(struct device *dev, void *arg) dev_name(dev)); ctx->cxlr = cxlr; + ctx->cxled = cxled;return 1 ; } -struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa) +struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa, +struct cxl_endpoint_decoder **cxled) {struct cxl_dpa_to_region_context ctx;struct cxl_port *port;@@ -2877,6 +2880,9 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa)if (port &&is_cxl_endpoint (port) &&cxl_num_decoders_committed (port))device_for_each_child (&port->dev, &ctx, __cxl_dpa_to_region); +if (cxled) + *cxled = ctx.cxled; +return ctx.cxlr; }
Re: [PATCH v3 17/25] cxl/core: Return endpoint decoder information from region search
In reply to Ira WeinyQuoted 8 lines · On Fri, 16 Aug 2024 09:44:25 -0500 Ira Weiny <[email protected]> wrote:
cxl_dpa_to_region()finds the region from a <DPA, device> tuple. The search involves finding the device endpoint decoder as well.Dynamic capacity extent processing uses the endpoint decoder HPA information to calculate the HPA offset. In addition, well behaved extents should be contained within an endpoint decoder.
Return the endpoint decoder found to be used in subsequent DCD code.
Maybe make this
Optionally return the ...
Quoted 2 lines
Signed-off-by Ira Weiny <[email protected]>
Re: [PATCH v3 17/25] cxl/core: Return endpoint decoder information from region search
In reply to Ira WeinyQuoted 10 lines · Ira Weiny
cxl_dpa_to_region()finds the region from a <DPA, device> tuple. The search involves finding the device endpoint decoder as well.Dynamic capacity extent processing uses the endpoint decoder HPA information to calculate the HPA offset. In addition, well behaved extents should be contained within an endpoint decoder.
Return the endpoint decoder found to be used in subsequent DCD code.
Signed-off-by Ira Weiny <[email protected]>
PATCH v3 18/25 cxl/extent: Process DCD events and realize region extents
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)
Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the cxl_dax_region device such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Process DCD events and create region devices.
---
Changes:
[iweiny: combine this with the extent surface patches to better show the
lifetime extent objects in review]
[iweiny: clean up commit message.]
[iweiny: move extent verification of the 'read extents on region
creation' to this patch]
[iweiny: Provide for a common path for extent realization between an add
event and adding existing extents.]
[iweiny: Persist a check that an extent is within an endpoint decoder] [iweiny: reduce exported and non-static calls]
[iweiny: use %par]
<Combined comments from the old patches which were addressed>
[Jonathan: implement the more bit with a simple algorithm which accepts
all extents it can.
Also include the response more bit to prevent payload overflow]
[Fan: Do not error if a contained extent is added.] [Jonathan: allocate ida after kzalloc]
[iweiny: fix ida resource leak]
[fan/djiang: remove unneeded memset]
[djiang: fix indentation]
[Jonathan: Fix indentation]
[Jonathan/djbw: make tag a uuid]
[djbw: create helper calc_hpa_range() straight away]
[djbw: Allow for multiple cxled_extents per region_extent] [djbw: s/cxl_ed/cxled]
[djbw: s/cxl_release_ed_extent/cxled_release_extent/]
[djbw: s/reg_ext/region_extent/]
[djbw: s/dc_extent/extent/]
[Gregory/djbw: reject shared extents]
[iweiny: predicate extent.c compile on CONFIG_CXL_REGION]
--- drivers/cxl/core/Makefile | 2 +- drivers/cxl/core/core.h | 13 ++ drivers/cxl/core/extent.c | 345 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/mbox.c | 268 ++++++++++++++++++++++++++++++++++- drivers/cxl/core/region.c | 6 + drivers/cxl/cxl.h | 52 ++++++- drivers/cxl/cxlmem.h | 26 ++++ include/linux/cxl-event.h | 32 +++++ tools/testing/cxl/Kbuild | 3 +- 9 files changed, 743 insertions(+), 4 deletions(-)
drivers/cxl/core/Makefile +1 -1
@@ -15,4 +15,4 @@ cxl_core-y += hdm.o cxl_core-y += pmu.o cxl_core-y += cdat.o cxl_core-$(CONFIG_TRACING) += trace.o -cxl_core-$(CONFIG_CXL_REGION) += region.o +cxl_core-$(CONFIG_CXL_REGION) += region.o extent.o
drivers/cxl/core/core.h +13 -0
@@ -44,12 +44,24 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa,u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa); +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent); +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent);#else static inline u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa) {return ULLONG_MAX ; } +static inline int cxl_add_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +} +static inline int cxl_rm_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +}static inline struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa,struct cxl_endpoint_decoder **cxled)
@@ -121,5 +133,6 @@ long cxl_pci_get_latency(struct pci_dev *pdev);int cxl_update_hmat_access_coordinates (int nid,struct cxl_region *cxlr,enum access_coordinate_class access);bool cxl_need_node_perf_attrs_update (int nid); +void memdev_release_extent (struct cxl_memdev_state *mds,struct range *range);#endif /* __CXL_CORE_H__ */
drivers/cxl/core/extent.c new file +345 -0
345 lines not on this page · raw message
drivers/cxl/core/mbox.c +267 -1
306 lines not on this page · raw message
drivers/cxl/core/region.c +6 -0
@@ -3037,6 +3037,7 @@ static void cxl_dax_region_release(struct device *dev) {struct cxl_dax_region *cxlr_dax =to_cxl_dax_region (dev); +ida_destroy (&cxlr_dax->extent_ida);kfree (cxlr_dax); }
@@ -3090,6 +3091,8 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr) dev = &cxlr_dax->dev; cxlr_dax->cxlr = cxlr; + cxlr->cxlr_dax = cxlr_dax; +ida_init (&cxlr_dax->extent_ida);device_initialize (dev);lockdep_set_class (&dev->mutex, &cxl_dax_region_key);device_set_pm_not_required (dev);
@@ -3190,7 +3193,10 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)static void cxlr_dax_unregister (void *_cxlr_dax) {struct cxl_dax_region *cxlr_dax = _cxlr_dax; +struct cxl_region *cxlr = cxlr_dax->cxlr; + cxlr->cxlr_dax =NULL ; + cxlr_dax->cxlr =NULL ;device_unregister (&cxlr_dax->dev); }
drivers/cxl/cxl.h +51 -1
98 lines not on this page · raw message
drivers/cxl/cxlmem.h +26 -0
@@ -497,6 +497,7 @@ struct cxl_dc_region_info {* @pmem_perf: performance data entry matched to PMEM partition * @nr_dc_region: number of DC regions implemented in the memory device * @dc_region: array containing info about the DC regions +* @pending_extents: array of extents pending during more bit processing * @event: event log driver state * @poison: poison driver state info * @security: security driver state info
@@ -532,6 +533,7 @@ struct cxl_memdev_state {u8 nr_dc_region;struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct xarray pending_extents;struct cxl_event_state event;struct cxl_poison_state poison;
@@ -607,6 +609,21 @@ enum cxl_opcode {UUID_INIT (0x5e1819d9 ,0x11a9 ,0x400c ,0x81 ,0x1f ,0xd6 ,0x07 ,0x19 , \0x40 ,0x3d ,0x86 ) +/* +* Add Dynamic Capacity Response +* CXL rev 3.1 section 8.2.9.9.9.3; Table 8-168 & Table 8-169 + */ +struct cxl_mbox_dc_response { +__le32 extent_list_size; +u8 flags; +u8 reserved[3 ]; +struct updated_extent_list { +__le64 dpa_start; +__le64 length; +u8 reserved[8 ]; + } __packed extent_list[]; +} __packed; +struct cxl_mbox_get_supported_logs {__le16 entries;u8 rsvd[6 ];
@@ -669,6 +686,14 @@ struct cxl_mbox_identify {UUID_INIT (0xfe927475 ,0xdd59 ,0x4339 ,0xa5 ,0x86 ,0x79 ,0xba ,0xb1 , \0x13 ,0xb7 ,0x74 ) +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1; Table 8-43 + */ +#define CXL_EVENT_DC_EVENT_UUID \ + UUID_INIT(0xca95afa7, 0xf183, 0x4018, 0x8c, 0x2f, 0x95, 0x26, 0x8e, \ + 0x10, 0x1a, 0x2a) +/* * Get Event Records output payload * CXL rev 3.0 section 8.2.9.2.2; Table 8-50
@@ -694,6 +719,7 @@ enum cxl_event_log_type {CXL_EVENT_TYPE_WARN ,CXL_EVENT_TYPE_FAIL ,CXL_EVENT_TYPE_FATAL , +CXL_EVENT_TYPE_DCD , CXL_EVENT_TYPE_MAX };
include/linux/cxl-event.h +32 -0
@@ -96,11 +96,43 @@ struct cxl_event_mem_module {u8 reserved[0x3d ]; } __packed; +/* +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-51 +*/ +#define CXL_EXTENT_TAG_LEN 0x10 +struct cxl_extent { +__le64 start_dpa; +__le64 length; +u8 tag[CXL_EXTENT_TAG_LEN ]; +__le16 shared_extn_seq; +u8 reserved[0x6 ]; +} __packed; + +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-50 +*/ +#define CXL_DCD_EVENT_MORE BIT(0) +struct cxl_event_dcd { +struct cxl_event_record_hdr hdr; +u8 event_type; +u8 validity_flags; +__le16 host_id; +u8 region_index; +u8 flags; +u8 reserved1[0x2 ]; +struct cxl_extent extent; +u8 reserved2[0x18 ]; +__le32 num_avail_extents; +__le32 num_avail_tags; +} __packed; +union cxl_event {struct cxl_event_generic generic;struct cxl_event_gen_media gen_media;struct cxl_event_dram dram;struct cxl_event_mem_module mem_module; +struct cxl_event_dcd dcd;/* dram & gen_media event header */ struct cxl_event_media_hdr media_hdr; } __packed;
tools/testing/cxl/Kbuild +2 -1
@@ -61,7 +61,8 @@ cxl_core-y += $(CXL_CORE_SRC)/hdm.o cxl_core-y += $(CXL_CORE_SRC)/pmu.o cxl_core-y += $(CXL_CORE_SRC)/cdat.o cxl_core-$(CONFIG_TRACING) += $(CXL_CORE_SRC)/trace.o -cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o +cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o \ + $(CXL_CORE_SRC)/extent.o cxl_core-y += config_check.o cxl_core-y += cxl_core_test.o cxl_core-y += cxl_core_exports.o
Signature · 1 line
2.45.2
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 54 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Quoted 5 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
A few nits below, but in general
Quoted 188 lines
---
Changes:
[iweiny: combine this with the extent surface patches to better show the
lifetime extent objects in review]
[iweiny: clean up commit message.]
[iweiny: move extent verification of the 'read extents on region
creation' to this patch]
[iweiny: Provide for a common path for extent realization between an add
event and adding existing extents.]
[iweiny: Persist a check that an extent is within an endpoint decoder] [iweiny: reduce exported and non-static calls]
[iweiny: use %par]<Combined comments from the old patches which were addressed>
[Jonathan: implement the more bit with a simple algorithm which accepts
all extents it can.
Also include the response more bit to prevent payload overflow]
[Fan: Do not error if a contained extent is added.] [Jonathan: allocate ida after kzalloc]
[iweiny: fix ida resource leak]
[fan/djiang: remove unneeded memset]
[djiang: fix indentation]
[Jonathan: Fix indentation]
[Jonathan/djbw: make tag a uuid]
[djbw: create helpercalc_hpa_range()straight away]
[djbw: Allow for multiplecxled_extentsperregion_extent] [djbw: s/cxl_ed/cxled]
[djbw: s/cxl_release_ed_extent/cxled_release_extent/]
[djbw: s/reg_ext/region_extent/]
[djbw: s/dc_extent/extent/]
[Gregory/djbw: reject shared extents]
[iweiny: predicateextent.ccompile onCONFIG_CXL_REGION]--- drivers/cxl/core/Makefile | 2 +- drivers/cxl/core/core.h | 13 ++ drivers/cxl/core/extent.c | 345 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/mbox.c | 268 ++++++++++++++++++++++++++++++++++- drivers/cxl/core/region.c | 6 + drivers/cxl/cxl.h | 52 ++++++- drivers/cxl/cxlmem.h | 26 ++++ include/linux/cxl-event.h | 32 +++++ tools/testing/cxl/Kbuild | 3 +- 9 files changed, 743 insertions(+), 4 deletions(-)drivers/cxl/core/Makefile +1
-1@@ -15,4 +15,4 @@ cxl_core-y += hdm.o cxl_core-y += pmu.o cxl_core-y += cdat.o cxl_core-$(CONFIG_TRACING) += trace.o -cxl_core-$(CONFIG_CXL_REGION) += region.o +cxl_core-$(CONFIG_CXL_REGION) += region.o extent.odrivers/cxl/core/core.h +13
-0@@ -44,12 +44,24 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa,u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa); +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent); +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent);#else static inline u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa) {return ULLONG_MAX ; } +static inline int cxl_add_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +} +static inline int cxl_rm_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +}static inline struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa,struct cxl_endpoint_decoder **cxled)@@ -121,5 +133,6 @@ long cxl_pci_get_latency(struct pci_dev *pdev);int cxl_update_hmat_access_coordinates (int nid,struct cxl_region *cxlr,enum access_coordinate_class access);bool cxl_need_node_perf_attrs_update (int nid); +void memdev_release_extent (struct cxl_memdev_state *mds,struct range *range);#endif /* __CXL_CORE_H__ */ drivers/cxl/core/extent.c new file +89
-0@@ -0,0 +1,345 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ + +#include <linux/device.h> +#include <cxl.h> + +#include "core.h" + +static void cxled_release_extent (struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct cxl_memdev_state *mds =cxled_to_mds (cxled); +struct device *dev = &cxled->cxld.dev; + +dev_dbg (dev,"Remove extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); +memdev_release_extent (mds, &ed_extent->dpa_range); +kfree (ed_extent); +} + +static void free_region_extent (struct region_extent *region_extent) +{ +struct cxled_extent *ed_extent; +unsigned long index; + +/* +* Remove from each endpoint decoder the extent which backs this region +* extent +*/ +xa_for_each (®ion_extent->decoder_extents, index, ed_extent) +cxled_release_extent (ed_extent->cxled, ed_extent); +xa_destroy (®ion_extent->decoder_extents); +ida_free (®ion_extent->cxlr_dax->extent_ida, region_extent->dev.id); +kfree (region_extent); +} + +static void region_extent_release (struct device *dev) +{ +struct region_extent *region_extent =to_region_extent (dev); + +free_region_extent (region_extent); +} + +static const struct device_type region_extent_type = { + .name ="extent" , + .release = region_extent_release, +}; + +bool is_region_extent (struct device *dev) +{ +return dev->type == ®ion_extent_type; +} +EXPORT_SYMBOL_NS_GPL (is_region_extent,CXL ); + +static void region_extent_unregister (void *ext) +{ +struct region_extent *region_extent = ext; + +dev_dbg (®ion_extent->dev,"DAX region rm extent HPA %par\n" , + ®ion_extent->hpa_range); +device_unregister (®ion_extent->dev); +} + +static void region_rm_extent (struct region_extent *region_extent) +{ +struct device *region_dev = region_extent->dev.parent; + +devm_release_action (region_dev, region_extent_unregister, region_extent); +} + +static struct region_extent * +alloc_region_extent (struct cxl_dax_region *cxlr_dax,struct range *hpa_range,u8 *tag) +{ +int id; + + struct region_extent *region_extent __free(kfree) = +kzalloc (sizeof (*region_extent),GFP_KERNEL ); +if (!region_extent) +return ERR_PTR (-ENOMEM ); + + id =ida_alloc (&cxlr_dax->extent_ida,GFP_KERNEL ); +if (id <0 ) +return ERR_PTR (-ENOMEM ); + + region_extent->hpa_range = *hpa_range; + region_extent->cxlr_dax = cxlr_dax; +import_uuid (®ion_extent->tag, tag); + region_extent->dev.id = id; +xa_init (®ion_extent->decoder_extents);
drivers/cxl/core/extent.c line 99
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+return no_free_ptr (region_extent); +} + +static int online_region_extent (struct region_extent *region_extent) +{ +struct cxl_dax_region *cxlr_dax = region_extent->cxlr_dax; +struct device *dev; +int rc; + + dev = ®ion_extent->dev;
Nit. You can move this up to when you declare 'dev'.
Quoted 403 lines
drivers/cxl/core/extent.c new file +246
-0+device_initialize (dev); +device_set_pm_not_required (dev); + dev->parent = &cxlr_dax->dev; + dev->type = ®ion_extent_type; + rc =dev_set_name (dev,"extent%d.%d" , cxlr_dax->cxlr->id, dev->id); +if (rc) + goto err; + + rc =device_add (dev); +if (rc) + goto err; + +dev_dbg (dev,"region extent HPA %par\n" , ®ion_extent->hpa_range); +return devm_add_action_or_reset (&cxlr_dax->dev, region_extent_unregister, + region_extent); + +err: +dev_err (&cxlr_dax->dev,"Failed to initialize region extent HPA %par\n" , + ®ion_extent->hpa_range); + +put_device (dev); +return rc; +} + +struct match_data { +struct cxl_endpoint_decoder *cxled; +struct range *new_range; +}; + +static int match_contains (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data; +struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_contains (&entry->dpa_range, md->new_range)) +return true; + } +return false; +} + +static bool extents_contain (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct range *new_range) +{ +struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_contains); +if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static int match_overlaps (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data; +struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_overlaps (&entry->dpa_range, md->new_range)) +return true; + } + +return false; +} + +static bool extents_overlap (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct range *new_range) +{ +struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_overlaps); +if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static void calc_hpa_range (struct cxl_endpoint_decoder *cxled, +struct cxl_dax_region *cxlr_dax, +struct range *dpa_range, +struct range *hpa_range) +{ +resource_size_t dpa_offset, hpa; + + dpa_offset = dpa_range->start - cxled->dpa_res->start; + hpa = cxled->cxld.hpa_range.start + dpa_offset; + + hpa_range->start = hpa - cxlr_dax->hpa_range.start; + hpa_range->end = hpa_range->start +range_len (dpa_range) -1 ; +} + +static int cxlr_rm_extent (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct range *region_hpa_range = data; + +if (!region_extent) +return 0 ; + +/* +* Any extent which 'touches' the released range is removed. +*/ +if (range_overlaps (region_hpa_range, ®ion_extent->hpa_range)) { +dev_dbg (dev,"Remove region extent HPA %par\n" , + ®ion_extent->hpa_range); +region_rm_extent (region_extent); + } +return 0 ; +} + +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range hpa_range, dpa_range; +struct cxl_region *cxlr; + + dpa_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) { +memdev_release_extent (mds, &dpa_range); +return -ENXIO ; + } + +calc_hpa_range (cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + +/* Remove region extents which overlap */ +return device_for_each_child (&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +static int cxlr_add_extent (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct region_extent *region_extent; +struct range hpa_range; +int rc; + +calc_hpa_range (cxled, cxlr_dax, &ed_extent->dpa_range, &hpa_range); + + region_extent =alloc_region_extent (cxlr_dax, &hpa_range, ed_extent->tag); +if (IS_ERR (region_extent)) +return PTR_ERR (region_extent); + + rc =xa_insert (®ion_extent->decoder_extents, (unsigned long )ed_extent, ed_extent, +GFP_KERNEL ); +if (rc) { +free_region_extent (region_extent); +return rc; + } + +/* device model handles freeing region_extent */ +return online_region_extent (region_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range ed_range, ext_range; +struct cxl_dax_region *cxlr_dax; +struct cxled_extent *ed_extent; +struct cxl_region *cxlr; +struct device *dev; + + ext_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) +return -ENXIO ; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range ) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + +dev_dbg (&cxled->cxld.dev,"Checking ED (%pr) for extent %par\n" , + cxled->dpa_res, &ext_range); + +if (!range_contains (&ed_range, &ext_range)) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not fully in ED %par\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag, &ed_range); +return -ENXIO ; + } + +if (extents_contain (cxlr_dax, cxled, &ext_range)) +return 0 ; + +if (extents_overlap (cxlr_dax, cxled, &ext_range)) +return -ENXIO ; + + ed_extent =kzalloc (sizeof (*ed_extent),GFP_KERNEL ); +if (!ed_extent) +return -ENOMEM ; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; +memcpy (ed_extent->tag, extent->tag,CXL_EXTENT_TAG_LEN ); + +dev_dbg (dev,"Add extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); + +return cxlr_add_extent (cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +142
-0@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 , + }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base, + .end = dcr->base + dcr->decode_len -1 , + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + } + +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not in any DC region\n" , + &ext_range,CXL_EXTENT_TAG_LEN , extent->tag); +return -ENXIO ; +} + void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_log_type type, enum cxl_event_type event_type,@@ -1009,6 +1051,207 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,return rc; } +static int cxl_send_dc_response (struct cxl_memdev_state *mds,int opcode, +struct xarray *extent_array,int cnt) +{ +struct cxl_mbox_dc_response *p; +struct cxl_mbox_cmd mbox_cmd; +struct cxl_extent *extent; +unsigned long index; +u32 pl_index; +int rc =0 ; + +size_t pl_size =struct_size (p, extent_list, cnt); +u32 max_extents = cnt; + +/* May have to use more bit on response. */ +if (pl_size > mds->payload_size) { + max_extents = (mds->payload_size -sizeof (*p)) / +sizeof (struct updated_extent_list ); + pl_size =struct_size (p, extent_list, max_extents); + } + + struct cxl_mbox_dc_response *response __free(kfree) = +kzalloc (pl_size,GFP_KERNEL ); +if (!response) +return -ENOMEM ; + + pl_index =0 ; +xa_for_each (extent_array, index, extent) { + + response->extent_list[pl_index].dpa_start = extent->start_dpa; + response->extent_list[pl_index].length = extent->length; + pl_index++; + response->extent_list_size =cpu_to_le32 (pl_index); + +if (pl_index == max_extents) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; +if (pl_index < cnt) + response->flags &=CXL_DCD_EVENT_MORE ; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc) +return rc; + pl_index =0 ; + } + } + +if (pl_index) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; + rc =cxl_internal_send_cmd (mds, &mbox_cmd); + } + +return rc; +} + +void memdev_release_extent (struct cxl_memdev_state *mds,struct range *range) +{ +struct device *dev = mds->cxlds.dev; +struct xarray extent_list; + +struct cxl_extent extent = { + .start_dpa =cpu_to_le64 (range->start), + .length =cpu_to_le64 (range_len (range)), + }; + +dev_dbg (dev,"Release response dpa %par\n" , range); + +xa_init (&extent_list); +if (xa_insert (&extent_list,0 , &extent,GFP_KERNEL )) { +dev_dbg (dev,"Failed to release %par\n" , range); + goto destroy; + } + +if (cxl_send_dc_response (mds,CXL_MBOX_OP_RELEASE_DC , &extent_list,1 )) +dev_dbg (dev,"Failed to release %par\n" , range); + +destroy: +xa_destroy (&extent_list); +} + +static int validate_add_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +int rc; + + rc =cxl_validate_extent (mds, extent); +if (rc) +return rc;
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1163
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ +return cxl_add_extent (mds, extent); +} + +static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ;
reverse xmas tree
Quoted 16 lines
drivers/cxl/core/mbox.c +16
-0+int rc; + +xa_for_each (&mds->pending_extents, index, extent) { +if (validate_add_extent (mds, extent)) { +dev_dbg (dev,"unconsumed DC extent DPA:%#llx LEN:%#llx\n" , +le64_to_cpu (extent->start_dpa), +le64_to_cpu (extent->length)); +xa_erase (&mds->pending_extents, index); +kfree (extent); +continue ; + } + cnt++; + } + rc =cxl_send_dc_response (mds,CXL_MBOX_OP_ADD_DC_RESPONSE , + &mds->pending_extents, cnt); +xa_for_each (&mds->pending_extents, index, extent) {
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1189
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+xa_erase (&mds->pending_extents, index); +kfree (extent); + } +return rc; +} + +static int handle_add_event (struct cxl_memdev_state *mds, +struct cxl_event_dcd *event) +{ +struct cxl_extent *tmp =kzalloc (sizeof (*tmp),GFP_KERNEL );
for readability I would use *extent instead of *tmp
Quoted 333 lines
drivers/cxl/core/mbox.c +89
-1+struct device *dev = mds->cxlds.dev; + +if (!tmp) +return -ENOMEM ; + +memcpy (tmp, &event->extent,sizeof (*tmp)); +if (xa_insert (&mds->pending_extents, (unsigned long )tmp, tmp, +GFP_KERNEL )) { +kfree (tmp); +return -ENOMEM ; + } + +if (event->flags &CXL_DCD_EVENT_MORE ) { +dev_dbg (dev,"more bit set; delay the surfacing of extent\n" ); +return 0 ; + } + +/* extents are removed and free'ed in cxl_add_pending() */ +return cxl_add_pending (mds); +} + +static char *cxl_dcd_evt_type_str (u8 type) +{ +switch (type) { +case DCD_ADD_CAPACITY : +return "add" ; +case DCD_RELEASE_CAPACITY : +return "release" ; +case DCD_FORCED_CAPACITY_RELEASE : +return "force release" ; +default : +break ; + } + +return "<unknown>" ; +} + +static int cxl_handle_dcd_event_records (struct cxl_memdev_state *mds, +struct cxl_event_record_raw *raw_rec) +{ +struct cxl_event_dcd *event = &raw_rec->event.dcd; +struct cxl_extent *extent = &event->extent; +struct device *dev = mds->cxlds.dev; +uuid_t *id = &raw_rec->id; + +if (!uuid_equal (id, &CXL_EVENT_DC_EVENT_UUID )) +return -EINVAL ; + +dev_dbg (dev,"DCD event %s : DPA:%#llx LEN:%#llx\n" , +cxl_dcd_evt_type_str (event->event_type), +le64_to_cpu (extent->start_dpa),le64_to_cpu (extent->length)); + +switch (event->event_type) { +case DCD_ADD_CAPACITY : +return handle_add_event (mds, event); +case DCD_RELEASE_CAPACITY : +return cxl_rm_extent (mds, &event->extent); +case DCD_FORCED_CAPACITY_RELEASE : +dev_err_ratelimited (dev,"Forced release event ignored.\n" ); +return 0 ; +default : +return -EINVAL ; + } +} +static void cxl_mem_get_records_log (struct cxl_memdev_state *mds,enum cxl_event_log_type type) {@@ -1044,9 +1287,17 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,if (!nr_rec)break ; -for (i =0 ; i < nr_rec; i++) +for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); +if (type ==CXL_EVENT_TYPE_DCD ) { + rc =cxl_handle_dcd_event_records (mds, + &payload->records[i]); +if (rc) +dev_err_ratelimited (dev,"dcd event failed: %d\n" , + rc); + } + }if (payload->flags &CXL_GET_EVENT_FLAG_OVERFLOW )trace_cxl_overflow (cxlmd, type, payload);@@ -1078,6 +1329,8 @@ void cxl_mem_get_event_records(struct cxl_memdev_state *mds, u32 status) {dev_dbg (mds->cxlds.dev,"Reading event logs: %x\n" , status); +if (cxl_dcd_supported (mds) && (status &CXLDEV_EVENT_STATUS_DCD )) +cxl_mem_get_records_log (mds,CXL_EVENT_TYPE_DCD );if (status &CXLDEV_EVENT_STATUS_FATAL )cxl_mem_get_records_log (mds,CXL_EVENT_TYPE_FATAL );if (status &CXLDEV_EVENT_STATUS_FAIL )@@ -1610,6 +1863,17 @@ int cxl_poison_state_init(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_poison_state_init,CXL ); +static void clear_pending_extents (void *_mds) +{ +struct cxl_memdev_state *mds = _mds; +struct cxl_extent *extent; +unsigned long index; + +xa_for_each (&mds->pending_extents, index, extent) +kfree (extent); +xa_destroy (&mds->pending_extents); +} +struct cxl_memdev_state *cxl_memdev_state_create (struct device *dev) {struct cxl_memdev_state *mds;@@ -1628,6 +1892,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) mds->cxlds.type =CXL_DEVTYPE_CLASSMEM ; mds->ram_perf.qos_class =CXL_QOS_CLASS_INVALID ; mds->pmem_perf.qos_class =CXL_QOS_CLASS_INVALID ; +xa_init (&mds->pending_extents); +devm_add_action_or_reset (dev, clear_pending_extents, mds);return mds; }drivers/cxl/core/region.c +6
-0@@ -3037,6 +3037,7 @@ static void cxl_dax_region_release(struct device *dev) {struct cxl_dax_region *cxlr_dax =to_cxl_dax_region (dev); +ida_destroy (&cxlr_dax->extent_ida);kfree (cxlr_dax); }@@ -3090,6 +3091,8 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr) dev = &cxlr_dax->dev; cxlr_dax->cxlr = cxlr; + cxlr->cxlr_dax = cxlr_dax; +ida_init (&cxlr_dax->extent_ida);device_initialize (dev);lockdep_set_class (&dev->mutex, &cxl_dax_region_key);device_set_pm_not_required (dev);@@ -3190,7 +3193,10 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)static void cxlr_dax_unregister (void *_cxlr_dax) {struct cxl_dax_region *cxlr_dax = _cxlr_dax; +struct cxl_region *cxlr = cxlr_dax->cxlr; + cxlr->cxlr_dax =NULL ; + cxlr_dax->cxlr =NULL ;device_unregister (&cxlr_dax->dev); }drivers/cxl/cxl.h +51
-1@@ -11,6 +11,7 @@#include <linux/log2.h> #include <linux/node.h> #include <linux/io.h> +#include <linux/cxl-event.h> extern const struct nvdimm_security_ops *cxl_security_ops;@@ -169,11 +170,13 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)#define CXLDEV_EVENT_STATUS_WARN BIT(1)#define CXLDEV_EVENT_STATUS_FAIL BIT(2)#define CXLDEV_EVENT_STATUS_FATAL BIT(3) +#define CXLDEV_EVENT_STATUS_DCD BIT(4)#define CXLDEV_EVENT_STATUS_ALL (CXLDEV_EVENT_STATUS_INFO | \ CXLDEV_EVENT_STATUS_WARN | \ CXLDEV_EVENT_STATUS_FAIL | \ - CXLDEV_EVENT_STATUS_FATAL) + CXLDEV_EVENT_STATUS_FATAL | \ + CXLDEV_EVENT_STATUS_DCD)/* CXL rev 3.0 section 8.2.9.2.4; Table 8-52 */ #define CXLDEV_EVENT_INT_MODE_MASK GENMASK(1, 0)@@ -444,6 +447,18 @@ enum cxl_decoder_state { CXL_DECODER_STATE_AUTO, }; +/** +* struct cxled_extent - Extent within an endpoint decoder +* @cxled: Reference to the endpoint decoder +* @dpa_range: DPA range this extent covers within the decoder +* @tag: Tag from device for this extent +*/ +struct cxled_extent { +struct cxl_endpoint_decoder *cxled; +struct range dpa_range; +u8 tag[CXL_EXTENT_TAG_LEN ]; +}; +/** * struct cxl_endpoint_decoder - Endpoint / SPA to DPA decoder * @cxld: base cxl_decoder_object @@ -569,6 +584,7 @@ struct cxl_region_params {* @type: Endpoint decoder target type * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown * @cxlr_pmem: (for pmem regions) cached copy of the nvdimm bridge +* @cxlr_dax: (for DC regions) cached copy of CXL DAX bridge * @flags: Region state flags * @params: active + config params for the region * @coord: QoS access coordinates for the region @@ -582,6 +598,7 @@ struct cxl_region {enum cxl_decoder_type type;struct cxl_nvdimm_bridge *cxl_nvb;struct cxl_pmem_region *cxlr_pmem; +struct cxl_dax_region *cxlr_dax;unsigned long flags;struct cxl_region_params params;struct access_coordinate coord[ACCESS_COORDINATE_MAX ];@@ -622,12 +639,45 @@ struct cxl_pmem_region {struct cxl_pmem_region_mapping mapping[]; }; +/* See CXL 3.0 8.2.9.2.1.5 */ +enum dc_event { +DCD_ADD_CAPACITY , +DCD_RELEASE_CAPACITY , +DCD_FORCED_CAPACITY_RELEASE , +DCD_REGION_CONFIGURATION_UPDATED , +}; +struct cxl_dax_region {struct device dev;struct cxl_region *cxlr;struct range hpa_range; +struct ida extent_ida; }; +/** +* struct region_extent - CXL DAX region extent +* @dev: device representing this extent +* @cxlr_dax: back reference to parent region device +* @hpa_range: HPA range of this extent +* @tag: tag of the extent +* @decoder_extents: Endpoint decoder extents which make up this region extent +*/ +struct region_extent { +struct device dev; +struct cxl_dax_region *cxlr_dax; +struct range hpa_range; +uuid_t tag; +struct xarray decoder_extents; +}; + +bool is_region_extent (struct device *dev); +static inline struct region_extent *to_region_extent (struct device *dev) +{ +if (!is_region_extent (dev)) +return NULL ; + return container_of(dev, struct region_extent, dev); +} +/** * struct cxl_port - logical collection of upstream port devices and * downstream port devices to construct a CXL memory drivers/cxl/cxlmem.h +26
-0@@ -497,6 +497,7 @@ struct cxl_dc_region_info {* @pmem_perf: performance data entry matched to PMEM partition * @nr_dc_region: number of DC regions implemented in the memory device * @dc_region: array containing info about the DC regions +* @pending_extents: array of extents pending during more bit processing * @event: event log driver state * @poison: poison driver state info * @security: security driver state info @@ -532,6 +533,7 @@ struct cxl_memdev_state {u8 nr_dc_region;struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct xarray pending_extents;struct cxl_event_state event;struct cxl_poison_state poison;@@ -607,6 +609,21 @@ enum cxl_opcode {UUID_INIT (0x5e1819d9 ,0x11a9 ,0x400c ,0x81 ,0x1f ,0xd6 ,0x07 ,0x19 , \0x40 ,0x3d ,0x86 ) +/* +* Add Dynamic Capacity Response +* CXL rev 3.1 section 8.2.9.9.9.3; Table 8-168 & Table 8-169 + */ +struct cxl_mbox_dc_response { +__le32 extent_list_size; +u8 flags; +u8 reserved[3 ]; +struct updated_extent_list { +__le64 dpa_start; +__le64 length; +u8 reserved[8 ]; + } __packed extent_list[]; +} __packed; +struct cxl_mbox_get_supported_logs {__le16 entries;u8 rsvd[6 ];@@ -669,6 +686,14 @@ struct cxl_mbox_identify {UUID_INIT (0xfe927475 ,0xdd59 ,0x4339 ,0xa5 ,0x86 ,0x79 ,0xba ,0xb1 , \0x13 ,0xb7 ,0x74 ) +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1; Table 8-43 + */ +#define CXL_EVENT_DC_EVENT_UUID \ + UUID_INIT(0xca95afa7, 0xf183, 0x4018, 0x8c, 0x2f, 0x95, 0x26, 0x8e, \ + 0x10, 0x1a, 0x2a) +/* * Get Event Records output payload * CXL rev 3.0 section 8.2.9.2.2; Table 8-50 @@ -694,6 +719,7 @@ enum cxl_event_log_type {CXL_EVENT_TYPE_WARN ,CXL_EVENT_TYPE_FAIL ,CXL_EVENT_TYPE_FATAL , +CXL_EVENT_TYPE_DCD , CXL_EVENT_TYPE_MAX };include/linux/cxl-event.h +0
-0
include/linux/cxl-event.h struct cxl_event_mem_module { · line 96
Quoted 1 line
include/linux/cxl-event.h +0
-0@@ -96,11 +96,43 @@ struct cxl_event_mem_module {u8 reserved[0x3d ];
Previous code, but 61 would be better than 0x3d to be consistent with rest of cxl code
include/linux/cxl-event.h struct cxl_event_mem_module { · line 108
Quoted 12 lines
include/linux/cxl-event.h +10
-0} __packed; +/* +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-51 +*/ +#define CXL_EXTENT_TAG_LEN 0x10 +struct cxl_extent { +__le64 start_dpa; +__le64 length; +u8 tag[CXL_EXTENT_TAG_LEN ]; +__le16 shared_extn_seq; +u8 reserved[0x6 ];
Why not just 6? In general I find it odd that this header uses hex for array indexing when the rest of the cxl code uses decimal.
Quoted 5 lines
include/linux/cxl-event.h +5
-0+} __packed; + +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-50
include/linux/cxl-event.h struct cxl_event_mem_module { · line 123
Quoted 10 lines
include/linux/cxl-event.h +10
-0+*/ +#define CXL_DCD_EVENT_MORE BIT(0) +struct cxl_event_dcd { +struct cxl_event_record_hdr hdr; +u8 event_type; +u8 validity_flags; +__le16 host_id; +u8 region_index; +u8 flags; +u8 reserved1[0x2 ];
also here, 2?
include/linux/cxl-event.h struct cxl_event_mem_module { · line 125
Quoted 2 lines
include/linux/cxl-event.h +2
-0+struct cxl_extent extent; +u8 reserved2[0x18 ];
24?
Quoted 28 lines
include/linux/cxl-event.h +5
-0+__le32 num_avail_extents; +__le32 num_avail_tags; +} __packed; +union cxl_event {struct cxl_event_generic generic;struct cxl_event_gen_media gen_media;struct cxl_event_dram dram;struct cxl_event_mem_module mem_module; +struct cxl_event_dcd dcd;/* dram & gen_media event header */ struct cxl_event_media_hdr media_hdr; } __packed;tools/testing/cxl/Kbuild +2
-1@@ -61,7 +61,8 @@ cxl_core-y += $(CXL_CORE_SRC)/hdm.o cxl_core-y += $(CXL_CORE_SRC)/pmu.o cxl_core-y += $(CXL_CORE_SRC)/cdat.o cxl_core-$(CONFIG_TRACING) += $(CXL_CORE_SRC)/trace.o -cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o +cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o \ + $(CXL_CORE_SRC)/extent.o cxl_core-y += config_check.o cxl_core-y += cxl_core_test.o cxl_core-y += cxl_core_exports.o
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 5 lines · Dave Jiang
Quoted 2 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
[snip]
Quoted 9 lines
Quoted 6 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>A few nits below, but in general
Reviewed-by Dave Jiang <[email protected]>
Thanks.
Quoted 10 lines
drivers/cxl/core/extent.c line 99
Quoted 8 lines
drivers/cxl/core/extent.c new file +8
-0+ +static int online_region_extent (struct region_extent *region_extent) +{ +struct cxl_dax_region *cxlr_dax = region_extent->cxlr_dax; +struct device *dev; +int rc; + + dev = ®ion_extent->dev;Nit. You can move this up to when you declare 'dev'.
[done.]
[snip]
Quoted 8 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1163
Quoted 7 lines
drivers/cxl/core/mbox.c +7
-0+ +static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ;reverse xmas tree
yep.
[done.]
[snip]
Quoted 6 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1189
Quoted 5 lines
drivers/cxl/core/mbox.c +5
-0+ +static int handle_add_event (struct cxl_memdev_state *mds, +struct cxl_event_dcd *event) +{ +struct cxl_extent *tmp =kzalloc (sizeof (*tmp),GFP_KERNEL );for readability I would use *extent instead of *tmp
sure.
[done.]
[snip]
Quoted 8 lines
include/linux/cxl-event.h struct cxl_event_mem_module { · line 96
Quoted 7 lines
include/linux/cxl-event.h +0
-0@@ -96,11 +96,43 @@ struct cxl_event_mem_module {u8 reserved[0x3d ];Previous code, but 61 would be better than
0x3dto be consistent with rest of cxl code
:-(
I get the rest of the code argument. However, the specification uses hex for the number of bytes in the definitions. For this reason I prefer the use of hex here so that one can better match the code to the spec.
Quoted 16 lines
include/linux/cxl-event.h struct cxl_event_mem_module { · line 108
Quoted 13 lines
include/linux/cxl-event.h +10
-0} __packed; +/* +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-51 +*/ +#define CXL_EXTENT_TAG_LEN 0x10 +struct cxl_extent { +__le64 start_dpa; +__le64 length; +u8 tag[CXL_EXTENT_TAG_LEN ]; +__le16 shared_extn_seq; +u8 reserved[0x6 ];Why not just 6? In general I find it odd that this header uses hex for array indexing when the rest of the cxl code uses decimal.
I was just directly matching the spec.
Quoted 10 lines
Quoted 10 lines
include/linux/cxl-event.h +9
-0+} __packed; + +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-50 +*/ +#define CXL_DCD_EVENT_MORE BIT(0) +struct cxl_event_dcd { +struct cxl_event_record_hdr hdr;
Quoted 8 lines
include/linux/cxl-event.h struct cxl_event_mem_module { · line 123
Quoted 6 lines
include/linux/cxl-event.h +6
-0+u8 event_type; +u8 validity_flags; +__le16 host_id; +u8 region_index; +u8 flags; +u8 reserved1[0x2 ];also here, 2?
Same... I know it is odd when the hex string == the decimal string.
Quoted 5 lines
include/linux/cxl-event.h struct cxl_event_mem_module { · line 125
Quoted 3 lines
include/linux/cxl-event.h +2
-0+struct cxl_extent extent; +u8 reserved2[0x18 ];24?
same.
Ira
[snip]
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
In reply to [email protected]Quoted 54 lines · On Fri, Aug 16, 2024 at 09:44:26AM -0500, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Quoted 6 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
One minor change inline.
Quoted 854 lines
---
Changes:
[iweiny: combine this with the extent surface patches to better show the
lifetime extent objects in review]
[iweiny: clean up commit message.]
[iweiny: move extent verification of the 'read extents on region
creation' to this patch]
[iweiny: Provide for a common path for extent realization between an add
event and adding existing extents.]
[iweiny: Persist a check that an extent is within an endpoint decoder] [iweiny: reduce exported and non-static calls]
[iweiny: use %par]<Combined comments from the old patches which were addressed>
[Jonathan: implement the more bit with a simple algorithm which accepts
all extents it can.
Also include the response more bit to prevent payload overflow]
[Fan: Do not error if a contained extent is added.] [Jonathan: allocate ida after kzalloc]
[iweiny: fix ida resource leak]
[fan/djiang: remove unneeded memset]
[djiang: fix indentation]
[Jonathan: Fix indentation]
[Jonathan/djbw: make tag a uuid]
[djbw: create helpercalc_hpa_range()straight away]
[djbw: Allow for multiplecxled_extentsperregion_extent] [djbw: s/cxl_ed/cxled]
[djbw: s/cxl_release_ed_extent/cxled_release_extent/]
[djbw: s/reg_ext/region_extent/]
[djbw: s/dc_extent/extent/]
[Gregory/djbw: reject shared extents]
[iweiny: predicateextent.ccompile onCONFIG_CXL_REGION]--- drivers/cxl/core/Makefile | 2 +- drivers/cxl/core/core.h | 13 ++ drivers/cxl/core/extent.c | 345 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/mbox.c | 268 ++++++++++++++++++++++++++++++++++- drivers/cxl/core/region.c | 6 + drivers/cxl/cxl.h | 52 ++++++- drivers/cxl/cxlmem.h | 26 ++++ include/linux/cxl-event.h | 32 +++++ tools/testing/cxl/Kbuild | 3 +- 9 files changed, 743 insertions(+), 4 deletions(-)drivers/cxl/core/Makefile +1
-1@@ -15,4 +15,4 @@ cxl_core-y += hdm.o cxl_core-y += pmu.o cxl_core-y += cdat.o cxl_core-$(CONFIG_TRACING) += trace.o -cxl_core-$(CONFIG_CXL_REGION) += region.o +cxl_core-$(CONFIG_CXL_REGION) += region.o extent.odrivers/cxl/core/core.h +13
-0@@ -44,12 +44,24 @@ struct cxl_region *cxl_dpa_to_region(const struct cxl_memdev *cxlmd, u64 dpa,u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa); +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent); +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent);#else static inline u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa) {return ULLONG_MAX ; } +static inline int cxl_add_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +} +static inline int cxl_rm_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +return 0 ; +}static inline struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa,struct cxl_endpoint_decoder **cxled)@@ -121,5 +133,6 @@ long cxl_pci_get_latency(struct pci_dev *pdev);int cxl_update_hmat_access_coordinates (int nid,struct cxl_region *cxlr,enum access_coordinate_class access);bool cxl_need_node_perf_attrs_update (int nid); +void memdev_release_extent (struct cxl_memdev_state *mds,struct range *range);#endif /* __CXL_CORE_H__ */ drivers/cxl/core/extent.c new file +345
-0@@ -0,0 +1,345 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ + +#include <linux/device.h> +#include <cxl.h> + +#include "core.h" + +static void cxled_release_extent (struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct cxl_memdev_state *mds =cxled_to_mds (cxled); +struct device *dev = &cxled->cxld.dev; + +dev_dbg (dev,"Remove extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); +memdev_release_extent (mds, &ed_extent->dpa_range); +kfree (ed_extent); +} + +static void free_region_extent (struct region_extent *region_extent) +{ +struct cxled_extent *ed_extent; +unsigned long index; + +/* +* Remove from each endpoint decoder the extent which backs this region +* extent +*/ +xa_for_each (®ion_extent->decoder_extents, index, ed_extent) +cxled_release_extent (ed_extent->cxled, ed_extent); +xa_destroy (®ion_extent->decoder_extents); +ida_free (®ion_extent->cxlr_dax->extent_ida, region_extent->dev.id); +kfree (region_extent); +} + +static void region_extent_release (struct device *dev) +{ +struct region_extent *region_extent =to_region_extent (dev); + +free_region_extent (region_extent); +} + +static const struct device_type region_extent_type = { + .name ="extent" , + .release = region_extent_release, +}; + +bool is_region_extent (struct device *dev) +{ +return dev->type == ®ion_extent_type; +} +EXPORT_SYMBOL_NS_GPL (is_region_extent,CXL ); + +static void region_extent_unregister (void *ext) +{ +struct region_extent *region_extent = ext; + +dev_dbg (®ion_extent->dev,"DAX region rm extent HPA %par\n" , + ®ion_extent->hpa_range); +device_unregister (®ion_extent->dev); +} + +static void region_rm_extent (struct region_extent *region_extent) +{ +struct device *region_dev = region_extent->dev.parent; + +devm_release_action (region_dev, region_extent_unregister, region_extent); +} + +static struct region_extent * +alloc_region_extent (struct cxl_dax_region *cxlr_dax,struct range *hpa_range,u8 *tag) +{ +int id; + + struct region_extent *region_extent __free(kfree) = +kzalloc (sizeof (*region_extent),GFP_KERNEL ); +if (!region_extent) +return ERR_PTR (-ENOMEM ); + + id =ida_alloc (&cxlr_dax->extent_ida,GFP_KERNEL ); +if (id <0 ) +return ERR_PTR (-ENOMEM ); + + region_extent->hpa_range = *hpa_range; + region_extent->cxlr_dax = cxlr_dax; +import_uuid (®ion_extent->tag, tag); + region_extent->dev.id = id; +xa_init (®ion_extent->decoder_extents); +return no_free_ptr (region_extent); +} + +static int online_region_extent (struct region_extent *region_extent) +{ +struct cxl_dax_region *cxlr_dax = region_extent->cxlr_dax; +struct device *dev; +int rc; + + dev = ®ion_extent->dev; +device_initialize (dev); +device_set_pm_not_required (dev); + dev->parent = &cxlr_dax->dev; + dev->type = ®ion_extent_type; + rc =dev_set_name (dev,"extent%d.%d" , cxlr_dax->cxlr->id, dev->id); +if (rc) + goto err; + + rc =device_add (dev); +if (rc) + goto err; + +dev_dbg (dev,"region extent HPA %par\n" , ®ion_extent->hpa_range); +return devm_add_action_or_reset (&cxlr_dax->dev, region_extent_unregister, + region_extent); + +err: +dev_err (&cxlr_dax->dev,"Failed to initialize region extent HPA %par\n" , + ®ion_extent->hpa_range); + +put_device (dev); +return rc; +} + +struct match_data { +struct cxl_endpoint_decoder *cxled; +struct range *new_range; +}; + +static int match_contains (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data; +struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_contains (&entry->dpa_range, md->new_range)) +return true; + } +return false; +} + +static bool extents_contain (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct range *new_range) +{ +struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_contains); +if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static int match_overlaps (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data; +struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_overlaps (&entry->dpa_range, md->new_range)) +return true; + } + +return false; +} + +static bool extents_overlap (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct range *new_range) +{ +struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_overlaps); +if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static void calc_hpa_range (struct cxl_endpoint_decoder *cxled, +struct cxl_dax_region *cxlr_dax, +struct range *dpa_range, +struct range *hpa_range) +{ +resource_size_t dpa_offset, hpa; + + dpa_offset = dpa_range->start - cxled->dpa_res->start; + hpa = cxled->cxld.hpa_range.start + dpa_offset; + + hpa_range->start = hpa - cxlr_dax->hpa_range.start; + hpa_range->end = hpa_range->start +range_len (dpa_range) -1 ; +} + +static int cxlr_rm_extent (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct range *region_hpa_range = data; + +if (!region_extent) +return 0 ; + +/* +* Any extent which 'touches' the released range is removed. +*/ +if (range_overlaps (region_hpa_range, ®ion_extent->hpa_range)) { +dev_dbg (dev,"Remove region extent HPA %par\n" , + ®ion_extent->hpa_range); +region_rm_extent (region_extent); + } +return 0 ; +} + +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range hpa_range, dpa_range; +struct cxl_region *cxlr; + + dpa_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) { +memdev_release_extent (mds, &dpa_range); +return -ENXIO ; + } + +calc_hpa_range (cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + +/* Remove region extents which overlap */ +return device_for_each_child (&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +static int cxlr_add_extent (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct region_extent *region_extent; +struct range hpa_range; +int rc; + +calc_hpa_range (cxled, cxlr_dax, &ed_extent->dpa_range, &hpa_range); + + region_extent =alloc_region_extent (cxlr_dax, &hpa_range, ed_extent->tag); +if (IS_ERR (region_extent)) +return PTR_ERR (region_extent); + + rc =xa_insert (®ion_extent->decoder_extents, (unsigned long )ed_extent, ed_extent, +GFP_KERNEL ); +if (rc) { +free_region_extent (region_extent); +return rc; + } + +/* device model handles freeing region_extent */ +return online_region_extent (region_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range ed_range, ext_range; +struct cxl_dax_region *cxlr_dax; +struct cxled_extent *ed_extent; +struct cxl_region *cxlr; +struct device *dev; + + ext_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) +return -ENXIO ; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range ) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + +dev_dbg (&cxled->cxld.dev,"Checking ED (%pr) for extent %par\n" , + cxled->dpa_res, &ext_range); + +if (!range_contains (&ed_range, &ext_range)) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not fully in ED %par\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag, &ed_range); +return -ENXIO ; + } + +if (extents_contain (cxlr_dax, cxled, &ext_range)) +return 0 ; + +if (extents_overlap (cxlr_dax, cxled, &ext_range)) +return -ENXIO ; + + ed_extent =kzalloc (sizeof (*ed_extent),GFP_KERNEL ); +if (!ed_extent) +return -ENOMEM ; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; +memcpy (ed_extent->tag, extent->tag,CXL_EXTENT_TAG_LEN ); + +dev_dbg (dev,"Add extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); + +return cxlr_add_extent (cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +267
-1@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 , + }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base, + .end = dcr->base + dcr->decode_len -1 , + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + } + +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not in any DC region\n" , + &ext_range,CXL_EXTENT_TAG_LEN , extent->tag); +return -ENXIO ; +} + void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_log_type type, enum cxl_event_type event_type,@@ -1009,6 +1051,207 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,return rc; } +static int cxl_send_dc_response (struct cxl_memdev_state *mds,int opcode, +struct xarray *extent_array,int cnt) +{ +struct cxl_mbox_dc_response *p; +struct cxl_mbox_cmd mbox_cmd; +struct cxl_extent *extent; +unsigned long index; +u32 pl_index; +int rc =0 ; + +size_t pl_size =struct_size (p, extent_list, cnt); +u32 max_extents = cnt; + +/* May have to use more bit on response. */ +if (pl_size > mds->payload_size) { + max_extents = (mds->payload_size -sizeof (*p)) / +sizeof (struct updated_extent_list ); + pl_size =struct_size (p, extent_list, max_extents); + } + + struct cxl_mbox_dc_response *response __free(kfree) = +kzalloc (pl_size,GFP_KERNEL ); +if (!response) +return -ENOMEM ; + + pl_index =0 ; +xa_for_each (extent_array, index, extent) { + + response->extent_list[pl_index].dpa_start = extent->start_dpa; + response->extent_list[pl_index].length = extent->length; + pl_index++; + response->extent_list_size =cpu_to_le32 (pl_index); + +if (pl_index == max_extents) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; +if (pl_index < cnt) + response->flags &=CXL_DCD_EVENT_MORE ; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc) +return rc; + pl_index =0 ; + } + } + +if (pl_index) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; + rc =cxl_internal_send_cmd (mds, &mbox_cmd); + } + +return rc; +} + +void memdev_release_extent (struct cxl_memdev_state *mds,struct range *range) +{ +struct device *dev = mds->cxlds.dev; +struct xarray extent_list; + +struct cxl_extent extent = { + .start_dpa =cpu_to_le64 (range->start), + .length =cpu_to_le64 (range_len (range)), + }; + +dev_dbg (dev,"Release response dpa %par\n" , range); + +xa_init (&extent_list); +if (xa_insert (&extent_list,0 , &extent,GFP_KERNEL )) { +dev_dbg (dev,"Failed to release %par\n" , range); + goto destroy; + } + +if (cxl_send_dc_response (mds,CXL_MBOX_OP_RELEASE_DC , &extent_list,1 )) +dev_dbg (dev,"Failed to release %par\n" , range); + +destroy: +xa_destroy (&extent_list); +} + +static int validate_add_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +int rc; + + rc =cxl_validate_extent (mds, extent); +if (rc) +return rc; + +return cxl_add_extent (mds, extent); +} + +static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ; +int rc; + +xa_for_each (&mds->pending_extents, index, extent) { +if (validate_add_extent (mds, extent)) { +dev_dbg (dev,"unconsumed DC extent DPA:%#llx LEN:%#llx\n" , +le64_to_cpu (extent->start_dpa), +le64_to_cpu (extent->length)); +xa_erase (&mds->pending_extents, index); +kfree (extent); +continue ; + } + cnt++; + } + rc =cxl_send_dc_response (mds,CXL_MBOX_OP_ADD_DC_RESPONSE , + &mds->pending_extents, cnt); +xa_for_each (&mds->pending_extents, index, extent) { +xa_erase (&mds->pending_extents, index); +kfree (extent); + } +return rc; +} + +static int handle_add_event (struct cxl_memdev_state *mds, +struct cxl_event_dcd *event) +{ +struct cxl_extent *tmp =kzalloc (sizeof (*tmp),GFP_KERNEL ); +struct device *dev = mds->cxlds.dev; + +if (!tmp) +return -ENOMEM ; + +memcpy (tmp, &event->extent,sizeof (*tmp)); +if (xa_insert (&mds->pending_extents, (unsigned long )tmp, tmp, +GFP_KERNEL )) { +kfree (tmp); +return -ENOMEM ; + } + +if (event->flags &CXL_DCD_EVENT_MORE ) { +dev_dbg (dev,"more bit set; delay the surfacing of extent\n" ); +return 0 ; + } + +/* extents are removed and free'ed in cxl_add_pending() */ +return cxl_add_pending (mds); +} + +static char *cxl_dcd_evt_type_str (u8 type) +{ +switch (type) { +case DCD_ADD_CAPACITY : +return "add" ; +case DCD_RELEASE_CAPACITY : +return "release" ; +case DCD_FORCED_CAPACITY_RELEASE : +return "force release" ; +default : +break ; + } + +return "<unknown>" ; +} + +static int cxl_handle_dcd_event_records (struct cxl_memdev_state *mds, +struct cxl_event_record_raw *raw_rec) +{ +struct cxl_event_dcd *event = &raw_rec->event.dcd; +struct cxl_extent *extent = &event->extent; +struct device *dev = mds->cxlds.dev; +uuid_t *id = &raw_rec->id; + +if (!uuid_equal (id, &CXL_EVENT_DC_EVENT_UUID )) +return -EINVAL ; + +dev_dbg (dev,"DCD event %s : DPA:%#llx LEN:%#llx\n" , +cxl_dcd_evt_type_str (event->event_type), +le64_to_cpu (extent->start_dpa),le64_to_cpu (extent->length)); + +switch (event->event_type) { +case DCD_ADD_CAPACITY : +return handle_add_event (mds, event); +case DCD_RELEASE_CAPACITY : +return cxl_rm_extent (mds, &event->extent); +case DCD_FORCED_CAPACITY_RELEASE : +dev_err_ratelimited (dev,"Forced release event ignored.\n" ); +return 0 ; +default : +return -EINVAL ; + } +} +static void cxl_mem_get_records_log (struct cxl_memdev_state *mds,enum cxl_event_log_type type) {@@ -1044,9 +1287,17 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,if (!nr_rec)break ; -for (i =0 ; i < nr_rec; i++) +for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); +if (type ==CXL_EVENT_TYPE_DCD ) { + rc =cxl_handle_dcd_event_records (mds, + &payload->records[i]); +if (rc) +dev_err_ratelimited (dev,"dcd event failed: %d\n" , + rc); + } + }if (payload->flags &CXL_GET_EVENT_FLAG_OVERFLOW )trace_cxl_overflow (cxlmd, type, payload);@@ -1078,6 +1329,8 @@ void cxl_mem_get_event_records(struct cxl_memdev_state *mds, u32 status) {dev_dbg (mds->cxlds.dev,"Reading event logs: %x\n" , status); +if (cxl_dcd_supported (mds) && (status &CXLDEV_EVENT_STATUS_DCD )) +cxl_mem_get_records_log (mds,CXL_EVENT_TYPE_DCD );if (status &CXLDEV_EVENT_STATUS_FATAL )cxl_mem_get_records_log (mds,CXL_EVENT_TYPE_FATAL );if (status &CXLDEV_EVENT_STATUS_FAIL )@@ -1610,6 +1863,17 @@ int cxl_poison_state_init(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_poison_state_init,CXL ); +static void clear_pending_extents (void *_mds) +{ +struct cxl_memdev_state *mds = _mds; +struct cxl_extent *extent; +unsigned long index; + +xa_for_each (&mds->pending_extents, index, extent) +kfree (extent); +xa_destroy (&mds->pending_extents); +} +struct cxl_memdev_state *cxl_memdev_state_create (struct device *dev) {struct cxl_memdev_state *mds;@@ -1628,6 +1892,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) mds->cxlds.type =CXL_DEVTYPE_CLASSMEM ; mds->ram_perf.qos_class =CXL_QOS_CLASS_INVALID ; mds->pmem_perf.qos_class =CXL_QOS_CLASS_INVALID ; +xa_init (&mds->pending_extents); +devm_add_action_or_reset (dev, clear_pending_extents, mds);return mds; }drivers/cxl/core/region.c +6
-0@@ -3037,6 +3037,7 @@ static void cxl_dax_region_release(struct device *dev) {struct cxl_dax_region *cxlr_dax =to_cxl_dax_region (dev); +ida_destroy (&cxlr_dax->extent_ida);kfree (cxlr_dax); }@@ -3090,6 +3091,8 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr) dev = &cxlr_dax->dev; cxlr_dax->cxlr = cxlr; + cxlr->cxlr_dax = cxlr_dax; +ida_init (&cxlr_dax->extent_ida);device_initialize (dev);lockdep_set_class (&dev->mutex, &cxl_dax_region_key);device_set_pm_not_required (dev);@@ -3190,7 +3193,10 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)static void cxlr_dax_unregister (void *_cxlr_dax) {struct cxl_dax_region *cxlr_dax = _cxlr_dax; +struct cxl_region *cxlr = cxlr_dax->cxlr; + cxlr->cxlr_dax =NULL ; + cxlr_dax->cxlr =NULL ;device_unregister (&cxlr_dax->dev); }drivers/cxl/cxl.h +18
-1@@ -11,6 +11,7 @@#include <linux/log2.h> #include <linux/node.h> #include <linux/io.h> +#include <linux/cxl-event.h> extern const struct nvdimm_security_ops *cxl_security_ops;@@ -169,11 +170,13 @@ static inline int ways_to_eiw(unsigned int ways, u8 *eiw)#define CXLDEV_EVENT_STATUS_WARN BIT(1)#define CXLDEV_EVENT_STATUS_FAIL BIT(2)#define CXLDEV_EVENT_STATUS_FATAL BIT(3) +#define CXLDEV_EVENT_STATUS_DCD BIT(4)#define CXLDEV_EVENT_STATUS_ALL (CXLDEV_EVENT_STATUS_INFO | \ CXLDEV_EVENT_STATUS_WARN | \ CXLDEV_EVENT_STATUS_FAIL | \ - CXLDEV_EVENT_STATUS_FATAL) + CXLDEV_EVENT_STATUS_FATAL | \ + CXLDEV_EVENT_STATUS_DCD)/* CXL rev 3.0 section 8.2.9.2.4; Table 8-52 */ #define CXLDEV_EVENT_INT_MODE_MASK GENMASK(1, 0)@@ -444,6 +447,18 @@ enum cxl_decoder_state { CXL_DECODER_STATE_AUTO, }; +/** +* struct cxled_extent - Extent within an endpoint decoder +* @cxled: Reference to the endpoint decoder +* @dpa_range: DPA range this extent covers within the decoder +* @tag: Tag from device for this extent +*/ +struct cxled_extent { +struct cxl_endpoint_decoder *cxled; +struct range dpa_range; +u8 tag[CXL_EXTENT_TAG_LEN ]; +}; +/** * struct cxl_endpoint_decoder - Endpoint / SPA to DPA decoder * @cxld: base cxl_decoder_object @@ -569,6 +584,7 @@ struct cxl_region_params {* @type: Endpoint decoder target type * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown * @cxlr_pmem: (for pmem regions) cached copy of the nvdimm bridge +* @cxlr_dax: (for DC regions) cached copy of CXL DAX bridge * @flags: Region state flags * @params: active + config params for the region * @coord: QoS access coordinates for the region @@ -582,6 +598,7 @@ struct cxl_region {enum cxl_decoder_type type;struct cxl_nvdimm_bridge *cxl_nvb;struct cxl_pmem_region *cxlr_pmem; +struct cxl_dax_region *cxlr_dax;unsigned long flags;struct cxl_region_params params;struct access_coordinate coord[ACCESS_COORDINATE_MAX ];
drivers/cxl/cxl.h struct cxl_pmem_region { · line 642
Quoted 4 lines
drivers/cxl/cxl.h +1
-0@@ -622,12 +639,45 @@ struct cxl_pmem_region {struct cxl_pmem_region_mapping mapping[]; }; +/* See CXL 3.0 8.2.9.2.1.5 */
Update the reference to reflect CXL 3.1.
Fan
Quoted 172 lines
drivers/cxl/cxl.h +32
-0+enum dc_event { +DCD_ADD_CAPACITY , +DCD_RELEASE_CAPACITY , +DCD_FORCED_CAPACITY_RELEASE , +DCD_REGION_CONFIGURATION_UPDATED , +}; +struct cxl_dax_region {struct device dev;struct cxl_region *cxlr;struct range hpa_range; +struct ida extent_ida; }; +/** +* struct region_extent - CXL DAX region extent +* @dev: device representing this extent +* @cxlr_dax: back reference to parent region device +* @hpa_range: HPA range of this extent +* @tag: tag of the extent +* @decoder_extents: Endpoint decoder extents which make up this region extent +*/ +struct region_extent { +struct device dev; +struct cxl_dax_region *cxlr_dax; +struct range hpa_range; +uuid_t tag; +struct xarray decoder_extents; +}; + +bool is_region_extent (struct device *dev); +static inline struct region_extent *to_region_extent (struct device *dev) +{ +if (!is_region_extent (dev)) +return NULL ; + return container_of(dev, struct region_extent, dev); +} +/** * struct cxl_port - logical collection of upstream port devices and * downstream port devices to construct a CXL memory drivers/cxl/cxlmem.h +26
-0@@ -497,6 +497,7 @@ struct cxl_dc_region_info {* @pmem_perf: performance data entry matched to PMEM partition * @nr_dc_region: number of DC regions implemented in the memory device * @dc_region: array containing info about the DC regions +* @pending_extents: array of extents pending during more bit processing * @event: event log driver state * @poison: poison driver state info * @security: security driver state info @@ -532,6 +533,7 @@ struct cxl_memdev_state {u8 nr_dc_region;struct cxl_dc_region_info dc_region[CXL_MAX_DC_REGION ]; +struct xarray pending_extents;struct cxl_event_state event;struct cxl_poison_state poison;@@ -607,6 +609,21 @@ enum cxl_opcode {UUID_INIT (0x5e1819d9 ,0x11a9 ,0x400c ,0x81 ,0x1f ,0xd6 ,0x07 ,0x19 , \0x40 ,0x3d ,0x86 ) +/* +* Add Dynamic Capacity Response +* CXL rev 3.1 section 8.2.9.9.9.3; Table 8-168 & Table 8-169 + */ +struct cxl_mbox_dc_response { +__le32 extent_list_size; +u8 flags; +u8 reserved[3 ]; +struct updated_extent_list { +__le64 dpa_start; +__le64 length; +u8 reserved[8 ]; + } __packed extent_list[]; +} __packed; +struct cxl_mbox_get_supported_logs {__le16 entries;u8 rsvd[6 ];@@ -669,6 +686,14 @@ struct cxl_mbox_identify {UUID_INIT (0xfe927475 ,0xdd59 ,0x4339 ,0xa5 ,0x86 ,0x79 ,0xba ,0xb1 , \0x13 ,0xb7 ,0x74 ) +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1; Table 8-43 + */ +#define CXL_EVENT_DC_EVENT_UUID \ + UUID_INIT(0xca95afa7, 0xf183, 0x4018, 0x8c, 0x2f, 0x95, 0x26, 0x8e, \ + 0x10, 0x1a, 0x2a) +/* * Get Event Records output payload * CXL rev 3.0 section 8.2.9.2.2; Table 8-50 @@ -694,6 +719,7 @@ enum cxl_event_log_type {CXL_EVENT_TYPE_WARN ,CXL_EVENT_TYPE_FAIL ,CXL_EVENT_TYPE_FATAL , +CXL_EVENT_TYPE_DCD , CXL_EVENT_TYPE_MAX };include/linux/cxl-event.h +32
-0@@ -96,11 +96,43 @@ struct cxl_event_mem_module {u8 reserved[0x3d ]; } __packed; +/* +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-51 +*/ +#define CXL_EXTENT_TAG_LEN 0x10 +struct cxl_extent { +__le64 start_dpa; +__le64 length; +u8 tag[CXL_EXTENT_TAG_LEN ]; +__le16 shared_extn_seq; +u8 reserved[0x6 ]; +} __packed; + +/* +* Dynamic Capacity Event Record +* CXL rev 3.1 section 8.2.9.2.1.6; Table 8-50 +*/ +#define CXL_DCD_EVENT_MORE BIT(0) +struct cxl_event_dcd { +struct cxl_event_record_hdr hdr; +u8 event_type; +u8 validity_flags; +__le16 host_id; +u8 region_index; +u8 flags; +u8 reserved1[0x2 ]; +struct cxl_extent extent; +u8 reserved2[0x18 ]; +__le32 num_avail_extents; +__le32 num_avail_tags; +} __packed; +union cxl_event {struct cxl_event_generic generic;struct cxl_event_gen_media gen_media;struct cxl_event_dram dram;struct cxl_event_mem_module mem_module; +struct cxl_event_dcd dcd;/* dram & gen_media event header */ struct cxl_event_media_hdr media_hdr; } __packed;tools/testing/cxl/Kbuild +2
-1@@ -61,7 +61,8 @@ cxl_core-y += $(CXL_CORE_SRC)/hdm.o cxl_core-y += $(CXL_CORE_SRC)/pmu.o cxl_core-y += $(CXL_CORE_SRC)/cdat.o cxl_core-$(CONFIG_TRACING) += $(CXL_CORE_SRC)/trace.o -cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o +cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o \ + $(CXL_CORE_SRC)/extent.o cxl_core-y += config_check.o cxl_core-y += cxl_core_test.o cxl_core-y += cxl_core_exports.oSignature · 2 lines
-- 2.45.2
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 55 lines · On Fri, 23 Aug 2024 14:32:32 -0700 Fan Ni <[email protected]> wrote:
Quoted 54 lines · On Fri, Aug 16, 2024 at 09:44:26AM -0500, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Quoted 8 lines
Quoted 6 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>One minor change inline.
Hi Fan,
Crop please. I scanned past it 3 times when scrolling without noticing what you'd actually commented on.
Quoted 6 lines
Quoted 1 line
+/* See CXL 3.0 8.2.9.2.1.5 */
Update the reference to reflect CXL 3.1.
Fan
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 65 lines · Jonathan Cameron
Quoted 62 lines · On Fri, 23 Aug 2024 14:32:32 -0700 Fan Ni <[email protected]> wrote:
Quoted 60 lines · On Fri, Aug 16, 2024 at 09:44:26AM -0500, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
Quoted 5 lines
Quoted 1 line
One minor change inline.
Hi Fan,
Crop please. I scanned past it 3 times when scrolling without noticing what you'd actually commented on.
Sure. I will crop in the future.
Thanks for the tips, Jonathan.
Fan
Quoted 7 lines
Quoted 7 lines
Quoted 2 lines
+/* See CXL 3.0 8.2.9.2.1.5 */
Update the reference to reflect CXL 3.1.
Fan
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
In reply to [email protected]Quoted 54 lines · On Fri, 16 Aug 2024 09:44:26 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Quoted 6 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
A few minor bits and pieces inline.
Jonathan
Quoted 12 lines
drivers/cxl/core/extent.c new file +4
-0+static int match_contains (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data;
drivers/cxl/core/extent.c line 142
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_contains (&entry->dpa_range, md->new_range)) +return true;
As below, this returns int, so shouldn't be true or false.
Quoted 8 lines
drivers/cxl/core/extent.c new file +7
-0+ } +return false; +} +static int match_overlaps (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data;
drivers/cxl/core/extent.c line 178
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_overlaps (&entry->dpa_range, md->new_range)) +return true;
returns int, so returning true or false is odd.
Quoted 13 lines
drivers/cxl/core/extent.c new file +11
-0+ } + +return false; +} +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range hpa_range, dpa_range; +struct cxl_region *cxlr;
drivers/cxl/core/extent.c line 251
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+ + dpa_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) { +memdev_release_extent (mds, &dpa_range);
How does this condition happen? Perhaps a comment needed.
Quoted 15 lines
drivers/cxl/core/extent.c new file +15
-0+return -ENXIO ; + } + +calc_hpa_range (cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + +/* Remove region extents which overlap */ +return device_for_each_child (&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +static int cxlr_add_extent (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct region_extent *region_extent;
drivers/cxl/core/extent.c line 276
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+struct range hpa_range; +int rc; + +calc_hpa_range (cxled, cxlr_dax, &ed_extent->dpa_range, &hpa_range); + + region_extent =alloc_region_extent (cxlr_dax, &hpa_range, ed_extent->tag); +if (IS_ERR (region_extent)) +return PTR_ERR (region_extent); + + rc = xa_insert(®ion_extent->decoder_extents, (unsigned long)ed_extent, ed_extent,
I'd wrap that earlier to keep the line a bit shorter.
Quoted 41 lines
drivers/cxl/core/extent.c new file +41
-0+ GFP_KERNEL); +if (rc) { +free_region_extent (region_extent); +return rc; + } + +/* device model handles freeing region_extent */ +return online_region_extent (region_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range ed_range, ext_range; +struct cxl_dax_region *cxlr_dax; +struct cxled_extent *ed_extent; +struct cxl_region *cxlr; +struct device *dev; + + ext_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) +return -ENXIO ; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range ) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + +dev_dbg (&cxled->cxld.dev,"Checking ED (%pr) for extent %par\n" , + cxled->dpa_res, &ext_range);
drivers/cxl/core/extent.c line 327
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+ +if (!range_contains (&ed_range, &ext_range)) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not fully in ED %par\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag, &ed_range); +return -ENXIO ; + } + +if (extents_contain (cxlr_dax, cxled, &ext_range))
This case confuses me. If the extents are already there I think we should error out or at least print something as that's very wrong.
Quoted 29 lines
drivers/cxl/core/extent.c new file +18
-0+return 0 ; + +if (extents_overlap (cxlr_dax, cxled, &ext_range)) +return -ENXIO ; + + ed_extent =kzalloc (sizeof (*ed_extent),GFP_KERNEL ); +if (!ed_extent) +return -ENOMEM ; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; +memcpy (ed_extent->tag, extent->tag,CXL_EXTENT_TAG_LEN ); + +dev_dbg (dev,"Add extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); + +return cxlr_add_extent (cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +3
-0@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{
drivers/cxl/core/mbox.c int cxl_enumerate_cmds(struct cxl_memdev_state *mds) · line 897
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 , + }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) {
That's not the 'main' way to tell if an extent is shared because we could have a single extent (so seq == 0).
Should verify it's not in a DCD region that
is shareable to make this decision.
I've lost track on the region handling so maybe you already do this by not including those regions at all?
Quoted 39 lines
drivers/cxl/core/mbox.c +32
-0+dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base, + .end = dcr->base + dcr->decode_len -1 , + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + } + +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not in any DC region\n" , + &ext_range,CXL_EXTENT_TAG_LEN , extent->tag); +return -ENXIO ; +} + void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_log_type type, enum cxl_event_type event_type,@@ -1009,6 +1051,207 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,return rc; } +static int cxl_send_dc_response (struct cxl_memdev_state *mds,int opcode, +struct xarray *extent_array,int cnt) +{
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1066
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+struct cxl_mbox_dc_response *p; +struct cxl_mbox_cmd mbox_cmd; +struct cxl_extent *extent; +unsigned long index; +u32 pl_index; +int rc =0 ; + +size_t pl_size =struct_size (p, extent_list, cnt); +u32 max_extents = cnt; +
What is cnt is zero? All extents rejected so none in the extent_array. Need to send a zero extent response to reject them all IIRC.
Quoted 30 lines
drivers/cxl/core/mbox.c +30
-0+/* May have to use more bit on response. */ +if (pl_size > mds->payload_size) { + max_extents = (mds->payload_size -sizeof (*p)) / +sizeof (struct updated_extent_list ); + pl_size =struct_size (p, extent_list, max_extents); + } + + struct cxl_mbox_dc_response *response __free(kfree) = +kzalloc (pl_size,GFP_KERNEL ); +if (!response) +return -ENOMEM ; + + pl_index =0 ; +xa_for_each (extent_array, index, extent) { + + response->extent_list[pl_index].dpa_start = extent->start_dpa; + response->extent_list[pl_index].length = extent->length; + pl_index++; + response->extent_list_size =cpu_to_le32 (pl_index); + +if (pl_index == max_extents) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; +if (pl_index < cnt)
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1106
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ response->flags &=CXL_DCD_EVENT_MORE ; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc) +return rc; + pl_index =0 ; + } + } + +if (pl_index) {
|| !cnt
I think so we send a nothing accepted message.
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1099
Quoted 9 lines
drivers/cxl/core/mbox.c +9
-0+ mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; + rc =cxl_internal_send_cmd (mds, &mbox_cmd);
if (rc) return rc;
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1117
Quoted 2 lines
drivers/cxl/core/mbox.c +2
-0+ } +
return 0; So that reader doesn't have to check what rc was in !pl_index case and avoids assigning rc right at the top.
Quoted 4 lines
drivers/cxl/core/mbox.c +2
-0+return rc; +}
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1167
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ; +int rc; + +xa_for_each (&mds->pending_extents, index, extent) { +if (validate_add_extent (mds, extent)) {
Add a comment here that not accepting an extent but accepting some or none means this one was rejected (I'd forgotten how that bit worked)
Quoted 18 lines
drivers/cxl/core/mbox.c +18
-0+dev_dbg (dev,"unconsumed DC extent DPA:%#llx LEN:%#llx\n" , +le64_to_cpu (extent->start_dpa), +le64_to_cpu (extent->length)); +xa_erase (&mds->pending_extents, index); +kfree (extent); +continue ; + } + cnt++; + } + rc =cxl_send_dc_response (mds,CXL_MBOX_OP_ADD_DC_RESPONSE , + &mds->pending_extents, cnt); +xa_for_each (&mds->pending_extents, index, extent) { +xa_erase (&mds->pending_extents, index); +kfree (extent); + } +return rc; +} +
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1195
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+static int handle_add_event (struct cxl_memdev_state *mds, +struct cxl_event_dcd *event) +{ +struct cxl_extent *tmp =kzalloc (sizeof (*tmp),GFP_KERNEL ); +struct device *dev = mds->cxlds.dev; + +if (!tmp) +return -ENOMEM ; + +memcpy (tmp, &event->extent,sizeof (*tmp));
kmemdup?
Quoted 19 lines
drivers/cxl/core/mbox.c +14
-0+if (xa_insert (&mds->pending_extents, (unsigned long )tmp, tmp, +GFP_KERNEL )) { +kfree (tmp); +return -ENOMEM ; + } + +if (event->flags &CXL_DCD_EVENT_MORE ) { +dev_dbg (dev,"more bit set; delay the surfacing of extent\n" ); +return 0 ; + } + +/* extents are removed and free'ed in cxl_add_pending() */ +return cxl_add_pending (mds); +}static void cxl_mem_get_records_log (struct cxl_memdev_state *mds,enum cxl_event_log_type type) {
drivers/cxl/core/mbox.c static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, · line 1293
Quoted 8 lines
drivers/cxl/core/mbox.c +2
-1@@ -1044,9 +1287,17 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,if (!nr_rec)break ; -for (i =0 ; i < nr_rec; i++) +for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); +if (type ==CXL_EVENT_TYPE_DCD ) {
Bit of a deep indent so maybe flip logic?
Logic wise it's a bit dubious as we might want to match other types in future though so up to you.
if (type != CXL_EVENT_TYPE_DCD) continue; rc =
Quoted 13 lines
drivers/cxl/core/mbox.c +7
-0+ rc =cxl_handle_dcd_event_records (mds, + &payload->records[i]); +if (rc) +dev_err_ratelimited (dev,"dcd event failed: %d\n" , + rc); + } + }struct cxl_memdev_state *cxl_memdev_state_create (struct device *dev){
drivers/cxl/core/mbox.c +0
-0struct cxl_memdev_state *mds;
drivers/cxl/core/mbox.c struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) · line 1896
Quoted 5 lines
drivers/cxl/core/mbox.c +2
-0@@ -1628,6 +1892,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) mds->cxlds.type =CXL_DEVTYPE_CLASSMEM ; mds->ram_perf.qos_class =CXL_QOS_CLASS_INVALID ; mds->pmem_perf.qos_class =CXL_QOS_CLASS_INVALID ; +xa_init (&mds->pending_extents); +devm_add_action_or_reset (dev, clear_pending_extents, mds);
Why don't you need to check if this failed? Definitely seems unlikely to leave things in a good state. Unlikely to fail of course, but you never know.
Quoted 14 lines
drivers/cxl/core/mbox.c +2
-0return mds; }@@ -3090,6 +3091,8 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr) dev = &cxlr_dax->dev; cxlr_dax->cxlr = cxlr; + cxlr->cxlr_dax = cxlr_dax; +ida_init (&cxlr_dax->extent_ida);device_initialize (dev);lockdep_set_class (&dev->mutex, &cxl_dax_region_key);device_set_pm_not_required (dev);
drivers/cxl/core/mbox.c static int devm_cxl_add_pmem_region(struct cxl_region *cxlr) · line 3199
Quoted 7 lines
drivers/cxl/core/mbox.c +3
-0@@ -3190,7 +3193,10 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)static void cxlr_dax_unregister (void *_cxlr_dax) {struct cxl_dax_region *cxlr_dax = _cxlr_dax; +struct cxl_region *cxlr = cxlr_dax->cxlr; + cxlr->cxlr_dax =NULL ; + cxlr_dax->cxlr =NULL ;
cxlr_dax->cxlr was assigned before this patch.
I'm not seeing any new checks on these being non null so why are the needed? If there is a good reason for this then a comment would be useful.
Quoted 3 lines
drivers/cxl/core/mbox.c +0
-0device_unregister (&cxlr_dax->dev); }
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 5 lines · Jonathan Cameron
Quoted 2 lines · On Fri, 16 Aug 2024 09:44:26 -0500 [email protected] wrote:
From: Navneet Singh <[email protected]>
[snip]
Quoted 7 lines
Quoted 7 lines
(quoted diff) +7
-0+static int match_contains(struct device *dev, void *data) +{ + struct region_extent *region_extent = to_region_extent(dev); + struct match_data *md = data; + struct cxled_extent *entry; + unsigned long index; +
Quoted 8 lines
Review
Quoted 7 lines
(quoted diff) +7
-0+ if (!region_extent) + return 0; + + xa_for_each(®ion_extent->decoder_extents, index, entry) { + if (md->cxled == entry->cxled && + range_contains(&entry->dpa_range, md->new_range)) + return true;As below, this returns int, so shouldn't be true or false.
Yep. Thanks.
Quoted 5 lines
Quoted 4 lines
(quoted diff) +3
-0+ } + return false; +}
Quoted 16 lines
Quoted 4 lines
(quoted diff) +4
-0+static int match_overlaps(struct device *dev, void *data) +{ + struct region_extent *region_extent = to_region_extent(dev); + struct match_data *md = data;Review
Quoted 10 lines
(quoted diff) +10
-0+ struct cxled_extent *entry; + unsigned long index; + + if (!region_extent) + return 0; + + xa_for_each(®ion_extent->decoder_extents, index, entry) { + if (md->cxled == entry->cxled && + range_overlaps(&entry->dpa_range, md->new_range)) + return true;returns int, so returning true or false is odd.
Yep.
Quoted 18 lines
Quoted 18 lines
(quoted diff) +15
-0+ } + + return false; +} +int cxl_rm_extent(struct cxl_memdev_state *mds, struct cxl_extent *extent) +{ + u64 start_dpa = le64_to_cpu(extent->start_dpa); + struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; + struct cxl_endpoint_decoder *cxled; + struct range hpa_range, dpa_range; + struct cxl_region *cxlr; + + dpa_range = (struct range) { + .start = start_dpa, + .end = start_dpa + le64_to_cpu(extent->length) - 1,
Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ }; + + guard(rwsem_read)(&cxl_region_rwsem); + cxlr = cxl_dpa_to_region(cxlmd, start_dpa, &cxled); + if (!cxlr) { + memdev_release_extent(mds, &dpa_range);How does this condition happen? Perhaps a comment needed.
Fair enough. Proposed comment.
/*
* No region can happen here for a few reasons:
*
* 1) Extents were accepted and the host crashed/rebooted
* leaving them in an accepted state. On reboot the host
* has not yet created a region to own them.
*
* 2) Region destruction won the race with the device releasing
* all the extents. Here the release will be a duplicate of
* the one sent via region destruction.
*
* 3) The device is confused and releasing extents for which no
* region ever existed.
*
* In all these cases make sure the device knows we are not
* using this extent.
*/
Item 2 is AFAICS ok with the spec.
Quoted 20 lines
Quoted 20 lines
(quoted diff) +19
-0+ return -ENXIO; + } + + calc_hpa_range(cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + + /* Remove region extents which overlap */ + return device_for_each_child(&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +static int cxlr_add_extent(struct cxl_dax_region *cxlr_dax, + struct cxl_endpoint_decoder *cxled, + struct cxled_extent *ed_extent) +{ + struct region_extent *region_extent; + struct range hpa_range; + int rc; + + calc_hpa_range(cxled, cxlr_dax, &ed_extent->dpa_range, &hpa_range);
Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ + region_extent = alloc_region_extent(cxlr_dax, &hpa_range, ed_extent->tag); + if (IS_ERR(region_extent)) + return PTR_ERR(region_extent); + + rc = xa_insert(®ion_extent->decoder_extents, (unsigned long)ed_extent, ed_extent,I'd wrap that earlier to keep the line a bit shorter.
Done.
Quoted 47 lines
Quoted 47 lines
(quoted diff) +46
-0+ GFP_KERNEL); + if (rc) { + free_region_extent(region_extent); + return rc; + } + + /* device model handles freeing region_extent */ + return online_region_extent(region_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent(struct cxl_memdev_state *mds, struct cxl_extent *extent) +{ + u64 start_dpa = le64_to_cpu(extent->start_dpa); + struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; + struct cxl_endpoint_decoder *cxled; + struct range ed_range, ext_range; + struct cxl_dax_region *cxlr_dax; + struct cxled_extent *ed_extent; + struct cxl_region *cxlr; + struct device *dev; + + ext_range = (struct range) { + .start = start_dpa, + .end = start_dpa + le64_to_cpu(extent->length) - 1, + }; + + guard(rwsem_read)(&cxl_region_rwsem); + cxlr = cxl_dpa_to_region(cxlmd, start_dpa, &cxled); + if (!cxlr) + return -ENXIO; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + + dev_dbg(&cxled->cxld.dev, "Checking ED (%pr) for extent %par\n", + cxled->dpa_res, &ext_range); + + if (!range_contains(&ed_range, &ext_range)) { + dev_err_ratelimited(dev, + "DC extent DPA %par (%*phC) is not fully in ED %par\n", + &ext_range.start, CXL_EXTENT_TAG_LEN,
Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ extent->tag, &ed_range); + return -ENXIO; + } + + if (extents_contain(cxlr_dax, cxled, &ext_range))This case confuses me. If the extents are already there I think we should error out or at least print something as that's very wrong.
I thought we discussed this in one of the community meetings that it would be ok to accept these. We could certainly print a warning here.
In all honestly I'm wondering if these restrictions are really needed anymore. But at the same time I really, really, really don't think anyone has a good use case to have to support these cases. So I'm keeping the code simple for now.
Quoted 37 lines
Quoted 37 lines
(quoted diff) +18
-0+ return 0; + + if (extents_overlap(cxlr_dax, cxled, &ext_range)) + return -ENXIO; + + ed_extent = kzalloc(sizeof(*ed_extent), GFP_KERNEL); + if (!ed_extent) + return -ENOMEM; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; + memcpy(ed_extent->tag, extent->tag, CXL_EXTENT_TAG_LEN); + + dev_dbg(dev, "Add extent %par (%*phC)\n", &ed_extent->dpa_range, + CXL_EXTENT_TAG_LEN, ed_extent->tag); + + return cxlr_add_extent(cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +10
-0@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 ,
Quoted 8 lines
drivers/cxl/core/mbox.c int cxl_enumerate_cmds(struct cxl_memdev_state *mds) · line 897
Quoted 3 lines
drivers/cxl/core/mbox.c +3
-0+ }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) {That's not the 'main' way to tell if an extent is shared because we could have a single extent (so seq == 0).
Should verify it's not in a DCD region that
is shareable to make this decision.
Ah... :-/
Quoted 3 lines
I've lost track on the region handling so maybe you already do this by not including those regions at all?
I don't think so.
I'll add the region check. I see now why I glossed over this though. The shared nature of a DCD partition is defined in the DSMAS.
Is that correct? Or am I missing something in the spec?
Quoted 37 lines
Quoted 37 lines
drivers/cxl/core/mbox.c +29
-0+dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base, + .end = dcr->base + dcr->decode_len -1 , + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + } + +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not in any DC region\n" , + &ext_range,CXL_EXTENT_TAG_LEN , extent->tag); +return -ENXIO ; +} + void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_log_type type, enum cxl_event_type event_type,@@ -1009,6 +1051,207 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,return rc; }
Quoted 16 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1066
Quoted 13 lines
drivers/cxl/core/mbox.c +13
-0+static int cxl_send_dc_response (struct cxl_memdev_state *mds,int opcode, +struct xarray *extent_array,int cnt) +{ +struct cxl_mbox_dc_response *p; +struct cxl_mbox_cmd mbox_cmd; +struct cxl_extent *extent; +unsigned long index; +u32 pl_index; +int rc =0 ; + +size_t pl_size =struct_size (p, extent_list, cnt); +u32 max_extents = cnt; +What is cnt is zero? All extents rejected so none in the
extent_array. Need to send a zero extent response to reject them all IIRC.
yes. I missed that thanks.
Quoted 43 lines
Quoted 31 lines
drivers/cxl/core/mbox.c +30
-0+/* May have to use more bit on response. */ +if (pl_size > mds->payload_size) { + max_extents = (mds->payload_size -sizeof (*p)) / +sizeof (struct updated_extent_list ); + pl_size =struct_size (p, extent_list, max_extents); + } + + struct cxl_mbox_dc_response *response __free(kfree) = +kzalloc (pl_size,GFP_KERNEL ); +if (!response) +return -ENOMEM ; + + pl_index =0 ; +xa_for_each (extent_array, index, extent) { + + response->extent_list[pl_index].dpa_start = extent->start_dpa; + response->extent_list[pl_index].length = extent->length; + pl_index++; + response->extent_list_size =cpu_to_le32 (pl_index); + +if (pl_index == max_extents) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; +if (pl_index < cnt)drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1106
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ response->flags &=CXL_DCD_EVENT_MORE ; + + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc) +return rc; + pl_index =0 ; + } + } + +if (pl_index) {|| !cnt
Quoted 1 line
I think so we send a nothing accepted message.
Yep.
Quoted 12 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1115
Quoted 10 lines
drivers/cxl/core/mbox.c +9
-0+ mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; + rc =cxl_internal_send_cmd (mds, &mbox_cmd);if (rc) return rc;
Quoted 5 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1117
Quoted 2 lines
drivers/cxl/core/mbox.c +2
-0+ } +return 0; So that reader doesn't have to check what rc was in !pl_index case and avoids assigning rc right at the top.
Ah thanks. That might have been left over from something previous.
Quoted 6 lines
Quoted 4 lines
drivers/cxl/core/mbox.c +2
-0+return rc; +}
Quoted 15 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1129
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ; +int rc; + +xa_for_each (&mds->pending_extents, index, extent) { +if (validate_add_extent (mds, extent)) {Add a comment here that not accepting an extent but accepting some or none means this one was rejected (I'd forgotten how that bit worked)
Ok yeah that may not be clear without reading the spec closely.
/*
* Any extents which are to be rejected are omitted from
* the response. An empty response means all are
* rejected.
*/
Quoted 23 lines
Quoted 23 lines
drivers/cxl/core/mbox.c +22
-0+dev_dbg (dev,"unconsumed DC extent DPA:%#llx LEN:%#llx\n" , +le64_to_cpu (extent->start_dpa), +le64_to_cpu (extent->length)); +xa_erase (&mds->pending_extents, index); +kfree (extent); +continue ; + } + cnt++; + } + rc =cxl_send_dc_response (mds,CXL_MBOX_OP_ADD_DC_RESPONSE , + &mds->pending_extents, cnt); +xa_for_each (&mds->pending_extents, index, extent) { +xa_erase (&mds->pending_extents, index); +kfree (extent); + } +return rc; +} + +static int handle_add_event (struct cxl_memdev_state *mds, +struct cxl_event_dcd *event) +{ +struct cxl_extent *tmp =kzalloc (sizeof (*tmp),GFP_KERNEL );
Quoted 8 lines
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1157
Quoted 6 lines
drivers/cxl/core/mbox.c +6
-0+struct device *dev = mds->cxlds.dev; + +if (!tmp) +return -ENOMEM ; + +memcpy (tmp, &event->extent,sizeof (*tmp));kmemdup?
yep.
Quoted 30 lines
Quoted 20 lines
drivers/cxl/core/mbox.c +14
-0+if (xa_insert (&mds->pending_extents, (unsigned long )tmp, tmp, +GFP_KERNEL )) { +kfree (tmp); +return -ENOMEM ; + } + +if (event->flags &CXL_DCD_EVENT_MORE ) { +dev_dbg (dev,"more bit set; delay the surfacing of extent\n" ); +return 0 ; + } + +/* extents are removed and free'ed in cxl_add_pending() */ +return cxl_add_pending (mds); +}static void cxl_mem_get_records_log (struct cxl_memdev_state *mds,enum cxl_event_log_type type) {drivers/cxl/core/mbox.c static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, · line 1293
Quoted 8 lines
drivers/cxl/core/mbox.c +2
-1@@ -1044,9 +1287,17 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,if (!nr_rec)break ; -for (i =0 ; i < nr_rec; i++) +for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); +if (type ==CXL_EVENT_TYPE_DCD ) {Bit of a deep indent so maybe flip logic?
Quoted 2 lines
Logic wise it's a bit dubious as we might want to match other types in future though so up to you.
I was thinking more along these lines. But the rc is unneeded. That print can be in the handle function.
Something like this:
drivers/cxl/core/mbox.c +17 -13
@@ -1231,16 +1231,17 @@ static char *cxl_dcd_evt_type_str(u8 type)return "<unknown>" ; } -static int cxl_handle_dcd_event_records (struct cxl_memdev_state *mds, +static void cxl_handle_dcd_event_records (struct cxl_memdev_state *mds,struct cxl_event_record_raw *raw_rec) {struct cxl_event_dcd *event = &raw_rec->event.dcd;struct cxl_extent *extent = &event->extent;struct device *dev = mds->cxlds.dev;uuid_t *id = &raw_rec->id; +int rc;if (!uuid_equal (id, &CXL_EVENT_DC_EVENT_UUID )) -return -EINVAL ; +return ; dev_dbg(dev, "DCD event %s : DPA:%#llx LEN:%#llx\n", cxl_dcd_evt_type_str(event->event_type),
@@ -1248,15 +1249,22 @@ static int cxl_handle_dcd_event_records(struct cxl_memdev_state *mds,switch (event->event_type) {case DCD_ADD_CAPACITY : -return handle_add_event (mds, event); + rc =handle_add_event (mds, event); +break ;case DCD_RELEASE_CAPACITY : -return cxl_rm_extent (mds, &event->extent); + rc =cxl_rm_extent (mds, &event->extent); +break ;case DCD_FORCED_CAPACITY_RELEASE :dev_err_ratelimited (dev,"Forced release event ignored.\n" ); -return 0 ; + rc =0 ; +break ;default : -return -EINVAL ; + rc = -EINVAL ; +break ; } + +if (rc) +dev_err_ratelimited (dev,"dcd event failed: %d\n" , rc); } static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,
@@ -1297,13 +1305,9 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); -if (type ==CXL_EVENT_TYPE_DCD ) { - rc =cxl_handle_dcd_event_records (mds, - &payload->records[i]); -if (rc) -dev_err_ratelimited (dev,"dcd event failed: %d\n" , - rc); - } +if (type ==CXL_EVENT_TYPE_DCD ) +cxl_handle_dcd_event_records (mds, + &payload->records[i]); }if (payload->flags &CXL_GET_EVENT_FLAG_OVERFLOW )
<end diff>
Quoted 15 lines
if (type != CXL_EVENT_TYPE_DCD) continue; rc =Quoted 8 lines
drivers/cxl/core/mbox.c +7
-0+ rc =cxl_handle_dcd_event_records (mds, + &payload->records[i]); +if (rc) +dev_err_ratelimited (dev,"dcd event failed: %d\n" , + rc); + } + }
Quoted 12 lines
drivers/cxl/core/mbox.c struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) · line 1896
Quoted 9 lines
drivers/cxl/core/mbox.c +0
-0struct cxl_memdev_state *cxl_memdev_state_create (struct device *dev) {drivers/cxl/core/mbox.c +2
-0struct cxl_memdev_state *mds;@@ -1628,6 +1892,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) mds->cxlds.type =CXL_DEVTYPE_CLASSMEM ; mds->ram_perf.qos_class =CXL_QOS_CLASS_INVALID ; mds->pmem_perf.qos_class =CXL_QOS_CLASS_INVALID ; +xa_init (&mds->pending_extents); +devm_add_action_or_reset (dev, clear_pending_extents, mds);Why don't you need to check if this failed? Definitely seems unlikely to leave things in a good state. Unlikely to fail of course, but you never know.
yea good catch.
Quoted 20 lines
Quoted 20 lines
drivers/cxl/core/mbox.c +3
-0return mds; }@@ -3090,6 +3091,8 @@ static struct cxl_dax_region *cxl_dax_region_alloc(struct cxl_region *cxlr) dev = &cxlr_dax->dev; cxlr_dax->cxlr = cxlr; + cxlr->cxlr_dax = cxlr_dax; +ida_init (&cxlr_dax->extent_ida);device_initialize (dev);lockdep_set_class (&dev->mutex, &cxl_dax_region_key);device_set_pm_not_required (dev);@@ -3190,7 +3193,10 @@ static int devm_cxl_add_pmem_region(struct cxl_region *cxlr)static void cxlr_dax_unregister (void *_cxlr_dax) {struct cxl_dax_region *cxlr_dax = _cxlr_dax; +struct cxl_region *cxlr = cxlr_dax->cxlr;
Quoted 8 lines
drivers/cxl/core/mbox.c static int devm_cxl_add_pmem_region(struct cxl_region *cxlr) · line 3199
Quoted 2 lines
drivers/cxl/core/mbox.c +2
-0+ cxlr->cxlr_dax =NULL ; + cxlr_dax->cxlr =NULL ;
cxlr_dax->cxlrwas assigned before this patch.I'm not seeing any new checks on these being non null so why are the needed? If there is a good reason for this then a comment would be useful.
I'm not sure anymore either. Perhaps this was left over from an earlier version. Or was something I thought I would need that ended up getting removed. I'll test without this hunk and remove it if I can.
Thanks for the review,
Ira
[snip]
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
Quoted 40 lines
Quoted 11 lines
Quoted 11 lines
(quoted diff) +11
-0+int cxl_rm_extent(struct cxl_memdev_state *mds, struct cxl_extent *extent) +{ + u64 start_dpa = le64_to_cpu(extent->start_dpa); + struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; + struct cxl_endpoint_decoder *cxled; + struct range hpa_range, dpa_range; + struct cxl_region *cxlr; + + dpa_range = (struct range) { + .start = start_dpa, + .end = start_dpa + le64_to_cpu(extent->length) - 1,Quoted 8 lines
Review
Quoted 6 lines
(quoted diff) +6
-0+ }; + + guard(rwsem_read)(&cxl_region_rwsem); + cxlr = cxl_dpa_to_region(cxlmd, start_dpa, &cxled); + if (!cxlr) { + memdev_release_extent(mds, &dpa_range);How does this condition happen? Perhaps a comment needed.
Fair enough. Proposed comment.
/*
* No region can happen here for a few reasons:
*
* 1) Extents were accepted and the host crashed/rebooted
* leaving them in an accepted state. On reboot the host
* has not yet created a region to own them.
*
* 2) Region destruction won the race with the device releasing
* all the extents. Here the release will be a duplicate of
* the one sent via region destruction.
*
* 3) The device is confused and releasing extents for which no
* region ever existed.
*
* In all these cases make sure the device knows we are not
* using this extent.
*/
Quoted 1 line
Item 2 is AFAICS ok with the spec.
I'm not sure I follow 2. Why would device be releasing extents if we haven't given them back? We aren't supporting the mess that is force removal.
Quoted 57 lines
Quoted 48 lines
Quoted 48 lines
(quoted diff) +46
-0+ return -ENXIO; + } + + calc_hpa_range(cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + + /* Remove region extents which overlap */ + return device_for_each_child(&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent(struct cxl_memdev_state *mds, struct cxl_extent *extent) +{ + u64 start_dpa = le64_to_cpu(extent->start_dpa); + struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; + struct cxl_endpoint_decoder *cxled; + struct range ed_range, ext_range; + struct cxl_dax_region *cxlr_dax; + struct cxled_extent *ed_extent; + struct cxl_region *cxlr; + struct device *dev; + + ext_range = (struct range) { + .start = start_dpa, + .end = start_dpa + le64_to_cpu(extent->length) - 1, + }; + + guard(rwsem_read)(&cxl_region_rwsem); + cxlr = cxl_dpa_to_region(cxlmd, start_dpa, &cxled); + if (!cxlr) + return -ENXIO; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + + dev_dbg(&cxled->cxld.dev, "Checking ED (%pr) for extent %par\n", + cxled->dpa_res, &ext_range); + + if (!range_contains(&ed_range, &ext_range)) { + dev_err_ratelimited(dev, + "DC extent DPA %par (%*phC) is not fully in ED %par\n", + &ext_range.start, CXL_EXTENT_TAG_LEN,Quoted 8 lines
Review
Quoted 5 lines
(quoted diff) +5
-0+ extent->tag, &ed_range); + return -ENXIO; + } + + if (extents_contain(cxlr_dax, cxled, &ext_range))This case confuses me. If the extents are already there I think we should error out or at least print something as that's very wrong.
Quoted 2 lines
I thought we discussed this in one of the community meetings that it would be ok to accept these. We could certainly print a warning here.
A warning probably does the job of indicating that 'something' odd is going on. A device should never resend an extent overlapping one it sent before, (assuming no removal happened inbetween) so this should never happen, but who knows :(
Quoted 4 lines
In all honestly I'm wondering if these restrictions are really needed anymore. But at the same time I really, really, really don't think anyone has a good use case to have to support these cases. So I'm keeping the code simple for now.
Fair enough.
Quoted 53 lines
Quoted 38 lines
Quoted 38 lines
(quoted diff) +18
-0+ return 0; + + if (extents_overlap(cxlr_dax, cxled, &ext_range)) + return -ENXIO; + + ed_extent = kzalloc(sizeof(*ed_extent), GFP_KERNEL); + if (!ed_extent) + return -ENOMEM; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; + memcpy(ed_extent->tag, extent->tag, CXL_EXTENT_TAG_LEN); + + dev_dbg(dev, "Add extent %par (%*phC)\n", &ed_extent->dpa_range, + CXL_EXTENT_TAG_LEN, ed_extent->tag); + + return cxlr_add_extent(cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +10
-0@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 ,Quoted 8 lines
drivers/cxl/core/mbox.c int cxl_enumerate_cmds(struct cxl_memdev_state *mds) · line 897
Quoted 3 lines
drivers/cxl/core/mbox.c +3
-0+ }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) {That's not the 'main' way to tell if an extent is shared because we could have a single extent (so seq == 0).
Should verify it's not in a DCD region that
is shareable to make this decision.Ah... :-/
Quoted 3 lines
I've lost track on the region handling so maybe you already do this by not including those regions at all?
Quoted 6 lines
I don't think so.
I'll add the region check. I see now why I glossed over this though. The shared nature of a DCD partition is defined in the DSMAS.
Is that correct? Or am I missing something in the spec?
Yes. That's matches my understanding (I might also be missing something of course :)
Quoted 16 lines
Quoted 7 lines
Quoted 7 lines
drivers/cxl/core/mbox.c +7
-0+static int cxl_add_pending (struct cxl_memdev_state *mds) +{ +struct device *dev = mds->cxlds.dev; +struct cxl_extent *extent; +unsigned long index; +unsigned long cnt =0 ; +int rc;Quoted 8 lines
drivers/cxl/core/mbox.c int cxl_enumerate_cmds(struct cxl_memdev_state *mds) · line 907
Quoted 3 lines
drivers/cxl/core/mbox.c +3
-0+ +xa_for_each (&mds->pending_extents, index, extent) { +if (validate_add_extent (mds, extent)) {Add a comment here that not accepting an extent but accepting some or none means this one was rejected (I'd forgotten how that bit worked)
Quoted 7 lines
Ok yeah that may not be clear without reading the spec closely.
/*
* Any extents which are to be rejected are omitted from
* the response. An empty response means all are
* rejected.
*/
Perfect.
Quoted 35 lines
Quoted 35 lines
Quoted 25 lines
drivers/cxl/core/mbox.c +18
-0+dev_dbg (dev,"unconsumed DC extent DPA:%#llx LEN:%#llx\n" , +le64_to_cpu (extent->start_dpa), +le64_to_cpu (extent->length)); +xa_erase (&mds->pending_extents, index); +kfree (extent); +continue ; + } + cnt++; + } + rc =cxl_send_dc_response (mds,CXL_MBOX_OP_ADD_DC_RESPONSE , + &mds->pending_extents, cnt); +xa_for_each (&mds->pending_extents, index, extent) { +xa_erase (&mds->pending_extents, index); +kfree (extent); + } +return rc; +} +static void cxl_mem_get_records_log (struct cxl_memdev_state *mds,enum cxl_event_log_type type) {drivers/cxl/core/mbox.c static void cxl_mem_get_records_log(struct cxl_memdev_state *mds, · line 1293
Quoted 8 lines
drivers/cxl/core/mbox.c +2
-1@@ -1044,9 +1287,17 @@ static void cxl_mem_get_records_log(struct cxl_memdev_state *mds,if (!nr_rec)break ; -for (i =0 ; i < nr_rec; i++) +for (i =0 ; i < nr_rec; i++) {__cxl_event_trace_record (cxlmd, type, &payload->records[i]); +if (type ==CXL_EVENT_TYPE_DCD ) {Bit of a deep indent so maybe flip logic?
Quoted 8 lines
Quoted 2 lines
Logic wise it's a bit dubious as we might want to match other types in future though so up to you.
I was thinking more along these lines. But the rc is unneeded. That print can be in the handle function.
Something like this:
Looks good to me. (cut to save on scrolling!)
Jonathan
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
In reply to [email protected]Quoted 105 lines · On 8/16/2024 10:44 PM, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: combine this with the extent surface patches to better show the
lifetime extent objects in review]
[iweiny: clean up commit message.]
[iweiny: move extent verification of the 'read extents on region
creation' to this patch]
[iweiny: Provide for a common path for extent realization between an add
event and adding existing extents.]
[iweiny: Persist a check that an extent is within an endpoint decoder] [iweiny: reduce exported and non-static calls]
[iweiny: use %par]<Combined comments from the old patches which were addressed>
[Jonathan: implement the more bit with a simple algorithm which accepts
all extents it can.
Also include the response more bit to prevent payload overflow]
[Fan: Do not error if a contained extent is added.] [Jonathan: allocate ida after kzalloc]
[iweiny: fix ida resource leak]
[fan/djiang: remove unneeded memset]
[djiang: fix indentation]
[Jonathan: Fix indentation]
[Jonathan/djbw: make tag a uuid]
[djbw: create helpercalc_hpa_range()straight away]
[djbw: Allow for multiplecxled_extentsperregion_extent] [djbw: s/cxl_ed/cxled]
[djbw: s/cxl_release_ed_extent/cxled_release_extent/]
[djbw: s/reg_ext/region_extent/]
[djbw: s/dc_extent/extent/]
[Gregory/djbw: reject shared extents]
[iweiny: predicateextent.ccompile onCONFIG_CXL_REGION]--- drivers/cxl/core/Makefile | 2 +- drivers/cxl/core/core.h | 13 ++ drivers/cxl/core/extent.c | 345 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/cxl/core/mbox.c | 268 ++++++++++++++++++++++++++++++++++- drivers/cxl/core/region.c | 6 + drivers/cxl/cxl.h | 52 ++++++- drivers/cxl/cxlmem.h | 26 ++++ include/linux/cxl-event.h | 32 +++++ tools/testing/cxl/Kbuild | 3 +- 9 files changed, 743 insertions(+), 4 deletions(-)
[...]
drivers/cxl/core/extent.c line 157
Quoted 12 lines
drivers/cxl/core/extent.c new file +12
-0+ +static bool extents_contain (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct range *new_range) +{ +struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_contains);
Is it better to use __free(put_device) here to drop below 'put_device(extent_device)'?
Quoted 27 lines
drivers/cxl/core/extent.c new file +27
-0+if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static int match_overlaps (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct match_data *md = data; +struct cxled_extent *entry; +unsigned long index; + +if (!region_extent) +return 0 ; + +xa_for_each (®ion_extent->decoder_extents, index, entry) { +if (md->cxled == entry->cxled && +range_overlaps (&entry->dpa_range, md->new_range)) +return true; + } + +return false; +} + +static bool extents_overlap(struct cxl_dax_region *cxlr_dax,
drivers/cxl/core/extent.c line 194
Quoted 10 lines
drivers/cxl/core/extent.c new file +10
-0+struct cxl_endpoint_decoder *cxled, + struct range *new_range) +{ + struct device *extent_device; +struct match_data md = { + .cxled = cxled, + .new_range = new_range, + }; + + extent_device =device_find_child (&cxlr_dax->dev, &md, match_overlaps);
Same as above.
Quoted 242 lines
drivers/cxl/core/extent.c new file +151
-0+if (!extent_device) +return false; + +put_device (extent_device); +return true; +} + +static void calc_hpa_range (struct cxl_endpoint_decoder *cxled, +struct cxl_dax_region *cxlr_dax, +struct range *dpa_range, +struct range *hpa_range) +{ +resource_size_t dpa_offset, hpa; + + dpa_offset = dpa_range->start - cxled->dpa_res->start; + hpa = cxled->cxld.hpa_range.start + dpa_offset; + + hpa_range->start = hpa - cxlr_dax->hpa_range.start; + hpa_range->end = hpa_range->start +range_len (dpa_range) -1 ; +} + +static int cxlr_rm_extent (struct device *dev,void *data) +{ +struct region_extent *region_extent =to_region_extent (dev); +struct range *region_hpa_range = data; + +if (!region_extent) +return 0 ; + +/* +* Any extent which 'touches' the released range is removed. +*/ +if (range_overlaps (region_hpa_range, ®ion_extent->hpa_range)) { +dev_dbg (dev,"Remove region extent HPA %par\n" , + ®ion_extent->hpa_range); +region_rm_extent (region_extent); + } +return 0 ; +} + +int cxl_rm_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range hpa_range, dpa_range; +struct cxl_region *cxlr; + + dpa_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) { +memdev_release_extent (mds, &dpa_range); +return -ENXIO ; + } + +calc_hpa_range (cxled, cxlr->cxlr_dax, &dpa_range, &hpa_range); + +/* Remove region extents which overlap */ +return device_for_each_child (&cxlr->cxlr_dax->dev, &hpa_range, + cxlr_rm_extent); +} + +static int cxlr_add_extent (struct cxl_dax_region *cxlr_dax, +struct cxl_endpoint_decoder *cxled, +struct cxled_extent *ed_extent) +{ +struct region_extent *region_extent; +struct range hpa_range; +int rc; + +calc_hpa_range (cxled, cxlr_dax, &ed_extent->dpa_range, &hpa_range); + + region_extent =alloc_region_extent (cxlr_dax, &hpa_range, ed_extent->tag); +if (IS_ERR (region_extent)) +return PTR_ERR (region_extent); + + rc =xa_insert (®ion_extent->decoder_extents, (unsigned long )ed_extent, ed_extent, +GFP_KERNEL ); +if (rc) { +free_region_extent (region_extent); +return rc; + } + +/* device model handles freeing region_extent */ +return online_region_extent (region_extent); +} + +/* Callers are expected to ensure cxled has been attached to a region */ +int cxl_add_extent (struct cxl_memdev_state *mds,struct cxl_extent *extent) +{ +u64 start_dpa =le64_to_cpu (extent->start_dpa); +struct cxl_memdev *cxlmd = mds->cxlds.cxlmd; +struct cxl_endpoint_decoder *cxled; +struct range ed_range, ext_range; +struct cxl_dax_region *cxlr_dax; +struct cxled_extent *ed_extent; +struct cxl_region *cxlr; +struct device *dev; + + ext_range = (struct range ) { + .start = start_dpa, + .end = start_dpa +le64_to_cpu (extent->length) -1 , + }; + +guard (rwsem_read)(&cxl_region_rwsem); + cxlr =cxl_dpa_to_region (cxlmd, start_dpa, &cxled); +if (!cxlr) +return -ENXIO ; + + cxlr_dax = cxled->cxld.region->cxlr_dax; + dev = &cxled->cxld.dev; + ed_range = (struct range ) { + .start = cxled->dpa_res->start, + .end = cxled->dpa_res->end, + }; + +dev_dbg (&cxled->cxld.dev,"Checking ED (%pr) for extent %par\n" , + cxled->dpa_res, &ext_range); + +if (!range_contains (&ed_range, &ext_range)) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not fully in ED %par\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag, &ed_range); +return -ENXIO ; + } + +if (extents_contain (cxlr_dax, cxled, &ext_range)) +return 0 ; + +if (extents_overlap (cxlr_dax, cxled, &ext_range)) +return -ENXIO ; + + ed_extent =kzalloc (sizeof (*ed_extent),GFP_KERNEL ); +if (!ed_extent) +return -ENOMEM ; + + ed_extent->cxled = cxled; + ed_extent->dpa_range = ext_range; +memcpy (ed_extent->tag, extent->tag,CXL_EXTENT_TAG_LEN ); + +dev_dbg (dev,"Add extent %par (%*phC)\n" , &ed_extent->dpa_range, +CXL_EXTENT_TAG_LEN , ed_extent->tag); + +return cxlr_add_extent (cxlr_dax, cxled, ed_extent); +}drivers/cxl/core/mbox.c +76
-0@@ -882,6 +882,48 @@ int cxl_enumerate_cmds(struct cxl_memdev_state *mds) }EXPORT_SYMBOL_NS_GPL (cxl_enumerate_cmds,CXL ); +static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 , + }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base, + .end = dcr->base + dcr->decode_len -1 , + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + } + +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) is not in any DC region\n" , + &ext_range,CXL_EXTENT_TAG_LEN , extent->tag); +return -ENXIO ; +} + void cxl_event_trace_record(const struct cxl_memdev *cxlmd, enum cxl_event_log_type type, enum cxl_event_type event_type,@@ -1009,6 +1051,207 @@ static int cxl_clear_event_record(struct cxl_memdev_state *mds,return rc; } +static int cxl_send_dc_response (struct cxl_memdev_state *mds,int opcode, +struct xarray *extent_array,int cnt) +{ +struct cxl_mbox_dc_response *p; +struct cxl_mbox_cmd mbox_cmd; +struct cxl_extent *extent; +unsigned long index; +u32 pl_index; +int rc =0 ; + +size_t pl_size =struct_size (p, extent_list, cnt); +u32 max_extents = cnt; + +/* May have to use more bit on response. */ +if (pl_size > mds->payload_size) { + max_extents = (mds->payload_size -sizeof (*p)) / +sizeof (struct updated_extent_list ); + pl_size =struct_size (p, extent_list, max_extents); + } + + struct cxl_mbox_dc_response *response __free(kfree) = +kzalloc (pl_size,GFP_KERNEL ); +if (!response) +return -ENOMEM ; + + pl_index =0 ; +xa_for_each (extent_array, index, extent) { + + response->extent_list[pl_index].dpa_start = extent->start_dpa; + response->extent_list[pl_index].length = extent->length; + pl_index++; + response->extent_list_size =cpu_to_le32 (pl_index); + +if (pl_index == max_extents) {
drivers/cxl/core/mbox.c static int cxl_clear_event_record(struct cxl_memdev_state *mds, · line 1097
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; +if (pl_index < cnt) + response->flags &=CXL_DCD_EVENT_MORE ;
Should "response->flags |= CXL_DCD_EVENT_MORE"?
And seems like there is a bug if the value of 'cnt' is double the value of 'max_extents'. the response command will be sent in this xa_for_each() scope twice, and CXL_DCD_EVENT_MORE will be set for both times. because 'pl_index < cnt' is always true.
Quoted 23 lines
drivers/cxl/core/mbox.c +23
-0+ + rc =cxl_internal_send_cmd (mds, &mbox_cmd); +if (rc) +return rc; + pl_index =0 ; + } + } + +if (pl_index) { + mbox_cmd = (struct cxl_mbox_cmd ) { + .opcode = opcode, + .size_in =struct_size (response, extent_list, + pl_index), + .payload_in = response, + }; + + response->flags =0 ; + rc =cxl_internal_send_cmd (mds, &mbox_cmd); + } + +return rc; +} +
Re: [PATCH v3 18/25] cxl/extent: Process DCD events and realize region extents
In reply to [email protected]Quoted 54 lines · On Fri, Aug 16, 2024 at 09:44:26AM -0500, [email protected] wrote:
From: Navneet Singh <[email protected]>
A dynamic capacity device (DCD) sends events to signal the host for changes in the availability of Dynamic Capacity (DC) memory. These events contain extents describing a DPA range and meta data for memory to be added or removed. Events may be sent from the device at any time.
Three types of events can be signaled, Add, Release, and Force Release.
On add, the host may accept or reject the memory being offered. If no region exists, or the extent is invalid, the extent should be rejected. Add extent events may be grouped by a 'more' bit which indicates those extents should be processed as a group.
On remove, the host can delay the response until the host is safely not using the memory. If no region exists the release can be sent immediately. The host may also release extents (or partial extents) at any time. Thus the 'more' bit grouping of release events is of less value and can be ignored in favor of sending multiple release capacity responses for groups of release events.
Force removal is intended as a mechanism between the FM and the device and intended only when the host is unresponsive, out of sync, or otherwise broken. Purposely ignore force removal events.
Regions are made up of one or more devices which may be surfacing memory to the host. Once all devices in a region have surfaced an extent the region can expose a corresponding extent for the user to consume. Without interleaving a device extent forms a 1:1 relationship with the region extent. Immediately surface a region extent upon getting a device extent.
Per the specification the device is allowed to offer or remove extents at any time. However, anticipated use cases can expect extents to be offered, accepted, and removed in well defined chunks.
Simplify extent tracking with the following restrictions.
1) Flag for removal any extent which overlaps a requested release range.
2) Refuse the offer of extents which overlap already accepted memory ranges.
3) Accept again a range which has already been accepted by the host. (It is likely the device has an error because it should already know that this range was accepted. But from the host point of view it is safe to acknowledge that acceptance again.)Management of the region extent devices must be synchronized with potential uses of the memory within the DAX layer. Create region extent devices as children of the
cxl_dax_regiondevice such that the DAX region driver can co-drive them and synchronize with the DAX layer. Synchronization and management is handled in a subsequent patch.
Quoted 6 lines
Process DCD events and create region devices.
Signed-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>
One more minor inline.
Quoted 25 lines
drivers/cxl/core/mbox.c +25
-0+static int cxl_validate_extent (struct cxl_memdev_state *mds, +struct cxl_extent *extent) +{ +u64 start =le64_to_cpu (extent->start_dpa); +u64 length =le64_to_cpu (extent->length); +struct device *dev = mds->cxlds.dev; + +struct range ext_range = (struct range ){ + .start = start, + .end = start + length -1 , + }; + +if (le16_to_cpu (extent->shared_extn_seq) !=0 ) { +dev_err_ratelimited (dev, +"DC extent DPA %par (%*phC) can not be shared\n" , + &ext_range.start,CXL_EXTENT_TAG_LEN , + extent->tag); +return -ENXIO ; + } + +/* Extents must not cross DC region boundary's */ +for (int i =0 ; i < mds->nr_dc_region; i++) { +struct cxl_dc_region_info *dcr = &mds->dc_region[i]; +struct range region_range = (struct range ) { + .start = dcr->base,
drivers/cxl/core/mbox.c int cxl_enumerate_cmds(struct cxl_memdev_state *mds) · line 919
Quoted 10 lines
drivers/cxl/core/mbox.c +10
-0+ .end = dcr->base + dcr->decode_len - 1, + }; + +if (range_contains (®ion_range, &ext_range)) { +dev_dbg (dev,"DC extent DPA %par (DCR:%d:%#llx)(%*phC)\n" , + &ext_range, i, start - dcr->base, +CXL_EXTENT_TAG_LEN , extent->tag); +return 0 ; + } + }
For extent validation, we may need to ensure its size is not 0 based on the spec. Noted that during testing, do not see issue for the case as 0-sized extents will be rejected when trying to add even though it passes the validation.
Fan
PATCH v3 19/25 cxl/region/extent: Expose region extent information in sysfs
In reply to Ira WeinyFrom: Navneet Singh <[email protected]>
Extent information can be helpful to the user to coordinate memory usage with the external orchestrator and FM.
Expose the details of region extents by creating the following sysfs entries.
/sys/bus/cxl/devices/dax_regionX/extentX.Y /sys/bus/cxl/devices/dax_regionX/extentX.Y/offset /sys/bus/cxl/devices/dax_regionX/extentX.Y/length /sys/bus/cxl/devices/dax_regionX/extentX.Y/tag
---
Changes:
[iweiny: split this out]
[Jonathan: add documentation for extent sysfs] [Jonathan/djbw: s/label/tag]
[Jonathan/djbw: treat tag as uuid]
[djbw: use __ATTRIBUTE_GROUPS]
[djbw: make tag invisible if it is empty] [djbw/iweiny: use conventional id names for extents; extentX.Y]
--- Documentation/ABI/testing/sysfs-bus-cxl | 13 ++++++++ drivers/cxl/core/extent.c | 58 +++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+)
Documentation/ABI/testing/sysfs-bus-cxl +13 -0
@@ -599,3 +599,16 @@ Description: See Documentation/ABI/stable/sysfs-devices-node. access0 provides the number to the closest initiator and access1 provides the number to the closest CPU. + +What: /sys/bus/cxl/devices/dax_regionX/extentX.Y/offset + /sys/bus/cxl/devices/dax_regionX/extentX.Y/length + /sys/bus/cxl/devices/dax_regionX/extentX.Y/tag +Date: October, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) [For Dynamic Capacity regions only] Extent offset and + length within the region. Users can use the extent information + to create DAX devices on specific extents. This is done by + creating and destroying DAX devices in specific sequences and + looking at the mappings created.
drivers/cxl/core/extent.c +58 -0
70 lines not on this page · raw message
Signature · 1 line
2.45.2
Dave Jiang
maintainerRe: [PATCH v3 19/25] cxl/region/extent: Expose region extent information in sysfs
Quoted 36 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Extent information can be helpful to the user to coordinate memory usage with the external orchestrator and FM.
Expose the details of region extents by creating the following sysfs entries.
/sys/bus/cxl/devices/dax_regionX/extentX.Y/sys/bus/cxl/devices/dax_regionX/extentX.Y/offset/sys/bus/cxl/devices/dax_regionX/extentX.Y/length/sys/bus/cxl/devices/dax_regionX/extentX.Y/tagSigned-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: split this out]
[Jonathan: add documentation for extent sysfs] [Jonathan/djbw: s/label/tag]
[Jonathan/djbw: treat tag as uuid]
[djbw: use__ATTRIBUTE_GROUPS]
[djbw: make tag invisible if it is empty] [djbw/iweiny: use conventional id names for extents; extentX.Y]--- Documentation/ABI/testing/sysfs-bus-cxl | 13 ++++++++ drivers/cxl/core/extent.c | 58 +++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+)Documentation/ABI/testing/sysfs-bus-cxl +0
-0
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 605
Quoted 7 lines
Documentation/ABI/testing/sysfs-bus-cxl +4
-0@@ -599,3 +599,16 @@ Description: See Documentation/ABI/stable/sysfs-devices-node. access0 provides the number to the closest initiator and access1 provides the number to the closest CPU. + +What: /sys/bus/cxl/devices/dax_regionX/extentX.Y/offset + /sys/bus/cxl/devices/dax_regionX/extentX.Y/length + /sys/bus/cxl/devices/dax_regionX/extentX.Y/tag
I wonder consider an entry for each with their own descriptions, which seems to be the standard practice.
DJ
Quoted 86 lines
Documentation/ABI/testing/sysfs-bus-cxl +9
-0+Date: October, 2024 +KernelVersion: v6.12 +Contact: [email protected] +Description: + (RO) [For Dynamic Capacity regions only] Extent offset and + length within the region. Users can use the extent information + to create DAX devices on specific extents. This is done by + creating and destroying DAX devices in specific sequences and + looking at the mappings created.drivers/cxl/core/extent.c +58
-0@@ -6,6 +6,63 @@#include "core.h" +static ssize_t offset_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct region_extent *region_extent =to_region_extent (dev); + +return sysfs_emit (buf,"%#llx\n" , region_extent->hpa_range.start); +} +static DEVICE_ATTR_RO (offset); + +static ssize_t length_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct region_extent *region_extent =to_region_extent (dev); +u64 length =range_len (®ion_extent->hpa_range); + +return sysfs_emit (buf,"%#llx\n" , length); +} +static DEVICE_ATTR_RO (length); + +static ssize_t tag_show (struct device *dev,struct device_attribute *attr, +char *buf) +{ +struct region_extent *region_extent =to_region_extent (dev); + +return sysfs_emit (buf,"%pUb\n" , ®ion_extent->tag); +} +static DEVICE_ATTR_RO (tag); + +static struct attribute *region_extent_attrs[] = { + &dev_attr_offset.attr, + &dev_attr_length.attr, + &dev_attr_tag.attr, +NULL , +}; + +static uuid_t empty_tag = {0 }; + +static umode_t region_extent_visible (struct kobject *kobj, +struct attribute *a,int n) +{ +struct device *dev =kobj_to_dev (kobj); +struct region_extent *region_extent =to_region_extent (dev); + +if (a == &dev_attr_tag.attr && +uuid_equal (®ion_extent->tag, &empty_tag)) +return 0 ; + +return a->mode; +} + +static const struct attribute_group region_extent_attribute_group = { + .attrs = region_extent_attrs, + .is_visible = region_extent_visible, +}; + +__ATTRIBUTE_GROUPS (region_extent_attribute); +static void cxled_release_extent (struct cxl_endpoint_decoder *cxled,struct cxled_extent *ed_extent) {@@ -44,6 +101,7 @@ static void region_extent_release(struct device *dev)static const struct device_type region_extent_type = { .name ="extent" , .release = region_extent_release, + .groups = region_extent_attribute_groups, };bool is_region_extent (struct device *dev)
Re: [PATCH v3 19/25] cxl/region/extent: Expose region extent information in sysfs
Quoted 34 lines · Dave Jiang
Quoted 31 lines · On 8/16/24 7:44 AM, [email protected] wrote:
From: Navneet Singh <[email protected]>
Extent information can be helpful to the user to coordinate memory usage with the external orchestrator and FM.
Expose the details of region extents by creating the following sysfs entries.
/sys/bus/cxl/devices/dax_regionX/extentX.Y/sys/bus/cxl/devices/dax_regionX/extentX.Y/offset/sys/bus/cxl/devices/dax_regionX/extentX.Y/length/sys/bus/cxl/devices/dax_regionX/extentX.Y/tagSigned-off-by Navneet Singh <[email protected]>Co-developed-by Ira Weiny <[email protected]>Signed-off-by Ira Weiny <[email protected]>---
Changes:
[iweiny: split this out]
[Jonathan: add documentation for extent sysfs] [Jonathan/djbw: s/label/tag]
[Jonathan/djbw: treat tag as uuid]
[djbw: use__ATTRIBUTE_GROUPS]
[djbw: make tag invisible if it is empty] [djbw/iweiny: use conventional id names for extents; extentX.Y]--- Documentation/ABI/testing/sysfs-bus-cxl | 13 ++++++++ drivers/cxl/core/extent.c | 58 +++++++++++++++++++++++++++++++++ 2 files changed, 71 insertions(+)
Quoted 14 lines
Documentation/ABI/testing/sysfs-bus-cxl Description: · line 605
Quoted 12 lines
Documentation/ABI/testing/sysfs-bus-cxl +4
-0@@ -599,3 +599,16 @@ Description: See Documentation/ABI/stable/sysfs-devices-node. access0 provides the number to the closest initiator and access1 provides the number to the closest CPU. + +What: /sys/bus/cxl/devices/dax_regionX/extentX.Y/offset + /sys/bus/cxl/devices/dax_regionX/extentX.Y/length + /sys/bus/cxl/devices/dax_regionX/extentX.Y/tagI wonder consider an entry for each with their own descriptions, which seems to be the standard practice.
:-/ Except kind of for the access'.
What: /sys/bus/cxl/devices/regionZ/accessY/read_bandwidth
/sys/bus/cxl/devices/regionZ/accessY/write_banwidth
What: /sys/bus/cxl/devices/regionZ/accessY/read_latency
/sys/bus/cxl/devices/regionZ/accessY/write_latency
But I think you have a point.
Ira
Quoted 3 lines
DJ
[snip]