Skip to contentSkip to conversation

Enhance network interface feature testing

PATCH Applied Abhinav Jain 2 participants 5 messages Aug 21, 2024 – Aug 23, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

v9 cover Enhance network interface feature testing

This small series includes fixes for creation of veth pairs for networkless kernels & adds tests for turning the different network interface features on and off in selftests/net/netdevice.sh script. Tested using vng and compiles for network as well as networkless kernel.

Changes in v9:
Removed veth1 to avoid redundant testing as per feedback in v8.

Changes in v8:
https://lore.kernel.org/all/[email protected]/

Remove redundant variable initial_state as per feedback in v7.

Changes in v7:
https://lore.kernel.org/all/[email protected]

Create a third patch in the series to do SKIP -> XFAIL replacement. Add logic to incorporate XFAIL on setting IP address for veth pair.

Changes in v6:
https://lore.kernel.org/all/[email protected]

Use XFAIL for ethtool operations that are unsupported instead of SKIP.

Changes in v5:
https://lore.kernel.org/all/[email protected]

Rectify the syntax for ip add link.
Fix the veth_created condition check.

Changes in v4:
https://lore.kernel.org/all/[email protected]

Move veth creation/removal to the main shell script. Tested using vng on a networkless kernel and the script works, sample output below the changes.

Changes in v3:
https://lore.kernel.org/all/[email protected]

Add a check for netdev, create veth pair for testing. Restore feature to its initial state.

Changes in v2:
https://lore.kernel.org/all/[email protected]

Remove tail usage; use read to parse the features from temp file.

v1:
https://lore.kernel.org/all/[email protected]

```
# selftests: net: netdevice.sh
# No valid network device found, creating veth pair
# PASS: veth0: set interface up
# PASS: veth0: set MAC address
# XFAIL: veth0: set IP address unsupported for veth*
# PASS: veth0: ethtool list features
# PASS: veth0: Turned off feature: rx-checksumming
# PASS: veth0: Turned on feature: rx-checksumming
# PASS: veth0: Restore feature rx-checksumming to initial state on
# Actual changes:
# tx-checksum-ip-generic: off

...

# PASS: veth0: Turned on feature: rx-udp-gro-forwarding
# PASS: veth0: Restore feature rx-udp-gro-forwarding to initial state off
# Cannot get register dump: Operation not supported
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```

Abhinav Jain (3):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed features of interface
selftests: net: Use XFAIL for operations not supported by the driver

 tools/testing/selftests/net/netdevice.sh | 60 ++++++++++++++++++++++--
 1 file changed, 56 insertions(+), 4 deletions(-)

--
2.34.1

#1 lore raw

PATCH v9 1/3 selftests: net: Create veth pair for testing in networkless kernel

Check if the netdev list is empty and create veth pair to be used for feature on/off testing.
Remove the veth pair after testing is complete.

---
 tools/testing/selftests/net/netdevice.sh | 15 +++++++++++++++
 1 file changed, 15 insertions(+)
tools/testing/selftests/net/netdevice.sh +15 -0
index e3afcb424710..999d72b6670c 100755
@@ -129,6 +129,7 @@ kci_netdev_ethtool()
 
 	kci_netdev_ethtool_test 74 'dump' "ethtool -d $netdev"
 	kci_netdev_ethtool_test 94 'stats' "ethtool -S $netdev"
+
 	return 0
 }
 
@@ -196,10 +197,24 @@ if [ ! -e "$TMP_LIST_NETDEV" ];then
 fi
 
 ip link show |grep '^[0-9]' | grep -oE '[[:space:]].*eth[0-9]*:|[[:space:]].*enp[0-9]s[0-9]:' | cut -d\  -f2 | cut -d: -f1> "$TMP_LIST_NETDEV"
+
+if [ ! -s "$TMP_LIST_NETDEV" ]; then
+	echo "No valid network device found, creating veth pair"
+	ip link add veth0 type veth peer name veth1
+	echo "veth0" > "$TMP_LIST_NETDEV"
+	veth_created=1
+fi
+
 while read netdev
 do
 	kci_test_netdev "$netdev"
 done < "$TMP_LIST_NETDEV"
 
+#clean up veth interface pair if it was created
+if [ "$veth_created" ]; then
+	ip link delete veth0
+	echo "Removed veth pair"
+fi
+
 rm "$TMP_LIST_NETDEV"
 exit 0
Signature · 1 line
2.34.1
#2 lore raw

PATCH v9 2/3 selftests: net: Add on/off checks for non-fixed features of interface

In reply to Abhinav Jain

Implement on/off testing for all non-fixed features via while loop.

---
 tools/testing/selftests/net/netdevice.sh | 35 +++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)
tools/testing/selftests/net/netdevice.sh +34 -1
index 999d72b6670c..f7752e1ebe22 100755
@@ -124,7 +124,40 @@ kci_netdev_ethtool()
 		return 1
 	fi
 	echo "PASS: $netdev: ethtool list features"
-	#TODO for each non fixed features, try to turn them on/off
+
+	while read -r FEATURE VALUE FIXED; do
+		[ "$FEATURE" != "Features" ] || continue # Skip "Features"
+		[ "$FIXED" != "[fixed]" ] || continue # Skip fixed features
+		feature="${FEATURE%:*}"
+
+		ethtool --offload "$netdev" "$feature" off
+		if [ $? -eq 0 ]; then
+			echo "PASS: $netdev: Turned off feature: $feature"
+		else
+			echo "FAIL: $netdev: Failed to turn off feature:" \
+				"$feature"
+		fi
+
+		ethtool --offload "$netdev" "$feature" on
+		if [ $? -eq 0 ]; then
+			echo "PASS: $netdev: Turned on feature: $feature"
+		else
+			echo "FAIL: $netdev: Failed to turn on feature:" \
+				"$feature"
+		fi
+
+		#restore the feature to its initial state
+		ethtool --offload "$netdev" "$feature" "$VALUE"
+		if [ $? -eq 0 ]; then
+			echo "PASS: $netdev: Restore feature $feature" \
+				"to initial state $VALUE"
+		else
+			echo "FAIL: $netdev: Failed to restore feature" \
+				"$feature to initial state $VALUE"
+		fi
+
+	done < "$TMP_ETHTOOL_FEATURES"
+
 	rm "$TMP_ETHTOOL_FEATURES"
 
 	kci_netdev_ethtool_test 74 'dump' "ethtool -d $netdev"
Signature · 1 line
2.34.1
#3 lore raw

PATCH v9 3/3 selftests: net: Use XFAIL for operations not supported by the driver

In reply to Abhinav Jain

Check if veth pair was created and if yes, xfail on setting IP address logging an informational message.
Use XFAIL instead of SKIP for unsupported ethtool APIs.

---
 tools/testing/selftests/net/netdevice.sh | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)
tools/testing/selftests/net/netdevice.sh +7 -3
index f7752e1ebe22..438f7b2acc5f 100755
@@ -67,8 +67,12 @@ kci_net_setup()
 		return $ksft_skip
 	fi
 
-	# TODO what ipaddr to set ? DHCP ?
-	echo "SKIP: $netdev: set IP address"
+	if [ "$veth_created" ]; then
+		echo "XFAIL: $netdev: set IP address unsupported for veth*"
+	else
+		# TODO what ipaddr to set ? DHCP ?
+		echo "SKIP: $netdev: set IP address"
+	fi
 	return $ksft_skip
 }
 
@@ -86,7 +90,7 @@ kci_netdev_ethtool_test()
 	ret=$?
 	if [ $ret -ne 0 ];then
 		if [ $ret -eq "$1" ];then
-			echo "SKIP: $netdev: ethtool $2 not supported"
+			echo "XFAIL: $netdev: ethtool $2 not supported"
 			return $ksft_skip
 		else
 			echo "FAIL: $netdev: ethtool $2"
Signature · 1 line
2.34.1
#4 lore raw
In reply to Abhinav Jain
This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Hello:

This series was applied to netdev/net-next.git (main) by Jakub Kicinski <[email protected]>:

Quoted 9 lines · On Wed, 21 Aug 2024 22:49:00 +0530 you wrote:

This small series includes fixes for creation of veth pairs for networkless kernels & adds tests for turning the different network interface features on and off in selftests/net/netdevice.sh script. Tested using vng and compiles for network as well as networkless kernel.

Changes in v9:
Removed veth1 to avoid redundant testing as per feedback in v8.

[...]

Here is the summary with links:
- [v9,net-next,1/3] selftests: net: Create veth pair for testing in networkless kernel

    https://git.kernel.org/netdev/net-next/c/1820b84f3c61
  - [v9,net-next,2/3] selftests: net: Add on/off checks for non-fixed features of interface
    https://git.kernel.org/netdev/net-next/c/6ce7bdbc0d4b
  - [v9,net-next,3/3] selftests: net: Use XFAIL for operations not supported by the driver
    https://git.kernel.org/netdev/net-next/c/8402a158028f

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html