Enhance network interface feature testing
Status from this message: This series was applied to netdev/net-next.git (main)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v9 Latest3 patches 0 repliesApplied 3/3
- v83 patches 7 repliesSuperseded
- v73 patches 2 repliesSuperseded
Earlier versions · 3
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v6 | 2 patches | 4 replies | Superseded | |
| v5 | 2 patches | 4 replies | Superseded | |
| v4 | 2 patches | 3 replies | Superseded |
Changes in v9 from the cover letter
Removed veth1 to avoid redundant testing as per feedback in v8.
Patches in v9 All 3 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | selftests: net: Create veth pair for testing in networkless kerneltools/ | +15 | 0 replies | Applied |
| 2/3 | selftests: net: Add on/off checks for non-fixed features of interfacetools/ | +34 | 0 replies | Applied |
| 3/3 | selftests: net: Use XFAIL for operations not supported by the drivertools/ | +7 | 0 replies | Applied |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Simon Horman |
|---|---|
| 1/3 | R-b |
| 2/3 | R-b |
| 3/3 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v9 net-next 0/3] Enhance network interface feature testing
This small series includes fixes for creation of veth pairs for networkless kernels & adds tests for turning the different network interface features on and off in selftests/net/netdevice.sh script. Tested using vng and compiles for network as well as networkless kernel.
Changes in v9:
Removed veth1 to avoid redundant testing as per feedback in v8.
Changes in v8:
https://lore.kernel.org/all/[email protected]/
Remove redundant variable initial_state as per feedback in v7.
Changes in v7:
https://lore.kernel.org/all/[email protected]
Create a third patch in the series to do SKIP -> XFAIL replacement. Add logic to incorporate XFAIL on setting IP address for veth pair.
Changes in v6:
https://lore.kernel.org/all/[email protected]
Use XFAIL for ethtool operations that are unsupported instead of SKIP.
Changes in v5:
https://lore.kernel.org/all/[email protected]
Rectify the syntax for ip add link.
Fix the veth_created condition check.
Changes in v4:
https://lore.kernel.org/all/[email protected]
Move veth creation/removal to the main shell script. Tested using vng on a networkless kernel and the script works, sample output below the changes.
Changes in v3:
https://lore.kernel.org/all/[email protected]
Add a check for netdev, create veth pair for testing. Restore feature to its initial state.
Changes in v2:
https://lore.kernel.org/all/[email protected]
Remove tail usage; use read to parse the features from temp file.
v1:
https://lore.kernel.org/all/[email protected]
``` # selftests: net: netdevice.sh # No valid network device found, creating veth pair # PASS: veth0: set interface up # PASS: veth0: set MAC address # XFAIL: veth0: set IP address unsupported for veth* # PASS: veth0: ethtool list features # PASS: veth0: Turned off feature: rx-checksumming # PASS: veth0: Turned on feature: rx-checksumming # PASS: veth0: Restore feature rx-checksumming to initial state on # Actual changes: # tx-checksum-ip-generic: off ... # PASS: veth0: Turned on feature: rx-udp-gro-forwarding # PASS: veth0: Restore feature rx-udp-gro-forwarding to initial state off # Cannot get register dump: Operation not supported # XFAIL: veth0: ethtool dump not supported # PASS: veth0: ethtool stats # PASS: veth0: stop interface ```
Abhinav Jain (3):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed features of interface
selftests: net: Use XFAIL for operations not supported by the driver
tools/testing/selftests/net/netdevice.sh | 60 ++++++++++++++++++++++-- 1 file changed, 56 insertions(+), 4 deletions(-)
--
2.34.1