Skip to contentSkip to conversation

lib/igt_kms: add enum for link rate and lane count

PATCH In review Kunal Joshi 5 participants 36 messages Aug 25, 2024 – Sep 12, 2024 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/14 lib/igt_kms: add enum for link rate and lane count

add enums for link rate, lane count

---
 lib/igt_kms.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
lib/igt_kms.h +23 -0
index 25ba50916..999921f9f 100644
@@ -258,6 +258,29 @@ enum intel_broadcast_rgb_mode {
 	BROADCAST_RGB_16_235
 };
 
+enum dp_link_rate {
+	DP_LINK_RATE_162000 = 162000,
+	DP_LINK_RATE_216000 = 216000,
+	DP_LINK_RATE_243000 = 243000,
+	DP_LINK_RATE_270000 = 270000,
+	DP_LINK_RATE_324000 = 324000,
+	DP_LINK_RATE_432000 = 432000,
+	DP_LINK_RATE_540000 = 540000,
+	DP_LINK_RATE_675000 = 675000,
+	DP_LINK_RATE_810000 = 810000,
+	DP_LINK_RATE_1000000 = 1000000,
+	DP_LINK_RATE_1350000 = 1350000,
+	DP_LINK_RATE_2000000 = 2000000
+};
+
+#define DP_MAX_LINK_RATE_COUNT 12
+
+enum dp_lane_count {
+	DP_LANE_COUNT_1 = 1,
+	DP_LANE_COUNT_2 = 2,
+	DP_LANE_COUNT_4 = 4
+};
+
 struct edid;
 
 bool kmstest_force_connector(int fd, drmModeConnector *connector,
Signature · 1 line
2.34.1
Reviewed-by on v1 1/14
#2 lore raw
Quoted 9 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kunal Joshi
Sent: Monday, August 26, 2024 1:36 AM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 01/14] lib/igt_kms: add enum for link rate and lane count

Quoted 3 lines

add enums for link rate, lane count

LGTM.

Quoted 40 lines
---
 lib/igt_kms.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
lib/igt_kms.h index 25ba50916..999921f9f renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +23 -1
@@ -258,6 +258,29 @@ enum intel_broadcast_rgb_mode {
 	BROADCAST_RGB_16_235
 };
 
+enum dp_link_rate {
+	DP_LINK_RATE_162000 = 162000,
+	DP_LINK_RATE_216000 = 216000,
+	DP_LINK_RATE_243000 = 243000,
+	DP_LINK_RATE_270000 = 270000,
+	DP_LINK_RATE_324000 = 324000,
+	DP_LINK_RATE_432000 = 432000,
+	DP_LINK_RATE_540000 = 540000,
+	DP_LINK_RATE_675000 = 675000,
+	DP_LINK_RATE_810000 = 810000,
+	DP_LINK_RATE_1000000 = 1000000,
+	DP_LINK_RATE_1350000 = 1350000,
+	DP_LINK_RATE_2000000 = 2000000
+};
+
+#define DP_MAX_LINK_RATE_COUNT 12
+
+enum dp_lane_count {
+	DP_LANE_COUNT_1 = 1,
+	DP_LANE_COUNT_2 = 2,
+	DP_LANE_COUNT_4 = 4
+};
+
 struct edid;
 
 bool kmstest_force_connector(int fd, drmModeConnector *connector,
--

2.34.1

#3 lore raw
In reply to Kunal Joshi
Quoted 19 lines · Kunal Joshi

add enums for link rate, lane count

---
 lib/igt_kms.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
lib/igt_kms.h +4 -0
index 25ba50916..999921f9f 100644
@@ -258,6 +258,29 @@ enum intel_broadcast_rgb_mode {
 	BROADCAST_RGB_16_235
 };
 
+enum dp_link_rate {
+	DP_LINK_RATE_162000 = 162000,
+	DP_LINK_RATE_216000 = 216000,
+	DP_LINK_RATE_243000 = 243000,

lib/igt_kms.h enum intel_broadcast_rgb_mode { · line 274

Quoted 10 lines
lib/igt_kms.h +10 -0
+	DP_LINK_RATE_270000 = 270000,
+	DP_LINK_RATE_324000 = 324000,
+	DP_LINK_RATE_432000 = 432000,
+	DP_LINK_RATE_540000 = 540000,
+	DP_LINK_RATE_675000 = 675000,
+	DP_LINK_RATE_810000 = 810000,
+	DP_LINK_RATE_1000000 = 1000000,
+	DP_LINK_RATE_1350000 = 1350000,
+	DP_LINK_RATE_2000000 = 2000000
+};

Imo, there is no point to define enums for the rates or lane counts.

lib/igt_kms.h enum intel_broadcast_rgb_mode { · line 276

Quoted 2 lines
lib/igt_kms.h +2 -0
+
+#define DP_MAX_LINK_RATE_COUNT 12

This is not used.

Quoted 13 lines
lib/igt_kms.h +7 -0
+
+enum dp_lane_count {
+	DP_LANE_COUNT_1 = 1,
+	DP_LANE_COUNT_2 = 2,
+	DP_LANE_COUNT_4 = 4
+};
+
 struct edid;
 
 bool kmstest_force_connector(int fd, drmModeConnector *connector,
Signature · 1 line
2.34.1
#4 lore raw

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 6:23 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 01/14] lib/igt_kms: add enum for link rate and lane count

Quoted 19 lines · Kunal Joshi

add enums for link rate, lane count

---
 lib/igt_kms.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
lib/igt_kms.h index 25ba50916..999921f9f renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +4 -0
@@ -258,6 +258,29 @@ enum intel_broadcast_rgb_mode {
 	BROADCAST_RGB_16_235
 };
 
+enum dp_link_rate {
+	DP_LINK_RATE_162000 = 162000,
+	DP_LINK_RATE_216000 = 216000,
+	DP_LINK_RATE_243000 = 243000,

lib/igt_kms.h enum intel_broadcast_rgb_mode { · line 274

Quoted 10 lines
lib/igt_kms.h +10 -0
+	DP_LINK_RATE_270000 = 270000,
+	DP_LINK_RATE_324000 = 324000,
+	DP_LINK_RATE_432000 = 432000,
+	DP_LINK_RATE_540000 = 540000,
+	DP_LINK_RATE_675000 = 675000,
+	DP_LINK_RATE_810000 = 810000,
+	DP_LINK_RATE_1000000 = 1000000,
+	DP_LINK_RATE_1350000 = 1350000,
+	DP_LINK_RATE_2000000 = 2000000
+};

Imo, there is no point to define enums for the rates or lane counts.
----------------------------------------------------------------------------------------------
Sure, will remove this.

lib/igt_kms.h enum intel_broadcast_rgb_mode { · line 276

Quoted 2 lines
lib/igt_kms.h +2 -0
+
+#define DP_MAX_LINK_RATE_COUNT 12

This is not used.
----------------------------------------------------------------------------------------------
This too.

Quoted 11 lines
lib/igt_kms.h +7 -1
+
+enum dp_lane_count {
+	DP_LANE_COUNT_1 = 1,
+	DP_LANE_COUNT_2 = 2,
+	DP_LANE_COUNT_4 = 4
+};
+
 struct edid;
 
 bool kmstest_force_connector(int fd, drmModeConnector *connector,
--
Quoted 2 lines

2.34.1

Thanks and Regards
Kunal Joshi

#5 lore raw

PATCH 2/14 lib/igt_kms: add helper to get current link rate/ lane count for connector

In reply to a message not in the archive

i915_dp_force_(lane_count/link_rate) debugfs files expoose current link rate/lane count for connector.add helper to get current link rate/ lane count for connector

---
 lib/igt_kms.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c +58 -0
index dd530dbab..4ef7f4d7f 100644
@@ -6705,3 +6705,61 @@ int get_num_scalers(igt_display_t *display, enum pipe pipe)
 
 	return num_scalers;
 }
+
+/**
+ * igt_get_dp_link_rate_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Link rate set for the output.
+ */
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_rate", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 6, "%d", &link_rate) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &link_rate) == 1);
+
+	return link_rate;
+}
+
+/**
+ * igt_get_dp_lane_count_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Lane count set for the output.
+ */
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_lane_count", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 2, "%d", &lane_count) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &lane_count) == 1);
+
+	return lane_count;
+}
lib/igt_kms.h +2 -0
index 999921f9f..9d42a2b35 100644
@@ -1247,5 +1247,7 @@ bool intel_pipe_output_combo_valid(igt_display_t *display);
 bool igt_check_output_is_dp_mst(igt_output_t *output);
 int igt_get_dp_mst_connector_id(igt_output_t *output);
 int get_num_scalers(igt_display_t *display, enum pipe pipe);
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output);
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#6 lore raw

RE: [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector

Quoted 10 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kunal Joshi
Sent: Monday, August 26, 2024 1:36 AM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector

i915_dp_force_(lane_count/link_rate) debugfs files expoose current link

Fix typo /expoose /Expose

Quoted 101 lines

rate/lane count for connector.add helper to get current link rate/ lane count for connector

---
 lib/igt_kms.c | 58
+++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c index dd530dbab..4ef7f4d7f renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +16 -0
@@ -6705,3 +6705,61 @@ int get_num_scalers(igt_display_t *display,
 enum pipe pipe)
 
 	return num_scalers;
 }
+
+/**
+ * igt_get_dp_link_rate_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Link rate set for the output.
+ */
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd,
+igt_output_t *output) {
+	char buf[512];
+	int dir, res;
+	int link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name,

O_RDONLY);

lib/igt_kms.c +1 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector

%s\n",

lib/igt_kms.c +2 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_rate", buf,

sizeof(buf));

lib/igt_kms.c +26 -0
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 6, "%d", &link_rate) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &link_rate) == 1);
+
+	return link_rate;
+}
+
+/**
+ * igt_get_dp_lane_count_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Lane count set for the output.
+ */
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd,
+igt_output_t *output) {
+	char buf[512];
+	int dir, res;
+	int lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name,

O_RDONLY);

lib/igt_kms.c +1 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector

%s\n",

lib/igt_kms.c +2 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_lane_count", buf,

sizeof(buf));

lib/igt_kms.c +5 -0
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 2, "%d", &lane_count) ==

1);

lib/igt_kms.c +2 -0
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &lane_count) ==

1);

lib/igt_kms.c +3 -0
+
+	return lane_count;
+}
lib/igt_kms.h index 999921f9f..9d42a2b35 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +0 -0
@@ -1247,5 +1247,7 @@ bool

intel_pipe_output_combo_valid(igt_display_t *display); bool igt_check_output_is_dp_mst(igt_output_t *output); int igt_get_dp_mst_connector_id(igt_output_t *output); int get_num_scalers(igt_display_t *display, enum pipe pipe);

lib/igt_kms.h +3 -1
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd,
+igt_output_t *output); enum dp_lane_count
+igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
--

2.34.1

#7 lore raw

Re: [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector

In reply to Kunal Joshi
Quoted 23 lines · Kunal Joshi

i915_dp_force_(lane_count/link_rate) debugfs files expoose current link rate/lane count for connector.add helper to get current link rate/ lane count for connector

---
 lib/igt_kms.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c +5 -0
index dd530dbab..4ef7f4d7f 100644
@@ -6705,3 +6705,61 @@ int get_num_scalers(igt_display_t *display, enum pipe pipe)
 
 	return num_scalers;
 }
+
+/**
+ * igt_get_dp_link_rate_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6722

Quoted 10 lines
lib/igt_kms.c +10 -0
+ *
+ * Returns: Link rate set for the output.
+ */
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int link_rate;
+
+	igt_require_f(output->name, "Invalid output");

It's strange to check this in these library functions. I'd think the caller should make sure already that it's a valid output, how can it become invalid in the test this patchset adds?

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6728

Quoted 6 lines
lib/igt_kms.c +6 -0
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_rate", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);

res == 0 is also valid.

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6733

Quoted 5 lines
lib/igt_kms.c +5 -0
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 6, "%d", &link_rate) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &link_rate) == 1);

I suppose this should return the rate used for an active output. It should be the one with the '*' marker, regardless if the rate is getting selected automatically or forced. In case it's forced the selected rate could be different than the target with the '[]' markers (if the sink doesn't support the target rate). So I think this should return the one marked with '*' or an error if such is not found (when the output is disabled).

Quoted 19 lines
lib/igt_kms.c +19 -0
+
+	return link_rate;
+}
+
+/**
+ * igt_get_dp_lane_count_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Lane count set for the output.
+ */
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6762

Quoted 10 lines
lib/igt_kms.c +10 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_lane_count", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 2, "%d", &lane_count) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &lane_count) == 1);

The same as above apply in this function too.

Quoted 18 lines
lib/igt_kms.c +3 -0
+
+	return lane_count;
+}
lib/igt_kms.h +2 -0
index 999921f9f..9d42a2b35 100644
@@ -1247,5 +1247,7 @@ bool intel_pipe_output_combo_valid(igt_display_t *display);
 bool igt_check_output_is_dp_mst(igt_output_t *output);
 int igt_get_dp_mst_connector_id(igt_output_t *output);
 int get_num_scalers(igt_display_t *display, enum pipe pipe);
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output);
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#8 lore raw

RE: [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 6:39 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 02/14] lib/igt_kms: add helper to get current link rate/ lane count for connector

Quoted 25 lines · Kunal Joshi

i915_dp_force_(lane_count/link_rate) debugfs files expoose current link rate/lane count for connector.add helper to get current link rate/ lane count for connector

---
 lib/igt_kms.c | 58 
+++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c index dd530dbab..4ef7f4d7f renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +5 -0
@@ -6705,3 +6705,61 @@ int get_num_scalers(igt_display_t *display, 
 enum pipe pipe)
 
 	return num_scalers;
 }
+
+/**
+ * igt_get_dp_link_rate_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output

lib/igt_kms.c int get_num_scalers(igt_display_t *display, · line 6722

Quoted 10 lines
lib/igt_kms.c +10 -0
+ *
+ * Returns: Link rate set for the output.
+ */
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, 
+igt_output_t *output) {
+	char buf[512];
+	int dir, res;
+	int link_rate;
+
+	igt_require_f(output->name, "Invalid output");

It's strange to check this in these library functions. I'd think the caller should make sure already that it's a valid output, how can it become invalid in the test this patchset adds?
----------------------------------------------------------------------------------------------
Was extra precautious that some using this API's may pass NULL in case,
but will remove this check in the next revision

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6728

Quoted 6 lines
lib/igt_kms.c +6 -0
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_rate", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);

res == 0 is also valid.
----------------------------------------------------------------------------------------------
Thanks for the catch, will fix it in next revision.

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6733

Quoted 5 lines
lib/igt_kms.c +5 -0
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 6, "%d", &link_rate) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &link_rate) == 1);

I suppose this should return the rate used for an active output. It should be the one with the '*' marker, regardless if the rate is getting selected automatically or forced. In case it's forced the selected rate could be different than the target with the '[]' markers (if the sink doesn't support the target rate). So I think this should return the one marked with '*' or an error if such is not found (when the output is disabled).
----------------------------------------------------------------------------------------------
Ok thanks for clearing, my understanding was a bit different.
Will modify as suggested in next revision.

Quoted 19 lines
lib/igt_kms.c +19 -0
+
+	return link_rate;
+}
+
+/**
+ * igt_get_dp_lane_count_set_for_output:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Lane count set for the output.
+ */
+enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, 
+igt_output_t *output) {
+	char buf[512];
+	int dir, res;
+	int lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);

lib/igt_kms.c int get_num_scalers(igt_display_t *display, enum pipe pipe) · line 6762

Quoted 10 lines
lib/igt_kms.c +10 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_lane_count", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	if (strstr(buf, "[auto]"))
+		igt_assert(sscanf(strstr(buf, "*") - 2, "%d", &lane_count) == 1);
+	else
+		igt_assert(sscanf(strstr(buf, "[") + 1, "%d", &lane_count) == 1);

The same as above apply in this function too.
----------------------------------------------------------------------------------------------
Sure

Thanks and Regards
Kunal Joshi

Quoted 20 lines
lib/igt_kms.c +3 -0
+
+	return lane_count;
+}
lib/igt_kms.h index 999921f9f..9d42a2b35 renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +0 -0
@@ -1247,5 +1247,7 @@ bool intel_pipe_output_combo_valid(igt_display_t 
 *display);  bool igt_check_output_is_dp_mst(igt_output_t *output);  

int igt_get_dp_mst_connector_id(igt_output_t *output); int get_num_scalers(igt_display_t *display, enum pipe pipe);

lib/igt_kms.h +4 -1
+enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, 
+igt_output_t *output); enum dp_lane_count 
+igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t 
+*output);
 
 #endif /* __IGT_KMS_H__ */
--

2.34.1

#9 lore raw

PATCH 3/14 lib/igt_kms: add function to get max link rate/lane count

In reply to a message not in the archive

i915_dp_max_(lane_count/link_rate) debugfs files expose max link rate/lane count for connector.add function to get max link rate/lane lane count for connector

---
 lib/igt_kms.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c +58 -0
index 4ef7f4d7f..21ea8550c 100644
@@ -6763,3 +6763,61 @@ enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t
 
 	return lane_count;
 }
+
+/**
+ * igt_get_dp_max_link_rate:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max link rate supported by the sink.
+ *
+ * Returns: Max link rate supported by the sink.
+ */
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int max_link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_DIRECTORY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_link_rate",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require_f(res > 0, "Couldn't read i915_dp_max_link_rate");
+
+	igt_assert(sscanf(buf, "%d", &max_link_rate) == 1);
+
+	return max_link_rate;
+}
+
+/**
+ * igt_get_dp_max_lane_count:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max lane count supported by the sink.
+ *
+ * Returns: Max lane count supported by the sink.
+ */
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int max_lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_lane_count",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	igt_assert(sscanf(buf, "%d", &max_lane_count) == 1);
+
+	return max_lane_count;
+}
lib/igt_kms.h +2 -0
index 9d42a2b35..1d3226c5c 100644
@@ -1249,5 +1249,7 @@ int igt_get_dp_mst_connector_id(igt_output_t *output);
 int get_num_scalers(igt_display_t *display, enum pipe pipe);
 enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output);
 enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output);
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#10 lore raw

RE: [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count

Quoted 26 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kunal Joshi
Sent: Monday, August 26, 2024 1:36 AM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count

i915_dp_max_(lane_count/link_rate) debugfs files expose max link rate/lane count for connector.add function to get max link rate/lane lane count for connector

---
 lib/igt_kms.c | 58
+++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c +0 -0
@@ -6763,3 +6763,61 @@ enum dp_lane_count

igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t

lib/igt_kms.c enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t · line 6766

Quoted 3 lines
lib/igt_kms.c +1 -0
 	return lane_count;
 }
+

Is it possible to reuse the function igt_get_dp_link_rate_set_for_output & igt_get_dp_lane_count_set_for_output To get max rate using some logic.

Quoted 80 lines
lib/igt_kms.c +17 -0
+/**
+ * igt_get_dp_max_link_rate:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max link rate supported by the sink.
+ *
+ * Returns: Max link rate supported by the sink.
+ */
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t
+*output) {
+	char buf[512];
+	int dir, res;
+	int max_link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name,

O_DIRECTORY);

lib/igt_kms.c +1 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector

%s\n",

lib/igt_kms.c +3 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_link_rate",
+								  buf,

sizeof(buf));

lib/igt_kms.c +18 -0
+	close(dir);
+	igt_require_f(res > 0, "Couldn't read i915_dp_max_link_rate");
+
+	igt_assert(sscanf(buf, "%d", &max_link_rate) == 1);
+
+	return max_link_rate;
+}
+
+/**
+ * igt_get_dp_max_lane_count:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max lane count supported by the sink.
+ *
+ * Returns: Max lane count supported by the sink.
+ */
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd,

igt_output_t

lib/igt_kms.c +7 -0
+*output) {
+	char buf[512];
+	int dir, res;
+	int max_lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name,

O_RDONLY);

lib/igt_kms.c +1 -0
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector

%s\n",

lib/igt_kms.c +3 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_lane_count",
+								  buf,

sizeof(buf));

lib/igt_kms.c +7 -0
+	close(dir);
+	igt_require(res > 0);
+
+	igt_assert(sscanf(buf, "%d", &max_lane_count) == 1);
+
+	return max_lane_count;
+}
lib/igt_kms.h index 9d42a2b35..1d3226c5c renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +0 -0
@@ -1249,5 +1249,7 @@ int igt_get_dp_mst_connector_id(igt_output_t
 *output);  int get_num_scalers(igt_display_t *display, enum pipe pipe);
 enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd,

igt_output_t *output); enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);

lib/igt_kms.h +3 -1
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t
+*output); enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd,
+igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
--

2.34.1

#11 lore raw

Re: [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count

In reply to Kunal Joshi
Quoted 37 lines · Kunal Joshi

i915_dp_max_(lane_count/link_rate) debugfs files expose max link rate/lane count for connector.add function to get max link rate/lane lane count for connector

---
 lib/igt_kms.c | 58 +++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c +19 -0
index 4ef7f4d7f..21ea8550c 100644
@@ -6763,3 +6763,61 @@ enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t
 
 	return lane_count;
 }
+
+/**
+ * igt_get_dp_max_link_rate:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max link rate supported by the sink.
+ *
+ * Returns: Max link rate supported by the sink.
+ */
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int max_link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_DIRECTORY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",

lib/igt_kms.c enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t · line 6794

Quoted 10 lines
lib/igt_kms.c +10 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_link_rate",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require_f(res > 0, "Couldn't read i915_dp_max_link_rate");
+
+	igt_assert(sscanf(buf, "%d", &max_link_rate) == 1);
+
+	return max_link_rate;
+}

The comments from the previous patch apply here too. This makes me wonder if it'd make more sense to add all these DP link training debugfs entries from one patch.

Quoted 44 lines
lib/igt_kms.c +29 -0
+
+/**
+ * igt_get_dp_max_lane_count:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max lane count supported by the sink.
+ *
+ * Returns: Max lane count supported by the sink.
+ */
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output)
+{
+	char buf[512];
+	int dir, res;
+	int max_lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_lane_count",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	igt_assert(sscanf(buf, "%d", &max_lane_count) == 1);
+
+	return max_lane_count;
+}
lib/igt_kms.h +2 -0
index 9d42a2b35..1d3226c5c 100644
@@ -1249,5 +1249,7 @@ int igt_get_dp_mst_connector_id(igt_output_t *output);
 int get_num_scalers(igt_display_t *display, enum pipe pipe);
 enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output);
 enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output);
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#12 lore raw

RE: [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 6:42 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 03/14] lib/igt_kms: add function to get max link rate/lane count

Quoted 39 lines · Kunal Joshi

i915_dp_max_(lane_count/link_rate) debugfs files expose max link rate/lane count for connector.add function to get max link rate/lane lane count for connector

---
 lib/igt_kms.c | 58 
+++++++++++++++++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 60 insertions(+)
lib/igt_kms.c index 4ef7f4d7f..21ea8550c renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +0 -0
@@ -6763,3 +6763,61 @@ enum dp_lane_count 

igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t

lib/igt_kms.c +19 -0
 	return lane_count;
 }
+
+/**
+ * igt_get_dp_max_link_rate:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max link rate supported by the sink.
+ *
+ * Returns: Max link rate supported by the sink.
+ */
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t 
+*output) {
+	char buf[512];
+	int dir, res;
+	int max_link_rate;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_DIRECTORY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",

lib/igt_kms.c enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t · line 6794

Quoted 10 lines
lib/igt_kms.c +10 -0
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_link_rate",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require_f(res > 0, "Couldn't read i915_dp_max_link_rate");
+
+	igt_assert(sscanf(buf, "%d", &max_link_rate) == 1);
+
+	return max_link_rate;
+}

The comments from the previous patch apply here too. This makes me wonder if it'd make more sense to add all these DP link training debugfs entries from one patch.
----------------------------------------------------------------------------------------------
Ok sure let me combine all in 1

Thanks and Regards
Kunal Joshi

Quoted 47 lines
lib/igt_kms.c +29 -0
+
+/**
+ * igt_get_dp_max_lane_count:
+ * @drm_fd: A drm file descriptor
+ * @output: The output to query
+ *
+ * Get the max lane count supported by the sink.
+ *
+ * Returns: Max lane count supported by the sink.
+ */
+enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t 
+*output) {
+	char buf[512];
+	int dir, res;
+	int max_lane_count;
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+				 igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_max_lane_count",
+								  buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+
+	igt_assert(sscanf(buf, "%d", &max_lane_count) == 1);
+
+	return max_lane_count;
+}
lib/igt_kms.h index 9d42a2b35..1d3226c5c renamed from lib/igt_kms.h +0 -0

100644

lib/igt_kms.h +0 -0
@@ -1249,5 +1249,7 @@ int igt_get_dp_mst_connector_id(igt_output_t 
 *output);  int get_num_scalers(igt_display_t *display, enum pipe 

pipe); enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *output); enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);

lib/igt_kms.h +3 -1
+enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t 
+*output); enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, 
+igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
--

2.34.1

#13 lore raw

PATCH 4/14 lib/igt_kms: add function to force link retrain

In reply to a message not in the archive

i915_dp_force_link_retrain debugfs allow forcing retraing on the connector. add a helper to write given retraining count to the same.

---
 lib/igt_kms.c | 22 ++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 23 insertions(+)
lib/igt_kms.c +22 -0
index 21ea8550c..553a08f2f 100644
@@ -6821,3 +6821,25 @@ enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output)
 
 	return max_lane_count;
 }
+
+/**
+ * igt_force_link_retrain:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ * @retrain_count: number of retraining required
+ *
+ * Force link retrain on the output.
+ */
+void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count)
+{
+	int dir;
+	char value[2];
+
+	snprintf(value, sizeof(value), "%d", retrain_count);
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+			       igt_output_name(output));
+	igt_sysfs_write(dir, "i915_dp_force_link_retrain", value, sizeof(value));
+	close(dir);
+}
lib/igt_kms.h +1 -0
index 1d3226c5c..9ba8c6394 100644
@@ -1251,5 +1251,6 @@ enum dp_link_rate igt_get_dp_link_rate_set_for_output(int drm_fd, igt_output_t *
 enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t *output);
 enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output);
 enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
+void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#14 lore raw

PATCH 5/14 lib/igt_kms: add function to force link training failure

In reply to a message not in the archive

i915_dp_force_link_training_failure debugfs
file is used to force link training failure.
add a function to force link training failure.

---
 lib/igt_kms.c | 26 ++++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 27 insertions(+)
lib/igt_kms.c +26 -0
index 553a08f2f..683989e84 100644
@@ -6843,3 +6843,29 @@ void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count)
 	igt_sysfs_write(dir, "i915_dp_force_link_retrain", value, sizeof(value));
 	close(dir);
 }
+
+/**
+ * igt_force_lt_failure:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ * @failure_count: 1 for same link param and
+ *                2 for reduced link params
+ *
+ * Force link training failure on the output.
+ * @failure_count: 1 for retraining with same link params
+ * 				   2 for retraining with reduced link params
+ */
+void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count)
+{
+	int dir;
+	char value[2];
+
+	snprintf(value, sizeof(value), "%d", failure_count);
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+			       igt_output_name(output));
+	igt_sysfs_write(dir, "i915_dp_force_link_training_failure",
+			     value, sizeof(value));
+	close(dir);
+}
lib/igt_kms.h +1 -0
index 9ba8c6394..57829416a 100644
@@ -1252,5 +1252,6 @@ enum dp_lane_count igt_get_dp_lane_count_set_for_output(int drm_fd, igt_output_t
 enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output);
 enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
 void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count);
+void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#15 lore raw

PATCH 6/14 lib/igt_kms: add function to check if retrain disabled

In reply to a message not in the archive

add helper to check if retraining is disabled, retraining will be disable if we are at the lowest link parameters or the lowest mode supported on a panel

---
 lib/igt_kms.c | 24 ++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 25 insertions(+)
lib/igt_kms.c +24 -0
index 683989e84..2720095d4 100644
@@ -6869,3 +6869,27 @@ void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count)
 			     value, sizeof(value));
 	close(dir);
 }
+
+/**
+ * igt_get_dp_link_retrain_disabled:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: True if link retrain disabled, false otherwise
+ */
+bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output)
+{
+	int dir, res;
+	char buf[512];
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+			       igt_output_name(output));
+	res = igt_debugfs_simple_read(dir,
+				      "i915_dp_link_retrain_disabled",
+				      buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+	return strstr(buf, "yes");
+}
lib/igt_kms.h +1 -0
index 57829416a..2d69d794a 100644
@@ -1253,5 +1253,6 @@ enum dp_link_rate igt_get_dp_max_link_rate(int drm_fd, igt_output_t *output);
 enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
 void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count);
 void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count);
+bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#16 lore raw

PATCH 7/14 lib/igt_kms: add function to check force link training failure support

In reply to a message not in the archive

add helper to check if platform support forcing
link training failures

---
 lib/igt_kms.c | 25 +++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 26 insertions(+)
lib/igt_kms.c +25 -0
index 2720095d4..4ab47e2e9 100644
@@ -6893,3 +6893,28 @@ bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output)
 	igt_require(res > 0);
 	return strstr(buf, "yes");
 }
+
+/**
+ * Checks if the force link training failure debugfs
+ * is available for a specific output.
+ *
+ * @drmfd: file descriptor of the DRM device.
+ * @output: output to check.
+ * Returns:
+ *  true if the debugfs is available, false otherwise.
+ */
+bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output)
+{
+	int debugfs_fd, ret;
+	char buf[512];
+
+	igt_assert_f(output->name, "Invalid output\n");
+	debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name, O_RDONLY);
+	if (debugfs_fd < 0)
+		return false;
+	ret = igt_debugfs_simple_read(debugfs_fd,
+				      "i915_dp_force_link_training_failure",
+				      buf, sizeof(buf));
+	close(debugfs_fd);
+	return ret >= 0;
+}
lib/igt_kms.h +1 -0
index 2d69d794a..5ae324f6f 100644
@@ -1254,5 +1254,6 @@ enum dp_lane_count igt_get_dp_max_lane_count(int drm_fd, igt_output_t *output);
 void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count);
 void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count);
 bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
+bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
Reviewed-by on v1 7/14
#17 lore raw

RE: [PATCH i-g-t 07/14] lib/igt_kms: add function to check force link training failure support

Quoted 10 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kunal Joshi
Sent: Monday, August 26, 2024 1:36 AM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>
Subject: [PATCH i-g-t 07/14] lib/igt_kms: add function to check force link training failure support

Quoted 3 lines

add helper to check if platform support forcing link training failures

LGTM.

Quoted 52 lines
---
 lib/igt_kms.c | 25 +++++++++++++++++++++++++  lib/igt_kms.h |  1 +
 2 files changed, 26 insertions(+)
lib/igt_kms.c +17 -0
@@ -6893,3 +6893,28 @@ bool igt_get_dp_link_retrain_disabled(int drm_fd,
 igt_output_t *output)
 	igt_require(res > 0);
 	return strstr(buf, "yes");
 }
+
+/**
+ * Checks if the force link training failure debugfs
+ * is available for a specific output.
+ *
+ * @drmfd: file descriptor of the DRM device.
+ * @output: output to check.
+ * Returns:
+ *  true if the debugfs is available, false otherwise.
+ */
+bool igt_has_force_link_training_failure_debugfs(int drmfd,
+igt_output_t *output) {
+	int debugfs_fd, ret;
+	char buf[512];
+
+	igt_assert_f(output->name, "Invalid output\n");
+	debugfs_fd = igt_debugfs_connector_dir(drmfd, output->name,

O_RDONLY);

lib/igt_kms.c +8 -0
+	if (debugfs_fd < 0)
+		return false;
+	ret = igt_debugfs_simple_read(debugfs_fd,
+				      "i915_dp_force_link_training_failure",
+				      buf, sizeof(buf));
+	close(debugfs_fd);
+	return ret >= 0;
+}
lib/igt_kms.h +0 -0
@@ -1254,5 +1254,6 @@ enum dp_lane_count igt_get_dp_max_lane_count(int
 drm_fd, igt_output_t *output);  void igt_force_link_retrain(int drm_fd,
 igt_output_t *output, int retrain_count);  void igt_force_lt_failure(int drm_fd,

igt_output_t *output, int failure_count); bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);

lib/igt_kms.h +2 -1
+bool igt_has_force_link_training_failure_debugfs(int drmfd,
+igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
--

2.34.1

#18 lore raw

PATCH 8/14 lib/igt_kms: add helper to get pending lt failures

In reply to a message not in the archive

i915_dp_force_link_training_failure can be written to written to trigger link trainig failures on retrain. add helper to get pending link training failure count.

---
 lib/igt_kms.c | 23 +++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 24 insertions(+)
lib/igt_kms.c +23 -0
index 4ab47e2e9..727fa83f1 100644
@@ -6918,3 +6918,26 @@ bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output
 	close(debugfs_fd);
 	return ret >= 0;
 }
+
+/**
+ * igt_get_dp_pending_lt_failures:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Returns: Number of pending link training failures.
+ */
+int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output)
+{
+	int dir, res, ret;
+	char buf[512];
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+			       igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_training_failure", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+	sscanf(buf, "%d", &ret);
+	return ret;
+}
lib/igt_kms.h +1 -0
index 5ae324f6f..07dbcb263 100644
@@ -1255,5 +1255,6 @@ void igt_force_link_retrain(int drm_fd, igt_output_t *output, int retrain_count)
 void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count);
 bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
 bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output);
+int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#19 lore raw

PATCH 9/14 lib/igt_kms: add helper to get pending retrain count

In reply to a message not in the archive

i915_dp_force_link_retrain can be written to trigger link retraining. add helper to get pending retrainig failure count.

---
 lib/igt_kms.c | 23 +++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 24 insertions(+)
lib/igt_kms.c +23 -0
index 727fa83f1..91f75243d 100644
@@ -6941,3 +6941,26 @@ int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output)
 	sscanf(buf, "%d", &ret);
 	return ret;
 }
+
+/**
+ * igt_dp_pending_retrain:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ * 
+ * Returns: Number of pending link retrains.
+ */
+int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output)
+{
+	int dir, res, ret;
+	char buf[512];
+
+	igt_require_f(output->name, "Invalid output");
+	dir = igt_debugfs_connector_dir(drm_fd, output->name, O_RDONLY);
+	igt_assert_f(dir >= 0, "Failed to open debugfs dir for connector %s\n",
+			       igt_output_name(output));
+	res = igt_debugfs_simple_read(dir, "i915_dp_force_link_retrain", buf, sizeof(buf));
+	close(dir);
+	igt_require(res > 0);
+	sscanf(buf, "%d", &ret);
+	return ret;
+}
lib/igt_kms.h +1 -0
index 07dbcb263..640ec4e09 100644
@@ -1256,5 +1256,6 @@ void igt_force_lt_failure(int drm_fd, igt_output_t *output, int failure_count);
 bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
 bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output);
 int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output);
+int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#20 lore raw

PATCH 10/14 lib/igt_kms: add helper to set connector link status

In reply to a message not in the archive

add helper to set connector's link status property

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 38 insertions(+)
lib/igt_kms.c +36 -0
index 91f75243d..e0533f6ae 100644
@@ -2213,6 +2213,42 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
 					       dpms, mode) == 0);
 }
 
+/**
+ * kmstest_set_connector_link_status
+ * @drm_fd: drm file descriptor
+ * @connector: libdrm connector
+ * @link_status: DRM link status value
+ * 
+ * This function sets the link status of @connector to @link_status.
+ */
+void kmstest_set_connector_link_status(int drm_fd, drmModeConnector *connector,
+				       int link_status)
+{
+	int i, link_status_prop = 0;
+	bool found_it = false;
+
+	for (i = 0; i < connector->count_props; i++) {
+		struct drm_mode_get_property prop = {
+			.prop_id = connector->props[i],
+		};
+
+		if (drmIoctl(drm_fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
+			continue;
+
+		if (strcmp(prop.name, "link-status"))
+			continue;
+
+		link_status_prop = prop.prop_id;
+		found_it = true;
+		break;
+	}
+	igt_assert_f(found_it, "LINK_STATUS property not found on %d\n",
+		     connector->connector_id);
+
+	igt_assert(drmModeConnectorSetProperty(drm_fd, connector->connector_id,
+					       link_status_prop, link_status) == 0);
+}
+
 /**
  * kmstest_get_property:
  * @drm_fd: drm file descriptor
lib/igt_kms.h +2 -0
index 640ec4e09..3d7842b36 100644
@@ -301,6 +301,8 @@ bool kmstest_probe_connector_config(int drm_fd, uint32_t connector_id,
 void kmstest_free_connector_config(struct kmstest_connector_config *config);
 
 void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode);
+void kmstest_set_connector_link_status(int drm_fd, drmModeConnector *connector,
+				       int link_status);
 bool kmstest_get_property(int drm_fd, uint32_t object_id, uint32_t object_type,
 			  const char *name, uint32_t *prop_id, uint64_t *value,
 			  drmModePropertyPtr *prop);
Signature · 1 line
2.34.1
#21 lore raw

Re: [PATCH i-g-t 10/14] lib/igt_kms: add helper to set connector link status

Quoted 18 lines · Kunal Joshi

add helper to set connector's link status property

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 38 insertions(+)
lib/igt_kms.c +2 -0
index 91f75243d..e0533f6ae 100644
@@ -2213,6 +2213,42 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
 					       dpms, mode) == 0);
 }
 
+/**
+ * kmstest_set_connector_link_status

lib/igt_kms.c void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode) · line 2227

Quoted 10 lines
lib/igt_kms.c +10 -0
+ * @drm_fd: drm file descriptor
+ * @connector: libdrm connector
+ * @link_status: DRM link status value
+ * 
+ * This function sets the link status of @connector to @link_status.
+ */
+void kmstest_set_connector_link_status(int drm_fd, drmModeConnector *connector,
+				       int link_status)
+{
+	int i, link_status_prop = 0;

The property ID's type is uint32_t.

lib/igt_kms.c void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode) · line 2238

Quoted 11 lines
lib/igt_kms.c +11 -0
+	bool found_it = false;
+
+	for (i = 0; i < connector->count_props; i++) {
+		struct drm_mode_get_property prop = {
+			.prop_id = connector->props[i],
+		};
+
+		if (drmIoctl(drm_fd, DRM_IOCTL_MODE_GETPROPERTY, &prop))
+			continue;
+
+		if (strcmp(prop.name, "link-status"))

Maybe better looking up the name from igt_connector_prop_names[]. Looks like the property ID is also already cached in igt_output_t::props[IGT_IGT_CONNECTOR_LINK_STATUS], but looking it up again here matches the related DPMS helper, so for now it's ok to do the same.

Quoted 32 lines
lib/igt_kms.c +13 -0
+			continue;
+
+		link_status_prop = prop.prop_id;
+		found_it = true;
+		break;
+	}
+	igt_assert_f(found_it, "LINK_STATUS property not found on %d\n",
+		     connector->connector_id);
+
+	igt_assert(drmModeConnectorSetProperty(drm_fd, connector->connector_id,
+					       link_status_prop, link_status) == 0);
+}
+
 /**
  * kmstest_get_property:
  * @drm_fd: drm file descriptor
lib/igt_kms.h +2 -0
index 640ec4e09..3d7842b36 100644
@@ -301,6 +301,8 @@ bool kmstest_probe_connector_config(int drm_fd, uint32_t connector_id,
 void kmstest_free_connector_config(struct kmstest_connector_config *config);
 
 void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode);
+void kmstest_set_connector_link_status(int drm_fd, drmModeConnector *connector,
+				       int link_status);
 bool kmstest_get_property(int drm_fd, uint32_t object_id, uint32_t object_type,
 			  const char *name, uint32_t *prop_id, uint64_t *value,
 			  drmModePropertyPtr *prop);
Signature · 1 line
2.34.1
#22 lore raw

RE: [PATCH i-g-t 10/14] lib/igt_kms: add helper to set connector link status

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 7:26 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 10/14] lib/igt_kms: add helper to set connector link status

Quoted 18 lines · Kunal Joshi

add helper to set connector's link status property

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  2 ++
 2 files changed, 38 insertions(+)
lib/igt_kms.c index 91f75243d..e0533f6ae renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +2 -0
@@ -2213,6 +2213,42 @@ void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode)
 					       dpms, mode) == 0);
 }
 
+/**
+ * kmstest_set_connector_link_status

lib/igt_kms.c void kmstest_set_connector_dpms(int fd, drmModeConnector *connector, int mode) · line 2227

Quoted 10 lines
lib/igt_kms.c +10 -0
+ * @drm_fd: drm file descriptor
+ * @connector: libdrm connector
+ * @link_status: DRM link status value
+ *
+ * This function sets the link status of @connector to @link_status.
+ */
+void kmstest_set_connector_link_status(int drm_fd, drmModeConnector *connector,
+				       int link_status)
+{
+	int i, link_status_prop = 0;

The property ID's type is uint32_t.[Joshi, Kunal1

#23 lore raw

PATCH 11/14 lib/igt_kms: add function to reset link params

In reply to a message not in the archive

Writing auto to i915_dp_force_(link_rate/lane_count) and retraing afterwards sets max link param's supported by sink.Reset link rate and lane count to auto, also installs exit handler to set link rate and lane count to auto on exit

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 37 insertions(+)
lib/igt_kms.c +36 -0
index e0533f6ae..b7511ccfc 100644
@@ -7000,3 +7000,39 @@ int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output)
 	sscanf(buf, "%d", &ret);
 	return ret;
 }
+
+/**
+ * igt_reset_link_params:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Reset link rate and lane count to auto, also installs exit handler
+ * to set link rate and lane count to auto on exit
+ */
+void igt_reset_link_params(int drm_fd, igt_output_t *output)
+{
+	bool valid;
+	drmModeConnector *temp;
+
+	igt_require_f(output->name, "Invalid output");
+	valid = true;
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_link_rate",
+						    "auto", "auto");
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_lane_count",
+						    "auto", "auto");
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_link_retrain",
+						    "1", "1");
+	igt_assert_f(valid, "Unable to set attr or install exit handler\n");
+	dump_connector_attrs();
+	igt_install_exit_handler(reset_connectors_at_exit);
+
+	/*
+	 * To allow callers to always use GetConnectorCurrent we need to force a
+	 * redetection here.
+	 */
+	temp = drmModeGetConnector(drm_fd, output->config.connector->connector_id);
+	drmModeFreeConnector(temp);
+}
lib/igt_kms.h +1 -0
index 3d7842b36..847609379 100644
@@ -1259,5 +1259,6 @@ bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
 bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output);
 int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output);
 int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output);
+void igt_reset_link_params(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#24 lore raw

Re: [PATCH i-g-t 11/14] lib/igt_kms: add function to reset link params

Quoted 29 lines · Kunal Joshi

Writing auto to i915_dp_force_(link_rate/lane_count) and retraing afterwards sets max link param's supported by sink.Reset link rate and lane count to auto, also installs exit handler to set link rate and lane count to auto on exit

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 37 insertions(+)
lib/igt_kms.c +12 -0
index e0533f6ae..b7511ccfc 100644
@@ -7000,3 +7000,39 @@ int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output)
 	sscanf(buf, "%d", &ret);
 	return ret;
 }
+
+/**
+ * igt_reset_link_params:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Reset link rate and lane count to auto, also installs exit handler
+ * to set link rate and lane count to auto on exit
+ */
+void igt_reset_link_params(int drm_fd, igt_output_t *output)
+{
+	bool valid;

lib/igt_kms.c int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output) · line 7024

Quoted 10 lines
lib/igt_kms.c +10 -0
+	drmModeConnector *temp;
+
+	igt_require_f(output->name, "Invalid output");
+	valid = true;
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_link_rate",
+						    "auto", "auto");
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_lane_count",
+						    "auto", "auto");

Couldn't the above use the corresponding helpers added? I don't see those used elsewhere.

lib/igt_kms.c int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output) · line 7027

Quoted 3 lines
lib/igt_kms.c +3 -0
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_link_retrain",
+						    "1", "1");

Not sure if this is needed, if the link params are reset before a modeset. The latter does a link training anyway if needed.

Quoted 25 lines
lib/igt_kms.c +11 -0
+	igt_assert_f(valid, "Unable to set attr or install exit handler\n");
+	dump_connector_attrs();
+	igt_install_exit_handler(reset_connectors_at_exit);
+
+	/*
+	 * To allow callers to always use GetConnectorCurrent we need to force a
+	 * redetection here.
+	 */
+	temp = drmModeGetConnector(drm_fd, output->config.connector->connector_id);
+	drmModeFreeConnector(temp);
+}
lib/igt_kms.h +1 -0
index 3d7842b36..847609379 100644
@@ -1259,5 +1259,6 @@ bool igt_get_dp_link_retrain_disabled(int drm_fd, igt_output_t *output);
 bool igt_has_force_link_training_failure_debugfs(int drmfd, igt_output_t *output);
 int igt_get_dp_pending_lt_failures(int drm_fd, igt_output_t *output);
 int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output);
+void igt_reset_link_params(int drm_fd, igt_output_t *output);
 
 #endif /* __IGT_KMS_H__ */
Signature · 1 line
2.34.1
#25 lore raw

RE: [PATCH i-g-t 11/14] lib/igt_kms: add function to reset link params

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 7:56 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 11/14] lib/igt_kms: add function to reset link params

Quoted 27 lines · Kunal Joshi

Writing auto to i915_dp_force_(link_rate/lane_count) and retraing afterwards sets max link param's supported by sink.Reset link rate and lane count to auto, also installs exit handler to set link rate and lane count to auto on exit

---
 lib/igt_kms.c | 36 ++++++++++++++++++++++++++++++++++++
 lib/igt_kms.h |  1 +
 2 files changed, 37 insertions(+)
lib/igt_kms.c index e0533f6ae..b7511ccfc renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c +10 -0
@@ -7000,3 +7000,39 @@ int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output)
 	sscanf(buf, "%d", &ret);
 	return ret;
 }
+
+/**
+ * igt_reset_link_params:
+ * @drm_fd: A drm file descriptor
+ * @output: Target output
+ *
+ * Reset link rate and lane count to auto, also installs exit handler
+ * to set link rate and lane count to auto on exit  */ void 
+igt_reset_link_params(int drm_fd, igt_output_t *output) {
+	bool valid;

lib/igt_kms.c int igt_get_dp_pending_retrain(int drm_fd, igt_output_t *output) · line 7022

Quoted 10 lines
lib/igt_kms.c +10 -0
+	drmModeConnector *temp;
+
+	igt_require_f(output->name, "Invalid output");
+	valid = true;
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_link_rate",
+						    "auto", "auto");
+	valid = valid && connector_attr_set_debugfs(drm_fd, output->config.connector,
+						    "i915_dp_force_lane_count",
+						    "auto", "auto");

Couldn't the above use the corresponding helpers added? I don't see those used elsewhere.[Joshi, Kunal1

#26 lore raw

PATCH 12/14 lib/igt_kms: allow set and reset value to be same

In reply to a message not in the archive

allow set and reset value to be same, let the caller handle this scenario instead.

example scenario where this is required. i915_dp_force_link_rate should be auto before starting test should be auto at exit

---
 lib/igt_kms.c | 3 ---
 1 file changed, 3 deletions(-)
lib/igt_kms.c +0 -3
index b7511ccfc..5427a849e 100644
@@ -1572,9 +1572,6 @@ static bool connector_attr_set(int idx, drmModeConnector *connector,
 		return false;
 	}
 
-	if (!strcmp(c->value, c->reset_value))
-		connector_attr_free(c);
-
 	return true;
 }
 
Signature · 1 line
2.34.1
#27 lore raw

Re: [PATCH i-g-t 12/14] lib/igt_kms: allow set and reset value to be same

Quoted 17 lines · Kunal Joshi

allow set and reset value to be same, let the caller handle this scenario instead.

example scenario where this is required. i915_dp_force_link_rate should be auto before starting test should be auto at exit

---
 lib/igt_kms.c | 3 ---
 1 file changed, 3 deletions(-)
lib/igt_kms.c +0 -0
index b7511ccfc..5427a849e 100644

lib/igt_kms.c static bool connector_attr_set(int idx, drmModeConnector *connector, · line 1577

Quoted 6 lines
lib/igt_kms.c +0 -3
@@ -1572,9 +1572,6 @@ static bool connector_attr_set(int idx, drmModeConnector *connector,
 		return false;
 	}
 
-	if (!strcmp(c->value, c->reset_value))
-		connector_attr_free(c);
-

But it's not handled now by the caller. I agree it's better to keep the behavior for existing users, maybe adding a separate function for this (named *force_reset() or similar).

Quoted 6 lines
lib/igt_kms.c +0 -0
 	return true;
 }
 
Signature · 1 line
2.34.1
#28 lore raw

RE: [PATCH i-g-t 12/14] lib/igt_kms: allow set and reset value to be same

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 7:59 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 12/14] lib/igt_kms: allow set and reset value to be same

Quoted 17 lines · Kunal Joshi

allow set and reset value to be same, let the caller handle this scenario instead.

example scenario where this is required. i915_dp_force_link_rate should be auto before starting test should be auto at exit

---
 lib/igt_kms.c | 3 ---
 1 file changed, 3 deletions(-)
lib/igt_kms.c index b7511ccfc..5427a849e renamed from lib/igt_kms.c +0 -0

100644

lib/igt_kms.c static bool connector_attr_set(int idx, drmModeConnector *connector, · line 1577

Quoted 6 lines
lib/igt_kms.c +0 -3
@@ -1572,9 +1572,6 @@ static bool connector_attr_set(int idx, drmModeConnector *connector,
 		return false;
 	}
 
-	if (!strcmp(c->value, c->reset_value))
-		connector_attr_free(c);
-

But it's not handled now by the caller. I agree it's better to keep the behavior for existing users, maybe adding a separate function for this (named *force_reset() or similar).
----------------------------------------------------------------------------------------------
Will add parameter to allow similar set and reset_value if allow_eqaul_set_reset is true
And handle this wherever we have used this.

Thanks and Regards
Kunal Joshi

Quoted 6 lines
lib/igt_kms.c +0 -1
 	return true;
 }
 
--

2.34.1

#29 lore raw

PATCH 13/14 tests/intel/kms_dp_fallback: add test for validating fallback

In reply to a message not in the archive

add test to valdiate fallback for DP connector,
eDP subtest will be added later.

How does test validates fallback?
- test start by doing initial modeset on default mode (if connector is DP then we enable just that connector, if its DP-MST we enable all on the same topology)
- force link training failures and retrain until we reach lowest param or retrain is disabled
- expect hotplug and link-status to turn bad
- expect link params reduce after fallback

v2: add test for mst (imre)
refresh mode list (imre)
monitor got hotplugs (imre)
check link parameter are reduced (imre)

v3: call check_fn (Santosh)

v4: handle buggy lg monitor (Imre)
remove reset in between (Imre)

v5: fit modes wrt to bw in non-mst case as well

---
 tests/intel/kms_fallback.c | 515 +++++++++++++++++++++++++++++++++++++
 tests/meson.build          |   1 +
 2 files changed, 516 insertions(+)
 create mode 100644 tests/intel/kms_fallback.c
tests/intel/kms_fallback.c new file +515 -0
new file mode 100644
index 000000000..e97300c08
@@ -0,0 +1,515 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: kms fallback
+ * Category: Display
+ * Description: Test link training fallback for eDP/DP connectors
+ * Driver requirement: i915, xe
+ * Functionality: link training
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include <sys/types.h>
+
+#include "igt.h"
+#include "igt_psr.h"
+
+/**
+ * SUBTEST: dp-fallback
+ * Description: Test fallback on DP connectors
+ */
+
+#define RETRAIN_COUNT 1
+#define LT_FAILURE_SAME_CAPS 1
+#define LT_FAILURE_REDUCED_CAPS 2
+#define SPURIOUS_HPD_RETRY 3
+
+static int traversed_mst_outputs[IGT_MAX_PIPES];
+static int traversed_mst_output_count;
+typedef struct {
+	int drm_fd;
+	igt_display_t display;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+	enum pipe pipe;
+	struct igt_fb fb;
+	struct igt_plane *primary;
+	int n_pipes;
+} data_t;
+
+typedef int (*condition_check_fn)(int drm_fd, igt_output_t *output);
+
+IGT_TEST_DESCRIPTION("Test link training fallback");
+
+static const char *str_link_rate(enum dp_link_rate link_rate)
+{
+	switch (link_rate) {
+	case DP_LINK_RATE_162000:
+		return "1.62 Gbps";
+	case DP_LINK_RATE_216000:
+		return "2.16 Gbps";
+	case DP_LINK_RATE_243000:
+		return "2.43 Gbps";
+	case DP_LINK_RATE_270000:
+		return "2.70 Gbps";
+	case DP_LINK_RATE_324000:
+		return "3.24 Gbps";
+	case DP_LINK_RATE_432000:
+		return "4.32 Gbps";
+	case DP_LINK_RATE_540000:
+		return "5.40 Gbps";
+	case DP_LINK_RATE_675000:
+		return "6.75 Gbps";
+	case DP_LINK_RATE_810000:
+		return "8.10 Gbps";
+	case DP_LINK_RATE_1000000:
+		return "10.00 Gbps";
+	case DP_LINK_RATE_1350000:
+		return "13.50 Gbps";
+	case DP_LINK_RATE_2000000:
+		return "20.00 Gbps";
+	default:
+		igt_assert_f(0, "Invalid link rate %d\n", link_rate);
+	}
+}
+
+static const char *str_lane_count(enum dp_lane_count lane_count)
+{
+	switch (lane_count) {
+	case DP_LANE_COUNT_1:
+		return "1";
+	case DP_LANE_COUNT_2:
+		return "2";
+	case DP_LANE_COUNT_4:
+		return "4";
+	default:
+		igt_assert_f(0, "Invalid lane count %d\n", lane_count);
+	}
+}
+
+static void find_mst_outputs(int drm_fd, data_t *data,
+			     igt_output_t *output,
+			     igt_output_t **mst_outputs,
+			     int *num_mst_outputs)
+{
+	bool is_output_mst;
+	uint64_t path_blob_id;
+	igt_output_t *connector_output;
+	drmModePropertyPtr path_prop = NULL;
+	drmModePropertyPtr connector_path_prop = NULL;
+
+	igt_assert_f(output, "Invalid output\n");
+
+	/*
+	 * Check if given output is MST by checking if it has PATH property
+	 */
+	is_output_mst = kmstest_get_property(drm_fd,
+			output->config.connector->connector_id,
+			DRM_MODE_OBJECT_CONNECTOR, "PATH", NULL,
+			&path_blob_id, &path_prop);
+
+	if (!is_output_mst)
+		return;
+
+	/*
+	 * If output is MST check all other connected output which shares
+	 * same path and fill mst_outputs and num_mst_outputs
+	 */
+	for_each_connected_output(&data->display, connector_output) {
+
+		connector_path_prop = NULL;
+
+		kmstest_get_property(drm_fd,
+				     connector_output->config.connector->connector_id,
+				     DRM_MODE_OBJECT_CONNECTOR, "PATH",
+				     NULL, &path_blob_id,
+				     &connector_path_prop);
+
+		if (connector_path_prop && path_prop &&
+		    connector_path_prop->prop_id == path_prop->prop_id)
+			mst_outputs[(*num_mst_outputs)++] = connector_output;
+
+		if (connector_path_prop)
+			drmModeFreeProperty(connector_path_prop);
+	}
+	if (path_prop)
+		drmModeFreeProperty(path_prop);
+}
+
+static bool setup_mst_outputs(data_t *data, igt_output_t *mst_output[],
+			      int *dp_mst_outputs)
+{
+	int i;
+	igt_output_t *output;
+
+	igt_require_f(igt_check_output_is_dp_mst(data->output),
+		      "Not a valid MST connector\n");
+
+	/*
+	 * Check if this is already traversed
+	 */
+	for (i = 0; i < traversed_mst_output_count; i++)
+		if (traversed_mst_outputs[i] == data->output->config.connector->connector_id)
+			return false;
+
+	find_mst_outputs(data->drm_fd, data, data->output,
+			 mst_output, dp_mst_outputs);
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		output = mst_output[i];
+		traversed_mst_outputs[traversed_mst_output_count++] = output->config.connector->connector_id;
+		igt_info("Output %s is in same topology as %s\n",
+			 igt_output_name(output),
+			 igt_output_name(data->output));
+	}
+
+	return true;
+}
+
+static void setup_pipe_on_mst_outputs(data_t *data,
+				      igt_output_t *mst_output[],
+				      int *dp_mst_outputs)
+{
+	int i = 0;
+
+	igt_require_f(data->n_pipes >= *dp_mst_outputs,
+		      "Need %d pipes to assign to %d MST outputs\n",
+		      data->n_pipes, *dp_mst_outputs);
+
+	for_each_pipe(&data->display, data->pipe) {
+		if (i >= *dp_mst_outputs)
+			break;
+		igt_info("Setting pipe %s on output %s\n",
+			 kmstest_pipe_name(data->pipe),
+			 igt_output_name(mst_output[i]));
+		igt_output_set_pipe(mst_output[i++], data->pipe);
+	}
+}
+
+static void setup_modeset_on_mst_outputs(data_t *data,
+					 igt_output_t *mst_output[],
+					 int *dp_mst_outputs,
+					 drmModeModeInfo *mode[],
+					 struct igt_fb fb[],
+					 struct igt_plane *primary[])
+{
+	int i;
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		mst_output[i]->force_reprobe = true;
+		igt_output_refresh(mst_output[i]);
+		mode[i] = igt_output_get_mode(mst_output[i]);
+		igt_info("Mode %dx%d@%d on output %s\n",
+			 mode[i]->hdisplay, mode[i]->vdisplay,
+			 mode[i]->vrefresh,
+			 igt_output_name(mst_output[i]));
+		primary[i] = igt_output_get_plane_type(mst_output[i],
+							DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode[i]->hdisplay,
+				    mode[i]->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb[i]);
+		igt_plane_set_fb(primary[i], &fb[i]);
+	}
+}
+
+static bool fit_modes_in_bw(data_t *data)
+{
+	bool found;
+	int ret;
+
+	if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) {
+		igt_info("Modes overridden\n");
+		found = igt_override_all_active_output_modes_to_fit_bw(&data->display);
+                igt_require_f(found,
+                              "No valid mode combo found for MST modeset\n");
+                ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+                igt_require_f(ret == 0,
+                              "Commit failure during MST modeset\n");
+        }
+        return true;
+}
+
+static bool validate_modeset_mst_output(data_t *data,
+					igt_output_t *mst_output[],
+					int *dp_mst_outputs,
+					drmModeModeInfo *mode[],
+					struct igt_fb fb[],
+					struct igt_plane *primary[])
+{
+
+	igt_require_f(*dp_mst_outputs > 0, "No MST outputs found\n");
+	setup_pipe_on_mst_outputs(data, mst_output, dp_mst_outputs);
+	setup_modeset_on_mst_outputs(data, mst_output,
+				     dp_mst_outputs,
+				     mode, fb, primary);
+	igt_assert_f(fit_modes_in_bw(data), "Unable to fit modes in bw\n");
+	return true;
+}
+
+static bool setup_mst(data_t *data, bool is_mst,
+		      igt_output_t *mst_output[],
+		      int *dp_mst_outputs, drmModeModeInfo *mode[],
+		      struct igt_fb fb[], struct igt_plane *primary[])
+{
+	bool ret;
+
+	*dp_mst_outputs = 0;
+	ret = setup_mst_outputs(data, mst_output, dp_mst_outputs);
+	if (!ret) {
+		igt_info("Skipping MST output %s as already tested\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	ret = validate_modeset_mst_output(data, mst_output,
+					  dp_mst_outputs, mode,
+					  fb, primary);
+	if (!ret) {
+		igt_info("Skipping MST output %s as validpipe/output combo not found\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	return true;
+}
+
+static int check_condition_with_timeout(int drm_fd, igt_output_t *output,
+					condition_check_fn check_fn,
+					double interval, double timeout)
+{
+	struct timespec start_time, current_time;
+	double elapsed_time;
+
+	clock_gettime(CLOCK_MONOTONIC, &start_time);
+
+	while (1) {
+		if (check_fn(drm_fd, output) == 0) {
+			return 0;
+		}
+
+		clock_gettime(CLOCK_MONOTONIC, &current_time);
+		elapsed_time = (current_time.tv_sec - start_time.tv_sec) +
+			(current_time.tv_nsec - start_time.tv_nsec) / 1e9;
+
+		if (elapsed_time >= timeout) {
+			return -1;
+		}
+
+		usleep((useconds_t)(interval * 1000000));
+	}
+}
+
+static void test_fallback(data_t *data, bool is_mst)
+{
+	int dp_mst_outputs, retries;
+	igt_output_t *mst_outputs[IGT_MAX_PIPES];
+	enum dp_link_rate max_link_rate, curr_link_rate, prev_link_rate;
+	enum dp_lane_count max_lane_count, curr_lane_count, prev_lane_count;
+	uint32_t link_status_prop_id;
+	uint64_t link_status_value;
+	drmModeModeInfo *mst_modes[IGT_MAX_PIPES], *mode;
+	drmModePropertyPtr link_status_prop;
+	struct igt_fb mst_fbs[IGT_MAX_PIPES], fb;
+	struct igt_plane *mst_primarys[IGT_MAX_PIPES], *primary;
+	struct udev_monitor *mon;
+
+	igt_display_reset(&data->display);
+	retries = SPURIOUS_HPD_RETRY;
+
+	if (is_mst) {
+		if (!setup_mst(data, is_mst, mst_outputs,
+			       &dp_mst_outputs, mst_modes, mst_fbs,
+			       mst_primarys))
+			return;
+	} else {
+		data->pipe = PIPE_A;
+		igt_output_set_pipe(data->output, data->pipe);
+		mode = igt_output_get_mode(data->output);
+		primary = igt_output_get_plane_type(data->output,
+						    DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode->hdisplay, mode->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb);
+		igt_plane_set_fb(primary, &fb);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	}
+
+	igt_info("Testing link training fallback on %s\n",
+		 igt_output_name(data->output));
+
+	igt_reset_link_params(data->drm_fd, data->output);
+	igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+						   data->output,
+						   igt_get_dp_pending_retrain,
+						   1.0, 20.0), 0);
+
+	max_link_rate = igt_get_dp_max_link_rate(data->drm_fd, data->output);
+	max_lane_count = igt_get_dp_max_lane_count(data->drm_fd, data->output);
+
+	while (!igt_get_dp_link_retrain_disabled(data->drm_fd,
+						 data->output)) {
+
+		prev_link_rate = igt_get_dp_link_rate_set_for_output(data->drm_fd, data->output);
+		prev_lane_count = igt_get_dp_lane_count_set_for_output(data->drm_fd, data->output);
+
+		igt_info("Current link rate: %s, Current lane count: %s\n",
+			 str_link_rate(prev_link_rate),
+			 str_lane_count(prev_lane_count));
+		mon = igt_watch_uevents();
+		igt_force_lt_failure(data->drm_fd, data->output,
+				     LT_FAILURE_REDUCED_CAPS);
+		igt_force_link_retrain(data->drm_fd, data->output,
+				       RETRAIN_COUNT);
+
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_retrain,
+							   1.0, 20.0), 0);
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_lt_failures,
+							   1.0, 20.0), 0);
+
+		if (igt_get_dp_link_retrain_disabled(data->drm_fd,
+						     data->output)) {
+			igt_reset_connectors();
+			return;
+		}
+
+		igt_assert_f(igt_hotplug_detected(mon, 20),
+			     "Didn't get hotplug for force link training failure\n");
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-status",
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+
+		igt_assert_eq(link_status_value, DRM_MODE_LINK_STATUS_BAD);
+
+		igt_flush_uevents(mon);
+
+		if (is_mst) {
+			igt_assert_f(validate_modeset_mst_output(data,
+								 mst_outputs,
+								 &dp_mst_outputs,
+								 mst_modes,
+								 mst_fbs,
+								 mst_primarys),
+				     "MST modeset failed\n");
+		} else {
+			data->output->force_reprobe = true;
+			igt_output_refresh(data->output);
+			data->pipe = PIPE_A;
+			igt_assert_f(fit_modes_in_bw(data),
+				     "Unable to fit modes in bw\n");
+
+			igt_output_set_pipe(data->output, data->pipe);
+			mode = igt_output_get_mode(data->output);
+			igt_info("Mode %dx%d@%d on output %s\n",
+				 mode->hdisplay, mode->vdisplay,
+				 mode->vrefresh,
+				 igt_output_name(data->output));
+			primary = igt_output_get_plane_type(data->output,
+							    DRM_PLANE_TYPE_PRIMARY);
+			igt_create_color_fb(data->drm_fd,
+					    mode->hdisplay,
+					    mode->vdisplay,
+					    DRM_FORMAT_XRGB8888,
+					    DRM_FORMAT_MOD_LINEAR,
+					    0.0, 1.0, 0.0, &fb);
+			igt_plane_set_fb(primary, &fb);
+		}
+
+		kmstest_set_connector_link_status(data->drm_fd,
+						  data->output->config.connector,
+						  DRM_MODE_LINK_STATUS_GOOD);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-status",
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+		igt_assert_eq(link_status_value, DRM_MODE_LINK_STATUS_GOOD);
+
+		curr_link_rate = igt_get_dp_link_rate_set_for_output(data->drm_fd, data->output);
+		curr_lane_count = igt_get_dp_lane_count_set_for_output(data->drm_fd, data->output);
+
+		igt_assert_f((curr_link_rate < prev_link_rate ||
+			     curr_lane_count < prev_lane_count) ||
+			     ((curr_link_rate == max_link_rate && curr_lane_count == max_lane_count) && --retries),
+			     "Fallback unsuccessful\n");
+
+		prev_link_rate = curr_link_rate;
+		prev_lane_count = curr_lane_count;
+	}
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL |
+						     DRIVER_XE);
+		kmstest_set_vt_graphics_mode();
+		igt_display_require(&data.display, data.drm_fd);
+		igt_display_require_output(&data.display);
+		for_each_pipe(&data.display, data.pipe) {
+			data.n_pipes++;
+		}
+	}
+
+	igt_subtest("dp-fallback") {
+		bool ran = false;
+		igt_output_t *output;
+
+		for_each_connected_output(&data.display, output) {
+
+			data.output = output;
+			if (!igt_has_force_link_training_failure_debugfs(data.drm_fd,
+								    data.output)) {
+				igt_info("Output %s unsupported\n", igt_output_name(data.output));
+				continue;
+			}
+
+			if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort) {
+				igt_info("Skipping output %s as it's not DP\n", output->name);
+				continue;
+			}
+
+			ran = true;
+
+			/*
+			 * Check output is MST
+			 */
+			if (igt_check_output_is_dp_mst(data.output)) {
+				igt_info("Testing MST output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, true);
+			} else {
+				igt_info("Testing DP output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, false);
+			}
+		}
+		igt_require_f(ran, "No output supports fallback\n");
+	}
+
+	igt_fixture {
+		igt_remove_fb(data.drm_fd, &data.fb);
+		igt_display_fini(&data.display);
+		close(data.drm_fd);
+	}
+}
tests/meson.build +1 -0
index 00556c9d6..86fab423b 100644
@@ -249,6 +249,7 @@ intel_kms_progs = [
 	'kms_dirtyfb',
 	'kms_draw_crc',
 	'kms_dsc',
+        'kms_fallback',
 	'kms_fb_coherency',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
Signature · 1 line
2.34.1
#30 lore raw

RE: [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback

Quoted 554 lines

-----Original Message-----
From: igt-dev <[email protected]> On Behalf Of Kunal Joshi
Sent: Monday, August 26, 2024 1:36 AM
To: [email protected]
Cc: Joshi, Kunal1 <[email protected]>; Deak, Imre <[email protected]>
Subject: [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback

add test to valdiate fallback for DP connector, eDP subtest will be added later.

How does test validates fallback?
- test start by doing initial modeset on default mode (if connector is DP then we enable just that connector, if its DP-MST we enable all on the same topology)
- force link training failures and retrain until we reach lowest param or retrain is disabled
- expect hotplug and link-status to turn bad
- expect link params reduce after fallback

v2: add test for mst (imre)
refresh mode list (imre)
monitor got hotplugs (imre)
check link parameter are reduced (imre)

v3: call check_fn (Santosh)

v4: handle buggy lg monitor (Imre)
remove reset in between (Imre)

v5: fit modes wrt to bw in non-mst case as well

---
 tests/intel/kms_fallback.c | 515 +++++++++++++++++++++++++++++++++++++
 tests/meson.build          |   1 +
 2 files changed, 516 insertions(+)
 create mode 100644 tests/intel/kms_fallback.c
tests/intel/kms_fallback.c new file mode renamed from tests/intel/kms_fallback.c +0 -0

100644 index 000000000..e97300c08

tests/intel/kms_fallback.c new file +124 -0
@@ -0,0 +1,515 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: kms fallback
+ * Category: Display
+ * Description: Test link training fallback for eDP/DP connectors
+ * Driver requirement: i915, xe
+ * Functionality: link training
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include <sys/types.h>
+
+#include "igt.h"
+#include "igt_psr.h"
+
+/**
+ * SUBTEST: dp-fallback
+ * Description: Test fallback on DP connectors  */
+
+#define RETRAIN_COUNT 1
+#define LT_FAILURE_SAME_CAPS 1
+#define LT_FAILURE_REDUCED_CAPS 2
+#define SPURIOUS_HPD_RETRY 3
+
+static int traversed_mst_outputs[IGT_MAX_PIPES];
+static int traversed_mst_output_count;
+typedef struct {
+	int drm_fd;
+	igt_display_t display;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+	enum pipe pipe;
+	struct igt_fb fb;
+	struct igt_plane *primary;
+	int n_pipes;
+} data_t;
+
+typedef int (*condition_check_fn)(int drm_fd, igt_output_t *output);
+
+IGT_TEST_DESCRIPTION("Test link training fallback");
+
+static const char *str_link_rate(enum dp_link_rate link_rate) {
+	switch (link_rate) {
+	case DP_LINK_RATE_162000:
+		return "1.62 Gbps";
+	case DP_LINK_RATE_216000:
+		return "2.16 Gbps";
+	case DP_LINK_RATE_243000:
+		return "2.43 Gbps";
+	case DP_LINK_RATE_270000:
+		return "2.70 Gbps";
+	case DP_LINK_RATE_324000:
+		return "3.24 Gbps";
+	case DP_LINK_RATE_432000:
+		return "4.32 Gbps";
+	case DP_LINK_RATE_540000:
+		return "5.40 Gbps";
+	case DP_LINK_RATE_675000:
+		return "6.75 Gbps";
+	case DP_LINK_RATE_810000:
+		return "8.10 Gbps";
+	case DP_LINK_RATE_1000000:
+		return "10.00 Gbps";
+	case DP_LINK_RATE_1350000:
+		return "13.50 Gbps";
+	case DP_LINK_RATE_2000000:
+		return "20.00 Gbps";
+	default:
+		igt_assert_f(0, "Invalid link rate %d\n", link_rate);
+	}
+}
+
+static const char *str_lane_count(enum dp_lane_count lane_count) {
+	switch (lane_count) {
+	case DP_LANE_COUNT_1:
+		return "1";
+	case DP_LANE_COUNT_2:
+		return "2";
+	case DP_LANE_COUNT_4:
+		return "4";
+	default:
+		igt_assert_f(0, "Invalid lane count %d\n", lane_count);
+	}
+}
+
+static void find_mst_outputs(int drm_fd, data_t *data,
+			     igt_output_t *output,
+			     igt_output_t **mst_outputs,
+			     int *num_mst_outputs)
+{
+	bool is_output_mst;
+	uint64_t path_blob_id;
+	igt_output_t *connector_output;
+	drmModePropertyPtr path_prop = NULL;
+	drmModePropertyPtr connector_path_prop = NULL;
+
+	igt_assert_f(output, "Invalid output\n");
+
+	/*
+	 * Check if given output is MST by checking if it has PATH property
+	 */
+	is_output_mst = kmstest_get_property(drm_fd,
+			output->config.connector->connector_id,
+			DRM_MODE_OBJECT_CONNECTOR, "PATH", NULL,
+			&path_blob_id, &path_prop);
+
+	if (!is_output_mst)
+		return;
+
+	/*
+	 * If output is MST check all other connected output which shares
+	 * same path and fill mst_outputs and num_mst_outputs
+	 */
+	for_each_connected_output(&data->display, connector_output) {
+
+		connector_path_prop = NULL;
+
+		kmstest_get_property(drm_fd,
+				     connector_output->config.connector-
Quoted 1 line

connector_id,

tests/intel/kms_fallback.c new file +7 -0
+				     DRM_MODE_OBJECT_CONNECTOR, "PATH",
+				     NULL, &path_blob_id,
+				     &connector_path_prop);
+
+		if (connector_path_prop && path_prop &&
+		    connector_path_prop->prop_id == path_prop->prop_id)
+			mst_outputs[(*num_mst_outputs)++] =

connector_output;

tests/intel/kms_fallback.c new file +22 -0
+
+		if (connector_path_prop)
+			drmModeFreeProperty(connector_path_prop);
+	}
+	if (path_prop)
+		drmModeFreeProperty(path_prop);
+}
+
+static bool setup_mst_outputs(data_t *data, igt_output_t *mst_output[],
+			      int *dp_mst_outputs)
+{
+	int i;
+	igt_output_t *output;
+
+	igt_require_f(igt_check_output_is_dp_mst(data->output),
+		      "Not a valid MST connector\n");
+
+	/*
+	 * Check if this is already traversed
+	 */
+	for (i = 0; i < traversed_mst_output_count; i++)
+		if (traversed_mst_outputs[i] == data->output->config.connector-
Quoted 1 line

connector_id)

tests/intel/kms_fallback.c new file +8 -0
+			return false;
+
+	find_mst_outputs(data->drm_fd, data, data->output,
+			 mst_output, dp_mst_outputs);
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		output = mst_output[i];
+		traversed_mst_outputs[traversed_mst_output_count++] =

output->config.connector->connector_id;

tests/intel/kms_fallback.c new file +47 -0
+		igt_info("Output %s is in same topology as %s\n",
+			 igt_output_name(output),
+			 igt_output_name(data->output));
+	}
+
+	return true;
+}
+
+static void setup_pipe_on_mst_outputs(data_t *data,
+				      igt_output_t *mst_output[],
+				      int *dp_mst_outputs)
+{
+	int i = 0;
+
+	igt_require_f(data->n_pipes >= *dp_mst_outputs,
+		      "Need %d pipes to assign to %d MST outputs\n",
+		      data->n_pipes, *dp_mst_outputs);
+
+	for_each_pipe(&data->display, data->pipe) {
+		if (i >= *dp_mst_outputs)
+			break;
+		igt_info("Setting pipe %s on output %s\n",
+			 kmstest_pipe_name(data->pipe),
+			 igt_output_name(mst_output[i]));
+		igt_output_set_pipe(mst_output[i++], data->pipe);
+	}
+}
+
+static void setup_modeset_on_mst_outputs(data_t *data,
+					 igt_output_t *mst_output[],
+					 int *dp_mst_outputs,
+					 drmModeModeInfo *mode[],
+					 struct igt_fb fb[],
+					 struct igt_plane *primary[])
+{
+	int i;
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		mst_output[i]->force_reprobe = true;
+		igt_output_refresh(mst_output[i]);
+		mode[i] = igt_output_get_mode(mst_output[i]);
+		igt_info("Mode %dx%d@%d on output %s\n",
+			 mode[i]->hdisplay, mode[i]->vdisplay,
+			 mode[i]->vrefresh,
+			 igt_output_name(mst_output[i]));
+		primary[i] = igt_output_get_plane_type(mst_output[i],
+
	DRM_PLANE_TYPE_PRIMARY);
tests/intel/kms_fallback.c new file +17 -0
+		igt_create_color_fb(data->drm_fd,
+				    mode[i]->hdisplay,
+				    mode[i]->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb[i]);
+		igt_plane_set_fb(primary[i], &fb[i]);
+	}
+}
+
+static bool fit_modes_in_bw(data_t *data) {
+	bool found;
+	int ret;
+
+	if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) {
+		igt_info("Modes overridden\n");
+		found =

igt_override_all_active_output_modes_to_fit_bw(&data->display);

tests/intel/kms_fallback.c new file +45 -0
+                igt_require_f(found,
+                              "No valid mode combo found for MST modeset\n");
+                ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+                igt_require_f(ret == 0,
+                              "Commit failure during MST modeset\n");
+        }
+        return true;
+}
+
+static bool validate_modeset_mst_output(data_t *data,
+					igt_output_t *mst_output[],
+					int *dp_mst_outputs,
+					drmModeModeInfo *mode[],
+					struct igt_fb fb[],
+					struct igt_plane *primary[])
+{
+
+	igt_require_f(*dp_mst_outputs > 0, "No MST outputs found\n");
+	setup_pipe_on_mst_outputs(data, mst_output, dp_mst_outputs);
+	setup_modeset_on_mst_outputs(data, mst_output,
+				     dp_mst_outputs,
+				     mode, fb, primary);
+	igt_assert_f(fit_modes_in_bw(data), "Unable to fit modes in bw\n");
+	return true;
+}
+
+static bool setup_mst(data_t *data, bool is_mst,
+		      igt_output_t *mst_output[],
+		      int *dp_mst_outputs, drmModeModeInfo *mode[],
+		      struct igt_fb fb[], struct igt_plane *primary[]) {
+	bool ret;
+
+	*dp_mst_outputs = 0;
+	ret = setup_mst_outputs(data, mst_output, dp_mst_outputs);
+	if (!ret) {
+		igt_info("Skipping MST output %s as already tested\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	ret = validate_modeset_mst_output(data, mst_output,
+					  dp_mst_outputs, mode,
+					  fb, primary);
+	if (!ret) {
+		igt_info("Skipping MST output %s as validpipe/output combo not

found\n",

tests/intel/kms_fallback.c new file +39 -0
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	return true;
+}
+
+static int check_condition_with_timeout(int drm_fd, igt_output_t *output,
+					condition_check_fn check_fn,
+					double interval, double timeout)
+{
+	struct timespec start_time, current_time;
+	double elapsed_time;
+
+	clock_gettime(CLOCK_MONOTONIC, &start_time);
+
+	while (1) {
+		if (check_fn(drm_fd, output) == 0) {
+			return 0;
+		}
+
+		clock_gettime(CLOCK_MONOTONIC, &current_time);
+		elapsed_time = (current_time.tv_sec - start_time.tv_sec) +
+			(current_time.tv_nsec - start_time.tv_nsec) / 1e9;
+
+		if (elapsed_time >= timeout) {
+			return -1;
+		}
+
+		usleep((useconds_t)(interval * 1000000));
+	}
+}
+
+static void test_fallback(data_t *data, bool is_mst) {
+	int dp_mst_outputs, retries;
+	igt_output_t *mst_outputs[IGT_MAX_PIPES];
+	enum dp_link_rate max_link_rate, curr_link_rate, prev_link_rate;
+	enum dp_lane_count max_lane_count, curr_lane_count,

prev_lane_count;

tests/intel/kms_fallback.c new file +22 -0
+	uint32_t link_status_prop_id;
+	uint64_t link_status_value;
+	drmModeModeInfo *mst_modes[IGT_MAX_PIPES], *mode;
+	drmModePropertyPtr link_status_prop;
+	struct igt_fb mst_fbs[IGT_MAX_PIPES], fb;
+	struct igt_plane *mst_primarys[IGT_MAX_PIPES], *primary;
+	struct udev_monitor *mon;
+
+	igt_display_reset(&data->display);
+	retries = SPURIOUS_HPD_RETRY;
+
+	if (is_mst) {
+		if (!setup_mst(data, is_mst, mst_outputs,
+			       &dp_mst_outputs, mst_modes, mst_fbs,
+			       mst_primarys))
+			return;
+	} else {
+		data->pipe = PIPE_A;
+		igt_output_set_pipe(data->output, data->pipe);
+		mode = igt_output_get_mode(data->output);
+		primary = igt_output_get_plane_type(data->output,
+

DRM_PLANE_TYPE_PRIMARY);

tests/intel/kms_fallback.c new file +26 -0
+		igt_create_color_fb(data->drm_fd,
+				    mode->hdisplay, mode->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb);
+		igt_plane_set_fb(primary, &fb);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	}
+
+	igt_info("Testing link training fallback on %s\n",
+		 igt_output_name(data->output));
+
+	igt_reset_link_params(data->drm_fd, data->output);
+	igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+						   data->output,
+						   igt_get_dp_pending_retrain,
+						   1.0, 20.0), 0);
+
+	max_link_rate = igt_get_dp_max_link_rate(data->drm_fd, data->output);
+	max_lane_count = igt_get_dp_max_lane_count(data->drm_fd,
+data->output);
+
+	while (!igt_get_dp_link_retrain_disabled(data->drm_fd,
+						 data->output)) {
+
+		prev_link_rate = igt_get_dp_link_rate_set_for_output(data-
Quoted 1 line

drm_fd, data->output);

tests/intel/kms_fallback.c new file +1 -0
+		prev_lane_count = igt_get_dp_lane_count_set_for_output(data-
Quoted 1 line

drm_fd,

tests/intel/kms_fallback.c new file +14 -0
+data->output);
+
+		igt_info("Current link rate: %s, Current lane count: %s\n",
+			 str_link_rate(prev_link_rate),
+			 str_lane_count(prev_lane_count));
+		mon = igt_watch_uevents();
+		igt_force_lt_failure(data->drm_fd, data->output,
+				     LT_FAILURE_REDUCED_CAPS);
+		igt_force_link_retrain(data->drm_fd, data->output,
+				       RETRAIN_COUNT);
+
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+

igt_get_dp_pending_retrain,

tests/intel/kms_fallback.c new file +4 -0
+							   1.0, 20.0), 0);
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+

igt_get_dp_pending_lt_failures,

tests/intel/kms_fallback.c new file +14 -0
+							   1.0, 20.0), 0);
+
+		if (igt_get_dp_link_retrain_disabled(data->drm_fd,
+						     data->output)) {
+			igt_reset_connectors();
+			return;
+		}
+
+		igt_assert_f(igt_hotplug_detected(mon, 20),
+			     "Didn't get hotplug for force link training failure\n");
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-

status",

tests/intel/kms_fallback.c new file +4 -0
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+
+		igt_assert_eq(link_status_value,

DRM_MODE_LINK_STATUS_BAD);

tests/intel/kms_fallback.c new file +7 -0
+
+		igt_flush_uevents(mon);
+
+		if (is_mst) {
+			igt_assert_f(validate_modeset_mst_output(data,
+								 mst_outputs,
+

&dp_mst_outputs,

tests/intel/kms_fallback.c new file +3 -0
+								 mst_modes,
+								 mst_fbs,
+

mst_primarys),

tests/intel/kms_fallback.c new file +16 -0
+				     "MST modeset failed\n");
+		} else {
+			data->output->force_reprobe = true;
+			igt_output_refresh(data->output);
+			data->pipe = PIPE_A;
+			igt_assert_f(fit_modes_in_bw(data),
+				     "Unable to fit modes in bw\n");
+
+			igt_output_set_pipe(data->output, data->pipe);
+			mode = igt_output_get_mode(data->output);
+			igt_info("Mode %dx%d@%d on output %s\n",
+				 mode->hdisplay, mode->vdisplay,
+				 mode->vrefresh,
+				 igt_output_name(data->output));
+			primary = igt_output_get_plane_type(data->output,
+

DRM_PLANE_TYPE_PRIMARY);

tests/intel/kms_fallback.c new file +11 -0
+			igt_create_color_fb(data->drm_fd,
+					    mode->hdisplay,
+					    mode->vdisplay,
+					    DRM_FORMAT_XRGB8888,
+					    DRM_FORMAT_MOD_LINEAR,
+					    0.0, 1.0, 0.0, &fb);
+			igt_plane_set_fb(primary, &fb);
+		}
+
+		kmstest_set_connector_link_status(data->drm_fd,
+						  data->output-
Quoted 1 line

config.connector,

+
DRM_MODE_LINK_STATUS_GOOD);

tests/intel/kms_fallback.c new file +5 -0
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-

status",

tests/intel/kms_fallback.c new file +3 -0
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+		igt_assert_eq(link_status_value,

DRM_MODE_LINK_STATUS_GOOD);

tests/intel/kms_fallback.c new file +2 -0
+
+		curr_link_rate = igt_get_dp_link_rate_set_for_output(data-
Quoted 1 line

drm_fd, data->output);

tests/intel/kms_fallback.c new file +1 -0
+		curr_lane_count = igt_get_dp_lane_count_set_for_output(data-
Quoted 1 line

drm_fd,

tests/intel/kms_fallback.c new file +5 -0
+data->output);
+
+		igt_assert_f((curr_link_rate < prev_link_rate ||
+			     curr_lane_count < prev_lane_count) ||
+			     ((curr_link_rate == max_link_rate &&

curr_lane_count == max_lane_count) && --retries),

tests/intel/kms_fallback.c new file +30 -0
+			     "Fallback unsuccessful\n");
+
+		prev_link_rate = curr_link_rate;
+		prev_lane_count = curr_lane_count;
+	}
+}
+
+igt_main
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL |
+						     DRIVER_XE);
+		kmstest_set_vt_graphics_mode();
+		igt_display_require(&data.display, data.drm_fd);
+		igt_display_require_output(&data.display);
+		for_each_pipe(&data.display, data.pipe) {
+			data.n_pipes++;
+		}
+	}
+
+	igt_subtest("dp-fallback") {
+		bool ran = false;
+		igt_output_t *output;
+
+		for_each_connected_output(&data.display, output) {
+
+			data.output = output;
+			if

(!igt_has_force_link_training_failure_debugfs(data.drm_fd, +
data.output)) {

tests/intel/kms_fallback.c new file +1 -0
+				igt_info("Output %s unsupported\n",
Quoted 1 line

igt_output_name(data.output));

If possible, we can convert this message to a more user-friendly way.

Igt_info("Output %s doesn't support force link training failure\n" Or anything similar.

Regards,
Pranay Samala

Quoted 48 lines
tests/intel/kms_fallback.c new file +4 -0
+				continue;
+			}
+
+			if (output->config.connector->connector_type !=

DRM_MODE_CONNECTOR_DisplayPort) {

tests/intel/kms_fallback.c new file +1 -0
+				igt_info("Skipping output %s as it's not DP\n",

output->name);

tests/intel/kms_fallback.c new file +27 -0
+				continue;
+			}
+
+			ran = true;
+
+			/*
+			 * Check output is MST
+			 */
+			if (igt_check_output_is_dp_mst(data.output)) {
+				igt_info("Testing MST output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, true);
+			} else {
+				igt_info("Testing DP output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, false);
+			}
+		}
+		igt_require_f(ran, "No output supports fallback\n");
+	}
+
+	igt_fixture {
+		igt_remove_fb(data.drm_fd, &data.fb);
+		igt_display_fini(&data.display);
+		close(data.drm_fd);
+	}
+}
tests/meson.build index 00556c9d6..86fab423b renamed from tests/meson.build +0 -0

100644

tests/meson.build +1 -1
@@ -249,6 +249,7 @@ intel_kms_progs = [
 	'kms_dirtyfb',
 	'kms_draw_crc',
 	'kms_dsc',
+        'kms_fallback',
 	'kms_fb_coherency',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
--

2.34.1

#31 lore raw

Re: [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback

In reply to Kunal Joshi
Quoted 56 lines · Kunal Joshi

add test to valdiate fallback for DP connector,
eDP subtest will be added later.

How does test validates fallback?
- test start by doing initial modeset on default mode (if connector is DP then we enable just that connector, if its DP-MST we enable all on the same topology)
- force link training failures and retrain until we reach lowest param or retrain is disabled
- expect hotplug and link-status to turn bad
- expect link params reduce after fallback

v2: add test for mst (imre)
refresh mode list (imre)
monitor got hotplugs (imre)
check link parameter are reduced (imre)

v3: call check_fn (Santosh)

v4: handle buggy lg monitor (Imre)
remove reset in between (Imre)

v5: fit modes wrt to bw in non-mst case as well

---
 tests/intel/kms_fallback.c | 515 +++++++++++++++++++++++++++++++++++++
 tests/meson.build          |   1 +
 2 files changed, 516 insertions(+)
 create mode 100644 tests/intel/kms_fallback.c
tests/intel/kms_fallback.c new file +17 -0
new file mode 100644
index 000000000..e97300c08
@@ -0,0 +1,515 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright © 2024 Intel Corporation
+ */
+
+/**
+ * TEST: kms fallback
+ * Category: Display
+ * Description: Test link training fallback for eDP/DP connectors
+ * Driver requirement: i915, xe
+ * Functionality: link training
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include <sys/types.h>
+

tests/intel/kms_fallback.c line 27

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+#include "igt.h"
+#include "igt_psr.h"
+
+/**
+ * SUBTEST: dp-fallback
+ * Description: Test fallback on DP connectors
+ */
+
+#define RETRAIN_COUNT 1
+#define LT_FAILURE_SAME_CAPS 1

This is not used. Maybe add a comment instead why 2 LT failure will lead to reducing the link params?

Quoted 308 lines
tests/intel/kms_fallback.c new file +308 -0
+#define LT_FAILURE_REDUCED_CAPS 2
+#define SPURIOUS_HPD_RETRY 3
+
+static int traversed_mst_outputs[IGT_MAX_PIPES];
+static int traversed_mst_output_count;
+typedef struct {
+	int drm_fd;
+	igt_display_t display;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+	enum pipe pipe;
+	struct igt_fb fb;
+	struct igt_plane *primary;
+	int n_pipes;
+} data_t;
+
+typedef int (*condition_check_fn)(int drm_fd, igt_output_t *output);
+
+IGT_TEST_DESCRIPTION("Test link training fallback");
+
+static const char *str_link_rate(enum dp_link_rate link_rate)
+{
+	switch (link_rate) {
+	case DP_LINK_RATE_162000:
+		return "1.62 Gbps";
+	case DP_LINK_RATE_216000:
+		return "2.16 Gbps";
+	case DP_LINK_RATE_243000:
+		return "2.43 Gbps";
+	case DP_LINK_RATE_270000:
+		return "2.70 Gbps";
+	case DP_LINK_RATE_324000:
+		return "3.24 Gbps";
+	case DP_LINK_RATE_432000:
+		return "4.32 Gbps";
+	case DP_LINK_RATE_540000:
+		return "5.40 Gbps";
+	case DP_LINK_RATE_675000:
+		return "6.75 Gbps";
+	case DP_LINK_RATE_810000:
+		return "8.10 Gbps";
+	case DP_LINK_RATE_1000000:
+		return "10.00 Gbps";
+	case DP_LINK_RATE_1350000:
+		return "13.50 Gbps";
+	case DP_LINK_RATE_2000000:
+		return "20.00 Gbps";
+	default:
+		igt_assert_f(0, "Invalid link rate %d\n", link_rate);
+	}
+}
+
+static const char *str_lane_count(enum dp_lane_count lane_count)
+{
+	switch (lane_count) {
+	case DP_LANE_COUNT_1:
+		return "1";
+	case DP_LANE_COUNT_2:
+		return "2";
+	case DP_LANE_COUNT_4:
+		return "4";
+	default:
+		igt_assert_f(0, "Invalid lane count %d\n", lane_count);
+	}
+}
+
+static void find_mst_outputs(int drm_fd, data_t *data,
+			     igt_output_t *output,
+			     igt_output_t **mst_outputs,
+			     int *num_mst_outputs)
+{
+	bool is_output_mst;
+	uint64_t path_blob_id;
+	igt_output_t *connector_output;
+	drmModePropertyPtr path_prop = NULL;
+	drmModePropertyPtr connector_path_prop = NULL;
+
+	igt_assert_f(output, "Invalid output\n");
+
+	/*
+	 * Check if given output is MST by checking if it has PATH property
+	 */
+	is_output_mst = kmstest_get_property(drm_fd,
+			output->config.connector->connector_id,
+			DRM_MODE_OBJECT_CONNECTOR, "PATH", NULL,
+			&path_blob_id, &path_prop);
+
+	if (!is_output_mst)
+		return;
+
+	/*
+	 * If output is MST check all other connected output which shares
+	 * same path and fill mst_outputs and num_mst_outputs
+	 */
+	for_each_connected_output(&data->display, connector_output) {
+
+		connector_path_prop = NULL;
+
+		kmstest_get_property(drm_fd,
+				     connector_output->config.connector->connector_id,
+				     DRM_MODE_OBJECT_CONNECTOR, "PATH",
+				     NULL, &path_blob_id,
+				     &connector_path_prop);
+
+		if (connector_path_prop && path_prop &&
+		    connector_path_prop->prop_id == path_prop->prop_id)
+			mst_outputs[(*num_mst_outputs)++] = connector_output;
+
+		if (connector_path_prop)
+			drmModeFreeProperty(connector_path_prop);
+	}
+	if (path_prop)
+		drmModeFreeProperty(path_prop);
+}
+
+static bool setup_mst_outputs(data_t *data, igt_output_t *mst_output[],
+			      int *dp_mst_outputs)
+{
+	int i;
+	igt_output_t *output;
+
+	igt_require_f(igt_check_output_is_dp_mst(data->output),
+		      "Not a valid MST connector\n");
+
+	/*
+	 * Check if this is already traversed
+	 */
+	for (i = 0; i < traversed_mst_output_count; i++)
+		if (traversed_mst_outputs[i] == data->output->config.connector->connector_id)
+			return false;
+
+	find_mst_outputs(data->drm_fd, data, data->output,
+			 mst_output, dp_mst_outputs);
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		output = mst_output[i];
+		traversed_mst_outputs[traversed_mst_output_count++] = output->config.connector->connector_id;
+		igt_info("Output %s is in same topology as %s\n",
+			 igt_output_name(output),
+			 igt_output_name(data->output));
+	}
+
+	return true;
+}
+
+static void setup_pipe_on_mst_outputs(data_t *data,
+				      igt_output_t *mst_output[],
+				      int *dp_mst_outputs)
+{
+	int i = 0;
+
+	igt_require_f(data->n_pipes >= *dp_mst_outputs,
+		      "Need %d pipes to assign to %d MST outputs\n",
+		      data->n_pipes, *dp_mst_outputs);
+
+	for_each_pipe(&data->display, data->pipe) {
+		if (i >= *dp_mst_outputs)
+			break;
+		igt_info("Setting pipe %s on output %s\n",
+			 kmstest_pipe_name(data->pipe),
+			 igt_output_name(mst_output[i]));
+		igt_output_set_pipe(mst_output[i++], data->pipe);
+	}
+}
+
+static void setup_modeset_on_mst_outputs(data_t *data,
+					 igt_output_t *mst_output[],
+					 int *dp_mst_outputs,
+					 drmModeModeInfo *mode[],
+					 struct igt_fb fb[],
+					 struct igt_plane *primary[])
+{
+	int i;
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		mst_output[i]->force_reprobe = true;
+		igt_output_refresh(mst_output[i]);
+		mode[i] = igt_output_get_mode(mst_output[i]);
+		igt_info("Mode %dx%d@%d on output %s\n",
+			 mode[i]->hdisplay, mode[i]->vdisplay,
+			 mode[i]->vrefresh,
+			 igt_output_name(mst_output[i]));
+		primary[i] = igt_output_get_plane_type(mst_output[i],
+							DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode[i]->hdisplay,
+				    mode[i]->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb[i]);
+		igt_plane_set_fb(primary[i], &fb[i]);
+	}
+}
+
+static bool fit_modes_in_bw(data_t *data)
+{
+	bool found;
+	int ret;
+
+	if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) {
+		igt_info("Modes overridden\n");
+		found = igt_override_all_active_output_modes_to_fit_bw(&data->display);
+                igt_require_f(found,
+                              "No valid mode combo found for MST modeset\n");
+                ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+                igt_require_f(ret == 0,
+                              "Commit failure during MST modeset\n");
+        }
+        return true;
+}
+
+static bool validate_modeset_mst_output(data_t *data,
+					igt_output_t *mst_output[],
+					int *dp_mst_outputs,
+					drmModeModeInfo *mode[],
+					struct igt_fb fb[],
+					struct igt_plane *primary[])
+{
+
+	igt_require_f(*dp_mst_outputs > 0, "No MST outputs found\n");
+	setup_pipe_on_mst_outputs(data, mst_output, dp_mst_outputs);
+	setup_modeset_on_mst_outputs(data, mst_output,
+				     dp_mst_outputs,
+				     mode, fb, primary);
+	igt_assert_f(fit_modes_in_bw(data), "Unable to fit modes in bw\n");
+	return true;
+}
+
+static bool setup_mst(data_t *data, bool is_mst,
+		      igt_output_t *mst_output[],
+		      int *dp_mst_outputs, drmModeModeInfo *mode[],
+		      struct igt_fb fb[], struct igt_plane *primary[])
+{
+	bool ret;
+
+	*dp_mst_outputs = 0;
+	ret = setup_mst_outputs(data, mst_output, dp_mst_outputs);
+	if (!ret) {
+		igt_info("Skipping MST output %s as already tested\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	ret = validate_modeset_mst_output(data, mst_output,
+					  dp_mst_outputs, mode,
+					  fb, primary);
+	if (!ret) {
+		igt_info("Skipping MST output %s as validpipe/output combo not found\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	return true;
+}
+
+static int check_condition_with_timeout(int drm_fd, igt_output_t *output,
+					condition_check_fn check_fn,
+					double interval, double timeout)
+{
+	struct timespec start_time, current_time;
+	double elapsed_time;
+
+	clock_gettime(CLOCK_MONOTONIC, &start_time);
+
+	while (1) {
+		if (check_fn(drm_fd, output) == 0) {
+			return 0;
+		}
+
+		clock_gettime(CLOCK_MONOTONIC, &current_time);
+		elapsed_time = (current_time.tv_sec - start_time.tv_sec) +
+			(current_time.tv_nsec - start_time.tv_nsec) / 1e9;
+
+		if (elapsed_time >= timeout) {
+			return -1;
+		}
+
+		usleep((useconds_t)(interval * 1000000));
+	}
+}
+
+static void test_fallback(data_t *data, bool is_mst)
+{
+	int dp_mst_outputs, retries;
+	igt_output_t *mst_outputs[IGT_MAX_PIPES];
+	enum dp_link_rate max_link_rate, curr_link_rate, prev_link_rate;
+	enum dp_lane_count max_lane_count, curr_lane_count, prev_lane_count;
+	uint32_t link_status_prop_id;
+	uint64_t link_status_value;
+	drmModeModeInfo *mst_modes[IGT_MAX_PIPES], *mode;
+	drmModePropertyPtr link_status_prop;
+	struct igt_fb mst_fbs[IGT_MAX_PIPES], fb;
+	struct igt_plane *mst_primarys[IGT_MAX_PIPES], *primary;
+	struct udev_monitor *mon;
+
+	igt_display_reset(&data->display);
+	retries = SPURIOUS_HPD_RETRY;
+
+	if (is_mst) {
+		if (!setup_mst(data, is_mst, mst_outputs,
+			       &dp_mst_outputs, mst_modes, mst_fbs,
+			       mst_primarys))
+			return;
+	} else {
+		data->pipe = PIPE_A;
+		igt_output_set_pipe(data->output, data->pipe);
+		mode = igt_output_get_mode(data->output);

tests/intel/kms_fallback.c line 345

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+		primary = igt_output_get_plane_type(data->output,
+						    DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode->hdisplay, mode->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb);
+		igt_plane_set_fb(primary, &fb);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	}

Would be better to have a separate function for the above and make dp_mst_outputs more generic, also used for the non-MST case (adding to the array then only a single output).

tests/intel/kms_fallback.c line 350

Quoted 5 lines
tests/intel/kms_fallback.c new file +5 -0
+
+	igt_info("Testing link training fallback on %s\n",
+		 igt_output_name(data->output));
+
+	igt_reset_link_params(data->drm_fd, data->output);

Could this be done before the above setup part? Then the modes chosen there should be based already on the updated link params and the commit would also retrain the link if needed.

tests/intel/kms_fallback.c line 361

Quoted 11 lines
tests/intel/kms_fallback.c new file +11 -0
+	igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+						   data->output,
+						   igt_get_dp_pending_retrain,
+						   1.0, 20.0), 0);
+
+	max_link_rate = igt_get_dp_max_link_rate(data->drm_fd, data->output);
+	max_lane_count = igt_get_dp_max_lane_count(data->drm_fd, data->output);
+
+	while (!igt_get_dp_link_retrain_disabled(data->drm_fd,
+						 data->output)) {
+

Extra w/s.

tests/intel/kms_fallback.c line 363

Quoted 2 lines
tests/intel/kms_fallback.c new file +2 -0
+		prev_link_rate = igt_get_dp_link_rate_set_for_output(data->drm_fd, data->output);
+		prev_lane_count = igt_get_dp_lane_count_set_for_output(data->drm_fd, data->output);

Moving these before the loop would avoid the duplication wrt. setting them at the end of the loop.

Quoted 59 lines
tests/intel/kms_fallback.c new file +59 -0
+
+		igt_info("Current link rate: %s, Current lane count: %s\n",
+			 str_link_rate(prev_link_rate),
+			 str_lane_count(prev_lane_count));
+		mon = igt_watch_uevents();
+		igt_force_lt_failure(data->drm_fd, data->output,
+				     LT_FAILURE_REDUCED_CAPS);
+		igt_force_link_retrain(data->drm_fd, data->output,
+				       RETRAIN_COUNT);
+
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_retrain,
+							   1.0, 20.0), 0);
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_lt_failures,
+							   1.0, 20.0), 0);
+
+		if (igt_get_dp_link_retrain_disabled(data->drm_fd,
+						     data->output)) {
+			igt_reset_connectors();
+			return;
+		}
+
+		igt_assert_f(igt_hotplug_detected(mon, 20),
+			     "Didn't get hotplug for force link training failure\n");
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-status",
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+
+		igt_assert_eq(link_status_value, DRM_MODE_LINK_STATUS_BAD);
+
+		igt_flush_uevents(mon);
+
+		if (is_mst) {
+			igt_assert_f(validate_modeset_mst_output(data,
+								 mst_outputs,
+								 &dp_mst_outputs,
+								 mst_modes,
+								 mst_fbs,
+								 mst_primarys),
+				     "MST modeset failed\n");
+		} else {
+			data->output->force_reprobe = true;
+			igt_output_refresh(data->output);
+			data->pipe = PIPE_A;
+			igt_assert_f(fit_modes_in_bw(data),
+				     "Unable to fit modes in bw\n");
+
+			igt_output_set_pipe(data->output, data->pipe);
+			mode = igt_output_get_mode(data->output);
+			igt_info("Mode %dx%d@%d on output %s\n",
+				 mode->hdisplay, mode->vdisplay,
+				 mode->vrefresh,
+				 igt_output_name(data->output));

tests/intel/kms_fallback.c line 432

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+			primary = igt_output_get_plane_type(data->output,
+							    DRM_PLANE_TYPE_PRIMARY);
+			igt_create_color_fb(data->drm_fd,
+					    mode->hdisplay,
+					    mode->vdisplay,
+					    DRM_FORMAT_XRGB8888,
+					    DRM_FORMAT_MOD_LINEAR,
+					    0.0, 1.0, 0.0, &fb);
+			igt_plane_set_fb(primary, &fb);
+		}

The above would be better in a separate function and make the MST and non-MST cases more unified. For instance setup_modeset_on_mst_outputs() looks quite similar to the above non-MST setup.

tests/intel/kms_fallback.c line 441

Quoted 9 lines
tests/intel/kms_fallback.c new file +9 -0
+
+		kmstest_set_connector_link_status(data->drm_fd,
+						  data->output->config.connector,
+						  DRM_MODE_LINK_STATUS_GOOD);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-status",

Could use the cached property name here instead of hard-coding it.

tests/intel/kms_fallback.c line 452

Quoted 11 lines
tests/intel/kms_fallback.c new file +11 -0
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+		igt_assert_eq(link_status_value, DRM_MODE_LINK_STATUS_GOOD);
+
+		curr_link_rate = igt_get_dp_link_rate_set_for_output(data->drm_fd, data->output);
+		curr_lane_count = igt_get_dp_lane_count_set_for_output(data->drm_fd, data->output);
+
+		igt_assert_f((curr_link_rate < prev_link_rate ||
+			     curr_lane_count < prev_lane_count) ||
+			     ((curr_link_rate == max_link_rate && curr_lane_count == max_lane_count) && --retries),
+			     "Fallback unsuccessful\n");

I wonder if having separate asserts would make it easier to parse the logs.

Quoted 7 lines
tests/intel/kms_fallback.c new file +7 -0
+
+		prev_link_rate = curr_link_rate;
+		prev_lane_count = curr_lane_count;
+	}
+}
+
+igt_main

tests/intel/kms_fallback.c line 469

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+{
+	data_t data = {};
+
+	igt_fixture {
+		data.drm_fd = drm_open_driver_master(DRIVER_INTEL |
+						     DRIVER_XE);
+		kmstest_set_vt_graphics_mode();
+		igt_display_require(&data.display, data.drm_fd);
+		igt_display_require_output(&data.display);
+		for_each_pipe(&data.display, data.pipe) {

One liners don't the { }.

tests/intel/kms_fallback.c line 479

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+			data.n_pipes++;
+		}
+	}
+
+	igt_subtest("dp-fallback") {
+		bool ran = false;
+		igt_output_t *output;
+
+		for_each_connected_output(&data.display, output) {
+

Extra w/s.

Quoted 18 lines
tests/intel/kms_fallback.c new file +18 -0
+			data.output = output;
+			if (!igt_has_force_link_training_failure_debugfs(data.drm_fd,
+								    data.output)) {
+				igt_info("Output %s unsupported\n", igt_output_name(data.output));
+				continue;
+			}
+
+			if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_DisplayPort) {
+				igt_info("Skipping output %s as it's not DP\n", output->name);
+				continue;
+			}
+
+			ran = true;
+
+			/*
+			 * Check output is MST
+			 */
+			if (igt_check_output_is_dp_mst(data.output)) {

tests/intel/kms_fallback.c line 507

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+				igt_info("Testing MST output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, true);
+			} else {
+				igt_info("Testing DP output %s\n",
+					 igt_output_name(data.output));
+				test_fallback(&data, false);
+			}
+		}
+		igt_require_f(ran, "No output supports fallback\n");

Would be better to have a separate function for the above.

Quoted 23 lines
tests/intel/kms_fallback.c new file +8 -0
+	}
+
+	igt_fixture {
+		igt_remove_fb(data.drm_fd, &data.fb);
+		igt_display_fini(&data.display);
+		close(data.drm_fd);
+	}
+}
tests/meson.build +1 -0
index 00556c9d6..86fab423b 100644
@@ -249,6 +249,7 @@ intel_kms_progs = [
 	'kms_dirtyfb',
 	'kms_draw_crc',
 	'kms_dsc',
+        'kms_fallback',
 	'kms_fb_coherency',
 	'kms_fbcon_fbt',
 	'kms_fence_pin_leak',
Signature · 1 line
2.34.1
#32 lore raw

RE: [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback

Hello Imre,

-----Original Message-----
From: Deak, Imre <[email protected]>
Sent: Tuesday, September 3, 2024 8:25 PM
To: Joshi, Kunal1 <[email protected]>
Cc: [email protected]
Subject: Re: [PATCH i-g-t 13/14] tests/intel/kms_dp_fallback: add test for validating fallback

Quoted 53 lines · Kunal Joshi

add test to valdiate fallback for DP connector, eDP subtest will be added later.

How does test validates fallback?
- test start by doing initial modeset on default mode (if connector is DP then we enable just that connector, if its DP-MST we enable all on the same topology)
- force link training failures and retrain until we reach lowest param or retrain is disabled
- expect hotplug and link-status to turn bad
- expect link params reduce after fallback

v2: add test for mst (imre)
refresh mode list (imre)
monitor got hotplugs (imre)
check link parameter are reduced (imre)

v3: call check_fn (Santosh)

v4: handle buggy lg monitor (Imre)
remove reset in between (Imre)

v5: fit modes wrt to bw in non-mst case as well

---
 tests/intel/kms_fallback.c | 515 +++++++++++++++++++++++++++++++++++++
 tests/meson.build          |   1 +
 2 files changed, 516 insertions(+)
 create mode 100644 tests/intel/kms_fallback.c
tests/intel/kms_fallback.c new file +15 -0
new file mode 100644 index 000000000..e97300c08
@@ -0,0 +1,515 @@
+/* SPDX-License-Identifier: MIT */
+/*
+ * Copyright (c) 2024 Intel Corporation  */
+
+/**
+ * TEST: kms fallback
+ * Category: Display
+ * Description: Test link training fallback for eDP/DP connectors
+ * Driver requirement: i915, xe
+ * Functionality: link training
+ * Mega feature: General Display Features
+ * Test category: functionality test
+ */
+
+#include <sys/types.h>

tests/intel/kms_fallback.c line 25

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+
+#include "igt.h"
+#include "igt_psr.h"
+
+/**
+ * SUBTEST: dp-fallback
+ * Description: Test fallback on DP connectors  */
+
+#define RETRAIN_COUNT 1
+#define LT_FAILURE_SAME_CAPS 1

This is not used. Maybe add a comment instead why 2 LT failure will lead to reducing the link params?
----------------------------------------------------------------------------------------------
Ok will remove LT_FAILURE_SAME_CAPS and add a comment for LT_FAILURE_REDUCED_CAPS

Quoted 301 lines
tests/intel/kms_fallback.c new file +301 -0
+#define LT_FAILURE_REDUCED_CAPS 2
+#define SPURIOUS_HPD_RETRY 3
+
+static int traversed_mst_outputs[IGT_MAX_PIPES];
+static int traversed_mst_output_count; typedef struct {
+	int drm_fd;
+	igt_display_t display;
+	drmModeModeInfo *mode;
+	igt_output_t *output;
+	enum pipe pipe;
+	struct igt_fb fb;
+	struct igt_plane *primary;
+	int n_pipes;
+} data_t;
+
+typedef int (*condition_check_fn)(int drm_fd, igt_output_t *output);
+
+IGT_TEST_DESCRIPTION("Test link training fallback");
+
+static const char *str_link_rate(enum dp_link_rate link_rate) {
+	switch (link_rate) {
+	case DP_LINK_RATE_162000:
+		return "1.62 Gbps";
+	case DP_LINK_RATE_216000:
+		return "2.16 Gbps";
+	case DP_LINK_RATE_243000:
+		return "2.43 Gbps";
+	case DP_LINK_RATE_270000:
+		return "2.70 Gbps";
+	case DP_LINK_RATE_324000:
+		return "3.24 Gbps";
+	case DP_LINK_RATE_432000:
+		return "4.32 Gbps";
+	case DP_LINK_RATE_540000:
+		return "5.40 Gbps";
+	case DP_LINK_RATE_675000:
+		return "6.75 Gbps";
+	case DP_LINK_RATE_810000:
+		return "8.10 Gbps";
+	case DP_LINK_RATE_1000000:
+		return "10.00 Gbps";
+	case DP_LINK_RATE_1350000:
+		return "13.50 Gbps";
+	case DP_LINK_RATE_2000000:
+		return "20.00 Gbps";
+	default:
+		igt_assert_f(0, "Invalid link rate %d\n", link_rate);
+	}
+}
+
+static const char *str_lane_count(enum dp_lane_count lane_count) {
+	switch (lane_count) {
+	case DP_LANE_COUNT_1:
+		return "1";
+	case DP_LANE_COUNT_2:
+		return "2";
+	case DP_LANE_COUNT_4:
+		return "4";
+	default:
+		igt_assert_f(0, "Invalid lane count %d\n", lane_count);
+	}
+}
+
+static void find_mst_outputs(int drm_fd, data_t *data,
+			     igt_output_t *output,
+			     igt_output_t **mst_outputs,
+			     int *num_mst_outputs)
+{
+	bool is_output_mst;
+	uint64_t path_blob_id;
+	igt_output_t *connector_output;
+	drmModePropertyPtr path_prop = NULL;
+	drmModePropertyPtr connector_path_prop = NULL;
+
+	igt_assert_f(output, "Invalid output\n");
+
+	/*
+	 * Check if given output is MST by checking if it has PATH property
+	 */
+	is_output_mst = kmstest_get_property(drm_fd,
+			output->config.connector->connector_id,
+			DRM_MODE_OBJECT_CONNECTOR, "PATH", NULL,
+			&path_blob_id, &path_prop);
+
+	if (!is_output_mst)
+		return;
+
+	/*
+	 * If output is MST check all other connected output which shares
+	 * same path and fill mst_outputs and num_mst_outputs
+	 */
+	for_each_connected_output(&data->display, connector_output) {
+
+		connector_path_prop = NULL;
+
+		kmstest_get_property(drm_fd,
+				     connector_output->config.connector->connector_id,
+				     DRM_MODE_OBJECT_CONNECTOR, "PATH",
+				     NULL, &path_blob_id,
+				     &connector_path_prop);
+
+		if (connector_path_prop && path_prop &&
+		    connector_path_prop->prop_id == path_prop->prop_id)
+			mst_outputs[(*num_mst_outputs)++] = connector_output;
+
+		if (connector_path_prop)
+			drmModeFreeProperty(connector_path_prop);
+	}
+	if (path_prop)
+		drmModeFreeProperty(path_prop);
+}
+
+static bool setup_mst_outputs(data_t *data, igt_output_t *mst_output[],
+			      int *dp_mst_outputs)
+{
+	int i;
+	igt_output_t *output;
+
+	igt_require_f(igt_check_output_is_dp_mst(data->output),
+		      "Not a valid MST connector\n");
+
+	/*
+	 * Check if this is already traversed
+	 */
+	for (i = 0; i < traversed_mst_output_count; i++)
+		if (traversed_mst_outputs[i] == data->output->config.connector->connector_id)
+			return false;
+
+	find_mst_outputs(data->drm_fd, data, data->output,
+			 mst_output, dp_mst_outputs);
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		output = mst_output[i];
+		traversed_mst_outputs[traversed_mst_output_count++] = output->config.connector->connector_id;
+		igt_info("Output %s is in same topology as %s\n",
+			 igt_output_name(output),
+			 igt_output_name(data->output));
+	}
+
+	return true;
+}
+
+static void setup_pipe_on_mst_outputs(data_t *data,
+				      igt_output_t *mst_output[],
+				      int *dp_mst_outputs)
+{
+	int i = 0;
+
+	igt_require_f(data->n_pipes >= *dp_mst_outputs,
+		      "Need %d pipes to assign to %d MST outputs\n",
+		      data->n_pipes, *dp_mst_outputs);
+
+	for_each_pipe(&data->display, data->pipe) {
+		if (i >= *dp_mst_outputs)
+			break;
+		igt_info("Setting pipe %s on output %s\n",
+			 kmstest_pipe_name(data->pipe),
+			 igt_output_name(mst_output[i]));
+		igt_output_set_pipe(mst_output[i++], data->pipe);
+	}
+}
+
+static void setup_modeset_on_mst_outputs(data_t *data,
+					 igt_output_t *mst_output[],
+					 int *dp_mst_outputs,
+					 drmModeModeInfo *mode[],
+					 struct igt_fb fb[],
+					 struct igt_plane *primary[])
+{
+	int i;
+
+	for (i = 0; i < *dp_mst_outputs; i++) {
+		mst_output[i]->force_reprobe = true;
+		igt_output_refresh(mst_output[i]);
+		mode[i] = igt_output_get_mode(mst_output[i]);
+		igt_info("Mode %dx%d@%d on output %s\n",
+			 mode[i]->hdisplay, mode[i]->vdisplay,
+			 mode[i]->vrefresh,
+			 igt_output_name(mst_output[i]));
+		primary[i] = igt_output_get_plane_type(mst_output[i],
+							DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode[i]->hdisplay,
+				    mode[i]->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb[i]);
+		igt_plane_set_fb(primary[i], &fb[i]);
+	}
+}
+
+static bool fit_modes_in_bw(data_t *data) {
+	bool found;
+	int ret;
+
+	if (!igt_display_try_commit2(&data->display, COMMIT_ATOMIC)) {
+		igt_info("Modes overridden\n");
+		found = igt_override_all_active_output_modes_to_fit_bw(&data->display);
+                igt_require_f(found,
+                              "No valid mode combo found for MST modeset\n");
+                ret = igt_display_try_commit2(&data->display, COMMIT_ATOMIC);
+                igt_require_f(ret == 0,
+                              "Commit failure during MST modeset\n");
+        }
+        return true;
+}
+
+static bool validate_modeset_mst_output(data_t *data,
+					igt_output_t *mst_output[],
+					int *dp_mst_outputs,
+					drmModeModeInfo *mode[],
+					struct igt_fb fb[],
+					struct igt_plane *primary[])
+{
+
+	igt_require_f(*dp_mst_outputs > 0, "No MST outputs found\n");
+	setup_pipe_on_mst_outputs(data, mst_output, dp_mst_outputs);
+	setup_modeset_on_mst_outputs(data, mst_output,
+				     dp_mst_outputs,
+				     mode, fb, primary);
+	igt_assert_f(fit_modes_in_bw(data), "Unable to fit modes in bw\n");
+	return true;
+}
+
+static bool setup_mst(data_t *data, bool is_mst,
+		      igt_output_t *mst_output[],
+		      int *dp_mst_outputs, drmModeModeInfo *mode[],
+		      struct igt_fb fb[], struct igt_plane *primary[]) {
+	bool ret;
+
+	*dp_mst_outputs = 0;
+	ret = setup_mst_outputs(data, mst_output, dp_mst_outputs);
+	if (!ret) {
+		igt_info("Skipping MST output %s as already tested\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	ret = validate_modeset_mst_output(data, mst_output,
+					  dp_mst_outputs, mode,
+					  fb, primary);
+	if (!ret) {
+		igt_info("Skipping MST output %s as validpipe/output combo not found\n",
+			 igt_output_name(data->output));
+		return false;
+	}
+
+	igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	return true;
+}
+
+static int check_condition_with_timeout(int drm_fd, igt_output_t *output,
+					condition_check_fn check_fn,
+					double interval, double timeout) {
+	struct timespec start_time, current_time;
+	double elapsed_time;
+
+	clock_gettime(CLOCK_MONOTONIC, &start_time);
+
+	while (1) {
+		if (check_fn(drm_fd, output) == 0) {
+			return 0;
+		}
+
+		clock_gettime(CLOCK_MONOTONIC, &current_time);
+		elapsed_time = (current_time.tv_sec - start_time.tv_sec) +
+			(current_time.tv_nsec - start_time.tv_nsec) / 1e9;
+
+		if (elapsed_time >= timeout) {
+			return -1;
+		}
+
+		usleep((useconds_t)(interval * 1000000));
+	}
+}
+
+static void test_fallback(data_t *data, bool is_mst) {
+	int dp_mst_outputs, retries;
+	igt_output_t *mst_outputs[IGT_MAX_PIPES];
+	enum dp_link_rate max_link_rate, curr_link_rate, prev_link_rate;
+	enum dp_lane_count max_lane_count, curr_lane_count, prev_lane_count;
+	uint32_t link_status_prop_id;
+	uint64_t link_status_value;
+	drmModeModeInfo *mst_modes[IGT_MAX_PIPES], *mode;
+	drmModePropertyPtr link_status_prop;
+	struct igt_fb mst_fbs[IGT_MAX_PIPES], fb;
+	struct igt_plane *mst_primarys[IGT_MAX_PIPES], *primary;
+	struct udev_monitor *mon;
+
+	igt_display_reset(&data->display);
+	retries = SPURIOUS_HPD_RETRY;
+
+	if (is_mst) {
+		if (!setup_mst(data, is_mst, mst_outputs,
+			       &dp_mst_outputs, mst_modes, mst_fbs,
+			       mst_primarys))
+			return;
+	} else {
+		data->pipe = PIPE_A;
+		igt_output_set_pipe(data->output, data->pipe);
+		mode = igt_output_get_mode(data->output);

tests/intel/kms_fallback.c line 345

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+		primary = igt_output_get_plane_type(data->output,
+						    DRM_PLANE_TYPE_PRIMARY);
+		igt_create_color_fb(data->drm_fd,
+				    mode->hdisplay, mode->vdisplay,
+				    DRM_FORMAT_XRGB8888,
+				    DRM_FORMAT_MOD_LINEAR, 0.0, 1.0, 0.0,
+				    &fb);
+		igt_plane_set_fb(primary, &fb);
+		igt_display_commit2(&data->display, COMMIT_ATOMIC);
+	}

Would be better to have a separate function for the above and make dp_mst_outputs more generic, also used for the non-MST case (adding to the array then only a single output).
----------------------------------------------------------------------------------------------
Ok sure will reuse the mst functions after renaming them

tests/intel/kms_fallback.c line 350

Quoted 5 lines
tests/intel/kms_fallback.c new file +5 -0
+
+	igt_info("Testing link training fallback on %s\n",
+		 igt_output_name(data->output));
+
+	igt_reset_link_params(data->drm_fd, data->output);

Could this be done before the above setup part? Then the modes chosen there should be based already on the updated link params and the commit would also retrain the link if needed.
----------------------------------------------------------------------------------------------
Ok sure will do as suggested

tests/intel/kms_fallback.c line 361

Quoted 12 lines
tests/intel/kms_fallback.c new file +12 -0
+	igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+						   data->output,
+						   igt_get_dp_pending_retrain,
+						   1.0, 20.0), 0);
+
+	max_link_rate = igt_get_dp_max_link_rate(data->drm_fd, data->output);
+	max_lane_count = igt_get_dp_max_lane_count(data->drm_fd, 
+data->output);
+
+	while (!igt_get_dp_link_retrain_disabled(data->drm_fd,
+						 data->output)) {
+

Extra w/s.
----------------------------------------------------------------------------------------------
Noted

tests/intel/kms_fallback.c line 356

Quoted 3 lines
tests/intel/kms_fallback.c new file +3 -0
+		prev_link_rate = igt_get_dp_link_rate_set_for_output(data->drm_fd, data->output);
+		prev_lane_count = 
+igt_get_dp_lane_count_set_for_output(data->drm_fd, data->output);

Moving these before the loop would avoid the duplication wrt. setting them at the end of the loop.
----------------------------------------------------------------------------------------------
Right will move this out of the loop

Quoted 59 lines
tests/intel/kms_fallback.c new file +59 -0
+
+		igt_info("Current link rate: %s, Current lane count: %s\n",
+			 str_link_rate(prev_link_rate),
+			 str_lane_count(prev_lane_count));
+		mon = igt_watch_uevents();
+		igt_force_lt_failure(data->drm_fd, data->output,
+				     LT_FAILURE_REDUCED_CAPS);
+		igt_force_link_retrain(data->drm_fd, data->output,
+				       RETRAIN_COUNT);
+
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_retrain,
+							   1.0, 20.0), 0);
+		igt_assert_eq(check_condition_with_timeout(data->drm_fd,
+							   data->output,
+							   igt_get_dp_pending_lt_failures,
+							   1.0, 20.0), 0);
+
+		if (igt_get_dp_link_retrain_disabled(data->drm_fd,
+						     data->output)) {
+			igt_reset_connectors();
+			return;
+		}
+
+		igt_assert_f(igt_hotplug_detected(mon, 20),
+			     "Didn't get hotplug for force link training failure\n");
+
+		kmstest_get_property(data->drm_fd,
+				data->output->config.connector->connector_id,
+				DRM_MODE_OBJECT_CONNECTOR, "link-status",
+				&link_status_prop_id, &link_status_value,
+				&link_status_prop);
+
+		igt_assert_eq(link_status_value, DRM_MODE_LINK_STATUS_BAD);
+
+		igt_flush_uevents(mon);
+
+		if (is_mst) {
+			igt_assert_f(validate_modeset_mst_output(data,
+								 mst_outputs,
+								 &dp_mst_outputs,
+								 mst_modes,
+								 mst_fbs,
+								 mst_primarys),
+				     "MST modeset failed\n");
+		} else {
+			data->output->force_reprobe = true;
+			igt_output_refresh(data->output);
+			data->pipe = PIPE_A;
+			igt_assert_f(fit_modes_in_bw(data),
+				     "Unable to fit modes in bw\n");
+
+			igt_output_set_pipe(data->output, data->pipe);
+			mode = igt_output_get_mode(data->output);
+			igt_info("Mode %dx%d@%d on output %s\n",
+				 mode->hdisplay, mode->vdisplay,
+				 mode->vrefresh,
+				 igt_output_name(data->output));

tests/intel/kms_fallback.c line 432

Quoted 10 lines
tests/intel/kms_fallback.c new file +10 -0
+			primary = igt_output_get_plane_type(data->output,
+							    DRM_PLANE_TYPE_PRIMARY);
+			igt_create_color_fb(data->drm_fd,
+					    mode->hdisplay,
+					    mode->vdisplay,
+					    DRM_FORMAT_XRGB8888,
+					    DRM_FORMAT_MOD_LINEAR,
+					    0.0, 1.0, 0.0, &fb);
+			igt_plane_set_fb(primary, &fb);
+		}

The above would be better in a separate function and make the MST and non-MST cases more unified. For instance setup_modeset_on_mst_outputs() looks quite similar to the above non-MST setup.[Joshi, Kunal1

#33 lore raw

PATCH 14/14 HAX: Do not merge

In reply to a message not in the archive
---
 tests/intel-ci/fast-feedback.testlist    | 1 +
 tests/intel-ci/xe-fast-feedback.testlist | 2 ++
 2 files changed, 3 insertions(+)
tests/intel-ci/fast-feedback.testlist +1 -0
index be0965110..7b84ccffc 100644
@@ -1,6 +1,7 @@
 # Try to load the driver if it's not available yet.
 igt@i915_module_load@load
 
+igt@kms_fallback@dp-fallback
 # Keep alphabetically sorted by default
 igt@core_auth@basic-auth
 igt@debugfs_test@read_all_entries
tests/intel-ci/xe-fast-feedback.testlist +2 -0
index 01b01dcf9..110675cd3 100644
@@ -1,6 +1,8 @@
 # Should be the first test
 igt@xe_module_load@load
 
+igt@kms_fallback@dp-fallback
+
 igt@fbdev@eof
 igt@fbdev@info
 igt@fbdev@nullptr
Signature · 1 line
2.34.1
#34 lore raw

✗ CI.xeBAT: failure for series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count

In reply to a message not in the archive
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count
URL : https://patchwork.freedesktop.org/series/137761/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_7990_BAT -> XEIGTPW_11633_BAT
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_11633_BAT absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_11633_BAT, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (9 -> 9)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_11633_BAT:

### IGT changes ###

#### Possible regressions ####

* igt@kms_fallback@dp-fallback (NEW):
- {bat-bmg-2}: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-bmg-2/igt@[email protected]
- bat-adlp-7: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-adlp-7/igt@[email protected]
- bat-bmg-1: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-bmg-1/igt@[email protected]
- bat-lnl-2: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-lnl-2/igt@[email protected]
- bat-adlp-vf: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-adlp-vf/igt@[email protected]
- bat-lnl-1: NOTRUN -> [SKIP][6]
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-lnl-1/igt@[email protected]

New tests
---------

New tests have been introduced between XEIGT_7990_BAT and XEIGTPW_11633_BAT:

### New IGT tests (1) ###

* igt@kms_fallback@dp-fallback:
- Statuses : 1 pass(s) 8 skip(s)
- Exec time: [0.0, 11.87] s

Known issues
------------

Here are the changes found in XEIGTPW_11633_BAT that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_fallback@dp-fallback (NEW):
- bat-atsm-2: NOTRUN -> [SKIP][7] ([Intel XE#1024])
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-atsm-2/igt@[email protected]
- bat-pvc-2: NOTRUN -> [SKIP][8] ([Intel XE#1024])
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/bat-pvc-2/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#1024]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1024

Build changes
-------------

* IGT: IGT_7990 -> IGTPW_11633
* Linux: xe-1822-411a047925bb7e169a075a2ddfb63ba96f26a8c8 -> xe-1823-5626fe5d6eeb0949727861375b27d67ee71feaa7

IGTPW_11633: 11633
IGT_7990: 9ca5ff0afa3636478b6ba5a97e5ba440cfb2e55e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-1822-411a047925bb7e169a075a2ddfb63ba96f26a8c8: 411a047925bb7e169a075a2ddfb63ba96f26a8c8 xe-1823-5626fe5d6eeb0949727861375b27d67ee71feaa7: 5626fe5d6eeb0949727861375b27d67ee71feaa7

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/index.html

#35 lore raw

✗ Fi.CI.BAT: failure for series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count

In reply to a message not in the archive
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count
URL : https://patchwork.freedesktop.org/series/137761/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_15288 -> IGTPW_11633
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with IGTPW_11633 absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in IGTPW_11633, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/index.html

Participating hosts (38 -> 38)
------------------------------

Additional (3): fi-kbl-8809g fi-cfl-8109u fi-elk-e7500
Missing (3): fi-blb-e6850 bat-dg2-11 fi-snb-2520m

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in IGTPW_11633:

### IGT changes ###

#### Possible regressions ####

* igt@kms_fallback@dp-fallback (NEW):
- fi-rkl-11600: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-rkl-11600/igt@[email protected]
- fi-tgl-1115g4: NOTRUN -> [SKIP][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-tgl-1115g4/igt@[email protected]
- bat-arls-2: NOTRUN -> [SKIP][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-arls-2/igt@[email protected]
- bat-mtlp-8: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-mtlp-8/igt@[email protected]
- bat-jsl-1: NOTRUN -> [SKIP][5]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-jsl-1/igt@[email protected]
- bat-arls-1: NOTRUN -> [SKIP][6]
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-arls-1/igt@[email protected]
- bat-arlh-2: NOTRUN -> [SKIP][7]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-arlh-2/igt@[email protected]
- bat-dg1-7: NOTRUN -> [SKIP][8]
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-dg1-7/igt@[email protected]
- bat-twl-2: NOTRUN -> [SKIP][9]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-twl-2/igt@[email protected]
- bat-rpls-4: NOTRUN -> [SKIP][10]
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-rpls-4/igt@[email protected]
- bat-twl-1: NOTRUN -> [SKIP][11]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-twl-1/igt@[email protected]
- bat-dg2-14: NOTRUN -> [SKIP][12]
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-dg2-14/igt@[email protected]
- bat-rplp-1: NOTRUN -> [SKIP][13]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-rplp-1/igt@[email protected]

New tests
---------

New tests have been introduced between CI_DRM_15288 and IGTPW_11633:

### New IGT tests (1) ###

* igt@kms_fallback@dp-fallback:
- Statuses : 8 pass(s) 29 skip(s)
- Exec time: [0.0, 16.34] s

Known issues
------------

Here are the changes found in IGTPW_11633 that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@gem_huc_copy@huc-copy:
- fi-cfl-8109u: NOTRUN -> [SKIP][14] ([i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-cfl-8109u/igt@[email protected]
- fi-kbl-8809g: NOTRUN -> [SKIP][15] ([i915#2190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-kbl-8809g/igt@[email protected]

* igt@gem_lmem_swapping@basic:
- fi-kbl-8809g: NOTRUN -> [SKIP][16] ([i915#4613]) +3 other tests skip
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-kbl-8809g/igt@[email protected]

* igt@gem_lmem_swapping@verify-random:
- fi-cfl-8109u: NOTRUN -> [SKIP][17] ([i915#4613]) +3 other tests skip
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-cfl-8109u/igt@[email protected]

* igt@i915_selftest@live@hangcheck:
- bat-arls-2: [PASS][18] -> [DMESG-WARN][19] ([i915#11349])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15288/bat-arls-2/igt@i915_selftest@[email protected]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-arls-2/igt@i915_selftest@[email protected]

* igt@kms_fallback@dp-fallback (NEW):
- fi-cfl-guc: NOTRUN -> [SKIP][20]
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-cfl-guc/igt@[email protected]
- bat-mtlp-6: NOTRUN -> [SKIP][21] ([i915#9792])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-mtlp-6/igt@[email protected]
- bat-dg2-9: NOTRUN -> [SKIP][22] ([i915#9197])
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-dg2-9/igt@[email protected]
- fi-kbl-x1275: NOTRUN -> [SKIP][23]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-kbl-x1275/igt@[email protected]
- bat-adlp-11: NOTRUN -> [SKIP][24] ([i915#10470])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-adlp-11/igt@[email protected]
- fi-ivb-3770: NOTRUN -> [SKIP][25]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-ivb-3770/igt@[email protected]
- fi-kbl-guc: NOTRUN -> [SKIP][26]
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-kbl-guc/igt@[email protected]
- fi-ilk-650: NOTRUN -> [SKIP][27]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-ilk-650/igt@[email protected]
- fi-bsw-n3050: NOTRUN -> [SKIP][28]
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-bsw-n3050/igt@[email protected]
- fi-pnv-d510: NOTRUN -> [SKIP][29]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-pnv-d510/igt@[email protected]
- fi-glk-j4005: NOTRUN -> [SKIP][30]
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-glk-j4005/igt@[email protected]
- fi-cfl-8700k: NOTRUN -> [SKIP][31]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-cfl-8700k/igt@[email protected]
- bat-kbl-2: NOTRUN -> [SKIP][32]
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-kbl-2/igt@[email protected]
- bat-adlm-1: NOTRUN -> [SKIP][33] ([i915#9900])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/bat-adlm-1/igt@[email protected]

* igt@kms_force_connector_basic@force-load-detect:
- fi-kbl-8809g: NOTRUN -> [SKIP][34] +31 other tests skip
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-kbl-8809g/igt@[email protected]

* igt@kms_pm_backlight@basic-brightness:
- fi-cfl-8109u: NOTRUN -> [SKIP][35] +11 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-cfl-8109u/igt@[email protected]

* igt@kms_pm_rpm@basic-pci-d3-state:
- fi-elk-e7500: NOTRUN -> [SKIP][36] +25 other tests skip
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/fi-elk-e7500/igt@[email protected]

[i915#10470]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10470
[i915#11349]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11349
[i915#2190]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/2190
[i915#4613]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/4613
[i915#9197]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197
[i915#9792]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9792
[i915#9900]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9900

Build changes
-------------

* CI: CI-20190529 -> None
* IGT: IGT_7990 -> IGTPW_11633

CI-20190529: 20190529
CI_DRM_15288: 5626fe5d6eeb0949727861375b27d67ee71feaa7 @ git://anongit.freedesktop.org/gfx-ci/linux
IGTPW_11633: 11633
IGT_7990: 9ca5ff0afa3636478b6ba5a97e5ba440cfb2e55e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_11633/index.html

#36 lore raw

✗ CI.xeFULL: failure for series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count

In reply to a message not in the archive
== Series Details ==

== Series Details ==

Series: series starting with [i-g-t,01/14] lib/igt_kms: add enum for link rate and lane count
URL : https://patchwork.freedesktop.org/series/137761/
State : failure

== Summary ==

CI Bug Log - changes from XEIGT_7990_full -> XEIGTPW_11633_full
====================================================

Summary
-------

**FAILURE**

Serious unknown changes coming with XEIGTPW_11633_full absolutely need to be verified manually.

If you think the reported changes have nothing to do with the changes
introduced in XEIGTPW_11633_full, please notify your bug team ([email protected]) to allow them to document this new failure mode, which will reduce false positives in CI.

Participating hosts (4 -> 4)
------------------------------

No changes in participating hosts

Possible new issues
-------------------

Here are the unknown changes that may have been introduced in XEIGTPW_11633_full:

### IGT changes ###

#### Possible regressions ####

* igt@kms_fallback@dp-fallback (NEW):
- shard-lnl: NOTRUN -> [SKIP][1]
[1]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@[email protected]

* igt@xe_drm_fdinfo@drm-most-busy-idle-check-all:
- shard-lnl: [PASS][2] -> [FAIL][3]
[2]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-6/igt@[email protected]
[3]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]
- shard-dg2-set2: [PASS][4] -> [FAIL][5]
[4]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[5]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

#### Warnings ####

* igt@kms_ccs@bad-rotation-90-4-tiled-lnl-ccs:
- shard-dg2-set2: [SKIP][6] ([Intel XE#1201]) -> [SKIP][7] +2 other tests skip
[6]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[7]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

#### Suppressed ####

The following results come from untrusted machines, tests, or statuses. They do not affect the overall result.

* igt@kms_async_flips@crc@pipe-a-dp-2:
- {shard-bmg}: [FAIL][8] ([Intel XE#1656]) -> [DMESG-FAIL][9]
[8]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-1/igt@kms_async_flips@[email protected]
[9]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-7/igt@kms_async_flips@[email protected]

* igt@kms_flip@2x-flip-vs-absolute-wf_vblank:
- {shard-bmg}: [PASS][10] -> [INCOMPLETE][11] +1 other test incomplete
[10]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-1/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html
[11]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-7/igt@kms_flip@2x-flip-vs-absolute-wf_vblank.html

New tests
---------

New tests have been introduced between XEIGT_7990_full and XEIGTPW_11633_full:

### New IGT tests (1) ###

* igt@kms_fallback@dp-fallback:
- Statuses : 2 pass(s) 1 skip(s)
- Exec time: [0.0, 11.46] s

Known issues
------------

Here are the changes found in XEIGTPW_11633_full that come from known issues:

### IGT changes ###

#### Issues hit ####

* igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
- shard-lnl: NOTRUN -> [SKIP][12] ([Intel XE#1466])
[12]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

* igt@kms_async_flips@async-flip-with-page-flip-events@pipe-a-edp-1-linear:
- shard-lnl: [PASS][13] -> [FAIL][14] ([Intel XE#911]) +3 other tests fail
[13]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-8/igt@kms_async_flips@[email protected]
[14]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@kms_async_flips@[email protected]

* igt@kms_atomic_transition@plane-all-modeset-transition-internal-panels@pipe-a-edp-1:
- shard-lnl: [PASS][15] -> [FAIL][16] ([Intel XE#1426]) +1 other test fail
[15]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-4/igt@kms_atomic_transition@[email protected]
[16]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@kms_atomic_transition@[email protected]

* igt@kms_big_fb@4-tiled-64bpp-rotate-180:
- shard-lnl: [PASS][17] -> [FAIL][18] ([Intel XE#1659])
[17]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-8/igt@[email protected]
[18]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-lnl: NOTRUN -> [DMESG-WARN][19] ([Intel XE#1725])
[19]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@[email protected]

* igt@kms_big_fb@linear-64bpp-rotate-270:
- shard-dg2-set2: NOTRUN -> [SKIP][20] ([Intel XE#1201] / [Intel XE#316])
[20]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@kms_big_fb@x-tiled-64bpp-rotate-90:
- shard-lnl: NOTRUN -> [SKIP][21] ([Intel XE#1407])
[21]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

* igt@kms_big_fb@yf-tiled-max-hw-stride-64bpp-rotate-0-async-flip:
- shard-lnl: NOTRUN -> [SKIP][22] ([Intel XE#1124]) +6 other tests skip
[22]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-lnl: NOTRUN -> [SKIP][23] ([Intel XE#346])
[23]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@[email protected]

* igt@kms_bw@linear-tiling-2-displays-2160x1440p:
- shard-lnl: NOTRUN -> [SKIP][24] ([Intel XE#367]) +1 other test skip
[24]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-mc-ccs:
- shard-dg2-set2: NOTRUN -> [SKIP][25] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) +5 other tests skip
[25]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_ccs@bad-aux-stride-y-tiled-gen12-mc-ccs@pipe-c-hdmi-a-6:
- shard-dg2-set2: NOTRUN -> [SKIP][26] ([Intel XE#1201] / [Intel XE#787]) +20 other tests skip
[26]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@kms_ccs@[email protected]

* igt@kms_ccs@random-ccs-data-4-tiled-mtl-rc-ccs:
- shard-lnl: NOTRUN -> [SKIP][27] ([Intel XE#1399]) +9 other tests skip
[27]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@[email protected]

* igt@kms_cdclk@mode-transition-all-outputs:
- shard-lnl: NOTRUN -> [SKIP][28] ([Intel XE#314])
[28]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-dg2-set2: NOTRUN -> [SKIP][29] ([Intel XE#1201] / [Intel XE#373]) +1 other test skip
[29]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_chamelium_hpd@hdmi-hpd-storm:
- shard-lnl: NOTRUN -> [SKIP][30] ([Intel XE#373]) +4 other tests skip
[30]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-32x10:
- shard-lnl: NOTRUN -> [SKIP][31] ([Intel XE#1424])
[31]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

* igt@kms_cursor_crc@cursor-random-32x10:
- shard-dg2-set2: NOTRUN -> [SKIP][32] ([Intel XE#1201] / [Intel XE#455])
[32]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-lnl: NOTRUN -> [SKIP][33] ([Intel XE#309])
[33]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

* igt@kms_feature_discovery@chamelium:
- shard-lnl: NOTRUN -> [SKIP][34] ([Intel XE#701])
[34]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@[email protected]

* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-lnl: NOTRUN -> [SKIP][35] ([Intel XE#1421]) +3 other tests skip
[35]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling:
- shard-lnl: NOTRUN -> [SKIP][36] ([Intel XE#1397] / [Intel XE#1745])
[36]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling.html

* igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode:
- shard-lnl: NOTRUN -> [SKIP][37] ([Intel XE#1397])
[37]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@kms_flip_scaled_crc@flip-32bpp-4tile-to-64bpp-4tile-downscaling@pipe-a-default-mode.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling:
- shard-lnl: NOTRUN -> [SKIP][38] ([Intel XE#1401] / [Intel XE#1745]) +1 other test skip
[38]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling.html

* igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode:
- shard-lnl: NOTRUN -> [SKIP][39] ([Intel XE#1401]) +1 other test skip
[39]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-7/igt@kms_flip_scaled_crc@flip-32bpp-ytile-to-64bpp-ytile-downscaling@pipe-a-default-mode.html

* igt@kms_frontbuffer_tracking@drrs-suspend:
- shard-dg2-set2: NOTRUN -> [SKIP][40] ([Intel XE#1201] / [Intel XE#651]) +3 other tests skip
[40]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrs-rgb101010-draw-mmap-wc:
- shard-lnl: NOTRUN -> [SKIP][41] ([Intel XE#651]) +10 other tests skip
[41]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][42] ([Intel XE#1201] / [Intel XE#653]) +1 other test skip
[42]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-434/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render:
- shard-lnl: NOTRUN -> [SKIP][43] ([Intel XE#656]) +26 other tests skip
[43]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@kms_frontbuffer_tracking@psr-2p-scndscrn-pri-indfb-draw-render.html

* igt@kms_getfb@getfb-reject-ccs:
- shard-lnl: NOTRUN -> [SKIP][44] ([Intel XE#605])
[44]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@[email protected]

* igt@kms_plane@plane-position-hole-dpms@pipe-a-plane-1:
- shard-lnl: [PASS][45] -> [DMESG-WARN][46] ([Intel XE#324]) +2 other tests dmesg-warn
[45]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-1/igt@kms_plane@[email protected]
[46]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@kms_plane@[email protected]

* igt@kms_plane_scaling@intel-max-src-size@pipe-a-hdmi-a-6:
- shard-dg2-set2: [PASS][47] -> [FAIL][48] ([Intel XE#361]) +2 other tests fail
[47]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@kms_plane_scaling@[email protected]
[48]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-5-with-rotation@pipe-b-edp-1:
- shard-lnl: NOTRUN -> [SKIP][49] ([Intel XE#498]) +3 other tests skip
[49]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-upscale-20x20-downscale-factor-0-5@pipe-b-edp-1:
- shard-lnl: NOTRUN -> [SKIP][50] ([Intel XE#2318]) +3 other tests skip
[50]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_dc@dc3co-vpb-simulation:
- shard-lnl: NOTRUN -> [SKIP][51] ([Intel XE#736])
[51]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

* igt@kms_pm_dc@dc5-psr:
- shard-lnl: [PASS][52] -> [FAIL][53] ([Intel XE#718])
[52]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-7/igt@[email protected]
[53]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@[email protected]

* igt@kms_pm_rpm@modeset-non-lpsp-stress:
- shard-lnl: NOTRUN -> [SKIP][54] ([Intel XE#1439])
[54]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

* igt@kms_psr2_sf@overlay-primary-update-sf-dmg-area:
- shard-dg2-set2: NOTRUN -> [SKIP][55] ([Intel XE#1489])
[55]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr2_su@page_flip-nv12:
- shard-dg2-set2: NOTRUN -> [SKIP][56] ([Intel XE#1122] / [Intel XE#1201])
[56]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-434/igt@kms_psr2_su@page_flip-nv12.html

* igt@kms_psr2_su@page_flip-xrgb8888:
- shard-lnl: NOTRUN -> [SKIP][57] ([Intel XE#1128])
[57]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@kms_psr2_su@page_flip-xrgb8888.html

* igt@kms_psr@pr-sprite-plane-move:
- shard-lnl: NOTRUN -> [SKIP][58] ([Intel XE#1406]) +2 other tests skip
[58]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@[email protected]

* igt@kms_psr@psr-cursor-blt:
- shard-dg2-set2: NOTRUN -> [SKIP][59] ([Intel XE#1201] / [Intel XE#929])
[59]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-434/igt@[email protected]

* igt@kms_rotation_crc@sprite-rotation-90-pos-100-0:
- shard-lnl: NOTRUN -> [SKIP][60] ([Intel XE#1437])
[60]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-none:
- shard-lnl: NOTRUN -> [SKIP][61] ([Intel XE#374] / [Intel XE#599])
[61]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@[email protected]

* igt@kms_scaling_modes@scaling-mode-none@pipe-a-edp-1:
- shard-lnl: NOTRUN -> [SKIP][62] ([Intel XE#374]) +2 other tests skip
[62]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@kms_scaling_modes@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-c-hdmi-a-6:
- shard-dg2-set2: [PASS][63] -> [FAIL][64] ([Intel XE#899])
[63]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@kms_universal_plane@[email protected]
[64]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@kms_universal_plane@[email protected]

* igt@kms_vrr@flip-basic:
- shard-lnl: NOTRUN -> [FAIL][65] ([Intel XE#2443]) +1 other test fail
[65]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@[email protected]

* igt@kms_vrr@negative-basic:
- shard-lnl: NOTRUN -> [SKIP][66] ([Intel XE#1499] / [Intel XE#599])
[66]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@[email protected]

* igt@sriov_basic@enable-vfs-autoprobe-off:
- shard-dg2-set2: NOTRUN -> [SKIP][67] ([Intel XE#1091] / [Intel XE#1201])
[67]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-434/igt@[email protected]

* igt@xe_evict@evict-beng-threads-large-multi-vm:
- shard-lnl: NOTRUN -> [SKIP][68] ([Intel XE#688]) +5 other tests skip
[68]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@[email protected]

* igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-rebind:
- shard-lnl: NOTRUN -> [SKIP][69] ([Intel XE#1392]) +4 other tests skip
[69]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-3/igt@xe_exec_basic@multigpu-many-execqueues-many-vm-bindexecqueue-userptr-rebind.html

* igt@xe_exec_fault_mode@many-execqueues-invalid-userptr-fault:
- shard-dg2-set2: NOTRUN -> [SKIP][70] ([Intel XE#1201] / [Intel XE#288]) +1 other test skip
[70]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit:
- shard-lnl: NOTRUN -> [SKIP][71] ([Intel XE#2229])
[71]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-6/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html

* igt@xe_oa@closed-fd-and-unmapped-access:
- shard-dg2-set2: NOTRUN -> [SKIP][72] ([Intel XE#1201] / [Intel XE#2541]) +1 other test skip
[72]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@[email protected]

* igt@xe_pat@pat-index-xelp:
- shard-lnl: NOTRUN -> [SKIP][73] ([Intel XE#977])
[73]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

* igt@xe_pm@d3hot-mmap-vram:
- shard-lnl: NOTRUN -> [SKIP][74] ([Intel XE#1948])
[74]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@[email protected]

* igt@xe_pm@s3-d3hot-basic-exec:
- shard-dg2-set2: [PASS][75] -> [DMESG-WARN][76] ([Intel XE#1551] / [Intel XE#569])
[75]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[76]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@xe_pm@s4-basic:
- shard-dg2-set2: [PASS][77] -> [DMESG-WARN][78] ([Intel XE#2019]) +1 other test dmesg-warn
[77]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@[email protected]
[78]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-434/igt@[email protected]

* igt@xe_pm@s4-mocs:
- shard-dg2-set2: [PASS][79] -> [DMESG-WARN][80] ([Intel XE#2280])
[79]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[80]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@[email protected]

* igt@xe_query@multigpu-query-invalid-size:
- shard-lnl: NOTRUN -> [SKIP][81] ([Intel XE#944]) +1 other test skip
[81]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

#### Possible fixes ####

* igt@kms_atomic_transition@plane-all-modeset-transition@pipe-a-hdmi-a-6:
- shard-dg2-set2: [FAIL][82] ([Intel XE#1426]) -> [PASS][83] +1 other test pass
[82]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@kms_atomic_transition@[email protected]
[83]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@kms_atomic_transition@[email protected]

* igt@kms_big_fb@4-tiled-max-hw-stride-64bpp-rotate-0-hflip:
- shard-lnl: [FAIL][84] ([Intel XE#1659]) -> [PASS][85]
[84]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-5/igt@[email protected]
[85]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-4/igt@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs:
- {shard-bmg}: [FAIL][86] ([Intel XE#2436]) -> [PASS][87] +1 other test pass
[86]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-3/igt@[email protected]
[87]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-3/igt@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-bmg-ccs@pipe-c-dp-2:
- {shard-bmg}: [FAIL][88] -> [PASS][89]
[88]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-3/igt@kms_ccs@[email protected]
[89]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-3/igt@kms_ccs@[email protected]

* igt@kms_cursor_crc@cursor-suspend:
- shard-dg2-set2: [DMESG-WARN][90] ([Intel XE#1551]) -> [PASS][91] +1 other test pass
[90]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[91]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_flip@2x-flip-vs-panning-interruptible@cd-dp2-hdmi-a3:
- {shard-bmg}: [DMESG-WARN][92] ([Intel XE#877]) -> [PASS][93] +6 other tests pass
[92]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-6/igt@kms_flip@[email protected]
[93]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-4/igt@kms_flip@[email protected]

* igt@kms_flip@flip-vs-absolute-wf_vblank:
- shard-lnl: [FAIL][94] ([Intel XE#886]) -> [PASS][95] +2 other tests pass
[94]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-3/igt@kms_flip@flip-vs-absolute-wf_vblank.html
[95]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-8/igt@kms_flip@flip-vs-absolute-wf_vblank.html

* igt@kms_flip@flip-vs-absolute-wf_vblank@c-hdmi-a3:
- {shard-bmg}: [INCOMPLETE][96] -> [PASS][97] +2 other tests pass
[96]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-5/igt@kms_flip@[email protected]
[97]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-8/igt@kms_flip@[email protected]

* igt@kms_hdr@invalid-hdr:
- {shard-bmg}: [SKIP][98] ([Intel XE#1503]) -> [PASS][99]
[98]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-1/igt@[email protected]
[99]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-3/igt@[email protected]

* igt@kms_plane_cursor@overlay:
- shard-dg2-set2: [INCOMPLETE][100] ([Intel XE#1195]) -> [PASS][101] +2 other tests pass
[100]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[101]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr@fbc-psr-suspend:
- shard-lnl: [INCOMPLETE][102] -> [PASS][103]
[102]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-4/igt@[email protected]
[103]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@[email protected]

* igt@kms_psr@fbc-psr-suspend@edp-1:
- shard-lnl: [INCOMPLETE][104] ([Intel XE#2497]) -> [PASS][105]
[104]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-4/igt@kms_psr@[email protected]
[105]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-2/igt@kms_psr@[email protected]

* igt@kms_psr@psr2-cursor-plane-move@edp-1:
- shard-lnl: [FAIL][106] ([Intel XE#1649]) -> [PASS][107] +1 other test pass
[106]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-5/igt@kms_psr@[email protected]
[107]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-7/igt@kms_psr@[email protected]

* igt@kms_universal_plane@cursor-fb-leak:
- {shard-bmg}: [FAIL][108] ([Intel XE#899]) -> [PASS][109] +2 other tests pass
[108]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-5/igt@[email protected]
[109]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-5/igt@[email protected]

* igt@kms_universal_plane@cursor-fb-leak@pipe-d-hdmi-a-6:
- shard-dg2-set2: [FAIL][110] ([Intel XE#899]) -> [PASS][111]
[110]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@kms_universal_plane@[email protected]
[111]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@kms_universal_plane@[email protected]

* igt@kms_vrr@max-min:
- shard-lnl: [FAIL][112] ([Intel XE#2443]) -> [PASS][113] +1 other test pass
[112]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-1/igt@[email protected]
[113]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-1/igt@[email protected]

* igt@xe_evict@evict-beng-threads-large:
- {shard-bmg}: [TIMEOUT][114] ([Intel XE#1473]) -> [PASS][115] +1 other test pass
[114]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-1/igt@[email protected]
[115]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-7/igt@[email protected]
- shard-dg2-set2: [TIMEOUT][116] ([Intel XE#1473]) -> [PASS][117]
[116]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[117]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@[email protected]

* igt@xe_exec_reset@parallel-gt-reset:
- {shard-bmg}: [TIMEOUT][118] ([Intel XE#2105]) -> [PASS][119]
[118]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-2/igt@[email protected]
[119]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-1/igt@[email protected]
- shard-dg2-set2: [TIMEOUT][120] ([Intel XE#2105]) -> [PASS][121]
[120]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[121]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@xe_live_ktest@xe_bo:
- shard-dg2-set2: [SKIP][122] ([Intel XE#1192]) -> [PASS][123]
[122]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@xe_live_ktest@xe_bo.html
[123]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@xe_live_ktest@xe_bo.html

* igt@xe_oa@oa-regs-whitelisted:
- {shard-bmg}: [FAIL][124] ([Intel XE#2514]) -> [PASS][125]
[124]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-bmg-4/igt@[email protected]
[125]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-bmg-3/igt@[email protected]

* igt@xe_pm@s4-basic-exec:
- shard-lnl: [ABORT][126] ([Intel XE#1358] / [Intel XE#1607] / [Intel XE#1794]) -> [PASS][127] +1 other test pass
[126]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-2/igt@[email protected]
[127]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-7/igt@[email protected]

* igt@xe_pm@s4-d3hot-basic-exec:
- shard-dg2-set2: [DMESG-WARN][128] ([Intel XE#2019]) -> [PASS][129]
[128]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[129]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@xe_pm@s4-vm-bind-unbind-all:
- shard-lnl: [ABORT][130] ([Intel XE#1794]) -> [PASS][131]
[130]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-2/igt@[email protected]
[131]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-7/igt@[email protected]

* igt@xe_pm_residency@toggle-gt-c6:
- shard-lnl: [FAIL][132] ([Intel XE#958]) -> [PASS][133]
[132]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-lnl-8/igt@[email protected]
[133]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-lnl-5/igt@[email protected]

#### Warnings ####

* igt@kms_big_fb@4-tiled-32bpp-rotate-90:
- shard-dg2-set2: [SKIP][134] ([Intel XE#1201] / [Intel XE#316]) -> [SKIP][135] ([Intel XE#316]) +1 other test skip
[134]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[135]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_big_fb@linear-32bpp-rotate-90:
- shard-dg2-set2: [SKIP][136] ([Intel XE#316]) -> [SKIP][137] ([Intel XE#1201] / [Intel XE#316]) +2 other tests skip
[136]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[137]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_big_fb@y-tiled-addfb:
- shard-dg2-set2: [SKIP][138] ([Intel XE#1201] / [Intel XE#619]) -> [SKIP][139] ([Intel XE#619])
[138]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-463/igt@[email protected]
[139]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-dg2-set2: [SKIP][140] ([Intel XE#1124]) -> [SKIP][141] ([Intel XE#1124] / [Intel XE#1201]) +7 other tests skip
[140]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[141]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@kms_big_fb@yf-tiled-64bpp-rotate-180:
- shard-dg2-set2: [SKIP][142] ([Intel XE#1124] / [Intel XE#1201]) -> [SKIP][143] ([Intel XE#1124]) +9 other tests skip
[142]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[143]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_big_fb@yf-tiled-addfb-size-offset-overflow:
- shard-dg2-set2: [SKIP][144] ([Intel XE#607]) -> [SKIP][145] ([Intel XE#1201] / [Intel XE#607])
[144]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[145]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@[email protected]

* igt@kms_big_joiner@invalid-modeset:
- shard-dg2-set2: [SKIP][146] ([Intel XE#1201] / [Intel XE#346]) -> [SKIP][147] ([Intel XE#346])
[146]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@[email protected]
[147]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_bw@connected-linear-tiling-3-displays-1920x1080p:
- shard-dg2-set2: [SKIP][148] ([Intel XE#1201] / [Intel XE#2191]) -> [SKIP][149] ([Intel XE#2191])
[148]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[149]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_bw@connected-linear-tiling-4-displays-1920x1080p:
- shard-dg2-set2: [SKIP][150] ([Intel XE#2191]) -> [SKIP][151] ([Intel XE#1201] / [Intel XE#2191])
[150]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[151]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_bw@linear-tiling-1-displays-2160x1440p:
- shard-dg2-set2: [SKIP][152] ([Intel XE#367]) -> [SKIP][153] ([Intel XE#1201] / [Intel XE#367])
[152]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[153]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@kms_bw@linear-tiling-4-displays-2560x1440p:
- shard-dg2-set2: [SKIP][154] ([Intel XE#1201] / [Intel XE#367]) -> [SKIP][155] ([Intel XE#367]) +2 other tests skip
[154]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[155]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_ccs@bad-rotation-90-y-tiled-gen12-mc-ccs@pipe-d-dp-4:
- shard-dg2-set2: [SKIP][156] ([Intel XE#455] / [Intel XE#787]) -> [SKIP][157] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) +13 other tests skip
[156]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_ccs@[email protected]
[157]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-primary-basic-y-tiled-gen12-rc-ccs-cc@pipe-a-dp-4:
- shard-dg2-set2: [SKIP][158] ([Intel XE#787]) -> [SKIP][159] ([Intel XE#1201] / [Intel XE#787]) +48 other tests skip
[158]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_ccs@[email protected]
[159]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@kms_ccs@[email protected]

* igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs-cc@pipe-c-hdmi-a-6:
- shard-dg2-set2: [SKIP][160] ([Intel XE#1201] / [Intel XE#787]) -> [SKIP][161] ([Intel XE#787]) +48 other tests skip
[160]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs-cc@pipe-c-hdmi-a-6.html
[161]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@kms_ccs@crc-sprite-planes-basic-4-tiled-mtl-rc-ccs-cc@pipe-c-hdmi-a-6.html

* igt@kms_ccs@random-ccs-data-4-tiled-mtl-mc-ccs:
- shard-dg2-set2: [SKIP][162] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#787]) -> [SKIP][163] ([Intel XE#455] / [Intel XE#787]) +13 other tests skip
[162]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[163]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_cdclk@mode-transition@pipe-d-dp-4:
- shard-dg2-set2: [SKIP][164] ([Intel XE#314]) -> [SKIP][165] ([Intel XE#1201] / [Intel XE#314]) +3 other tests skip
[164]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_cdclk@[email protected]
[165]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@kms_cdclk@[email protected]

* igt@kms_chamelium_audio@dp-audio:
- shard-dg2-set2: [SKIP][166] ([Intel XE#1201] / [Intel XE#373]) -> [SKIP][167] ([Intel XE#373]) +7 other tests skip
[166]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[167]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_chamelium_color@ctm-red-to-blue:
- shard-dg2-set2: [SKIP][168] ([Intel XE#1201] / [Intel XE#306]) -> [SKIP][169] ([Intel XE#306]) +1 other test skip
[168]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-463/igt@[email protected]
[169]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_chamelium_edid@hdmi-edid-stress-resolution-4k:
- shard-dg2-set2: [SKIP][170] ([Intel XE#373]) -> [SKIP][171] ([Intel XE#1201] / [Intel XE#373]) +6 other tests skip
[170]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[171]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_cursor_crc@cursor-onscreen-512x512:
- shard-dg2-set2: [SKIP][172] ([Intel XE#1201] / [Intel XE#308]) -> [SKIP][173] ([Intel XE#308]) +1 other test skip
[172]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[173]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size:
- shard-dg2-set2: [SKIP][174] ([Intel XE#1201] / [Intel XE#323]) -> [SKIP][175] ([Intel XE#323]) +1 other test skip
[174]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html
[175]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-varying-size.html

* igt@kms_feature_discovery@chamelium:
- shard-dg2-set2: [SKIP][176] ([Intel XE#1201] / [Intel XE#701]) -> [SKIP][177] ([Intel XE#701])
[176]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@[email protected]
[177]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_feature_discovery@display-3x:
- shard-dg2-set2: [SKIP][178] ([Intel XE#703]) -> [SKIP][179] ([Intel XE#1201] / [Intel XE#703])
[178]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[179]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_feature_discovery@dp-mst:
- shard-dg2-set2: [SKIP][180] ([Intel XE#1137] / [Intel XE#1201]) -> [SKIP][181] ([Intel XE#1137])
[180]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[181]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling:
- shard-dg2-set2: [SKIP][182] ([Intel XE#455]) -> [SKIP][183] ([Intel XE#1201] / [Intel XE#455]) +4 other tests skip
[182]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling.html
[183]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@kms_flip_scaled_crc@flip-32bpp-yftileccs-to-64bpp-yftile-upscaling.html

* igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling:
- shard-dg2-set2: [SKIP][184] ([Intel XE#1201] / [Intel XE#455]) -> [SKIP][185] ([Intel XE#455]) +21 other tests skip
[184]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html
[185]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@kms_flip_scaled_crc@flip-64bpp-ytile-to-32bpp-ytilegen12rcccs-upscaling.html

* igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-shrfb-pgflip-blt:
- shard-dg2-set2: [SKIP][186] ([Intel XE#651]) -> [SKIP][187] ([Intel XE#1201] / [Intel XE#651]) +16 other tests skip
[186]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-shrfb-pgflip-blt.html
[187]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@kms_frontbuffer_tracking@fbcdrrs-2p-scndscrn-shrfb-pgflip-blt.html

* igt@kms_frontbuffer_tracking@fbcdrrs-rgb101010-draw-mmap-wc:
- shard-dg2-set2: [SKIP][188] ([Intel XE#1201] / [Intel XE#651]) -> [SKIP][189] ([Intel XE#651]) +24 other tests skip
[188]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@[email protected]
[189]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_frontbuffer_tracking@fbcdrrs-tiling-y:
- shard-dg2-set2: [SKIP][190] ([Intel XE#658]) -> [SKIP][191] ([Intel XE#1201] / [Intel XE#658])
[190]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[191]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc:
- shard-dg2-set2: [SKIP][192] ([Intel XE#653]) -> [SKIP][193] ([Intel XE#1201] / [Intel XE#653]) +17 other tests skip
[192]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc.html
[193]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-shrfb-draw-mmap-wc.html

* igt@kms_frontbuffer_tracking@psr-2p-primscrn-shrfb-msflip-blt:
- shard-dg2-set2: [SKIP][194] ([Intel XE#1201] / [Intel XE#653]) -> [SKIP][195] ([Intel XE#653]) +25 other tests skip
[194]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[195]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format:
- shard-dg2-set2: [SKIP][196] ([Intel XE#455] / [Intel XE#498]) -> [SKIP][197] ([Intel XE#1201] / [Intel XE#455] / [Intel XE#498]) +1 other test skip
[196]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format.html
[197]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format.html

* igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-6:
- shard-dg2-set2: [SKIP][198] ([Intel XE#498]) -> [SKIP][199] ([Intel XE#1201] / [Intel XE#498]) +2 other tests skip
[198]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-6.html
[199]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@kms_plane_scaling@plane-downscale-factor-0-25-with-pixel-format@pipe-c-hdmi-a-6.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25:
- shard-dg2-set2: [SKIP][200] ([Intel XE#1201] / [Intel XE#2318] / [Intel XE#455]) -> [SKIP][201] ([Intel XE#2318] / [Intel XE#455]) +1 other test skip
[200]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25.html
[201]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25.html

* igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-6:
- shard-dg2-set2: [SKIP][202] ([Intel XE#1201] / [Intel XE#2318]) -> [SKIP][203] ([Intel XE#2318]) +2 other tests skip
[202]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-6.html
[203]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-factor-0-25@pipe-c-hdmi-a-6.html

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-a-hdmi-a-6:
- shard-dg2-set2: [SKIP][204] ([Intel XE#2318]) -> [SKIP][205] ([Intel XE#1201] / [Intel XE#2318]) +2 other tests skip
[204]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_plane_scaling@[email protected]
[205]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@kms_plane_scaling@[email protected]

* igt@kms_plane_scaling@planes-unity-scaling-downscale-factor-0-25@pipe-d-hdmi-a-6:
- shard-dg2-set2: [SKIP][206] ([Intel XE#2318] / [Intel XE#455]) -> [SKIP][207] ([Intel XE#1201] / [Intel XE#2318] / [Intel XE#455]) +1 other test skip
[206]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@kms_plane_scaling@[email protected]
[207]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@kms_plane_scaling@[email protected]

* igt@kms_pm_backlight@bad-brightness:
- shard-dg2-set2: [SKIP][208] ([Intel XE#870]) -> [SKIP][209] ([Intel XE#1201] / [Intel XE#870])
[208]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[209]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@[email protected]

* igt@kms_pm_dc@dc5-psr:
- shard-dg2-set2: [SKIP][210] ([Intel XE#1129]) -> [SKIP][211] ([Intel XE#1129] / [Intel XE#1201])
[210]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[211]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_pm_dc@dc6-dpms:
- shard-dg2-set2: [SKIP][212] ([Intel XE#1201] / [Intel XE#908]) -> [SKIP][213] ([Intel XE#908])
[212]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[213]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr2_sf@fbc-overlay-primary-update-sf-dmg-area:
- shard-dg2-set2: [SKIP][214] ([Intel XE#1201] / [Intel XE#1489]) -> [SKIP][215] ([Intel XE#1489]) +2 other tests skip
[214]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[215]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area-big-fb:
- shard-dg2-set2: [SKIP][216] ([Intel XE#1489]) -> [SKIP][217] ([Intel XE#1201] / [Intel XE#1489]) +3 other tests skip
[216]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[217]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_psr2_su@frontbuffer-xrgb8888:
- shard-dg2-set2: [SKIP][218] ([Intel XE#1122] / [Intel XE#1201]) -> [SKIP][219] ([Intel XE#1122])
[218]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[219]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr@fbc-psr-sprite-render:
- shard-dg2-set2: [SKIP][220] ([Intel XE#1201] / [Intel XE#929]) -> [SKIP][221] ([Intel XE#929]) +13 other tests skip
[220]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[221]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_psr@fbc-psr2-sprite-plane-move:
- shard-dg2-set2: [SKIP][222] ([Intel XE#929]) -> [SKIP][223] ([Intel XE#1201] / [Intel XE#929]) +9 other tests skip
[222]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[223]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@kms_rotation_crc@bad-tiling:
- shard-dg2-set2: [SKIP][224] ([Intel XE#1201] / [Intel XE#327]) -> [SKIP][225] ([Intel XE#327])
[224]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[225]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_rotation_crc@primary-y-tiled-reflect-x-90:
- shard-dg2-set2: [SKIP][226] ([Intel XE#327]) -> [SKIP][227] ([Intel XE#1201] / [Intel XE#327])
[226]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[227]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-436/igt@[email protected]

* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-dg2-set2: [SKIP][228] ([Intel XE#1127] / [Intel XE#1201]) -> [SKIP][229] ([Intel XE#1127])
[228]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[229]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_tv_load_detect@load-detect:
- shard-dg2-set2: [SKIP][230] ([Intel XE#1201] / [Intel XE#330]) -> [SKIP][231] ([Intel XE#330])
[230]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[231]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_vrr@lobf:
- shard-dg2-set2: [SKIP][232] ([Intel XE#1201] / [Intel XE#2168]) -> [SKIP][233] ([Intel XE#2168])
[232]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[233]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@kms_writeback@writeback-fb-id:
- shard-dg2-set2: [SKIP][234] ([Intel XE#1201] / [Intel XE#756]) -> [SKIP][235] ([Intel XE#756]) +1 other test skip
[234]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[235]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@sriov_basic@enable-vfs-bind-unbind-each-numvfs-all:
- shard-dg2-set2: [SKIP][236] ([Intel XE#1091]) -> [SKIP][237] ([Intel XE#1091] / [Intel XE#1201])
[236]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[237]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@[email protected]

* igt@xe_compute_preempt@compute-preempt:
- shard-dg2-set2: [SKIP][238] ([Intel XE#1280] / [Intel XE#455]) -> [SKIP][239] ([Intel XE#1201] / [Intel XE#1280] / [Intel XE#455]) +1 other test skip
[238]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[239]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-433/igt@[email protected]

* igt@xe_compute_preempt@compute-threadgroup-preempt@engine-drm_xe_engine_class_compute:
- shard-dg2-set2: [SKIP][240] ([Intel XE#1201] / [Intel XE#1280] / [Intel XE#455]) -> [SKIP][241] ([Intel XE#1280] / [Intel XE#455]) +1 other test skip
[240]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@xe_compute_preempt@compute-threadgroup-preempt@engine-drm_xe_engine_class_compute.html
[241]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@xe_compute_preempt@compute-threadgroup-preempt@engine-drm_xe_engine_class_compute.html

* igt@xe_copy_basic@mem-copy-linear-0x3fff:
- shard-dg2-set2: [SKIP][242] ([Intel XE#1123] / [Intel XE#1201]) -> [SKIP][243] ([Intel XE#1123])
[242]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[243]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_copy_basic@mem-set-linear-0xfffe:
- shard-dg2-set2: [SKIP][244] ([Intel XE#1126] / [Intel XE#1201]) -> [SKIP][245] ([Intel XE#1126])
[244]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-434/igt@[email protected]
[245]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_exec_fault_mode@once-bindexecqueue-imm:
- shard-dg2-set2: [SKIP][246] ([Intel XE#288]) -> [SKIP][247] ([Intel XE#1201] / [Intel XE#288]) +14 other tests skip
[246]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[247]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@[email protected]

* igt@xe_exec_fault_mode@twice-userptr-invalidate-race:
- shard-dg2-set2: [SKIP][248] ([Intel XE#1201] / [Intel XE#288]) -> [SKIP][249] ([Intel XE#288]) +22 other tests skip
[248]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[249]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit:
- shard-dg2-set2: [SKIP][250] ([Intel XE#1201] / [Intel XE#2229]) -> [SKIP][251] ([Intel XE#2229])
[250]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-466/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html
[251]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@xe_live_ktest@xe_migrate@xe_validate_ccs_kunit.html

* igt@xe_module_load@force-load:
- shard-dg2-set2: [SKIP][252] ([Intel XE#1201] / [Intel XE#378]) -> [SKIP][253] ([Intel XE#378])
[252]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-435/igt@[email protected]
[253]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_oa@oa-unit-exclusive-stream-sample-oa:
- shard-dg2-set2: [SKIP][254] ([Intel XE#1201] / [Intel XE#2541]) -> [SKIP][255] ([Intel XE#2541]) +4 other tests skip
[254]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[255]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_oa@polling-small-buf:
- shard-dg2-set2: [SKIP][256] ([Intel XE#2541]) -> [SKIP][257] ([Intel XE#1201] / [Intel XE#2541]) +2 other tests skip
[256]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[257]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@[email protected]

* igt@xe_pat@pat-index-xe2:
- shard-dg2-set2: [SKIP][258] ([Intel XE#977]) -> [SKIP][259] ([Intel XE#1201] / [Intel XE#977])
[258]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[259]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-463/igt@[email protected]

* igt@xe_pat@pat-index-xehpc:
- shard-dg2-set2: [SKIP][260] ([Intel XE#1201] / [Intel XE#979]) -> [SKIP][261] ([Intel XE#979])
[260]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[261]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_pat@pat-index-xelpg:
- shard-dg2-set2: [SKIP][262] ([Intel XE#979]) -> [SKIP][263] ([Intel XE#1201] / [Intel XE#979])
[262]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[263]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

* igt@xe_pm@d3cold-basic-exec:
- shard-dg2-set2: [SKIP][264] ([Intel XE#1201] / [Intel XE#2284] / [Intel XE#366]) -> [SKIP][265] ([Intel XE#2284] / [Intel XE#366]) +1 other test skip
[264]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[265]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_query@multigpu-query-engines:
- shard-dg2-set2: [SKIP][266] ([Intel XE#1201] / [Intel XE#944]) -> [SKIP][267] ([Intel XE#944]) +1 other test skip
[266]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-436/igt@[email protected]
[267]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-432/igt@[email protected]

* igt@xe_query@multigpu-query-oa-units:
- shard-dg2-set2: [SKIP][268] ([Intel XE#944]) -> [SKIP][269] ([Intel XE#1201] / [Intel XE#944]) +2 other tests skip
[268]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-432/igt@[email protected]
[269]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-466/igt@[email protected]

* igt@xe_wedged@wedged-at-any-timeout:
- shard-dg2-set2: [DMESG-WARN][270] ([Intel XE#1760]) -> [INCOMPLETE][271] ([Intel XE#1195] / [Intel XE#1760])
[270]: https://intel-gfx-ci.01.org/tree/intel-xe/IGT_7990/shard-dg2-433/igt@[email protected]
[271]: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/shard-dg2-435/igt@[email protected]

{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).

[Intel XE#1091]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1091
[Intel XE#1122]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1122
[Intel XE#1123]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1123
[Intel XE#1124]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1124
[Intel XE#1126]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1126
[Intel XE#1127]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1127
[Intel XE#1128]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1128
[Intel XE#1129]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1129
[Intel XE#1137]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1137
[Intel XE#1188]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1188
[Intel XE#1192]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1192
[Intel XE#1195]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1195
[Intel XE#1201]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1201
[Intel XE#1280]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1280
[Intel XE#1358]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1358
[Intel XE#1392]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1392
[Intel XE#1397]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1397
[Intel XE#1399]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1399
[Intel XE#1401]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1401
[Intel XE#1406]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1406
[Intel XE#1407]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1407
[Intel XE#1421]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1421
[Intel XE#1424]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1424
[Intel XE#1426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1426
[Intel XE#1437]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1437
[Intel XE#1439]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1439
[Intel XE#1466]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1466
[Intel XE#1473]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1473
[Intel XE#1489]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1489
[Intel XE#1499]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1499
[Intel XE#1503]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1503
[Intel XE#1551]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1551
[Intel XE#1607]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1607
[Intel XE#1649]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1649
[Intel XE#1656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1656
[Intel XE#1659]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1659
[Intel XE#1695]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1695
[Intel XE#1725]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1725
[Intel XE#1729]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1729
[Intel XE#1745]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1745
[Intel XE#1760]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1760
[Intel XE#1794]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1794
[Intel XE#1948]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/1948
[Intel XE#2019]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2019
[Intel XE#2105]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2105
[Intel XE#2168]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2168
[Intel XE#2191]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2191
[Intel XE#2229]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2229
[Intel XE#2234]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2234
[Intel XE#2251]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2251
[Intel XE#2252]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2252
[Intel XE#2280]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2280
[Intel XE#2284]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2284
[Intel XE#2311]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2311
[Intel XE#2313]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2313
[Intel XE#2318]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2318
[Intel XE#2320]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2320
[Intel XE#2322]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2322
[Intel XE#2327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2327
[Intel XE#2333]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2333
[Intel XE#2357]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2357
[Intel XE#2426]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2426
[Intel XE#2436]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2436
[Intel XE#2443]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2443
[Intel XE#2472]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2472
[Intel XE#2497]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2497
[Intel XE#2509]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2509
[Intel XE#2514]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2514
[Intel XE#2541]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2541
[Intel XE#2597]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/2597
[Intel XE#288]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/288
[Intel XE#306]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/306
[Intel XE#308]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/308
[Intel XE#309]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/309
[Intel XE#314]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/314
[Intel XE#316]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/316
[Intel XE#323]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/323
[Intel XE#324]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/324
[Intel XE#327]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/327
[Intel XE#330]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/330
[Intel XE#346]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/346
[Intel XE#361]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/361
[Intel XE#366]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/366
[Intel XE#367]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/367
[Intel XE#373]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/373
[Intel XE#374]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/374
[Intel XE#378]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/378
[Intel XE#455]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/455
[Intel XE#498]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/498
[Intel XE#569]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/569
[Intel XE#599]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/599
[Intel XE#605]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/605
[Intel XE#607]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/607
[Intel XE#619]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/619
[Intel XE#651]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/651
[Intel XE#653]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/653
[Intel XE#656]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/656
[Intel XE#658]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/658
[Intel XE#688]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/688
[Intel XE#701]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/701
[Intel XE#703]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/703
[Intel XE#718]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/718
[Intel XE#736]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/736
[Intel XE#756]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/756
[Intel XE#787]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/787
[Intel XE#870]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/870
[Intel XE#877]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/877
[Intel XE#886]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/886
[Intel XE#899]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/899
[Intel XE#908]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/908
[Intel XE#911]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/911
[Intel XE#929]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/929
[Intel XE#944]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/944
[Intel XE#958]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/958
[Intel XE#977]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/977
[Intel XE#979]: https://gitlab.freedesktop.org/drm/xe/kernel/issues/979

Build changes
-------------

* IGT: IGT_7990 -> IGTPW_11633
* Linux: xe-1822-411a047925bb7e169a075a2ddfb63ba96f26a8c8 -> xe-1823-5626fe5d6eeb0949727861375b27d67ee71feaa7

IGTPW_11633: 11633
IGT_7990: 9ca5ff0afa3636478b6ba5a97e5ba440cfb2e55e @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
xe-1822-411a047925bb7e169a075a2ddfb63ba96f26a8c8: 411a047925bb7e169a075a2ddfb63ba96f26a8c8 xe-1823-5626fe5d6eeb0949727861375b27d67ee71feaa7: 5626fe5d6eeb0949727861375b27d67ee71feaa7

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/intel-xe/IGTPW_11633/index.html