staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

PATCH Superseded Alien Wesley 2 participants 3 messages Aug 25, 2024 – Aug 26, 2024 Staging

Share & tools

Alien Wesley

author

2024-08-25 21:46 UTC #0 lore raw

PATCH 1/1 staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.

CHECK: multiple assignments should be avoided.

---
Changes in v2:
- Removed two spaces in front of "=".

Signed-off-by Alien Wesley <[email protected]>

---
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -1

index 47f1adf30ab4..67c4793e0fc1 100644
@@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
 	mutex_unlock(&priv->wx_mutex);
 
 	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
-		ieee->pairwise_key_type  = KEY_TYPE_NA;
+		ieee->pairwise_key_type = KEY_TYPE_NA;
 		ieee->group_key_type = KEY_TYPE_NA;
 		rtl92e_cam_reset(dev);
 		memset(priv->rtllib->swcamtable, 0,

Signature · 1 line

2.34.1

Alien Wesley

author

2024-08-25 22:43 UTC #1 lore raw

Sorry folks, this was supposed to be a v2.
[PATCH v2] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529

Quoted 27 lines

Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.
CHECK: multiple assignments should be avoided.
---
Changes in v2:
- Removed two spaces in front of "=".
Signed-off-by Alien Wesley <[email protected]>
---
  drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -1
index 47f1adf30ab4..67c4793e0fc1 100644
@@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
  	mutex_unlock(&priv->wx_mutex);
 
  	if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
-		ieee->pairwise_key_type  = KEY_TYPE_NA;
+		ieee->pairwise_key_type = KEY_TYPE_NA;
  		ieee->group_key_type = KEY_TYPE_NA;
  		rtl92e_cam_reset(dev);
  		memset(priv->rtllib->swcamtable, 0,

Philipp Hortmann

2024-08-26 00:42 UTC #2 lore raw

Quoted 16 lines · Alien Wesley

Sorry folks, this was supposed to be a v2.
[PATCH v2] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529
Quoted 14 lines
Separated assignments for pairwise_key_type and group_key_type in order to silence the following checkpatch warning.
CHECK: multiple assignments should be avoided.
---
Changes in v2:
- Removed two spaces in front of "=".
Signed-off-by Alien Wesley <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Quoted 14 lines

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c static int _rtl92e_wx_set_enc(struct net_device *dev, · line 531

Quoted 12 lines

drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +1 -1

index 47f1adf30ab4..67c4793e0fc1 100644
@@ -526,7 +526,7 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
       mutex_unlock(&priv->wx_mutex);
       if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
-        ieee->pairwise_key_type  = KEY_TYPE_NA;
+        ieee->pairwise_key_type = KEY_TYPE_NA;
           ieee->group_key_type = KEY_TYPE_NA;
           rtl92e_cam_reset(dev);
           memset(priv->rtllib->swcamtable, 0,

Hi Alien,

please make a v3 with correct subject.

Description from Dan under:
https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

Thanks for your support.

Bye Philipp