Skip to contentSkip to conversation

Added prefix pop at bottom of DBCN test function.

PATCH In review Cade Richard 2 participants 3 messages Aug 26, 2024 – Aug 27, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Added prefix pop at bottom of DBCN test function.

Added report prefix pop at bottom of DBCN test function.

---
 riscv/sbi.c | 1 +
 1 file changed, 1 insertion(+)
riscv/sbi.c +1 -0
index 36ddfd48..01697aed 100644
@@ -418,6 +418,7 @@ static void check_dbcn(void)
 	report(ret.value == 0, "expected ret.value (%ld)", ret.value);
 
 	report_prefix_pop();
+	report_prefix_pop();
 }
 
 int main(int argc, char **argv)
Signature · 1 line
2.43.0
#1 lore raw
Quoted 3 lines · Cade Richard

Added report prefix pop at bottom of DBCN test function.

This should be

Fixes ce58d3a45d96 ("riscv: sbi: Add dbcn write test")

and without a space before the s-o-b.

I've fixed it up while queuing.

Thanks,
drew

Quoted 26 lines
---
 riscv/sbi.c | 1 +
 1 file changed, 1 insertion(+)
riscv/sbi.c +1 -0
index 36ddfd48..01697aed 100644
@@ -418,6 +418,7 @@ static void check_dbcn(void)
 	report(ret.value == 0, "expected ret.value (%ld)", ret.value);
 
 	report_prefix_pop();
+	report_prefix_pop();
 }
 
 int main(int argc, char **argv)
Signature · 7 lines
2.43.0


-- 
kvm-riscv mailing list
kvm-riscv at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv
#2 lore raw
In reply to Cade Richard

This patch summary has a period. I've removed it. I also rewrote the commit message. Just repeating the summary isn't helpful. I wrote

The number of pops needs to balance the number of pushes, but check_dbcn was missing a pop, resulting in a dbcn prefix being output on following non-dbcn tests. Add the pop.

Thanks,
drew

Quoted 29 lines · Cade Richard

Added report prefix pop at bottom of DBCN test function.

---
 riscv/sbi.c | 1 +
 1 file changed, 1 insertion(+)
riscv/sbi.c +1 -0
index 36ddfd48..01697aed 100644
@@ -418,6 +418,7 @@ static void check_dbcn(void)
 	report(ret.value == 0, "expected ret.value (%ld)", ret.value);
 
 	report_prefix_pop();
+	report_prefix_pop();
 }
 
 int main(int argc, char **argv)
Signature · 7 lines
2.43.0


-- 
kvm-riscv mailing list
kvm-riscv at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kvm-riscv