Skip to contentSkip to conversation

imx: Remove CFG_MXC_USB_FLAGS

PATCH In review Fabio Estevam 3 participants 9 messages Aug 28, 2024 – Sep 2, 2024

Subsystems (4)
lore
Share & tools
lore

Fabio Estevam

author reviewer
#0 lore raw

PATCH v3 1/4 imx: Remove CFG_MXC_USB_FLAGS

From: Fabio Estevam <[email protected]>

CFG_MXC_USB_FLAGS is only used for drivers/usb/host/ehci-mx5.c, so it can be removed from all the imx6/imx7/imx8m board config files.

mx51evk.h is the only place CFG_MXC_USB_FLAGS is not set to 0.

---
Changes since v2:
- None.

 include/configs/apalis_imx6.h            | 1 -
 include/configs/aristainetos2.h          | 1 -
 include/configs/cl-som-imx7.h            | 1 -
 include/configs/cm_fx6.h                 | 1 -
 include/configs/colibri-imx6ull.h        | 1 -
 include/configs/colibri_imx6.h           | 1 -
 include/configs/colibri_imx7.h           | 1 -
 include/configs/dart_6ul.h               | 1 -
 include/configs/dh_imx6.h                | 1 -
 include/configs/embestmx6boards.h        | 1 -
 include/configs/ge_b1x5v2.h              | 1 -
 include/configs/gw_ventana.h             | 1 -
 include/configs/imx6_logic.h             | 1 -
 include/configs/imx6dl-mamoj.h           | 1 -
 include/configs/imx6q-bosch-acc.h        | 1 -
 include/configs/kontron-sl-mx6ul.h       | 1 -
 include/configs/kontron-sl-mx8mm.h       | 1 -
 include/configs/kp_imx53.h               | 1 -
 include/configs/kp_imx6q_tpc.h           | 1 -
 include/configs/liteboard.h              | 1 -
 include/configs/m53menlo.h               | 1 -
 include/configs/mx53cx9020.h             | 1 -
 include/configs/mx53loco.h               | 1 -
 include/configs/mx53ppd.h                | 1 -
 include/configs/mx6sabreauto.h           | 1 -
 include/configs/mx6sabresd.h             | 1 -
 include/configs/mx6slevk.h               | 1 -
 include/configs/mx6sxsabreauto.h         | 1 -
 include/configs/mx6sxsabresd.h           | 1 -
 include/configs/mx6ul_14x14_evk.h        | 1 -
 include/configs/mys_6ulx.h               | 1 -
 include/configs/nitrogen6x.h             | 1 -
 include/configs/novena.h                 | 1 -
 include/configs/npi_imx6ull.h            | 1 -
 include/configs/opos6uldev.h             | 1 -
 include/configs/pcl063.h                 | 1 -
 include/configs/pcl063_ull.h             | 1 -
 include/configs/pico-imx6.h              | 1 -
 include/configs/pico-imx6ul.h            | 1 -
 include/configs/pico-imx7d.h             | 1 -
 include/configs/somlabs_visionsom_6ull.h | 1 -
 include/configs/usbarmory.h              | 1 -
 include/configs/vining_2000.h            | 1 -
 include/configs/wandboard.h              | 1 -
 include/configs/xpress.h                 | 1 -
 45 files changed, 45 deletions(-)
include/configs/apalis_imx6.h +0 -1
index 6fd43511ee4..097f819e44a 100644
@@ -26,7 +26,6 @@
 /* USB Configs */
 /* Host */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Framebuffer and LCD */
 
include/configs/aristainetos2.h +0 -1
index 9d4a4bbdf43..120ff9284ef 100644
@@ -413,7 +413,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* UBI support */
 
include/configs/cl-som-imx7.h +0 -1
index 280ae1e9cca..96058d48148 100644
@@ -97,6 +97,5 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 
 #endif	/* __CONFIG_H */
include/configs/cm_fx6.h +0 -1
index 7d0f2b6dc13..fc2d59751c4 100644
@@ -136,7 +136,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Boot */
 #define CFG_SYS_BOOTMAPSZ	        (8 << 20)
include/configs/colibri-imx6ull.h +0 -1
index 8860ceec1a0..c896a897cbf 100644
@@ -120,7 +120,6 @@
 /* USB Configs */
 
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/colibri_imx6.h +0 -1
index 79e5b870b81..87c973883c3 100644
@@ -24,7 +24,6 @@
 /* USB Configs */
 /* Host */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Command definition */
 
include/configs/colibri_imx7.h +0 -1
index 33133a0b96e..0e0665038b1 100644
@@ -162,6 +162,5 @@
 /* USB Configs */
 
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #endif
include/configs/dart_6ul.h +0 -1
index c5781670864..4d715d4f425 100644
@@ -48,7 +48,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/dh_imx6.h +0 -1
index 4b5ef4ad510..dc5ca9fc60c 100644
@@ -32,7 +32,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* USB Gadget (DFU, UMS) */
 #if defined(CONFIG_CMD_DFU) || defined(CONFIG_CMD_USB_MASS_STORAGE)
include/configs/embestmx6boards.h +0 -1
index 31c7e104f6b..e378374a004 100644
@@ -19,7 +19,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
include/configs/ge_b1x5v2.h +0 -1
index 49b058cb10d..0bf31897a74 100644
@@ -25,7 +25,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 /* Memory */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
include/configs/gw_ventana.h +0 -1
index ebc5d03d0d5..f884d74d9ca 100644
@@ -37,7 +37,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS      0
 
 /* Miscellaneous configurable options */
 
include/configs/imx6_logic.h +0 -1
index 66004a6eb2a..19613e838fb 100644
@@ -117,7 +117,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Falcon Mode */
include/configs/imx6dl-mamoj.h +0 -1
index 6c61b3f4480..6651653d5e9 100644
@@ -44,7 +44,6 @@
 
 /* USB */
 #define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS			0
 
 /* Falcon */
 
include/configs/imx6q-bosch-acc.h +0 -1
index 2c998cdcfc7..aa365dc9a79 100644
@@ -111,6 +111,5 @@
 #endif
 
 #define CFG_MXC_USB_PORTSC            (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS             0
 
 #endif /* __IMX6Q_ACC_H */
include/configs/kontron-sl-mx6ul.h +0 -1
index 1c92cd78767..e68c667c505 100644
@@ -26,7 +26,6 @@
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Boot order for distro boot */
include/configs/kontron-sl-mx8mm.h +0 -1
index eee3d2ddb03..be1f70a9a59 100644
@@ -26,7 +26,6 @@
 
 #ifdef CONFIG_USB_EHCI_HCD
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* GUID for capsule updatable firmware image */
include/configs/kp_imx53.h +0 -1
index 6e383cbe75f..91caf03091c 100644
@@ -12,7 +12,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/kp_imx6q_tpc.h +0 -1
index 1aa4b8ab598..74f6e4e9f96 100644
@@ -19,7 +19,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #define CFG_EXTRA_ENV_SETTINGS	\
include/configs/liteboard.h +0 -1
index 5811059c8e2..25c30e6c6a5 100644
@@ -96,7 +96,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/m53menlo.h +0 -1
index 9cf46b2c362..1491c509820 100644
@@ -72,7 +72,6 @@
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORT		1
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* LVDS display */
include/configs/mx53cx9020.h +0 -1
index dccfdc3a15d..ab6b0b65556 100644
@@ -24,7 +24,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/mx53loco.h +0 -1
index 7398804e6b5..04f4b723209 100644
@@ -19,7 +19,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* PMIC Controller */
 #define CFG_SYS_DIALOG_PMIC_I2C_ADDR	0x48
include/configs/mx53ppd.h +0 -1
index df65dbeea41..3c9a9fb045b 100644
@@ -14,7 +14,6 @@
 /* USB Configs */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Command definition */
 
include/configs/mx6sabreauto.h +0 -1
index 91544c8a0e2..eb963cbb0b3 100644
@@ -13,7 +13,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 #define CFG_SYS_I2C_PCA953X_WIDTH	{ {0x30, 8}, {0x32, 8}, {0x34, 8} }
 
include/configs/mx6sabresd.h +0 -1
index 844f10e4229..9160f878f4b 100644
@@ -27,7 +27,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #endif                         /* __MX6SABRESD_CONFIG_H */
include/configs/mx6slevk.h +0 -1
index 490d9feb805..65c6cdd4b87 100644
@@ -91,7 +91,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	3
include/configs/mx6sxsabreauto.h +0 -1
index 1c14a6beb0a..4e163d28e63 100644
@@ -97,7 +97,6 @@
 
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #define CFG_SYS_FSL_USDHC_NUM	2
include/configs/mx6sxsabresd.h +0 -1
index fe0ad34ef9c..b43a1d81315 100644
@@ -119,7 +119,6 @@
 
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_PCI
include/configs/mx6ul_14x14_evk.h +0 -1
index 98b743b9364..fd0c87ffb01 100644
@@ -117,7 +117,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/mys_6ulx.h +0 -1
index 2571098d06c..8defdfc4fda 100644
@@ -31,7 +31,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/nitrogen6x.h +0 -1
index c03d11dcdae..a8ad85050f7 100644
@@ -20,7 +20,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 #ifdef CONFIG_CMD_MMC
 #define DISTRO_BOOT_DEV_MMC(func) func(MMC, mmc, 0) func(MMC, mmc, 1)
include/configs/novena.h +0 -1
index 39d3afd1c8e..144cf1b4a4b 100644
@@ -54,7 +54,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* Extra U-Boot environment. */
include/configs/npi_imx6ull.h +0 -1
index 5f933391cc0..f71e2657076 100644
@@ -30,7 +30,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_MXC_PHYADDR		0x1
include/configs/opos6uldev.h +0 -1
index 1edb1826c4e..12020d31e1c 100644
@@ -20,7 +20,6 @@
 /* USB */
 #ifdef CONFIG_USB_EHCI_MX6
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 #endif
 
 /* LCD */
include/configs/pcl063.h +0 -1
index 38dcee05359..2a729c3e454 100644
@@ -43,7 +43,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
include/configs/pcl063_ull.h +0 -1
index d742201ce43..afa8e7aeb71 100644
@@ -45,7 +45,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
include/configs/pico-imx6.h +0 -1
index d806d7d9c57..6ccb3dc1902 100644
@@ -17,7 +17,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx6ul.h +0 -1
index 8a22f0134b3..ef8281440e5 100644
@@ -23,7 +23,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
include/configs/pico-imx7d.h +0 -1
index e7a8cb20dff..21ec7fd3362 100644
@@ -107,6 +107,5 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS			0
 
 #endif
include/configs/somlabs_visionsom_6ull.h +0 -1
index 041a83b057d..aa09528acd9 100644
@@ -62,7 +62,6 @@
 /* USB Configs */
 #ifdef CONFIG_CMD_USB
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 #endif
 
 #ifdef CONFIG_CMD_NET
include/configs/usbarmory.h +0 -1
index 27e61f5b8f4..28d86a26362 100644
@@ -25,7 +25,6 @@
 /* USB */
 #define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS	0
 
 /* Linux boot */
 
include/configs/vining_2000.h +0 -1
index 30654191a26..3c2d7e66891 100644
@@ -37,7 +37,6 @@
 #define CFG_FEC_MXC_PHYADDR          0x0
 
 #define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS   0
 
 #ifdef CONFIG_CMD_PCI
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(4, 6)
include/configs/wandboard.h +0 -1
index 7b8c5cbe7a8..d64c4262bd6 100644
@@ -18,7 +18,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0\0" \
include/configs/xpress.h +0 -1
index a2aa31008ec..bb0a30c4344 100644
@@ -29,7 +29,6 @@
 
 /* USB Configs */
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#define CFG_MXC_USB_FLAGS		0
 
 #define CFG_FEC_ENET_DEV		0
 #define CFG_FEC_MXC_PHYADDR          0x0
Signature · 1 line
2.34.1
author reviewer
#1 lore raw

PATCH v3 2/4 usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

From: Fabio Estevam <[email protected]>

Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files.

All the mx5 boards, with the exeption of mx51evk, define CFG_MXC_USB_PORTSC as:

#define CFG_MXC_USB_PORTSC (PORT_PTS_UTMI | PORT_PTS_PTW)

So move this definition as a default into ehci-mx5.c.

---
Changes since v2:
- None.

 drivers/usb/host/ehci-mx5.c | 4 ++++
 1 file changed, 4 insertions(+)
drivers/usb/host/ehci-mx5.c +4 -0
index 44912de7787..d8f521befe1 100644
@@ -79,6 +79,10 @@
 /* USB_CTRL_1 */
 #define MXC_USB_CTRL_UH1_EXT_CLK_EN	(1 << 25)
 
+#ifndef CFG_MXC_USB_PORTSC
+#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
+#endif
+
 int mxc_set_usbcontrol(int port, unsigned int flags)
 {
 	unsigned int v;
Signature · 1 line
2.34.1
Reviewed-by on v3 2/4
#2 lore raw

Re: [PATCH v3 2/4] usb: ehci-mx5: Add a default for CFG_MXC_USB_PORTSC

Quoted 11 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

Just like drivers/usb/host/ehci-mx6.c, add a default for drivers/usb/host/ehci-mx5.c.

The motivation for doing this is to remove CFG_MXC_USB_PORTSC from board config files.

All the mx5 boards, with the exeption of mx51evk, define CFG_MXC_USB_PORTSC as:

Quoted 6 lines
  #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)

So move this definition as a default into ehci-mx5.c.

author reviewer
#3 lore raw

PATCH v3 3/4 mx5: Remove CFG_MXC_USB_PORT

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

CFG_MXC_USB_PORT is not used anywhere, so remove this unused symbol.

---
Changes since v2:
- None.

 include/configs/m53menlo.h   | 1 -
 include/configs/mx51evk.h    | 1 -
 include/configs/mx53cx9020.h | 1 -
 include/configs/mx53loco.h   | 1 -
 include/configs/mx53ppd.h    | 1 -
 include/configs/usbarmory.h  | 1 -
 6 files changed, 6 deletions(-)
include/configs/m53menlo.h +0 -1
index 1491c509820..51ce030d831 100644
@@ -70,7 +70,6 @@
  * USB
  */
 #ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORT		1
 #define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif
 
include/configs/mx51evk.h +0 -1
index dff54d04a67..6c8cb78274b 100644
@@ -33,7 +33,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	MMC_SDHC1_BASE_ADDR
 
 /* USB Configs */
-#define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	PORT_PTS_ULPI
 #define CFG_MXC_USB_FLAGS	MXC_EHCI_POWER_PINS_ENABLED
 
include/configs/mx53cx9020.h +0 -1
index ab6b0b65556..38bafc5156d 100644
@@ -22,7 +22,6 @@
 /* bootz: zImage/initrd.img support */
 
 /* USB Configs */
-#define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
include/configs/mx53loco.h +0 -1
index 04f4b723209..e9340c59ae1 100644
@@ -17,7 +17,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
 /* USB Configs */
-#define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* PMIC Controller */
include/configs/mx53ppd.h +0 -1
index 3c9a9fb045b..e0bfbbb459c 100644
@@ -12,7 +12,6 @@
 #include <asm/arch/imx-regs.h>
 
 /* USB Configs */
-#define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Command definition */
include/configs/usbarmory.h +0 -1
index 28d86a26362..1d7caaa1448 100644
@@ -23,7 +23,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
 /* USB */
-#define CFG_MXC_USB_PORT	1
 #define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* Linux boot */
Signature · 1 line
2.34.1
author reviewer
#5 lore raw

PATCH v3 4/4 imx: Remove CFG_MXC_USB_PORTSC

In reply to Fabio Estevam

From: Fabio Estevam <[email protected]>

The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

---
Changes since v2:
- Keep mx51evk.h intact as it uses a different CFG_MXC_USB_PORTSC definition.

 include/configs/apalis_imx6.h            | 4 ----
 include/configs/aristainetos2.h          | 3 ---
 include/configs/brppt2.h                 | 3 ---
 include/configs/cl-som-imx7.h            | 3 ---
 include/configs/cm_fx6.h                 | 3 ---
 include/configs/colibri-imx6ull.h        | 4 ----
 include/configs/colibri_imx6.h           | 4 ----
 include/configs/colibri_imx7.h           | 4 ----
 include/configs/dart_6ul.h               | 3 ---
 include/configs/dh_imx6.h                | 3 ---
 include/configs/display5.h               | 1 -
 include/configs/embestmx6boards.h        | 3 ---
 include/configs/ge_b1x5v2.h              | 3 ---
 include/configs/gw_ventana.h             | 3 ---
 include/configs/imx6_logic.h             | 5 -----
 include/configs/imx6dl-mamoj.h           | 3 ---
 include/configs/imx6q-bosch-acc.h        | 1 -
 include/configs/imx7-cm.h                | 3 ---
 include/configs/imx8mm-cl-iot-gate.h     | 3 ---
 include/configs/kontron-sl-mx6ul.h       | 4 ----
 include/configs/kontron-sl-mx8mm.h       | 4 ----
 include/configs/kp_imx53.h               | 3 ---
 include/configs/kp_imx6q_tpc.h           | 5 -----
 include/configs/liteboard.h              | 5 -----
 include/configs/m53menlo.h               | 7 -------
 include/configs/meerkat96.h              | 3 ---
 include/configs/mx53cx9020.h             | 3 ---
 include/configs/mx53loco.h               | 3 ---
 include/configs/mx53ppd.h                | 3 ---
 include/configs/mx6cuboxi.h              | 3 ---
 include/configs/mx6memcal.h              | 1 -
 include/configs/mx6sabreauto.h           | 3 ---
 include/configs/mx6sabresd.h             | 5 -----
 include/configs/mx6slevk.h               | 5 -----
 include/configs/mx6sllevk.h              | 5 -----
 include/configs/mx6sxsabreauto.h         | 4 ----
 include/configs/mx6sxsabresd.h           | 4 ----
 include/configs/mx6ul_14x14_evk.h        | 5 -----
 include/configs/mx7dsabresd.h            | 3 ---
 include/configs/mx7ulp_com.h             | 1 -
 include/configs/mys_6ulx.h               | 3 ---
 include/configs/nitrogen6x.h             | 3 ---
 include/configs/novena.h                 | 5 -----
 include/configs/npi_imx6ull.h            | 3 ---
 include/configs/o4-imx6ull-nano.h        | 4 ----
 include/configs/opos6uldev.h             | 5 -----
 include/configs/pcl063.h                 | 3 ---
 include/configs/pcl063_ull.h             | 3 ---
 include/configs/pico-imx6.h              | 3 ---
 include/configs/pico-imx6ul.h            | 3 ---
 include/configs/pico-imx7d.h             | 3 ---
 include/configs/somlabs_visionsom_6ull.h | 5 -----
 include/configs/tbs2910.h                | 5 -----
 include/configs/tqma6.h                  | 3 ---
 include/configs/usbarmory.h              | 3 ---
 include/configs/verdin-imx8mm.h          | 3 ---
 include/configs/vining_2000.h            | 1 -
 include/configs/wandboard.h              | 3 ---
 include/configs/warp7.h                  | 1 -
 include/configs/xpress.h                 | 3 ---
 60 files changed, 203 deletions(-)
include/configs/apalis_imx6.h +0 -4
index 097f819e44a4..e5df82c68301 100644
@@ -23,10 +23,6 @@
 
 /* Network */
 
-/* USB Configs */
-/* Host */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Framebuffer and LCD */
 
 /* Command definition */
include/configs/aristainetos2.h +0 -3
index 120ff9284ef6..8a66b1275dfe 100644
@@ -411,9 +411,6 @@
 
 /* DMA stuff, needed for GPMI/MXS NAND support */
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* UBI support */
 
 #define CFG_ENV_FLAGS_LIST_STATIC "ethaddr:mw,serial#:sw,board_type:sw," \
include/configs/brppt2.h +0 -3
index 38c98c5e21c4..d01f0d373163 100644
@@ -78,7 +78,4 @@ BUR_COMMON_ENV \
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif	/* __CONFIG_BRPP2_IMX6_H */
include/configs/cl-som-imx7.h +0 -3
index 96058d48148b..8c363137b4fa 100644
@@ -95,7 +95,4 @@
 #define CFG_SYS_FSL_USDHC_NUM	2
 #endif
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif	/* __CONFIG_H */
include/configs/cm_fx6.h +0 -3
index fc2d59751c42..f7fd4c517b4f 100644
@@ -134,9 +134,6 @@
 /* Ethernet */
 #define CFG_FEC_MXC_PHYADDR		0
 
-/* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Boot */
 #define CFG_SYS_BOOTMAPSZ	        (8 << 20)
 
include/configs/colibri-imx6ull.h +0 -4
index c896a897cbf4..26b29bad6a18 100644
@@ -117,10 +117,6 @@
 #define CFG_SYS_NAND_BASE		-1
 #endif
 
-/* USB Configs */
-
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
 
include/configs/colibri_imx6.h +0 -4
index 87c973883c33..664b7c8ce0cd 100644
@@ -21,10 +21,6 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 #define CFG_SYS_FSL_USDHC_NUM	2
 
-/* USB Configs */
-/* Host */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Command definition */
 
 #define BOOT_TARGET_DEVICES(func) \
include/configs/colibri_imx7.h +0 -4
index 0e0665038b1f..c340dfb11894 100644
@@ -159,8 +159,4 @@
 #define CFG_SYS_NAND_BASE		0x40000000
 #endif
 
-/* USB Configs */
-
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif
include/configs/dart_6ul.h +0 -3
index 4d715d4f425e..2b329b4065c3 100644
@@ -46,9 +46,6 @@
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
 	"mmcpart=" __stringify(MMC_ROOTFS_PART) "\0" \
include/configs/dh_imx6.h +0 -3
index dc5ca9fc60cd..9b6f03f68563 100644
@@ -30,9 +30,6 @@
 /* UART */
 #define CFG_MXC_UART_BASE		UART1_BASE
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* USB Gadget (DFU, UMS) */
 #if defined(CONFIG_CMD_DFU) || defined(CONFIG_CMD_USB_MASS_STORAGE)
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/display5.h +0 -1
index 2005a256d6e3..51fa2b03a2e6 100644
@@ -287,5 +287,4 @@
 /* The 0x120000 value corresponds to above SPI-NOR memory MAP */
 #endif
 
-#define CFG_MXC_USB_PORTSC           (PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif /* __CONFIG_H */
include/configs/embestmx6boards.h +0 -3
index e378374a004a..61c0d755a8d9 100644
@@ -17,9 +17,6 @@
 
 #define PHYS_SDRAM_SIZE		(1u * 1024 * 1024 * 1024)
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR      0
 
include/configs/ge_b1x5v2.h +0 -3
index 0bf31897a744..f3d85c9c11e8 100644
@@ -23,9 +23,6 @@
 #define CONSOLE_DEVICE "ttymxc2" /* Base board debug connector */
 #endif
 
-/* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Memory */
 #define PHYS_SDRAM		       MMDC0_ARB_BASE_ADDR
 
include/configs/gw_ventana.h +0 -3
index f884d74d9ca9..d112825ad1ff 100644
@@ -35,9 +35,6 @@
 
 /* Various command support */
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Miscellaneous configurable options */
 
 /* Memory configuration */
include/configs/imx6_logic.h +0 -5
index 19613e838fb3..75997469cd91 100644
@@ -114,11 +114,6 @@
 #define CFG_SYS_NAND_BASE           0x40000000
 #define CFG_SYS_NAND_U_BOOT_START	CONFIG_TEXT_BASE
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* Falcon Mode */
 
 /* Falcon Mode - MMC support: args@1MB kernel@2MB */
include/configs/imx6dl-mamoj.h +0 -3
index 6651653d5e9c..8abb58b06918 100644
@@ -42,9 +42,6 @@
 /* Ethernet */
 #define CFG_FEC_MXC_PHYADDR		1
 
-/* USB */
-#define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Falcon */
 
 /* MMC support: args@1MB kernel@2MB */
include/configs/imx6q-bosch-acc.h +0 -1
index aa365dc9a795..fab5063b73f4 100644
@@ -110,6 +110,5 @@
 #endif
 #endif
 
-#define CFG_MXC_USB_PORTSC            (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #endif /* __IMX6Q_ACC_H */
include/configs/imx7-cm.h +0 -3
index 131f18290b90..36c4c5b8b50a 100644
@@ -77,7 +77,4 @@
 #define CFG_SYS_FSL_ESDHC_ADDR       USDHC1_BASE_ADDR
 #define CFG_SYS_FSL_USDHC_NUM		2
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif	/* __CONFIG_H */
include/configs/imx8mm-cl-iot-gate.h +0 -3
index 6442e3d570f4..146f7945719f 100644
@@ -137,7 +137,4 @@
 
 #define CFG_FEC_MXC_PHYADDR		-1 /* Auto search of PHY on MII */
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif /*__IMX8MM_CL_IOT_GATE_H*/
include/configs/kontron-sl-mx6ul.h +0 -4
index e68c667c5057..015df01db4e6 100644
@@ -24,10 +24,6 @@
 /* Board and environment settings */
 #define CFG_MXC_UART_BASE		UART4_BASE
 
-#ifdef CONFIG_USB_EHCI_HCD
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* Boot order for distro boot */
 #define BOOT_TARGET_DEVICES(func) \
 	func(MMC, mmc, 1) \
include/configs/kontron-sl-mx8mm.h +0 -4
index be1f70a9a598..3a129c5cce77 100644
@@ -24,10 +24,6 @@
 
 /* Board and environment settings */
 
-#ifdef CONFIG_USB_EHCI_HCD
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* GUID for capsule updatable firmware image */
 #define KONTRON_SL_MX8MM_FIT_IMAGE_GUID \
 	EFI_GUID(0xd488e45a, 0x4929, 0x4b55, 0x8c, 0x14, \
include/configs/kp_imx53.h +0 -3
index 91caf03091c4..48adff3f03a7 100644
@@ -10,9 +10,6 @@
 #include <asm/arch/imx-regs.h>
 #include <linux/sizes.h>
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Command definition */
 
 #define CFG_EXTRA_ENV_SETTINGS \
include/configs/kp_imx6q_tpc.h +0 -5
index 74f6e4e9f963..c0cb3db23e7a 100644
@@ -16,11 +16,6 @@
 
 /* FEC ethernet */
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #define CFG_EXTRA_ENV_SETTINGS	\
 	"console=ttymxc0,115200\0"	\
 	"fdt_addr=0x18000000\0"		\
include/configs/liteboard.h +0 -5
index 25c30e6c6a5d..fc6bc6b28baa 100644
@@ -93,11 +93,6 @@
 
 /* FLASH and environment organization */
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_ENET_DEV		0
 
include/configs/m53menlo.h +0 -7
index 51ce030d831e..b5943f48c69f 100644
@@ -66,13 +66,6 @@
 #define CFG_SYS_I2C_RTC_ADDR		0x68
 #endif
 
-/*
- * USB
- */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* LVDS display */
 #define CFG_SYS_LDB_CLOCK			33260000
 
include/configs/meerkat96.h +0 -3
index 6ffc1282411a..8e248177b1ca 100644
@@ -23,7 +23,4 @@
 
 /* Environment configs */
 
-/* USB configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif
include/configs/mx53cx9020.h +0 -3
index 38bafc5156dd..2ee5cc40e541 100644
@@ -21,9 +21,6 @@
 
 /* bootz: zImage/initrd.img support */
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Command definition */
 
 #define BOOT_TARGET_DEVICES(func) \
include/configs/mx53loco.h +0 -3
index e9340c59ae1b..cec3658b1891 100644
@@ -16,9 +16,6 @@
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* PMIC Controller */
 #define CFG_SYS_DIALOG_PMIC_I2C_ADDR	0x48
 #define CFG_SYS_FSL_PMIC_I2C_ADDR	0x8
include/configs/mx53ppd.h +0 -3
index e0bfbbb459cf..6e1cbec0c1f4 100644
@@ -11,9 +11,6 @@
 
 #include <asm/arch/imx-regs.h>
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Command definition */
 
 #define PPD_CONFIG_NFS \
include/configs/mx6cuboxi.h +0 -3
index f0d6405d3012..068b9e4d25f1 100644
@@ -14,9 +14,6 @@
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC2_BASE_ADDR
 
-/* USB */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Command definition */
 
 #define CFG_MXC_UART_BASE	UART1_BASE
include/configs/mx6memcal.h +0 -1
index f2edd13eb881..a966c8b2a446 100644
@@ -31,6 +31,5 @@
 #define CFG_SYS_INIT_RAM_ADDR       IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE       IRAM_SIZE
 
-#define CFG_MXC_USB_PORTSC	PORT_PTS_UTMI
 
 #endif	       /* __CONFIG_H */
include/configs/mx6sabreauto.h +0 -3
index eb963cbb0b3b..e491af3e9278 100644
@@ -11,9 +11,6 @@
 #define CFG_MXC_UART_BASE	UART4_BASE
 #define CONSOLE_DEV		"ttymxc3"
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define CFG_SYS_I2C_PCA953X_WIDTH	{ {0x30, 8}, {0x32, 8}, {0x34, 8} }
 
 #include "mx6sabre_common.h"
include/configs/mx6sabresd.h +0 -5
index 9160f878f4b3..e34947c94d00 100644
@@ -24,9 +24,4 @@
 #define CFG_PCIE_IMX_POWER_GPIO	IMX_GPIO_NR(3, 19)
 #endif
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #endif                         /* __MX6SABRESD_CONFIG_H */
include/configs/mx6slevk.h +0 -5
index 65c6cdd4b87b..d4e66a39882c 100644
@@ -88,11 +88,6 @@
 
 /* Environment organization */
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #define CFG_SYS_FSL_USDHC_NUM	3
 
 #endif				/* __CONFIG_H */
include/configs/mx6sllevk.h +0 -5
index 290996b51bc7..0ba4054bbe4a 100644
@@ -92,10 +92,5 @@
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC1_BASE_ADDR
 #define CFG_SYS_FSL_USDHC_NUM	3
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #include <linux/stringify.h>
 #endif				/* __CONFIG_H */
include/configs/mx6sxsabreauto.h +0 -4
index 4e163d28e63d..36d82e81d5dd 100644
@@ -95,10 +95,6 @@
 #define IMX_FEC_BASE			ENET2_BASE_ADDR
 #define CFG_FEC_MXC_PHYADDR          0x0
 
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #define CFG_SYS_FSL_USDHC_NUM	2
 
 #endif				/* __CONFIG_H */
include/configs/mx6sxsabresd.h +0 -4
index b43a1d813151..844becbfd2ce 100644
@@ -117,10 +117,6 @@
 
 #define CFG_FEC_MXC_PHYADDR          0x1
 
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #ifdef CONFIG_CMD_PCI
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(2, 0)
 #define CFG_PCIE_IMX_POWER_GPIO	IMX_GPIO_NR(2, 1)
include/configs/mx6ul_14x14_evk.h +0 -5
index fd0c87ffb012..3716dc75b966 100644
@@ -114,11 +114,6 @@
 
 /* environment organization */
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_ENET_DEV		1
 
include/configs/mx7dsabresd.h +0 -3
index 94bee75fdea5..f5ab47207504 100644
@@ -98,7 +98,4 @@
 /* DMA stuff, needed for GPMI/MXS NAND support */
 #endif
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif	/* __CONFIG_H */
include/configs/mx7ulp_com.h +0 -1
index a310c64e7948..f8e3950fa321 100644
@@ -51,5 +51,4 @@
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	SZ_256K
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 #endif	/* __CONFIG_H */
include/configs/mys_6ulx.h +0 -3
index 8defdfc4fda6..ddd46c8f945b 100644
@@ -29,9 +29,6 @@
 /* NAND */
 #define CFG_SYS_NAND_BASE		0x40000000
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
 	"fdt_addr_r=0x82000000\0" \
include/configs/nitrogen6x.h +0 -3
index a8ad85050f79..23eefaffc721 100644
@@ -18,9 +18,6 @@
 #define IMX_FEC_BASE			ENET_BASE_ADDR
 #define CFG_FEC_MXC_PHYADDR		6
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #ifdef CONFIG_CMD_MMC
 #define DISTRO_BOOT_DEV_MMC(func) func(MMC, mmc, 0) func(MMC, mmc, 1)
 #else
include/configs/novena.h +0 -5
index 144cf1b4a4b8..059b8104e4b4 100644
@@ -51,11 +51,6 @@
 /* UART */
 #define CFG_MXC_UART_BASE		UART2_BASE
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* Extra U-Boot environment. */
 #define CFG_EXTRA_ENV_SETTINGS					\
 	"fdt_high=0xffffffff\0"						\
include/configs/npi_imx6ull.h +0 -3
index f71e2657076b..1caa63f0227b 100644
@@ -28,9 +28,6 @@
 /* NAND */
 #define CFG_SYS_NAND_BASE		0x40000000
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_MXC_PHYADDR		0x1
 #endif
include/configs/o4-imx6ull-nano.h +0 -4
index 9050da8738b1..f5a4898f90e6 100644
@@ -11,10 +11,6 @@
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
-#if IS_ENABLED(CONFIG_CMD_USB)
-#	define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif /* CONFIG_CMD_USB */
-
 #define CFG_EXTRA_ENV_SETTINGS \
 	"mmcdev=0\0" \
 	"mmcpart=2\0" \
include/configs/opos6uldev.h +0 -5
index 12020d31e1c7..fd945235af37 100644
@@ -17,11 +17,6 @@
 #define CFG_SYS_INIT_RAM_ADDR	IRAM_BASE_ADDR
 #define CFG_SYS_INIT_RAM_SIZE	IRAM_SIZE
 
-/* USB */
-#ifdef CONFIG_USB_EHCI_MX6
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 /* LCD */
 #define MXS_LCDIF_BASE MX6UL_LCDIF1_BASE_ADDR
 
include/configs/pcl063.h +0 -3
index 2a729c3e4544..0c96506b5fbe 100644
@@ -41,9 +41,6 @@
 /* NAND */
 #define CFG_SYS_NAND_BASE		0x40000000
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0,115200n8\0" \
 	"fdt_addr_r=0x82000000\0" \
include/configs/pcl063_ull.h +0 -3
index afa8e7aeb716..0f265adc5dca 100644
@@ -43,9 +43,6 @@
 /* NAND */
 #define CFG_SYS_NAND_BASE		0x40000000
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define ENV_MMC \
 	"mmcdev=" __stringify(MMC_ROOTFS_DEV) "\0" \
 	"mmcpart=" __stringify(MMC_ROOTFS_PART) "\0" \
include/configs/pico-imx6.h +0 -3
index 6ccb3dc19021..500dd8c069ae 100644
@@ -15,9 +15,6 @@
 /* MMC Configuration */
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC3_BASE_ADDR
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
 #define CFG_DFU_ENV_SETTINGS \
include/configs/pico-imx6ul.h +0 -3
index ef8281440e5d..37f4c7d8a098 100644
@@ -21,9 +21,6 @@
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR	USDHC1_BASE_ADDR
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
 #define CFG_DFU_ENV_SETTINGS \
include/configs/pico-imx7d.h +0 -3
index 21ec7fd3362c..89850d8e4a7e 100644
@@ -105,7 +105,4 @@
 
 #define CFG_SYS_FSL_USDHC_NUM		2
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC			(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif
include/configs/somlabs_visionsom_6ull.h +0 -5
index aa09528acd97..c8fdb40d011b 100644
@@ -59,11 +59,6 @@
 
 /* environment organization */
 
-/* USB Configs */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif
-
 #ifdef CONFIG_CMD_NET
 #define CFG_FEC_MXC_PHYADDR		0x1
 #endif
include/configs/tbs2910.h +0 -5
index 256331ae1733..9ef774afd0f9 100644
@@ -25,11 +25,6 @@
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(7, 12)
 #endif
 
-/* USB */
-#ifdef CONFIG_CMD_USB
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-#endif /* CONFIG_CMD_USB      */
-
 #define CFG_EXTRA_ENV_SETTINGS \
 	BOOTENV \
 	"bootargs_mmc1=console=ttymxc0,115200 di0_primary console=tty1\0" \
include/configs/tqma6.h +0 -3
index b4a06a75c538..e85c801e4fbe 100644
@@ -29,9 +29,6 @@
 /* MMC Configs */
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #if defined(CONFIG_TQMA6X_MMC_BOOT)
 
 #define TQMA6_UBOOT_OFFSET		SZ_1K
include/configs/usbarmory.h +0 -3
index 1d7caaa1448f..b895022ee9cc 100644
@@ -22,9 +22,6 @@
 /* SD/MMC */
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
-/* USB */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 /* Linux boot */
 
 #define BOOT_TARGET_DEVICES(func) func(MMC, mmc, 0)
include/configs/verdin-imx8mm.h +0 -3
index 12d2b6823058..b018bbe29dd1 100644
@@ -63,7 +63,4 @@
 #define PHYS_SDRAM_2                 0x100000000
 #define PHYS_SDRAM_2_SIZE            (long)(SZ_1G)
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC	(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #endif /* __VERDIN_IMX8MM_H */
include/configs/vining_2000.h +0 -1
index 3c2d7e668917..2cf7bc70d8de 100644
@@ -36,7 +36,6 @@
 /* Network */
 #define CFG_FEC_MXC_PHYADDR          0x0
 
-#define CFG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
 #ifdef CONFIG_CMD_PCI
 #define CFG_PCIE_IMX_PERST_GPIO	IMX_GPIO_NR(4, 6)
include/configs/wandboard.h +0 -3
index d64c4262bd69..b5b342b35383 100644
@@ -16,9 +16,6 @@
 #define CFG_SYS_FSL_USDHC_NUM	2
 #define CFG_SYS_FSL_ESDHC_ADDR	0
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define CFG_EXTRA_ENV_SETTINGS \
 	"console=ttymxc0\0" \
 	"splashpos=m,m\0" \
include/configs/warp7.h +0 -1
index 0da9250c3b78..a5278d1cb9b8 100644
@@ -92,7 +92,6 @@
 
 #define CFG_SYS_FSL_USDHC_NUM	1
 
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
 
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT	300
include/configs/xpress.h +0 -3
index bb0a30c4344f..8efebf77c3d6 100644
@@ -27,9 +27,6 @@
 
 /* Environment is in stored in the eMMC boot partition */
 
-/* USB Configs */
-#define CFG_MXC_USB_PORTSC		(PORT_PTS_UTMI | PORT_PTS_PTW)
-
 #define CFG_FEC_ENET_DEV		0
 #define CFG_FEC_MXC_PHYADDR          0x0
 
Signature · 1 line
2.34.1
Reviewed-by on v3 4/4
#6 lore raw

Re: [PATCH v3 4/4] imx: Remove CFG_MXC_USB_PORTSC

Quoted 67 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

---
Changes since v2:
- Keep mx51evk.h intact as it uses a different CFG_MXC_USB_PORTSC definition.

  include/configs/apalis_imx6.h            | 4 ----
  include/configs/aristainetos2.h          | 3 ---
  include/configs/brppt2.h                 | 3 ---
  include/configs/cl-som-imx7.h            | 3 ---
  include/configs/cm_fx6.h                 | 3 ---
  include/configs/colibri-imx6ull.h        | 4 ----
  include/configs/colibri_imx6.h           | 4 ----
  include/configs/colibri_imx7.h           | 4 ----
  include/configs/dart_6ul.h               | 3 ---
  include/configs/dh_imx6.h                | 3 ---
  include/configs/display5.h               | 1 -
  include/configs/embestmx6boards.h        | 3 ---
  include/configs/ge_b1x5v2.h              | 3 ---
  include/configs/gw_ventana.h             | 3 ---
  include/configs/imx6_logic.h             | 5 -----
  include/configs/imx6dl-mamoj.h           | 3 ---
  include/configs/imx6q-bosch-acc.h        | 1 -
  include/configs/imx7-cm.h                | 3 ---
  include/configs/imx8mm-cl-iot-gate.h     | 3 ---
  include/configs/kontron-sl-mx6ul.h       | 4 ----
  include/configs/kontron-sl-mx8mm.h       | 4 ----
  include/configs/kp_imx53.h               | 3 ---
  include/configs/kp_imx6q_tpc.h           | 5 -----
  include/configs/liteboard.h              | 5 -----
  include/configs/m53menlo.h               | 7 -------
  include/configs/meerkat96.h              | 3 ---
  include/configs/mx53cx9020.h             | 3 ---
  include/configs/mx53loco.h               | 3 ---
  include/configs/mx53ppd.h                | 3 ---
  include/configs/mx6cuboxi.h              | 3 ---
  include/configs/mx6memcal.h              | 1 -
  include/configs/mx6sabreauto.h           | 3 ---
  include/configs/mx6sabresd.h             | 5 -----
  include/configs/mx6slevk.h               | 5 -----
  include/configs/mx6sllevk.h              | 5 -----
  include/configs/mx6sxsabreauto.h         | 4 ----
  include/configs/mx6sxsabresd.h           | 4 ----
  include/configs/mx6ul_14x14_evk.h        | 5 -----
  include/configs/mx7dsabresd.h            | 3 ---
  include/configs/mx7ulp_com.h             | 1 -
  include/configs/mys_6ulx.h               | 3 ---
  include/configs/nitrogen6x.h             | 3 ---
  include/configs/novena.h                 | 5 -----
  include/configs/npi_imx6ull.h            | 3 ---
  include/configs/o4-imx6ull-nano.h        | 4 ----
  include/configs/opos6uldev.h             | 5 -----
  include/configs/pcl063.h                 | 3 ---
  include/configs/pcl063_ull.h             | 3 ---
  include/configs/pico-imx6.h              | 3 ---
  include/configs/pico-imx6ul.h            | 3 ---
  include/configs/pico-imx7d.h             | 3 ---
  include/configs/somlabs_visionsom_6ull.h | 5 -----
  include/configs/tbs2910.h                | 5 -----
Quoted 8 lines
  include/configs/tqma6.h                  | 3 ---
  include/configs/usbarmory.h              | 3 ---
  include/configs/verdin-imx8mm.h          | 3 ---
  include/configs/vining_2000.h            | 1 -
  include/configs/wandboard.h              | 3 ---
  include/configs/warp7.h                  | 1 -
  include/configs/xpress.h                 | 3 ---
  60 files changed, 203 deletions(-)

Thanks,
Soeren

Reviewed-by on v3 4/4
#7 lore raw

Re: [PATCH v3 4/4] imx: Remove CFG_MXC_USB_PORTSC

In reply to Fabio Estevam
Quoted 9 lines · Fabio Estevam

From: Fabio Estevam <[email protected]>

The definition of CFG_MXC_USB_PORTSC as (PORT_PTS_UTMI | PORT_PTS_PTW) can be removed from mx5/mx6/mx7/mx8m board config files as it is the default in drivers/usb/host/ehci-mx5.c and drivers/usb/host/ehci-mx6.c.

author reviewer
#8 lore raw
In reply to Fabio Estevam
Quoted 4 lines · Fabio Estevam
 include/configs/m53menlo.h               | 1 -
 include/configs/mx53cx9020.h             | 1 -
 include/configs/mx53loco.h               | 1 -
 include/configs/mx53ppd.h                | 1 -

I kept the mx5 lines and applied all, thanks.