support/scripts/genimage.sh: drop gzip compression
PATCH 1/1 support/scripts/genimage.sh: drop gzip compression
Commit 6889056f1eb4 (support/scripts/genimage.sh: support creating a bmap image) added unconditional gzip compression of the genimage outputs if bmap-tools is enabled, which is problematic for a number of reasons:
- The gzip invocation is not reproducable (E.G. does not use -n)
- The original file is removed, dropping the sparse info
- It hardcodes policy, E.G. bmap supports a number of different compression algorithms / compression may not be desired for all images / different compression levels may be desired
So drop the compression step. If desired, compression can be done with a post-image script.
--- support/scripts/genimage.sh | 1 - 1 file changed, 1 deletion(-)
support/scripts/genimage.sh +0 -1
@@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then continue fi bmaptool create "${image_path}" -o "${image_path}.bmap" - gzip -c "${image_path}" > "${image_path}.gz" done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2) fi
Signature · 6 lines
2.39.2 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
Quoted 30 lines · Peter Korsgaard
Commit
6889056f1eb4(support/scripts/genimage.sh: support creating a bmap image) added unconditional gzip compression of the genimage outputs if bmap-tools is enabled, which is problematic for a number of reasons:- The gzip invocation is not reproducable (E.G. does not use -n)
- The original file is removed, dropping the sparse info
- It hardcodes policy, E.G. bmap supports a number of different compression algorithms / compression may not be desired for all images / different compression levels may be desired
So drop the compression step. If desired, compression can be done with a post-image script.
Signed-off-by Peter Korsgaard <[email protected]>---
support/scripts/genimage.sh| 1 -1 file changed, 1 deletion(-)support/scripts/genimage.sh +0
-1@@ -54,6 +54,5 @@ if grep -Eq "^BR2_PACKAGE_HOST_BMAP_TOOLS=y$" "${BR2_CONFIG}"; then continue fi bmaptool create "${image_path}" -o "${image_path}.bmap" - gzip -c "${image_path}" > "${image_path}.gz" done < <(grep '^image ' "${GENIMAGE_CFG}" | cut -d ' ' -f 2)
Quoted 8 lines
fi
Signature · 6 lines
2.39.2 _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot
Thomas Petazzoni via buildroot
AppliedQuoted 12 lines · On Fri, 30 Aug 2024 10:26:49 +0200 Peter Korsgaard <[email protected]> wrote:
Commit
6889056f1eb4(support/scripts/genimage.sh: support creating a bmap image) added unconditional gzip compression of the genimage outputs if bmap-tools is enabled, which is problematic for a number of reasons:- The gzip invocation is not reproducable (E.G. does not use -n)
- The original file is removed, dropping the sparse info
- It hardcodes policy, E.G. bmap supports a number of different compression algorithms / compression may not be desired for all images / different compression levels may be desired
Quoted 7 lines
So drop the compression step. If desired, compression can be done with a post-image script.
Signed-off-by Peter Korsgaard <[email protected]>--- support/scripts/genimage.sh | 1 - 1 file changed, 1 deletion(-)
Applied to master, thanks.
Thomas
Signature · 7 lines
Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list [email protected] https://lists.buildroot.org/mailman/listinfo/buildroot