mpi3mr: a performance fix
Subsystems (2)
PATCH v2 1/1 mpi3mr: a performance fix
Commit 0c52310f2600 ("hrtimer: Ignore slack time for RT tasks in schedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver.
That is causing a performance regression as the new value
of just 2us is too low, in certain tests the perf drop is ~30%.
Fix this by adjusting the sleep to 20us (close to the previous value).
The '+1' added to the max parameter in usleep_range is there just to silence static code analyzers like checkpatch.
---
V2: added a '+ 1' to silence checkpatch.
--- drivers/scsi/mpi3mr/mpi3mr.h | 2 +- drivers/scsi/mpi3mr/mpi3mr_fw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/mpi3mr/mpi3mr.h +1 -1
@@ -178,7 +178,7 @@ extern atomic64_t event_counter;#define MPI3MR_DEFAULT_SDEV_QD 32/* Definitions for Threaded IRQ poll*/ -#define MPI3MR_IRQ_POLL_SLEEP 2 +#define MPI3MR_IRQ_POLL_SLEEP 20#define MPI3MR_IRQ_POLL_TRIGGER_IOCOUNT 8/* Definitions for the controller security status*/
drivers/scsi/mpi3mr/mpi3mr_fw.c +1 -1
@@ -710,7 +710,7 @@ static irqreturn_t mpi3mr_isr_poll(int irq, void *privdata)mpi3mr_process_op_reply_q (mrioc, intr_info->op_reply_q); -usleep_range (MPI3MR_IRQ_POLL_SLEEP ,10 *MPI3MR_IRQ_POLL_SLEEP ); +usleep_range (MPI3MR_IRQ_POLL_SLEEP ,MPI3MR_IRQ_POLL_SLEEP +1 ); }while (atomic_read (&intr_info->op_reply_q->pend_ios) && (num_op_reply < mrioc->max_host_ios));
Signature · 1 line
2.45.2
Martin K. Petersen
AppliedTomas,
Quoted 6 lines
Commit
0c52310f2600("hrtimer: Ignore slack time for RT tasks inschedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver. That is causing a performance regression as the new value of just 2us is too low, in certain tests the perf drop is ~30%. Fix this by adjusting the sleep to 20us (close to the previous value).
Applied to 6.12/scsi-staging, thanks!
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen
AppliedQuoted 10 lines · Tomas Henzl
Commit
0c52310f2600("hrtimer: Ignore slack time for RT tasks inschedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver.
That is causing a performance regression as the new value
of just 2us is too low, in certain tests the perf drop is ~30%.
Fix this by adjusting the sleep to 20us (close to the previous value).The '+1' added to the max parameter in
usleep_rangeis there just to silence static code analyzers like checkpatch.[...]
Applied to 6.12/scsi-queue, thanks!
[1/1] mpi3mr: a performance fix
https://git.kernel.org/mkp/scsi/c/24d7071d9645
Signature · 1 line
Martin K. Petersen Oracle Linux Engineering