Skip to contentSkip to conversation

mpi3mr: a perfomance fix

PATCH Superseded Tomas Henzl 3 participants 4 messages Aug 3, 2024 – Aug 25, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mpi3mr: a perfomance fix

Patch 0c52310f2600 ("hrtimer: Ignore slack time for RT tasks in schedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver.
That is causing a perfomance regression as the new value
of just 2us is too low. In certain test the perf drop is ~30%.
Fix this by adjusting the sleep to 20us (close to the previous value).

---
 drivers/scsi/mpi3mr/mpi3mr.h    | 2 +-
 drivers/scsi/mpi3mr/mpi3mr_fw.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/scsi/mpi3mr/mpi3mr.h +1 -1
index dc2cdd5f0311..249c1a7285d6 100644
@@ -178,7 +178,7 @@ extern atomic64_t event_counter;
 #define MPI3MR_DEFAULT_SDEV_QD	32
 
 /* Definitions for Threaded IRQ poll*/
-#define MPI3MR_IRQ_POLL_SLEEP			2
+#define MPI3MR_IRQ_POLL_SLEEP			20
 #define MPI3MR_IRQ_POLL_TRIGGER_IOCOUNT		8
 
 /* Definitions for the controller security status*/
drivers/scsi/mpi3mr/mpi3mr_fw.c +1 -1
index c196dc14ad20..5695c95fca15 100644
@@ -710,7 +710,7 @@ static irqreturn_t mpi3mr_isr_poll(int irq, void *privdata)
 			    mpi3mr_process_op_reply_q(mrioc,
 				intr_info->op_reply_q);
 
-		usleep_range(MPI3MR_IRQ_POLL_SLEEP, 10 * MPI3MR_IRQ_POLL_SLEEP);
+		usleep_range(MPI3MR_IRQ_POLL_SLEEP, MPI3MR_IRQ_POLL_SLEEP);
 
 	} while (atomic_read(&intr_info->op_reply_q->pend_ios) &&
 	    (num_op_reply < mrioc->max_host_ios));
Signature · 1 line
2.45.2
#1 lore raw
Quoted 7 lines

Patch 0c52310f2600 ("hrtimer: Ignore slack time for RT tasks in schedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver. That is causing a perfomance regression as the new value of just 2us is too low. In certain test the perf drop is ~30%. Fix this by adjusting the sleep to 20us (close to the previous value).

Broadcom: Please review, thanks!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
#2 lore raw
In reply to Tomas Henzl
Quoted 7 lines

Patch 0c52310f2600 ("hrtimer: Ignore slack time for RT tasks in schedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver. That is causing a perfomance regression as the new value of just 2us is too low. In certain test the perf drop is ~30%. Fix this by adjusting the sleep to 20us (close to the previous value).

Broadcom: Please review!

Signature · 1 line
Martin K. Petersen	Oracle Linux Engineering
maintainer Acked-by on v1 1/1
#3 lore raw
In reply to Tomas Henzl
Quoted 9 lines · Tomas Henzl

Patch 0c52310f2600 ("hrtimer: Ignore slack time for RT tasks in schedule_hrtimeout_range()") effectivelly shortens a sleep in a polling function in the driver.
That is causing a perfomance regression as the new value
of just 2us is too low. In certain test the perf drop is ~30%.
Fix this by adjusting the sleep to 20us (close to the previous value).

Looks good to me.