Correct WL-355608-A8 panel compatible
Subsystems (4)
v3 cover Correct WL-355608-A8 panel compatible
Hi,
V3 of this patch updated to reflect discussion and agreement to use the integrating vendor prefix and device names for this display panel.
The previous patch adding support for this panel [1] referred to previously by its serial number only. As discussed after the patch was committed, the preference is to use the integrating device vendor and name in this circumstance.
This series corrects the panel compatible to reflect the integrating vendor (Anbernic, already in the vendor prefix table) and device names (adding fallbacks for the variants using the same panel), and updates the NV3052C panel driver with the new compatible.
Ryan Walklin (2):
dt-bindings: display: panel: Rename WL-355608-A8 panel to
rg35xx-*-panel
drm: panel: nv3052c: Correct WL-355608-A8 panel compatible
...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++++++++++----
drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +-
2 files changed, 12 insertions(+), 5 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-plus-panel.yaml} (67%)Signature · 1 line
2.46.0
PATCH v3 1/2 dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however following subsequent discussion the preference is to use the integrating device vendor and name where the OEM is unknown.
There are 4 RG35XX series devices from Anbernic based on an Allwinner H700 SoC using this panel, with the -Plus variant introduced first. Therefore the -Plus is used as the fallback for the subsequent -H, -2024, and -SP devices.
Alter the filename and compatible string to reflect the convention.
--
Changelog v1..v2:
- Use known panel serial for compatible name rather than referencing integrating devices as per feedback [1] from DT maintainers.
Changelog v2..v3:
- Use integrating device names rather than panel serial number for compatible string as per further maintainer feedback [2].
[1] https://lore.kernel.org/linux-devicetree/[email protected]/#t
[2] https://lore.kernel.org/dri-devel/[email protected]/
---
...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-plus-panel.yaml} (67%)Documentation/devicetree/bindings/display/panel/anbernic,rg35xx-plus-panel.yaml renamed from Documentation/devicetree/bindings/display/panel/wl-355608-a8.yaml +11 -4
@@ -1,10 +1,10 @@ # SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 --- -$id: http://devicetree.org/schemas/display/panel/wl-355608-a8.yaml# +$id: http://devicetree.org/schemas/display/panel/anbernic,rg35xx-plus-panel.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: WL-355608-A8 3.5" (640x480 pixels) 24-bit IPS LCD panel +title: Anbernic RG35XX series (WL-355608-A8) 3.5" 640x480 24-bit IPS LCD panel maintainers: - Ryan Walklin <[email protected]>
@@ -15,7 +15,14 @@ allOf: properties: compatible: - const: wl-355608-a8 + oneOf: + - const: anbernic,rg35xx-plus-panel + - items: + - enum: + - anbernic,rg35xx-2024-panel + - anbernic,rg35xx-h-panel + - anbernic,rg35xx-sp-panel + - const: anbernic,rg35xx-plus-panel reg: maxItems: 1
@@ -40,7 +47,7 @@ examples: #size-cells = <0>; panel@0 { - compatible = "wl-355608-a8"; + compatible = "anbernic,rg35xx-plus-panel"; reg = <0>; spi-3wire;
Signature · 1 line
2.46.0
Re: [PATCH v3 1/2] dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel
Quoted 25 lines · Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however following subsequent discussion the preference is to use the integrating device vendor and name where the OEM is unknown.
There are 4 RG35XX series devices from Anbernic based on an Allwinner H700 SoC using this panel, with the -Plus variant introduced first. Therefore the -Plus is used as the fallback for the subsequent -H, -2024, and -SP devices.
Alter the filename and compatible string to reflect the convention.
Fixes f08aac40639c ("drm: panel: nv3052c: Add WL-355608-A8 panel")Signed-off-by Ryan Walklin <[email protected]>--
Changelog v1..v2:
- Use known panel serial for compatible name rather than referencing integrating devices as per feedback [1] from DT maintainers.Changelog v2..v3:
- Use integrating device names rather than panel serial number for compatible string as per further maintainer feedback [2].
Quoted 8 lines
[1] https://lore.kernel.org/linux-devicetree/[email protected]/#t
[2] https://lore.kernel.org/dri-devel/[email protected]/
--- ...08-a8.yaml => anbernic,rg35xx-plus-panel.yaml} | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) rename Documentation/devicetree/bindings/display/panel/{wl-355608-a8.yaml => anbernic,rg35xx-plus-panel.yaml} (67%)
Re: (subset) [PATCH v3 1/2] dt-bindings: display: panel: Rename WL-355608-A8 panel to rg35xx-*-panel
In reply to Ryan WalklinQuoted 6 lines · Ryan Walklin
The WL-355608-A8 is a 3.5" 640x480@60Hz RGB LCD display from an unknown OEM used in a number of handheld gaming devices made by Anbernic. Previously committed using the OEM serial without a vendor prefix, however following subsequent discussion the preference is to use the integrating device vendor and name where the OEM is unknown.
Quoted 6 lines
There are 4 RG35XX series devices from Anbernic based on an Allwinner H700 SoC using this panel, with the -Plus variant introduced first. Therefore the -Plus is used as the fallback for the subsequent -H, -2024, and -SP devices.
[...]
Applied to misc/kernel.git (drm-misc-fixes).
Thanks!
Maxime
PATCH v3 2/2 drm: panel: nv3052c: Correct WL-355608-A8 panel compatible
In reply to Ryan WalklinAs per the previous dt-binding commit, update the WL-355608-A8 panel compatible to reflect the the integrating device vendor and name as the panel OEM is unknown.
--
Changelog v2..v3:
- Use integrating device name with vendor prefix instead of OEM serial.
--- drivers/gpu/drm/panel/panel-newvision-nv3052c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/panel/panel-newvision-nv3052c.c +1 -1
@@ -925,7 +925,7 @@ MODULE_DEVICE_TABLE(spi, nv3052c_ids);static const struct of_device_id nv3052c_of_match[] = { { .compatible ="leadtek,ltk035c5444t" , .data = <k035c5444t_panel_info }, { .compatible ="fascontek,fs035vg158" , .data = &fs035vg158_panel_info }, - { .compatible ="wl-355608-a8" , .data = &wl_355608_a8_panel_info }, + { .compatible ="anbernic,rg35xx-plus-panel" , .data = &wl_355608_a8_panel_info }, {/* sentinel */ } };MODULE_DEVICE_TABLE (of, nv3052c_of_match);
Signature · 1 line
2.46.0
Re: (subset) [PATCH v3 2/2] drm: panel: nv3052c: Correct WL-355608-A8 panel compatible
Quoted 11 lines · Ryan Walklin
As per the previous dt-binding commit, update the WL-355608-A8 panel compatible to reflect the the integrating device vendor and name as the panel OEM is unknown.
Signed-off-by Ryan Walklin <[email protected]>--
Changelog v2..v3:
- Use integrating device name with vendor prefix instead of OEM serial.[...]
Applied to misc/kernel.git (drm-misc-fixes).
Thanks!
Maxime