Add support for Ariaboard Photonicat RK3568
Subsystems (2)
v2 cover Add support for Ariaboard Photonicat RK3568
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-A
Changed from v1:
- move some general nodes (firmware, ramoops, reboot-mode) to rk356x.dtsi
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- rename rk3568-ariaboard-photonicat.dts to rk3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/
Junhao Xie (3):
dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 595 ++++++++++++++++++ 4 files changed, 603 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Signature · 1 line
2.46.0
PATCH v2 1/3 dt-bindings: vendor-prefixes: Add prefix for Ariaboard
Add an entry for Ariaboard from Shanghai Novotech
Ariaboard represents a product line from Shanghai Novotech Co., Ltd.
--- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/vendor-prefixes.yaml +2 -0
@@ -145,6 +145,8 @@ patternProperties: description: Arctic Sand "^arcx,.*": description: arcx Inc. / Archronix Inc. + "^ariaboard,.*": + description: Shanghai Novotech Co., Ltd. (Ariaboard) "^aries,.*": description: Aries Embedded GmbH "^arm,.*":
Signature · 1 line
2.46.0
Re: [PATCH v2 1/3] dt-bindings: vendor-prefixes: Add prefix for Ariaboard
Quoted 8 lines · Junhao Xie
Add an entry for Ariaboard from Shanghai Novotech
Ariaboard represents a product line from Shanghai Novotech Co., Ltd.
Signed-off-by Junhao Xie <[email protected]>
Best regards,
Krzysztof
PATCH v2 2/3 dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
In reply to Junhao XieThis documents Ariaboard Photonicat which is a router based on RK3568 SoC.
--- Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ 1 file changed, 5 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +5 -0
@@ -49,6 +49,11 @@ properties: - anbernic,rg-arc-s - const: rockchip,rk3566 + - description: Ariaboard Photonicat RK3568 + items: + - const: ariaboard,photonicat + - const: rockchip,rk3568 + - description: ArmSoM Sige7 board items: - const: armsom,sige7
Signature · 1 line
2.46.0
Re: [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
Hi Junhao,
Quoted 1 line
+ - description: Ariaboard Photonicat RK3568
This should match the model name.
Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4
-0+ items: + - const: ariaboard,photonicat + - const: rockchip,rk3568 +
Signature · 1 line
2.25.1
Re: [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
Quoted 11 lines · Chukun Pan
Hi Junhao,
Quoted 1 line
+ - description: Ariaboard Photonicat RK3568
This should match the model name.
Quoted 4 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +4
-0+ items: + - const: ariaboard,photonicat + - const: rockchip,rk3568 +
I will correct it in next version.
Thanks for your review.
Best regards,
Junhao
PATCH v2 3/3 arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
In reply to Junhao XieAdd dts for Ariaboard Photonicat RK3568.
Working IO:
Debug UART
SDIO QCA9377 WiFi and Bluetooth
M.2 E-Key PCIe WiFi and Bluetooth
M.2 B-Key USB Modem WWAN
Ethernet WAN Port
MicroSD Card slot
eMMC
HDMI Output
Mali GPU
USB Type-A
Not working IO:
Ethernet LAN Port (Lack of SGMII support) Power management MCU on UART4 (Driver pending)
Not working IO in MCU:
Battery voltage sensor
Board temperature sensor
Hardware Power-off
Hardware Watchdog
Network status LED
Real-time clock
USB Charger voltage sensor
About onboard power management MCU:
A heartbeat must be sent to the MCU within 60 seconds, otherwise the MCU will restart the system.
When powering off, a shutdown command needs to be sent to the MCU. When the power button is long pressed, the MCU will send a shutdown command to the system. If system does not shutdown within 60 seconds, the power will be turned off directly.
MCU only provides voltage for charger and battery. Manufacturer removed RK8xx PMIC.
--- arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 595 ++++++++++++++++++ 2 files changed, 596 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
@@ -130,6 +130,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-jaguar.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-nanopc-t6.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-ok3588-c.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-orangepi-5-plus.dtb +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-photonicat.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-quartzpro64.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5-itx.dtb dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-rock-5b.dtb
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +595 -0
595 lines not on this page · raw message
Signature · 1 line
2.46.0
Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Hi Junhao,
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 10
Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +10
-0@@ -0,0 +1,595 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> +#include <dt-bindings/soc/rockchip,boot-mode.h>
No need for input.h, leds/common.h and boot-mode.h.
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 115
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +3
-0+#include "rk3568.dtsi" + vcc3v3_sd: regulator-3v3-vcc-sd { + pinctrl-0 = <&vcc_sd_h>;
schematics: sdmmc0_pwren
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 133
Quoted 2 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc3v3_rf: regulator-3v3-vcc-rf {
schematics: VCC3V4_RFVCCIN_5V -> VCC3V4_RF
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 2 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ pinctrl-names = "default"; + pinctrl-0 = <&vcc3v3_rf_pwren_en>;
schematics: RF_PWR_EN
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 145
Quoted 2 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc5v0_sysin: regulator-5v0-vcc-sysin {
schematics: VCC_SYSIN
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 154
Quoted 2 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc5v0_syson: regulator-5v0-vcc-syson {
schematics: VCC_SYSON
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 173
Quoted 4 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host { + vin-supply = <&vcc5v0_syson>;
VCCIN_5V -> VCC5V0_USB30_OTG0
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 280
Quoted 5 lines
...
+&gmac1 {
...arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ tx_delay = <0x0>; + rx_delay = <0x0>;
Please remove the tx_delay and rx_delay, it's useless. I know there is an error log, but please ignore it first.
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 392
Quoted 8 lines
...
+&pinctrl {
...arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +5
-0+ bt_reg_on_h: bt-enable-h { + pcie_pwren_h: pcie-enable-h { + wifi_reg_on_h: wifi-enable-h { + vcc3v3_rf_pwren_en: vcc5v0-modem-en { + usb_host_pwren_h: vcc5v0-host-en {
obviously (
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +4
-0+ wifi_pwrseq: wifi-pwrseq { + compatible = "mmc-pwrseq-simple"; +&pinctrl { + sdio-pwrseq {
I tend to write like this:
```
&pinctrl {
wifi {
wifi_reg_on_h: wifi-reg-on-h {
```arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 398
Quoted 2 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ vcc_sd { + vcc_sd_h: vcc-sd-h {
Overwrite original to match sdmmc0_pwren
sdmmc0 {
sdmmc0_pwren: sdmmc0-pwren {arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 402
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +4
-0+ rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; +
Extra blank lines.
Quoted 5 lines
+};
...
&sdmmc1 {
...max-frequency = <150000000>;
max-frequency = <150000000>; already defined in rk356x.dtsi
Quoted 4 lines
...
+&usb_host0_ohci {
...
+&usb_host0_ehci {
&usb_host0_ehci {&usb_host0_ohci {
Same for usb_host1
Quoted 5 lines
...
&usb2phy1_host { phy-supply = <&vcc3v3_rf>; status = "okay"; };
Is usb2phy1_host connected?
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Quoted 17 lines · Chukun Pan
Hi Junhao,
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 10
Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +10
-0@@ -0,0 +1,595 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> +#include <dt-bindings/leds/common.h> +#include <dt-bindings/pinctrl/rockchip.h> +#include <dt-bindings/soc/rockchip,vop2.h> +#include <dt-bindings/soc/rockchip,boot-mode.h>No need for
input.h,leds/common.handboot-mode.h.
I will remove them.
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 115
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +3
-0+#include "rk3568.dtsi" + vcc3v3_sd: regulator-3v3-vcc-sd { + pinctrl-0 = <&vcc_sd_h>;schematics:
sdmmc0_pwren
I will rename vcc_sd_h to sdmmc0_pwren.
Quoted 5 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 133
Quoted 3 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc3v3_rf: regulator-3v3-vcc-rf {schematics:
VCC3V4_RF
I will change it to "vcc3v4_rf: regulator-3v4-vcc-rf {"
Quoted 1 line
VCCIN_5V->VCC3V4_RF
Is vccin_5v a new regulator or is it actually vcc_sysin?
Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 3 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ pinctrl-names = "default"; + pinctrl-0 = <&vcc3v3_rf_pwren_en>;schematics:
RF_PWR_ENarch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 145
Quoted 2 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc5v0_sysin: regulator-5v0-vcc-sysin {schematics:
VCC_SYSIN
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 154
Quoted 2 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +1
-0+ vcc5v0_syson: regulator-5v0-vcc-syson {schematics:
VCC_SYSON
I will rename them.
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 173
Quoted 5 lines
...
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host { + vin-supply = <&vcc5v0_syson>;
VCCIN_5V->VCC5V0_USB30_OTG0
Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 280
Quoted 5 lines
...
+&gmac1 {
...arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ tx_delay = <0x0>; + rx_delay = <0x0>;Please remove the
tx_delayandrx_delay, it's useless. I know there is an error log, but please ignore it first.
OK, I will remove them.
Quoted 11 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 392
Quoted 9 lines
...
+&pinctrl {
...arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +5
-0+ bt_reg_on_h: bt-enable-h { + pcie_pwren_h: pcie-enable-h { + wifi_reg_on_h: wifi-enable-h { + vcc3v3_rf_pwren_en: vcc5v0-modem-en { + usb_host_pwren_h: vcc5v0-host-en {obviously (
Yes, I forgot to modify them, it looks better like this:bt_reg_on_h: bt-reg-on-h {pcie_pwren_h: pcie-pwren-h {wifi_reg_on_h: wifi-reg-on-h {sdmmc0_pwren: sdmmc0-pwren {rf_pwren_en: rf-pwren-en {usb_host_pwren_h: usb-host-pwren-h {
Quoted 9 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +4
-0+ wifi_pwrseq: wifi-pwrseq { + compatible = "mmc-pwrseq-simple"; +&pinctrl { + sdio-pwrseq {I tend to write like this:
I will rename them.
Quoted 22 lines
``` &pinctrl { wifi { wifi_reg_on_h: wifi-reg-on-h { ```arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 398
Quoted 2 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +2
-0+ vcc_sd { + vcc_sd_h: vcc-sd-h {Overwrite original to match
sdmmc0_pwrensdmmc0 { sdmmc0_pwren: sdmmc0-pwren {arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts line 402
Quoted 4 lines
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts new file +4
-0+ rockchip,pins = <0 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>; + }; + }; +Extra blank lines.
Quoted 7 lines
Quoted 5 lines
+};
...
&sdmmc1 {
...max-frequency = <150000000>;
max-frequency = <150000000>;already defined inrk356x.dtsi
Yes, I will remove them.
Quoted 11 lines
Quoted 5 lines
...
+&usb_host0_ohci {
...
+&usb_host0_ehci {
&usb_host0_ehci{&usb_host0_ohci{Same for
usb_host1
Quoted 7 lines
Quoted 5 lines
...
&usb2phy1_host { phy-supply = <&vcc3v3_rf>; status = "okay"; };Is
usb2phy1_hostconnected?
It looks like usb_host1_ehci, usb_host1_ohci, usb2phy1_host are not used by any device.
I removed them and it still works fine.
Quoted 1 line
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
Re: [PATCH v2 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568
Hi Junhao,
Quoted 1 line
Is
vccin_5va new regulator or is it actuallyvcc_sysin?
VCCIN_5V (type-c power or battery) -> VCC_SYSIN
VCC_SYSIN -> MCU -> VCC_SYSON
Signature · 7 lines
2.25.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
Rob Herring (Arm)
maintainerQuoted 33 lines · Junhao Xie
Add dts for Ariaboard Photonicat RK3568.
This series bring support for:
* Debug UART
* SDIO QCA9377 WiFi and Bluetooth
* M.2 E-Key PCIe WiFi and Bluetooth
* M.2 B-Key USB Modem WWAN
* Ethernet WAN Port
* MicroSD Card slot
* eMMC
* HDMI Output
* Mali GPU
* USB Type-AChanged from v1:
- move some general nodes (firmware, ramoops, reboot-mode) tork356x.dtsi
- gmac1 change to phy-mode rgmii-id
- corrected some regulator to be closer to schematics
- renamerk3568-ariaboard-photonicat.dtstork3568-photonicat.dts
https://lore.kernel.org/lkml/[email protected]/Junhao Xie (3):
dt-bindings: vendor-prefixes: Add Shanghai Novotech Ariaboard
dt-bindings: arm: rockchip: Add Ariaboard Photonicat RK3568
arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568.../devicetree/bindings/arm/rockchip.yaml | 5 + .../devicetree/bindings/vendor-prefixes.yaml | 2 + arch/arm64/boot/dts/rockchip/Makefile | 1 + .../boot/dts/rockchip/rk3568-photonicat.dts | 595 ++++++++++++++++++ 4 files changed, 603 insertions(+) create mode 100644 arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
Quoted 5 lines
--
2.46.0
My bot found new DTB warnings on the .dts files added or changed in this series.
Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.
If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:
pip3 install dtschema --upgrade
New warnings running 'make CHECK_DTBS=y rockchip/rk3568-photonicat.dtb' for [email protected]:
arch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: bluetooth: 'clock-names' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yamlarch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: phy@fe8c0000: 'phy-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/phy/rockchip,pcie3-phy.yamlarch/arm64/boot/dts/rockchip/rk3568-photonicat.dtb: rfkill-modem: 'reset-gpios' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/net/rfkill-gpio.yaml