X1E Dell XPS 9345 support

Document the X1E80100-based Dell XPS 13 9345 laptop, platform codenamed 'Tributo'/'Tributo R'.

Signed-off-by Aleksandrs Vinarskis <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Documentation/devicetree/bindings/arm/qcom.yaml +1 -1

index 5cb54d69af0b..7c01fe30dabc 100644
@@ -1058,6 +1058,7 @@ properties:
       - items:
           - enum:
               - asus,vivobook-s15
+              - dell,xps13-9345
               - lenovo,yoga-slim7x
               - microsoft,romulus13
               - microsoft,romulus15
--

2.43.0

Hello Aleksandrs,

[Again in plain text]

Quoted 10 lines · Aleksandrs Vinarskis

Document the X1E80100-based Dell XPS 13 9345 laptop, platform codenamed 'Tributo'/'Tributo R'.

Signed-off-by Aleksandrs Vinarskis <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Quoted 13 lines

Documentation/devicetree/bindings/arm/qcom.yaml +1 -1

index 5cb54d69af0b..7c01fe30dabc 100644
@@ -1058,6 +1058,7 @@ properties:
       - items:
           - enum:
               - asus,vivobook-s15
+              - dell,xps13-9345
               - lenovo,yoga-slim7x
               - microsoft,romulus13
               - microsoft,romulus15
--

Quoted 1 line

2.43.0

Tested-by Stefan Schmidt <[email protected]>

Quoted 16 lines · Stefan Schmidt

Hello Aleksandrs,

[Again in plain text]

Quoted 10 lines · Aleksandrs Vinarskis

Document the X1E80100-based Dell XPS 13 9345 laptop, platform codenamed 'Tributo'/'Tributo R'.

Signed-off-by Aleksandrs Vinarskis <[email protected]>

Acked-by Krzysztof Kozlowski <[email protected]>

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

Quoted 16 lines

Quoted 13 lines

Documentation/devicetree/bindings/arm/qcom.yaml +1 -1

index 5cb54d69af0b..7c01fe30dabc 100644
@@ -1058,6 +1058,7 @@ properties:
       - items:
           - enum:
               - asus,vivobook-s15
+              - dell,xps13-9345
               - lenovo,yoga-slim7x
               - microsoft,romulus13
               - microsoft,romulus15
--

Quoted 1 line

2.43.0

Tested-by Stefan Schmidt <[email protected]>

How do you test bindings? Running static checks in kernel tree is the same as compiling software and adding tested-by.

Allow particular machine accessing eg. efivars.

Signed-off-by Aleksandrs Vinarskis <[email protected]>

Reviewed-by Dmitry Baryshkov <[email protected]>

---
 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)

drivers/firmware/qcom/qcom_scm.c +1 -1

index 10986cb11ec0..2495c08a52f5 100644
@@ -1731,6 +1731,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);
  + any potential issues with this, only allow validated machines for now.
  */
 static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
+       { .compatible = "dell,xps13-9345" },
        { .compatible = "lenovo,flex-5g" },
        { .compatible = "lenovo,thinkpad-t14s" },
        { .compatible = "lenovo,thinkpad-x13s", },
--

2.43.0

Initial support for Dell XPS 9345 13" 2024 (Codenamed 'Tributo') based on X1E80100.

Working:
* Touchpad
* Keyboard (only post suspend&resume, i2c-hid patch required [1])
* Touchscreen
* eDP (low-res IPS, OLED) with brightness control
* NVME
* USB Type-C ports in USB2/USB3 (one orientation)
* WiFi
* GPU/aDSP/cDSP firmware loading (requires binaries from Windows)
* Lid switch
* Sleep/suspend, nothing visibly broken on resume

Not working:
* Speakers (WIP, pin guessing, x4 WSA8845)
* Microphones (WIP, pin guessing, dual array)
* Fingerprint Reader (WIP, USB MP with ptn3222)
* USB as DP/USB3 (WIP, PS8830 based)
* Camera (Likely OV01A10)
* EC over i2c

Should be working, but cannot be tested due to lack of hw:
* higher res IPS panel

[1] https://lore.kernel.org/all/[email protected]/

Signed-off-by Aleksandrs Vinarskis <[email protected]>

---
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../dts/qcom/x1e80100-dell-xps13-9345.dts     | 863 ++++++++++++++++++
 2 files changed, 864 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts

Hello Aleksandrs,

[Again in plain text]

Quoted 29 lines · Aleksandrs Vinarskis

Initial support for Dell XPS 9345 13" 2024 (Codenamed 'Tributo') based on X1E80100.

Working:
* Touchpad
* Keyboard (only post suspend&resume, i2c-hid patch required [1])
* Touchscreen
* eDP (low-res IPS, OLED) with brightness control
* NVME
* USB Type-C ports in USB2/USB3 (one orientation)
* WiFi
* GPU/aDSP/cDSP firmware loading (requires binaries from Windows)
* Lid switch
* Sleep/suspend, nothing visibly broken on resume

Not working:
* Speakers (WIP, pin guessing, x4 WSA8845)
* Microphones (WIP, pin guessing, dual array)
* Fingerprint Reader (WIP, USB MP with ptn3222)
* USB as DP/USB3 (WIP, PS8830 based)
* Camera (Likely OV01A10)
* EC over i2c

Should be working, but cannot be tested due to lack of hw:
* higher res IPS panel

[1] https://lore.kernel.org/all/[email protected]/

Quoted 6 lines

Signed-off-by Aleksandrs Vinarskis <[email protected]>

---
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../dts/qcom/x1e80100-dell-xps13-9345.dts     | 863 ++++++++++++++++++
 2 files changed, 864 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts

Tested-by Stefan Schmidt <[email protected]>

regards
Stefan Schmidt

Thanks for taking your time to test this.
For the record, which variant did you test it on (low res IPS/OLED/high res IPS)?

Introduce support for the mentioned laptop.

Very similar to other X1E laptops, device tree was derived by analyzing dtsi of existing models and ACPI tables of this laptop [1]. Most notable difference were
* TZ protected SPI19.
* Keyboard only working after suspend/resume sequence, will do a follow up patch to i2c-hid.
* Lots of small deviations in LDOs voltages.

Successfully tested with Debian 12 and Gnome. Firmware for GPU/aDSP/cDSP was extracted from Windows, WiFi firmware from upstream linux-firmware.

Quite a few things alraedy work, details in patches, quite a few still in WIP or TODOs. Since fixing these may take me a while due to lack of documentation, sending current progress as its very much usable.

[1] https://github.com/aarch64-laptops/build/blob/master/misc/dell-xps-9345/acpi/DSDT.dsl

--------

Changes to V3:
* Rename device from tributo-13 to xps13-9345
* Update commit description - identify EC over i2c, likely camera model
* Update cover letter - no hacks needed when build on top of linux-next
* v3 link: https://lore.kernel.org/all/[email protected]/

--------

Changes to V2:
* Fix uart21 missing alias
* Fix redundant mdss_dp3 defines
* Fix touchscreen i2c address
* Update commit description - OLED panel reported working
* Update commit description - touchscreen reported working
* Update commit description - battery info reported working
* Update commit description - add keyboard patches link
* v2 link: https://lore.kernel.org/all/[email protected]/

--------

Changes to V1:
* Fix misalignments due to wrong tab/space conversion
* Fix regulator namings
* Fix reasonable warnings from scripts/checkpatch.pl
* Restructure all (sub)nodes alphabetically
* v1 link: https://lore.kernel.org/all/[email protected]/

Aleksandrs Vinarskis (3):
dt-bindings: arm: qcom: Add Dell XPS 13 9345
firmware: qcom: scm: Allow QSEECOM on Dell XPS 13 9345
arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345

 .../devicetree/bindings/arm/qcom.yaml         |   1 +
 arch/arm64/boot/dts/qcom/Makefile             |   1 +
 .../dts/qcom/x1e80100-dell-xps13-9345.dts     | 863 ++++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |   1 +
 4 files changed, 866 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts

--
2.43.0

Introduce support for the mentioned laptop.

Very similar to other X1E laptops, device tree was derived by analyzing dtsi of existing models and ACPI tables of this laptop [1]. Most notable difference were
* TZ protected SPI19.
* Keyboard only working after suspend/resume sequence, will do a follow up patch to i2c-hid.
* Lots of small deviations in LDOs voltages.

[...]