iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig
cover iio: {amplifiers,dac,frequency,resolver}: add missing selects in Kconfig
This series adds some missing selects in the Kconfig entry for the following drivers:
- ad2s1210 (BUFFER, TRIGGERED_BUFFER, REGMAP)
- adf4377 (REGMAP_SPI)
- admv4420 (REMGAP_SPI)
- ada4250 (REGMAP_SPI)
- ad4770r (REGMAP_SPI)
- ltc1660 (REGMAP_SPI)
- stm32-dac-core (REGMAP_MMIO)
Usually you will not notice the missing dependencies, but tiny config files where those drivers are include will lead to multiple errors when compiling and linking.
The issue was found while compiling the ad2s1210, and then I looked for other cases where REGMAP was missing.
---
Javier Carrasco (8):
iio: resolver: ad2s1210 add missing select REGMAP in Kconfig
iio: resolver: ad2s1210: add missing select (TRIGGERED_)BUFFER in Kconfig
iio: frequency: adf4377: add missing select REMAP_SPI in Kconfig
iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig
iio: amplifiers: ada4250: add missing select REGMAP_SPI in Kconfig
iio: dac: ad5770r: add missing select REGMAP_SPI in Kconfig
iio: dac: ltc1660: add missing select REGMAP_SPI in Kconfig
iio: dac: stm32-dac-core: add missing select REGMAP_MMIO in Kconfig
drivers/iio/amplifiers/Kconfig | 1 + drivers/iio/dac/Kconfig | 3 +++ drivers/iio/frequency/Kconfig | 18 ++++++++++-------- drivers/iio/resolver/Kconfig | 3 +++ 4 files changed, 17 insertions(+), 8 deletions(-)
---
base-commit: c02d24a5af66a9806922391493205a344749f2c4
change-id: 20241003-ad2s1210-select-a0a73a48038a
Best regards,
Signature · 1 line
Javier Carrasco <[email protected]>
PATCH 1/8 iio: resolver: ad2s1210 add missing select REGMAP in Kconfig
This driver makes use of regmap, but does not select the required module.
Add the missing 'select REGMAP'.
--- drivers/iio/resolver/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/resolver/Kconfig +1 -0
@@ -31,6 +31,7 @@ config AD2S1210 depends on SPI depends on COMMON_CLK depends on GPIOLIB || COMPILE_TEST + select REGMAP help Say yes here to build support for Analog Devices spi resolver to digital converters, ad2s1210, provides direct access via sysfs.
Signature · 1 line
2.43.0
Re: [PATCH 1/8] iio: resolver: ad2s1210 add missing select REGMAP in Kconfig
Quoted 7 lines · Javier Carrasco
This driver makes use of regmap, but does not select the required module.
Add the missing 'select REGMAP'.Fixes b3689e14415a ("staging: iio: resolver: ad2s1210: use regmap for config registers")Signed-off-by Javier Carrasco <[email protected]>---
Re: [PATCH 1/8] iio: resolver: ad2s1210 add missing select REGMAP in Kconfig
Quoted 10 lines · On Thu, 3 Oct 2024 17:44:03 -0500 David Lechner <[email protected]> wrote:
Quoted 7 lines · Javier Carrasco
This driver makes use of regmap, but does not select the required module.
Add the missing 'select REGMAP'.Fixes b3689e14415a ("staging: iio: resolver: ad2s1210: use regmap for config registers")Signed-off-by Javier Carrasco <[email protected]>---
Reviewed-by David Lechner <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Thanks,
J
PATCH 2/8 iio: resolver: ad2s1210: add missing select (TRIGGERED_)BUFFER in Kconfig
In reply to Javier CarrascoThis driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select IIO_BUFFER' and 'select IIO_TRIGGERED_BUFFER'.
--- drivers/iio/resolver/Kconfig | 2 ++ 1 file changed, 2 insertions(+)
drivers/iio/resolver/Kconfig +2 -0
@@ -32,6 +32,8 @@ config AD2S1210 depends on COMMON_CLK depends on GPIOLIB || COMPILE_TEST select REGMAP + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER help Say yes here to build support for Analog Devices spi resolver to digital converters, ad2s1210, provides direct access via sysfs.
Signature · 1 line
2.43.0
Re: [PATCH 2/8] iio: resolver: ad2s1210: add missing select (TRIGGERED_)BUFFER in Kconfig
Quoted 8 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 128b9389db0e ("staging: iio: resolver: ad2s1210: add triggered buffer support")Signed-off-by Javier Carrasco <[email protected]>---
Re: [PATCH 2/8] iio: resolver: ad2s1210: add missing select (TRIGGERED_)BUFFER in Kconfig
Quoted 11 lines · On Thu, 3 Oct 2024 17:44:20 -0500 David Lechner <[email protected]> wrote:
Quoted 8 lines · Javier Carrasco
This driver makes use of triggered buffers, but does not select the required modules.
Add the missing 'select
IIO_BUFFER' and 'selectIIO_TRIGGERED_BUFFER'.Fixes 128b9389db0e ("staging: iio: resolver: ad2s1210: add triggered buffer support")Signed-off-by Javier Carrasco <[email protected]>---
Reviewed-by David Lechner <[email protected]>
applied.
PATCH 3/8 iio: frequency: adf4377: add missing select REMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/frequency/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/frequency/Kconfig +1 -0
@@ -53,6 +53,7 @@ config ADF4371 config ADF4377 tristate "Analog Devices ADF4377 Microwave Wideband Synthesizer" depends on SPI && COMMON_CLK + select REGMAP_SPI help Say yes here to build support for Analog Devices ADF4377 Microwave Wideband Synthesizer.
Signature · 1 line
2.43.0
Re: [PATCH 3/8] iio: frequency: adf4377: add missing select REMAP_SPI in Kconfig
Quoted 6 lines · On Thu, 03 Oct 2024 18:49:35 +0200 Javier Carrasco…
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes eda549e2e524 ("iio: frequency: adf4377: add support for ADF4377")Signed-off-by Javier Carrasco <[email protected]>
Applied.
Quoted 17 lines
--- drivers/iio/frequency/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/iio/frequency/Kconfig +1
-0@@ -53,6 +53,7 @@ config ADF4371 config ADF4377 tristate "Analog Devices ADF4377 Microwave Wideband Synthesizer" depends on SPI && COMMON_CLK + select REGMAP_SPI help Say yes here to build support for Analog Devices ADF4377 Microwave Wideband Synthesizer.
PATCH 4/8 iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/frequency/Kconfig | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)
drivers/iio/frequency/Kconfig +9 -8
@@ -92,14 +92,15 @@ config ADMV1014 module will be called admv1014. config ADMV4420 - tristate "Analog Devices ADMV4420 K Band Downconverter" - depends on SPI - help - Say yes here to build support for Analog Devices K Band - Downconverter with integrated Fractional-N PLL and VCO. - - To compile this driver as a module, choose M here: the - module will be called admv4420. + tristate "Analog Devices ADMV4420 K Band Downconverter" + depends on SPI + select REGMAP_SPI + help + Say yes here to build support for Analog Devices K Band + Downconverter with integrated Fractional-N PLL and VCO. + + To compile this driver as a module, choose M here: the + module will be called admv4420. config ADRF6780 tristate "Analog Devices ADRF6780 Microwave Upconverter"
Signature · 1 line
2.43.0
Re: [PATCH 4/8] iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig
Quoted 29 lines · Javier Carrasco
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/frequency/Kconfig | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)drivers/iio/frequency/Kconfig +2
-8@@ -92,14 +92,15 @@ config ADMV1014 module will be called admv1014. config ADMV4420 - tristate "Analog Devices ADMV4420 K Band Downconverter" - depends on SPI - help - Say yes here to build support for Analog Devices K Band - Downconverter with integrated Fractional-N PLL and VCO. - - To compile this driver as a module, choose M here: the - module will be called admv4420. + tristate "Analog Devices ADMV4420 K Band Downconverter" + depends on SPI
drivers/iio/frequency/Kconfig config ADMV1014 · line 106
Quoted 10 lines
drivers/iio/frequency/Kconfig +7
-0+ select REGMAP_SPI + help + Say yes here to build support for Analog Devices K Band + Downconverter with integrated Fractional-N PLL and VCO. + + To compile this driver as a module, choose M here: the + module will be called admv4420. config ADRF6780 tristate "Analog Devices ADRF6780 Microwave Upconverter"
Note that I formatted the entry to use tabs instead of spaces, although I forgot to add it to the commit message.
Best regards,
Javier Carrasco
Jonathan Cameron
maintainerRe: [PATCH 4/8] iio: frequency: admv4420: add missing select REMAP_SPI in Kconfig
Quoted 37 lines · On Thu, 3 Oct 2024 21:30:26 +0200 Javier Carrasco…
Quoted 36 lines · Javier Carrasco
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes b59c04155901 ("iio: frequency: admv4420.c: Add support for ADMV4420")Signed-off-by Javier Carrasco <[email protected]>--- drivers/iio/frequency/Kconfig | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-)drivers/iio/frequency/Kconfig +9
-8@@ -92,14 +92,15 @@ config ADMV1014 module will be called admv1014. config ADMV4420 - tristate "Analog Devices ADMV4420 K Band Downconverter" - depends on SPI - help - Say yes here to build support for Analog Devices K Band - Downconverter with integrated Fractional-N PLL and VCO. - - To compile this driver as a module, choose M here: the - module will be called admv4420. + tristate "Analog Devices ADMV4420 K Band Downconverter" + depends on SPI + select REGMAP_SPI + help + Say yes here to build support for Analog Devices K Band + Downconverter with integrated Fractional-N PLL and VCO. + + To compile this driver as a module, choose M here: the + module will be called admv4420.
Quoted 6 lines
drivers/iio/frequency/Kconfig config ADMV1014 · line 106
Quoted 3 lines
drivers/iio/frequency/Kconfig +0
-0config ADRF6780 tristate "Analog Devices ADRF6780 Microwave Upconverter"Note that I formatted the entry to use tabs instead of spaces, although I forgot to add it to the commit message.
Please split it up. The fix wants backporting. Also there are other white space issues in here that would be good to clean up (see the entry above).
Quoted 4 lines
Best regards,
Javier Carrasco
PATCH 5/8 iio: amplifiers: ada4250: add missing select REGMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/amplifiers/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/amplifiers/Kconfig +1 -0
@@ -27,6 +27,7 @@ config AD8366 config ADA4250 tristate "Analog Devices ADA4250 Instrumentation Amplifier" depends on SPI + select REGMAP_SPI help Say yes here to build support for Analog Devices ADA4250 SPI Amplifier's support. The driver provides direct access via
Signature · 1 line
2.43.0
Re: [PATCH 5/8] iio: amplifiers: ada4250: add missing select REGMAP_SPI in Kconfig
Quoted 6 lines · On Thu, 03 Oct 2024 18:49:37 +0200 Javier Carrasco…
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes 28b4c30bfa5f ("iio: amplifiers: ada4250: add support for ADA4250")Signed-off-by Javier Carrasco <[email protected]>
Applied.
Quoted 17 lines
--- drivers/iio/amplifiers/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/iio/amplifiers/Kconfig +1
-0@@ -27,6 +27,7 @@ config AD8366 config ADA4250 tristate "Analog Devices ADA4250 Instrumentation Amplifier" depends on SPI + select REGMAP_SPI help Say yes here to build support for Analog Devices ADA4250 SPI Amplifier's support. The driver provides direct access via
PATCH 6/8 iio: dac: ad5770r: add missing select REGMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/dac/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/dac/Kconfig +1 -0
@@ -262,6 +262,7 @@ config AD5766 config AD5770R tristate "Analog Devices AD5770R IDAC driver" depends on SPI_MASTER + select REGMAP_SPI help Say yes here to build support for Analog Devices AD5770R Digital to Analog Converter.
Signature · 1 line
2.43.0
Re: [PATCH 6/8] iio: dac: ad5770r: add missing select REGMAP_SPI in Kconfig
Quoted 6 lines · On Thu, 03 Oct 2024 18:49:38 +0200 Javier Carrasco…
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes cbbb819837f6 ("iio: dac: ad5770r: Add AD5770R support")Signed-off-by Javier Carrasco <[email protected]>
Applied
Quoted 17 lines
--- drivers/iio/dac/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/iio/dac/Kconfig +1
-0@@ -262,6 +262,7 @@ config AD5766 config AD5770R tristate "Analog Devices AD5770R IDAC driver" depends on SPI_MASTER + select REGMAP_SPI help Say yes here to build support for Analog Devices AD5770R Digital to Analog Converter.
PATCH 7/8 iio: dac: ltc1660: add missing select REGMAP_SPI in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_spi, but does not select the required module.
Add the missing 'select REGMAP_SPI'.
--- drivers/iio/dac/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/dac/Kconfig +1 -0
@@ -354,6 +354,7 @@ config LPC18XX_DAC config LTC1660 tristate "Linear Technology LTC1660/LTC1665 DAC SPI driver" depends on SPI + select REGMAP_SPI help Say yes here to build support for Linear Technology LTC1660 and LTC1665 Digital to Analog Converters.
Signature · 1 line
2.43.0
Re: [PATCH 7/8] iio: dac: ltc1660: add missing select REGMAP_SPI in Kconfig
Quoted 6 lines · On Thu, 03 Oct 2024 18:49:39 +0200 Javier Carrasco…
This driver makes use of
regmap_spi, but does not select the required module.
Add the missing 'selectREGMAP_SPI'.Fixes 8316cebd1e59 ("iio: dac: add support for ltc1660")Signed-off-by Javier Carrasco <[email protected]>
Applied to the fixes-togreg branch of iio.git.
Quoted 17 lines
--- drivers/iio/dac/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/iio/dac/Kconfig +1
-0@@ -354,6 +354,7 @@ config LPC18XX_DAC config LTC1660 tristate "Linear Technology LTC1660/LTC1665 DAC SPI driver" depends on SPI + select REGMAP_SPI help Say yes here to build support for Linear Technology LTC1660 and LTC1665 Digital to Analog Converters.
PATCH 8/8 iio: dac: stm32-dac-core: add missing select REGMAP_MMIO in Kconfig
In reply to Javier CarrascoThis driver makes use of regmap_mmio, but does not select the required module.
Add the missing 'select REGMAP_MMIO'.
--- drivers/iio/dac/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/iio/dac/Kconfig +1 -0
@@ -485,6 +485,7 @@ config STM32_DAC config STM32_DAC_CORE tristate + select REGMAP_MMIO config TI_DAC082S085 tristate "Texas Instruments 8/10/12-bit 2/4-channel DAC driver"
Signature · 1 line
2.43.0