pinctrl: th1520: add a CONFIG_OF dependency
Subsystems (2)
PATCH 1/1 pinctrl: th1520: add a CONFIG_OF dependency
From: Arnd Bergmann <[email protected]>
When compile-testing without CONfIG_OF:
drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| pinconf_generic_dump_configEnforce this using Kconig dependencies.
--- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
@@ -564,6 +564,7 @@ config PINCTRL_TPS6594 config PINCTRL_TH1520 tristate "Pinctrl driver for the T-Head TH1520 SoC" depends on ARCH_THEAD || COMPILE_TEST + depends on OF select GENERIC_PINMUX_FUNCTIONS select GENERIC_PINCONF select PINMUX
Signature · 1 line
2.39.5
Quoted 33 lines · Arnd Bergmann
From: Arnd Bergmann <[email protected]>
When compile-testing without
CONfIG_OF:
drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | pinconf_generic_dump_configEnforce this using Kconig dependencies.
Fixes bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")Signed-off-by Arnd Bergmann <[email protected]>--- drivers/pinctrl/Kconfig | 1 + 1 file changed, 1 insertion(+)drivers/pinctrl/Kconfig +1
-0@@ -564,6 +564,7 @@ config PINCTRL_TPS6594 config PINCTRL_TH1520 tristate "Pinctrl driver for the T-Head TH1520 SoC" depends on ARCH_THEAD || COMPILE_TEST + depends on OF select GENERIC_PINMUX_FUNCTIONS select GENERIC_PINCONF select PINMUXSignature · 1 line
2.39.5
Thank you for fixing this.
Quoted 4 lines · Arnd Bergmann
When compile-testing without
CONfIG_OF:
drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]
Quoted 8 lines
455 | ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | pinconf_generic_dump_configEnforce this using Kconig dependencies.
Fixes bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")Signed-off-by Arnd Bergmann <[email protected]>
Patch applied!
Yours,
Linus Walleij