Skip to contentSkip to conversation

pinctrl: th1520: add a CONFIG_OF dependency

PATCH In review Arnd Bergmann 3 participants 3 messages Oct 15, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pinctrl: th1520: add a CONFIG_OF dependency

From: Arnd Bergmann <[email protected]>

When compile-testing without CONfIG_OF:

drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]

  455 |                 ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       pinconf_generic_dump_config

Enforce this using Kconig dependencies.

Fixes bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index a6acc27c9a83..3fab5ebeb2e0 100644
@@ -564,6 +564,7 @@ config PINCTRL_TPS6594
 config PINCTRL_TH1520
 	tristate "Pinctrl driver for the T-Head TH1520 SoC"
 	depends on ARCH_THEAD || COMPILE_TEST
+	depends on OF
 	select GENERIC_PINMUX_FUNCTIONS
 	select GENERIC_PINCONF
 	select PINMUX
Signature · 1 line
2.39.5
Acked-by on v1 1/1
#1 lore raw
Quoted 33 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

When compile-testing without CONfIG_OF:

drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]

  455 |                 ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       pinconf_generic_dump_config

Enforce this using Kconig dependencies.

Fixes bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")
---
 drivers/pinctrl/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/pinctrl/Kconfig +1 -0
index a6acc27c9a83..3fab5ebeb2e0 100644
@@ -564,6 +564,7 @@ config PINCTRL_TPS6594
 config PINCTRL_TH1520
 	tristate "Pinctrl driver for the T-Head TH1520 SoC"
 	depends on ARCH_THEAD || COMPILE_TEST
+	depends on OF
 	select GENERIC_PINMUX_FUNCTIONS
 	select GENERIC_PINCONF
 	select PINMUX
Signature · 1 line
2.39.5

Thank you for fixing this.

#2 lore raw
In reply to Arnd Bergmann
Quoted 4 lines · Arnd Bergmann

When compile-testing without CONfIG_OF:

drivers/pinctrl/pinctrl-th1520.c: In function 'th1520_pinctrl_dt_node_to_map':
drivers/pinctrl/pinctrl-th1520.c:455:23: error: implicit declaration of function 'pinconf_generic_parse_dt_config'; did you mean 'pinconf_generic_dump_config'? [-Wimplicit-function-declaration]

Quoted 8 lines
  455 |                 ret = pinconf_generic_parse_dt_config(child, pctldev, &configs, &nconfigs);
      |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                       pinconf_generic_dump_config

Enforce this using Kconig dependencies.

Fixes bed5cd6f8a98 ("pinctrl: Add driver for the T-Head TH1520 SoC")

Patch applied!

Yours,
Linus Walleij