s390/kvm: initialize uninitialized flags variable
Claudio Imbrenda
maintainerPATCH 1/1 s390/kvm: initialize uninitialized flags variable
The flags variable was being used uninitialized.
Initialize it to 0 as expected.
For some reason neither gcc nor clang reported a warning.
Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
Reported-by Janosch Frank <[email protected]>
Signed-off-by Claudio Imbrenda <[email protected]>
--- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/kvm-s390.c +1 -1
@@ -4729,8 +4729,8 @@ static int vcpu_post_run_addressing_exception(struct kvm_vcpu *vcpu)static int vcpu_post_run_handle_fault (struct kvm_vcpu *vcpu) { +unsigned int flags =0 ;unsigned long gaddr; -unsigned int flags;int rc =0 ; gaddr = current->thread.gmap_teid.addr *PAGE_SIZE ;
Signature · 1 line
2.47.0
Quoted 11 lines · Claudio Imbrenda
The flags variable was being used uninitialized.
Initialize it to 0 as expected.For some reason neither gcc nor clang reported a warning.
Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")Reported-by Janosch Frank <[email protected]>Signed-off-by Claudio Imbrenda <[email protected]>--- arch/s390/kvm/kvm-s390.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Quoted 8 lines · Claudio Imbrenda
The flags variable was being used uninitialized.
Initialize it to 0 as expected.For some reason neither gcc nor clang reported a warning.
Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")Reported-by Janosch Frank <[email protected]>Signed-off-by Claudio Imbrenda <[email protected]>
Thanks for tracking this down, tprot selftest is green with this fix.
Reviewed-by Janosch Frank <[email protected]>