Skip to contentSkip to conversation

s390/kvm: initialize uninitialized flags variable

PATCH Applied Claudio Imbrenda 3 participants 3 messages Oct 30, 2024 – Nov 4, 2024

Subsystems (3)
lore
Share & tools
lore

Claudio Imbrenda

author maintainer
#0 lore raw

PATCH 1/1 s390/kvm: initialize uninitialized flags variable

The flags variable was being used uninitialized.
Initialize it to 0 as expected.

For some reason neither gcc nor clang reported a warning.

Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
---
 arch/s390/kvm/kvm-s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/s390/kvm/kvm-s390.c +1 -1
index a5750c14bb4d..8b3afda99397 100644
@@ -4729,8 +4729,8 @@ static int vcpu_post_run_addressing_exception(struct kvm_vcpu *vcpu)
 
 static int vcpu_post_run_handle_fault(struct kvm_vcpu *vcpu)
 {
+	unsigned int flags = 0;
 	unsigned long gaddr;
-	unsigned int flags;
 	int rc = 0;
 
 	gaddr = current->thread.gmap_teid.addr * PAGE_SIZE;
Signature · 1 line
2.47.0
maintainer Applied
#1 lore raw
Quoted 11 lines · Claudio Imbrenda

The flags variable was being used uninitialized.
Initialize it to 0 as expected.

For some reason neither gcc nor clang reported a warning.

Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")
---
 arch/s390/kvm/kvm-s390.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks!

maintainer Reviewed-by on v1 1/1
#2 lore raw
In reply to Claudio Imbrenda
Quoted 8 lines · Claudio Imbrenda

The flags variable was being used uninitialized.
Initialize it to 0 as expected.

For some reason neither gcc nor clang reported a warning.

Fixes ce2b276ebe51 ("s390/mm/fault: Handle guest-related program interrupts in KVM")

Thanks for tracking this down, tprot selftest is green with this fix.