ext4: Use str_yes_no() helper function
PATCH RESEND 1/1 ext4: Use str_yes_no() helper function
Remove hard-coded strings by using the str_yes_no() helper function.
Signed-off-by Thorsten Blum <[email protected]>
--- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/ext4/mballoc.c +2 -2
@@ -5711,7 +5711,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) (unsigned long )ac->ac_b_ex.fe_logical, (int)ac->ac_criteria);mb_debug (sb,"%u found" , ac->ac_found); -mb_debug (sb,"used pa: %s, " , ac->ac_pa ?"yes" :"no" ); +mb_debug (sb,"used pa: %s, " ,str_yes_no (ac->ac_pa));if (ac->ac_pa)mb_debug (sb,"pa_type %s\n" , ac->ac_pa->pa_type ==MB_GROUP_PA ?"group pa" :"inode pa" );
@@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb, } out_dbg: -mb_debug (sb,"freed %d, retry ? %s\n" , freed, ret ?"yes" :"no" ); +mb_debug (sb,"freed %d, retry ? %s\n" , freed,str_yes_no (ret));return ret; }
Signature · 1 line
2.47.0
Quoted 3 lines · Thorsten Blum
Remove hard-coded strings by using the
str_yes_no()helper function.Signed-off-by Thorsten Blum <[email protected]>
OK. Feel free to add:
Reviewed-by Jan Kara <[email protected]>
Honza
Quoted 30 lines
--- fs/ext4/mballoc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)fs/ext4/mballoc.c +2
-2@@ -5711,7 +5711,7 @@ static void ext4_mb_show_ac(struct ext4_allocation_context *ac) (unsigned long )ac->ac_b_ex.fe_logical, (int)ac->ac_criteria);mb_debug (sb,"%u found" , ac->ac_found); -mb_debug (sb,"used pa: %s, " , ac->ac_pa ?"yes" :"no" ); +mb_debug (sb,"used pa: %s, " ,str_yes_no (ac->ac_pa));if (ac->ac_pa)mb_debug (sb,"pa_type %s\n" , ac->ac_pa->pa_type ==MB_GROUP_PA ?"group pa" :"inode pa" );@@ -6056,7 +6056,7 @@ static bool ext4_mb_discard_preallocations_should_retry(struct super_block *sb, } out_dbg: -mb_debug (sb,"freed %d, retry ? %s\n" , freed, ret ?"yes" :"no" ); +mb_debug (sb,"freed %d, retry ? %s\n" , freed,str_yes_no (ret));return ret; }Signature · 1 line
2.47.0
Signature · 2 lines
Jan Kara <[email protected]> SUSE Labs, CR