Skip to contentSkip to conversation

arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs

PATCH Superseded Eddie James 2 participants 3 messages Nov 8, 2024 – Nov 12, 2024

Subsystems (2)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 arm: dts: aspeed: Blueridge and Rainer: Add VRM presence GPIOs

Add GPIO line names to the GPIO expander to describe DCM and VRM presence detection lines.

---
 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++--
 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts   | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts +2 -2
index 5f9a46c2abb8..d504ae84db89 100644
@@ -1232,8 +1232,8 @@ led-controller@60 {
 		#gpio-cells = <2>;
 
 		gpio-line-names =
-			"", "", "", "", "", "", "", "",
-			"", "", "", "", "", "", "power-config-full-load", "";
+			"", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+			"", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
 	};
 
 	led-controller@61 {
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts +2 -2
index a4aec3010456..eefc69d0d032 100644
@@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
 		#gpio-cells = <2>;
 
 		gpio-line-names =
-			"", "", "", "", "", "", "", "",
-			"", "", "", "", "", "", "power-config-full-load", "";
+			"", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+			"", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
 	};
 
 	pca_pres2: pca9552@61 {
Signature · 1 line
2.43.5
maintainer
#1 lore raw
Quoted 18 lines · Eddie James

Add GPIO line names to the GPIO expander to describe DCM and VRM presence detection lines.

---
 arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++-- arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts   | 4 ++--

 2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts +0 -0
index 5f9a46c2abb8..d504ae84db89 100644
@@ -1232,8 +1232,8 @@ led-controller@60 {
                 #gpio-cells = <2>;


                gpio-line-names =

Quoted 8 lines

-                       "", "", "", "", "", "", "", "", -                       "", "", "", "", "", "", "power-config-full- load", "";
+                       "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+                       "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
        };

This ends up generating checkpatch warnings about long lines when I apply it.

I did a quick, incomplete and random survey of some other devicetrees, and perhaps exploding out like in [1] might help.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d85b2ad35a2ab

Quoted 10 lines


        led-controller@61 {

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts +0 -0
index a4aec3010456..eefc69d0d032 100644
@@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
                 #gpio-cells = <2>;

Quoted 8 lines

                gpio-line-names =
-                       "", "", "", "", "", "", "", "", -                       "", "", "", "", "", "", "power-config-full- load", "";
+                       "", "", "", "", "", "", "P10_DCM0_PRES", "P10_DCM1_PRES",
+                       "", "", "", "", "PRESENT_VRM_DCM0_N", "PRESENT_VRM_DCM1_N", "power-config-full-load", "";

Similarly here.

Andrew

#2 lore raw
Quoted 30 lines · Andrew Jeffery
Quoted 25 lines · Eddie James

Add GPIO line names to the GPIO expander to describe DCM and VRM presence detection lines.

---
  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts | 4 ++--
  arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts   | 4 ++--
  2 files changed, 4 insertions(+), 4 deletions(-)
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-blueridge.dts +2 -2
index 5f9a46c2abb8..d504ae84db89 100644
@@ -1232,8 +1232,8 @@ led-controller@60 {
                 #gpio-cells = <2>;
 
                 gpio-line-names =
-                       "", "", "", "", "", "", "", "",
-                       "", "", "", "", "", "", "power-config-full-
 load", "";
+                       "", "", "", "", "", "", "P10_DCM0_PRES",
 "P10_DCM1_PRES",
+                       "", "", "", "", "PRESENT_VRM_DCM0_N",
 "PRESENT_VRM_DCM1_N", "power-config-full-load", "";
Quoted 1 line

        };

This ends up generating checkpatch warnings about long lines when I apply it.

Quoted 4 lines

I did a quick, incomplete and random survey of some other devicetrees, and perhaps exploding out like in [1] might help.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d85b2ad35a2ab

Oh, oops, sure thing.

Thanks,

Eddie

Quoted 22 lines
Quoted 9 lines

        led-controller@61 {

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts +0 -0
index a4aec3010456..eefc69d0d032 100644

arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts pca_pres3: pca9552@60 { · line 1287

Quoted 10 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-rainier.dts +2 -2
@@ -1280,8 +1280,8 @@ pca_pres3: pca9552@60 {
                 #gpio-cells = <2>;
 
                 gpio-line-names =
-                       "", "", "", "", "", "", "", "",
-                       "", "", "", "", "", "", "power-config-full-
 load", "";
+                       "", "", "", "", "", "", "P10_DCM0_PRES",
 "P10_DCM1_PRES",
+                       "", "", "", "", "PRESENT_VRM_DCM0_N",
 "PRESENT_VRM_DCM1_N", "power-config-full-load", "";

Similarly here.

Andrew