Bluetooth: btnxpuart: Switch to SYSTEM_SLEEP_PM_OPS
Subsystems (2)
PATCH 1/1 Bluetooth: btnxpuart: Switch to SYSTEM_SLEEP_PM_OPS
From: Fabio Estevam <[email protected]>
Replace SET_SYSTEM_SLEEP_PM_OPS() with its modern SYSTEM_SLEEP_PM_OPS() alternative.
The combined usage of pm_sleep_ptr() and SYSTEM_SLEEP_PM_OPS() allows the compiler to evaluate if the suspend/resume() functions are used at build time or are simply dead code.
This allows removing the CONFIG_PM_SLEEP ifdefery from the suspend/resume() functions.
--- drivers/bluetooth/btnxpuart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
drivers/bluetooth/btnxpuart.c +2 -4
@@ -1588,7 +1588,6 @@ static void nxp_serdev_remove(struct serdev_device *serdev)hci_free_dev (hdev); } -#ifdef CONFIG_PM_SLEEP static int nxp_serdev_suspend (struct device *dev) {struct btnxpuart_dev *nxpdev =dev_get_drvdata (dev);
@@ -1606,7 +1605,6 @@ static int nxp_serdev_resume(struct device *dev)ps_control (psdata->hdev,PS_STATE_AWAKE );return 0 ; } -#endif static struct btnxpuart_data w8987_data__maybe_unused = { .helper_fw_name =NULL ,
@@ -1628,7 +1626,7 @@ static const struct of_device_id nxpuart_of_match_table[] __maybe_unused = {MODULE_DEVICE_TABLE (of, nxpuart_of_match_table);static const struct dev_pm_ops nxp_pm_ops = { -SET_SYSTEM_SLEEP_PM_OPS (nxp_serdev_suspend, nxp_serdev_resume) +SYSTEM_SLEEP_PM_OPS (nxp_serdev_suspend, nxp_serdev_resume) };static struct serdev_device_driver nxp_serdev_driver = {
@@ -1637,7 +1635,7 @@ static struct serdev_device_driver nxp_serdev_driver = { .driver = { .name = "btnxpuart", .of_match_table = of_match_ptr(nxpuart_of_match_table), - .pm = &nxp_pm_ops, + .pm = pm_sleep_ptr(&nxp_pm_ops), }, };
Signature · 1 line
2.34.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=911801
---Test result---
Test Summary:
CheckPatch PENDING 0.43 seconds GitLint PENDING 0.26 seconds SubjectPrefix PASS 0.07 seconds BuildKernel PASS 24.91 seconds CheckAllWarning PASS 27.57 seconds CheckSparse PASS 30.16 seconds BuildKernel32 PASS 28.02 seconds TestRunnerSetup PASS 434.25 seconds TestRunner_l2cap-tester PASS 20.16 seconds TestRunner_iso-tester FAIL 34.34 seconds TestRunner_bnep-tester PASS 4.81 seconds TestRunner_mgmt-tester FAIL 121.11 seconds TestRunner_rfcomm-tester PASS 7.54 seconds TestRunner_sco-tester PASS 13.50 seconds TestRunner_ioctl-tester PASS 8.07 seconds TestRunner_mesh-tester PASS 5.91 seconds TestRunner_smp-tester PASS 6.91 seconds TestRunner_userchan-tester PASS 4.95 seconds IncrementalBuild PENDING 0.80 seconds
Details
##############################
Test: CheckPatch - PENDING
Desc: Run checkpatch.pl script
Output:
##############################
Test: GitLint - PENDING
Desc: Run gitlint
Output:
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
WARNING: possible circular locking dependency detected
Total: 124, Passed: 120 (96.8%), Failed: 0, Not Run: 4
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner Output:
Total: 492, Passed: 487 (99.0%), Failed: 1, Not Run: 4
Failed Test Cases
LL Privacy - Start Discovery 2 (Disable RL) Failed 0.202 seconds
##############################
Test: IncrementalBuild - PENDING
Desc: Incremental build with the patches in the series Output:
---
Regards,
Linux Bluetooth
Neeraj Sanjay Kale
maintainerPATCH 1/1 Bluetooth: btnxpuart: Switch to SYSTEM_SLEEP_PM_OPS
In reply to Fabio EstevamHi Fabio,
Thank you for the patch and the improvement it brings along.
Thanks,
Neeraj
Quoted 60 lines
From: Fabio Estevam <[email protected]>
Replace
SET_SYSTEM_SLEEP_PM_OPS()with its modernSYSTEM_SLEEP_PM_OPS()alternative.The combined usage of
pm_sleep_ptr()andSYSTEM_SLEEP_PM_OPS()allows the compiler to evaluate if the suspend/resume() functions are used at build time or are simply dead code.This allows removing the
CONFIG_PM_SLEEPifdefery from the suspend/resume() functions.Signed-off-by Fabio Estevam <[email protected]>--- drivers/bluetooth/btnxpuart.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)drivers/bluetooth/btnxpuart.c +2
-3@@ -1588,7 +1588,6 @@ static void nxp_serdev_remove(struct serdev_device *serdev)hci_free_dev (hdev ); } -#ifdef CONFIG_PM_SLEEP static int nxp_serdev_suspend (struct device *dev) { struct btnxpuart_dev *nxpdev = dev_get_drvdata(dev); @@ -1606,7 +1605,6 @@ static int nxp_serdev_resume(struct device *dev) ps_control(psdata->hdev, PS_STATE_AWAKE);return 0 ; } -#endif static struct btnxpuart_data w8987_data__maybe_unused = { .helper_fw_name =NULL ,@@ -1628,7 +1626,7 @@ static const struct of_device_id nxpuart_of_match_table[] __maybe_unused = { MODULE_DEVICE_TABLE(of, nxpuart_of_match_table);static const struct dev_pm_ops nxp_pm_ops = { -SET_SYSTEM_SLEEP_PM_OPS (nxp_serdev_suspend, nxp_serdev_resume) +SYSTEM_SLEEP_PM_OPS (nxp_serdev_suspend, nxp_serdev_resume) };static struct
serdev_device_drivernxp_serdev_driver= { @@ -1637,7 +1635,7
@@ static structserdev_device_drivernxp_serdev_driver= {
.driver = {
.name = "btnxpuart",
.of_match_table =of_match_ptr(nxpuart_of_match_table),drivers/bluetooth/btnxpuart.c +1
-2- .pm = &nxp_pm_ops, + .pm = pm_sleep_ptr(&nxp_pm_ops), }, }; --2.34.1