SRF: Fix offline CPU preventing pc6 entry
Subsystems (4)
v6 cover SRF: Fix offline CPU preventing pc6 entry
Changes since v5:
* Split 1/3 from v5 into two commits, as suggestem by Gautham. 1/4 splits wait_play_dead into mwait_play_dead_with_hint. 2/4 and 3/4 uses the new mwait_play_dead_with_hint
4/4 removes mwait_play_dead and calls cpuidle_play_dead right away
* Reword 1-3/4 changelog slightly.
* Move changelog from v5 1/3 into v6 4/4
Patryk Wlazlyn (4):
x86/smp: Allow calling mwait_play_dead with an arbitrary hint
ACPI: processor_idle: Add FFH state handling
intel_idle: Provide the default enter_dead() handler x86/smp native_play_dead: Prefer cpuidle_play_dead() over
mwait_play_dead()
arch/x86/include/asm/smp.h | 4 ++- arch/x86/kernel/acpi/cstate.c | 9 +++++++ arch/x86/kernel/smpboot.c | 50 ++++------------------------------- drivers/acpi/processor_idle.c | 2 ++ drivers/idle/intel_idle.c | 18 +++++++++++-- include/acpi/processor.h | 5 ++++ 6 files changed, 40 insertions(+), 48 deletions(-)
Signature · 1 line
2.47.1
PATCH v6 1/4 x86/smp: Allow calling mwait_play_dead with an arbitrary hint
The MWAIT instruction needs different hints on different CPUs to reach specific idle states. The current hint calculation in mwait_play_dead() code works in practice on current Intel hardware, but is not documented and fails on a recent Intel's Sierra Forest and possibly some future ones. Those newer CPUs' power efficiency suffers when the CPU is put offline.
Allow cpuidle code to provide mwait_play_dead with a known hint for efficient play_dead code.
--- arch/x86/include/asm/smp.h | 4 +- arch/x86/kernel/smpboot.c | 86 ++++++++++++++++++++------------------ 2 files changed, 49 insertions(+), 41 deletions(-)
arch/x86/include/asm/smp.h +3 -1
@@ -114,6 +114,7 @@ void wbinvd_on_cpu(int cpu);int wbinvd_on_all_cpus (void );void smp_kick_mwait_play_dead (void ); +void mwait_play_dead_with_hint (unsigned int hint);void native_smp_send_reschedule (int cpu);void native_send_call_func_ipi (const struct cpumask *mask);
@@ -151,7 +152,6 @@ static inline struct cpumask *cpu_l2c_shared_mask(int cpu) {return per_cpu (cpu_l2c_shared_map, cpu); } -#else /* !CONFIG_SMP */ #define wbinvd_on_cpu (cpu) wbinvd()static inline int wbinvd_on_all_cpus (void )
@@ -164,6 +164,8 @@ static inline struct cpumask *cpu_llc_shared_mask(int cpu) {return (struct cpumask *)cpumask_of (0 ); } + +static inline void mwait_play_dead_with_hint (unsigned int eax_hint) { }#endif /* CONFIG_SMP */ #ifdef CONFIG_DEBUG_NMI_SELFTEST
arch/x86/kernel/smpboot.c +46 -40
104 lines not on this page · raw message
Signature · 1 line
2.47.1
Re: [PATCH v6 1/4] x86/smp: Allow calling mwait_play_dead with an arbitrary hint
Hello Patryk,
Quoted 9 lines · Patryk Wlazlyn
The MWAIT instruction needs different hints on different CPUs to reach specific idle states. The current hint calculation in
mwait_play_dead()code works in practice on current Intel hardware, but is not documented and fails on a recent Intel's Sierra Forest and possibly some future ones. Those newer CPUs' power efficiency suffers when the CPU is put offline.Allow cpuidle code to provide
mwait_play_deadwith a known hint for efficientplay_deadcode.
Just a couple of minor nits:
You could just reword this something along the lines of:
"Introduce a helper function to allow offlined CPUs to enter FFh idle states with a specific MWAIT hint. The new helper will be used in subsequent patches by the acpi_idle and intel_idle drivers. This patch should not have any functional impact."
There is no need to mention MWAIT hint calculation and the Sierra Forest failure in this patch, as this patch is not doing anything to fix the issue. Very likely you will be covering that in Patch 4.
Quoted 20 lines
Signed-off-by Patryk Wlazlyn <[email protected]>--- arch/x86/include/asm/smp.h | 4 +- arch/x86/kernel/smpboot.c | 86 ++++++++++++++++++++------------------ 2 files changed, 49 insertions(+), 41 deletions(-)arch/x86/include/asm/smp.h +1
-0@@ -114,6 +114,7 @@ void wbinvd_on_cpu(int cpu);int wbinvd_on_all_cpus (void );void smp_kick_mwait_play_dead (void ); +void mwait_play_dead_with_hint (unsigned int hint);void native_smp_send_reschedule (int cpu);void native_send_call_func_ipi (const struct cpumask *mask);
arch/x86/include/asm/smp.h static inline struct cpumask *cpu_l2c_shared_mask(int cpu) · line 157
Quoted 7 lines
arch/x86/include/asm/smp.h +0
-1@@ -151,7 +152,6 @@ static inline struct cpumask *cpu_l2c_shared_mask(int cpu) {return per_cpu (cpu_l2c_shared_map, cpu); } -#else /* !CONFIG_SMP */ #define wbinvd_on_cpu (cpu) wbinvd()static inline int wbinvd_on_all_cpus (void )
This hunk is not relevant to this patch.
The rest of the patch looks good to me.
--
Thanks and Regards
gautham.
Re: [PATCH v6 1/4] x86/smp: Allow calling mwait_play_dead with an arbitrary hint
Quoted 15 lines
Quoted 9 lines
The MWAIT instruction needs different hints on different CPUs to reach specific idle states. The current hint calculation in
mwait_play_dead()code works in practice on current Intel hardware, but is not documented and fails on a recent Intel's Sierra Forest and possibly some future ones. Those newer CPUs' power efficiency suffers when the CPU is put offline.Allow cpuidle code to provide
mwait_play_deadwith a known hint for efficientplay_deadcode.Just a couple of minor nits:
You could just reword this something along the lines of:
Quoted 8 lines
"Introduce a helper function to allow offlined CPUs to enter FFh idle states with a specific MWAIT hint. The new helper will be used in subsequent patches by the
acpi_idleandintel_idledrivers. This patch should not have any functional impact."There is no need to mention MWAIT hint calculation and the Sierra Forest failure in this patch, as this patch is not doing anything to fix the issue. Very likely you will be covering that in Patch 4.
Ok. I thought that giving some context on how the change originated might be useful, but people doesn't seem to like that that much ;]
Quoted 1 line
"(...) This patch should not have any functional impact."
Yeah, forgot to put that no functional change intended.
Quoted 7 lines
Quoted 7 lines
Signed-off-by Patryk Wlazlyn <[email protected]>---
arch/x86/include/asm/smp.h| 4 +- arch/x86/kernel/smpboot.c | 86 ++++++++++++++++++++------------------2 files changed, 49 insertions(+), 41 deletions(-)
Quoted 9 lines
Quoted 9 lines
arch/x86/include/asm/smp.h +0
-0@@ -114,6 +114,7 @@ void wbinvd_on_cpu(int cpu); int wbinvd_on_all_cpus(void);
voidsmp_kick_mwait_play_dead(void); +voidmwait_play_dead_with_hint(unsigned int hint);
That actually is needed.
Quoted 8 lines
arch/x86/include/asm/smp.h static inline struct cpumask *cpu_l2c_shared_mask(int cpu) · line 154
Quoted 8 lines
voidnative_smp_send_reschedule(int cpu);
voidnative_send_call_func_ipi(const struct cpumask *mask);arch/x86/include/asm/smp.h +0
-1@@ -151,7 +152,6 @@ static inline struct cpumask *cpu_l2c_shared_mask(int cpu) { return per_cpu(cpu_l2c_shared_map, cpu); } -
Yeah, missed that one when submitting.
Quoted 5 lines
arch/x86/include/asm/smp.h static inline struct cpumask *cpu_l2c_shared_mask(int cpu) · line 157
Quoted 3 lines
arch/x86/include/asm/smp.h +0
-0#else /* !CONFIG_SMP */ #define wbinvd_on_cpu(cpu) wbinvd() static inline int wbinvd_on_all_cpus(void)This hunk is not relevant to this patch.
PATCH v6 2/4 ACPI: processor_idle: Add FFH state handling
In reply to Patryk WlazlynRecent Intel platforms will depend on the idle driver to pass the correct hint for playing dead via mwait_play_dead_with_hint(). Expand the existing enter_dead interface with handling for FFH states and pass the MWAIT hint to the mwait_play_dead code.
--- arch/x86/kernel/acpi/cstate.c | 9 +++++++++ drivers/acpi/processor_idle.c | 2 ++ include/acpi/processor.h | 5 +++++ 3 files changed, 16 insertions(+)
arch/x86/kernel/acpi/cstate.c +9 -0
@@ -204,6 +204,15 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu, }EXPORT_SYMBOL_GPL (acpi_processor_ffh_cstate_probe); +void acpi_processor_ffh_play_dead (struct acpi_processor_cx *cx) +{ +unsigned int cpu =smp_processor_id (); +struct cstate_entry *percpu_entry; + + percpu_entry =per_cpu_ptr (cpu_cstate_entry, cpu); +mwait_play_dead_with_hint (percpu_entry->states[cx->index].eax); +} + void __cpuidle acpi_processor_ffh_cstate_enter(struct acpi_processor_cx *cx) {unsigned int cpu =smp_processor_id ();
drivers/acpi/processor_idle.c +2 -0
@@ -590,6 +590,8 @@ static void acpi_idle_play_dead(struct cpuidle_device *dev, int index)raw_safe_halt (); else if (cx->entry_method == ACPI_CSTATE_SYSTEMIO) {io_idle (cx->address); + } else if (cx->entry_method == ACPI_CSTATE_FFH) { +acpi_processor_ffh_play_dead (cx); } else return; }
include/acpi/processor.h +5 -0
@@ -280,6 +280,7 @@ int acpi_processor_ffh_cstate_probe(unsigned int cpu,struct acpi_processor_cx *cx, struct acpi_power_register *reg);void acpi_processor_ffh_cstate_enter (struct acpi_processor_cx *cstate); +void acpi_processor_ffh_play_dead (struct acpi_processor_cx *cx);#else static inline void acpi_processor_power_init_bm_check (struct acpi_processor_flags
@@ -300,6 +301,10 @@ static inline void acpi_processor_ffh_cstate_enter(struct acpi_processor_cx {return ; } +static inline void acpi_processor_ffh_play_dead (struct acpi_processor_cx *cx) +{ +return ; +}#endif static inline int call_on_cpu(int cpu, long (*fn)(void *), void *arg,
Signature · 1 line
2.47.1
kernel test robot
build botRe: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling
kernel test robot noticed the following build errors:
Hi Patryk,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge acpi/next tip/x86/core linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Patryk-Wlazlyn/x86-smp-Allow-calling-mwait_play_dead-with-an-arbitrary-hint/20241128-113851 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20241127161518.432616-3-patryk.wlazlyn%40linux.intel.com patch subject: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling config: i386-buildonly-randconfig-002-20241128 (https://download.01.org/0day-ci/archive/20241128/[email protected]/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
>> arch/x86/kernel/acpi/cstate.c:213:2: error: call to undeclared function 'mwait_play_dead_with_hint'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
213 | mwait_play_dead_with_hint(percpu_entry->states[cx->index].eax);
| ^1 error generated.
vim +/mwait_play_dead_with_hint +213 arch/x86/kernel/acpi/cstate.c
206
207 void acpi_processor_ffh_play_dead(struct acpi_processor_cx *cx)
208 {
209 unsigned int cpu = smp_processor_id();
210 struct cstate_entry *percpu_entry;
211
212 percpu_entry = per_cpu_ptr(cpu_cstate_entry, cpu);
> 213 mwait_play_dead_with_hint(percpu_entry->states[cx->index].eax);
214 }
215
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botRe: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling
In reply to Patryk Wlazlynkernel test robot noticed the following build errors:
Hi Patryk,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge acpi/next tip/x86/core linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Patryk-Wlazlyn/x86-smp-Allow-calling-mwait_play_dead-with-an-arbitrary-hint/20241128-113851 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20241127161518.432616-3-patryk.wlazlyn%40linux.intel.com patch subject: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling config: i386-buildonly-randconfig-001-20241128 (https://download.01.org/0day-ci/archive/20241128/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241128/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All errors (new ones prefixed by >>):
arch/x86/kernel/acpi/cstate.c: In function 'acpi_processor_ffh_play_dead':
>> arch/x86/kernel/acpi/cstate.c:213:9: error: implicit declaration of function 'mwait_play_dead_with_hint'; did you mean 'mwait_idle_with_hints'? [-Werror=implicit-function-declaration]
213 | mwait_play_dead_with_hint(percpu_entry->states[cx->index].eax);
| ^~~~~~~~~~~~~~~~~~~~~~~~~
| mwait_idle_with_hintscc1: some warnings being treated as errors
vim +213 arch/x86/kernel/acpi/cstate.c
206
207 void acpi_processor_ffh_play_dead(struct acpi_processor_cx *cx)
208 {
209 unsigned int cpu = smp_processor_id();
210 struct cstate_entry *percpu_entry;
211
212 percpu_entry = per_cpu_ptr(cpu_cstate_entry, cpu);
> 213 mwait_play_dead_with_hint(percpu_entry->states[cx->index].eax);
214 }
215
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
kernel test robot
build botRe: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling
In reply to Patryk Wlazlynkernel test robot noticed the following build warnings:
Hi Patryk,
kernel test robot noticed the following build warnings:
[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on rafael-pm/bleeding-edge linus/master v6.12 next-20241128] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Patryk-Wlazlyn/x86-smp-Allow-calling-mwait_play_dead-with-an-arbitrary-hint/20241128-113851 base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next patch link: https://lore.kernel.org/r/20241127161518.432616-3-patryk.wlazlyn%40linux.intel.com patch subject: [PATCH v6 2/4] ACPI: processor_idle: Add FFH state handling config: x86_64-randconfig-074-20241128 (https://download.01.org/0day-ci/archive/20241129/[email protected]/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/[email protected]/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
All warnings (new ones prefixed by >>):
>> vmlinux.o: warning: objtool: acpi_processor_ffh_play_dead+0xb9: mwait_play_dead_with_hint() is missing a __noreturn annotation
Signature · 2 lines
0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
PATCH v6 3/4 intel_idle: Provide the default enter_dead() handler
In reply to Patryk WlazlynRecent Intel platforms require idle driver to provide information about the MWAIT hint used to enter the deepest idle state in the play_dead code.
Provide the default enter_dead() handler for all of the platforms and allow overwriting with a custom handler for each platform if needed.
--- drivers/idle/intel_idle.c | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-)
drivers/idle/intel_idle.c +16 -2
@@ -56,6 +56,7 @@#include <asm/mwait.h> #include <asm/spec-ctrl.h> #include <asm/fpu/api.h> +#include <asm/smp.h> #define INTEL_IDLE_VERSION "0.5.1"
@@ -227,6 +228,16 @@ static __cpuidle int intel_idle_s2idle(struct cpuidle_device *dev,return 0 ; } +static __cpuidle void intel_idle_enter_dead(struct cpuidle_device *dev, +int index) +{ +struct cpuidle_driver *drv =cpuidle_get_cpu_driver (dev); +struct cpuidle_state *state = &drv->states[index]; +unsigned long eax =flg2MWAIT (state->flags); + +mwait_play_dead_with_hint (eax); +} +/* * States are indexed by the cstate number, * which is also the index into the MWAIT hint array.
@@ -1798,6 +1809,7 @@ static void __init intel_idle_init_cstates_acpi(struct cpuidle_driver *drv) state->flags |=CPUIDLE_FLAG_TIMER_STOP ; state->enter = intel_idle; + state->enter_dead = intel_idle_enter_dead; state->enter_s2idle = intel_idle_s2idle; } }
@@ -2143,10 +2155,12 @@ static void __init intel_idle_init_cstates_icpu(struct cpuidle_driver *drv)if (intel_idle_max_cstate_reached (cstate))break ; -if (!cpuidle_state_table[cstate].enter && - !cpuidle_state_table[cstate].enter_s2idle) +if (!cpuidle_state_table[cstate].enter)break ; +if (!cpuidle_state_table[cstate].enter_dead) + cpuidle_state_table[cstate].enter_dead = intel_idle_enter_dead; +/* If marked as unusable, skip this state. */ if (cpuidle_state_table[cstate].flags &CPUIDLE_FLAG_UNUSABLE ) { pr_debug("state %s is disabled\n",
Signature · 1 line
2.47.1
PATCH v6 4/4 x86/smp native_play_dead: Prefer cpuidle_play_dead() over mwait_play_dead()
In reply to Patryk WlazlynThe current algorithm* for looking up the mwait hint for the deepest cstate, in mwait_play_dead() code works by inspecting CPUID leaf 0x5 and calculates the mwait hint based on the number of reported substates. This approach depends on the hints associated with them to be continuous in the range [0, NUM_SUBSTATES-1]. This continuity is not documented and is not met on the recent Intel platforms.
* The current algorithm is implemented in the for loop inspecting edx in mwait_play_dead().
For example, Intel's Sierra Forest report two cstates with two substates each in cpuid leaf 0x5:
Name* target cstate target subcstate (mwait hint)
===========================================================
C1 0x00 0x00 C1E 0x00 0x01
-- 0x10 ----
C6S 0x20 0x22 C6P 0x20 0x23
-- 0x30 ----
/* No more (sub)states all the way down to the end. */
===========================================================
* Names of the cstates are not included in the CPUID leaf 0x5, they are taken from the product specific documentation.
Notice that hints 0x20 and 0x21 are skipped entirely for the target cstate 0x20 (C6), being a cause of the problem for the current cpuid leaf 0x5 algorithm.
Remove the old implementation of play_dead MWAIT hint calculation based on the CPUID leaf 0x5 in mwait_play_dead() and delegate calling of the mwait_play_dead_with_hint() to the idle driver.
--- arch/x86/kernel/smpboot.c | 52 +++------------------------------------ 1 file changed, 3 insertions(+), 49 deletions(-)
arch/x86/kernel/smpboot.c +3 -49
@@ -1317,52 +1317,6 @@ void __noreturn mwait_play_dead_with_hint(unsigned int eax_hint) } } -/* -* We need to flush the caches before going to sleep, lest we have -* dirty data in our caches when we come back up. -*/ -static inline void mwait_play_dead (void ) -{ -unsigned int eax, ebx, ecx, edx; -unsigned int highest_cstate =0 ; -unsigned int highest_subcstate =0 ; -int i; - -if (boot_cpu_data.x86_vendor ==X86_VENDOR_AMD || - boot_cpu_data.x86_vendor ==X86_VENDOR_HYGON ) -return ; -if (!this_cpu_has (X86_FEATURE_MWAIT )) -return ; -if (!this_cpu_has (X86_FEATURE_CLFLUSH )) -return ; -if (__this_cpu_read (cpu_info.cpuid_level) <CPUID_MWAIT_LEAF ) -return ; - - eax =CPUID_MWAIT_LEAF ; - ecx =0 ; -native_cpuid (&eax, &ebx, &ecx, &edx); - -/* -* eax will be 0 if EDX enumeration is not valid. -* Initialized below to cstate, sub_cstate value when EDX is valid. -*/ -if (!(ecx &CPUID5_ECX_EXTENSIONS_SUPPORTED )) { - eax =0 ; - }else { - edx >>=MWAIT_SUBSTATE_SIZE ; -for (i =0 ; i <7 && edx; i++, edx >>=MWAIT_SUBSTATE_SIZE ) { -if (edx &MWAIT_SUBSTATE_MASK ) { - highest_cstate = i; - highest_subcstate = edx &MWAIT_SUBSTATE_MASK ; - } - } - eax = (highest_cstate <<MWAIT_SUBSTATE_SIZE ) | - (highest_subcstate -1 ); - } - -mwait_play_dead_with_hint (eax); -} -/* * Kick all "offline" CPUs out of mwait on kexec(). See comment in * mwait_play_dead().
@@ -1413,9 +1367,9 @@ void native_play_dead(void)play_dead_common ();tboot_shutdown (TB_SHUTDOWN_WFS ); -mwait_play_dead (); -if (cpuidle_play_dead ()) - hlt_play_dead(); +/* Below returns only on error. */ +cpuidle_play_dead (); + hlt_play_dead(); }#else /* ... !CONFIG_HOTPLUG_CPU */
Signature · 1 line
2.47.1
Quoted 9 lines · Patryk Wlazlyn
Changes since v5:
* Split 1/3 from v5 into two commits, as suggestem by Gautham. 1/4 splitswait_play_deadintomwait_play_dead_with_hint. 2/4 and 3/4 uses the newmwait_play_dead_with_hint
4/4 removesmwait_play_deadand callscpuidle_play_deadright away* Reword 1-3/4 changelog slightly.
* Move changelog from v5 1/3 into v6 4/4
FWIW,
I have tested the series on AMD platforms and there are no issues.
Quoted 8 lines
Patryk Wlazlyn (4):
x86/smp: Allow callingmwait_play_deadwith an arbitrary hint
ACPI:processor_idle: Add FFH state handling
intel_idle: Provide the defaultenter_dead()handler x86/smpnative_play_dead: Prefercpuidle_play_dead()over
mwait_play_dead()
Quoted 11 lines
arch/x86/include/asm/smp.h | 4 ++- arch/x86/kernel/acpi/cstate.c | 9 +++++++ arch/x86/kernel/smpboot.c | 50 ++++------------------------------- drivers/acpi/processor_idle.c | 2 ++ drivers/idle/intel_idle.c | 18 +++++++++++-- include/acpi/processor.h | 5 ++++ 6 files changed, 40 insertions(+), 48 deletions(-)Signature · 1 line
2.47.1
--
Thanks and Regards
gautham.
Quoted 5 lines
FWIW,
I have tested the series on AMD platforms and there are no issues.
Tested-by Gautham R. Shenoy <[email protected]>
Thanks!