Skip to contentSkip to conversation

arm64: dts: qcom: Introduce Huawei Matebook E Go

PATCH Superseded Pengyu Luo 5 participants 21 messages Dec 11, 2024 – Jan 8, 2025

Subsystems (3)

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Pengyu Luo

author
#0 lore raw

cover arm64: dts: qcom: Introduce Huawei Matebook E Go

Add support for the SC8280XP-based Huawei Matebook E Go (sc8280xp)

This is my first time to submit patches to Linux kernel, I have referred to some submit cases, but I will inevitably make mistakes, please give me some advice, thanks.

---

Pengyu Luo (3):
dt-bindings: arm: qcom: Document Huawei Matebook E Go (sc8280xp)
firmware: qcom: scm: Allow QSEECOM on Huawei Matebook E Go (sc8280xp)
arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

 .../devicetree/bindings/arm/qcom.yaml         |    1 +
 arch/arm64/boot/dts/qcom/Makefile             |    1 +
 .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 1332 +++++++++++++++++
 drivers/firmware/qcom/qcom_scm.c              |    1 +
 4 files changed, 1335 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts
Signature · 1 line
2.47.1
author
#1 lore raw

PATCH 1/3 dt-bindings: arm: qcom: Document Huawei Matebook E Go (sc8280xp)

Add compatible for the SC8280XP-based Huawei Matebook E Go, using its codename, gaokun3, which means it is the 3rd gen gaokun.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/qcom.yaml +1 -0
index 9679fed72..355b17259 100644
@@ -822,6 +822,7 @@ properties:
 
       - items:
           - enum:
+              - huawei,gaokun3
               - lenovo,thinkpad-x13s
               - microsoft,arcata
               - qcom,sc8280xp-crd
Signature · 1 line
2.47.1
Acked-by on v1 1/3
#2 lore raw

Re: [PATCH 1/3] dt-bindings: arm: qcom: Document Huawei Matebook E Go (sc8280xp)

Quoted 7 lines · Pengyu Luo

Add compatible for the SC8280XP-based Huawei Matebook E Go, using its codename, gaokun3, which means it is the 3rd gen gaokun.

---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)

---

<form letter>
This is an automated instruction, just in case, because many review tags are being ignored. If you know the process, you can skip it (please do not feel offended by me posting it here - no bad intentions intended). If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577
</form letter>

Best regards,
Krzysztof

author
#3 lore raw

PATCH 2/3 firmware: qcom: scm: Allow QSEECOM on Huawei Matebook E Go (sc8280xp)

In reply to Pengyu Luo

Add the SC8280XP-based Huawei Matebook E Go (sc8280xp) to the allowlist.

---
 drivers/firmware/qcom/qcom_scm.c | 1 +
 1 file changed, 1 insertion(+)
drivers/firmware/qcom/qcom_scm.c +1 -0
index 72bf87ddc..deff48d01 100644
@@ -1769,6 +1769,7 @@ EXPORT_SYMBOL_GPL(qcom_scm_qseecom_app_send);
  */
 static const struct of_device_id qcom_scm_qseecom_allowlist[] __maybe_unused = {
 	{ .compatible = "dell,xps13-9345" },
+	{ .compatible = "huawei,gaokun3" },
 	{ .compatible = "lenovo,flex-5g" },
 	{ .compatible = "lenovo,thinkpad-t14s" },
 	{ .compatible = "lenovo,thinkpad-x13s", },
Signature · 1 line
2.47.1
author
#4 lore raw

PATCH 3/3 arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

In reply to Pengyu Luo

Add an initial devicetree for the Huawei Matebook E Go, which is based on sc8280xp.

There are 3 variants, Huawei released first 2 at the same time. Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2. Huawei Matebook E Go([email protected]), codename is gaokun3. Huawei Matebook E Go 2023([email protected]).

We add support for the latter two variants.

This work started by Tianyu Gao and Xuecong Chen, they made the devicetree based on existing work(i.e. the Lenovo X13s and the Qualcomm CRD), it can boot with framebuffer.

Original work: https://github.com/matalama80td3l/matebook-e-go-boot-works/blob/main/dts/sc8280xp-huawei-matebook-e-go.dts

Later, I got my device, I continue their work.

Supported features:
- adsp
- bluetooth (connect issue)
- charge (with a lower power)
- framebuffer
- gpu
- keyboard (via internal USB)
- pcie devices (wifi and nvme, no modem)
- speakers and microphones
- tablet mode switch
- touchscreen
- usb
- volume key and power key

Some key features not supported yet:
- battery and charger information report (EC driver required)
- built-in display (cannot enable backlight yet)
- charging thresholds control (EC driver required)
- camera
- LID switch detection (EC driver required)
- USB Type-C altmode (EC driver required)
- USB Type-C PD (EC driver required)

I have finished the EC driver, once this series are upstreamed, I will submit a series of patches to enable EC support.

---
 arch/arm64/boot/dts/qcom/Makefile             |    1 +
 .../boot/dts/qcom/sc8280xp-huawei-gaokun3.dts | 1332 +++++++++++++++++
 2 files changed, 1333 insertions(+)
 create mode 100644 arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts
arch/arm64/boot/dts/qcom/Makefile +1 -0
index 6ca8db4b8..00d02cf5f 100644
@@ -195,6 +195,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sc7280-crd-r3.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc8180x-lenovo-flex-5g.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc8180x-primus.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc8280xp-crd.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sc8280xp-huawei-gaokun3.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc8280xp-lenovo-thinkpad-x13s.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sc8280xp-microsoft-arcata.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sda660-inforce-ifc6560.dtb
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +1332 -0

1,332 lines not on this page · raw message

Signature · 1 line
2.47.1
#5 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 32 lines · Pengyu Luo

Add an initial devicetree for the Huawei Matebook E Go, which is based on sc8280xp.

There are 3 variants, Huawei released first 2 at the same time. Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2. Huawei Matebook E Go([email protected]), codename is gaokun3. Huawei Matebook E Go 2023([email protected]).

We add support for the latter two variants.

This work started by Tianyu Gao and Xuecong Chen, they made the devicetree based on existing work(i.e. the Lenovo X13s and the Qualcomm CRD), it can boot with framebuffer.

Original work: https://github.com/matalama80td3l/matebook-e-go-boot-works/blob/main/dts/sc8280xp-huawei-matebook-e-go.dts

Later, I got my device, I continue their work.

Supported features:
- adsp
- bluetooth (connect issue)
- charge (with a lower power)
- framebuffer
- gpu
- keyboard (via internal USB)
- pcie devices (wifi and nvme, no modem)
- speakers and microphones
- tablet mode switch
- touchscreen
- usb
- volume key and power key

Quoted 8 lines

Some key features not supported yet:
- battery and charger information report (EC driver required)
- built-in display (cannot enable backlight yet)
- charging thresholds control (EC driver required)
- camera
- LID switch detection (EC driver required)
- USB Type-C altmode (EC driver required)
- USB Type-C PD (EC driver required)

Does qcom_battmgr / pmic_glink not work?

Quoted 6 lines

I have finished the EC driver, once this series are upstreamed, I will submit a series of patches to enable EC support.

Your commit message suggests Co-developed-by: tags would also be fitting here

[...]

Quoted 4 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +4 -0
+	chosen {
+		#address-cells = <2>;
+		#size-cells = <2>;
+		ranges;

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 47

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +10 -0
+
+		framebuffer0: framebuffer@c6200000 {
+			compatible = "simple-framebuffer";
+			reg = <0x0 0xC6200000 0x0 0x02400000>;
+			width = <1600>;
+			height = <2560>;
+			stride = <(1600 * 4)>;
+			format = "a8r8g8b8";
+		};
+	};

This should be redundant, as you should have efifb

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 53

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+	wcd938x: audio-codec {
+		compatible = "qcom,wcd9380-codec";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&wcd_default>;

Please follow this order throughout the file:

property-n
property-names

[...]

Quoted 19 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +19 -0
+
+		reset-gpios = <&tlmm 106 GPIO_ACTIVE_LOW>;
+
+		vdd-buck-supply = <&vreg_s10b>;
+		vdd-rxtx-supply = <&vreg_s10b>;
+		vdd-io-supply = <&vreg_s10b>;
+		vdd-mic-bias-supply = <&vreg_bob>;
+
+		qcom,micbias1-microvolt = <1800000>;
+		qcom,micbias2-microvolt = <1800000>;
+		qcom,micbias3-microvolt = <1800000>;
+		qcom,micbias4-microvolt = <1800000>;
+		qcom,mbhc-buttons-vthreshold-microvolt = <75000 150000 237000 500000 500000 500000 500000 500000>;
+		qcom,mbhc-headset-vthreshold-microvolt = <1700000>;
+		qcom,mbhc-headphone-vthreshold-microvolt = <50000>;
+		qcom,rx-device = <&wcd_rx>;
+		qcom,tx-device = <&wcd_tx>;
+
+		#sound-dai-cells = <1>;

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 82

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +10 -0
+	};
+
+	gpio-keys {
+		compatible = "gpio-keys";
+
+		pinctrl-names = "default";
+		pinctrl-0 = <&mode_pin_active>, <&vol_up_n>;
+
+		switch-mode {
+			gpios = <&tlmm 26 GPIO_ACTIVE_HIGH>;

This could use a label too - "Tablet Mode Switch", perhaps?

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 89

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +7 -0
+			linux,input-type = <EV_SW>;
+			linux,code = <SW_TABLET_MODE>;
+			debounce-interval = <10>;
+			wakeup-source;
+		};
+
+		key-vol-up {

Please place this node above the switch-mode one to preserve alphabetical ordering (see [1])

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 97

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +8 -0
+			label = "Volume Up";
+			gpios = <&pmc8280_1_gpios 6 GPIO_ACTIVE_LOW>;
+			linux,code = <KEY_VOLUMEUP>;
+			debounce-interval = <15>;
+			linux,can-disable;
+			wakeup-source;
+		};
+

Stray newline

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 408

Quoted 2 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +2 -0
+
+		/* s2c, s3c */

Please remove such comments

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+		/* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+		 * there is no calibrate data for huawei,
+		 * but they have the same subsystem-device id
+		 */
+		qcom,ath11k-calibration-variant = "LE_X13S";

Oh, this can be taken care of! See [2], [3].

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 859

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+&sound {
+	compatible = "qcom,sc8280xp-sndcard";
+	model = "SC8280XP-HUAWEI-MATEBOOKEGO";
+	audio-routing =
+		"SpkrLeft IN", "WSA_SPK1 OUT",

Please remove the line break and

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +5 -0
+		"SpkrRight IN", "WSA_SPK2 OUT",
+		"IN1_HPHL", "HPHL_OUT",
+		"IN2_HPHR", "HPHR_OUT",
+		"AMIC2", "MIC BIAS2",
+		"VA DMIC0", "MIC BIAS1",

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 874

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +10 -0
+		"VA DMIC1", "MIC BIAS1",
+		"VA DMIC2", "MIC BIAS3",
+		"VA DMIC0", "VA MIC BIAS1",
+		"VA DMIC1", "VA MIC BIAS1",
+		"VA DMIC2", "VA MIC BIAS3",
+		"TX SWR_ADC1", "ADC2_OUTPUT";
+
+	wcd-playback-dai-link {
+		link-name = "WCD Playback";
+		cpu {

Please insert a newline between the last property and subnodes.

Otherwise looks fairly good!

Konrad

[1] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
[2] https://lore.kernel.org/ath11k/[email protected]/
[3] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware

author
#6 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Oh, I sent it by gamil wrongly(forgot cc to), I resend it by git send-email again

Quoted 43 lines · Konrad Dybcio
Quoted 8 lines · Pengyu Luo

Add an initial devicetree for the Huawei Matebook E Go, which is based on sc8280xp.

There are 3 variants, Huawei released first 2 at the same time. Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2. Huawei Matebook E Go([email protected]), codename is gaokun3. Huawei Matebook E Go 2023([email protected]).

Quoted 7 lines

We add support for the latter two variants.

This work started by Tianyu Gao and Xuecong Chen, they made the devicetree based on existing work(i.e. the Lenovo X13s and the Qualcomm CRD), it can boot with framebuffer.

Original work:

https://github.com/matalama80td3l/matebook-e-go-boot-works/blob/main/dts/sc8280xp-huawei-matebook-e-go.dts

Quoted 17 lines

Later, I got my device, I continue their work.

Supported features:
- adsp
- bluetooth (connect issue)
- charge (with a lower power)
- framebuffer
- gpu
- keyboard (via internal USB)
- pcie devices (wifi and nvme, no modem)
- speakers and microphones
- tablet mode switch
- touchscreen
- usb
- volume key and power key

Quoted 8 lines

Some key features not supported yet:
- battery and charger information report (EC driver required)
- built-in display (cannot enable backlight yet)
- charging thresholds control (EC driver required)
- camera
- LID switch detection (EC driver required)
- USB Type-C altmode (EC driver required)
- USB Type-C PD (EC driver required)

Quoted 2 lines

Does qcom_battmgr / pmic_glink not work?

Unfortunately, different from many sc8280xp devices, device(PMGK) _STA is Zero,
this device is quiet strange, also, it has no PM8008,
nor PMIC Battery Miniclass(PMBM), etc.

[...]

Quoted 10 lines
Quoted 6 lines

I have finished the EC driver, once this series are upstreamed, I will submit a series of patches to enable EC support.

Your commit message suggests Co-developed-by: tags would also be fitting here

Agree

[...]

Quoted 17 lines

[...]

Quoted 4 lines
(quoted diff) +4 -0
+     chosen {
+             #address-cells =3D <2>;
+             #size-cells =3D <2>;
+             ranges;

Review

Quoted 10 lines
(quoted diff) +10 -0
+
+             framebuffer0: framebuffer@c6200000 {
+                     compatible =3D "simple-framebuffer";
+                     reg =3D <0x0 0xC6200000 0x0 0x02400000>;
+                     width =3D <1600>;
+                     height =3D <2560>;
+                     stride =3D <(1600 * 4)>;
+                     format =3D "a8r8g8b8";
+             };
+     };
Quoted 2 lines

This should be redundant, as you should have efifb

I think no, it won't boot up without it(stuck at EFI stub: Booting Linux Kernel)

[...]

Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+     wcd938x: audio-codec {
+             compatible =3D "qcom,wcd9380-codec";
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&wcd_default>;

Please follow this order throughout the file:

Quoted 3 lines

property-n
property-names

Do you mean I should arragne as following? If so, I actually keep reference devicetree untouched. x13s and crd are written like this.

pinctrl-0 =3D <&wcd_default>>;
pinctrl-names =3D "default";

[...]

Quoted 26 lines

[...]

Review

Quoted 13 lines
(quoted diff) +13 -0
+
+             reset-gpios =3D <&tlmm 106 GPIO_ACTIVE_LOW>;
+
+             vdd-buck-supply =3D <&vreg_s10b>;
+             vdd-rxtx-supply =3D <&vreg_s10b>;
+             vdd-io-supply =3D <&vreg_s10b>;
+             vdd-mic-bias-supply =3D <&vreg_bob>;
+
+             qcom,micbias1-microvolt =3D <1800000>;
+             qcom,micbias2-microvolt =3D <1800000>;
+             qcom,micbias3-microvolt =3D <1800000>;
+             qcom,micbias4-microvolt =3D <1800000>;
+             qcom,mbhc-buttons-vthreshold-microvolt =3D <75000 150000

237000 500000 500000 500000 500000 500000>;

Quoted 10 lines
(quoted diff) +10 -0
+             qcom,mbhc-headset-vthreshold-microvolt =3D <1700000>;
+             qcom,mbhc-headphone-vthreshold-microvolt =3D <50000>;
+             qcom,rx-device =3D <&wcd_rx>;
+             qcom,tx-device =3D <&wcd_tx>;
+
+             #sound-dai-cells =3D <1>;
+     };
+
+     gpio-keys {
+             compatible =3D "gpio-keys";
Quoted 9 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&mode_pin_active>, <&vol_up_n>;
+
+             switch-mode {
+                     gpios =3D <&tlmm 26 GPIO_ACTIVE_HIGH>;

This could use a label too - "Tablet Mode Switch", perhaps?

This part I follow Lenovo Yoga C630 one (see [1]), it doesn't use it, and this node is not referenced.

Quoted 19 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 89

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +7 -0
+                     linux,input-type =3D <EV_SW>;
+                     linux,code =3D <SW_TABLET_MODE>;
+                     debounce-interval =3D <10>;
+                     wakeup-source;
+             };
+
+             key-vol-up {

Please place this node above the switch-mode one to preserve alphabetical ordering (see [1])

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 97

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +8 -0
+                     label =3D "Volume Up";
+                     gpios =3D <&pmc8280_1_gpios 6 GPIO_ACTIVE_LOW>;
+                     linux,code =3D <KEY_VOLUMEUP>;
+                     debounce-interval =3D <15>;
+                     linux,can-disable;
+                     wakeup-source;
+             };
+
Quoted 10 lines

Stray newline

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 408

Quoted 2 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +2 -0
+
+             /* s2c, s3c */

Please remove such comments

Agree

[...]

Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+             /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+              * there is no calibrate data for huawei,
+              * but they have the same subsystem-device id
+              */
+             qcom,ath11k-calibration-variant =3D "LE_X13S";

Oh, this can be taken care of! See [2], [3].

I have a glance, now I know we should extract something or it won't be there.
Question is how can I extract them? I have a quick search, got no luck. As for windows drivers, in the folder

bdwlan.e02
bdwlan.e07
bdwlan.e1d
bdwlan.e1e
bdwlan.e23
bdwlan.e26
bdwlan.e32
bdwlan.e47
bdwlan.e81
bdwlan.e84
bdwlan.e85
bdwlan.e8c
bdwlan.e8e
bdwlan.e9f
bdwlan.ea3
bdwlan.eb8
bdwlan.elf
bdwlan.elf.g
bdwlang.e8b
bdwlang.e9f
bdwlang.ea3
bdwlang.eb8
bdwlang.elf
Data20.msc
Data.msc
m320.bin
m3.bin
qcwlan8280.cat
qcwlan8280.inf
qcwlan8280.sys
regdb.bin
wlanfw20.mbn
wlanfw.mbn

[...]

Quoted 26 lines

[...]

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 859

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+&sound {
+     compatible =3D "qcom,sc8280xp-sndcard";
+     model =3D "SC8280XP-HUAWEI-MATEBOOKEGO";
+     audio-routing =3D
+             "SpkrLeft IN", "WSA_SPK1 OUT",

Please remove the line break and

Quoted 5 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +5 -0
+             "SpkrRight IN", "WSA_SPK2 OUT",
+             "IN1_HPHL", "HPHL_OUT",
+             "IN2_HPHR", "HPHR_OUT",
+             "AMIC2", "MIC BIAS2",
+             "VA DMIC0", "MIC BIAS1",

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 874

Quoted 10 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +10 -0
+             "VA DMIC1", "MIC BIAS1",
+             "VA DMIC2", "MIC BIAS3",
+             "VA DMIC0", "VA MIC BIAS1",
+             "VA DMIC1", "VA MIC BIAS1",
+             "VA DMIC2", "VA MIC BIAS3",
+             "TX SWR_ADC1", "ADC2_OUTPUT";
+
+     wcd-playback-dai-link {
+             link-name =3D "WCD Playback";
+             cpu {
Quoted 2 lines

Please insert a newline between the last property and subnodes.

Agree, but I didn't touch them, they are from x13s and crd (see [2])

Quoted 7 lines

Otherwise looks fairly good!

Konrad

[1] https://docs.kernel.org/devicetree/bindings/dts-coding-style.html
[2] https://lore.kernel.org/ath11k/[email protected]/
[3] https://git.codelinaro.org/clo/ath-firmware/ath11k-firmware

Thanks,
Pengyu

[1] https://elixir.bootlin.com/linux/v6.12.4/source/arch/arm64/boot/dts/qcom/sdm850-lenovo-yoga-c630.dts#L54
[2] https://elixir.bootlin.com/linux/v6.12.4/source/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts#L1125

#7 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 46 lines · Pengyu Luo

Oh, I sent it by gamil wrongly(forgot cc to), I resend it by git send-email again

Quoted 43 lines · Konrad Dybcio
Quoted 8 lines · Pengyu Luo

Add an initial devicetree for the Huawei Matebook E Go, which is based on sc8280xp.

There are 3 variants, Huawei released first 2 at the same time. Huawei Matebook E Go LTE(sc8180x), codename should be gaokun2. Huawei Matebook E Go([email protected]), codename is gaokun3. Huawei Matebook E Go 2023([email protected]).

Quoted 7 lines

We add support for the latter two variants.

This work started by Tianyu Gao and Xuecong Chen, they made the devicetree based on existing work(i.e. the Lenovo X13s and the Qualcomm CRD), it can boot with framebuffer.

Original work:

https://github.com/matalama80td3l/matebook-e-go-boot-works/blob/main/dts/sc8280xp-huawei-matebook-e-go.dts

Quoted 25 lines

Later, I got my device, I continue their work.

Supported features:
- adsp
- bluetooth (connect issue)
- charge (with a lower power)
- framebuffer
- gpu
- keyboard (via internal USB)
- pcie devices (wifi and nvme, no modem)
- speakers and microphones
- tablet mode switch
- touchscreen
- usb
- volume key and power key

Some key features not supported yet:
- battery and charger information report (EC driver required)
- built-in display (cannot enable backlight yet)
- charging thresholds control (EC driver required)
- camera
- LID switch detection (EC driver required)
- USB Type-C altmode (EC driver required)
- USB Type-C PD (EC driver required)

Quoted 7 lines
Quoted 2 lines

Does qcom_battmgr / pmic_glink not work?

Unfortunately, different from many sc8280xp devices, device(PMGK) _STA is Zero,
this device is quiet strange, also, it has no PM8008,
nor PMIC Battery Miniclass(PMBM), etc.

So it's not used on windows.. but have you tried checking if it's still provided by the firwmare?

[...]

Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
(quoted diff) +14 -0
+     chosen {
+             #address-cells =3D <2>;
+             #size-cells =3D <2>;
+             ranges;
+
+             framebuffer0: framebuffer@c6200000 {
+                     compatible =3D "simple-framebuffer";
+                     reg =3D <0x0 0xC6200000 0x0 0x02400000>;
+                     width =3D <1600>;
+                     height =3D <2560>;
+                     stride =3D <(1600 * 4)>;
+                     format =3D "a8r8g8b8";
+             };
+     };
Quoted 5 lines
Quoted 2 lines

This should be redundant, as you should have efifb

I think no, it won't boot up without it(stuck at EFI stub: Booting Linux Kernel)

Do you have CONFIG_EFI and CONFIG_FB_EFI enabled?

(also, your email client does something funny and posts 0x3d, which is ASCII for '=' after that symbol)

Quoted 13 lines

[...]

Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+     wcd938x: audio-codec {
+             compatible =3D "qcom,wcd9380-codec";
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&wcd_default>;

Please follow this order throughout the file:

Quoted 6 lines
Quoted 3 lines

property-n
property-names

Do you mean I should arragne as following? If so, I actually keep reference devicetree untouched. x13s and crd are written like this.

Yeah, we try to unify the style as we progress and we still haven't gotten around to cleaning up files that have been in the tree for years..

Quoted 3 lines

pinctrl-0 =3D <&wcd_default>>;
pinctrl-names =3D "default";

Yes please

[...]

Quoted 12 lines
Quoted 11 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +8 -0
+     gpio-keys {
+             compatible =3D "gpio-keys";
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&mode_pin_active>, <&vol_up_n>;
+
+             switch-mode {
+                     gpios =3D <&tlmm 26 GPIO_ACTIVE_HIGH>;

This could use a label too - "Tablet Mode Switch", perhaps?

Quoted 2 lines

This part I follow Lenovo Yoga C630 one (see [1]), it doesn't use it, and this node is not referenced.

So "label" could mean

label: node-name@unit-address {
	property = "value";
};

when talking about DT nodes, but here I'm speaking of the "label" property (which you set to "Volume Up" in the node below). That is read by Linux and provides a nice human-readable name to the userspace.

Quoted 41 lines
Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+             /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+              * there is no calibrate data for huawei,
+              * but they have the same subsystem-device id
+              */
+             qcom,ath11k-calibration-variant =3D "LE_X13S";

Oh, this can be taken care of! See [2], [3].

I have a glance, now I know we should extract something or it won't be there.
Question is how can I extract them? I have a quick search, got no luck. As for windows drivers, in the folder

bdwlan.e02
bdwlan.e07
bdwlan.e1d
bdwlan.e1e
bdwlan.e23
bdwlan.e26
bdwlan.e32
bdwlan.e47
bdwlan.e81
bdwlan.e84
bdwlan.e85
bdwlan.e8c
bdwlan.e8e
bdwlan.e9f
bdwlan.ea3
bdwlan.eb8
bdwlan.elf
bdwlan.elf.g
bdwlang.e8b
bdwlang.e9f
bdwlang.ea3
bdwlang.eb8
bdwlang.elf
Data20.msc
Data.msc

Quoted 8 lines

m320.bin
m3.bin
qcwlan8280.cat
qcwlan8280.inf
qcwlan8280.sys
regdb.bin
wlanfw20.mbn
wlanfw.mbn

Adding Dmitry who has gone through this multiple times and may be able to help

Konrad

author
#8 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

I am not sure, huawei even provided the PMGK driver, but I think it is not loaded.

If you talking about adsp cdsp and sdsp/slpi (this one should be unrelated), in the firmware driver files, some of them are same as the x13s one

adspr.jsn
adspua.jsn
battmgr.jsn
cdspr.jsn

as for qcadsp8280.mbn should be different from x13s, in the old days, Gao and Chen used firmware from x13s totally, and the firmware didn't work (If I remember correctly, can't be loaded).

As I know, the adsp firmware is tied with many things, even if huawei have moved many features to EC, the device still need it. (like normal usb function, audio? btw, this device can use audioreach-tplg.bin from x13s as well, I am not sure if it fits well.)

Quoted 16 lines
Quoted 16 lines
Quoted 16 lines
Quoted 15 lines
(quoted diff) +14 -0
+     chosen {
+             #address-cells =3D <2>;
+             #size-cells =3D <2>;
+             ranges;
+
+             framebuffer0: framebuffer@c6200000 {
+                     compatible =3D "simple-framebuffer";
+                     reg =3D <0x0 0xC6200000 0x0 0x02400000>;
+                     width =3D <1600>;
+                     height =3D <2560>;
+                     stride =3D <(1600 * 4)>;
+                     format =3D "a8r8g8b8";
+             };
+     };
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines

This should be redundant, as you should have efifb

I think no, it won't boot up without it(stuck at EFI stub: Booting Linux Kernel)

Do you have CONFIG_EFI and CONFIG_FB_EFI enabled?

Yes, I enabled them.

Quoted 4 lines

(also, your email client does something funny and posts 0x3d, which is ASCII for '=' after that symbol)

I am sorry, hah, the first time I reply it by gmail directly, but it didn't help me cc to others. Then I sent the exported original message(it added the 3D for =, I didn't notice that at that time).

Quoted 25 lines
Quoted 13 lines

[...]

Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+     wcd938x: audio-codec {
+             compatible =3D "qcom,wcd9380-codec";
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&wcd_default>;

Please follow this order throughout the file:

Quoted 6 lines
Quoted 3 lines

property-n
property-names

Do you mean I should arragne as following? If so, I actually keep reference devicetree untouched. x13s and crd are written like this.

Yeah, we try to unify the style as we progress and we still haven't gotten around to cleaning up files that have been in the tree for years..

Quoted 1 line
Quoted 7 lines
Quoted 2 lines

pinctrl-0 =3D <&wcd_default>>;
pinctrl-names =3D "default";

Yes please

[...]

Got it. I will do it in V2.

Quoted 17 lines
Quoted 12 lines
Quoted 11 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 8 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +8 -0
+     gpio-keys {
+             compatible =3D "gpio-keys";
+
+             pinctrl-names =3D "default";
+             pinctrl-0 =3D <&mode_pin_active>, <&vol_up_n>;
+
+             switch-mode {
+                     gpios =3D <&tlmm 26 GPIO_ACTIVE_HIGH>;

This could use a label too - "Tablet Mode Switch", perhaps?

Quoted 2 lines

This part I follow Lenovo Yoga C630 one (see [1]), it doesn't use it, and this node is not referenced.

So "label" could mean

Quoted 9 lines
label: node-name@unit-address {
	  property = "value";
};

when talking about DT nodes, but here I'm speaking of the "label" property (which you set to "Volume Up" in the node below). That is read by Linux and provides a nice human-readable name to the userspace.

It makes sense, agree. I misunderstood.

Quoted 50 lines
Quoted 41 lines
Quoted 10 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts

Quoted 7 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+             /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+              * there is no calibrate data for huawei,
+              * but they have the same subsystem-device id
+              */
+             qcom,ath11k-calibration-variant =3D "LE_X13S";

Oh, this can be taken care of! See [2], [3].

I have a glance, now I know we should extract something or it won't be there.
Question is how can I extract them? I have a quick search, got no luck. As for windows drivers, in the folder

bdwlan.e02
bdwlan.e07
bdwlan.e1d
bdwlan.e1e
bdwlan.e23
bdwlan.e26
bdwlan.e32
bdwlan.e47
bdwlan.e81
bdwlan.e84
bdwlan.e85
bdwlan.e8c
bdwlan.e8e
bdwlan.e9f
bdwlan.ea3
bdwlan.eb8
bdwlan.elf
bdwlan.elf.g
bdwlang.e8b
bdwlang.e9f
bdwlang.ea3
bdwlang.eb8
bdwlang.elf
Data20.msc
Data.msc

Quoted 8 lines

m320.bin
m3.bin
qcwlan8280.cat
qcwlan8280.inf
qcwlan8280.sys
regdb.bin
wlanfw20.mbn
wlanfw.mbn

Quoted 4 lines

Adding Dmitry who has gone through this multiple times and may be able to help

Konrad

I see, thanks.

Pengyu

#9 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 12 lines · Pengyu Luo

I am not sure, huawei even provided the PMGK driver, but I think it is not loaded.

If you talking about adsp cdsp and sdsp/slpi (this one should be unrelated), in the firmware driver files, some of them are same as the x13s one

adspr.jsn
adspua.jsn
battmgr.jsn
cdspr.jsn

Quoted 8 lines

as for qcadsp8280.mbn should be different from x13s, in the old days, Gao and Chen used firmware from x13s totally, and the firmware didn't work (If I remember correctly, can't be loaded).

As I know, the adsp firmware is tied with many things, even if huawei have moved many features to EC, the device still need it. (like normal usb function, audio? btw, this device can use audioreach-tplg.bin from x13s as well, I am not sure if it fits well.)

The jsn files are just descriptions of what "services" should be used (including the battmgr service) for the userland utility, and nowadays we have a kernel driver that does the same:

drivers/soc/qcom/qcom_pd_mapper.c

Start your ADSP with the firmware from your device and post the dmesg output.

[...]

Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 14 lines
(quoted diff) +14 -0
+     chosen {
+             #address-cells =3D <2>;
+             #size-cells =3D <2>;
+             ranges;
+
+             framebuffer0: framebuffer@c6200000 {
+                     compatible =3D "simple-framebuffer";
+                     reg =3D <0x0 0xC6200000 0x0 0x02400000>;
+                     width =3D <1600>;
+                     height =3D <2560>;
+                     stride =3D <(1600 * 4)>;
+                     format =3D "a8r8g8b8";
+             };
+     };
Quoted 7 lines
Quoted 7 lines
Quoted 5 lines
Quoted 2 lines

This should be redundant, as you should have efifb

I think no, it won't boot up without it(stuck at EFI stub: Booting Linux Kernel)

Do you have CONFIG_EFI and CONFIG_FB_EFI enabled?

Very very weird. Are you booting with clk_ignore_unused pd_ignore_unused in kernel cmdline?

Konrad

author
#10 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

should I attach the all?

# dmesg | grep -i 'adsp '
[    0.000000] OF: reserved mem: 0x0000000086c00000..0x0000000088bfffff (32768 KiB) nomap non-reusable adsp-region@86c00000
[    2.249916] remoteproc remoteproc1: Booting fw image qcom/sc8280xp/HUAWEI/gaokun3/qcadsp8280.mbn, size 12950508
[    2.556517] PDR: Indication received from msm/adsp/audio_pd, state: 0x1fffffff, trans-id: 1
[    2.556546] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:1
[    2.556594] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:2
Quoted 20 lines

[...]

Quoted 18 lines
Quoted 18 lines
Quoted 18 lines
Quoted 17 lines
Quoted 4 lines
(quoted diff) +4 -0
+     chosen {
+             #address-cells =3D <2>;
+             #size-cells =3D <2>;
+             ranges;

Review

Quoted 10 lines
(quoted diff) +10 -0
+
+             framebuffer0: framebuffer@c6200000 {
+                     compatible =3D "simple-framebuffer";
+                     reg =3D <0x0 0xC6200000 0x0 0x02400000>;
+                     width =3D <1600>;
+                     height =3D <2560>;
+                     stride =3D <(1600 * 4)>;
+                     format =3D "a8r8g8b8";
+             };
+     };

This should be redundant, as you should have efifb

Quoted 8 lines
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines

I think no, it won't boot up without it(stuck at EFI stub: Booting Linux Kernel)

Do you have CONFIG_EFI and CONFIG_FB_EFI enabled?

Very very weird. Are you booting with clk_ignore_unused pd_ignore_unused in kernel cmdline?

yes, as Johan said this (see [1])

Quoted 3 lines

Konrad

Pengyu

[1] https://github.com/jhovold/linux/wiki/X13s#kernel-command-line

#11 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 7 lines · Pengyu Luo

should I attach the all?

# dmesg | grep -i 'adsp '
[    0.000000] OF: reserved mem: 0x0000000086c00000..0x0000000088bfffff (32768 KiB) nomap non-reusable adsp-region@86c00000
[    2.249916] remoteproc remoteproc1: Booting fw image qcom/sc8280xp/HUAWEI/gaokun3/qcadsp8280.mbn, size 12950508
[    2.556517] PDR: Indication received from msm/adsp/audio_pd, state: 0x1fffffff, trans-id: 1
[    2.556546] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:1
[    2.556594] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:2

(Please don't top-post)

Yes, please share the whole thing

Konrad

author
#12 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 11 lines · Konrad Dybcio
Quoted 7 lines · Pengyu Luo

should I attach the all?

# dmesg | grep -i 'adsp '
[    0.000000] OF: reserved mem: 0x0000000086c00000..0x0000000088bfffff (32768 KiB) nomap non-reusable adsp-region@86c00000
[    2.249916] remoteproc remoteproc1: Booting fw image qcom/sc8280xp/HUAWEI/gaokun3/qcadsp8280.mbn, size 12950508
[    2.556517] PDR: Indication received from msm/adsp/audio_pd, state: 0x1fffffff, trans-id: 1
[    2.556546] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:1
[    2.556594] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:2

(Please don't top-post)

Sorry, I am getting used to mailing lists, recently I write replys with text editor, last twice I didn't give a blank line between subject and main content, then quotes were removed when sending via git send-email.

Quoted 1 line

Yes, please share the whole thing

Check this https://pastebin.com/p2JyGW4K

Pengyu

#13 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 13 lines · Pengyu Luo
Quoted 11 lines · Konrad Dybcio
Quoted 7 lines · Pengyu Luo

should I attach the all?

# dmesg | grep -i 'adsp '
[    0.000000] OF: reserved mem: 0x0000000086c00000..0x0000000088bfffff (32768 KiB) nomap non-reusable adsp-region@86c00000
[    2.249916] remoteproc remoteproc1: Booting fw image qcom/sc8280xp/HUAWEI/gaokun3/qcadsp8280.mbn, size 12950508
[    2.556517] PDR: Indication received from msm/adsp/audio_pd, state: 0x1fffffff, trans-id: 1
[    2.556546] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:1
[    2.556594] qcom,apr 3000000.remoteproc:glink-edge.adsp_apps.-1.-1: Adding APR/GPR dev: gprsvc:service:2:2

(Please don't top-post)

Quoted 7 lines

Sorry, I am getting used to mailing lists, recently I write replys with text editor, last twice I didn't give a blank line between subject and main content, then quotes were removed when sending via git send-email.

Quoted 1 line

Yes, please share the whole thing

Check this https://pastebin.com/p2JyGW4K

Hm, right, looks like battmgr is not there..

Konrad

author
#14 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

In reply to Pengyu Luo

On Fri, Dec 13, 2024 at 1:13 AM Konrad Dybcio <[email protected]> wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+		/* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+		 * there is no calibrate data for huawei,
+		 * but they have the same subsystem-device id
+		 */
+		qcom,ath11k-calibration-variant = "LE_X13S";

Oh, this can be taken care of! See [2], [3].

[...]

Hi, Konrad

I want to distrub you again.

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

Pengyu

[1] https://github.com/qca/qca-swiss-army-knife

#15 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 22 lines · Pengyu Luo

On Fri, Dec 13, 2024 at 1:13 AM Konrad Dybcio <[email protected]> wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+		/* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+		 * there is no calibrate data for huawei,
+		 * but they have the same subsystem-device id
+		 */
+		qcom,ath11k-calibration-variant = "LE_X13S";

Oh, this can be taken care of! See [2], [3].

[...]

Hi, Konrad

I want to distrub you again.

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

Quoted 8 lines

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

Quoted 4 lines

Pengyu

[1] https://github.com/qca/qca-swiss-army-knife

Signature · 2 lines
With best wishes
Dmitry
author
#16 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 28 lines · Dmitry Baryshkov
Quoted 27 lines · Pengyu Luo

On Fri, Dec 13, 2024 at 1:13 AM Konrad Dybcio <[email protected]> wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+          /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+           * there is no calibrate data for huawei,
+           * but they have the same subsystem-device id
+           */
+          qcom,ath11k-calibration-variant = "LE_X13S";

Oh, this can be taken care of! See [2], [3].

[...]

Hi, Konrad

I want to distrub you again.

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048
Quoted 9 lines
Quoted 3 lines

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

But how? Is it possible that some boards have no calibration data? I tried to track the access time of files, the result shows that these bdwlan* are never touched. According to my observation, these files should have been accessed, (like BT firmware on windows).

Quoted 8 lines
Quoted 4 lines

Pengyu

[1] https://github.com/qca/qca-swiss-army-knife

--
With best wishes
Dmitry

Pengyu

#17 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 40 lines · Pengyu Luo
Quoted 28 lines · Dmitry Baryshkov
Quoted 27 lines · Pengyu Luo

On Fri, Dec 13, 2024 at 1:13 AM Konrad Dybcio <[email protected]> wrote:

[...]

Quoted 8 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+          /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+           * there is no calibrate data for huawei,
+           * but they have the same subsystem-device id
+           */
+          qcom,ath11k-calibration-variant = "LE_X13S";

Oh, this can be taken care of! See [2], [3].

[...]

Hi, Konrad

I want to distrub you again.

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048
Quoted 9 lines
Quoted 3 lines

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

Quoted 4 lines

But how? Is it possible that some boards have no calibration data? I tried to track the access time of files, the result shows that these bdwlan* are never touched. According to my observation, these files should have been accessed, (like BT firmware on windows).

On Windows? Unfortunately I have no idea :-( Please try asking on the ath11k mailing list.

Quoted 12 lines
Quoted 9 lines
Quoted 5 lines

Pengyu

[1] https://github.com/qca/qca-swiss-army-knife

--
With best wishes
Dmitry

Pengyu

Signature · 2 lines
With best wishes
Dmitry
#18 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

In reply to Dmitry Baryshkov
Quoted 17 lines · Dmitry Baryshkov
Quoted 15 lines · Pengyu Luo
Quoted 6 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+		/* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+		 * there is no calibrate data for huawei,
+		 * but they have the same subsystem-device id
+		 */
+		qcom,ath11k-calibration-variant = "LE_X13S";

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048
Quoted 8 lines
Quoted 3 lines

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

The board files used by Windows are not compatible with the Linux firmware, so the calibration data needs to come from Qualcomm.

Try filing a request in the bugzilla:

	https://bugzilla.kernel.org/buglist.cgi?quicksearch=ath11k&list_id=1147229

Johan

author
#19 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 22 lines · Johan Hovold
Quoted 21 lines · Dmitry Baryshkov
Quoted 18 lines · Pengyu Luo
Quoted 6 lines

arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts line 666

Quoted 6 lines
arch/arm64/boot/dts/qcom/sc8280xp-huawei-gaokun3.dts new file +6 -0
+
+                /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+                 * there is no calibrate data for huawei,
+                 * but they have the same subsystem-device id
+                 */
+                qcom,ath11k-calibration-variant = "LE_X13S";

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

Quoted 8 lines
Quoted 4 lines

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

The board files used by Windows are not compatible with the Linux firmware, so the calibration data needs to come from Qualcomm.

Then I don't understand why those bdwlan.* files would be in the firmware tree.

Quoted 4 lines

Try filing a request in the bugzilla:

	https://bugzilla.kernel.org/buglist.cgi?quicksearch=ath11k&list_id=1147229

Thanks, I will try it.

Quoted 1 line

Johan

Best wishes,
Pengyu

#20 lore raw

Re: [PATCH 3/3] arm64: dts: qcom: sc8280xp: Add Huawei Matebook E Go (sc8280xp)

Quoted 29 lines · Pengyu Luo
Quoted 27 lines · Johan Hovold
Quoted 25 lines · Dmitry Baryshkov
Quoted 10 lines · Pengyu Luo
Quoted 6 lines

Review

Quoted 6 lines
(quoted diff) +6 -0
+
+                /* /lib/firmware/ath11k/WCN6855/hw2.1/board-2.bin
+                 * there is no calibrate data for huawei,
+                 * but they have the same subsystem-device id
+                 */
+                qcom,ath11k-calibration-variant = "LE_X13S";

Finally, I found something, after I enabled ath11k boot dbg, I got my id_string='bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255`

Quoted 8 lines

With qca-swiss-army-knife (see [1])

$ ./ath11k-bdencoder -e board-2.bin | grep -i "$id_string"
bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=255.bin created size: 60048

It have already been here. So that means I don't need to extract from Windows. I just extract it from linux-firmware then give it a variant name and send patches to ath11k, right?

No. Usually 255 is an ID that is used by a variety of boards. So, basically, you have to extract board data from Windows, add a proper calibration variant that is specific to your board and then send the resulting data to the ath11k mailing list.

Quoted 6 lines
Quoted 3 lines

The board files used by Windows are not compatible with the Linux firmware, so the calibration data needs to come from Qualcomm.

Then I don't understand why those bdwlan.* files would be in the firmware tree.

Those (Windows) files are supposedly used by the Windows driver firmware. The Linux firmware cannot consume those directly and Qualcomm had to provide us a corresponding file for the X13s (which they then included in board-2.bin and pushed to linux-firmware).

Johan