Skip to contentSkip to conversation

rockchip: Add support for RK3582

PATCH Applied FUKAUMI Naoki 4 participants 8 messages Dec 26, 2024 – Jan 8, 2025

Subsystems (2)

v3 of 6 Applied Latest is v6 →

lore
Share & tools
lore
#0 lore raw

v3 cover rockchip: Add support for RK3582

Rockchip RK3582 is a scaled down version of Rockchip RK3588(S).

- Dual Cortex-A76 and quad Cortex-A55 CPU
- No GPU
- 5TOPS NPU
- H.264/H.265 video encoder up to 4K@60fps

This patch series adds support for the Radxa E52C compact network computer based on the RK3582.

FUKAUMI Naoki (2):
dt-bindings: arm: rockchip: Add Radxa E52C
arm64: dts: rockchip: Add Radxa E52C

 .../devicetree/bindings/arm/rockchip.yaml     |   6 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 743 ++++++++++++++++++
 3 files changed, 750 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#1 lore raw

PATCH v3 1/2 dt-bindings: arm: rockchip: Add Radxa E52C

Add devicetree binding for the Radxa E52C.

Radxa E52C is a compact network computer based on the Rockchip RK3582 SoC.

---
Changes in v3:
- Collect A-b tag
Changes in v2:
- Add "rockchip,rk3588s"

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +6 -0
index 753199a12923..2152d170524a 100644
@@ -812,6 +812,12 @@ properties:
           - const: radxa,e20c
           - const: rockchip,rk3528
 
+      - description: Radxa E52C
+        items:
+          - const: radxa,e52c
+          - const: rockchip,rk3582
+          - const: rockchip,rk3588s
+
       - description: Radxa Rock
         items:
           - const: radxa,rock
Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#2 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C

Hi Kever,

What do you think about the introduction of the "rockchip,rk3582" compatibility string?

Best regards,

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 23 lines · FUKAUMI Naoki

Add devicetree binding for the Radxa E52C.

Radxa E52C is a compact network computer based on the Rockchip RK3582 SoC.

---
Changes in v3:
- Collect A-b tag
Changes in v2:
- Add "rockchip,rk3588s"

---
  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +0 -0
index 753199a12923..2152d170524a 100644
@@ -812,6 +812,12 @@ properties:
            - const: radxa,e20c
            - const: rockchip,rk3528

Documentation/devicetree/bindings/arm/rockchip.yaml properties: · line 823

Quoted 10 lines
Documentation/devicetree/bindings/arm/rockchip.yaml +6 -0
 
+      - description: Radxa E52C
+        items:
+          - const: radxa,e52c
+          - const: rockchip,rk3582
+          - const: rockchip,rk3588s
+
        - description: Radxa Rock
          items:
            - const: radxa,rock

_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip

maintainer
#3 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C

Hey,

Am Freitag, 3. Januar 2025, 07:45:58 CET schrieb FUKAUMI Naoki:

Quoted 4 lines

Hi Kever,

What do you think about the introduction of the "rockchip,rk3582" compatibility string?

I'm not Kever, but I do like the way you did this :-) .

I.e. the rk3582 _is_ a rk3588 with those cores disabled.

So going the way you did allows us to not introduce too much overhead while still already having the rk3582 naming in there if it becomes necessary later on.

Heiko

Quoted 40 lines

--
FUKAUMI Naoki
Radxa Computer (Shenzhen) Co., Ltd.

Quoted 33 lines · FUKAUMI Naoki

Add devicetree binding for the Radxa E52C.

Radxa E52C is a compact network computer based on the Rockchip RK3582 SoC.

---
Changes in v3:
- Collect A-b tag
Changes in v2:
- Add "rockchip,rk3588s"

---
  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +6 -0
index 753199a12923..2152d170524a 100644
@@ -812,6 +812,12 @@ properties:
            - const: radxa,e20c
            - const: rockchip,rk3528
 
+      - description: Radxa E52C
+        items:
+          - const: radxa,e52c
+          - const: rockchip,rk3582
+          - const: rockchip,rk3588s
+
        - description: Radxa Rock
          items:
            - const: radxa,rock
#4 lore raw

Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Radxa E52C

Hello Heiko,

Quoted 11 lines · Heiko Stuebner

Am Freitag, 3. Januar 2025, 07:45:58 CET schrieb FUKAUMI Naoki:

Quoted 2 lines

What do you think about the introduction of the "rockchip,rk3582" compatibility string?

I'm not Kever, but I do like the way you did this :-) .

I.e. the rk3582 _is_ a rk3588 with those cores disabled.

So going the way you did allows us to not introduce too much overhead while still already having the rk3582 naming in there if it becomes necessary later on.

I'm glad that you like it, so it hasn't turned out it was me providing some kind of bad guidance, so to speak. :) [*]

[*] https://lore.kernel.org/linux-rockchip/[email protected]/

Quoted 34 lines
Quoted 34 lines · FUKAUMI Naoki
Quoted 33 lines

Add devicetree binding for the Radxa E52C.

Radxa E52C is a compact network computer based on the Rockchip RK3582 SoC.

---
Changes in v3:
- Collect A-b tag
Changes in v2:
- Add "rockchip,rk3588s"

---
  Documentation/devicetree/bindings/arm/rockchip.yaml | 6 ++++++
  1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +6 -0
index 753199a12923..2152d170524a 100644
@@ -812,6 +812,12 @@ properties:
            - const: radxa,e20c
            - const: rockchip,rk3528
 
+      - description: Radxa E52C
+        items:
+          - const: radxa,e52c
+          - const: rockchip,rk3582
+          - const: rockchip,rk3588s
+
        - description: Radxa Rock
          items:
            - const: radxa,rock
#5 lore raw

PATCH v3 2/2 arm64: dts: rockchip: Add Radxa E52C

In reply to FUKAUMI Naoki

Radxa E52C[1] is a compact network computer based on the Rockchip RK3582 SoC:

- Dual Cortex-A76 and quad Cortex-A55 CPU
- 5TOPS NPU
- 2GB/4GB/8GB LPDDR4 RAM
- 16GB/32GB/64GB on-board eMMC
- microSD card slot
- USB 3.0 Type-A HOST port
- USB Type-C debug port
- USB Type-C power port (5V only)
- 2x 2.5GbE ports

[1] https://radxa.com/products/network-computer/e52c

---
Changes in v3:
- Use "^button-" for a sub-node of "adc-keys"
- Add comment about defective big core (Dragan Simic)
- Trivial changes
Changes in v2:
- Generalize node names
- Add "rockchip,rk3588s" to compatible
- Add RTC
- Trivial changes

---
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 743 ++++++++++++++++++
 2 files changed, 744 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts
arch/arm64/boot/dts/rockchip/Makefile +1 -0
index cac3f39af82a..e6e71e8f5519 100644
@@ -157,6 +157,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-display-vz.dtbo
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-wolfvision-pf5-io-expander.dtbo
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3576-armsom-sige5.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3582-radxa-e52c.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-sige7.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-armsom-w3.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3588-coolpi-cm5-evb.dtb
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts new file +743 -0

743 lines not on this page · raw message

Signature · 7 lines
2.43.0


_______________________________________________
Linux-rockchip mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-rockchip
#6 lore raw
In reply to FUKAUMI Naoki
Quoted 14 lines · FUKAUMI Naoki

Rockchip RK3582 is a scaled down version of Rockchip RK3588(S).

- Dual Cortex-A76 and quad Cortex-A55 CPU
- No GPU
- 5TOPS NPU
- H.264/H.265 video encoder up to 4K@60fps

This patch series adds support for the Radxa E52C compact network computer based on the RK3582.

FUKAUMI Naoki (2):
dt-bindings: arm: rockchip: Add Radxa E52C
arm64: dts: rockchip: Add Radxa E52C

Quoted 11 lines
 .../devicetree/bindings/arm/rockchip.yaml     |   6 +
 arch/arm64/boot/dts/rockchip/Makefile         |   1 +
 .../boot/dts/rockchip/rk3582-radxa-e52c.dts   | 743 ++++++++++++++++++
 3 files changed, 750 insertions(+)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dts

--
2.43.0

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3582-radxa-e52c.dtb' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dtb: leds-1: led-1:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:

	'r8169-4-4100:00:link' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'netdev', 'none', 'rc-feedback', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'r8169-4-4100:00:link' does not match '^cpu[0-9]*$'
	'r8169-4-4100:00:link' does not match '^hci[0-9]+-power$'
	'r8169-4-4100:00:link' does not match '^mmc[0-9]+$'
	'r8169-4-4100:00:link' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dtb: leds-1: led-1: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
	from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#
arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dtb: leds-1: led-2:linux,default-trigger: 'oneOf' conditional failed, one must be fixed:
	'r8169-3-3100:00:link' is not one of ['backlight', 'default-on', 'heartbeat', 'disk-activity', 'disk-read', 'disk-write', 'timer', 'pattern', 'audio-micmute', 'audio-mute', 'bluetooth-power', 'flash', 'kbd-capslock', 'mtd', 'nand-disk', 'netdev', 'none', 'rc-feedback', 'torch', 'usb-gadget', 'usb-host', 'usbport']
	'r8169-3-3100:00:link' does not match '^cpu[0-9]*$'
	'r8169-3-3100:00:link' does not match '^hci[0-9]+-power$'
	'r8169-3-3100:00:link' does not match '^mmc[0-9]+$'
	'r8169-3-3100:00:link' does not match '^phy[0-9]+tx$'
	from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#

arch/arm64/boot/dts/rockchip/rk3582-radxa-e52c.dtb: leds-1: led-2: Unevaluated properties are not allowed ('linux,default-trigger' was unexpected)
from schema $id: http://devicetree.org/schemas/leds/leds-pwm.yaml#

maintainer Applied
#7 lore raw
In reply to FUKAUMI Naoki
Quoted 8 lines · FUKAUMI Naoki

Rockchip RK3582 is a scaled down version of Rockchip RK3588(S).

- Dual Cortex-A76 and quad Cortex-A55 CPU
- No GPU
- 5TOPS NPU
- H.264/H.265 video encoder up to 4K@60fps

[...]

Applied, thanks!

[1/2] dt-bindings: arm: rockchip: Add Radxa E52C

      commit: ddf021193879f54bb8fd9acdcf467b24229a553e
[2/2] arm64: dts: rockchip: Add Radxa E52C
      commit: 9be4171219b659a8f0fa0a7913af2c6ab20c714e

changed the rtl-net led-triggers to "netdev" for now, to a value compatible with the binding.

Best regards,

Signature · 1 line
Heiko Stuebner <[email protected]>