Skip to contentSkip to conversation

PCI/AER:Add error message when unable to handle additional devices

PATCH In review Atharva Tiwari 2 participants 4 messages Dec 27, 2024 – Jan 3, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PCI/AER:Add error message when unable to handle additional devices

Log an error message in `find_device_iter'
when the system cannot handle more error devices.

---
 drivers/pci/pcie/aer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie/aer.c +1 -1
index 34ce9f834d0c..04743617202e 100644
@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
 		/* List this device */
 		if (add_error_device(e_info, dev)) {
 			/* We cannot handle more... Stop iteration */
-			/* TODO: Should print error message here? */
+			pr_err("PCI: Unable to handle additional error devices\n");
 			return 1;
 		}
 
Signature · 1 line
2.39.5
#1 lore raw
Quoted 2 lines · On Fri, 27 Dec 2024 12:49:10 +0530 Atharva Tiwari <[email protected]> wrote:

Log an error message in `find_device_iter'
when the system cannot handle more error devices.

Needs a statement of 'why'

Jonathan

Quoted 19 lines
---
 drivers/pci/pcie/aer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie/aer.c +1 -1
index 34ce9f834d0c..04743617202e 100644
@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)
 		/* List this device */
 		if (add_error_device(e_info, dev)) {
 			/* We cannot handle more... Stop iteration */
-			/* TODO: Should print error message here? */
+			pr_err("PCI: Unable to handle additional error devices\n");
 			return 1;
 		}
 
#3 lore raw
Quoted 2 lines · On Fri, 3 Jan 2025 18:50:35 +0530 Atharva Tiwari <[email protected]> wrote:

i completed the todo on line 886 thats why

It is a question, not a todo. So if you wish to
make the change you need to discuss why the answer to that question was 'yes it makes sense to print an error message here'.

Jonathan