PCI/AER:Add error message when unable to handle additional devices
Subsystems (2)
PATCH 1/1 PCI/AER:Add error message when unable to handle additional devices
Log an error message in `find_device_iter'
when the system cannot handle more error devices.
Signed-off-by Atharva Tiwari <[email protected]>
--- drivers/pci/pcie/aer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/pci/pcie/aer.c +1 -1
@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)/* List this device */ if (add_error_device (e_info, dev)) {/* We cannot handle more... Stop iteration */ -/* TODO: Should print error message here? */ +pr_err ("PCI: Unable to handle additional error devices\n" );return 1 ; }
Signature · 1 line
2.39.5
Quoted 2 lines · On Fri, 27 Dec 2024 12:49:10 +0530 Atharva Tiwari <[email protected]> wrote:
Log an error message in `find_device_iter'
when the system cannot handle more error devices.
Needs a statement of 'why'
Jonathan
Quoted 19 lines
Signed-off-by Atharva Tiwari <[email protected]>--- drivers/pci/pcie/aer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/pci/pcie/aer.c +1
-1@@ -886,7 +886,7 @@ static int find_device_iter(struct pci_dev *dev, void *data)/* List this device */ if (add_error_device (e_info, dev)) {/* We cannot handle more... Stop iteration */ -/* TODO: Should print error message here? */ +pr_err ("PCI: Unable to handle additional error devices\n" );return 1 ; }
PATCH 1/1 PCI/AER:Add error message when unable to handle additional devices
In reply to Atharva Tiwarii completed the todo on line 886 thats why
Quoted 2 lines · On Fri, 3 Jan 2025 18:50:35 +0530 Atharva Tiwari <[email protected]> wrote:
i completed the todo on line 886 thats why
It is a question, not a todo. So if you wish to
make the change you need to discuss why the answer to that question was 'yes it makes sense to print an error message here'.
Jonathan