Skip to contentSkip to conversation

arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2

PATCH Superseded Ivan Sergeev 4 participants 7 messages Dec 30, 2024 – Jan 5, 2025

Subsystems (2)

v4 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

v4 cover arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2

BigTreeTech CB2 and Pi2 are Rockchip RK3566 SoM and SBC boards made by BigTreeTech for the intent of using as a 3d printer control board. It is a successor to the Allwinner H616-based BigTreeTech CB1 and Pi, so the device trees for CB2 and Pi2 are also done in the same manner: the common nodes and properties are put into a dtsi file that the board-specific device trees include.

Changes in v4:
- Removed invalid i2c,ignore-nak properties
- Set #address-cells and size-cells on sdmmc1
- Fixed phy-supply properties of usb host nodes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Proper formatting and patch series sending (using b4)
- Converted spaces to tab indentation in the dtsi file
- Fixed empty line where the license identifier should be
- Link to v2 1/2: https://lore.kernel.org/linux-rockchip/[email protected]/
- Link to v2 2/2: https://lore.kernel.org/linux-rockchip/[email protected]/

Changes in v2:
- Added bigtreetech cb2 and pi2 boards to the list of platforms
- Split BigTreeTech CB2 and Pi2 into two device trees using common dtsi
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/

---
Ivan Sergeev (2):
dt-bindings: arm: rockchip: Add BigTreeTech CB2 and Pi2
arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2

 .../devicetree/bindings/arm/rockchip.yaml          |  11 +
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../dts/rockchip/rk3566-bigtreetech-cb2-manta.dts  |  10 +
 .../boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi  | 943 +++++++++++++++++++++
 .../boot/dts/rockchip/rk3566-bigtreetech-pi2.dts   |  10 +
 5 files changed, 976 insertions(+)

---
base-commit: d6ef8b40d075c425f548002d2f35ae3f06e9cf96
change-id: 20241224-bigtreetech-cb2-18944b349916

Best regards,

Signature · 1 line
Ivan Sergeev <[email protected]>
#1 lore raw

PATCH v4 1/2 dt-bindings: arm: rockchip: Add BigTreeTech CB2 and Pi2

BigTreeTech CB2 and Pi2 are Rockchip RK3566 based boards

---
 Documentation/devicetree/bindings/arm/rockchip.yaml | 11 +++++++++++
 1 file changed, 11 insertions(+)
Documentation/devicetree/bindings/arm/rockchip.yaml +11 -0
index 753199a12923fadaa48c407a8e55e7854db7203e..349453b1676bfac45abf5cd49d6bd9f847281213 100644
@@ -81,6 +81,17 @@ properties:
           - const: azw,beelink-a1
           - const: rockchip,rk3328
 
+      - description: BigTreeTech CB2 Manta M4/8P
+        items:
+          - const: bigtreetech,cb2-manta
+          - const: bigtreetech,cb2
+          - const: rockchip,rk3566
+
+      - description: BigTreeTech Pi 2
+        items:
+          - const: bigtreetech,pi2
+          - const: rockchip,rk3566
+
       - description: bq Curie 2 tablet
         items:
           - const: mundoreader,bq-curie2
Signature · 1 line
2.45.2
#2 lore raw

PATCH v4 2/2 arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2

In reply to Ivan Sergeev

BigTreeTech CB2 and Pi2 share a lot of hardware configuration, so a common dtsi file was used to define common nodes and properties. This is similar to how BigTreeTech CB1 and Pi are implemented.

---
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../dts/rockchip/rk3566-bigtreetech-cb2-manta.dts  |  10 +
 .../boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi  | 943 +++++++++++++++++++++
 .../boot/dts/rockchip/rk3566-bigtreetech-pi2.dts   |  10 +
 4 files changed, 965 insertions(+)
arch/arm64/boot/dts/rockchip/Makefile +2 -0
index 86cc418a2255cdc22f1d503e9519d2d9572d4e9d..99266316a6003e5a8a4dadbd05b8453beb2c3efc 100644
@@ -111,6 +111,8 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-box-demo.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lckfb-tspi.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-lubancat-1.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-nanopi-r3s.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-cb2-manta.dtb
+dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-bigtreetech-pi2.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-bpi-r2-pro.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-evb1-v10.dtb
 dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3568-fastrhino-r66s.dtb
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dts new file +10 -0
new file mode 100644
index 0000000000000000000000000000000000000000..97415d099d886aba97c9b652af3d03573f5e74d7
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-bigtreetech-cb2.dtsi"
+
+/ {
+	model = "BigTreeTech CB2";
+	compatible = "bigtreetech,cb2-manta", "bigtreetech,cb2", "rockchip,rk3566";
+};
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +943 -0

943 lines not on this page · raw message

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dts new file +10 -0
new file mode 100644
index 0000000000000000000000000000000000000000..7cd444caa18bc9f6cf7afe04a777aecdce2fc93e
@@ -0,0 +1,10 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+
+/dts-v1/;
+
+#include "rk3566-bigtreetech-cb2.dtsi"
+
+/ {
+	model = "BigTreeTech Pi 2";
+	compatible = "bigtreetech,pi2", "rockchip,rk3566";
+};
Signature · 1 line
2.45.2
#3 lore raw
Quoted 4 lines · Ivan Sergeev

BigTreeTech CB2 and Pi2 share a lot of hardware configuration, so a common dtsi file was used to define common nodes and properties. This is similar to how BigTreeTech CB1 and Pi are implemented.

...

Quoted 14 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +14 -0
+			vcc3v3_sd: SWITCH_REG2 {
+				regulator-always-on;
+				regulator-boot-on;
+				regulator-name = "vcc3v3_sd";
+				regulator-state-mem {
+					regulator-off-in-suspend;
+				};
+			};
+		};
+
+		codec {
+			rockchip,mic-in-differential;
+		};
+	};

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 553

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+};
+
+&i2c2 {
+	pinctrl-0 = <&i2c2m1_xfer>;
+};
+
+&i2c3 {
+	status = "okay";
+
+	tft_tp: ns2009@48 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+		compatible = "ti,tsc2007";
+		reg = <0x48>;
+		status = "okay";
+		ti,x-plate-ohms = <660>;
+		ti,rt-thr = <3000>;
+		ti,fuzzx = <32>;
+		ti,fuzzy = <16>;
+	};
+};
+

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 573

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+&i2s0_8ch {
+	status = "okay";
+};
+
+&i2s1_8ch {
+	pinctrl-names = "default";
+	pinctrl-0 = <&i2s1m0_sclktx
+			&i2s1m0_lrcktx
+			&i2s1m0_sdi0
+			&i2s1m0_sdo0>;

Why this can't be one line?

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 581

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +8 -0
+	rockchip,trcm-sync-tx-only;
+	status = "okay";
+};
+
+&spi1 {
+	pinctrl-0 = <&spi1m1_cs0 &spi1m1_pins>;
+
+	can_mcp2515: can-mcp2515@0 {

Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

Review

Quoted 1 line
(quoted diff) +1 -0
+		status = "disabled";

Why? Anyway, srtatus is never the first property for new nodes.

Quoted 40 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +40 -0
+		compatible = "microchip,mcp2515";
+		reg = <0x00>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
+		spi-max-frequency = <10000000>;
+		clocks = <&can_mcp2515_osc>;
+		vdd-supply = <&vcc3v3_sys>;
+		xceiver-supply = <&vcc3v3_sys>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&mcp2515_int_pin>;
+	};
+};
+
+&spi3 {
+	pinctrl-0 = <&spi3m1_cs0 &spi3m1_pins>;
+};
+
+&pcie2x1 {
+	reset-gpios = <&gpio1 RK_PB2 GPIO_ACTIVE_HIGH>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pcie_reset_h>;
+	vpcie3v3-supply = <&vcc3v3_pcie>;
+	status = "okay";
+};
+
+&pinctrl {
+	wireless-bluetooth {
+		uart1_gpios: uart1-gpios {
+			rockchip,pins = <2 RK_PB5 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	sd {
+		sdmmc0_pwr_h: sdmmc0-pwr-h {
+			rockchip,pins = <0 RK_PB0 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	mxc6655xa {
+		mxc6655xa_irq_gpio: mxc6655xa_irq_gpio {

...

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +8 -0
+	};
+
+	bt {
+		bt_enable: bt-enable-h {
+			rockchip,pins = <2 RK_PB7 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+
+		bt_host_wake: bt-host-wake-l {

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 732

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+			rockchip,pins = <2 RK_PC1 RK_FUNC_GPIO &pcfg_pull_down>;
+		};
+
+		bt_wake: bt-wake-l {
+			rockchip,pins = <2 RK_PC0 RK_FUNC_GPIO &pcfg_pull_none>;
+		};
+	};
+
+	mcp2515_int_pin {
+		mcp2515_int_pin: mcp2515_in_pin {

Don't use underscore. See DTS coding style.

Quoted 6 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +6 -0
+			rockchip,pins = <4 RK_PA3 RK_FUNC_GPIO &pcfg_pull_up>;
+		};
+	};
+};
+
+&pmu_io_domains {

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 748

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+		status = "okay";
+		pmuio1-supply = <&vcc3v3_pmu>;
+		pmuio2-supply = <&vcc3v3_pmu>;
+		vccio1-supply = <&vcc_3v3>;
+		vccio2-supply = <&vcc_1v8>;
+		vccio3-supply = <&vccio_sd>;
+		vccio4-supply = <&vcc_1v8>;
+		vccio5-supply = <&vcc_3v3>;
+		vccio6-supply = <&vcc_3v3>;
+		vccio7-supply = <&vcc_3v3>;

Messed indentation

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 795

Quoted 8 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +8 -0
+
+&sdmmc0 {
+	max-frequency = <150000000>;
+	bus-width = <4>;
+	cap-mmc-highspeed;
+	cap-sd-highspeed;
+	disable-wp;
+	//sd-uhs-sdr104;

Drop dead code

Quoted 13 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +13 -0
+	vmmc-supply = <&vcc_sd>;
+	vqmmc-supply = <&vccio_sd>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc0_bus4 &sdmmc0_clk &sdmmc0_cmd &sdmmc0_det>;
+	status = "okay";
+};
+
+&sdmmc1 {
+	/* WiFi & BT combo module AMPAK AP6256 */
+	#address-cells = <1>;
+	#size-cells = <0>;
+	max-frequency = <150000000>;
+	bus-width = <4>;

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 818

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+	disable-wp;
+	cap-sd-highspeed;
+	cap-sdio-irq;
+	keep-power-in-suspend;
+	mmc-pwrseq = <&sdio_pwrseq>;
+	non-removable;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sdmmc1_bus4 &sdmmc1_cmd &sdmmc1_clk>;
+	sd-uhs-sdr104;
+	status = "okay";

Status is always the last property... or the first in overrides, but not middle.

Quoted 20 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +20 -0
+	rockchip,default-sample-phase = <90>;
+
+	sdio-wifi@1 {
+		compatible = "brcm,bcm4329-fmac";
+		reg = <1>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <9 IRQ_TYPE_LEVEL_HIGH>;
+		interrupt-names = "host-wake";
+		pinctrl-names = "default";
+		pinctrl-0 = <&wifi_host_wake>;
+		brcm,drive-strength = <10>;
+	};
+};
+
+&sfc {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	status = "okay";
+};
+

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 848

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+&tsadc {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+	pinctrl-names = "default";
+	pinctrl-0 = <&uart1m0_xfer &uart1m0_ctsn &uart1m0_rtsn>;
+	uart-has-rtscts;
+	dma-names = "tx\0rx";

Hm? NUL byte?

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi line 858

Quoted 10 lines
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi new file +10 -0
+
+	bluetooth {
+		compatible = "brcm,bcm4345c5";
+		clocks = <&rk809 1>;
+		clock-names = "lpo";
+		device-wakeup-gpios = <&gpio2 RK_PC0 GPIO_ACTIVE_HIGH>;
+		host-wakeup-gpios = <&gpio2 RK_PC1 GPIO_ACTIVE_HIGH>;
+		shutdown-gpios = <&gpio2 RK_PB7 GPIO_ACTIVE_HIGH>;
+		//pinctrl-names = "default";
+		//pinctrl-0 = <&bt_host_wake &bt_wake &bt_enable>;

Drop dead code

Best regards,
Krzysztof

#4 lore raw
In reply to Ivan Sergeev
Quoted 37 lines · Ivan Sergeev

BigTreeTech CB2 and Pi2 are Rockchip RK3566 SoM and SBC boards made by BigTreeTech for the intent of using as a 3d printer control board. It is a successor to the Allwinner H616-based BigTreeTech CB1 and Pi, so the device trees for CB2 and Pi2 are also done in the same manner: the common nodes and properties are put into a dtsi file that the board-specific device trees include.

Changes in v4:
- Removed invalid i2c,ignore-nak properties
- Set #address-cells and size-cells on sdmmc1
- Fixed phy-supply properties of usb host nodes
- Link to v3: https://lore.kernel.org/r/[email protected]

Changes in v3:
- Proper formatting and patch series sending (using b4)
- Converted spaces to tab indentation in the dtsi file
- Fixed empty line where the license identifier should be
- Link to v2 1/2: https://lore.kernel.org/linux-rockchip/[email protected]/
- Link to v2 2/2: https://lore.kernel.org/linux-rockchip/[email protected]/

Changes in v2:
- Added bigtreetech cb2 and pi2 boards to the list of platforms
- Split BigTreeTech CB2 and Pi2 into two device trees using common dtsi
- Link to v1: https://lore.kernel.org/linux-rockchip/[email protected]/

---
Ivan Sergeev (2):
dt-bindings: arm: rockchip: Add BigTreeTech CB2 and Pi2
arm64: dts: rockchip: Add BigTreeTech CB2 and Pi2

 .../devicetree/bindings/arm/rockchip.yaml          |  11 +
 arch/arm64/boot/dts/rockchip/Makefile              |   2 +
 .../dts/rockchip/rk3566-bigtreetech-cb2-manta.dts  |  10 +
 .../boot/dts/rockchip/rk3566-bigtreetech-cb2.dtsi  | 943 +++++++++++++++++++++
 .../boot/dts/rockchip/rk3566-bigtreetech-pi2.dts   |  10 +
 5 files changed, 976 insertions(+)
Quoted 10 lines

---
base-commit: d6ef8b40d075c425f548002d2f35ae3f06e9cf96
change-id: 20241224-bigtreetech-cb2-18944b349916

Best regards,
--
Ivan Sergeev <[email protected]>

My bot found new DTB warnings on the .dts files added or changed in this series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y rockchip/rk3566-bigtreetech-cb2-manta.dtb rockchip/rk3566-bigtreetech-pi2.dtb' for [email protected]:

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007'] arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007'] arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: host-port: phy-supply: 'oneOf' conditional failed, one must be fixed:

	[[181, 182]] is not of type 'object'
	[181, 182] is too long
	from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: host-port: phy-supply: 'oneOf' conditional failed, one must be fixed:
	[[184, 185]] is not of type 'object'
	[184, 185] is too long
	from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: host-port: phy-supply: 'oneOf' conditional failed, one must be fixed:
	[[181, 182]] is not of type 'object'
	[181, 182] is too long
	from schema $id: http://devicetree.org/schemas/dt-core.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: host-port: phy-supply: 'oneOf' conditional failed, one must be fixed:
	[[184, 185]] is not of type 'object'
	[184, 185] is too long
	from schema $id: http://devicetree.org/schemas/dt-core.yaml#

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#

#5 lore raw

Preparing a v5, fixed the phy-supply for usb nodes, but I have questions for the other warnings.

Quoted 2 lines

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007'] arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007']

Using grep -r 'ti,tsc2007' Documentation I can find a schema file for that compatible value: Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt Is it an invalid value or not a proper schema?

Quoted 8 lines

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#

I don't understand how these nodes differ in structure dcompared to other pinctrl nodes. Am I missing somethign taht is causing this warning?

#6 lore raw
Quoted 9 lines · Ivan Sergeev

Preparing a v5, fixed the phy-supply for usb nodes, but I have questions for the other warnings.

Quoted 2 lines

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007'] arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: /i2c@fe5c0000/ns2009@48: failed to match any schema with compatible: ['ti,tsc2007']

Using grep -r 'ti,tsc2007' Documentation I can find a schema file for that compatible value: Documentation/devicetree/bindings/input/touchscreen/tsc2007.txt Is it an invalid value or not a proper schema?

It's just not a schema. Warning can be ignored but you can also convert TXT to schema in separate patch.

Quoted 10 lines
Quoted 9 lines

arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-pi2.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: wireless-bluetooth: uart1-gpios: {'rockchip,pins': [[2, 13, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#
arch/arm64/boot/dts/rockchip/rk3566-bigtreetech-cb2-manta.dtb: touch: touch-gpio: {'rockchip,pins': [[0, 13, 0, 189], [0, 14, 0, 187]]} is not of type 'array'
from schema $id: http://devicetree.org/schemas/gpio/gpio-consumer.yaml#

Quoted 3 lines

I don't understand how these nodes differ in structure dcompared to other pinctrl nodes. Am I missing somethign taht is causing this warning?

Wrong naming. gpio and gpios are only GPIOs, not pinctrl. That's why your SoC pinctrl schema is supposed to have strict suffix or prefix naming for such pincfg nodes :/

Best regards,
Krzysztof