Skip to contentSkip to conversation

Add support for rgmii-id phy mode

PATCH In review Boon Khai Ng 2 participants 3 messages Jan 17, 2025 – Jan 22, 2025 Network drivers

lore
Share & tools
lore
#0 lore raw

cover Add support for rgmii-id phy mode

An issue was identified where selecting the phy-mode as rgmii-id in the device tree source (DTS) would cause the dwc_eth_xgmac_socfpga driver to raise an unsupported phy mode error.

From the MAC controller's perspective, the rgmii and rgmii-id phy modes are effectively identical. To address this, both modes will now be configured to rgmii in the MAC controller.

This change ensures that the rgmii-id phy mode is properly supported without error.

Boon Khai Ng (1):
net: dwc_eth_xgmac_socfpga: Add support for rgmii-id mode.

 drivers/net/dwc_eth_xgmac_socfpga.c | 1 +
 1 file changed, 1 insertion(+)
Signature · 1 line
2.26.2
#1 lore raw

PATCH 1/1 net: dwc_eth_xgmac_socfpga: Add support for rgmii-id mode.

An issue was identified where selecting the phy-mode as rgmii-id in the device tree source (DTS) would cause the dwc_eth_xgmac_socfpga driver to raise an unsupported phy mode error.

From the MAC controller's perspective, the rgmii and rgmii-id phy modes are effectively identical. To address this, both modes will now be configured to rgmii in the MAC controller.

This change ensures that the rgmii-id phy mode is properly supported without error.

---
 drivers/net/dwc_eth_xgmac_socfpga.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dwc_eth_xgmac_socfpga.c +1 -0
index 87fb7e887e..1864187c17 100644
@@ -80,6 +80,7 @@ static int xgmac_probe_resources_socfpga(struct udevice *dev)
 		modereg = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_ID:
 		modereg = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RGMII;
 		break;
 	default:
Signature · 1 line
2.26.2
Reviewed-by on v1 1/1
#2 lore raw

RE: [XGMAC RGMII-ID fix v1 1/1] net: dwc_eth_xgmac_socfpga: Add support for rgmii-id mode.

Quoted 54 lines

-----Original Message-----
From: Ng, Boon Khai <[email protected]>
Sent: Friday, January 17, 2025 2:56 PM
To: Uboot Open List <[email protected]>
Cc: Chee, Tien Fong <[email protected]>; Hea, Kok Kiang <[email protected]>; Maniyam, Dinesh <[email protected]>; Yuslaimi, Alif Zakuan <[email protected]>; Zamri, Muhammad Hazim Izzat <[email protected]>; Tien Fong Chee <[email protected]>; Kok Kiang Hea <[email protected]>; Dinesh Maniyam <[email protected]>; Alif Zakuan <[email protected]>; Boon Khai Ng <[email protected]>; Muhammad Hazim <[email protected]>; Joe Hershberger <[email protected]>; Ramon Fried <[email protected]>; Tom Rini <[email protected]>; Simon Glass <[email protected]>; Ng, Boon Khai <[email protected]>
Subject: [XGMAC RGMII-ID fix v1 1/1] net: dwc_eth_xgmac_socfpga: Add support for rgmii-id mode.

An issue was identified where selecting the phy-mode as rgmii-id in the device tree source (DTS) would cause the dwc_eth_xgmac_socfpga driver to raise an unsupported phy mode error.

From the MAC controller's perspective, the rgmii and rgmii-id phy modes are effectively identical. To address this, both modes will now be configured to rgmii in the MAC controller.

This change ensures that the rgmii-id phy mode is properly supported without error.

---
 drivers/net/dwc_eth_xgmac_socfpga.c | 1 +
 1 file changed, 1 insertion(+)
drivers/net/dwc_eth_xgmac_socfpga.c +1 -0
index 87fb7e887e..1864187c17 100644
@@ -80,6 +80,7 @@ static int xgmac_probe_resources_socfpga(struct
 udevice *dev)
 		modereg = SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RMII;
 		break;
 	case PHY_INTERFACE_MODE_RGMII:
+	case PHY_INTERFACE_MODE_RGMII_ID:
 		modereg =
 SYSMGR_EMACGRP_CTRL_PHYSEL_ENUM_RGMII;
drivers/net/dwc_eth_xgmac_socfpga.c +0 -1
 		break;
 	default:
--
Quoted 1 line

2.26.2

Best regards,
Tien Fong