platform/x86: Do not include <linux/fb.h>
Subsystems (2)
cover platform/x86: Do not include <linux/fb.h>
These two drivers include <linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.
Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>
drivers/platform/x86/compal-laptop.c | 1 - drivers/platform/x86/thinkpad_acpi.c | 1 - 2 files changed, 2 deletions(-)
Signature · 1 line
2.48.1
PATCH 1/2 platform/x86: compal-laptop: Do not include <linux/fb.h>
Nothing in this source file requires <linux/fb.h>. Remove the include statement.
--- drivers/platform/x86/compal-laptop.c | 1 - 1 file changed, 1 deletion(-)
drivers/platform/x86/compal-laptop.c +0 -1
@@ -69,7 +69,6 @@#include <linux/hwmon-sysfs.h> #include <linux/power_supply.h> #include <linux/sysfs.h> -#include <linux/fb.h> #include <acpi/video.h> /* ======= */
Signature · 1 line
2.48.1
PATCH 2/2 platform/x86: thinkpad-acpi: Do not include <linux/fb.h>
In reply to Thomas ZimmermannNothing in this source file requires <linux/fb.h>. Remove the include statement.
--- drivers/platform/x86/thinkpad_acpi.c | 1 - 1 file changed, 1 deletion(-)
drivers/platform/x86/thinkpad_acpi.c +0 -1
@@ -39,7 +39,6 @@#include <linux/bitops.h> #include <linux/delay.h> #include <linux/dmi.h> -#include <linux/fb.h> #include <linux/freezer.h> #include <linux/hwmon.h> #include <linux/hwmon-sysfs.h>
Signature · 1 line
2.48.1
Hi,
Quoted 6 lines · Thomas Zimmermann
These two drivers include <
linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>
Thanks, series looks good to me:
for the series.
Regards,
Hans
Ilpo Järvinen
maintainerQuoted 8 lines · Thomas Zimmermann
These two drivers include <
linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>[...]
Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.
The list of commits applied:
[1/2] platform/x86: compal-laptop: Do not include <linux/fb.h>
commit: e87af94c0794ae19c7ed58996d847f1466f67446
[2/2] platform/x86: thinkpad-acpi: Do not include <linux/fb.h>
commit: 1bcfd16b12265ff29c2e2d8c977a9dcbf2649020--
i.