Skip to contentSkip to conversation

platform/x86: Do not include <linux/fb.h>

PATCH In review Thomas Zimmermann 3 participants 5 messages Jan 31, 2025 – Feb 3, 2025

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover platform/x86: Do not include <linux/fb.h>

These two drivers include <linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.

Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>

 drivers/platform/x86/compal-laptop.c | 1 -
 drivers/platform/x86/thinkpad_acpi.c | 1 -
 2 files changed, 2 deletions(-)
Signature · 1 line
2.48.1
#1 lore raw

PATCH 1/2 platform/x86: compal-laptop: Do not include <linux/fb.h>

Nothing in this source file requires <linux/fb.h>. Remove the include statement.

---
 drivers/platform/x86/compal-laptop.c | 1 -
 1 file changed, 1 deletion(-)
drivers/platform/x86/compal-laptop.c +0 -1
index 58754bc5b5b17..abbebd4bfb151 100644
@@ -69,7 +69,6 @@
 #include <linux/hwmon-sysfs.h>
 #include <linux/power_supply.h>
 #include <linux/sysfs.h>
-#include <linux/fb.h>
 #include <acpi/video.h>
 
 /* ======= */
Signature · 1 line
2.48.1
#2 lore raw

PATCH 2/2 platform/x86: thinkpad-acpi: Do not include <linux/fb.h>

In reply to Thomas Zimmermann

Nothing in this source file requires <linux/fb.h>. Remove the include statement.

Cc Henrique de Moraes Holschuh <[email protected]>
---
 drivers/platform/x86/thinkpad_acpi.c | 1 -
 1 file changed, 1 deletion(-)
drivers/platform/x86/thinkpad_acpi.c +0 -1
index 2cfb2ac3f465a..b078bbcbc29c8 100644
@@ -39,7 +39,6 @@
 #include <linux/bitops.h>
 #include <linux/delay.h>
 #include <linux/dmi.h>
-#include <linux/fb.h>
 #include <linux/freezer.h>
 #include <linux/hwmon.h>
 #include <linux/hwmon-sysfs.h>
Signature · 1 line
2.48.1
Reviewed-by on the v1 series
#3 lore raw
In reply to Thomas Zimmermann

Hi,

Quoted 6 lines · Thomas Zimmermann

These two drivers include <linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.

Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>

Thanks, series looks good to me:

for the series.

Regards,

Hans

maintainer
#4 lore raw
In reply to Thomas Zimmermann
Quoted 8 lines · Thomas Zimmermann

These two drivers include <linux/fb.h>, presumably for backlight support. It's no longer need, so remove the include statement.

Thomas Zimmermann (2):
platform/x86: compal-laptop: Do not include <linux/fb.h> platform/x86: thinkpad-acpi: Do not include <linux/fb.h>

[...]

Thank you for your contribution, it has been applied to my local review-ilpo-next branch. Note it will show up in the public platform-drivers-x86/review-ilpo-next branch only once I've pushed my local branch there, which might take a while.

The list of commits applied:
[1/2] platform/x86: compal-laptop: Do not include <linux/fb.h>

      commit: e87af94c0794ae19c7ed58996d847f1466f67446
[2/2] platform/x86: thinkpad-acpi: Do not include <linux/fb.h>
      commit: 1bcfd16b12265ff29c2e2d8c977a9dcbf2649020

--
i.