Fix RG35XX Battery Charging Issues

From: Chris Morgan <[email protected]>

Correct the fault handling for the AXP717 by changing the i2c write from regmap_update_bits() to regmap_write_bits(). The update bits function does not work properly on a RW1C register where we must write a 1 back to an existing register to clear it.

Additionally, as part of this testing I confirmed the behavior of errors reappearing, so remove comment about assumptions.

Fixes 6625767049c2 ("power: supply: axp20x_battery: add support for AXP717")

Signed-off-by Chris Morgan <[email protected]>

From: Chris Morgan <[email protected]>

Add the vendor specific boolean property of x-powers,no-thermistor. This property optionally describes hardware where no thermistor is present on the battery and is specific to the AXP717. In rare circumstances this value can be set incorrectly in the efuse of the PMIC, and if it is not hard-coded the device will fail to charge.

Signed-off-by Chris Morgan <[email protected]>

---
 .../x-powers,axp20x-battery-power-supply.yaml | 22 ++++++++++++++++---
 1 file changed, 19 insertions(+), 3 deletions(-)

Documentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml +0 -3

index 5ccd375eb294..e0f134a13f7e 100644
@@ -14,9 +14,6 @@ maintainers:
   - Chen-Yu Tsai <[email protected]>
   - Sebastian Reichel <[email protected]>
 
-allOf:
-  - $ref: power-supply.yaml#
-
 properties:
   compatible:
     oneOf:

@@ -35,7 +32,26 @@ properties:
       this gauge.
     $ref: /schemas/types.yaml#/definitions/phandle
 

From: Chris Morgan <[email protected]>

Add AXP717_TS_PIN_CFG (register 0x50) to the table of writeable registers so that the temperature sensor can be configured by the battery driver.

Signed-off-by Chris Morgan <[email protected]>

---
 drivers/mfd/axp20x.c       | 2 +-
 include/linux/mfd/axp20x.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

drivers/mfd/axp20x.c +0 -0

index cff56deba24f..baf51dea98b0 100644

drivers/mfd/axp20x.c +0 -0

        regmap_reg_range(AXP717_IRQ0_STATE, AXP717_IRQ4_STATE),
        regmap_reg_range(AXP717_ICC_CHG_SET, AXP717_CV_CHG_SET),
        regmap_reg_range(AXP717_DCDC_OUTPUT_CONTROL, AXP717_CPUSLDO_CONTROL),

include/linux/mfd/axp20x.h +1 -1

index c3df0e615fbf..3c5aecf1d4b5 100644
@@ -137,6 +137,7 @@ enum axp20x_variants {
 #define AXP717_IRQ2_STATE              0x4a
 #define AXP717_IRQ3_STATE              0x4b
 #define AXP717_IRQ4_STATE              0x4c
+#define AXP717_TS_PIN_CFG              0x50
 #define AXP717_ICC_CHG_SET             0x62
 #define AXP717_ITERM_CHG_SET           0x63
 #define AXP717_CV_CHG_SET              0x64
--

2.43.0

From: Chris Morgan <[email protected]>

Allow a boolean property of "x-powers,no-thermistor" to specify devices where the ts pin is not connected to anything. This works around an issue found with some devices where the efuse is not programmed correctly from the factory or when the register gets set erroneously.

Signed-off-by Chris Morgan <[email protected]>

---
 drivers/power/supply/axp20x_battery.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

drivers/power/supply/axp20x_battery.c +3 -0

index 3c3158f31a48..345a1bbe50ad 100644
@@ -89,6 +89,8 @@
 #define AXP717_BAT_CC_MIN_UA           0
 #define AXP717_BAT_CC_MAX_UA           3008000
 
+#define AXP717_TS_PIN_DISABLE          BIT(4)
+
 struct axp20x_batt_ps;
 
 struct axp_data {

@@ -117,6 +119,7 @@ struct axp20x_batt_ps {
        /* Maximum constant charge current */
        unsigned int max_ccc;
        const struct axp_data   *data;
+       bool ts_disable;
 };
 
 static int axp20x_battery_get_max_voltage(struct axp20x_batt_ps *axp20x_batt,

drivers/power/supply/axp20x_battery.c +8 -1

+        */
+       if (axp_batt->ts_disable) {
+               regmap_update_bits(axp_batt->regmap,
+                                  AXP717_TS_PIN_CFG,
+                                  AXP717_TS_PIN_DISABLE,
+                                  AXP717_TS_PIN_DISABLE);
+       }
+
        if (vmin > 0 && axp717_set_voltage_min_design(axp_batt, vmin))
                dev_err(&pdev->dev,
                        "couldn't set voltage_min_design\n");
--

2.43.0

From: Chris Morgan <[email protected]>

The Anbernic RG35XX devices sometimes fail to charge when the register for the battery temperature sensor is set to the incorrect value either by user error or an incorrectly programmed efuse. Allow users to hard-code if a temperature sensor is not present (which is the case for all Anbernic RGxx series devices) to prevent this issue from causing problems. Additionally, a bug was identified with the handling of PMU faults while this fix was being tested.

Chris Morgan (5):
power: supply: axp20x_battery: Fix fault handling for AXP717
dt-bindings: power: supply: axp20x-battery: Add x-powers,no-thermistor
mfd: axp20x: AXP717: Add AXP717_TS_PIN_CFG to writeable regs

power: supply: axp20x_battery: Update temp sensor for AXP717 from
device tree

arm64: dts: allwinner: rg35xx: Add no-thermistor property for battery

 .../x-powers,axp20x-battery-power-supply.yaml | 22 ++++++--
 .../sun50i-h700-anbernic-rg35xx-2024.dts      |  1 +
 drivers/mfd/axp20x.c                          |  2 +-
 drivers/power/supply/axp20x_battery.c         | 50 +++++++++++++------
 include/linux/mfd/axp20x.h                    |  1 +
 5 files changed, 56 insertions(+), 20 deletions(-)

--
2.43.0

From: Chris Morgan <[email protected]>

The Anbernic RG35XX devices sometimes fail to charge when the register for the battery temperature sensor is set to the incorrect value either by user error or an incorrectly programmed efuse. Allow users to hard-code if a temperature sensor is not present (which is the case for all Anbernic RGxx series devices) to prevent this issue from causing problems. Additionally, a bug was identified with the handling of PMU faults while this fix was being tested.

[...]