Skip to content

Fix RG35XX Battery Charging Issues

Chris Morgan linux-devicetree linux-pm linux-sunxi 2 versions – Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest4 patches 9 repliesApplied
  2. v15 patches 6 repliesApplied

Changes in v2 from the cover letter

- Updated cover letter to note that the MFD updates are build dependencies.
- Removed patch for "power: supply: axp20x_battery: Fix fault handling for AXP717" as it has already been accepted upstream.
- Simplified binding documentation with a "not" statement.
- Corrected writeable regs in MFD driver.
- Updated comment in driver to note a correctly defined device tree with a simple-battery node is required to apply the thermistor fix.

Patches in v2 Applied

#Subject and filesSizeRepliesApplied
1/4dt-bindings: power: supply: axp20x-battery: Add x-powers,no-thermistorDocumentation/devicetree/bindings/power/supply/x-powers,axp20x-battery-power-supply.yaml+17 -31 reply
2/4mfd: axp20x: AXP717: Add AXP717_TS_PIN_CFG to writeable regsdrivers/mfd/axp20x.c include/linux/mfd/axp20x.h+2 -03 replies
3/4power: supply: axp20x_battery: Update temp sensor for AXP717 from device treedrivers/power/supply/axp20x_battery.c+21 -02 replies
4/4arm64: dts: allwinner: rg35xx: Add no-thermistor property for batteryarch/arm64/boot/dts/allwinner/sun50i-h700-anbernic-rg35xx-2024.dts+1 -01 reply

Reviews trailers per patch

3 of 4 patches have a Reviewed-by or Acked-by.

PatchKrzysztof KozlowskiPhilippe SimonsSebastian ReichelJernej Skrabec
1/4R-b A-b
2/4
3/4T-b A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v2 thread

Cover letter [PATCH V2 0/4] Fix RG35XX Battery Charging Issues

From: Chris Morgan <[email protected]>

The Anbernic RG35XX devices sometimes fail to charge when the register for the battery temperature sensor is set to the incorrect value either by user error or an incorrectly programmed efuse. Allow users to hard-code if a temperature sensor is not present (which is the case for all Anbernic RGxx series devices) to prevent this issue from causing problems. Additionally, a bug was identified with the handling of PMU faults while this fix was being tested.

Note that the MFD updates to the writeable regs are required build dependencies of the battery fix, as it defines a register that was previously not defined or writeable.

Changes from V1:
- Updated cover letter to note that the MFD updates are build dependencies.
- Removed patch for "power: supply: axp20x_battery: Fix fault handling for AXP717" as it has already been accepted upstream.
- Simplified binding documentation with a "not" statement.
- Corrected writeable regs in MFD driver.
- Updated comment in driver to note a correctly defined device tree with a simple-battery node is required to apply the thermistor fix.

Chris Morgan (4):
dt-bindings: power: supply: axp20x-battery: Add
x-powers,no-thermistor
mfd: axp20x: AXP717: Add AXP717_TS_PIN_CFG to writeable regs
power: supply: axp20x_battery: Update temp sensor for AXP717 from
device tree
arm64: dts: allwinner: rg35xx: Add no-thermistor property for battery

 .../x-powers,axp20x-battery-power-supply.yaml | 20 +++++++++++++++---
 .../sun50i-h700-anbernic-rg35xx-2024.dts      |  1 +
 drivers/mfd/axp20x.c                          |  1 +
 drivers/power/supply/axp20x_battery.c         | 21 +++++++++++++++++++
 include/linux/mfd/axp20x.h                    |  1 +
 5 files changed, 41 insertions(+), 3 deletions(-)
Signature · 1 line
2.43.0